platform/upstream/coreclr.git
7 years agoI had unintentionally excluded RuntimeThread.cs when FeatureCoreClr is false. Since...
Koundinya Veluri [Fri, 14 Oct 2016 05:18:23 +0000 (22:18 -0700)]
I had unintentionally excluded RuntimeThread.cs when FeatureCoreClr is false. Since parts of Thread.cs were refactored into RuntimeThread, including RuntimeThread.cs always.

[tfs-changeset: 1633304]

7 years agoMerge pull request #7605 from sandreenko/core_rt_1982
sandreenko [Fri, 14 Oct 2016 03:54:57 +0000 (20:54 -0700)]
Merge pull request #7605 from sandreenko/core_rt_1982

Lower helper call inside PInvoke

7 years agoMerge pull request #7603 from pgavlin/FixInteropTest
Pat Gavlin [Thu, 13 Oct 2016 23:59:33 +0000 (16:59 -0700)]
Merge pull request #7603 from pgavlin/FixInteropTest

Fix a calling convention in SimpleStructNative.

7 years agoEnable DoStackSnapshot API on ARM to walk the current thread (#6933)
kvochko [Thu, 13 Oct 2016 22:17:08 +0000 (01:17 +0300)]
Enable DoStackSnapshot API on ARM to walk the current thread (#6933)

7 years agoLower helper call inside PInvoke
Sergey Andreenko [Thu, 13 Oct 2016 22:08:25 +0000 (15:08 -0700)]
Lower helper call inside PInvoke

Lowering can create a helper call. The helper call is inserted to the
part of the block, that was lowered. So the helper call should be
lowered independently.

7 years agoMerge pull request #2192 from dasMulli/random-seeding-improvements
Peter Marcu [Thu, 13 Oct 2016 21:55:50 +0000 (14:55 -0700)]
Merge pull request #2192 from dasMulli/random-seeding-improvements

System.Random: Parameterless constructor seeding improvement #1919

7 years agoMerge pull request #7602 from smile21prc/coreclr-perf
smile21prc [Thu, 13 Oct 2016 20:38:36 +0000 (13:38 -0700)]
Merge pull request #7602 from smile21prc/coreclr-perf

Make coreclr Windows perf run versionless on benchview binaries

7 years agoAdded Docs for Using Visual Studio to Edit and Debug in CoreCLR Repo (#7582)
Vance Morrison [Thu, 13 Oct 2016 20:10:12 +0000 (13:10 -0700)]
Added Docs for Using Visual Studio to Edit and Debug in CoreCLR Repo (#7582)

7 years agoMerge pull request #7600 from jkotas/master-UpdateDependencies
Jan Kotas [Thu, 13 Oct 2016 20:09:00 +0000 (13:09 -0700)]
Merge pull request #7600 from jkotas/master-UpdateDependencies

Update CoreClr, CoreFx to beta-24612-03, beta-24612-04, respectively

7 years agoMerge pull request #7593 from pgavlin/DisableGCStressTest
Pat Gavlin [Thu, 13 Oct 2016 19:38:43 +0000 (12:38 -0700)]
Merge pull request #7593 from pgavlin/DisableGCStressTest

Disable a test that is not compatible with GC stress.

7 years agoFix a calling convention in SimpleStructNative.
Pat Gavlin [Thu, 13 Oct 2016 19:35:48 +0000 (12:35 -0700)]
Fix a calling convention in SimpleStructNative.

The managed code expects `GetFptr` to have the `stdcall` calling
convention. Because of the mismatch, the JIT-generated code was not
cleaning up the stack after P/Invoking to this function on x86, which
was causing a failure during GC stress.

7 years agoMake coreclr Windows perf run versionless on benchview so they won't be broken by...
Smile Wei [Thu, 13 Oct 2016 18:59:21 +0000 (11:59 -0700)]
Make coreclr Windows perf run versionless on benchview so they won't be broken by benchview updates.

7 years agoUpdate tests to netcoreapp1.1
Jan Kotas [Thu, 13 Oct 2016 08:11:47 +0000 (01:11 -0700)]
Update tests to netcoreapp1.1

7 years agoDisable a test that is not compatible with GC stress.
Pat Gavlin [Wed, 12 Oct 2016 22:13:52 +0000 (15:13 -0700)]
Disable a test that is not compatible with GC stress.

This test fails under GCStress=0xC for all of RyuJIT/x86, legacy backend
x86, and JIT32.

7 years agoAddressed PR feedback.
dasMulli [Thu, 13 Oct 2016 06:19:52 +0000 (08:19 +0200)]
Addressed PR feedback.

7 years agoMerge pull request #7510 from kouvel/ApiThread
Koundinya Veluri [Thu, 13 Oct 2016 01:39:30 +0000 (18:39 -0700)]
Merge pull request #7510 from kouvel/ApiThread

Expose some members of the Thread class

7 years agoMerge pull request #7595 from dotnet-bot/from-tfs
Jan Kotas [Thu, 13 Oct 2016 00:55:53 +0000 (17:55 -0700)]
Merge pull request #7595 from dotnet-bot/from-tfs

Merge changes from TFS

7 years agoMerge pull request #7584 from sivarv/regressionTest
Sivarv [Wed, 12 Oct 2016 23:45:20 +0000 (16:45 -0700)]
Merge pull request #7584 from sivarv/regressionTest

Adding JIT regression test for the re-morph optimzation that transforms JIT_Stelem_Ref(a, null, i)  into a[i]=null.

7 years agoMerge pull request #7590 from smile21prc/coreclr-perf
smile21prc [Wed, 12 Oct 2016 23:23:04 +0000 (16:23 -0700)]
Merge pull request #7590 from smile21prc/coreclr-perf

Permanently fix benchview package version, and add code to produce perf-*-summary.xml on Linux

7 years agoMerge pull request #7563 from wateret/fix-7398
Carol Eidt [Wed, 12 Oct 2016 22:56:23 +0000 (15:56 -0700)]
Merge pull request #7563 from wateret/fix-7398

[ARM/Linux] Fix HFA unit test regression

7 years agoCleanup files excluded from CoreCLR build
Jan Kotas [Wed, 12 Oct 2016 22:26:51 +0000 (15:26 -0700)]
Cleanup files excluded from CoreCLR build

[tfs-changeset: 1633047]

7 years agoAddress feedback
Koundinya Veluri [Wed, 12 Oct 2016 22:06:42 +0000 (15:06 -0700)]
Address feedback

7 years agoMerge pull request #7585 from CarolEidt/Fix5699
Carol Eidt [Wed, 12 Oct 2016 22:05:51 +0000 (15:05 -0700)]
Merge pull request #7585 from CarolEidt/Fix5699

x86: adjust stack level at throw blocks

7 years agox86: adjust stack level at throw blocks
Carol Eidt [Wed, 12 Oct 2016 18:24:18 +0000 (11:24 -0700)]
x86: adjust stack level at throw blocks

When we don't have a frame pointer, we need to adjust the frame pointer before calling the throw helper.
I initially had some concern that we had some exposure from instruction reordering in the backend, but we don't do any reordering of the `GT_PUTARG_STK` nodes. I have added a note to sideeffects.h to call attention to the fact that we need to consider stack depth changes to be side effects, for future consideration should we start doing more general code motion.
For the more general issue, I have extracted the code from codegenlegacy.cpp that does the stack adjustment, and am now unconditionally calling it from both codegenlegacy.cpp and codegenxarch.cpp.

Fix #5699

7 years agoReturn false from IsMarshalByRefImpl/IsContextfulImpl when remoting is not supported...
Jan Kotas [Wed, 12 Oct 2016 21:39:43 +0000 (14:39 -0700)]
Return false from IsMarshalByRefImpl/IsContextfulImpl when remoting is not supported (#7583)

Remove references to types have been moved to corefx in the build
Consolidate FEATURE_CORECLR ifdefs

7 years agoFail fast on a couple flaky tests to get crash dumps (#7588)
Sean Gillespie [Wed, 12 Oct 2016 21:38:37 +0000 (14:38 -0700)]
Fail fast on a couple flaky tests to get crash dumps (#7588)

7 years agoFix a tailcall test that fails with Ready-to-Run (#7586)
John Chen [Wed, 12 Oct 2016 21:02:45 +0000 (14:02 -0700)]
Fix a tailcall test that fails with Ready-to-Run (#7586)

The test case JIT/opt/Tailcall/TailcallVerifyWithPrefix has some methods that
depend on the JIT compiler doing automatic tail call. Since tail is not
supported with Ready-to-Run, the test case is modified to exclude such methods
from Ready-to-Run images.

7 years agoPort NullStream.CopyTo override from corert (#7589)
James Ko [Wed, 12 Oct 2016 21:02:21 +0000 (17:02 -0400)]
Port NullStream.CopyTo override from corert (#7589)

7 years agoUpdate CoreClr, CoreFx to beta-24612-03, beta-24612-04, respectively
dotnet-bot [Wed, 12 Oct 2016 20:30:02 +0000 (20:30 +0000)]
Update CoreClr, CoreFx to beta-24612-03, beta-24612-04, respectively

7 years agoMerge pull request #7557 from sandreenko/long_decomp_6925
sandreenko [Wed, 12 Oct 2016 20:16:55 +0000 (13:16 -0700)]
Merge pull request #7557 from sandreenko/long_decomp_6925

Use the existing operands for long decomposition #6925

7 years agoRun VS formatting (no semantic change) (#7587)
Vance Morrison [Wed, 12 Oct 2016 19:37:12 +0000 (12:37 -0700)]
Run VS formatting (no semantic change) (#7587)

7 years agoDebugging
Smile Wei [Wed, 28 Sep 2016 18:49:59 +0000 (11:49 -0700)]
Debugging

7 years agoMove StreamHelpers from corefx and refactor Stream and MemoryStream to use it (#7579)
James Ko [Wed, 12 Oct 2016 19:07:37 +0000 (15:07 -0400)]
Move StreamHelpers from corefx and refactor Stream and MemoryStream to use it (#7579)

7 years agoExpose members of Thread that hide base class members
Koundinya Veluri [Tue, 11 Oct 2016 22:31:12 +0000 (15:31 -0700)]
Expose members of Thread that hide base class members

7 years agoFix build issue
Koundinya Veluri [Tue, 11 Oct 2016 04:10:31 +0000 (21:10 -0700)]
Fix build issue

7 years agoFix build issue
Koundinya Veluri [Mon, 10 Oct 2016 21:02:46 +0000 (14:02 -0700)]
Fix build issue

7 years agoAddress feedback
Koundinya Veluri [Sat, 8 Oct 2016 21:35:02 +0000 (14:35 -0700)]
Address feedback

7 years agoExpose some members of the Thread class
Koundinya Veluri [Tue, 27 Sep 2016 20:14:24 +0000 (13:14 -0700)]
Expose some members of the Thread class

- Added RuntimeThread class that Thread derives from. An instance of RuntimeThread will be used by the Thread class in CoreFX to forward thread functionality to the runtime.
- Some functionality in the RuntimeThread could potentially be moved to CoreFX. In particular, some of thread creation and apartment state handling could probably be moved with some minimal help from the runtime. Leaving that refactoring for later.
- A few things are left unimplemented (for instance, apartment state handling doesn't work currently). That functionality will be enabled in a future change.

Part of dotnet/corefx#11632, dotnet/corefx#11638, dotnet/corefx#11635

7 years agoUnnecessary temp loc vars were deleted in DecomposeLong.
Sergey Andreenko [Fri, 7 Oct 2016 21:19:15 +0000 (14:19 -0700)]
Unnecessary temp loc vars were deleted in DecomposeLong.

Delete temp local variables from DecomposeNeg, DecomposeShift.
Remain local variables have several uses(DecomposeShift) or are call
arguments. Such variables can't be deleted.

7 years agoAdding JIT regression test for a re-morph optimization.
sivarv [Wed, 12 Oct 2016 17:49:03 +0000 (10:49 -0700)]
Adding JIT regression test for a re-morph optimization.

7 years agoProvide KeyValuePair.Create static factory method (#5755)
Daniel Cazzulino [Wed, 12 Oct 2016 17:37:46 +0000 (19:37 +0200)]
Provide KeyValuePair.Create static factory method (#5755)

Just like Tuple.Create cuts down the noise and annoyance
of having to specify all the Ts when you already have typed
values to provide, a similarly designed KeyValuePair.Create
factory method would make code that creates those pairs
(i.e. public APIs that expose IEnumerable{KeyValuePair}
significantly more concise and readable.

Fixes dotnet/corefx#2127

7 years agoMerge pull request #7576 from sandreenko/check_ready_to_run_for_protojit
sandreenko [Wed, 12 Oct 2016 17:35:29 +0000 (10:35 -0700)]
Merge pull request #7576 from sandreenko/check_ready_to_run_for_protojit

set ready to run flag for protojit

7 years agoExposing MarshalByRefObject (#7558)
Rama krishnan Raghupathy [Wed, 12 Oct 2016 17:34:09 +0000 (10:34 -0700)]
Exposing MarshalByRefObject (#7558)

7 years agoMerge pull request #7575 from sivarv/lsraStat
Sivarv [Wed, 12 Oct 2016 17:21:32 +0000 (10:21 -0700)]
Merge pull request #7575 from sivarv/lsraStat

Dump LSRA stats.

7 years agoEnable TextInfo APIs for netstandard 1.7 on Linux (#7568)
Tarek Mahmoud Sayed [Wed, 12 Oct 2016 16:29:55 +0000 (09:29 -0700)]
Enable TextInfo APIs for netstandard 1.7 on Linux (#7568)

* Enable TextInfo APIs for netstandard 1.7 on Linux

The change here is to enable the newly added netstandard 1.7 TextInfo APIs on Linux.

- moved the locale specific data to its own file Locale.Unic.cs
- added needed data to handle the TextInfo properties (e.g. codepages)
- created some helper methods in LocaleData classto handle accessing the locale data
- added the implementation for added APIs

* Fix some typos

7 years agoMerge pull request #7561 from BruceForstall/Fix7483
Bruce Forstall [Wed, 12 Oct 2016 15:15:25 +0000 (08:15 -0700)]
Merge pull request #7561 from BruceForstall/Fix7483

Fix assertion regarding byteable reg when ngen'ing desktop mscorlib

7 years agoFix assertion regarding byteable xor reg,reg when ngen'ing desktop mscorlib
Bruce Forstall [Tue, 11 Oct 2016 01:10:16 +0000 (18:10 -0700)]
Fix assertion regarding byteable xor reg,reg when ngen'ing desktop mscorlib

Fixes #7483

The issue is that TreeNodeInfoInitCmp() will, under certain circumstances,
perform a tree transformation of a child node into a TYP_UBYTE type. Since
the TreeNodeInfo walk is bottom-up, its children have already been processed,
and they don't get the "byteable" register processing that is as the end of
TreeNodeInfoInit().

I extracted that processing into a TreeNodeInfoInitCheckByteable() function that
can be called after the TreeNodeInfoInitCmp() transformation.

A better solution might be to extract this, and other, tree transformations into
the prior "lowering" pass, such that TreeNodeInfoInit() and friends will only
do register requirement annotation. But that would be considerably more complicated,
so I opted not to do that for now.

I also fixed up a bunch of comments.

7 years agoFix conflicting identity of System.IO.TextReader (#7578)
Jan Kotas [Wed, 12 Oct 2016 12:53:28 +0000 (05:53 -0700)]
Fix conflicting identity of System.IO.TextReader (#7578)

System.IO build was switched to use CoreFX copy of System.IO.TextReader and friends. These type have to be removed from CoreLib now to avoid type identity mismatches.

7 years agoset ready to run flag for protojit
Sergey Andreenko [Wed, 12 Oct 2016 01:16:34 +0000 (18:16 -0700)]
set ready to run flag for protojit

7 years agoDump LSRA stats.
sivarv [Tue, 11 Oct 2016 23:20:39 +0000 (16:20 -0700)]
Dump LSRA stats.

7 years agoMerge pull request #7571 from pgavlin/MkRefAnyFieldTypeX86
Pat Gavlin [Tue, 11 Oct 2016 23:41:21 +0000 (16:41 -0700)]
Merge pull request #7571 from pgavlin/MkRefAnyFieldTypeX86

Fix the type of the data field of a typed ref on x86.

7 years agoMerge pull request #7574 from DrewScoggins/runtestfix
Rahul Kumar [Tue, 11 Oct 2016 23:05:04 +0000 (16:05 -0700)]
Merge pull request #7574 from DrewScoggins/runtestfix

Fix runtest.cmd return code

7 years agoFix runtest.cmd return code
Drew Scoggins [Tue, 11 Oct 2016 22:51:49 +0000 (15:51 -0700)]
Fix runtest.cmd return code

When running the GenerateLayoutOnly command of runtest.cmd the script
should return zero instead of one.

7 years agoFix the type of the data field of a typed ref on x86.
Pat Gavlin [Tue, 11 Oct 2016 22:05:03 +0000 (15:05 -0700)]
Fix the type of the data field of a typed ref on x86.

This field should be of type byref; not treating it as such causes GC
holes when passing typed references.

7 years agoMerge pull request #7310 from wateret/for-7002-2
Carol Eidt [Tue, 11 Oct 2016 20:55:33 +0000 (13:55 -0700)]
Merge pull request #7310 from wateret/for-7002-2

[ARM] Generate direct call instructions for recursive calls

7 years agoMerge pull request #7565 from dotnet-bot/from-tfs
Pat Gavlin [Tue, 11 Oct 2016 20:28:43 +0000 (13:28 -0700)]
Merge pull request #7565 from dotnet-bot/from-tfs

Merge changes from TFS

7 years agoMerge pull request #7560 from pgavlin/StoreBlkGCHole
Pat Gavlin [Tue, 11 Oct 2016 18:25:40 +0000 (11:25 -0700)]
Merge pull request #7560 from pgavlin/StoreBlkGCHole

Disable emit{Enable,Disable}GC for x86.

7 years agoSemaphoreSlim performance improvement (#137)
ikopylov [Tue, 11 Oct 2016 17:02:38 +0000 (20:02 +0300)]
SemaphoreSlim performance improvement (#137)

* Waiters notification by the value of releaseCount (reduce the number of false-wakeups).

7 years agoUpdate Readme.md to lead you through basic repo workflow (#7552)
Vance Morrison [Tue, 11 Oct 2016 16:10:11 +0000 (09:10 -0700)]
Update Readme.md to lead you through basic repo workflow (#7552)

Update README.md to contain much more information about using the repo

7 years agoFix a build break in the ARM64 JIT.
Pat Gavlin [Tue, 11 Oct 2016 15:55:09 +0000 (08:55 -0700)]
Fix a build break in the ARM64 JIT.

[tfs-changeset: 1632696]

7 years agoMerge pull request #7562 from pgavlin/x86PreemptiveAssert
Pat Gavlin [Tue, 11 Oct 2016 15:26:02 +0000 (08:26 -0700)]
Merge pull request #7562 from pgavlin/x86PreemptiveAssert

Remove an overly fragile assertion.

7 years ago[ARM/Linux] Fix HFA unit test regression
Hanjoung Lee [Tue, 11 Oct 2016 05:45:46 +0000 (14:45 +0900)]
[ARM/Linux] Fix HFA unit test regression

Fix #7398

7 years agoRemove an overly fragile assertion.
Pat Gavlin [Tue, 11 Oct 2016 04:21:23 +0000 (21:21 -0700)]
Remove an overly fragile assertion.

The GC stress infrastructure contained an assertion that was meant to
help detect managed code running in preemptive mode. Unfortunately, this
assertion was derived from the set of instructions emitted by the JIT at
the time at which it was added. As such, it is now out of date.

Because a failure of this assertion does not necessarily indicate a
correctness bug and because it is onerous to keep up-to-date, remove it.

7 years agoRemove AllowPartiallyTrustedCallers from a test (#7555)
Michal Strehovský [Tue, 11 Oct 2016 01:56:09 +0000 (18:56 -0700)]
Remove AllowPartiallyTrustedCallers from a test (#7555)

Partial trust is not part of .NET Core.

7 years agoDisable emit{Enable,Disable}GC for x86.
Pat Gavlin [Tue, 11 Oct 2016 00:09:29 +0000 (17:09 -0700)]
Disable emit{Enable,Disable}GC for x86.

The GC info encoding for this platform does not permit marking
arbitrary regions of generated code as non-interruptible.

7 years agoMerge pull request #7518 from adiaaida/cmpByteable
Michelle McDaniel [Tue, 11 Oct 2016 00:21:07 +0000 (17:21 -0700)]
Merge pull request #7518 from adiaaida/cmpByteable

Force byteable register for CMP if op2 is CNS_INT

7 years agoUpdate adding_new_public_apis.md (#7544)
Jan Kotas [Tue, 11 Oct 2016 00:06:45 +0000 (17:06 -0700)]
Update adding_new_public_apis.md (#7544)

7 years agoMerge pull request #7537 from pgavlin/PushStructArgsX86
Pat Gavlin [Tue, 11 Oct 2016 00:00:38 +0000 (17:00 -0700)]
Merge pull request #7537 from pgavlin/PushStructArgsX86

Fix the codegen for by-value struct args on x86.

7 years agoForce byteable register for CMP if op2 is CNS_INT
Michelle McDaniel [Fri, 7 Oct 2016 15:32:17 +0000 (08:32 -0700)]
Force byteable register for CMP if op2 is CNS_INT

On x86 we need to force byteable registers for compares not only when both
ops are typ_byte, but also when the first is of typ_byte and the second is
a constant int. The original condition for cmp only considered the first
case. This change adds the second condition.

7 years agoAddress PR feedback.
Pat Gavlin [Mon, 10 Oct 2016 20:30:00 +0000 (13:30 -0700)]
Address PR feedback.

7 years agoMerge pull request #7530 from ramarag/StrongNameKeyPair
Rama krishnan Raghupathy [Mon, 10 Oct 2016 21:18:26 +0000 (14:18 -0700)]
Merge pull request #7530 from ramarag/StrongNameKeyPair

Strong name key pair

7 years agoExposing StrongNameKeyPair
Rama Krishnan Raghupathy [Fri, 7 Oct 2016 23:36:46 +0000 (16:36 -0700)]
Exposing StrongNameKeyPair

7 years agoMerge pull request #7543 from JosephTremoulet/NoRngChecks_Rel
Joseph Tremoulet [Mon, 10 Oct 2016 19:01:43 +0000 (15:01 -0400)]
Merge pull request #7543 from JosephTremoulet/NoRngChecks_Rel

Stop making JitNoRngChecks debug-only

7 years agoFix buffer length usage in UTF-8 to Unicode conversion (#7540)
John Chen [Mon, 10 Oct 2016 16:39:08 +0000 (09:39 -0700)]
Fix buffer length usage in UTF-8 to Unicode conversion (#7540)

These changes are ported from desktop CLR.

7 years agoFix various CustomAttributeBuilder bugs (#7206)
Hugh Bellamy [Mon, 10 Oct 2016 15:54:41 +0000 (16:54 +0100)]
Fix various CustomAttributeBuilder bugs (#7206)

Fix various CustomAttributeBuilder bugs

7 years agoStop making JitNoRngChecks debug-only
Joseph Tremoulet [Mon, 10 Oct 2016 14:48:56 +0000 (10:48 -0400)]
Stop making JitNoRngChecks debug-only

JitNoRngChecks is a flag, only available in special builds, that removes
all array bounds checks from generated code, which exists solely to
facilitate experiments measuring the cost of bounds checks.  Commit
0aebfbef0 added support for it to RyuJit, but accidentally did so only for
debug builds; release `FEATURE_ENABLE_NO_RANGE_CHECKS` builds are
currently broken.

This change makes the jit flag's definition available in release builds
with `FEATURE_ENABLE_NO_RANGE_CHECKS` defined as well.  The corresponding
code in clrconfigvalues.h already works that way.

7 years agoFix the codegen for by-value struct args on x86.
Pat Gavlin [Sat, 8 Oct 2016 02:03:10 +0000 (19:03 -0700)]
Fix the codegen for by-value struct args on x86.

Although the existing code generation for by-value struct args containing
GC references on x86 was correct with respect to the layout of the data
being passed, it was not correct with respect to the invariants necessary
for the GC info encoder.

The existing codegen for by-value struct args--whether represented by
`GT_OBJ` or `GT_FIELD_LIST` nodes--takes what is essentially the
following approach:

    sub esp, argument_size
    mov [esp + offset_0], field_0
    mov [esp + offset_1], field_1
    ...
    mov [esp + offset_n], field_n

Although this puts the correct data in the correct locations, the
emitter is unable to recognize that a GC info update is requires if any
of the `mov` instructions write a GC reference to the stack: instead,
on x86, `push` instructions must be used to write GC references on the
stack. Furthermore, the stack must be kept 4-byte aligned.

This change modifies the code generator to use `push` instructions to
write outgoing GC references to the stack while obeying the alignment
invariant required by the GC encoding. For outgoing by-value struct
args represented by `GT_OBJ`, this results in very straightforward code:

    push [val_addr]
    push [val_addr + 4]
    ...
    push [val_addr + n]

For args represented by `GT_FIELD_LIST`, the picture is a bit more
complicated as the stack must be kept 4-byte aligned. Handling of these
args is split into two cases: if a field list contains no GC references
and is larger than 16 bytes or contains any fields that cannot be
treated as a 4-byte-aligned, int32-sized value, the argument is passed
using the `sub esp, arg_size; mov [esp + offset], field` approach.
Otherwise--if the struct contains any GC references or is smaller than
16 bytes and only contains fields that can be treated as slots--the
argument is passed using the following approach:
- If a field is a GC reference or can be treated as a 4-byte slot, the
  field is stored to the stack using a `push` instruction.
- Otherwise, the stack pointer is first adjusted to the next 4-byte
  aligned address after the offset of the field and the field is
  stored to the appropriate address using a `mov`.

For example, given the following IR:

     t55 =    lclVar    bool   V06 tmp4         u:6 esi REG esi RV $40

    t138 =    dconst    float  0.00000000000000000 REG mm0 $80

           /--*  t138   float
           +--*  t55    bool
    t139 = *  <fldList> void   float at offset 4 REG NA $180

           /--*  t139   void
    t152 = *  putarg_stk [+0x00] void   REG NA

The backend will generate the following code:

    sub      esp, 8
    movss    dword ptr [esp+04H], xmm0
    mov      dword ptr [esp], esi

And given the following IR:

    t13 =    lclVar    ref    V04 tmp1         u:2 esi (last use) REG esi RV $1c0

    t45 =    lclVar    int    V05 tmp2         u:2 eax (last use) REG eax RV $200

          /--*  t45    int
          +--*  t13    ref
    t46 = *  <fldList> void   int at offset 4 REG NA $240

The backend will instead generate the following:

    push     eax
    push     esi

These changes also produce beneficial diffs: for example, the native image
for System.Private.CoreLib.dll has diffs in ~1000 methods for an overall
size improvement of 1%.

7 years agoMerge pull request #7538 from dotnet-bot/master-UpdateDependencies
Gaurav Khanna [Sun, 9 Oct 2016 15:32:34 +0000 (08:32 -0700)]
Merge pull request #7538 from dotnet-bot/master-UpdateDependencies

Update CoreClr to beta-24609-02 (master)

7 years agoUpdate CoreClr to beta-24609-02
dotnet-bot [Sun, 9 Oct 2016 08:15:37 +0000 (08:15 +0000)]
Update CoreClr to beta-24609-02

7 years agoAdd test to validate ByRef type unification (#7534)
Michal Strehovský [Sun, 9 Oct 2016 04:59:20 +0000 (21:59 -0700)]
Add test to validate ByRef type unification (#7534)

Make sure that `ldtoken SomeType&` leads to the same type as `ldtoken
SomeType` followed by `MakeByRefType`.

7 years agoImplement CultureNotFoundException id-based ctors (#7536)
Stephen Toub [Sun, 9 Oct 2016 04:59:01 +0000 (00:59 -0400)]
Implement CultureNotFoundException id-based ctors (#7536)

7 years agoMerge pull request #7531 from dotnet-bot/master-UpdateDependencies
Gaurav Khanna [Sun, 9 Oct 2016 02:27:48 +0000 (19:27 -0700)]
Merge pull request #7531 from dotnet-bot/master-UpdateDependencies

Update CoreClr, CoreFx to beta-24609-01, beta-24608-01, respectively (master)

7 years agoUpdate CoreClr, CoreFx to beta-24609-01, beta-24608-01, respectively
dotnet-bot [Sun, 9 Oct 2016 00:13:50 +0000 (00:13 +0000)]
Update CoreClr, CoreFx to beta-24609-01, beta-24608-01, respectively

7 years agoStandardize on _echo name (#7532)
Vance Morrison [Sat, 8 Oct 2016 06:08:38 +0000 (23:08 -0700)]
Standardize on _echo name (#7532)

7 years agoMerge pull request #7521 from vkvenkat/master
Sergiy Kuryata [Sat, 8 Oct 2016 00:13:06 +0000 (17:13 -0700)]
Merge pull request #7521 from vkvenkat/master

Fixed #7519 - Dotnet crashes while saturating multiple CPU groups on Windows

7 years agoReturn null on allocation failure due to OOM instead of throwing a exception from...
Sean Gillespie [Fri, 7 Oct 2016 22:11:32 +0000 (15:11 -0700)]
Return null on allocation failure due to OOM instead of throwing a exception from within the GC (#7501)

7 years agoDisable CER code that is causing access violation
John Chen (CLR) [Fri, 7 Oct 2016 19:46:16 +0000 (12:46 -0700)]
Disable CER code that is causing access violation

Resolves issue dotnet/corefx#12412.

7 years agoMerge pull request #7522 from dotnet-bot/master-UpdateDependencies
Gaurav Khanna [Fri, 7 Oct 2016 20:57:28 +0000 (13:57 -0700)]
Merge pull request #7522 from dotnet-bot/master-UpdateDependencies

Update CoreClr, CoreFx to beta-24607-03, beta-24607-05, respectively (master)

7 years agoMerge pull request #7520 from pgavlin/PutStructArgStk
Pat Gavlin [Fri, 7 Oct 2016 20:08:40 +0000 (13:08 -0700)]
Merge pull request #7520 from pgavlin/PutStructArgStk

Refactor genPutStructArgStk for clarity.

7 years agoFix formatting.
Pat Gavlin [Fri, 7 Oct 2016 18:15:44 +0000 (11:15 -0700)]
Fix formatting.

7 years agoUpdate CoreClr, CoreFx to beta-24607-03, beta-24607-05, respectively
dotnet-bot [Fri, 7 Oct 2016 18:39:53 +0000 (18:39 +0000)]
Update CoreClr, CoreFx to beta-24607-03, beta-24607-05, respectively

7 years agoFixed #7519 - Dotnet crashes while saturating multiple CPU groups on Windows
vkvenkat [Fri, 7 Oct 2016 16:53:09 +0000 (09:53 -0700)]
Fixed #7519 - Dotnet crashes while saturating multiple CPU groups on Windows

7 years agoRefactor genPutStructArgStk for clarity.
Pat Gavlin [Fri, 7 Oct 2016 17:38:48 +0000 (10:38 -0700)]
Refactor genPutStructArgStk for clarity.

This also contains a minor CQ improvement: instead of always
incrementing the source and destination pointers when copying a struct
argument to the stack, we now only do so if there are more slots to
copy.

7 years agoMerge pull request #7515 from BruceForstall/FixMerge
Bruce Forstall [Fri, 7 Oct 2016 16:29:02 +0000 (09:29 -0700)]
Merge pull request #7515 from BruceForstall/FixMerge

Fix bad merge

7 years agoMerge pull request #7509 from sandreenko/master
sandreenko [Fri, 7 Oct 2016 15:46:34 +0000 (08:46 -0700)]
Merge pull request #7509 from sandreenko/master

Set missed default value for coreclr runtest.cmd #7488.

7 years agoMerge pull request #7514 from dotnet-bot/master-UpdateDependencies
Gaurav Khanna [Fri, 7 Oct 2016 14:58:47 +0000 (07:58 -0700)]
Merge pull request #7514 from dotnet-bot/master-UpdateDependencies

Update CoreClr, CoreFx to beta-24607-02, beta-24607-03, respectively (master)

7 years agoMerge pull request #7466 from adiaaida/fix7224
Michelle McDaniel [Fri, 7 Oct 2016 13:56:45 +0000 (06:56 -0700)]
Merge pull request #7466 from adiaaida/fix7224

Force byteable registers for indir op source

7 years agoForce byteable registers for indir op source
Michelle McDaniel [Mon, 3 Oct 2016 21:49:19 +0000 (14:49 -0700)]
Force byteable registers for indir op source

When we have a GT_STOREIND, we need to not only make sure that the
source and dest of the storeind are marked as requiring byteable
registers, but also the indirect op's source. For example:

```
GT_STOREIND(GT_ADD(TYP_INT, mem of TYP_BYTE, reg of TYP_INT or TYP_BYTE))
```

We need to make sure that the source reg of the GT_ADD is byteable.

This change fixes #7224.

7 years agoUpdate CoreClr, CoreFx to beta-24607-02, beta-24607-03, respectively
dotnet-bot [Fri, 7 Oct 2016 08:15:03 +0000 (08:15 +0000)]
Update CoreClr, CoreFx to beta-24607-02, beta-24607-03, respectively

7 years agoEnable netstandard1.7 collations APIs (#7502)
Tarek Mahmoud Sayed [Fri, 7 Oct 2016 07:07:04 +0000 (00:07 -0700)]
Enable netstandard1.7 collations APIs (#7502)

* Enable netstandard1.7 collations APIs

This change is adding the netstandard 1.7 APIs to CompareInfo class and adding support to SortKey and SortVersion classes
The change include some support in cultureinfo and culturedata for locale Id's too which is used by CompareInfo class

* optimize the globalization data so we'll have faster initialization

* Remove security attributes