ebrauer [Wed, 17 Feb 2016 16:04:00 +0000 (08:04 -0800)]
Updates Piex and uses it to obtain the DNG dimensions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1659873002
Review URL: https://codereview.chromium.org/
1659873002
mtklein [Wed, 17 Feb 2016 15:23:36 +0000 (07:23 -0800)]
fast sk4f <-> sk4i SSE methods
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1707673002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1707673002
reed [Wed, 17 Feb 2016 15:15:29 +0000 (07:15 -0800)]
misc fixes to make float buffers work a little better
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703013002
TBR=fmalita
Review URL: https://codereview.chromium.org/
1703013002
mtklein [Wed, 17 Feb 2016 14:47:52 +0000 (06:47 -0800)]
dead code: really kill these off again
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702343002
Review URL: https://codereview.chromium.org/
1702343002
mtklein [Wed, 17 Feb 2016 14:37:51 +0000 (06:37 -0800)]
come on, this is how you drive-by
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1708563002
Review URL: https://codereview.chromium.org/
1708563002
fmalita [Wed, 17 Feb 2016 14:17:12 +0000 (06:17 -0800)]
Use geometric mean when selecting a mipmap scale
Workaround for anisotropic mipmap quality issues.
R=reed@google.com,robertphillips@google.com
BUG=skia:4863,chromium:586894
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697423002
Review URL: https://codereview.chromium.org/
1697423002
yujieqin [Wed, 17 Feb 2016 14:12:12 +0000 (06:12 -0800)]
Update PIEX version. This should solve the stack buffer overflow issue
BUG=skia:4902
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690853003
Review URL: https://codereview.chromium.org/
1690853003
joshualitt [Wed, 17 Feb 2016 13:40:00 +0000 (05:40 -0800)]
Fix memory leak
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1706773002
Review URL: https://codereview.chromium.org/
1706773002
kkinnunen [Wed, 17 Feb 2016 07:15:40 +0000 (23:15 -0800)]
Do not try to use GL_texture_rectangle on GL ES
Do not try to use ARB_GL_texture_rectangle on GL ES.
Command buffer exposes it, but it's not recommended. It also
does not work with TexImage2D, and ANGLE does not
have support for it on with GL ES 3.0 source context.
Bug triggered only when trying to use command buffer in
GL ES 3.0 mode.
BUG=angleproject:1313
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691853003
Review URL: https://codereview.chromium.org/
1691853003
mtklein [Wed, 17 Feb 2016 04:56:13 +0000 (20:56 -0800)]
These files must be in the gypi for GN to remove them...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696373005
Review URL: https://codereview.chromium.org/
1696373005
mtklein [Wed, 17 Feb 2016 04:23:49 +0000 (20:23 -0800)]
restore empty files so that Chrome GN config can remove them...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1700023005
Review URL: https://codereview.chromium.org/
1700023005
iroth [Wed, 17 Feb 2016 03:17:01 +0000 (19:17 -0800)]
Fix linker errors when skia_ios target is used a dependency of an iOS app.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701153002
Review URL: https://codereview.chromium.org/
1701153002
mtklein [Wed, 17 Feb 2016 03:06:15 +0000 (19:06 -0800)]
clean up more dead code
- SkSHA1 is unused
- SkRunnable is obsolete now that we have std::function
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705583003
Review URL: https://codereview.chromium.org/
1705583003
mtklein [Wed, 17 Feb 2016 02:38:14 +0000 (18:38 -0800)]
Delete dead code. SkBitmapHasher has not been used since gm.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704783002
Review URL: https://codereview.chromium.org/
1704783002
kjlubick [Wed, 17 Feb 2016 00:14:23 +0000 (16:14 -0800)]
Add ability to fuzz images using scaling and different modes
This also fixes the tryAllocPixels/SkColorTable mismatch which was causing the
"Image might be too large (32 x 32)" problems.
BUG=skia:4952
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698963003
Review URL: https://codereview.chromium.org/
1698963003
mtklein [Tue, 16 Feb 2016 22:33:08 +0000 (14:33 -0800)]
add back Sk4i
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699293002
Review URL: https://codereview.chromium.org/
1699293002
mtklein [Tue, 16 Feb 2016 22:03:14 +0000 (14:03 -0800)]
MSAN: build libc++ with MSAN, link to it.
The errors that we see should now change to the unexplainable,
rather than the explainable errors at head.
We suspect that the original reason to blacklist was this,
not building libc++ with MSAN. So unblacklist everything to start fresh.
BUG=skia:4903,skia:4900
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694353004
Review URL: https://codereview.chromium.org/
1694353004
senorblanco [Tue, 16 Feb 2016 21:26:56 +0000 (13:26 -0800)]
Remove 6-param applyCropRect() from lighting filters (raster path).
BUG=skia:4502
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701133002
Review URL: https://codereview.chromium.org/
1701133002
msarett [Tue, 16 Feb 2016 21:24:54 +0000 (13:24 -0800)]
Make kInvalidConversion a fatal failure in DMSrcSink
We just need to abort early on tests that we know
are invalid conversions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704433003
Review URL: https://codereview.chromium.org/
1704433003
msarett [Tue, 16 Feb 2016 21:16:39 +0000 (13:16 -0800)]
Add SkCodec to the CMake build
BUG=skia:4956
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1705503002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1705503002
cblume [Tue, 16 Feb 2016 21:00:01 +0000 (13:00 -0800)]
There is an unused rowBytes parameter being passed along.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1636873002
Review URL: https://codereview.chromium.org/
1636873002
robertphillips [Tue, 16 Feb 2016 20:09:36 +0000 (12:09 -0800)]
Change signature of SkSpecialImage::draw to take SkScalars
Review URL: https://codereview.chromium.org/
1704603002
halcanary [Tue, 16 Feb 2016 19:48:06 +0000 (11:48 -0800)]
bin/sync-and-gyp: start using gclient
stop using hard-to-maintain git-sync-deps
BUG=skia:4885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693963005
Review URL: https://codereview.chromium.org/
1693963005
bsalomon [Tue, 16 Feb 2016 19:36:56 +0000 (11:36 -0800)]
Remove outdated optimization to not flush for new textures in GrSWMaskHelper
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704593002
Review URL: https://codereview.chromium.org/
1704593002
bsalomon [Tue, 16 Feb 2016 19:36:47 +0000 (11:36 -0800)]
Workaround for bug in Tegra 3 when uploading to a render target
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1703603002
Review URL: https://codereview.chromium.org/
1703603002
joshualitt [Tue, 16 Feb 2016 19:09:25 +0000 (11:09 -0800)]
Delete GrTextContext
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699073004
Review URL: https://codereview.chromium.org/
1699073004
ethannicholas [Tue, 16 Feb 2016 19:03:04 +0000 (11:03 -0800)]
tuned skiaserve's png output for better performance
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704573002
Review URL: https://codereview.chromium.org/
1704573002
joshualitt [Tue, 16 Feb 2016 18:36:53 +0000 (10:36 -0800)]
Create GrPathRenderingDrawContext
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1701013002
Review URL: https://codereview.chromium.org/
1701013002
jcgregorio [Tue, 16 Feb 2016 18:31:07 +0000 (10:31 -0800)]
skiaserve: Change alpha setting from GET to POST.
GET shouldn't be used for things that change the state of the server.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1706443002
Review URL: https://codereview.chromium.org/
1706443002
benjaminwagner [Tue, 16 Feb 2016 18:09:40 +0000 (10:09 -0800)]
Change SkMatrix::fixedStepInX to return SkVector (of SkScalar) rather than SkFixed.
All users were immediately converting to SkScalar or SkFixed3232.
This method is not used in Chromium, Android, or Google3.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692013002
Review URL: https://codereview.chromium.org/
1692013002
djsollen [Tue, 16 Feb 2016 17:19:35 +0000 (09:19 -0800)]
Use a statically linked libhwui for testing.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1688383005
Review URL: https://codereview.chromium.org/
1688383005
senorblanco [Tue, 16 Feb 2016 17:11:18 +0000 (09:11 -0800)]
Image filters: change applyCropRect() to take a src rect.
Instead of taking the source bitmap and offset, we simply take the
source rect bounds, and make the caller responsible for computing it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1702683002
Review URL: https://codereview.chromium.org/
1702683002
mtklein [Tue, 16 Feb 2016 16:10:34 +0000 (08:10 -0800)]
SkOSFile_stdio: less ::
It's not clear why we wrote this file in this manner.
On OpenBSD, fileno is a macro, so ::fileno makes no sense.
Also remove some end-of-line whitespace.
BUG=skia:4953
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695333003
Review URL: https://codereview.chromium.org/
1695333003
msarett [Tue, 16 Feb 2016 16:04:34 +0000 (08:04 -0800)]
Make png filter functions compatible with libpng
We hope to upstream these functions to libpng (a C library).
Let's make the code that Skia tests on look like the code
that we are submitting.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699953002
Review URL: https://codereview.chromium.org/
1699953002
bsalomon [Tue, 16 Feb 2016 16:00:05 +0000 (08:00 -0800)]
Modify interface to GrPathUtils::convertCubicToQuads
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694403003
Review URL: https://codereview.chromium.org/
1694403003
bsalomon [Tue, 16 Feb 2016 15:34:17 +0000 (07:34 -0800)]
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684313002
Committed: https://skia.googlesource.com/skia/+/
7ea5e28065e5eb797e95f5d81c1a65cf3209d741
Review URL: https://codereview.chromium.org/
1684313002
scroggo [Tue, 16 Feb 2016 14:59:18 +0000 (06:59 -0800)]
Make SkRWBuffer destruct safely
Check for NULL before calling unref.
Add a test.
BUG=483369
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691383002
Review URL: https://codereview.chromium.org/
1691383002
joshualitt [Tue, 16 Feb 2016 14:47:52 +0000 (06:47 -0800)]
Remove last bit of privacy violation for GrAtlasTextBlob
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698503002
Review URL: https://codereview.chromium.org/
1698503002
mtklein [Tue, 16 Feb 2016 14:42:51 +0000 (06:42 -0800)]
Setup for -Fast GCE bot.
I'd like a bot that has got optimization turned up to 11,
to let us test things that our Chrome-like bots normally can't.
(Not quite ready to commit this bot to -ffast-math yet.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1704473002
Review URL: https://codereview.chromium.org/
1704473002
update-skps [Tue, 16 Feb 2016 14:42:46 +0000 (06:42 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1698013005
Review URL: https://codereview.chromium.org/
1698013005
reed [Mon, 15 Feb 2016 22:26:14 +0000 (14:26 -0800)]
starter kit for colorspaces
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692893003
TBR=jvanverth
Review URL: https://codereview.chromium.org/
1695353002
msarett [Mon, 15 Feb 2016 18:18:45 +0000 (10:18 -0800)]
Fix colorType/alphaType checks in SkCodec
Make getPixels() and startScanlineDecode() behave
consistently.
Require that kGray8 decodes are opaque.
Assert that creating the swizzler succeeds.
BUG=skia:4203
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695473002
Committed: https://skia.googlesource.com/skia/+/
c7578b6cdd03b61f076ffc7956efd952d6c301c0
Review URL: https://codereview.chromium.org/
1695473002
reed [Mon, 15 Feb 2016 16:27:14 +0000 (08:27 -0800)]
make SkComposeShader.h private
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697523003
Review URL: https://codereview.chromium.org/
1697523003
reed [Mon, 15 Feb 2016 15:48:35 +0000 (07:48 -0800)]
blitters for sRGB and float16
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697863002
Review URL: https://codereview.chromium.org/
1697863002
brianosman [Sun, 14 Feb 2016 18:33:03 +0000 (10:33 -0800)]
Roll back ellipse logic for now. This was (probably) still wrong.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692303003
Review URL: https://codereview.chromium.org/
1692303003
update-skps [Sun, 14 Feb 2016 08:47:34 +0000 (00:47 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696023002
Review URL: https://codereview.chromium.org/
1696023002
benjaminwagner [Fri, 12 Feb 2016 23:20:55 +0000 (15:20 -0800)]
Revert of Add infastructure for gl_SampleMask (patchset #6 id:100001 of https://codereview.chromium.org/
1690963003/ )
Reason for revert:
Several bots failing with error 'invalid profile "es" for version 320'.
Original issue's description:
> Add infastructure for gl_SampleMask
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690963003
>
> Committed: https://skia.googlesource.com/skia/+/
533cefe5b9c7cec2592fc7ca00ee4cf69a26c094
TBR=egdaniel@google.com,bsalomon@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1693113002
msarett [Fri, 12 Feb 2016 23:00:10 +0000 (15:00 -0800)]
Revert of Fix colorType/alphaType checks in SkCodec (patchset #5 id:80001 of https://codereview.chromium.org/
1695473002/ )
Reason for revert:
Really bad images in Gold.
Original issue's description:
> Fix colorType/alphaType checks in SkCodec
>
> Make getPixels() and startScanlineDecode() behave
> consistently.
>
> Require that kGray8 decodes are opaque.
>
> Assert that creating the swizzler succeeds.
>
> BUG=skia:4203
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695473002
>
> Committed: https://skia.googlesource.com/skia/+/
c7578b6cdd03b61f076ffc7956efd952d6c301c0
TBR=scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4203
Review URL: https://codereview.chromium.org/
1694023002
msarett [Fri, 12 Feb 2016 22:47:09 +0000 (14:47 -0800)]
Adding a tool to get images from skps
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696763002
Review URL: https://codereview.chromium.org/
1696763002
reed [Fri, 12 Feb 2016 22:43:17 +0000 (14:43 -0800)]
re-emable u64 gm
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692903002
TBR=mtklein
Review URL: https://codereview.chromium.org/
1692903002
mtklein [Fri, 12 Feb 2016 22:19:06 +0000 (14:19 -0800)]
Revert of SkNx refactoring (patchset #4 id:60001 of https://codereview.chromium.org/
1690633003/ )
Reason for revert:
Precautionary revert for chromium:586487
Original issue's description:
> SkNx refactoring
>
> - add back Sk4i typedef
> - define SSE casts in terms of Sk4i
> * uint8 <-> float becomes uint8 <-> int <-> float
> * uint16 <-> float becomes uint16 <-> int <-> float
>
> This has the nice side effect of specializing uint8 <-> int
> and uint16 <-> int, which are useful in their own right.
>
> There are many cast specializations now, some of which call each other.
> I have tried to arrange them in some sort of sensible order, subject to
> the constraint that those called must precede those who call.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690633003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
c1eb311f4e98934476f1b2ad5d6de772cf140d60
TBR=herb@google.com,mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:586487
Review URL: https://codereview.chromium.org/
1696903002
mtklein [Fri, 12 Feb 2016 21:56:13 +0000 (13:56 -0800)]
Try fixing unused-variable warnings another way.
If we mark these as extern, the compiler won't complain they're unused.
This is an unsatisfying hack, but last time we tried to condition these
on non-NEON only, Chromium's GN linux ARM bot failed. They must not be
configured to use the NEON procs?
BUG=skia:4798
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1699473002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1699473002
cdalton [Fri, 12 Feb 2016 21:24:26 +0000 (13:24 -0800)]
Add infastructure for gl_SampleMask
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690963003
Review URL: https://codereview.chromium.org/
1690963003
msarett [Fri, 12 Feb 2016 21:07:15 +0000 (13:07 -0800)]
Fix colorType/alphaType checks in SkCodec
Make getPixels() and startScanlineDecode() behave
consistently.
Require that kGray8 decodes are opaque.
Assert that creating the swizzler succeeds.
BUG=skia:4203
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695473002
Review URL: https://codereview.chromium.org/
1695473002
msarett [Fri, 12 Feb 2016 21:06:30 +0000 (13:06 -0800)]
Sync DEPS to clang compatible arm v8 assembly for libjpeg-turbo
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1697623002
Review URL: https://codereview.chromium.org/
1697623002
mtklein [Fri, 12 Feb 2016 20:58:09 +0000 (12:58 -0800)]
followups
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693823005
Review URL: https://codereview.chromium.org/
1693823005
mtklein [Fri, 12 Feb 2016 20:54:15 +0000 (12:54 -0800)]
Remove check for platform_tools/android/third_party/externals.
We don't sync anything into it anymore, so a fresh gclient sync won't create it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694813004
Review URL: https://codereview.chromium.org/
1694813004
khushalsagar [Fri, 12 Feb 2016 20:42:48 +0000 (12:42 -0800)]
Add support for caching font files in the Android SkFontMgr.
SkFontMgr_Android lazily access font files from disk, which is not
possible when it is used in the renderer sandbox on Linux. Add a flag to
SkFontMgr_Android_CustomFonts for caching readonly FILE streams when
creating the font mgr.
Since the font mgr is created before the sandbox is initialized, it can
access these files on initialization, and use these cached streams safely
for its lifetime.
Review URL: https://codereview.chromium.org/
1673373003
msarett [Fri, 12 Feb 2016 20:35:48 +0000 (12:35 -0800)]
Make SkJpegCodec compatible with libjpeg
BUG=skia:4470
BUG=skia:4520
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1687863003
Review URL: https://codereview.chromium.org/
1687863003
benjaminwagner [Fri, 12 Feb 2016 20:19:14 +0000 (12:19 -0800)]
Change ScalarTo256 to more efficient implementation.
The previous implementation was likely more efficient when SkScalar was SkFixed.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693683002
Review URL: https://codereview.chromium.org/
1693683002
mtklein [Fri, 12 Feb 2016 20:15:23 +0000 (12:15 -0800)]
Put all XSAN bots on the same DEPS-sourced build of Clang.
This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.
This is similar to how the CMake bots bootstrap CMake if needed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693733003
Review URL: https://codereview.chromium.org/
1693733003
cdalton [Fri, 12 Feb 2016 20:14:06 +0000 (12:14 -0800)]
Use noperspective interpolation for 2D draws
Adds a mechanism to notify GrGLSLVaryingHandler that a shader will not
emit geometry in perspective. This gives it a chance to use the
noperspective keyword if it is supported.
Updates the existing processors to notify the varying handler when
there is no perspective.
Begins using the noperspective keyword in GrGLGpu internal shaders.
Web scenes with observable benefit (Pixel C, gpu config):
tabl_nofolo.skp 4.62 -> 3.33 ms 28%
desk_tigersvg.skp 26.5 -> 24 ms 9%
desk_pokemonwiki.skp 16.1 -> 14.9 ms 7%
tabl_deviantart.skp 3.97 -> 3.7 ms 7%
desk_gws.skp 3.85 -> 3.65 ms 5%
Also adds new methods for creating varyings with flat interpolation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1673093002
Review URL: https://codereview.chromium.org/
1673093002
bsalomon [Fri, 12 Feb 2016 20:10:14 +0000 (12:10 -0800)]
Make copySurface work in more situations.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693923002
Review URL: https://codereview.chromium.org/
1693923002
ethannicholas [Fri, 12 Feb 2016 20:06:53 +0000 (12:06 -0800)]
added clip visualization to skiaserve
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690023004
Review URL: https://codereview.chromium.org/
1690023004
jbroman [Fri, 12 Feb 2016 19:29:23 +0000 (11:29 -0800)]
Add a dependency from the debugger on tools.gyp:url_data_manager.
BUG=skia:4947
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695753003
Review URL: https://codereview.chromium.org/
1695753003
brianosman [Fri, 12 Feb 2016 18:20:00 +0000 (10:20 -0800)]
Put back the 0.5 bias in the shader. Only adjust the radii for the geometry, not the radii constants.
After working through this with Jim, this is more mathematically correct, and also accounts for the inner radius.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692683003
Review URL: https://codereview.chromium.org/
1692683003
ethannicholas [Fri, 12 Feb 2016 18:09:34 +0000 (10:09 -0800)]
skiaserve now retains the graphics context rather than creating a new one each request
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1693893002
Review URL: https://codereview.chromium.org/
1693893002
djsollen [Fri, 12 Feb 2016 16:44:39 +0000 (08:44 -0800)]
Update Android framework makefile to build static and shared libs
Also use static lib for testing tools and expose includes needed for
other framework testing tools to statically link in Skia.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696483002
Review URL: https://codereview.chromium.org/
1696483002
halcanary [Fri, 12 Feb 2016 16:08:27 +0000 (08:08 -0800)]
Documantation: nanobench
DOCS_PREVIEW= https://skia.org/dev/testing/tests?cl=
1696723002
https://skia.org/dev/testing/tests?cl=
1696723002#bench
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1696723002
NOTRY=true
Review URL: https://codereview.chromium.org/
1696723002
brianosman [Fri, 12 Feb 2016 15:45:56 +0000 (07:45 -0800)]
Remove the 0.5 bias from the ellipse edge function. This makes coverage drop to zero before we get clipped by the rasterizer (i.e. ensures the generated ellipse is inscribed in the geometry).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1683843006
Review URL: https://codereview.chromium.org/
1683843006
halcanary [Fri, 12 Feb 2016 15:26:46 +0000 (07:26 -0800)]
SkDocument: remove use of SkTArray (part 3/3).
TBR=reed
Removal only. Verbal lgtm.
Review URL: https://codereview.chromium.org/
1692703003
ethannicholas [Fri, 12 Feb 2016 15:15:45 +0000 (07:15 -0800)]
fixed SkDebugCanvas' handling of drawPicture
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1685133008
Review URL: https://codereview.chromium.org/
1685133008
benjaminwagner [Fri, 12 Feb 2016 00:00:24 +0000 (16:00 -0800)]
Enable RAW codec for Google3.
This CL depends on internal cl/
113089689.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692513003
Review URL: https://codereview.chromium.org/
1692513003
msarett [Thu, 11 Feb 2016 22:17:17 +0000 (14:17 -0800)]
Delete SkDecodingImageGenerator
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692053002
Review URL: https://codereview.chromium.org/
1692053002
brianosman [Thu, 11 Feb 2016 22:15:18 +0000 (14:15 -0800)]
Switch to vertex colors rather than uniforms for color in Ellipse/Circle/RRect/DRRect
[Notes:]
- Performance delta on desktop looked like noise. I'm curious what the results will be on low-end mobile GPUs. I'm still trying to figure out how I determine that with perf, etc...
- There appeared to be a single one-pixel image diff while running dm, if I'm understanding the results of skdiff correctly, so that's probably good news?
- Should I include anyone else on the review?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1675833002
Review URL: https://codereview.chromium.org/
1675833002
cdalton [Thu, 11 Feb 2016 22:10:38 +0000 (14:10 -0800)]
Add #define directives to GrGLSLShaderBuilder
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1660813002
Review URL: https://codereview.chromium.org/
1660813002
msarett [Thu, 11 Feb 2016 21:29:36 +0000 (13:29 -0800)]
Implement onSkipScanlines() for bmp and wbmp
TBR=reed@google.com
BUG=skia:4270
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691083002
Review URL: https://codereview.chromium.org/
1691083002
ethannicholas [Thu, 11 Feb 2016 21:10:37 +0000 (13:10 -0800)]
fixed off-by-one error in skiaserve /cmd
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1692683002
Review URL: https://codereview.chromium.org/
1692683002
cdalton [Thu, 11 Feb 2016 20:49:47 +0000 (12:49 -0800)]
Add GrShaderFlags enum
Replaces GrGLSLUniformHandler::ShaderVisibility with GrShaderFlags.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684063006
Review URL: https://codereview.chromium.org/
1684063006
mtklein [Thu, 11 Feb 2016 20:48:23 +0000 (12:48 -0800)]
new version of SkHalfToFloat_01
This is a little faster than the previous version, and much better explained.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1688233002
Review URL: https://codereview.chromium.org/
1688233002
joshualitt [Thu, 11 Feb 2016 20:42:02 +0000 (12:42 -0800)]
start to chip away at friending of GrAtlasTextBatch/GrAtlasTextBlob
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684253002
Review URL: https://codereview.chromium.org/
1684253002
kjlubick [Thu, 11 Feb 2016 20:05:24 +0000 (12:05 -0800)]
Revert of Make copySurface work for texture dsts, return a bool, & add unit test. (patchset #6 id:100001 of https://codereview.chromium.org/
1684313002/ )
Reason for revert:
Copy surface tests are not happy for Windows, Android and probably others:
https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/4161
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Release/builds/3694
Original issue's description:
> Make copySurface work for texture dsts, return a bool, & add unit test.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684313002
>
> Committed: https://skia.googlesource.com/skia/+/
7ea5e28065e5eb797e95f5d81c1a65cf3209d741
TBR=robertphillips@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1690053002
joshualitt [Thu, 11 Feb 2016 20:00:33 +0000 (12:00 -0800)]
Remove GrContext* from GrTextContext
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1686143003
Review URL: https://codereview.chromium.org/
1686143003
bsalomon [Thu, 11 Feb 2016 19:42:31 +0000 (11:42 -0800)]
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684313002
Review URL: https://codereview.chromium.org/
1684313002
joshualitt [Thu, 11 Feb 2016 19:42:19 +0000 (11:42 -0800)]
enable ThermalManager on Android
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684653002
Review URL: https://codereview.chromium.org/
1684653002
msarett [Thu, 11 Feb 2016 18:49:31 +0000 (10:49 -0800)]
Support more color types for ICOs
BUG=skia:4620
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694513002
Review URL: https://codereview.chromium.org/
1694513002
msarett [Thu, 11 Feb 2016 18:35:48 +0000 (10:35 -0800)]
Avoid initializing memory twice on incomplete RLE bmps
BUG=skia:4582
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1689983002
Review URL: https://codereview.chromium.org/
1689983002
ethannicholas [Thu, 11 Feb 2016 18:35:21 +0000 (10:35 -0800)]
integrated SkDebugCanvas JSON support with UrlDataManager
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1686143004
Review URL: https://codereview.chromium.org/
1686143004
scroggo [Thu, 11 Feb 2016 18:24:55 +0000 (10:24 -0800)]
Test SkAndroidCodec for more types
Now that SkAndroidCodec supports all types, stop selectively running
its tests for the types supported by BRD.
For the tests that actually require BRD support (i.e. partial
scanlines), change the method name from supports_scaled_codec to
supports_partial_scanlines to be more accurate today.
Use the name SkAndroidCodec instead of SkScaledCodec.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691823002
Review URL: https://codereview.chromium.org/
1691823002
brianosman [Thu, 11 Feb 2016 17:07:02 +0000 (09:07 -0800)]
Further reduce the number of primitives in the donut tests. Avoids crashes on iOS.
BUG=skia:4937
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691813002
Review URL: https://codereview.chromium.org/
1691813002
msarett [Thu, 11 Feb 2016 16:41:53 +0000 (08:41 -0800)]
Clarify bmp comment about when we support the alpha mask
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1689183002
Review URL: https://codereview.chromium.org/
1689183002
msarett [Thu, 11 Feb 2016 16:41:01 +0000 (08:41 -0800)]
Fix scanline decoding of rare RLE bmps
This also exposed a bug in rewinding RLE bmps, which I have also
fixed in this CL.
This should fix testcase7.bmp on Gold.
The image that I am adding to resources is in the
public domain.
BUG=skia:4730
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1689953002
Review URL: https://codereview.chromium.org/
1689953002
mtklein [Thu, 11 Feb 2016 16:10:22 +0000 (08:10 -0800)]
SkNx refactoring
- add back Sk4i typedef
- define SSE casts in terms of Sk4i
* uint8 <-> float becomes uint8 <-> int <-> float
* uint16 <-> float becomes uint16 <-> int <-> float
This has the nice side effect of specializing uint8 <-> int
and uint16 <-> int, which are useful in their own right.
There are many cast specializations now, some of which call each other.
I have tried to arrange them in some sort of sensible order, subject to
the constraint that those called must precede those who call.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1690633003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1690633003
fmalita [Thu, 11 Feb 2016 16:06:39 +0000 (08:06 -0800)]
Remove SK_SUPPORT_LEGACY_BITMAP_FILTER guard
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1695443002
Review URL: https://codereview.chromium.org/
1695443002
halcanary [Thu, 11 Feb 2016 15:59:59 +0000 (07:59 -0800)]
SkDocument: remove use of SkTArray (part 1/3).
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1689683002
Review URL: https://codereview.chromium.org/
1689683002
joshualitt [Thu, 11 Feb 2016 15:09:51 +0000 (07:09 -0800)]
wire up new json code in skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691773002
Review URL: https://codereview.chromium.org/
1691773002
joshualitt [Thu, 11 Feb 2016 14:53:36 +0000 (06:53 -0800)]
fix for gpu valgrind bot
TBR=egdaniel@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1689823004
Review URL: https://codereview.chromium.org/
1689823004
joshualitt [Thu, 11 Feb 2016 14:46:52 +0000 (06:46 -0800)]
Pass a GrContext pointer in GrDrawContext constructor
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691503002
Review URL: https://codereview.chromium.org/
1691503002
msarett [Thu, 11 Feb 2016 14:45:51 +0000 (06:45 -0800)]
Add AndroidCodecBench to time scaled decodes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1685693003
Review URL: https://codereview.chromium.org/
1685693003
mtklein [Thu, 11 Feb 2016 14:30:03 +0000 (06:30 -0800)]
SkHalfToFloat_01 / SkFloatToHalf_01
These are basically inlined, 4-at-a-time versions of our existing functions,
but cut down to avoid any work that's only necessary outside [0,1].
Both f16 and f32 denorms should work fine modulo the usual ARMv7 NEON denorm==zero caveat.
In exchange for a little speed, f32->f16 does not round properly.
Instead it truncates, so it's never off by more than 1 bit.
Support for finite values >1 or <0 is straightforward to add back.
>1 might already work as-is.
Getting close to _u16 performance:
micros bench
261.13 xferu64_bw_1_opaque_u16
1833.51 xferu64_bw_1_alpha_u16
2762.32 ? xferu64_aa_1_opaque_u16
3334.29 xferu64_aa_1_alpha_u16
249.78 xferu64_bw_1_opaque_f16
3383.18 xferu64_bw_1_alpha_f16
4214.72 xferu64_aa_1_opaque_f16
4701.19 xferu64_aa_1_alpha_f16
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1685133005
Committed: https://skia.googlesource.com/skia/+/
9ea11a4235b3e3521cc8bf914a27c2d0dc062db9
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1685133005
projects / platform / upstream / libSkiaSharp.git / log