isaacs [Thu, 2 Feb 2012 23:35:14 +0000 (15:35 -0800)]
Upgrade v8 to 3.6.6.20
isaacs [Thu, 2 Feb 2012 22:57:12 +0000 (14:57 -0800)]
Add npm msysgit bash shim to msi installer
Ben Noordhuis [Wed, 1 Feb 2012 21:37:26 +0000 (22:37 +0100)]
buffers: fix intermittent out of bounds error
The base64 decoder would intermittently throw an out-of-bounds exception when
the buffer in `buf.write('', 'base64')` was a zero-sized buffer located at the
end of the slab.
Fixes #2657.
Ben Noordhuis [Wed, 1 Feb 2012 21:07:42 +0000 (22:07 +0100)]
buffers: honor length argument in base64 decoder
Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before
this commit, the length argument was ignored. The decoder would keep writing
until it hit the end of the buffer. Since most buffers in Node are slices of
a parent buffer (the slab), this bug would overwrite the content of adjacent
buffers.
The bug is trivially demonstrated with the following test case:
var assert = require('assert');
var a = Buffer(3);
var b = Buffer('xxx');
a.write('
aaaaaaaa', 'base64');
assert.equal(b.toString(), 'xxx');
This commit coincidentally also fixes a bug where Buffer._charsWritten was not
updated for zero length buffers.
Bert Belder [Thu, 2 Feb 2012 16:42:08 +0000 (17:42 +0100)]
uv: upgrade to 267e75d
Bert Belder [Thu, 2 Feb 2012 15:57:45 +0000 (16:57 +0100)]
_makeLong shouldn't turn the empty string into \\?\C:\
Bert Belder [Thu, 2 Feb 2012 15:56:58 +0000 (16:56 +0100)]
Run path.exists paths through _makeLong
Philip Tellis [Fri, 2 Dec 2011 18:42:32 +0000 (00:12 +0530)]
Make QueryString.parse run faster
Use decodeURIComponent when appropriate, and only fall back to
querystring.decode if it throws, or if the character is a '+'.
Fix #2248
Ben Noordhuis [Wed, 1 Feb 2012 21:25:55 +0000 (22:25 +0100)]
Revert "Process symlinked shared library as .node"
This reverts commit
7e0bf7d57de318f45a097e05644efa49beb65209.
It's possible to make GYP generate an XCode project that produces a .node file,
hence this commit is no longer needed.
Paddy Byers [Tue, 22 Nov 2011 23:49:18 +0000 (23:49 +0000)]
Process symlinked shared library as .node
Paddy Byers [Tue, 22 Nov 2011 23:46:01 +0000 (23:46 +0000)]
Tidy _resolveFilename
Dan VerWeire [Mon, 30 Jan 2012 15:04:20 +0000 (10:04 -0500)]
test: dgram-{broadcast,multicast}-multi-process : prevent false failures
* check exit code of child processes
* wait 1000 ms to exit the child process
* prefix log messages with [PARENT] or [CHILD] to help debugging
* kill all child processes before exiting
Conflicts:
test/simple/test-dgram-multicast-multi-process.js
Bert Belder [Tue, 31 Jan 2012 16:41:46 +0000 (17:41 +0100)]
uv: upgrade to 3eb94e9
Bert Belder [Tue, 31 Jan 2012 15:46:14 +0000 (16:46 +0100)]
Small test-dgram-multicast-multi-process fixes
Somehow windows doesn't want to bind to 224.0.0.1. Let's test with a multicast
address that has no special meaning.
koichik [Mon, 30 Jan 2012 15:16:01 +0000 (00:16 +0900)]
http: fix free http-parser too early
when the status code is 100 (Continue).
Fixes #2636.
Ben Noordhuis [Sun, 29 Jan 2012 22:30:13 +0000 (23:30 +0100)]
timers: add v0.4 compatibility hack
If a timer callback throws and the user's uncaughtException handler ignores the
exception, other timers that expire on the current tick should still run.
If #2582 goes through, this hack should be removed.
Fixes #2631.
isaacs [Sat, 28 Jan 2012 01:07:43 +0000 (17:07 -0800)]
Correct spelling of Ben Noordhuis
isaacs [Sat, 28 Jan 2012 00:54:40 +0000 (16:54 -0800)]
Now working on 0.6.10
isaacs [Fri, 27 Jan 2012 21:33:01 +0000 (13:33 -0800)]
2012.01.27, Version 0.6.9 (stable)
* dgram: Bring back missing functionality for Unix (Dan VerWeire, Roman Shtylman, Ben Noordnuis)
- Note: Windows UDP support not yet complete.
* http: Fix parser memory leak (koichik)
* zlib: Fix #2365 crashes on invalid input (Nicolas LaCasse)
* module: fix --debug-brk on symlinked scripts (Fedor Indutny)
* Documentation Restyling (Matthew Fitzsimmons)
* Update npm to 1.1.0-3 (isaacs)
* Windows: fix regression in stat() calls to C:\ (Bert Belder)
Ben Noordhuis [Sat, 28 Jan 2012 00:30:46 +0000 (01:30 +0100)]
uv: upgrade to 332b72e
Ben Noordhuis [Fri, 27 Jan 2012 23:17:01 +0000 (00:17 +0100)]
uv: upgrade to 16124bb
isaacs [Fri, 27 Jan 2012 21:42:08 +0000 (13:42 -0800)]
stdout ending test message correction
Ben Noordhuis [Fri, 27 Jan 2012 21:16:47 +0000 (22:16 +0100)]
uv: upgrade to 3f1bad2
isaacs [Fri, 27 Jan 2012 21:12:07 +0000 (13:12 -0800)]
Properly update npm to 1.1.0-3
Thanks @mscdex for spotting this.
isaacs [Fri, 27 Jan 2012 01:14:16 +0000 (17:14 -0800)]
Fix #2507 Raise errors less agressively when destroying stdio streams
Also, if an error is already provided, then raise the provided
error, rather than throwing it with a less helpful 'stdout cannot
be closed' message.
This is important for properly handling EPIPEs.
Dan VerWeire [Wed, 25 Jan 2012 17:46:45 +0000 (12:46 -0500)]
test: handle unhandled dgram scenarios
- watch for the death of child processes and fail the test if they all die
- use setTimeout to fail the test if responses are not received and processed in 5000ms
isaacs [Thu, 26 Jan 2012 20:25:51 +0000 (12:25 -0800)]
Update npm to 1.1.0-3
Ben Noordhuis [Thu, 26 Jan 2012 23:53:37 +0000 (00:53 +0100)]
uv: upgrade to 9c76d0d
Fedor Indutny [Tue, 24 Jan 2012 16:45:34 +0000 (22:45 +0600)]
module: fix --debug-brk on symlinked scripts
* fixes #1519
Ben Noordhuis [Mon, 23 Jan 2012 22:52:08 +0000 (23:52 +0100)]
dgram: bring back setTTL()
Ben Noordhuis [Mon, 23 Jan 2012 22:38:25 +0000 (23:38 +0100)]
dgram: bring back setMulticastLoopback()
Ben Noordhuis [Mon, 23 Jan 2012 21:39:49 +0000 (22:39 +0100)]
uv: upgrade to b88bc43
Ben Noordhuis [Mon, 23 Jan 2012 21:38:22 +0000 (22:38 +0100)]
test: fix typos in error messages
Ben Noordhuis [Mon, 23 Jan 2012 21:39:07 +0000 (22:39 +0100)]
test: join multicast group *after* binding
Ben Noordhuis [Mon, 23 Jan 2012 23:04:45 +0000 (00:04 +0100)]
test: remove erroneous dropMembership() call
The socket is not part of any multicast group. Bug wasn't visible until 6999fb3.
Ben Noordhuis [Mon, 23 Jan 2012 20:36:48 +0000 (21:36 +0100)]
dgram: make addMembership() and dropMembership() conform to v0.4 API
- throw on error, don't return an error code
Ben Noordhuis [Mon, 23 Jan 2012 20:28:30 +0000 (21:28 +0100)]
dgram: make setBroadcast() conform to v0.4 API
- don't return a value
Ben Noordhuis [Mon, 23 Jan 2012 20:09:56 +0000 (21:09 +0100)]
dgram: make setMulticastTTL() conform to v0.4 API
- throw if the ttl argument is not a number
- return the ttl argument (not particulary useful but it's what v0.4 did)
Note that the 0 < ttl < 256 check has *not* been reinstated. On Linux, -1 is a
valid argument to setsockopt(IPPROTO_IP, IP_TTL).
isaacs [Mon, 23 Jan 2012 21:53:11 +0000 (13:53 -0800)]
doc: trademark link must be absolute
isaacs [Mon, 23 Jan 2012 21:50:31 +0000 (13:50 -0800)]
doc: Remove default border around logo for MSIE
isaacs [Mon, 23 Jan 2012 10:12:20 +0000 (02:12 -0800)]
doc: Pixel-nudging
isaacs [Mon, 23 Jan 2012 10:07:59 +0000 (02:07 -0800)]
doc: Add images to makefile
isaacs [Mon, 23 Jan 2012 10:07:15 +0000 (02:07 -0800)]
doctool: correct improperly nested ul/li handling
isaacs [Sun, 22 Jan 2012 22:06:17 +0000 (14:06 -0800)]
Add images to doc_assets
Matthew Fitzsimmons [Sun, 22 Jan 2012 04:02:16 +0000 (21:02 -0700)]
Nodejs.org design refresh.
Igor Zinkovsky [Mon, 23 Jan 2012 09:30:56 +0000 (01:30 -0800)]
fix windows build
Igor Zinkovsky [Mon, 23 Jan 2012 09:34:05 +0000 (01:34 -0800)]
upgrade libuv to
edbabe6f83
Ben Noordhuis [Sun, 22 Jan 2012 17:19:10 +0000 (18:19 +0100)]
crypto: silence unused variable warning
`retry` is not used if SSL_PRINT_DEBUG is not defined.
koichik [Sun, 22 Jan 2012 14:23:04 +0000 (23:23 +0900)]
test: fix test/simple/test-net-server-max-connections.js is racey
Fixes #1333.
koichik [Sun, 22 Jan 2012 08:35:28 +0000 (17:35 +0900)]
test: for #2109
Brandon Benvie [Mon, 14 Nov 2011 20:42:14 +0000 (15:42 -0500)]
util: use getOwnPropertyDescripter
Change formatProperty in util.js to use Object.getOwnPropertyDescriptor
instead of __lookup[GS]etter__.
Use the cached value from the descriptor to reduce number of property
lookups from 3 to 1.
Fallback to standard lookup if the descriptor is empty. This doesn't
ever happen with normal JS objects (this function is called only when
the key exists) but apparently does with Node's custom ENV interface.
Fixes: #2109.
koichik [Sun, 22 Jan 2012 05:55:41 +0000 (14:55 +0900)]
http: keep-alive should default with HTTP/1.1 server
As RFC 2616 says we should, assume that servers will provide a persistent
connection by default.
> A significant difference between HTTP/1.1 and earlier versions of
> HTTP is that persistent connections are the default behavior of any
> HTTP connection. That is, unless otherwise indicated, the client
> SHOULD assume that the server will maintain a persistent connection,
> even after error responses from the server.
> HTTP/1.1 applications that do not support persistent connections MUST
> include the "close" connection option in every message.
Fixes #2436.
Dan VerWeire [Tue, 22 Nov 2011 21:04:40 +0000 (16:04 -0500)]
dgram: reintroduce setMulticastTTL()
Removed during the early stages of node 0.5 refactoring to libuv.
Dan VerWeire [Thu, 27 Oct 2011 14:48:38 +0000 (10:48 -0400)]
dgram: reintroduce setBroadcast()
Removed during the early stages of node 0.5 refactoring to libuv.
Roman Shtylman [Wed, 12 Oct 2011 17:55:15 +0000 (13:55 -0400)]
dgram: reintroduce addMembership() and dropMembership()
Removed during the early stages of node 0.5 refactoring to libuv.
Ben Noordhuis [Sat, 21 Jan 2012 02:13:58 +0000 (03:13 +0100)]
uv: upgrade to 497b1ec
koichik [Fri, 20 Jan 2012 12:54:34 +0000 (21:54 +0900)]
http: reduce creating http-parser instances
Fixes #2577.
Nicolas LaCasse [Fri, 20 Jan 2012 14:36:28 +0000 (15:36 +0100)]
Fix #2365 zlib crashing on invalid input
Fix zlib crashes on error due to improper use of removeListener
in the error handler
isaacs [Fri, 20 Jan 2012 05:15:12 +0000 (21:15 -0800)]
Add missing ChangeLog item re: fs.stat improvement
This was a very significant improvement that should have been called out
explicitly.
I added 'review all libuv changes' to my build checklist. It won't
happen again. Sorry, @igorzi.
isaacs [Fri, 20 Jan 2012 05:15:12 +0000 (21:15 -0800)]
Now working on 0.6.9
isaacs [Fri, 20 Jan 2012 01:23:56 +0000 (17:23 -0800)]
2012.01.19, Version 0.6.8 (stable)
* Update V8 to 3.6.6.19
* Numeric key hash collision fix for V8 (Erik Corry, Fedor Indutny)
* Add missing TTY key translations for F1-F5 on Windows (Brandon Benvie)
* path.extname bugfix with . and .. paths (Bert Belder)
* cluster: don't always kill the master on uncaughtException (Ben
* Noordhuis)
* Update npm to 1.1.0-2 (isaacs)
* typed arrays: set class name (Ben Noordhuis)
* zlib binding cleanup (isaacs, Bert Belder)
* dgram: use slab memory allocator (Michael Bernstein)
* fix segfault #2473
isaacs [Fri, 20 Jan 2012 02:07:12 +0000 (18:07 -0800)]
Upgrade V8 to 3.6.6.19
Fedor Indutny [Thu, 19 Jan 2012 15:44:59 +0000 (21:44 +0600)]
Land number collision fix for v8 3.6 by Erik Corry
Update with fixes from: http://codereview.chromium.org/9190001/
Artur Adib [Thu, 19 Jan 2012 15:18:15 +0000 (10:18 -0500)]
docs: document common add-on design patterns
Brandon Benvie [Thu, 29 Dec 2011 07:39:56 +0000 (02:39 -0500)]
Add missing TTY key translations for F1-F5 on Windows
Bert Belder [Wed, 18 Jan 2012 14:09:42 +0000 (15:09 +0100)]
Make path.extname do the right thing when the last path component is . or ..
Closes GH-2526
Ben Noordhuis [Tue, 17 Jan 2012 23:10:22 +0000 (00:10 +0100)]
cluster: don't always kill the master on uncaughtException
uncaughtException handlers installed by the user override the default one that
the cluster module installs, the one that kills off the master process.
Fixes #2556.
Dan Williams [Tue, 17 Jan 2012 04:36:01 +0000 (23:36 -0500)]
docs: replace expresso with mocha in appendix 1
Ryan Dahl [Tue, 17 Jan 2012 19:32:58 +0000 (11:32 -0800)]
Link to Marak's module rap in community page
Bert Belder [Tue, 17 Jan 2012 19:16:49 +0000 (20:16 +0100)]
tests: fix more lint issues
Andreas Madsen [Tue, 17 Jan 2012 18:43:34 +0000 (19:43 +0100)]
Tests: fix jslint issues
Andreas Madsen [Tue, 17 Jan 2012 07:04:50 +0000 (08:04 +0100)]
child_process: add errno property to exceptions
In case of a write failure when using fork() an error would be thrown. The
thrown exception was missing the `errno` property.
Fedor Indutny [Tue, 17 Jan 2012 16:20:28 +0000 (22:20 +0600)]
Land number collision fix for v8 3.6 by Erik Corry
- If V8 snapshots are enabled then the hash is only randomized at build time.
---
backport @10366, @10367 and @10402 to 3.6
Add seed to hash of numeric keyed properties.
Minor cleanups of numeric seeded hashing patch.
Split NumberDictionary into a randomly seeded and an unseeded version.
We don't want to randomize the stub cache.
Review URL: http://codereview.chromium.org/9190001/
koichik [Tue, 17 Jan 2012 08:34:53 +0000 (17:34 +0900)]
tls: fix double 'error' events on HTTPS Requests
Fixes #2549.
Ben Noordhuis [Tue, 17 Jan 2012 15:20:37 +0000 (16:20 +0100)]
typed arrays: set class name
Make obj.toString and Object.prototype.toString work correctly for typed arrays.
isaacs [Mon, 16 Jan 2012 23:06:16 +0000 (15:06 -0800)]
Update npm to 1.1.0-2
Ben Noordhuis [Sat, 14 Jan 2012 01:13:22 +0000 (02:13 +0100)]
net: make .write() throw on bad input
Passing a non-buffer or non-string argument to Socket.prototype.write triggered
an assert:
Assertion failed: (Buffer::HasInstance(args[0])), function Write,
file ../src/stream_wrap.cc, line 289.
Fixes #2532.
Guillermo Rauch [Thu, 12 Jan 2012 22:08:08 +0000 (14:08 -0800)]
website: Add "Api Docs" button next to "Download"
* Added Docs button and `button` class.
* Refactored download button style into `.button`
* Applied color overrides for download/docs buttons.
* Pointed docs link to latest available docs.
mrb [Thu, 12 Jan 2012 04:42:24 +0000 (23:42 -0500)]
dgram: use slab memory allocator
Change udp memory allocation scheme from uv_buf_init to slab allocation. Takes
slab allocation scheme from stream_wrap.
Ben Noordhuis [Thu, 12 Jan 2012 13:41:04 +0000 (14:41 +0100)]
docs: clarify filename argument of vm.* functions
Igor Zinkovsky [Thu, 12 Jan 2012 03:34:56 +0000 (19:34 -0800)]
update libuv to
855764406e
fixes #2521
Fedor Indutny [Wed, 11 Jan 2012 17:46:10 +0000 (23:46 +0600)]
zlib: C++ style fixes
Maciej Małecki [Tue, 10 Jan 2012 22:29:11 +0000 (23:29 +0100)]
makefile: ignore `lib/punycode.js` while linting
`punycode` is a third party code which generates a lot of lint errors.
Upstream was contacted in order to fix it in bestiejs/punycode.js#6, but
request was denied.
Therefore, it's reasonable to exclude this file from linting process.
Ref #2456.
isaacs [Tue, 10 Jan 2012 20:07:30 +0000 (12:07 -0800)]
zlib binding cleanup
* Add assert to prevent parallel writes
* Embed request object instead of using new/delete
* Remove unnecessary WorkReqWrap in favor of uv_work_t
* Use container_of instead of req->data
Along with
2d8af39accc6e1a863aa60ed80289508f3df50e8 and
0ad2717fd88e5ddd28a1c245c78b37bfe9aa4197, this should Fix #2504.
Ryan Dahl [Tue, 10 Jan 2012 20:13:48 +0000 (12:13 -0800)]
Use .jpg instead of .bmp for .msi
smaller.
Ben Noordhuis [Tue, 10 Jan 2012 19:54:40 +0000 (20:54 +0100)]
Make sure that zlib contexts are not garbage collected when busy
Bert Belder [Tue, 10 Jan 2012 19:51:45 +0000 (20:51 +0100)]
Fix memory leak in node_zlib
Ryan Dahl [Mon, 9 Jan 2012 23:29:15 +0000 (15:29 -0800)]
Fix #2473
Tested in production.
See also http://code.google.com/p/v8/issues/detail?id=1889
Ben Noordhuis [Mon, 9 Jan 2012 19:42:11 +0000 (20:42 +0100)]
child_process: fix segfault after failed spawn
The process handle is uninitialized when uv_spawn() fails so don't export the
handle to JS land when that happens. Attempts to close the uninitialized handle
resulted in segmentation faults and memory corruption.
Fixes #2481.
Ben Noordhuis [Mon, 9 Jan 2012 19:39:06 +0000 (20:39 +0100)]
handle_wrap: guard against uninitialized handle or double close
Ben Noordhuis [Mon, 9 Jan 2012 14:45:51 +0000 (15:45 +0100)]
uv: upgrade to 803f5a0
Ryunosuke SATO [Sun, 8 Jan 2012 15:53:17 +0000 (00:53 +0900)]
events: fix checking max listeners with `1`
Fixes #2490.
Ben Noordhuis [Sun, 8 Jan 2012 23:45:19 +0000 (00:45 +0100)]
Avoid unnecessary buffer to string conversion.
Speeds up the benchmark below by about 680% (0.5s versus 3.4s on my Core 2 Duo).
var crypto = require('crypto');
var hash = crypto.createHash('sha1');
var data = new Buffer(1024);
for (var i = 0; i < 128 * 1024; ++i) hash.update(data);
Fixes #2494.
Ben Noordhuis [Sun, 8 Jan 2012 20:17:28 +0000 (21:17 +0100)]
build: honour the PYTHON environment variable
Overrides the path to the python binary. Defaults to `python`.
koichik [Sat, 7 Jan 2012 06:51:51 +0000 (07:51 +0100)]
docs: fix ChangeLog
koichik [Sat, 7 Jan 2012 05:44:35 +0000 (06:44 +0100)]
docs: small changes.
isaacs [Sat, 7 Jan 2012 01:36:39 +0000 (17:36 -0800)]
Now working on v0.6.8
isaacs [Thu, 5 Jan 2012 23:44:04 +0000 (15:44 -0800)]
2012.01.06, Version 0.6.7 (stable)
* V8 hash collision fix (Breaks MIPS) (Bert Belder, Erik Corry)
* Upgrade V8 to 3.6.6.15
* Upgrade npm to 1.1.0-beta-10 (isaacs)
* many doc updates (Ben Noordhuis, Jeremy Martin, koichik, Dave Irvine,
Seong-Rak Choi, Shannen, Adam Malcontenti-Wilson, koichik)
* Fix segfault in node_http_parser.cc
* dgram, timers: fix memory leaks (Ben Noordhuis, Yoshihiro Kukuchi)
* repl: fix repl.start not passing the `ignoreUndefined` arg (Damon Oehlman)
* #1980: Socket.pause null reference when called on a closed Stream (koichik)
* #2263: XMLHttpRequest piped in a writable file stream hang (koichik)
* #2069: http resource leak (koichik)
* buffer.readInt global pollution fix (Phil Sung)
* timers: fix performance regression (Ben Noordhuis)
* #2308, #2246: node swallows openssl error on request (koichik)
* #2114: timers: remove _idleTimeout from item in .unenroll() (James Hartig)
* #2379: debugger: Request backtrace w/o refs (Fedor Indutny)
* simple DTrace ustack helper (Dave Pacheco)
* crypto: rewrite HexDecode without snprintf (Roman Shtylman)
* crypto: don't ignore DH init errors (Ben Noordhuis)
isaacs [Sat, 7 Jan 2012 00:30:46 +0000 (16:30 -0800)]
Remove snapshot from Mac binary build
Ryan Dahl [Sat, 7 Jan 2012 00:20:45 +0000 (16:20 -0800)]
support nosnapshot in vcbuild.bat