platform/upstream/VK-GL-CTS.git
6 years agoFix handling of EGL_NONE as color space
Courtney Goeltzenleuchter [Mon, 11 Sep 2017 23:50:19 +0000 (23:50 +0000)]
Fix handling of EGL_NONE as color space
am: 0d4e616c35

Change-Id: I66cc2f4b168ad67ef3e636a6be34416204cd4274

6 years agoFix handling of EGL_NONE as color space
Courtney Goeltzenleuchter [Mon, 11 Sep 2017 19:06:48 +0000 (13:06 -0600)]
Fix handling of EGL_NONE as color space

Color space of EGL_NONE was getting passed down and
driver threw EGL_BAD_ATTRIBUTE in response.
Issue was caused when changing the colorspace from nullptr
to EGL_NONE, missed a couple of places that needed to
test against EGL_NONE instead of nullptr.

Bug: 65376495
Test: adb -d shell am start \
          -n com.drawelements.deqp/android.app.NativeActivity \
          -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
          --deqp-log-filename=/sdcard/dEQP-Log.qpa"'

Change-Id: If8812725be9d3858bf610c647ba53ff38944dd50

6 years agoMerge changes Id437e220,I9d6b3fba am: 94b6d11640 am: 8a7aa6197d
Kenneth Graunke [Mon, 11 Sep 2017 19:45:03 +0000 (19:45 +0000)]
Merge changes Id437e220,I9d6b3fba am: 94b6d11640 am: 8a7aa6197d
am: ffb306c748

Change-Id: Ifb89181d89ede9381a23e3a3a4a4ce8763ad1a0c

6 years agoMerge changes Id437e220,I9d6b3fba am: 94b6d11640
Kenneth Graunke [Mon, 11 Sep 2017 19:40:36 +0000 (19:40 +0000)]
Merge changes Id437e220,I9d6b3fba am: 94b6d11640
am: 8a7aa6197d

Change-Id: I265da403e05540802aa8f9502c5c0466cf2e0c1b

6 years agoMerge "Use 64-bit math in work group size assertion." am: bc6743fe27 am: 6c4a5cde18
Kenneth Graunke [Mon, 11 Sep 2017 19:36:05 +0000 (19:36 +0000)]
Merge "Use 64-bit math in work group size assertion." am: bc6743fe27 am: 6c4a5cde18
am: b7d0eae501

Change-Id: Id2ce8783b91da42161b40acc26bd751f8333432b

6 years agoMerge changes Id437e220,I9d6b3fba
Kenneth Graunke [Mon, 11 Sep 2017 19:36:02 +0000 (19:36 +0000)]
Merge changes Id437e220,I9d6b3fba
am: 94b6d11640

Change-Id: Ide9468359dc4bdfd9e47a3f5f3aaa345d8096cd8

6 years agoMerge "Delete incorrect invalid map tests." am: 6352f3c7c0 am: 5b357ce430
Kenneth Graunke [Mon, 11 Sep 2017 19:35:51 +0000 (19:35 +0000)]
Merge "Delete incorrect invalid map tests." am: 6352f3c7c0 am: 5b357ce430
am: 223859f5a9

Change-Id: I4e6c265c3b17769b9ba3dcda83323d63fab8217b

6 years agoMerge "Use 64-bit math in work group size assertion." am: bc6743fe27
Kenneth Graunke [Mon, 11 Sep 2017 19:31:58 +0000 (19:31 +0000)]
Merge "Use 64-bit math in work group size assertion." am: bc6743fe27
am: 6c4a5cde18

Change-Id: I2894fbf53a863b6a76281cbe9b7a9614c671dc7f

6 years agoMerge "Delete incorrect invalid map tests." am: 6352f3c7c0
Kenneth Graunke [Mon, 11 Sep 2017 19:31:44 +0000 (19:31 +0000)]
Merge "Delete incorrect invalid map tests." am: 6352f3c7c0
am: 5b357ce430

Change-Id: I7b1f588efdb92ad1c00b6b66d3377df6de184356

6 years agoMerge changes Id437e220,I9d6b3fba
Treehugger Robot [Mon, 11 Sep 2017 19:30:30 +0000 (19:30 +0000)]
Merge changes Id437e220,I9d6b3fba

* changes:
  Allow ES 3.2 contexts to run sRGB write control unsupported test.
  Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable

6 years agoMerge "Use 64-bit math in work group size assertion."
Kenneth Graunke [Mon, 11 Sep 2017 19:27:27 +0000 (19:27 +0000)]
Merge "Use 64-bit math in work group size assertion."
am: bc6743fe27

Change-Id: I8852b7cb4f89e1a7500cf5e216731a9b9f10ae31

6 years agoMerge "Delete incorrect invalid map tests."
Kenneth Graunke [Mon, 11 Sep 2017 19:27:13 +0000 (19:27 +0000)]
Merge "Delete incorrect invalid map tests."
am: 6352f3c7c0

Change-Id: I66916c3bcd4a064719062e3bb87c24c5f6ac2414

6 years agoMerge "Use 64-bit math in work group size assertion."
Treehugger Robot [Mon, 11 Sep 2017 18:58:52 +0000 (18:58 +0000)]
Merge "Use 64-bit math in work group size assertion."

6 years agoMerge "Delete incorrect invalid map tests."
Treehugger Robot [Mon, 11 Sep 2017 18:57:22 +0000 (18:57 +0000)]
Merge "Delete incorrect invalid map tests."

6 years agoAllow ES 3.2 contexts to run sRGB write control unsupported test.
Kenneth Graunke [Sat, 9 Sep 2017 06:30:15 +0000 (23:30 -0700)]
Allow ES 3.2 contexts to run sRGB write control unsupported test.

GL_EXT_sRGB_write_control functionality is not part of ES 3.2.
So there's no need to restrict this to older contexts.

Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_unsupported_enum

Components: AOSP

Change-Id: Id437e220958c66acf65fd5c40004e1fde13fdf64

6 years agoRequire GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable
Kenneth Graunke [Sat, 9 Sep 2017 06:26:15 +0000 (23:26 -0700)]
Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable

This test required GL_EXT_sRGB_write_control or ES 3.2.  But glEnable
and glDisable of GL_FRAMEBUFFER_SRGB requires the extension - ES 3.2
doesn't provide that functionality.  ES 3.2 implementations without the
extension would fail.  Now they report NotSupported.

Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled

Components: AOSP

Change-Id: I9d6b3fba892288354620ecbbc51ef7a351507e43

6 years agoFix regressions in synchronization tests for dedicated allocations
Slawomir Cygan [Sat, 9 Sep 2017 00:09:53 +0000 (00:09 +0000)]
Fix regressions in synchronization tests for dedicated allocations
am: 0e4f9f242d

Change-Id: Iec7cca8af632a5d29a19a5a48b34423f5a764359

6 years agoDelete incorrect invalid map tests.
Kenneth Graunke [Fri, 8 Sep 2017 22:37:38 +0000 (15:37 -0700)]
Delete incorrect invalid map tests.

The citation given in these tests comes from the OpenGL man pages, which
are not authoritative.  The ES 3.2 specification says:

   "6.3.2 Effects of Mapping Buffers on Other GL Commands

    Any GL command which attempts to read from, write to, or change the
    state of a buffer object may generate an INVALID_OPERATION error if
    all or part of the buffer object is mapped. However, only commands
    which explicitly describe this error are required to do so. If an
    error is not generated, using such commands to perform invalid
    reads, writes, or state changes will have undefined results and may
    result in GL interruption or termination."

Importantly, it says "_may_ generate an INVALID_OPERATION error".  Some
drivers choose not to implement this to avoid the CPU overhead required
to enforce this optional restriction.

Affects:
- dEQP-GLES31.functional.debug.negative_coverage.*.vertex_array.*_invalid_map

Components: AOSP

Change-Id: I26eb6ac0dfffbfc50612bed44d1beb6eb3d366c9

6 years agoMerge "Relax EGL functional test thresholds" am: a1ec716449 am: db760778a9
james.glanville [Fri, 8 Sep 2017 21:43:03 +0000 (21:43 +0000)]
Merge "Relax EGL functional test thresholds" am: a1ec716449 am: db760778a9
am: 6fe520433d

Change-Id: I2cfe51fd9842c7c0d4dbae1482a0506c3d5eaf7b

6 years agoMerge "Relax EGL functional test thresholds" am: a1ec716449
james.glanville [Fri, 8 Sep 2017 21:41:01 +0000 (21:41 +0000)]
Merge "Relax EGL functional test thresholds" am: a1ec716449
am: db760778a9

Change-Id: I997bdf950f65300a677703b54ed6262702e52a73

6 years agoMerge "Relax EGL functional test thresholds"
james.glanville [Fri, 8 Sep 2017 21:39:27 +0000 (21:39 +0000)]
Merge "Relax EGL functional test thresholds"
am: a1ec716449

Change-Id: I719ba3fa67da541722ac65f2b5d2c847b98824e0

6 years agoMerge "Relax EGL functional test thresholds"
Treehugger Robot [Fri, 8 Sep 2017 21:25:48 +0000 (21:25 +0000)]
Merge "Relax EGL functional test thresholds"

6 years agoUse 64-bit math in work group size assertion.
Kenneth Graunke [Thu, 13 Jul 2017 01:44:11 +0000 (18:44 -0700)]
Use 64-bit math in work group size assertion.

If the maximum workgroup size in each dimension is large enough, this
can overflow, causing the comparison to fail.  For example, on Intel
Haswell, we get:

   assert(2048 * 2048 * 2048 > 2048) -> assert(0 > 2048) -> fail

Casting one value to deInt64 causes the multiplications to occur as
64-bit values, so we don't overflow.

Affects:

dEQP-GLES31.functional.debug.negative_coverage.*.compute.invalid_maximum_work_group_sizes

Components: AOSP

Change-Id: Ie03627a378f4fdc46ce241bbdd3693ae829c217d

6 years agoFix regressions in synchronization tests for dedicated allocations
Slawomir Cygan [Mon, 31 Jul 2017 12:22:50 +0000 (14:22 +0200)]
Fix regressions in synchronization tests for dedicated allocations

Pass image memory requirements to allocation routine in allocateAndBindMemory.

VK_KHR_get_memory_requirements2 is a device extension (not instance).

Throw NotSupported when external handle requires dedicated allocation,
but 'suballocated' variant of test is being run.

Affects:
dEQP-VK.synchronization.cross_instance.*

Components: Vulkan

VK-GL-CTS issue: 604
Bug: 65490152
Bug: 65202260
Test: Ran tests on couple of Google devices
Change-Id: I3636779459300f5dee2e22b0a2e04762eb7b0601

6 years agoRelax EGL functional test thresholds
james.glanville [Tue, 29 Aug 2017 10:40:53 +0000 (11:40 +0100)]
Relax EGL functional test thresholds

The current threshold of 0.02 was selected as suitable for 8-bit color depths.
However, for smaller bit depths such as RGB565 this threshold is too strict
and it has been relaxed to allow a larger error for low bit depth formats.

Affects:
dEQP-EGL.functional.render.*

Change-Id: I6d6e061be02bc8e63cb5d9662feb804bc839d567

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Alexander Galazin [Fri, 8 Sep 2017 07:13:24 +0000 (09:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: Ied1a7d639c56dbdffd3db89085b4b771741e43f7

6 years agoFix flakiness in mailbox.display_timing
Ian Elliott [Thu, 7 Sep 2017 21:15:30 +0000 (21:15 +0000)]
Fix flakiness in mailbox.display_timing
am: 311129dc01

Change-Id: I3729de1b2b236c54e6008901c485e5c65c9d8f5d

6 years agoChange required sample counts for storage images
Graeme Leese [Wed, 30 Aug 2017 15:37:14 +0000 (16:37 +0100)]
Change required sample counts for storage images

Update the API feature info tests to set requiredSampleCounts to 1 for
all images that are not usable as some type of framebuffer attachment.
Previously images that were not usable as attachments but could be used
as a storage image were incorrectly exempted from the requirement.

Components: Vulkan
VK-GL-CTS Issue: 645
Affects: dEQP-VK.api.info.image_format_properties.*

Change-Id: Ia0d09ad0ff51029b75cd3a264860a3dd63c249fb

6 years agoFix flakiness in mailbox.display_timing
Ian Elliott [Wed, 16 Aug 2017 21:11:57 +0000 (15:11 -0600)]
Fix flakiness in mailbox.display_timing

The "vktWsiDisplayTimingTests.cpp" file was originally written just for
a present mode of VK_PRESENT_MODE_FIFO_KHR.  It has a case at image 80,
where it changes the desiredPresentTime to be 1 second earlier, and then
checks that later.  Such a check doesn't work with
VK_PRESENT_MODE_MAILBOX_KHR, which can throw off the timing of images
(because some images may not be presented).  This has resulted in the
test having random failures.  The "image 80 test" wasn't intended to
occur with MAILBOX, and so it's now being removed.

VK-GL-CTS issue: 622
Components: Vulkan
Affects: dEQP-VK.wsi.*.display_timing.mailbox.display_timing
Bug: 64486630
Test: Build cts and ran scripts/check_build_sanity.py

Change-Id: I9fbd2254b4e6fc1c7bff077c8c0a5229a6d74800

6 years agoFix VK_KHR_maintenance2 extended_usage_bit tests
Boris Zanin [Thu, 7 Sep 2017 07:19:08 +0000 (09:19 +0200)]
Fix VK_KHR_maintenance2 extended_usage_bit tests

Due to test runs over uncompressed formats it cannot include
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR bit.
Remove this bit from the tests.

Update tests:
 * dEQP-VK.image.extended_usage_bit.*

Components: Vulkan

VK-GL-CTS issue: 673, 614

Change-Id: I0adb26c5306a9d5f49936ffef070050fd5936faa

6 years agoFixup some missing/incorrect flushes and invalidates
Gary Sweet [Mon, 4 Sep 2017 10:14:58 +0000 (11:14 +0100)]
Fixup some missing/incorrect flushes and invalidates

Some of the flushes were too small, and there were a few
missing invalidates.

Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test

Components: Vulkan

VK-GL-CTS issue: 660

Change-Id: I27fac24397984f82865683f30b823570c3e52aed

6 years agoMerge "Check for EGL_KHR_gl_colorspace before using it" into oc-mr1-dev
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 21:36:16 +0000 (21:36 +0000)]
Merge "Check for EGL_KHR_gl_colorspace before using it" into oc-mr1-dev
am: e0000e9fa5

Change-Id: I4dda3ae340a7019ab7e4dde0fa49bfc34c06ca41

6 years agoMerge "Check for EGL_KHR_gl_colorspace before using it" into oc-mr1-dev
TreeHugger Robot [Wed, 6 Sep 2017 20:36:37 +0000 (20:36 +0000)]
Merge "Check for EGL_KHR_gl_colorspace before using it" into oc-mr1-dev

6 years agoCheck for EGL_KHR_gl_colorspace before using it am: 2cf32ffa6e am: e3992de385
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 16:53:27 +0000 (16:53 +0000)]
Check for EGL_KHR_gl_colorspace before using it am: 2cf32ffa6e am: e3992de385
am: 0353c8a186

Change-Id: Ie07301231b7c37b8b977d671f048d4fb00b20132

6 years agoCheck for EGL_KHR_gl_colorspace before using it am: 2cf32ffa6e
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 16:47:58 +0000 (16:47 +0000)]
Check for EGL_KHR_gl_colorspace before using it am: 2cf32ffa6e
am: e3992de385

Change-Id: Ia9a47fb3071a9c7d679bebc7343d551c4c7e0317

6 years agoCheck for EGL_KHR_gl_colorspace before using it
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 16:45:57 +0000 (16:45 +0000)]
Check for EGL_KHR_gl_colorspace before using it
am: 2cf32ffa6e

Change-Id: I862ea02e9803fc946a2e71e3145d806f76278676

6 years agoMerge changes Iee2918c1,I3a98fe12 into oc-mr1-dev
Mika Isojarvi [Wed, 6 Sep 2017 16:40:54 +0000 (16:40 +0000)]
Merge changes Iee2918c1,I3a98fe12 into oc-mr1-dev
am: 77827f4212

Change-Id: I26434955a5eb8f2648ceb3f082374db627d358f4

6 years agoMerge changes Iee2918c1,I3a98fe12 into oc-mr1-dev
Mika Isojarvi [Wed, 6 Sep 2017 16:32:19 +0000 (16:32 +0000)]
Merge changes Iee2918c1,I3a98fe12 into oc-mr1-dev

* changes:
  Fix unused uniform bug in EGL robustness tests
  Fix missing SSBO binding in EGL robustness tests

6 years agoUse SRC image layout for copy image to buffer
Slawomir Cygan [Wed, 6 Sep 2017 14:47:04 +0000 (16:47 +0200)]
Use SRC image layout for copy image to buffer

The test was calling vkCmdCopyImageToBuffer with
VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout, which is not a valid
parameter value for this function (and not the layout the image is currently in).

Affects: dEQP-VK.memory.binding.*.*.image_*

Components: Vulkan

VK-GL-CTS issue: 666

Change-Id: Ifb5a1bd8726535de02a0dc134f5ac76a2734a661

6 years agoCheck for EGL_KHR_gl_colorspace before using it
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it

Bug: 65376495
Test: adb -d shell am start \
        -n com.drawelements.deqp/android.app.NativeActivity \
        -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
        --deqp-log-filename=/sdcard/dEQP-Log.qpa"'

Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624
(cherry picked from commit 2cf32ffa6ee9daf7f58e34c1b874f4005e4b888f)

6 years agoCheck for EGL_KHR_gl_colorspace before using it
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it

Bug: 65376495
Test: adb -d shell am start \
        -n com.drawelements.deqp/android.app.NativeActivity \
        -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
        --deqp-log-filename=/sdcard/dEQP-Log.qpa"'

Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624

6 years agoMerge "Add more allowed 'dot' alternatives" am: 7e8c3b2d00 am: c6aef79622
Alexander Galazin [Tue, 5 Sep 2017 21:49:01 +0000 (21:49 +0000)]
Merge "Add more allowed 'dot' alternatives" am: 7e8c3b2d00 am: c6aef79622
am: 2cb24164fd

Change-Id: I96e76b5181661995bd85b235fb61501962be239e

6 years agoMerge "Add more allowed 'dot' alternatives" am: 7e8c3b2d00
Alexander Galazin [Tue, 5 Sep 2017 21:47:03 +0000 (21:47 +0000)]
Merge "Add more allowed 'dot' alternatives" am: 7e8c3b2d00
am: c6aef79622

Change-Id: I498ba85cd282a17b9fdb8a3c5381981a45521739

6 years agoMerge "Add more allowed 'dot' alternatives"
Alexander Galazin [Tue, 5 Sep 2017 21:44:31 +0000 (21:44 +0000)]
Merge "Add more allowed 'dot' alternatives"
am: 7e8c3b2d00

Change-Id: I8ea74cc7658e034905be82c02fafc7f01b4e3705

6 years agoMerge "Add more allowed 'dot' alternatives"
Treehugger Robot [Tue, 5 Sep 2017 21:35:29 +0000 (21:35 +0000)]
Merge "Add more allowed 'dot' alternatives"

6 years agoMerge "resolve merge conflicts of 5b2571349 to oc-mr1-dev-plus-aosp" into oc-mr1...
TreeHugger Robot [Tue, 5 Sep 2017 20:15:32 +0000 (20:15 +0000)]
Merge "resolve merge conflicts of 5b2571349 to oc-mr1-dev-plus-aosp" into oc-mr1-dev-plus-aosp

6 years agoFix unused uniform bug in EGL robustness tests am: 7806d74666 am: 32fe3869a7
Mika Isojrvi [Tue, 5 Sep 2017 19:51:23 +0000 (19:51 +0000)]
Fix unused uniform bug in EGL robustness tests am: 7806d74666 am: 32fe3869a7
am: df1b7de4fd

Change-Id: Ie4698293df88165583c7cf4e81e28b6b93506d70

6 years agoFix unused uniform bug in EGL robustness tests am: 7806d74666
Mika Isojrvi [Tue, 5 Sep 2017 19:49:21 +0000 (19:49 +0000)]
Fix unused uniform bug in EGL robustness tests am: 7806d74666
am: 32fe3869a7

Change-Id: Ic02f5be9192c5295cc56be26f06cd76bf2e6bdde

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojrvi [Tue, 5 Sep 2017 19:47:23 +0000 (19:47 +0000)]
Fix unused uniform bug in EGL robustness tests
am: 7806d74666

Change-Id: I7bdb3742437ed0abe590f5c011bf1b78cade9419

6 years agoDo not use ycbcr formats if ycbcr extension is not supported
Slawomir Cygan [Tue, 5 Sep 2017 14:39:12 +0000 (16:39 +0200)]
Do not use ycbcr formats if ycbcr extension is not supported

Spec says (on "vkGetPhysicalDeviceFormatProperties"):
"format must be a valid VkFormat value"

Formats from future or unsupported extensions do not
constitute a "valid VkFormat values".

Affects: dEQP-VK.memory.requirements.*.image.*

Components: Vulkan

VK-GL-CTS issue: 663

Change-Id: Ia284977b830d5fda14bcbd9d96010995d84014d5

6 years agoresolve merge conflicts of 5b2571349 to oc-mr1-dev-plus-aosp
Mika Isojärvi [Tue, 5 Sep 2017 18:15:08 +0000 (11:15 -0700)]
resolve merge conflicts of 5b2571349 to oc-mr1-dev-plus-aosp

Test: Ran check_build_sanity.py.
Change-Id: I57546248a0851acf9bfdae0ce560e4a2006f2141

6 years agoMerge "Fix missing SSBO binding in EGL robustness tests" am: e19c3ff127 am: fb660dc26b
Mika Isojärvi [Tue, 5 Sep 2017 17:51:14 +0000 (17:51 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests" am: e19c3ff127 am: fb660dc26b
am: 5ac30afb48

Change-Id: I42cf1fabd5887d784eb68f67b68af624788625a8

6 years agoMerge "Require EGL_KHR_gl_colorspace for wide_color tests." into oc-mr1-dev
Mika Isojarvi [Tue, 5 Sep 2017 17:50:15 +0000 (17:50 +0000)]
Merge "Require EGL_KHR_gl_colorspace for wide_color tests." into oc-mr1-dev

6 years agoMerge "Fix missing SSBO binding in EGL robustness tests" am: e19c3ff127
Mika Isojärvi [Tue, 5 Sep 2017 17:43:35 +0000 (17:43 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests" am: e19c3ff127
am: fb660dc26b

Change-Id: I3266c0593f72429a2c3fe3e619cd94d129c2dd63

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests

Bug: 64845766
Bug: 65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127

6 years agoFix missing SSBO binding in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests

Bug: 64845581
Bug: 65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0

6 years agoMerge "Fix missing SSBO binding in EGL robustness tests"
Mika Isojärvi [Tue, 5 Sep 2017 17:33:37 +0000 (17:33 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
am: e19c3ff127

Change-Id: I4eadac66e4d313347a6b3fea1c4585bb98507641

6 years agoMerge changes Iaf75d17e,I3977c3c2,Iff74939d into oc-mr1-dev
Mika Isojarvi [Tue, 5 Sep 2017 17:33:33 +0000 (17:33 +0000)]
Merge changes Iaf75d17e,I3977c3c2,Iff74939d into oc-mr1-dev
am: 5af097b242

Change-Id: I15233b20a5599add0404ec7e92e0a8f44ae6b1e1

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests

Bug: 64845766
Bug: 65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127

6 years agoMerge "Fix missing SSBO binding in EGL robustness tests"
Treehugger Robot [Tue, 5 Sep 2017 17:18:37 +0000 (17:18 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"

6 years agoMerge changes Iaf75d17e,I3977c3c2,Iff74939d into oc-mr1-dev
Mika Isojarvi [Tue, 5 Sep 2017 17:18:22 +0000 (17:18 +0000)]
Merge changes Iaf75d17e,I3977c3c2,Iff74939d into oc-mr1-dev

* changes:
  Use safe glFramebufferTexture* function
  Do not use degenerate frames in EGL tests
  Check for tessellation/geometry extensions being exposed

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 16:17:04 +0000 (16:17 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac am: c3c3b95253 am: 745856554f am: 2b79153434 am: c0fc41f6bc
am: 7221ef9a14

Change-Id: I09771c4622664a3e9fd124d8f13e619f8840e2de

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 16:16:48 +0000 (16:16 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f am: 36b26f80fe am: f909a2d16c am: 3976e3eade am: 4564f27dba
am: 7dbcb49eef

Change-Id: I3baa5c04d94aeb538e88ebe254e51846e3f7a9a3

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 16:16:31 +0000 (16:16 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 6d0cee6923 am: 4fa7f75d5f am: eecfee50a9
am: 40468c5270

Change-Id: I223834ca2c69a6c5ded8138888a2d0b02a62f1fa

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 16:16:16 +0000 (16:16 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac am: c3c3b95253 am: 745856554f am: 2b79153434 am: c0fc41f6bc
am: f7d4fe10ba

Change-Id: I5583ab1de1782090478527f50bd72b9dbaf17592

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 16:16:00 +0000 (16:16 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f am: 36b26f80fe am: f909a2d16c am: 3976e3eade am: 4564f27dba
am: 8dca54a6f8

Change-Id: Ib015feccaea3d1a91315ecc31ba957f85921eafb

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 16:07:56 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac am: c3c3b95253 am: 745856554f am: 2b79153434
am: c0fc41f6bc

Change-Id: I648c5f0e8d281c51625350d93daf2879ad5a430e

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 16:07:54 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac am: c3c3b95253 am: 745856554f am: 2b79153434
am: c0fc41f6bc

Change-Id: Id806b46d9b9c1001a694ae637539fa6f36aa4aea

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 16:07:32 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f am: 36b26f80fe am: f909a2d16c am: 3976e3eade
am: 4564f27dba

Change-Id: I4bac001f8af3ff954aab3258a1187e5f97beb77b

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 16:07:31 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f am: 36b26f80fe am: f909a2d16c am: 3976e3eade
am: 4564f27dba

Change-Id: I18a102999357266e6c37f1da9f7248c6daf11e06

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 16:00:22 +0000 (16:00 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 6d0cee6923 am: 4fa7f75d5f am: eecfee50a9
am: c2f5b4adb2

Change-Id: I8497b1b88f24322244681d1eafecb1a849b23759

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 15:59:55 +0000 (15:59 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac am: c3c3b95253 am: 745856554f
am: 2b79153434

Change-Id: I59da57b654d86c8e5a49068db970566c8e5373d8

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:59:31 +0000 (15:59 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f am: 36b26f80fe am: f909a2d16c
am: 3976e3eade

Change-Id: I6cb9841790f4027016df0c7cf8023ab991334125

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 15:51:16 +0000 (15:51 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac am: c3c3b95253
am: 745856554f

Change-Id: Ie2af4250a408f55c2857629e00b3915e23a5268b

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:51:00 +0000 (15:51 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 6d0cee6923 am: 4fa7f75d5f
am: eecfee50a9

Change-Id: I9949dddd9c57e5817c618e19a67c75393e33b3d5

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:50:59 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 6d0cee6923 am: 4fa7f75d5f
am: eecfee50a9

Change-Id: I3e259b3e82816c11d662a314f21e0c6da68dadb2

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:50:59 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f am: 36b26f80fe
am: f909a2d16c

Change-Id: I3056d6017cd988ff62104131642a22a88b26b24f

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:50:29 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 342eb176e6 am: 1b6fe918aa
am: c1664a16c8

Change-Id: I0f164fa8d88d062e9cb23d5b0ca2b2d89c57320f

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 15:50:28 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283 am: 79f028e0ac
am: c3c3b95253

Change-Id: I62ff995a5e6b0140777b13848af33ece4f6248e8

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 6d0cee6923
am: 4fa7f75d5f

Change-Id: I940607508851c13fd4ae3a35e0eb427f96efc571

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 342eb176e6
am: 1b6fe918aa

Change-Id: I10245b13f72c7b0cc51367f8f0fab516d60538f2

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: ac400ff59f
am: 36b26f80fe

Change-Id: Ie960b01bc31c94107bf7c545aef03b2e9d5671ed

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am...
Pyry Haulos [Tue, 5 Sep 2017 15:41:28 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3 am: 0d9b810283
am: 79f028e0ac

Change-Id: I9523ce132950603adc6a0adf77b9833f670dd6c4

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
am: 342eb176e6

Change-Id: Iad7f205649553e7096d52a0cbf16d868ba405085

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
am: 6d0cee6923

Change-Id: I2c843552baf45bfc918fce8cb7a9c40b3fd8adad

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
am: ac400ff59f

Change-Id: I8fd3f2dac244cddb228d780cb2e7ab4943b1cb9b

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 338a411fd3
am: 0d9b810283

Change-Id: Ic07c0dafc51bf12a82794d02786b885f8b1323f8

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
Pyry Haulos [Tue, 5 Sep 2017 15:22:27 +0000 (15:22 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
am: 9e85a126d2

Change-Id: I86a852a2216971095d4aa256a97f0b8e68e73646

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
am: 9e85a126d2

Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
am: 9e85a126d2

Change-Id: Idf3c0904f9695e04b48901c23c79b7dcd101d0dc

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
am: 338a411fd3

Change-Id: I6edcc0661c9d702a5bb518d24eebf7702145318f

6 years agoFix issues in pipeline.timestamp.transfer_tests
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am: 0f672f2a20

Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e

6 years agoFix issues in pipeline.timestamp.transfer_tests
Pyry Haulos [Tue, 5 Sep 2017 15:13:55 +0000 (15:13 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am: 0f672f2a20

Change-Id: I41d95ce51483f786706f9402701208801e73ecdc

6 years agoFixup some missing/incorrect flushes and invalidates
Gary Sweet [Mon, 4 Sep 2017 09:39:36 +0000 (10:39 +0100)]
Fixup some missing/incorrect flushes and invalidates

Some of the flushes were too small, and there were a few
missing invalidates.

Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test

Components: Vulkan

VK-GL-CTS issue: 660

Change-Id: Id29b59d127e004a028c04a1075db563d697140a1

6 years agoAdd more allowed 'dot' alternatives
Alexander Galazin [Tue, 22 Aug 2017 13:59:49 +0000 (15:59 +0200)]
Add more allowed 'dot' alternatives

Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.

Components: AOSP

VK-GL-CTS issue: 634
Google issue: 28767510

Affects:
dEQP-GLES3.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES3.functional.shaders.builtin_functions.precision.reflect.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.reflect.*

Change-Id: I2a91add1b92363acab2172179320cd880da779ec

6 years agoUse safe glFramebufferTexture* function
james.glanville [Wed, 16 Aug 2017 10:50:19 +0000 (11:50 +0100)]
Use safe glFramebufferTexture* function

glFramebufferTexture() is only supported when GL_EXT_geometry_shader is
present. Use glFramebufferTextureLayer() instead so that testing is
possible on unextended ES3.1 contexts.

Components: AOSP
Bug: 65317295
Test: Ran tests on couple of Google devices
Affects:
dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.framebuffer_texture_level

Change-Id: Iaf75d17e5d1077c1a6f591c3ebfca62c465d4378

6 years agoDo not use degenerate frames in EGL tests
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests

The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).

Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.

Bug: 65317274
Test: Ran tests on couple of Google devices
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28

6 years agoCheck for tessellation/geometry extensions being exposed
Alexander Galazin [Fri, 11 Aug 2017 09:03:50 +0000 (11:03 +0200)]
Check for tessellation/geometry extensions being exposed

Some sample_variables tests use tessellation/geometry shaders.
Need to check that the relevant extensions are exposed.

Components: AOSP

Affects:
dEQP-GLES31.functional.debug.negative_coverage.*.oes_sample_variables.access_built_in_types_inside_other_shaders

Bug: 65317039
Test: Run tests on couple of Google devices
Change-Id: Iff74939d474082938955e5b7ebfc41ea3b4a6ec5

6 years agoFix texture mip level size in framebuffer fetch tests
Mika Isojrvi [Fri, 1 Sep 2017 20:54:47 +0000 (20:54 +0000)]
Fix texture mip level size in framebuffer fetch tests
am: b88e73b07e

Change-Id: I4fdbdd3755dc06b3918a2e48c37bae905be7ebb8

6 years agoRequire EGL_KHR_gl_colorspace for wide_color tests.
Tapani Pälli [Mon, 28 Aug 2017 06:20:53 +0000 (09:20 +0300)]
Require EGL_KHR_gl_colorspace for wide_color tests.

These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.

v2: loosen the check, only check when enum in use (Courtney)
Test: adb -d shell am start \
    -n com.drawelements.deqp/android.app.NativeActivity \
    -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
    --deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug: 65291400

Change-Id: I891a6fdcce49ac6dcd42577076d4cf64a143dd38
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>