platform/upstream/gst-plugins-bad.git
8 years agoglvideoconvert: RG/LA is available in OpenGL ES 3, so let that through
Olivier Crête [Thu, 30 Jun 2016 03:55:18 +0000 (23:55 -0400)]
glvideoconvert: RG/LA is available in OpenGL ES 3, so let that through

8 years agovtdec: use L/LA textures on GLES2 as well
Matthew Waters [Wed, 29 Jun 2016 08:35:17 +0000 (18:35 +1000)]
vtdec: use L/LA textures on GLES2 as well

8 years agoRevert "Revert "gl/eagl: try getting a gles3 context""
Matthew Waters [Fri, 24 Jun 2016 03:41:11 +0000 (13:41 +1000)]
Revert "Revert "gl/eagl: try getting a gles3 context""

This reverts commit eb142736318463e6e553c21707ba0d716f85a46f.

vtdec now successfully outputs textures that can be converted by
glcolorconvert in GLES3 contexts.

8 years agovtdec: add support for zerocopy decoding with GLES 3.x
Matthew Waters [Fri, 24 Jun 2016 14:05:37 +0000 (00:05 +1000)]
vtdec: add support for zerocopy decoding with GLES 3.x

It seems that Red/RG textures aren't supported anymore for zerocopy decoding
with GLES 3.x.  Instead use Luminance/Luminance Alpha textures which are.

8 years agoglmemory: add the texture type to allocate to parameters
Matthew Waters [Tue, 28 Jun 2016 03:51:22 +0000 (13:51 +1000)]
glmemory: add the texture type to allocate to parameters

Rather than assuming something.  e.g. zerocopy on iOS with GLES3 requires
the use of Luminance/Luminance Alpha formats and does not work with
Red/RG textures.

8 years agoglcolorconvert: don't assume Red/RG textures will be used
Matthew Waters [Tue, 28 Jun 2016 03:09:51 +0000 (13:09 +1000)]
glcolorconvert: don't assume Red/RG textures will be used

Take the used texture type from the memory instead.

Fixes conversion from multi-planar YUV formats with two components per plane
(NV12, NV21, YUY2, UYVY, GRAY16_*, etc) with Luminance Alpha input textures.

This is also needed for zerocopy decoding on iOS with GLES 3.x.

8 years agoglcontext: correct precondition for get_gl_version
Matthew Waters [Tue, 28 Jun 2016 03:02:32 +0000 (13:02 +1000)]
glcontext: correct precondition for get_gl_version

The intention was to assert if both maj and min were NULL (as there would be no
point calling the function).  Instead if either maj or min were NULL, the assert
would occur.

Fix that.

8 years agod3dvideosink: Replace some more gst_caps_to_string() with GST_PTR_FORMAT
Sebastian Dröge [Tue, 28 Jun 2016 16:26:29 +0000 (19:26 +0300)]
d3dvideosink: Replace some more gst_caps_to_string() with GST_PTR_FORMAT

https://bugzilla.gnome.org/show_bug.cgi?id=768146

8 years agod3dvideosink: leak on caps string
Jonathan Roy [Tue, 28 Jun 2016 15:50:59 +0000 (11:50 -0400)]
d3dvideosink: leak on caps string

https://bugzilla.gnome.org/show_bug.cgi?id=768146

8 years agojpeg2000parse: fix typo in sampling check
Luis de Bethencourt [Tue, 28 Jun 2016 10:08:22 +0000 (11:08 +0100)]
jpeg2000parse: fix typo in sampling check

Fixing small typo that changes the value of the return.

8 years agotests: Ignore kmssink for state change test
Olivier Crête [Tue, 28 Jun 2016 01:36:50 +0000 (21:36 -0400)]
tests: Ignore kmssink for state change test

It can only be put to READY if the DRM stuff is available.

8 years agoqmlglsink: Fix build error when don't have QPA installed.
Haihua Hu [Mon, 27 Jun 2016 10:15:08 +0000 (18:15 +0800)]
qmlglsink: Fix build error when don't have QPA installed.

Check header file existance and wrap the header file include
in the necessary #ifdef to avoid build error.

https://bugzilla.gnome.org/show_bug.cgi?id=767553

8 years agodvbbasebin: make sure we have an error in case of parsing failure
Reynaldo H. Verdejo Pinochet [Sat, 25 Jun 2016 01:14:06 +0000 (18:14 -0700)]
dvbbasebin: make sure we have an error in case of parsing failure

Drop a redundant comment and rellocate another one while at it.

8 years agodvb/parsechannels: implement channels.conf format autodetection
Reynaldo H. Verdejo Pinochet [Wed, 22 Jun 2016 23:14:33 +0000 (16:14 -0700)]
dvb/parsechannels: implement channels.conf format autodetection

Simple autodetection avoids having to call the parsers
one after the other.

8 years agodvb/parsechannels: rename v5/zap parsers for congruency
Reynaldo H. Verdejo Pinochet [Tue, 21 Jun 2016 23:08:57 +0000 (16:08 -0700)]
dvb/parsechannels: rename v5/zap parsers for congruency

Add function prototypes while at it.

8 years agodvb/parsechannels: fix modulation names
Reynaldo H. Verdejo Pinochet [Wed, 13 Apr 2016 04:04:25 +0000 (21:04 -0700)]
dvb/parsechannels: fix modulation names

Some names were incorrect. Authoritative source for
the dvbv5 format taken from v4l-utils' lib/libdvbv5/dvb-v5.c

Aditionally, add the missing setter mapping for the
modulation param.

This change makes ATSC work.

https://bugzilla.gnome.org/show_bug.cgi?id=764957

8 years agodvbbasebin: also accept DVBv5 channels.conf format
Thiago Santos [Thu, 25 Feb 2016 00:44:40 +0000 (21:44 -0300)]
dvbbasebin: also accept DVBv5 channels.conf format

Confirmed working with ISDB-T & ATSC conf files.

https://bugzilla.gnome.org/show_bug.cgi?id=764957

8 years agodvbsrc: fix ISDB-T property descriptions
Reynaldo H. Verdejo Pinochet [Tue, 21 Jun 2016 18:48:36 +0000 (11:48 -0700)]
dvbsrc: fix ISDB-T property descriptions

Drop some stale trailing whitespace while at it.

8 years agodvbsrc: fix misplaced space on doc block
Reynaldo H. Verdejo Pinochet [Tue, 21 Jun 2016 18:32:07 +0000 (11:32 -0700)]
dvbsrc: fix misplaced space on doc block

8 years agoh264parse: When input alignment=AU, always drain each packet.
Jan Schmidt [Mon, 9 May 2016 17:32:59 +0000 (03:32 +1000)]
h264parse: When input alignment=AU, always drain each packet.

If the input alignment claims AU alignment, each received
buffer should contain a complete video frame, so never hold over parts
of buffers for later processing. Also reduces latency, as packets
are parsed/converted and output immediately instead of 1 buffer
later.

Fixes a problem where an (arguably disallowed) padding byte on the
end of a buffer is detected as an extra byte in the following
start code, and messes up the timestamping that should apply to
that start code.

8 years agowin32: update codecparsers .def file for new symbols
Tim-Philipp Müller [Fri, 24 Jun 2016 12:05:24 +0000 (13:05 +0100)]
win32: update codecparsers .def file for new symbols

8 years agoopenjpeg: fix more broken includes
Tim-Philipp Müller [Fri, 24 Jun 2016 08:41:18 +0000 (09:41 +0100)]
openjpeg: fix more broken includes

8 years agovideoparsers: fix broken include
Tim-Philipp Müller [Fri, 24 Jun 2016 08:39:00 +0000 (09:39 +0100)]
videoparsers: fix broken include

8 years agojpeg2000parse: use enums for colorspace and sampling, rather than strings
Aaron Boxer [Tue, 21 Jun 2016 16:41:46 +0000 (12:41 -0400)]
jpeg2000parse: use enums for colorspace and sampling, rather than strings

Also, move gstjpeg2000sampling to codecparsers project

https://bugzilla.gnome.org/show_bug.cgi?id=767908

8 years agoconfigure: Need to add -DGST_STATIC_COMPILATION when building only statically
Nirbheek Chauhan [Thu, 23 Jun 2016 20:27:13 +0000 (01:57 +0530)]
configure: Need to add -DGST_STATIC_COMPILATION when building only statically

https://bugzilla.gnome.org/show_bug.cgi?id=767463

8 years agoeglimage: Only register debug category if dmabuf support is enabled
Sebastian Dröge [Thu, 23 Jun 2016 12:57:58 +0000 (15:57 +0300)]
eglimage: Only register debug category if dmabuf support is enabled

It's not used otherwise currently and causes compiler warnings.

8 years agowebrtcdsp: Offset timestamp with duration
Nicolas Dufresne [Thu, 23 Jun 2016 02:28:03 +0000 (22:28 -0400)]
webrtcdsp: Offset timestamp with duration

The saved timestamp is used to compute the delay of the probe data.
As it's used at the following incoming buffer, it needs to be offset
with the duration of the buffer to represent the end position. Also,
properly initialize the saved timestamp and protect against TIME_NONE.

8 years agowebrtcdsp: Synchronize with delays
Nicolas Dufresne [Thu, 23 Jun 2016 01:54:13 +0000 (21:54 -0400)]
webrtcdsp: Synchronize with delays

Until now, we were synchronizing both DSP and Probe adapter by
waiting and clipping the probe adapter data. This increases the CPU
usage, can cause copies if the audio is not 10ms aligned and the worst
is that it prevents the processing from compensating for inaccurate
latency. This is also a step forward toward supporting playback
filters.

8 years agowebrtdsp: Remove restriction on channels number
Nicolas Dufresne [Thu, 23 Jun 2016 01:45:08 +0000 (21:45 -0400)]
webrtdsp: Remove restriction on channels number

Unlike 0.1, in 0.2 the reverse stream can have different number of
channels. Remove the check that restrict it.

8 years agowebrtcdsp: Style fix
Nicolas Dufresne [Thu, 23 Jun 2016 01:44:35 +0000 (21:44 -0400)]
webrtcdsp: Style fix

8 years agovtdec: minimize renegotiation to make hw decoding more reliable
Alessandro Decina [Thu, 16 Jun 2016 04:18:18 +0000 (14:18 +1000)]
vtdec: minimize renegotiation to make hw decoding more reliable

The hardware decoder can become (temporarily) unavailable across
VTDecompressionSessionCreate/Destroy calls. During negotiation if the currently
configured caps are still accepted by downstream we keep using them so we don't
have to destroy and recreate the decoding session.

This indirectly fixes https://bugzilla.gnome.org/show_bug.cgi?id=767429, by
making vtdec stick to GLMemory.

8 years agoqmlglsink: add win32 support
Matthew Waters [Thu, 16 Jun 2016 05:13:02 +0000 (15:13 +1000)]
qmlglsink: add win32 support

The current state of c++ ABI's on Window's and Gst's/Qt's conflicting
mingw builds means that we cannot use mingw for building the qt plugin.

Instead, a qmake .pro file is provided that is expected to be used with the
msvc binaries provided by Qt like so:

(with the PATH environment variable containing the path to the qt biniaries
and PKG_CONFIG_PATH containing the path to GStreamer modules)
cd /path/to/sources/gst-plugins-bad/ext/qt
qmake -tp vc

Then open the resulting VS project and build the library.  Then

cp debug/libgstqtsink.dll /path/to/prefix/lib/gstreamer-1.0/libgstqtsink.cll

https://bugzilla.gnome.org/show_bug.cgi?id=761260

8 years agoAdd missing file to gitignore
Nicolas Dufresne [Tue, 21 Jun 2016 15:40:22 +0000 (11:40 -0400)]
Add missing file to gitignore

8 years agodoc: Automatic update
Nicolas Dufresne [Mon, 20 Jun 2016 22:52:00 +0000 (18:52 -0400)]
doc: Automatic update

This is an automatic update with manual merges of running
"make update" in the doc/plugins directory. This should help
later maintenance of the plugins doc. A lot of plugin are
not referenced yet in the doc. Will come later.

8 years agodoc: Add .cpp files to doc parser
Nicolas Dufresne [Mon, 20 Jun 2016 20:30:19 +0000 (16:30 -0400)]
doc: Add .cpp files to doc parser

Also, complete the list of directory that need to be visited.

8 years agowebrtcdsp: Add WebRTC Audio Processing support
Nicolas Dufresne [Mon, 6 Jun 2016 19:10:05 +0000 (15:10 -0400)]
webrtcdsp: Add WebRTC Audio Processing support

This DSP library can be used to enhance voice signal for real time
communication call. In implements multiple filters like noise reduction,
high pass filter, echo cancellation, automatic gain control, etc.

The webrtcdsp element can be used along, or with the help of the
webrtcechoprobe if echo cancellation is enabled. The echo probe should
be placed as close as possible to the audio sink, while the DSP is
generally place close to the audio capture. For local testing, one can
use an echo loop pipeline like the following:

  autoaudiosrc ! webrtcdsp ! webrtcechoprobe ! autoaudiosink

This pipeline should produce a single echo rather then repeated echo.
Those elements works if they are placed in the same top level pipeline.

https://bugzilla.gnome.org/show_bug.cgi?id=767800

8 years agoAutomatic update of common submodule
Nicolas Dufresne [Tue, 21 Jun 2016 15:46:44 +0000 (11:46 -0400)]
Automatic update of common submodule

From ac2f647 to f363b32

8 years agoglcontext/wgl: try wglCreateContextAttribsARB even not gl3 core profile
Wang Xin-yu (王昕宇) [Tue, 22 Mar 2016 08:51:53 +0000 (16:51 +0800)]
glcontext/wgl: try wglCreateContextAttribsARB even not gl3 core profile

https://bugzilla.gnome.org/show_bug.cgi?id=764018

8 years agoglcontext: fix get_current_gl_api() on win32
Matthew Waters [Tue, 21 Jun 2016 08:28:46 +0000 (18:28 +1000)]
glcontext: fix get_current_gl_api() on win32

Another case of incorrect calling conventions.

Using this function on win32 would corrupt the stack pointer and end in
massive hilarity.

8 years agoglsl: fixup external-oes shaders by mangling the required extension
Matthew Waters [Wed, 15 Jun 2016 02:47:05 +0000 (12:47 +1000)]
glsl: fixup external-oes shaders by mangling the required extension

Newer devices require using a different GLSL extension for accessing
external-oes textures in a shader using the texture() functions.

While the GL_OES_EGL_image_external_essl3 should supposedly be supported
on a any GLES3 android device, the extension was defined after a lot of the
older drivers were built so they will not know about it.  Thus there are two
possible interpretations of which of texture[2D]() should be supported for
external-oes textures.  Strict adherence to the GL_OES_EGL_image_external
extension spec which uses texture2D() or following GLES3's pattern, also
allowing texture() as a function for accessing external-oes textures

This adds another mangling pass to convert
 #extension GL_OES_EGL_image_external : ...
into
 #extension GL_OES_EGL_image_external_essl3 : ...
on GLES3 and when the GL_OES_EGL_image_external_essl3 extension is supported.

Only uses texture() when the GLES3 and the GL_OES_EGL_image_external_essl3
extension is supported for external-oes textures.
Uses GLES2 + texture2D() + GL_OES_EGL_image_external in all other external-oes
cases.

https://bugzilla.gnome.org/show_bug.cgi?id=766993

8 years agowinks: Port to MSVC and pretend to be Windows XP
Nirbheek Chauhan [Tue, 24 May 2016 10:56:24 +0000 (16:26 +0530)]
winks: Port to MSVC and pretend to be Windows XP

strcasecmp is not defined on MSVC, so just use the glib wrapper. Also pretend to
be Windows XP explicitly since the API we use was deprecated and removed
(ifdef-ed) from the SDK after this version of Windows. This will be especially
relevant once we stop supporting Windows XP soon:

https://bugzilla.gnome.org/show_bug.cgi?id=756866

8 years agowin32: Add missing def files for libraries
Nirbheek Chauhan [Tue, 1 Mar 2016 20:47:54 +0000 (02:17 +0530)]
win32: Add missing def files for libraries

8 years agobuild: Factor out endian-order RGB formats
Nirbheek Chauhan [Tue, 1 Mar 2016 19:25:15 +0000 (00:55 +0530)]
build: Factor out endian-order RGB formats

MSVC seems to ignore preprocessor conditionals inside static pad templates

8 years agoopenjpegdec: use sampling field to determine RGB channel
Aaron Boxer [Tue, 14 Jun 2016 02:29:39 +0000 (22:29 -0400)]
openjpegdec: use sampling field to determine RGB channel

https://bugzilla.gnome.org/show_bug.cgi?id=767402

8 years agotemplatematch: fix buffer leak in test
Guillaume Desmottes [Thu, 2 Jun 2016 11:53:38 +0000 (13:53 +0200)]
templatematch: fix buffer leak in test

Need to call gst_check_drop_buffers() to unref the buffers exchanged
during the test.

https://bugzilla.gnome.org/show_bug.cgi?id=767159

8 years agoglimagesink: fix query leak in test
Guillaume Desmottes [Thu, 19 May 2016 10:31:56 +0000 (13:31 +0300)]
glimagesink: fix query leak in test

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agoglimagesink: properly setup/teardown tests
Guillaume Desmottes [Thu, 19 May 2016 10:29:15 +0000 (13:29 +0300)]
glimagesink: properly setup/teardown tests

tcase_add_checked_fixture() is suppose to call the setup and teardown
functions so the tests don't have to do it manually.

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agoglupload: fix shader leak in test
Guillaume Desmottes [Thu, 19 May 2016 10:09:41 +0000 (13:09 +0300)]
glupload: fix shader leak in test

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agouvch264demux: fix buffer leaks in test
Guillaume Desmottes [Thu, 19 May 2016 09:51:17 +0000 (12:51 +0300)]
uvch264demux: fix buffer leaks in test

The mock chain functions aren't unreffing the buffers so the caller
should do it.

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agocamerabin: fix element leak in test
Guillaume Desmottes [Thu, 19 May 2016 09:36:42 +0000 (12:36 +0300)]
camerabin: fix element leak in test

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agofix buffer leaks in tests
Guillaume Desmottes [Thu, 19 May 2016 08:19:57 +0000 (11:19 +0300)]
fix buffer leaks in tests

gst_check_drop_buffers() release the buffers exchanged during the test.

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agofix event leaks in tests
Guillaume Desmottes [Thu, 19 May 2016 08:19:20 +0000 (11:19 +0300)]
fix event leaks in tests

The events are supposed to be unreffed when finishing the test, not
reffed.

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agoaudiointerleave: fix message leaks by flushing the bus
Guillaume Desmottes [Thu, 19 May 2016 08:19:01 +0000 (11:19 +0300)]
audiointerleave: fix message leaks by flushing the bus

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agoaudioaggregator: fix buffer leak
Guillaume Desmottes [Thu, 19 May 2016 08:16:37 +0000 (11:16 +0300)]
audioaggregator: fix buffer leak

If the pad was still owning a buffer when being destroyed it was leaked.

Fix a leak with the test_flush_start_flush_stop test.

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agoautoconvert: fix factories leak in test
Guillaume Desmottes [Wed, 18 May 2016 13:58:44 +0000 (16:58 +0300)]
autoconvert: fix factories leak in test

The factories returned by gst_registry_find_feature() have to be
unreffed.

https://bugzilla.gnome.org/show_bug.cgi?id=766663

8 years agoh264parse: fix default time_offset_length
Michael Olbrich [Fri, 17 Jun 2016 12:58:44 +0000 (14:58 +0200)]
h264parse: fix default time_offset_length

The default value for time_offset_length should be 24, see
section E2.2 of the H264 spec.

https://bugzilla.gnome.org/show_bug.cgi?id=767792

8 years agodc1394src: check for disabled transmission in _stop_cam
Joan Pau Beltran [Fri, 17 Jun 2016 12:31:42 +0000 (14:31 +0200)]
dc1394src: check for disabled transmission in _stop_cam

For symetry with _start_cam, check that the transmission
is effectively disabled in _stop_cam.

https://bugzilla.gnome.org/show_bug.cgi?id=763026

8 years agodvbsrc: do not rely on temp var for fail detection
Reynaldo H. Verdejo Pinochet [Fri, 17 Jun 2016 22:32:08 +0000 (15:32 -0700)]
dvbsrc: do not rely on temp var for fail detection

Use errno instead as local var might be overwritten
before the check.

8 years agodvbsrc: rework set_pids()
Reynaldo H. Verdejo Pinochet [Tue, 14 Jun 2016 22:29:08 +0000 (15:29 -0700)]
dvbsrc: rework set_pids()

- Reflow to avoid unneeded nesting
- Free aux pids array earlier
- Adjust debug output to deliver more meaningful information

8 years agodvbsrc: drop pointless debug msg
Reynaldo H. Verdejo Pinochet [Tue, 14 Jun 2016 21:24:35 +0000 (14:24 -0700)]
dvbsrc: drop pointless debug msg

8 years agocodecparsers: drop all otherwizes
Reynaldo H. Verdejo Pinochet [Thu, 9 Jun 2016 23:05:39 +0000 (16:05 -0700)]
codecparsers: drop all otherwizes

8 years agojpeg2000parse: support j2c format
Aaron Boxer [Sun, 12 Jun 2016 17:53:18 +0000 (13:53 -0400)]
jpeg2000parse: support j2c format

https://bugzilla.gnome.org/show_bug.cgi?id=767512

8 years agotests/glcontext: link against gstvideo for gst_video_info_*
Matthew Waters [Wed, 15 Jun 2016 15:54:16 +0000 (01:54 +1000)]
tests/glcontext: link against gstvideo for gst_video_info_*

fixes make distcheck complaining about it.

8 years agoqml: Enable qmlglsink for eglfs
Sergey Borovkov [Thu, 14 Apr 2016 15:14:32 +0000 (18:14 +0300)]
qml: Enable qmlglsink for eglfs

https://bugzilla.gnome.org/show_bug.cgi?id=763044

8 years agoqmlglsink: propagate GL context creation failure upwards
Matthew Waters [Wed, 15 Jun 2016 14:44:48 +0000 (00:44 +1000)]
qmlglsink: propagate GL context creation failure upwards

Otherwise an application cannot know if the qmlglsink will be displaying frames
incorrectly/at all.

8 years agoqmlglsink: also allow wayland-egl as a platform name
Matthew Waters [Wed, 15 Jun 2016 14:44:16 +0000 (00:44 +1000)]
qmlglsink: also allow wayland-egl as a platform name

8 years agoqmlglsink: Add Wayland support
Haihua Hu [Sun, 12 Jun 2016 07:35:28 +0000 (15:35 +0800)]
qmlglsink: Add Wayland support

Don't use gstgldisplay to get wayland display. Should use QPA on wayland
to get wayland display for QT.

https://bugzilla.gnome.org/show_bug.cgi?id=767553

8 years agotests/glcontext: update test for gen,del_texture removal
Matthew Waters [Wed, 15 Jun 2016 14:46:57 +0000 (00:46 +1000)]
tests/glcontext: update test for gen,del_texture removal

8 years agoladspa: simplify registry cache structure creation
Stefan Sauer [Tue, 14 Jun 2016 20:12:18 +0000 (22:12 +0200)]
ladspa: simplify registry cache structure creation

Create and fill structure in one go.

8 years agogleffects: fix little rectangle that appears at the center of squeeze and tunnel...
Haihua Hu [Tue, 14 Jun 2016 05:48:09 +0000 (13:48 +0800)]
gleffects: fix little rectangle that appears at the center of squeeze and tunnel effects

These two shader will calculate the vector length and use it as denominator.
But length could be zero which will cause undefine behaviour. Add protection for
this condition

https://bugzilla.gnome.org/show_bug.cgi?id=767635

8 years agoglsl: add some debugging
Matthew Waters [Wed, 15 Jun 2016 08:10:59 +0000 (18:10 +1000)]
glsl: add some debugging

8 years agoglutils: remove unused functions for texture creation/deletion
Matthew Waters [Wed, 15 Jun 2016 06:08:57 +0000 (16:08 +1000)]
glutils: remove unused functions for texture creation/deletion

Everyone uses GstGLMemory now and any future code should as well.

8 years agoglfilter: remove unused class fields in/out_tex_id
Matthew Waters [Wed, 15 Jun 2016 05:47:47 +0000 (15:47 +1000)]
glfilter: remove unused class fields in/out_tex_id

The functionality is not used by any subclass nor are the values set anywhere.

8 years agogldeinterlace: remove dead code accessing filter->in_tex_id
Matthew Waters [Wed, 15 Jun 2016 05:08:39 +0000 (15:08 +1000)]
gldeinterlace: remove dead code accessing filter->in_tex_id

It's not set by anyone or anything and gldeinterlace is the only user of it now.

8 years agogl/upload/meta: remove unneeded texture deletion
Matthew Waters [Wed, 15 Jun 2016 04:40:40 +0000 (14:40 +1000)]
gl/upload/meta: remove unneeded texture deletion

The textures are managed by the GstGLMemory inside the output buffer.  Freeing
them prematurely may result in a use-after-free.

8 years agosrtpenc: remove get-rollover-counter signal and add stats property
Aleix Conchillo Flaqué [Mon, 30 May 2016 12:10:23 +0000 (14:10 +0200)]
srtpenc: remove get-rollover-counter signal and add stats property

We remove get-rollover-counter signal in favor of the "stats"
property. The "stats" property is a GstStructure with caps
application/x-srtp-encoder-stats that contains an array of
structures with caps application/x-srtp-stream.
Each stream structure contains "ssrc" and "roc" fields.

https://bugzilla.gnome.org/show_bug.cgi?id=733265

8 years agoh264parse: support for handling of config-interval = -1
Mats Lindestam [Wed, 25 May 2016 10:55:36 +0000 (12:55 +0200)]
h264parse: support for handling of config-interval = -1

Added support for handling of config-interval = -1.
config-inteval = -1 represents resending SPS and PPS for each
I-/IDR-frame.

https://bugzilla.gnome.org/show_bug.cgi?id=766803

8 years agoh264parse: refactored handling of SPS/PPS when pushing frames
Mats Lindestam [Wed, 25 May 2016 10:45:17 +0000 (12:45 +0200)]
h264parse: refactored handling of SPS/PPS when pushing frames

https://bugzilla.gnome.org/show_bug.cgi?id=766803

8 years agoh264parse: change "config-interval" property type from uint to int
Mats Lindestam [Wed, 25 May 2016 09:54:55 +0000 (11:54 +0200)]
h264parse: change "config-interval" property type from uint to int

So we can use -1 as special value like in rtph264pay.

https://bugzilla.gnome.org/show_bug.cgi?id=766803

8 years agoavfassetsrc: Don't escape the URI before passing it to NSURL
Sebastian Dröge [Mon, 13 Jun 2016 06:20:22 +0000 (09:20 +0300)]
avfassetsrc: Don't escape the URI before passing it to NSURL

The URI must already be escaped by the caller, we don't support passing around
invalid (unescaped) URIs via the GstURIHandler interface.

Also it will escape too much of the URI in this case, e.g.
  ipod-library://item/item.m4a?id=3143338395173862951
becomes
  ipod-library://item/item.m4a%3Fid%3D3143338395173862951

https://bugzilla.gnome.org/show_bug.cgi?id=767492

8 years agoiosassetsrc: Print the correct URI if it was rejected
Sebastian Dröge [Mon, 13 Jun 2016 06:20:02 +0000 (09:20 +0300)]
iosassetsrc: Print the correct URI if it was rejected

We were printing the previously set URI instead of the new one.

8 years agocurlsmtpsink: Lock and don't send final boundary upon error
Sebastian Rasmussen [Wed, 8 Jun 2016 23:20:36 +0000 (01:20 +0200)]
curlsmtpsink: Lock and don't send final boundary upon error

Previously GstCurlSmtpSink could cause the pipeline thread to end up
waiting for a stopped thread to perform work.

The scenario was that the sink could be rendering a buffer and waiting
for the curl transfer thread to have sent the data. As soon as the
transfer thread has copied all data to curl's data buffer in
gst_curl_base_sink_transfer_read_cb() then the render call would stop
waiting and return GST_FLOW_OK. While this takes place the transfer
thread may suffer from an error e.g. due gst_poll_wait() timing out.
This causes the transfer thread to record the error, claim (it is not
really true since there was an error) that the data has been sent and
that a response has been received by trying to signal the pipeline
thread (but this has already stopped waiting). Finally the transfer
thread stops itself. A short while later the pipeline thread may attempt
to push an EOS event into GstCurlSmtpSink. Since there is no check in
gst_curl_smtp_sink_event() to check if the sink has suffered from any
error it may attempt to add a final boundary and ask the, now deceased,
transfer thread to transfer the new data. Next the sink element would
have waited for the transfer to complete (using a different mechanism
than normal transfers through GstCurlBaseSink). In this case there was
an error check to avoid waiting if an error had already been seen.
Finally GstCurlSmtpSink would chain up to GstCurlBaseSink which would
then block waiting for a response (normally this would be prevented by
the transfer thread suffering the error claiming that it had been
received, but GstCurlSmtpSink clobbered this flag after the fact).

Now GstCurlSmtpSink avoids this by locking over the entire event handing
(preventing simultaneous changes to flags by the two threads) and also
by avoiding to initiate transfer of final boundary if an error has
already been seen.

Also add GST_FIXME() for remaining similar issue where the pipeline
thread may block indefinitely waiting for transfer thread to transfer
data but the transfer thread errors out and fails to notify the pipeline
thread that the transfer failed.

https://bugzilla.gnome.org/show_bug.cgi?id=767501

8 years agojpeg2000parse: Require either colorspace or sampling field in sink caps
Aaron Boxer [Wed, 8 Jun 2016 15:32:28 +0000 (11:32 -0400)]
jpeg2000parse: Require either colorspace or sampling field in sink caps

And always set the sampling field on the src caps, if necessary guessing a
correct value for it from the colorspace field.

Also, did some cleanup: removed sampling enum - redundant.

https://bugzilla.gnome.org/show_bug.cgi?id=766236

8 years agofacedetect: Fix compiler warning with clang 3.8
Heinrich Fink [Fri, 10 Jun 2016 08:32:46 +0000 (11:32 +0300)]
facedetect: Fix compiler warning with clang 3.8

Use namespace only after it was actually defined by a header.

gstfacedetect.cpp:79:17: error: using directive refers to implicitly-defined namespace 'std' [-Werror]
using namespace std;
                ^

8 years agodvbsrc: unify exit paths on _start()
Reynaldo H. Verdejo Pinochet [Mon, 6 Jun 2016 23:35:15 +0000 (16:35 -0700)]
dvbsrc: unify exit paths on _start()

8 years agodvbsrc: use proper acronym for PID (Packet Identifier)
Reynaldo H. Verdejo Pinochet [Mon, 6 Jun 2016 22:31:31 +0000 (15:31 -0700)]
dvbsrc: use proper acronym for PID (Packet Identifier)

Drop formatting tab from message while at it.

8 years agodvbsrc: set common PES filter params once and reuse
Reynaldo H. Verdejo Pinochet [Mon, 6 Jun 2016 19:25:22 +0000 (12:25 -0700)]
dvbsrc: set common PES filter params once and reuse

Avoid setting the same harcoded values over and over again.

8 years agodc1394src: minor clean-up
Tim-Philipp Müller [Thu, 9 Jun 2016 21:01:45 +0000 (22:01 +0100)]
dc1394src: minor clean-up

We always call _parse_caps() with non-NULL out vars.

8 years agodc1394src: fix some more c99-isms
Tim-Philipp Müller [Thu, 9 Jun 2016 21:01:13 +0000 (22:01 +0100)]
dc1394src: fix some more c99-isms

8 years agodocs: fix for renamed dc1394 source file
Tim-Philipp Müller [Thu, 9 Jun 2016 20:47:05 +0000 (21:47 +0100)]
docs: fix for renamed dc1394 source file

https://bugzilla.gnome.org/show_bug.cgi?id=763026

8 years agodc1394src: prefix and file names according to Gstreamer conventions
Joan Pau Beltran [Tue, 7 Jun 2016 13:50:50 +0000 (15:50 +0200)]
dc1394src: prefix and file names according to Gstreamer conventions

Replace the type and function prefix to follow the conventions:

  - Use `GST_TYPE_DC1394_SRC` instead of `GST_TYPE_DC1394`.

  - Use `GstDC1394Src` and `GstDC1394SrcClass` instead of
    `GstDc1394` and `GstDc1394Class`.

  - Use `gst_dc1394_src` instead of `gst_dc1394`.

https://bugzilla.gnome.org/show_bug.cgi?id=763026

8 years agodc1394src: port to 1.X
Joan Pau Beltran [Tue, 10 May 2016 16:30:35 +0000 (18:30 +0200)]
dc1394src: port to 1.X

The dc1394src is a PushSrc element for IIDC cameras based on libdc1394.
The implementation from the 0.x series is deffective:
caps negotiation does not work, and some video formats
provided by the camera are not supported.

Refactor the code to port it to 1.X and enhance the support
for the full set of video options of IIDC cameras:

  - The IIDC specification includes a set of camera video modes
    (video format, frame size, and frame rates).
    They do not map perfectly to Gstreamer formats, but those that
    do not match are very rare (if used at all by any camera).
    In addition, although the specification includes a raw format,
    some cameras use mono video formats to capture in Bayer format.
    Map corresponding video modes to Gstreamer formats in capabilities,
    allowing both gray raw and Bayer video formats for mono video modes.

  - The specification includes scalable video modes (Format7),
    where the frame size and rate can be set to arbitrary values
    (within the limits of the camera and the bus transport).
    Allow the use of such mode, using the frame size and rate
    from the negotiatied caps, and set the camera frame rate
    adjusting the packet size as in:
    <http://damien.douxchamps.net/ieee1394/libdc1394/faq/#How_do_I_set_the_frame_rate>

    The scalable modes also allow for a custom ROI offset.
    Support for it can be easily added later using properties.

  - Camera operation using libdc1394 is as follows:

      1. Enumerate cameras on the system and open the camera
         identified the enumeration index or by a GUID (64bit hex code).

      2. Query the video formats supported by the camera.

      3. Configure the camera for the desired video format.

      4. Setup the capture resources for the configured video format
         and start the camera transmission.

      5. Capture frames from the camera and release them when not used.

      6. Stop the camera transmission and clear the capture resources.

      7. Close the camera freeing its resources.

    Do steps 2 and 3 when getting and setting the caps respectively.
    Ideally 4 and 6 would be done when going from PAUSED to PLAYING
    and viceversa, but since caps might not be set yet, the video mode
    is not properly configured leaving the camera in a broken state.
    Hence, setup capture and start transmission in the set caps method,
    and consequently clear the capture and stop the transmission
    when going from PAUSED to READY (instead of PLAYING to PAUSED).
    Symmetrycally, open the camera when going from READY to PAUSED,
    allowing to probe the camera caps in the negotiation stage.
    Implement that using the `start` and `stop` methods of `GstBaseSrc`,
    instead of the `change-state` method of `GstElement`.
    Stop the camera before setting new caps and restarting it again
    to handle caps reconfiguration while in PLAYING (it has no effect
    if the camera is not started).

  - Create buffers copying the bytes of the captured frames.
    Alternatively, the buffers could just wrap the bytes of the frames,
    releasing the frame in the buffer's destroy notify function,
    if all buffers were destroyed before going from PLAYING to PAUSED.

  - No timestamp nor offset is set when creating buffers.
    Timestamping is delegated to the parent class BaseSrc,
    setting `gst_base_src_set_live` TRUE, `gst_base_src_set_format`
    with GST_FORMAT_TIME and `gst_base_src_set_do_timestamp`.
    Captured frames have a timestamp field with the system time
    at the completion of the transmission of the frame,
    but it is not sure that this comes from a monotonic clock,
    and it seems to be left NULL in Windows.

  - Use GUID and unit properties to select the camera to operate on.
    The camera number used in version 0.X does not uniquely identify
    the device (it depends on the set of cameras currently detected).
    Since the GUID is 64bit identifier (same as MAC address),
    handle it with a string property with its hexadecimal representation.
    For practicality, operate on the first camera available if the GUID
    is null (default) and match any camera unit number if unit is -1.
    Alternatively, the GUID could be handed with an unsigned 64 bit
    integer type property, using `0xffffffffffffffff` as default value
    to select the first camera available (it is not a valid GUID value).

  - Keep name `GstDc1394` and prefix `gst_dc1394` as in version 0.X,
    although `GstDC1394Src` and `gst_dc1394_src` are more descriptive.

  - Adjust build files to reenable the compilation of the plugin.

    Remove dc1394 from the list of unported plugins in configure.ac.

    Add the missing flags and libraries to Makefile.
    Use `$()` for variable substitution, as many plugins do,
    although other plugins use `@@` instead.

https://bugzilla.gnome.org/show_bug.cgi?id=763026

8 years agoadaptivedemux: Move SEEK handling to a separate function
Edward Hervey [Wed, 8 Jun 2016 16:02:32 +0000 (18:02 +0200)]
adaptivedemux: Move SEEK handling to a separate function

Just for code readability. Doesn't change behaviour

8 years agowebpdec: Wait for segment event before checking it
Nicolas Dufresne [Wed, 8 Jun 2016 01:10:04 +0000 (21:10 -0400)]
webpdec: Wait for segment event before checking it

The heuristic to choose between packetise or not was changed to use the
segment format. The problem is that this change is reading the segment
during the caps event handling. The segment event will only be sent
after. That prevented the decoder to go in packetize mode, and avoid
useless parsing.

https://bugzilla.gnome.org/show_bug.cgi?id=736252

8 years agovmncdec: Wait for segment event before checking it
Nicolas Dufresne [Wed, 8 Jun 2016 01:04:21 +0000 (21:04 -0400)]
vmncdec: Wait for segment event before checking it

The heuristic to choose between packetise or not was changed to use the
segment format. The problem is that this change is reading the segment
during the caps event handling. The segment event will only be sent
after. That prevented the decoder to go in packetize mode, and avoid
useless parsing.

https://bugzilla.gnome.org/show_bug.cgi?id=736252

8 years agoopenjpeg: fix builddir != srcdir build, and distcheck
Tim-Philipp Müller [Tue, 7 Jun 2016 13:15:41 +0000 (14:15 +0100)]
openjpeg: fix builddir != srcdir build, and distcheck

8 years agojpeg2000parse: Add JPEG2000 parser element
Aaron Boxer [Wed, 1 Jun 2016 23:02:33 +0000 (19:02 -0400)]
jpeg2000parse: Add JPEG2000 parser element

https://bugzilla.gnome.org/show_bug.cgi?id=766236

8 years agoopenjpeg: set sampling in the caps
Aaron Boxer [Wed, 1 Jun 2016 23:01:44 +0000 (19:01 -0400)]
openjpeg: set sampling in the caps

https://bugzilla.gnome.org/show_bug.cgi?id=766236

8 years agompegtsmux: Set PTS on aligned buffers
Jan Alexander Steffens (heftig) [Mon, 2 May 2016 15:38:50 +0000 (17:38 +0200)]
mpegtsmux: Set PTS on aligned buffers

This was broken in 09c05df (make "alignment" property more useful for
packetisation).

https://bugzilla.gnome.org/show_bug.cgi?id=765926

8 years agovtdec: always drain in ::negotiate
Alessandro Decina [Tue, 7 Jun 2016 07:22:01 +0000 (17:22 +1000)]
vtdec: always drain in ::negotiate

Move calling gst_vtdec_push_frames_if_needed from ::set_format to ::negotiate so
that we always drain even when renegotiation is triggered by downstream.