platform/upstream/libSkiaSharp.git
11 years agoAdded --picture flag to SampleApp, loads individual skp.
chudy@google.com [Wed, 1 Aug 2012 17:58:01 +0000 (17:58 +0000)]
Added --picture flag to SampleApp, loads individual skp.

Review URL: https://codereview.appspot.com/6452077

git-svn-id: http://skia.googlecode.com/svn/trunk@4895 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMerged bench_pictures and render_pictures rendering methods.
keyar@chromium.org [Wed, 1 Aug 2012 17:53:29 +0000 (17:53 +0000)]
Merged bench_pictures and render_pictures rendering methods.

bench_pictures now uses a class based method for choosing the benchmark type as well.

Review URL: https://codereview.appspot.com/6452070

git-svn-id: http://skia.googlecode.com/svn/trunk@4894 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded more DrawPoints debugging info for inspector
chudy@google.com [Wed, 1 Aug 2012 16:10:06 +0000 (16:10 +0000)]
Added more DrawPoints debugging info for inspector

Review URL: https://codereview.appspot.com/6441084

git-svn-id: http://skia.googlecode.com/svn/trunk@4893 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoarm: Move SkUtilsArm.h from include/core to src/core
digit@google.com [Wed, 1 Aug 2012 15:58:41 +0000 (15:58 +0000)]
arm: Move SkUtilsArm.h from include/core to src/core

There is no reason to make this visible to client code.
Review URL: https://codereview.appspot.com/6441082

git-svn-id: http://skia.googlecode.com/svn/trunk@4892 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOptimization: SkDebugCanvas is capable of pausing and drawing incrementally instead...
chudy@google.com [Wed, 1 Aug 2012 15:57:52 +0000 (15:57 +0000)]
Optimization: SkDebugCanvas is capable of pausing and drawing incrementally instead of redrawing all commands.

Review URL: https://codereview.appspot.com/6458056

git-svn-id: http://skia.googlecode.com/svn/trunk@4891 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHandle rgb_to_a8 when kGenA8FromLCD_Flag is set.
bungeman@google.com [Wed, 1 Aug 2012 15:36:46 +0000 (15:36 +0000)]
Handle rgb_to_a8 when kGenA8FromLCD_Flag is set.

git-svn-id: http://skia.googlecode.com/svn/trunk@4889 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoarm: dynamic NEON support for SkBitmapProcState matrix operations.
digit@google.com [Wed, 1 Aug 2012 14:25:07 +0000 (14:25 +0000)]
arm: dynamic NEON support for SkBitmapProcState matrix operations.

This patch implements dynamic ARM NEON support for the functions
implemented by src/core/SkBitmapProcState_matrixProcs.cpp.

 - Because the SkBitmapProcState_matrix_{clamp,repeat}.h headers
   are NEON-specific, they are renamed with a _neon.h suffix, and
   moved to src/opts/ (from src/core/)

 - Add a new file src/opts/SkBitmapProcState_matrixProcs_neon.cpp
   which implements the NEON code paths for all builds, and add
   it to the 'opts_neon' static library.

 - Modify SkBitmapProcState_matrixProcs.cpp to select the right
   code-path depending on our build configuration. Note that in
   the case where 'arm_neon == 1', we do not embed regular ARM
   code paths in the final binary. Only 'arm_neon_optional == 1'
   builds will contain both regular and NEON code paths at the
   same time.

Note that there doesn't seem to be a simple way to put the
NEON-specific selection from that currently is in
SkBitmapProcState_matrixProcs.cpp into src/opts/. Doing so
would require much more drastic restructuring. This is also
true of the other SkBitmapProcState source files that will
be touched in a future patch.
Review URL: https://codereview.appspot.com/6453065

git-svn-id: http://skia.googlecode.com/svn/trunk@4888 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to see if local bot triggers a rebuild
borenet@google.com [Wed, 1 Aug 2012 13:30:54 +0000 (13:30 +0000)]
Whitespace change to see if local bot triggers a rebuild

git-svn-id: http://skia.googlecode.com/svn/trunk@4887 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to see if local bot triggers a rebuild
borenet@google.com [Tue, 31 Jul 2012 22:17:45 +0000 (22:17 +0000)]
Whitespace change to see if local bot triggers a rebuild

git-svn-id: http://skia.googlecode.com/svn/trunk@4877 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix units per em test.
bungeman@google.com [Tue, 31 Jul 2012 21:39:05 +0000 (21:39 +0000)]
Fix units per em test.

git-svn-id: http://skia.googlecode.com/svn/trunk@4873 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPrevent deferred canvases from recording draw operations that use an SkPaint object...
junov@chromium.org [Tue, 31 Jul 2012 21:01:51 +0000 (21:01 +0000)]
Prevent deferred canvases from recording draw operations that use an SkPaint object that indirectly references a GPU resource.
The specific case targeted by this patch is SkBitmapProcShaders that use an SkBitmap object that references a GPU texture.

BUG=http://code.google.com/p/chromium/issues/detail?id=139204
Review URL: https://codereview.appspot.com/6447068

git-svn-id: http://skia.googlecode.com/svn/trunk@4871 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove old constructors from GrGradientEffect subclasses, and moved their declaration...
rileya@google.com [Tue, 31 Jul 2012 20:38:06 +0000 (20:38 +0000)]
Remove old constructors from GrGradientEffect subclasses, and moved their declarations into source files.
Review URL: https://codereview.appspot.com/6449067

git-svn-id: http://skia.googlecode.com/svn/trunk@4870 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for r4865 (complexclip2 _gpu & _msaa)
robertphillips@google.com [Tue, 31 Jul 2012 20:32:48 +0000 (20:32 +0000)]
Image rebaselines for r4865 (complexclip2 _gpu & _msaa)

http://codereview.appspot.com/6454075/

git-svn-id: http://skia.googlecode.com/svn/trunk@4869 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGetting rid of compile-time warnings
chudy@google.com [Tue, 31 Jul 2012 20:07:42 +0000 (20:07 +0000)]
Getting rid of compile-time warnings

Review URL: https://codereview.appspot.com/6447071

git-svn-id: http://skia.googlecode.com/svn/trunk@4868 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOptimized hit testing feature, refactored into seperate function from canvas draw...
chudy@google.com [Tue, 31 Jul 2012 19:55:32 +0000 (19:55 +0000)]
Optimized hit testing feature, refactored into seperate function from canvas draw calls

Review URL: https://codereview.appspot.com/6443068

git-svn-id: http://skia.googlecode.com/svn/trunk@4867 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed minor memory leaks
robertphillips@google.com [Tue, 31 Jul 2012 19:23:02 +0000 (19:23 +0000)]
Fixed minor memory leaks

http://codereview.appspot.com/6453066/

git-svn-id: http://skia.googlecode.com/svn/trunk@4866 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace GrClip with SkClipStack
robertphillips@google.com [Tue, 31 Jul 2012 19:15:58 +0000 (19:15 +0000)]
Replace GrClip with SkClipStack

http://codereview.appspot.com/6449070/

git-svn-id: http://skia.googlecode.com/svn/trunk@4865 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd getUnitsPerEm() to SkTypeface
reed@google.com [Tue, 31 Jul 2012 17:24:44 +0000 (17:24 +0000)]
add getUnitsPerEm() to SkTypeface

git-svn-id: http://skia.googlecode.com/svn/trunk@4863 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd baseline images for Galaxy Nexus
borenet@google.com [Tue, 31 Jul 2012 17:15:08 +0000 (17:15 +0000)]
Add baseline images for Galaxy Nexus
Review URL: https://codereview.appspot.com/6447069

git-svn-id: http://skia.googlecode.com/svn/trunk@4862 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a memory leak in cmykjpeg GM.
scroggo@google.com [Tue, 31 Jul 2012 16:37:11 +0000 (16:37 +0000)]
Fix a memory leak in cmykjpeg GM.

Review URL: https://codereview.appspot.com/6448089

git-svn-id: http://skia.googlecode.com/svn/trunk@4861 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModified GrGpuGL_unittest to no longer use the old constructors to create gradients...
rileya@google.com [Tue, 31 Jul 2012 16:00:13 +0000 (16:00 +0000)]
Modified GrGpuGL_unittest to no longer use the old constructors to create gradients, also added TwoPointConical to the tests.
Review URL: https://codereview.appspot.com/6452068

git-svn-id: http://skia.googlecode.com/svn/trunk@4860 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck-point for gpu support in SkImage/SkSurface
reed@google.com [Tue, 31 Jul 2012 15:45:27 +0000 (15:45 +0000)]
check-point for gpu support in SkImage/SkSurface

git-svn-id: http://skia.googlecode.com/svn/trunk@4859 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake 0-texture GrCustomStages work.
bsalomon@google.com [Tue, 31 Jul 2012 15:33:25 +0000 (15:33 +0000)]
Make 0-texture GrCustomStages work.

Review URL: http://codereview.appspot.com/6448080/

git-svn-id: http://skia.googlecode.com/svn/trunk@4858 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd flattening
reed@google.com [Tue, 31 Jul 2012 15:19:56 +0000 (15:19 +0000)]
add flattening

git-svn-id: http://skia.googlecode.com/svn/trunk@4857 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded dev- & canv- prefixes to Ganesh bounding boxes to indicate coordinate space
robertphillips@google.com [Tue, 31 Jul 2012 15:18:21 +0000 (15:18 +0000)]
Added dev- & canv- prefixes to Ganesh bounding boxes to indicate coordinate space

http://codereview.appspot.com/6457061/

git-svn-id: http://skia.googlecode.com/svn/trunk@4856 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove '../gm/image.cpp',
reed@google.com [Tue, 31 Jul 2012 15:01:57 +0000 (15:01 +0000)]
remove     '../gm/image.cpp',

git-svn-id: http://skia.googlecode.com/svn/trunk@4855 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix LayerDrawLooper to record its fFlagsMask
reed@google.com [Tue, 31 Jul 2012 14:32:38 +0000 (14:32 +0000)]
fix LayerDrawLooper to record its fFlagsMask
convert SampleDrawLooper to a GM

git-svn-id: http://skia.googlecode.com/svn/trunk@4854 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline after text gamma change
reed@google.com [Tue, 31 Jul 2012 14:00:55 +0000 (14:00 +0000)]
rebaseline after text gamma change

git-svn-id: http://skia.googlecode.com/svn/trunk@4853 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline after text gamma change
reed@google.com [Tue, 31 Jul 2012 13:35:59 +0000 (13:35 +0000)]
rebaseline after text gamma change

git-svn-id: http://skia.googlecode.com/svn/trunk@4852 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline after test gamma change
reed@google.com [Tue, 31 Jul 2012 13:32:29 +0000 (13:32 +0000)]
rebaseline after test gamma change

git-svn-id: http://skia.googlecode.com/svn/trunk@4851 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate SkData and SkDataSet to make better use of SkFlattenable.
djsollen@google.com [Tue, 31 Jul 2012 13:17:31 +0000 (13:17 +0000)]
Update SkData and SkDataSet to make better use of SkFlattenable.

TEST=DataRefTest.cpp

Review URL: https://codereview.appspot.com/6441076

git-svn-id: http://skia.googlecode.com/svn/trunk@4850 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed numerous mem errors
chudy@google.com [Tue, 31 Jul 2012 12:49:52 +0000 (12:49 +0000)]
Fixed numerous mem errors

Review URL: https://codereview.appspot.com/6441070

git-svn-id: http://skia.googlecode.com/svn/trunk@4849 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGrClip no longer translates its clips (to better mimic SkClipStack's behavior)
robertphillips@google.com [Tue, 31 Jul 2012 12:18:16 +0000 (12:18 +0000)]
GrClip no longer translates its clips (to better mimic SkClipStack's behavior)

http://codereview.appspot.com/6445052/

git-svn-id: http://skia.googlecode.com/svn/trunk@4848 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded test to ensure getConservativeBounds' result is clamped to render target
robertphillips@google.com [Tue, 31 Jul 2012 11:47:29 +0000 (11:47 +0000)]
Added test to ensure getConservativeBounds' result is clamped to render target

http://codereview.appspot.com/6447063/

git-svn-id: http://skia.googlecode.com/svn/trunk@4846 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkImage from encoded data
mike@reedtribe.org [Tue, 31 Jul 2012 03:57:11 +0000 (03:57 +0000)]
add SkImage from encoded data

git-svn-id: http://skia.googlecode.com/svn/trunk@4845 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate to surface.getCanvas()
mike@reedtribe.org [Tue, 31 Jul 2012 02:45:15 +0000 (02:45 +0000)]
update to surface.getCanvas()

git-svn-id: http://skia.googlecode.com/svn/trunk@4844 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline for r4841, gamma correcting masks.
bungeman@google.com [Mon, 30 Jul 2012 22:27:33 +0000 (22:27 +0000)]
Rebaseline for r4841, gamma correcting masks.

git-svn-id: http://skia.googlecode.com/svn/trunk@4843 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange SkSurface::newCanvas() to getCanvas(), and redefine its life-cycle to be
reed@google.com [Mon, 30 Jul 2012 21:03:46 +0000 (21:03 +0000)]
change SkSurface::newCanvas() to getCanvas(), and redefine its life-cycle to be
a single canvas for the lifetime of the surface.

Get a playback copy from the src picture, so we can continue to record into the
original picture.

git-svn-id: http://skia.googlecode.com/svn/trunk@4842 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGamma correcting masks.
bungeman@google.com [Mon, 30 Jul 2012 20:40:50 +0000 (20:40 +0000)]
Gamma correcting masks.
https://codereview.appspot.com/6244068/

git-svn-id: http://skia.googlecode.com/svn/trunk@4841 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove outdated test code for TEST_SRC_ALPHA
reed@google.com [Mon, 30 Jul 2012 20:26:06 +0000 (20:26 +0000)]
remove outdated test code for TEST_SRC_ALPHA
Review URL: https://codereview.appspot.com/6457056

git-svn-id: http://skia.googlecode.com/svn/trunk@4840 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate/add copyright notices
reed@google.com [Mon, 30 Jul 2012 19:50:31 +0000 (19:50 +0000)]
update/add copyright notices

git-svn-id: http://skia.googlecode.com/svn/trunk@4839 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix skdiff when using windows path that begins with a drive letter
bsalomon@google.com [Mon, 30 Jul 2012 19:16:02 +0000 (19:16 +0000)]
Fix skdiff when using windows path that begins with a drive letter

Review URL: https://mail.google.com/mail/u/0/?shva=1#inbox/138d92244ca33549

git-svn-id: http://skia.googlecode.com/svn/trunk@4838 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCanvas size initializes correctly when drawing from a skia picture
chudy@google.com [Mon, 30 Jul 2012 18:54:07 +0000 (18:54 +0000)]
Canvas size initializes correctly when drawing from a skia picture

Review URL: https://codereview.appspot.com/6450065

git-svn-id: http://skia.googlecode.com/svn/trunk@4837 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpand internal subclasses into separate files
reed@google.com [Mon, 30 Jul 2012 18:20:12 +0000 (18:20 +0000)]
expand internal subclasses into separate files

git-svn-id: http://skia.googlecode.com/svn/trunk@4836 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpand private subclasses into separate files
reed@google.com [Mon, 30 Jul 2012 18:06:00 +0000 (18:06 +0000)]
expand private subclasses into separate files

git-svn-id: http://skia.googlecode.com/svn/trunk@4835 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for clip assert in Chrome tests
robertphillips@google.com [Mon, 30 Jul 2012 17:10:51 +0000 (17:10 +0000)]
Fix for clip assert in Chrome tests

http://codereview.appspot.com/6442063/

git-svn-id: http://skia.googlecode.com/svn/trunk@4834 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogyp_skia: Fix module search path.
digit@google.com [Mon, 30 Jul 2012 16:48:13 +0000 (16:48 +0000)]
gyp_skia: Fix module search path.

gyp_skia should prepend the local gyp source path to the python
module search path, instead of appending it. Otherwise, if a 'gyp'
module is locally installed on the machine, it will be read instead
of the current version in the Skia tree.

This breaks the Android build when the installed 'gyp' module doesn't
support the "make-android" generator.
Review URL: https://codereview.appspot.com/6344096

git-svn-id: http://skia.googlecode.com/svn/trunk@4832 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRebaseline verttext so it can be monitored.
bungeman@google.com [Mon, 30 Jul 2012 15:29:17 +0000 (15:29 +0000)]
Rebaseline verttext so it can be monitored.

git-svn-id: http://skia.googlecode.com/svn/trunk@4831 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoConst correct BlockRef in SkAutoTUnref.
bungeman@google.com [Mon, 30 Jul 2012 15:03:59 +0000 (15:03 +0000)]
Const correct BlockRef in SkAutoTUnref.
https://codereview.appspot.com/6448066/

git-svn-id: http://skia.googlecode.com/svn/trunk@4829 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoShare code in various SkGPipeCanvas::drawBitmap_ calls.
scroggo@google.com [Mon, 30 Jul 2012 14:40:01 +0000 (14:40 +0000)]
Share code in various SkGPipeCanvas::drawBitmap_ calls.

Also implement SkGPipeCanvas::drawBitmapMatrix, and
create a GM to make sure it works properly.

Use a flag instead of writing a bool for determining whether
drawBitmap_ has a paint and whether drawBitmapRect has a source
rectangle.

BUG=
TEST=drawbitmapmatrix GM

Review URL: https://codereview.appspot.com/6450053

git-svn-id: http://skia.googlecode.com/svn/trunk@4828 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agodetect null pixles in setPixels() and just clear out any existing pixelref.
reed@google.com [Mon, 30 Jul 2012 13:16:35 +0000 (13:16 +0000)]
detect null pixles in setPixels() and just clear out any existing pixelref.

git-svn-id: http://skia.googlecode.com/svn/trunk@4827 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemove GrDrawState::setTexture/getTexture
bsalomon@google.com [Mon, 30 Jul 2012 13:09:05 +0000 (13:09 +0000)]
Remove GrDrawState::setTexture/getTexture

Review URL: http://codereview.appspot.com/6455051/

git-svn-id: http://skia.googlecode.com/svn/trunk@4826 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoland https://codereview.appspot.com/6448046/
reed@google.com [Mon, 30 Jul 2012 13:08:01 +0000 (13:08 +0000)]
land https://codereview.appspot.com/6448046/
Add a method reporting used font cache size to the SkGraphics API

git-svn-id: http://skia.googlecode.com/svn/trunk@4825 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDeserialization locks up multithreading fix.
chudy@google.com [Mon, 30 Jul 2012 12:59:12 +0000 (12:59 +0000)]
Deserialization locks up multithreading fix.

Review URL: https://codereview.appspot.com/6448077

git-svn-id: http://skia.googlecode.com/svn/trunk@4824 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agocheck-point for image/surface work
mike@reedtribe.org [Sun, 29 Jul 2012 20:38:16 +0000 (20:38 +0000)]
check-point for image/surface work

git-svn-id: http://skia.googlecode.com/svn/trunk@4823 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded missing files to fix build.
chudy@google.com [Sat, 28 Jul 2012 23:26:10 +0000 (23:26 +0000)]
Added missing files to fix build.

TBR

Review URL: https://codereview.appspot.com/6455058

git-svn-id: http://skia.googlecode.com/svn/trunk@4822 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSkia Debugger can now save modified pictures.
chudy@google.com [Sat, 28 Jul 2012 20:16:11 +0000 (20:16 +0000)]
Skia Debugger can now save modified pictures.

Review URL: https://codereview.appspot.com/6442055

git-svn-id: http://skia.googlecode.com/svn/trunk@4821 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Fri, 27 Jul 2012 21:22:25 +0000 (21:22 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@4820 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agocheck-point for surface experiment
reed@google.com [Fri, 27 Jul 2012 21:10:42 +0000 (21:10 +0000)]
check-point for surface experiment

git-svn-id: http://skia.googlecode.com/svn/trunk@4819 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd support for ARM without EDSP and ARMv6+
george@mozilla.com [Fri, 27 Jul 2012 21:08:01 +0000 (21:08 +0000)]
Add support for ARM without EDSP and ARMv6+

Original Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=751814

Review URL: https://codereview.appspot.com/6405065

git-svn-id: http://skia.googlecode.com/svn/trunk@4818 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoIn SkGPipe, only serialize SkTypefaces in cross process mode.
scroggo@google.com [Fri, 27 Jul 2012 20:39:19 +0000 (20:39 +0000)]
In SkGPipe, only serialize SkTypefaces in cross process mode.

Also make SkGPipeController ref the recording canvas to ensure that
objects used by SkGPipeCanvas (e.g. SharedHeap and fTypefaceSet, which
hold references to objects to which pointers are written to the stream)
survive to be played back even if SkGPipeWriter.endRecording() is called.

BUG=
TEST=TypefaceGM

Review URL: https://codereview.appspot.com/6447055

git-svn-id: http://skia.googlecode.com/svn/trunk@4817 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded an option to specify the tiling size to render_pictures.
keyar@chromium.org [Fri, 27 Jul 2012 20:09:26 +0000 (20:09 +0000)]
Added an option to specify the tiling size to render_pictures.

With this change I should be able to start merging the rendering implementations of bench_pictures and render_pictures.

Review URL: https://codereview.appspot.com/6427061

git-svn-id: http://skia.googlecode.com/svn/trunk@4816 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Fri, 27 Jul 2012 18:26:38 +0000 (18:26 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@4815 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofix the build after intentional break
epoger@google.com [Fri, 27 Jul 2012 18:15:03 +0000 (18:15 +0000)]
fix the build after intentional break

git-svn-id: http://skia.googlecode.com/svn/trunk@4814 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agointentionally break the build to test notifications
epoger@google.com [Fri, 27 Jul 2012 18:13:31 +0000 (18:13 +0000)]
intentionally break the build to test notifications

git-svn-id: http://skia.googlecode.com/svn/trunk@4813 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agocheck-point for image experiment
reed@google.com [Fri, 27 Jul 2012 18:02:50 +0000 (18:02 +0000)]
check-point for image experiment

git-svn-id: http://skia.googlecode.com/svn/trunk@4811 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd virtual destructor to class with virtual functions.
justinlin@google.com [Fri, 27 Jul 2012 17:37:12 +0000 (17:37 +0000)]
Add virtual destructor to class with virtual functions.

BUG=
TEST=

Review URL: https://codereview.appspot.com/6453052

git-svn-id: http://skia.googlecode.com/svn/trunk@4810 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAlways store pixels of mutable bitmaps when recording a SkPicture.
djsollen@google.com [Fri, 27 Jul 2012 15:58:23 +0000 (15:58 +0000)]
Always store pixels of mutable bitmaps when recording a SkPicture.

Prior to this CL mutable bitmaps only saved a copy of their pixels
if a flag was set at recording time.  That flag has been removed
and the default behavior when recording a mutable bitmap is to
make a copy of it's pixels. This is the only way to ensure that
the pixels are not manipulated before we playback their contents.

However, enabling this behavior breaks the recording of extracted
bitmaps in SkPicture. This is because we currently cache bitmaps
within a picture based only on their pixelRef. This results in
false positive cache hit when drawing an extracted bitmap as it
shares a pixelRef with its orginating bitmap.  Therefore we must
update the index of the bitmap cache to be both the pixelRef AND
the size and offset of the bitmap using those pixels.

BUG=
TEST=extractbitmap.cpp

Review URL: https://codereview.appspot.com/6439043

git-svn-id: http://skia.googlecode.com/svn/trunk@4809 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRenamed and made public SkGradientShaderBases's 'commonAsAGradient' to 'getGradientTa...
rileya@google.com [Fri, 27 Jul 2012 15:49:05 +0000 (15:49 +0000)]
Renamed and made public SkGradientShaderBases's 'commonAsAGradient' to 'getGradientTableBitmap', and use that instead of asABitmap in gradient custom stage setup.

Also tidied up Gr gradient implementation constructors, to take the appropriate SkGradientShaderBase subclass, and where necessary (namely 2pt radial/conical) made them obtain extra parameters from that object, rather than passing them in in addition to it.
Review URL: https://codereview.appspot.com/6449057

git-svn-id: http://skia.googlecode.com/svn/trunk@4808 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorename private animator type SkImage to SkImageBitmapBase, to avoid conflicts
reed@google.com [Fri, 27 Jul 2012 15:30:40 +0000 (15:30 +0000)]
rename private animator type SkImage to SkImageBitmapBase, to avoid conflicts
with new public type SkImage

git-svn-id: http://skia.googlecode.com/svn/trunk@4807 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoUpdate list of platforms to rebaseline
epoger@google.com [Fri, 27 Jul 2012 15:19:54 +0000 (15:19 +0000)]
Update list of platforms to rebaseline
Review URL: https://codereview.appspot.com/6441061

git-svn-id: http://skia.googlecode.com/svn/trunk@4806 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMove GPU gradients into src/effects/gradients.
rileya@google.com [Fri, 27 Jul 2012 14:00:39 +0000 (14:00 +0000)]
Move GPU gradients into src/effects/gradients.
Review URL: https://codereview.appspot.com/6453055

git-svn-id: http://skia.googlecode.com/svn/trunk@4805 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReapply "Remove Bitmaps Raw Pixel Support."
djsollen@google.com [Fri, 27 Jul 2012 13:41:44 +0000 (13:41 +0000)]
Reapply "Remove Bitmaps Raw Pixel Support."

This CL reapplies r4722. Now that we have addressed the issues
in Chrome tests that were causing asserts to be fired.

Review URL: https://codereview.appspot.com/6452050

git-svn-id: http://skia.googlecode.com/svn/trunk@4804 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorevert 4799-4801 -- red and blue are reversed on windows and linux
reed@google.com [Fri, 27 Jul 2012 13:29:59 +0000 (13:29 +0000)]
revert 4799-4801 -- red and blue are reversed on windows and linux

git-svn-id: http://skia.googlecode.com/svn/trunk@4803 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSpecialize SkAutoTUnref on const T so that operator -> works.
bsalomon@google.com [Fri, 27 Jul 2012 13:27:35 +0000 (13:27 +0000)]
Specialize SkAutoTUnref on const T so that operator -> works.

Review URL: http://codereview.appspot.com/6450054/

git-svn-id: http://skia.googlecode.com/svn/trunk@4802 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agouse SK_RESTRICT instead of __restrict__
reed@google.com [Fri, 27 Jul 2012 13:08:36 +0000 (13:08 +0000)]
use SK_RESTRICT instead of __restrict__

git-svn-id: http://skia.googlecode.com/svn/trunk@4801 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agouse intptr_t to cast from ptr to int for masking low bits
reed@google.com [Fri, 27 Jul 2012 13:03:37 +0000 (13:03 +0000)]
use intptr_t to cast from ptr to int for masking low bits

git-svn-id: http://skia.googlecode.com/svn/trunk@4800 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoland http://codereview.appspot.com/6327044/
reed@google.com [Fri, 27 Jul 2012 12:52:31 +0000 (12:52 +0000)]
land http://codereview.appspot.com/6327044/

SSE optimization for 565 pixel format -- by Lei

git-svn-id: http://skia.googlecode.com/svn/trunk@4799 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded getConservativeBound helper function to GrClipData
robertphillips@google.com [Thu, 26 Jul 2012 21:37:40 +0000 (21:37 +0000)]
Added getConservativeBound helper function to GrClipData

http://codereview.appspot.com/6454054/

git-svn-id: http://skia.googlecode.com/svn/trunk@4798 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMac build fix after gradient restructure/renaming.
rileya@google.com [Thu, 26 Jul 2012 21:25:09 +0000 (21:25 +0000)]
Mac build fix after gradient restructure/renaming.
Review URL: https://codereview.appspot.com/6441057

git-svn-id: http://skia.googlecode.com/svn/trunk@4797 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoWindows compiler complaint cleanup
robertphillips@google.com [Thu, 26 Jul 2012 21:18:31 +0000 (21:18 +0000)]
Windows compiler complaint cleanup

http://codereview.appspot.com/6441055/

git-svn-id: http://skia.googlecode.com/svn/trunk@4796 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFirst stab at committing GM baselines for Shuttle_Ubuntu12_ATI5770
epoger@google.com [Thu, 26 Jul 2012 20:54:34 +0000 (20:54 +0000)]
First stab at committing GM baselines for Shuttle_Ubuntu12_ATI5770
bsalomon looked at skdiff output and approved

git-svn-id: http://skia.googlecode.com/svn/trunk@4795 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoKey Shortcuts for Zooming. Refactored some event propogation.
chudy@google.com [Thu, 26 Jul 2012 20:26:44 +0000 (20:26 +0000)]
Key Shortcuts for Zooming. Refactored some event propogation.

Review URL: https://codereview.appspot.com/6452052

git-svn-id: http://skia.googlecode.com/svn/trunk@4794 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFirst stab at committing GM baselines for shuttle_win7_intel
epoger@google.com [Thu, 26 Jul 2012 20:17:26 +0000 (20:17 +0000)]
First stab at committing GM baselines for shuttle_win7_intel
bsalomon looked at skdiff output and approved

git-svn-id: http://skia.googlecode.com/svn/trunk@4793 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSplit SkGradientShader into separate files for each gradient subclass.
rileya@google.com [Thu, 26 Jul 2012 20:04:23 +0000 (20:04 +0000)]
Split SkGradientShader into separate files for each gradient subclass.
Review URL: https://codereview.appspot.com/6447049

git-svn-id: http://skia.googlecode.com/svn/trunk@4792 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMake SkDeferredCanvas query SkGPipeWriter for space allocated for bitmaps.
scroggo@google.com [Thu, 26 Jul 2012 20:03:32 +0000 (20:03 +0000)]
Make SkDeferredCanvas query SkGPipeWriter for space allocated for bitmaps.

SkGPipe now has a method to report how much memory is used for its shared heap.

BUG=http://code.google.com/p/skia/issues/detail?id=738
TEST=DeferredCanvasTest

Review URL: https://codereview.appspot.com/6445046

git-svn-id: http://skia.googlecode.com/svn/trunk@4791 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemove texture/mask setters on GrPaint
bsalomon@google.com [Thu, 26 Jul 2012 19:39:06 +0000 (19:39 +0000)]
Remove texture/mask setters on GrPaint

Review URL: http://codereview.appspot.com/6446052/

git-svn-id: http://skia.googlecode.com/svn/trunk@4790 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoGL Widget Alpha
chudy@google.com [Thu, 26 Jul 2012 19:38:22 +0000 (19:38 +0000)]
GL Widget Alpha

Review URL: https://codereview.appspot.com/6422060

git-svn-id: http://skia.googlecode.com/svn/trunk@4789 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAltered Ganesh's clip stack plumbing to pass down new GrClipData class
robertphillips@google.com [Thu, 26 Jul 2012 18:52:16 +0000 (18:52 +0000)]
Altered Ganesh's clip stack plumbing to pass down new GrClipData class

http://codereview.appspot.com/6454047/

git-svn-id: http://skia.googlecode.com/svn/trunk@4788 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded ctor to SkClipStack and isEmpty method
robertphillips@google.com [Thu, 26 Jul 2012 18:39:13 +0000 (18:39 +0000)]
Added ctor to SkClipStack and isEmpty method

http://codereview.appspot.com/6444048/

git-svn-id: http://skia.googlecode.com/svn/trunk@4787 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoChanged to a class based method in passing around the rendering method for render_pic...
keyar@chromium.org [Thu, 26 Jul 2012 17:27:57 +0000 (17:27 +0000)]
Changed to a class based method in passing around the rendering method for render_pictures.

This is based on a comment for https://codereview.appspot.com/6427061/

Review URL: https://codereview.appspot.com/6405080

git-svn-id: http://skia.googlecode.com/svn/trunk@4786 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoreject any paths that are not finite.
reed@google.com [Thu, 26 Jul 2012 16:11:47 +0000 (16:11 +0000)]
reject any paths that are not finite.

git-svn-id: http://skia.googlecode.com/svn/trunk@4785 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoexplicitly track if a path is finite or not
reed@google.com [Thu, 26 Jul 2012 15:20:36 +0000 (15:20 +0000)]
explicitly track if a path is finite or not
we need this (it appears) so we can definitively reject non-finite paths
in canvas, before passing them down into the guts.
Review URL: https://codereview.appspot.com/6453047

git-svn-id: http://skia.googlecode.com/svn/trunk@4784 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoWhitespace change to trigger rebuild after slave script modifications
borenet@google.com [Thu, 26 Jul 2012 15:14:57 +0000 (15:14 +0000)]
Whitespace change to trigger rebuild after slave script modifications

git-svn-id: http://skia.googlecode.com/svn/trunk@4783 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorebaseline after gpu changes
reed@google.com [Thu, 26 Jul 2012 14:55:46 +0000 (14:55 +0000)]
rebaseline after gpu changes

git-svn-id: http://skia.googlecode.com/svn/trunk@4781 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRevert "Remove Bitmaps Raw Pixel Support."
djsollen@google.com [Thu, 26 Jul 2012 14:48:52 +0000 (14:48 +0000)]
Revert "Remove Bitmaps Raw Pixel Support."

BUG=
TEST=

Review URL: https://codereview.appspot.com/6449049

git-svn-id: http://skia.googlecode.com/svn/trunk@4780 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoImplementing Color32 functions for Neon platforms.
borenet@google.com [Thu, 26 Jul 2012 14:20:13 +0000 (14:20 +0000)]
Implementing Color32 functions for Neon platforms.

Besides the raw processing improvement provided by Neon, the code uses memory
preteches (pld) which seem to improve performance greatly when dealing with
very large counts.

This was tested using bench where color32 accounts for the majority of the
workload:
bench -match rects_1 -config 8888 -repeat 500 -forceBlend 1
(the forceBlend is there so that the Color32 code does not go through the
special cases where alpha == 0xFF as it would transform color32 into
a sk_memset32.

Numbers averaged over 3 runs:
bench name      | Before | Neon, no pld | Neon with pld | full boost
rrects_1        | 153.9  | 128.3        | 92            | 1.66x
rects_1_stroke_4| 32.8   | 31.4         | 28.45         | 1.15x
rects_1         | 125.35 | 97.2         | 63.59         | 1.97x

Credits: various googletv team members.

Committed on behalf of evannier.
Review URL: http://codereview.appspot.com/5569077/

git-svn-id: http://skia.googlecode.com/svn/trunk@4779 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix reversed bilerp setting in GrTextContext in r4773
bsalomon@google.com [Thu, 26 Jul 2012 14:12:23 +0000 (14:12 +0000)]
Fix reversed bilerp setting in GrTextContext in r4773

Review URL: http://codereview.appspot.com/6455044/

git-svn-id: http://skia.googlecode.com/svn/trunk@4778 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCorrectly calculate remaining span length in Neon fallback blitter
skyostil@google.com [Thu, 26 Jul 2012 12:19:26 +0000 (12:19 +0000)]
Correctly calculate remaining span length in Neon fallback blitter

In the non-Neon optimized fallback in SCALE_NOFILTER_NAME() the pixels
are first processed in groups of 4, followed by the final remaining 0-3
pixels depending on the span length.

Currently the remaining span length (0-3) pixels is incorrectly
calculated as count - count / 4. This generally causes the function to
access outside the bounds of the input and/or output bitmaps.

The correct formula is count % 4, because all the full multiples of 4
pixels have been processed and only the remainder remains.

Bug spotted by Xianzhu Wang.

TEST=None, because this part of the code isn't actually even being compiled due
to the !defined(__ARM_HAVE_NEON) guard at the top of the file. It was compiled
in by mistake in Chrome for Android, which is how this bug was spotted.
Review URL: https://codereview.appspot.com/6441050

git-svn-id: http://skia.googlecode.com/svn/trunk@4777 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMove filter/wrap out of GrSamplerState into GrTextureParams
bsalomon@google.com [Wed, 25 Jul 2012 21:27:09 +0000 (21:27 +0000)]
Move filter/wrap out of GrSamplerState into GrTextureParams

Review URL: http://codereview.appspot.com/6440046/

git-svn-id: http://skia.googlecode.com/svn/trunk@4773 2bbb7eff-a529-9590-31e7-b0007b416f81