Lasse Collin [Mon, 10 Mar 2008 11:41:25 +0000 (13:41 +0200)]
Don't fill allocated memory with 0xFD when debugging is
enabled. It hides errors from Valgrind.
Lasse Collin [Thu, 28 Feb 2008 08:24:31 +0000 (10:24 +0200)]
Remove two redundant validity checks from the LZMA decoder.
These are already checked elsewhere, so omitting these
gives (very) tiny speed up.
Lasse Collin [Wed, 6 Feb 2008 11:25:32 +0000 (13:25 +0200)]
Tiny clean up to file-format.txt.
Lasse Collin [Sat, 2 Feb 2008 12:51:06 +0000 (14:51 +0200)]
Don't memzero() the history buffer when initializing LZ
decoder. There's no danger of information leak here, so
it isn't required. Doing memzero() takes a lot of time
with large dictionaries, which could make it easier to
construct DoS attack to consume too much CPU time.
Lasse Collin [Fri, 1 Feb 2008 06:39:26 +0000 (08:39 +0200)]
Do uncompressed size validation in raw encoder. This way
it gets done for not only raw encoder, but also Block
and LZMA_Alone encoders.
Lasse Collin [Fri, 1 Feb 2008 06:32:05 +0000 (08:32 +0200)]
Avoid unneeded function call in raw_common.c.
Lasse Collin [Sat, 26 Jan 2008 19:42:38 +0000 (21:42 +0200)]
Updated THANKS.
Lasse Collin [Sat, 26 Jan 2008 19:40:23 +0000 (21:40 +0200)]
Added note.GNU-stack to x86 assembler files. It is needed
when using non-executable stack.
Lasse Collin [Sat, 26 Jan 2008 17:12:50 +0000 (19:12 +0200)]
Added api/lzma/easy.h. I had forgot to add this to the
git repo. Thanks to Stephan Kulow.
Lasse Collin [Sat, 26 Jan 2008 09:09:17 +0000 (11:09 +0200)]
Added more test files.
Lasse Collin [Sat, 26 Jan 2008 08:47:55 +0000 (10:47 +0200)]
Added more test files.
Lasse Collin [Fri, 25 Jan 2008 22:25:34 +0000 (00:25 +0200)]
Return LZMA_HEADER_ERROR if LZMA_SYNC_FLUSH is used with any
of the so called simple filters. If there is demand, limited
support for LZMA_SYNC_FLUSH may be added in future.
After this commit, using LZMA_SYNC_FLUSH shouldn't cause
undefined behavior in any situation.
Lasse Collin [Fri, 25 Jan 2008 21:50:35 +0000 (23:50 +0200)]
Added more Multi-Block test files. Improved some
descriptions in the test files' README.
Lasse Collin [Fri, 25 Jan 2008 21:12:36 +0000 (23:12 +0200)]
Combine lzma_options_block validation needed by both Block
encoder and decoder, and put the shared things to
block_private.h. Improved the checks a little so that
they may detect too big Compressed Size at initialization
time if lzma_options_block.total_size or .total_limit is
known.
Allow encoding and decoding Blocks with combinations of
fields that are not allowed by the file format specification.
Doing this requires that the application passes such a
combination in lzma_options_lzma; liblzma doesn't do that,
but it's not impossible that someone could find them useful
in some custom file format.
Lasse Collin [Fri, 25 Jan 2008 17:21:22 +0000 (19:21 +0200)]
Added test_memlimit.c.
Lasse Collin [Fri, 25 Jan 2008 17:20:28 +0000 (19:20 +0200)]
Improved the memory limitter:
- Added lzma_memlimit_max() and lzma_memlimit_reached()
API functions.
- Added simple estimation of malloc()'s memory usage
overhead.
- Fixed integer overflow detection in lzma_memlimit_alloc().
- Made some white space cleanups and added more comments.
The description of lzma_memlimit_max() in memlimit.h is bad
and should be improved.
Lasse Collin [Fri, 25 Jan 2008 11:55:52 +0000 (13:55 +0200)]
Use more parenthesis in succeed() macro in tests/tests.h.
Lasse Collin [Thu, 24 Jan 2008 12:49:34 +0000 (14:49 +0200)]
Added more Multi-Block Stream test files.
Lasse Collin [Wed, 23 Jan 2008 22:46:05 +0000 (00:46 +0200)]
Added bunch of test files containing Multi-Block Streams.
Lasse Collin [Wed, 23 Jan 2008 21:43:00 +0000 (23:43 +0200)]
Fix decoding of empty Metadata Blocks, that don't have
even the Metadata Flags field. Earlier the code allowed
such files; now they are prohibited as the file format
specification requires.
Lasse Collin [Wed, 23 Jan 2008 21:38:18 +0000 (23:38 +0200)]
Fix a bug related to
99e12af4e2b866c011fe0106cd1e0bfdcc8fe9c6.
lzma_metadata.header_metadata_size was not properly set to
zero if the Metadata had only the Metadata Flags field.
Lasse Collin [Wed, 23 Jan 2008 21:35:49 +0000 (23:35 +0200)]
Fix decoding of Extra Records that have empty Data.
Lasse Collin [Wed, 23 Jan 2008 20:02:38 +0000 (22:02 +0200)]
Add the trailing '\0' to lzma_extra.data as the API header
already documents.
Lasse Collin [Wed, 23 Jan 2008 19:21:21 +0000 (21:21 +0200)]
Added debug/full_flush.c.
Lasse Collin [Wed, 23 Jan 2008 19:05:33 +0000 (21:05 +0200)]
Return LZMA_STREAM_END instead of LZMA_OK if
LZMA_SYNC_FLUSH or LZMA_FULL_FLUSH is used when
there's no unfinished Block open.
Lasse Collin [Wed, 23 Jan 2008 18:05:01 +0000 (20:05 +0200)]
Added bad-single-none-footer_filter_flags.lzma and
bad-single-none-too_long_vli.lzma.
Lasse Collin [Wed, 23 Jan 2008 11:42:35 +0000 (13:42 +0200)]
Fixed a typo.
Lasse Collin [Wed, 23 Jan 2008 11:40:45 +0000 (13:40 +0200)]
Fix a memory leak in the Subblock encoder.
Lasse Collin [Wed, 23 Jan 2008 11:36:07 +0000 (13:36 +0200)]
Fix Size of Header Metadata Block handling. Now
lzma_metadata.header_metadata_size == LZMA_VLI_VALUE_UNKNOWN
is not allowed at all. To indicate missing Header Metadata
Block, header_metadata_size must be set to zero. This is
what Metadata decoder does after this patch too.
Note that other missing fields in lzma_metadata are still
indicated with LZMA_VLI_VALUE_UNKNOWN. This isn't as
illogical as it sounds at first, because missing Size of
Header Metadata Block means that Header Metadata Block is
not present in the Stream. With other Metadata fields,
a missing field means only that the value is unknown.
Lasse Collin [Wed, 23 Jan 2008 11:15:55 +0000 (13:15 +0200)]
Fix a memory leak in metadata_decoder.c.
Lasse Collin [Wed, 23 Jan 2008 11:13:58 +0000 (13:13 +0200)]
Fix the fix
863028cb7ad6d8d0455fa69348f56b376d7b908f which
just moved to problem. Now it's really fixed.
Lasse Collin [Tue, 22 Jan 2008 22:21:04 +0000 (00:21 +0200)]
Take advantage of return_if_error() macro in
lzma_info_metadata_set() in info.c.
Lasse Collin [Tue, 22 Jan 2008 22:18:32 +0000 (00:18 +0200)]
Fixed a dangling pointer that caused invalid free().
Lasse Collin [Tue, 22 Jan 2008 20:49:24 +0000 (22:49 +0200)]
Added lzma_easy_* functions. These should make using
liblzma as easy as using zlib, because the easy API
don't require developers to know any fancy LZMA options.
Note that Multi-Block Stream encoding is currently broken.
The easy API should be OK, the bug(s) are elsewhere.
Lasse Collin [Tue, 22 Jan 2008 19:16:22 +0000 (21:16 +0200)]
Fix Multi-Block Stream encoder's EOPM usage.
Lasse Collin [Mon, 21 Jan 2008 22:15:11 +0000 (00:15 +0200)]
Made lzma_extra pointers const in lzma_options_stream.
Lasse Collin [Sun, 20 Jan 2008 18:15:21 +0000 (20:15 +0200)]
Updated debug/sync_flush.c.
Lasse Collin [Sun, 20 Jan 2008 18:14:26 +0000 (20:14 +0200)]
Added debug/repeat.c.
Lasse Collin [Sun, 20 Jan 2008 18:12:58 +0000 (20:12 +0200)]
Fix alignment handling bugs in Subblock encoder.
This leaves one known alignment bug unfixed: If repeat count
doesn't fit into 28-bit integer, the encoder has to split
this to multiple Subblocks with Subblock Type `Repeating Data'.
The extra Subblocks may have wrong alignment. Correct alignment
is restored after the split Repeating Data has been completely
written out.
Since the encoder doesn't even try to fix the alignment unless
the size of Data is at least 4 bytes, to trigger this bug you
need at least 4 GiB of repeating data with sequence length of
4 or more bytes. Since the worst thing done by this bug is
misaligned data (no data corruption), this bug simply isn't
worth fixing, because a proper fix isn't simple.
Lasse Collin [Sat, 19 Jan 2008 19:16:33 +0000 (21:16 +0200)]
Implemented LZMA_SYNC_FLUSH support to the Subblock encoder.
The API for handing Subfilters was changed to make it
consistent with LZMA_SYNC_FLUSH.
A few sanity checks were added for Subfilter handling. Some
small bugs were fixed. More comments were added.
Lasse Collin [Sat, 19 Jan 2008 13:19:21 +0000 (15:19 +0200)]
Revised the Delta filter implementation. The initialization
function is still shared between encoder and decoder, but the
actual coding is in separate files for encoder and decoder.
There are now separate functions for the actual delta
calculation depending on if Delta is the last filter in the
chain or not. If it is the last, the new code copies the
data from input to output buffer and does the delta
calculation at the same time. The old code first copied the
data, then did the delta in the target buffer, which required
reading through the data twice.
Support for LZMA_SYNC_FLUSH was added to the Delta encoder.
This doesn't change anything in the file format.
Lasse Collin [Fri, 18 Jan 2008 18:18:08 +0000 (20:18 +0200)]
Added the debug directory and the first debug tool
(sync_flush). These tools are not built unless the
user runs "make" in the debug directory.
Lasse Collin [Fri, 18 Jan 2008 18:13:00 +0000 (20:13 +0200)]
Added test files to test usage of flush marker in LZMA.
Lasse Collin [Fri, 18 Jan 2008 18:02:52 +0000 (20:02 +0200)]
Fix LZMA_SYNC_FLUSH handling in LZ and LZMA encoders.
That code is now almost completely in LZ coder, where
it can be shared with other LZ77-based algorithms in
future.
Lasse Collin [Fri, 18 Jan 2008 15:21:24 +0000 (17:21 +0200)]
Don't add -g to CFLAGS when --enable-debug is specified.
It's the job of the user to put that in CFLAGS.
Lasse Collin [Fri, 18 Jan 2008 12:17:37 +0000 (14:17 +0200)]
Set stdin and stdout to binary mode on Windows. This patch is
a forward port of
b7b22fcb979a16d3a47c8001f058c9f7d4416068
from lzma-utils-legacy.git. I don't know if the new code base
builds on Windows, but this is a start.
Lasse Collin [Thu, 17 Jan 2008 22:50:29 +0000 (00:50 +0200)]
Added test_compress.sh and bunch of files needed by it.
This new set of tests compress and decompress several
test files with many different compression options.
This set of tests will be extended later.
Lasse Collin [Thu, 17 Jan 2008 16:56:53 +0000 (18:56 +0200)]
Subblock decoder: Don't exit the main loop in decode_buffer()
too early if we hit End of Input while decoding a Subblock of
type Repeating Data. To keep the loop termination condition
elegant, the order of enumerations in coder->sequence were
changed.
To keep the case-labels in roughly the same order as the
enumerations in coder->sequence, large chunks of code was
moved around. This made the diff big and ugly compared to
the amount of the actual changes made.
Lasse Collin [Thu, 17 Jan 2008 15:39:42 +0000 (17:39 +0200)]
Fix wrong too small size of argument unfiltered_max
in ia64_coder_init(). It triggered assert() in
simple_coder.c, and could have caused a buffer overflow.
This error was probably a copypaste mistake, since most
of the simple filters use unfiltered_max = 4.
Lasse Collin [Thu, 17 Jan 2008 15:27:45 +0000 (17:27 +0200)]
Added --delta to the output of "lzma --help".
Lasse Collin [Thu, 17 Jan 2008 11:14:20 +0000 (13:14 +0200)]
Fix Subblock docoder: If Subblock filter was used with known
Uncompressed Size, and the last output byte was from RLE,
the code didn't stop decoding as it should have done.
Lasse Collin [Wed, 16 Jan 2008 14:33:37 +0000 (16:33 +0200)]
Tiny non-technical edits to file-format.txt.
Lasse Collin [Wed, 16 Jan 2008 12:48:04 +0000 (14:48 +0200)]
Plugged a memory leak in stream_decoder.c.
Lasse Collin [Wed, 16 Jan 2008 12:47:27 +0000 (14:47 +0200)]
Added memory leak detection to lzmadec.c.
Lasse Collin [Wed, 16 Jan 2008 12:46:50 +0000 (14:46 +0200)]
Added lzma_memlimit_count().
Lasse Collin [Wed, 16 Jan 2008 12:31:44 +0000 (14:31 +0200)]
Added ARRAY_SIZE(array) macro.
Lasse Collin [Wed, 16 Jan 2008 11:27:03 +0000 (13:27 +0200)]
Make Uncompresed Size validation more strict
in alone_decoder.c.
Lasse Collin [Tue, 15 Jan 2008 15:46:59 +0000 (17:46 +0200)]
Free the allocated memory in lzmadec if debugging is
enabled. This should make it possible to detect possible
memory leaks with Valgrind.
Lasse Collin [Tue, 15 Jan 2008 14:25:38 +0000 (16:25 +0200)]
Fix memory leaks from test_block_header.c.
Lasse Collin [Tue, 15 Jan 2008 12:23:35 +0000 (14:23 +0200)]
Use fastpos.h when encoding LZMA dictionary size in
Filter Flags encoder.
Lasse Collin [Tue, 15 Jan 2008 12:02:22 +0000 (14:02 +0200)]
Revised the fastpos code. It now uses the slightly faster
table-based version from LZMA SDK 4.57. This should be
fast on most systems.
A simpler and smaller alternative version is also provided.
On some CPUs this can be even a little faster than the
default table-based version (see comments in fastpos.h),
but on most systems the table-based code is faster.
Lasse Collin [Tue, 15 Jan 2008 11:32:13 +0000 (13:32 +0200)]
Added bsr.h.
Lasse Collin [Tue, 15 Jan 2008 11:29:14 +0000 (13:29 +0200)]
Fixed assembler detection in configure.ac, and added
detection for x86_64.
Lasse Collin [Tue, 15 Jan 2008 10:20:41 +0000 (12:20 +0200)]
Omit invalid space from printf() format string
in price_table_gen.c.
Lasse Collin [Tue, 15 Jan 2008 07:54:34 +0000 (09:54 +0200)]
Removed a few unused macros from lzma_common.h.
Lasse Collin [Tue, 15 Jan 2008 06:37:42 +0000 (08:37 +0200)]
Fix a typo in lzma_encoder.c.
Lasse Collin [Tue, 15 Jan 2008 06:36:25 +0000 (08:36 +0200)]
Convert bittree_get_price() and bittree_reverse_get_price()
from macros to inline functions.
Lasse Collin [Tue, 15 Jan 2008 05:44:59 +0000 (07:44 +0200)]
Fix CRC code in case --enable-small is used.
Lasse Collin [Tue, 15 Jan 2008 05:41:39 +0000 (07:41 +0200)]
Fix typo in test_index.c.
Lasse Collin [Tue, 15 Jan 2008 05:40:21 +0000 (07:40 +0200)]
Added precomputed range coder probability price table.
Lasse Collin [Mon, 14 Jan 2008 11:42:43 +0000 (13:42 +0200)]
Remove RC_BUFFER_SIZE from lzma_encoder_private.h
and replace it with a sanity check.
Lasse Collin [Mon, 14 Jan 2008 11:39:54 +0000 (13:39 +0200)]
Major changes to LZ encoder, LZMA encoder, and range encoder.
These changes implement support for LZMA_SYNC_FLUSH in LZMA
encoder, and move the temporary buffer needed by range encoder
from lzma_range_encoder structure to lzma_lz_encoder.
Lasse Collin [Mon, 14 Jan 2008 11:34:29 +0000 (13:34 +0200)]
Added one assert() to process.c of the command line tool.
Lasse Collin [Mon, 14 Jan 2008 10:09:52 +0000 (12:09 +0200)]
Don't use coder->lz.stream_end_was_reached in assertions
in match_c.h.
Lasse Collin [Mon, 14 Jan 2008 10:08:02 +0000 (12:08 +0200)]
In lzma_read_match_distances(), don't use
coder->lz.stream_end_was_reached. That variable
will be removed, and the check isn't required anyway.
Rearrange the check so that it doesn't make one to
think that there could be an integer overflow.
Lasse Collin [Mon, 14 Jan 2008 09:56:41 +0000 (11:56 +0200)]
Small LZMA_SYNC_FLUSH fixes to Block and Single-Stream encoders.
Lasse Collin [Mon, 14 Jan 2008 09:54:56 +0000 (11:54 +0200)]
More fixes to LZMA decoder's flush marker handling.
Lasse Collin [Thu, 10 Jan 2008 15:13:42 +0000 (17:13 +0200)]
Eliminate lzma_lz_encoder.must_move_pos. It's needed
only in one place which isn't performance criticial.
Lasse Collin [Wed, 9 Jan 2008 18:05:57 +0000 (20:05 +0200)]
Define HAVE_ASM_X86 when x86 assembler optimizations are
used. This #define will be useful for inline assembly.
Lasse Collin [Wed, 9 Jan 2008 10:06:46 +0000 (12:06 +0200)]
Added good-single-none-empty_3.lzma and
bad-single-none-empty.lzma.
Lasse Collin [Tue, 8 Jan 2008 21:11:59 +0000 (23:11 +0200)]
Take advantage of return_if_error() in block_decoder.c.
Lasse Collin [Tue, 8 Jan 2008 21:10:57 +0000 (23:10 +0200)]
Updated tests/files/README.
Lasse Collin [Tue, 8 Jan 2008 21:05:40 +0000 (23:05 +0200)]
Added test files with empty Compressed Data.
Lasse Collin [Tue, 8 Jan 2008 20:58:42 +0000 (22:58 +0200)]
Fix decoding of Blocks that have only Block Header.
Lasse Collin [Tue, 8 Jan 2008 20:27:46 +0000 (22:27 +0200)]
Added good-single-subblock_implicit.lzma.
Lasse Collin [Tue, 8 Jan 2008 16:50:30 +0000 (18:50 +0200)]
Disable CRC32 from Block Headers when --check=none
has been specified.
Lasse Collin [Tue, 8 Jan 2008 11:36:29 +0000 (13:36 +0200)]
Fixed encoding of empty files. Arguments to is_size_valid()
were in wrong order in block_encoder.c.
Lasse Collin [Tue, 8 Jan 2008 11:35:36 +0000 (13:35 +0200)]
Added a few test files.
Lasse Collin [Tue, 8 Jan 2008 10:29:58 +0000 (12:29 +0200)]
Avoid using ! in test_files.sh, because that doesn't work
with some ancient /bin/sh versions.
Lasse Collin [Mon, 7 Jan 2008 22:48:30 +0000 (00:48 +0200)]
More pre-C99 inttypes.h compatibility fixes. Now the code
should work even if the system has no inttypes.h.
Lasse Collin [Mon, 7 Jan 2008 21:25:32 +0000 (23:25 +0200)]
Updated fi.po although it's currently pretty much crap.
Lasse Collin [Mon, 7 Jan 2008 21:14:25 +0000 (23:14 +0200)]
Test for $GCC = yes instead of if it is non-empty. This
way it is possible to use ac_cv_c_compiler_gnu=no to
force configure to think it is using non-GNU C compiler.
Lasse Collin [Mon, 7 Jan 2008 19:49:41 +0000 (21:49 +0200)]
Added test_files.sh to tests/Makefile.am so it gets
included in the tarball with "make dist".
Lasse Collin [Mon, 7 Jan 2008 16:22:24 +0000 (18:22 +0200)]
Cosmetic edit to test_files.sh.
Lasse Collin [Mon, 7 Jan 2008 16:09:44 +0000 (18:09 +0200)]
Added tests/files/README.
Lasse Collin [Mon, 7 Jan 2008 12:20:57 +0000 (14:20 +0200)]
Tell in COPYING that everything in tests/files is
public domain.
Lasse Collin [Mon, 7 Jan 2008 12:19:05 +0000 (14:19 +0200)]
Cleaned up the tests/files directory.
Lasse Collin [Mon, 7 Jan 2008 11:49:19 +0000 (13:49 +0200)]
Added test_files.sh to test decoding of the files in
the tests/files directory. It doesn't test the malicious
files yet.
Lasse Collin [Mon, 7 Jan 2008 09:23:13 +0000 (11:23 +0200)]
Updated README regarding the assembler optimizations.
Lasse Collin [Mon, 7 Jan 2008 08:58:00 +0000 (10:58 +0200)]
Updated THANKS.