msarett [Wed, 19 Aug 2015 15:12:57 +0000 (08:12 -0700)]
Forgot to add resources with new test
I created these images using mandrill_16.png (already in
resources) and an online tool.
https://codereview.chromium.org/
1287863004/
BUG=skia:
Review URL: https://codereview.chromium.org/
1297723004
mtklein [Wed, 19 Aug 2015 15:11:37 +0000 (08:11 -0700)]
Revert of Have DM manually encode its .png outputs. (patchset #2 id:20001 of https://codereview.chromium.org/
1304443002/ )
Reason for revert:
derek + Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Debug
Original issue's description:
> Have DM manually encode its .png outputs.
>
> This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
3cc0dfffb70c0bd08ed8899efcd2e98da86a6ec7
TBR=stephana@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1297383002
herb [Wed, 19 Aug 2015 14:47:55 +0000 (07:47 -0700)]
Revert of SkCanvas::onDrawPicture() quick-reject (patchset #3 id:40001 of https://codereview.chromium.org/
1264133003/ )
Reason for revert:
Seems to be breaking some blink tests.
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/75812/layout-test-results/results.html
Original issue's description:
> SkCanvas::onDrawPicture() quick-reject
>
> R=reed@google.com,mtklein@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
48ed62b29d45e42b971aac8858da06781c93e6d7
>
> Committed: https://skia.googlesource.com/skia/+/
d3d07245e29504dbffa0083e84ace5bab85853d4
TBR=mtklein@google.com,reed@google.com,mtklein@chromium.org,fmalita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1301973002
mtklein [Wed, 19 Aug 2015 14:37:51 +0000 (07:37 -0700)]
Have DM manually encode its .png outputs.
This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags.
BUG=skia:
Review URL: https://codereview.chromium.org/
1304443002
halcanary [Wed, 19 Aug 2015 14:22:04 +0000 (07:22 -0700)]
SkStream Testing: fix bug in new unit test.
Review URL: https://codereview.chromium.org/
1297143004
mtklein [Wed, 19 Aug 2015 14:11:34 +0000 (07:11 -0700)]
add missing override
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1292073003
joshualitt [Wed, 19 Aug 2015 13:54:08 +0000 (06:54 -0700)]
fill rect batch refactor into separate batches
BUG=skia:
Review URL: https://codereview.chromium.org/
1295773003
Brian Salomon [Wed, 19 Aug 2015 13:44:48 +0000 (09:44 -0400)]
Init class ID in GrStencilPathBatch
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/
1300093007
halcanary [Wed, 19 Aug 2015 13:12:40 +0000 (06:12 -0700)]
Fix stack overuse error
Review URL: https://codereview.chromium.org/
1283193008
bsalomon [Wed, 19 Aug 2015 13:12:36 +0000 (06:12 -0700)]
Fix VS 2015 build
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
1297283003
fmalita [Wed, 19 Aug 2015 13:07:36 +0000 (06:07 -0700)]
SkCanvas::onDrawPicture() quick-reject
R=reed@google.com,mtklein@google.com
Committed: https://skia.googlesource.com/skia/+/
48ed62b29d45e42b971aac8858da06781c93e6d7
Review URL: https://codereview.chromium.org/
1264133003
reed [Wed, 19 Aug 2015 13:07:29 +0000 (06:07 -0700)]
widen gm to show entire image, add place-holder for no context
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1294113003
halcanary [Tue, 18 Aug 2015 20:30:25 +0000 (13:30 -0700)]
SkPDF/Deflate: clean up old SkFlate code
Factor out some of https://crrev.com/
1227913008
BUG=skia:3030
Review URL: https://codereview.chromium.org/
1298243002
bsalomon [Tue, 18 Aug 2015 20:28:19 +0000 (13:28 -0700)]
Path stenciling in GrBatch
Review URL: https://codereview.chromium.org/
1293973003
msarett [Tue, 18 Aug 2015 20:22:46 +0000 (13:22 -0700)]
Test scaling for small images
We don't want to test small images on Gold because they are
not interested to look at. Instead, I wrote a unit test to
verify that scaling small images does not cause crashes.
BUG=skia:
Review URL: https://codereview.chromium.org/
1287863004
egdaniel [Tue, 18 Aug 2015 20:08:36 +0000 (13:08 -0700)]
Try enabling all nanobenches on Nexus7
BUG=skia:2774
Review URL: https://codereview.chromium.org/
1290223005
reed [Tue, 18 Aug 2015 19:50:24 +0000 (12:50 -0700)]
handle no shader from image in drawAtlas
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1298233003
bsalomon [Tue, 18 Aug 2015 19:30:02 +0000 (12:30 -0700)]
Remove Cmd in GrTargetCommands that is no longer needed with GrCopySurfaceBatch
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/
1292623004
mtklein [Tue, 18 Aug 2015 19:23:28 +0000 (12:23 -0700)]
Try again to put SkXfermode_opts in SK_OPTS_NS
Remember failed attempt https://codereview.chromium.org/
1286093004/ ? I think this one is simpler and safer and even technically legal C++.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1296183004
joshualitt [Tue, 18 Aug 2015 19:13:34 +0000 (12:13 -0700)]
Add skeleton json support to visualbench
BUG=skia:
Review URL: https://codereview.chromium.org/
1298213002
bsalomon [Tue, 18 Aug 2015 19:12:35 +0000 (12:12 -0700)]
GrCopySurfaceBatch
Review URL: https://codereview.chromium.org/
1289673004
wangyix [Tue, 18 Aug 2015 19:00:12 +0000 (12:00 -0700)]
added emitChild() to GrGLFragmentProcessor; removed AutoFragmentChildProcAdvance class
BUG=skia:4182
Review URL: https://codereview.chromium.org/
1301523003
senorblanco [Tue, 18 Aug 2015 18:46:28 +0000 (11:46 -0700)]
Add support for non-mappable vert buffers to tessellating path renderer.
Use malloc-ed memory and the updateData() call instead.
BUG=skia:4215
Review URL: https://codereview.chromium.org/
1288683004
msarett [Tue, 18 Aug 2015 18:36:44 +0000 (11:36 -0700)]
Revert of Update skia to test with libpng to 1.6.10 (patchset #3 id:60001 of https://codereview.chromium.org/
1301523005/ )
Reason for revert:
DM is failing on gm tests on Android bots. Cause is not yet clear.
Original issue's description:
> Update skia to test with libpng to 1.6.10
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
f272bb03df9b86e7ea2cf23fb4d5cc56624e0118
TBR=djsollen@google.com,scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1298223002
wangyix [Tue, 18 Aug 2015 18:29:31 +0000 (11:29 -0700)]
When getGLInstance is called on a frag proc, the resulting GrGLFragmentProcessor will be the root of a tree of GrGLFragmentProcessors that mirrors the GrFragmentProcessor's tree. This allows setData() to be called recursively (removing the responsibility from compose shader) and allows gl instances direct access to their children gl instances so they can emit their code.
BUG=skia:4182
Review URL: https://codereview.chromium.org/
1287023009
reed [Tue, 18 Aug 2015 18:16:09 +0000 (11:16 -0700)]
Add subsets to SkImageGenerator and SkImageCacherator
... to support subsets in SkImage!
BUG=skia:
Review URL: https://codereview.chromium.org/
1301633002
msarett [Tue, 18 Aug 2015 17:46:01 +0000 (10:46 -0700)]
Update skia to test with libpng to 1.6.10
BUG=skia:
Review URL: https://codereview.chromium.org/
1301523005
hcm [Tue, 18 Aug 2015 17:38:00 +0000 (10:38 -0700)]
Add internal links section to skia.org
BUG=skia:4142
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1284043004
Review URL: https://codereview.chromium.org/
1284043004
bsalomon [Tue, 18 Aug 2015 17:33:30 +0000 (10:33 -0700)]
ClearStencilClip in GrBatch
Review URL: https://codereview.chromium.org/
1288963004
joshualitt [Tue, 18 Aug 2015 17:16:01 +0000 (10:16 -0700)]
Move GrTBatchTesselator to its own file
BUG=skia:
Review URL: https://codereview.chromium.org/
1298983002
mtklein [Tue, 18 Aug 2015 17:00:29 +0000 (10:00 -0700)]
Update SkOpts namespaces.
portable -> default, and everyone gets an sk_ prefix.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1299013003
Brian Salomon [Tue, 18 Aug 2015 16:46:51 +0000 (12:46 -0400)]
Add missing overrides to clear and discard batch dumpInfo()
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/
1303533003
mtklein [Tue, 18 Aug 2015 16:43:28 +0000 (09:43 -0700)]
Patches on top of Radu's latest.
patch from issue
1273033005 at patchset 120001 (http://crrev.com/
1273033005#ps120001)
BUG=skia:
Review URL: https://codereview.chromium.org/
1288323004
bungeman [Tue, 18 Aug 2015 16:34:07 +0000 (09:34 -0700)]
Use portable code for family names with DirectWrite.
IDWriteFamily::GetFamilyNames appears to be 'helpful' and removes
parts of family names that look like style names. Since the iterator
is supposed to return the actual names and not just the name the
platform thinks the name is (as getFamilyName does), try returning
the raw names when possible.
BUG=skia:4217
Review URL: https://codereview.chromium.org/
1302573002
bsalomon [Tue, 18 Aug 2015 16:20:09 +0000 (09:20 -0700)]
Put clear and discard into GrBatch.
Review URL: https://codereview.chromium.org/
1293563003
mtklein [Tue, 18 Aug 2015 15:51:49 +0000 (08:51 -0700)]
Update BUILD.public a bit.
- SSE2 files are unfortunately now mixed-case, _SSE2 or _sse2.
- Adds lists for SSSE3 and SSE4 files.
- Remove SkDocument_PDF_None.cpp
- Remove a few more references to animator.
- Exclude private headers from HDRS.
- Formatting and notes.
BUG=skia:
Review URL: https://codereview.chromium.org/
1298003007
halcanary [Tue, 18 Aug 2015 15:35:45 +0000 (08:35 -0700)]
Clean up BUILD_simulator.py
Review URL: https://codereview.chromium.org/
1298813002
mtklein [Tue, 18 Aug 2015 15:29:59 +0000 (08:29 -0700)]
Deduplicate typefaces across sub-pictures
Old flow to serialize a picture:
1) serialize picture ops
2) serialize all sub pictures recursively
3) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go
4) serialize the factories and typefaces
5) serialize the bytes from 3)
This allows the data in step 5) to refer to the deduplicated factories and typefaces from step 4). But, each sub picture in step 2) is completely siloed, so they can't dedup with the parent picture or each other.
New flow:
1) serialize picture ops
2) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go
3) dummy-serialize sub pictures into /dev/null, with the effect of adding any new typefaces to our dedup set
4) serialize the factories and typefaces
5) serialize the bytes from 2)
6) serialize all sub pictures recursively, with perfect deduplication because of step 3).
Now all typefaces in the top-level picture and all sub pictures recursively should end up deduplicated in the top-level typeface set.
Decoding changes are similar: we just thread through the top-level typefaces to the sub pictures. What's convenient / surprising is that this new code correctly reads old pictures if we just have each picture prefer its local typeface set over the top-level one: old pictures always just use their own typefaces, and new pictures always use the top-level ones.
BUG=skia:4092
Review URL: https://codereview.chromium.org/
1233953004
msarett [Tue, 18 Aug 2015 15:03:58 +0000 (08:03 -0700)]
Prefer native scaling to sampling
In the cases we have come across so far, native scaling has better performance
and correctness than sampling. If native scaling is supported we want to use
it.
Jpegs native scale rounds up.
Ex: An 11x11 image with sampleSize=8 scales to 2x2.
SkScaledCodec rounds down.
Ex: An 11x11 image with sampleSize=8 scales to 1x1.
Before the CL, we would choose to use SkScaledCodec because it scales closer to
the "ideal" scale.
I think we want to go with the native option as long as its within 1 of the
ideal value.
BUG=skia:
Review URL: https://codereview.chromium.org/
1284243004
jvanverth [Tue, 18 Aug 2015 14:44:22 +0000 (07:44 -0700)]
Regenerate LCD text blobs if GrPaint's color changes, not SkPaint.
The GrPaint's color takes into account shaders and color filters, so is a
more accurate picture of the color state.
BUG=chromium:511787
Review URL: https://codereview.chromium.org/
1297053004
wangyix [Tue, 18 Aug 2015 14:39:33 +0000 (07:39 -0700)]
Made isEqual in GrFragmentProcessor recursive
Added comment about how computeInvariantOutput() is non-recursive in GrFragmentProcessor
Made isEqual() recursive in GrFragmentProcessor
BUG=skia:4182
Review URL: https://codereview.chromium.org/
1287343005
joshualitt [Tue, 18 Aug 2015 14:25:38 +0000 (07:25 -0700)]
GrAAFillRectBatch holds onto GrPipelineOptimizations
BUG=skia:
Review URL: https://codereview.chromium.org/
1301603004
wangyix [Tue, 18 Aug 2015 14:24:29 +0000 (07:24 -0700)]
Added class AutoFragmentChildProcAdvance to be constructed before a child emitCode and destructed after
Fixed wrong indent
Changed auto child advance back to backwards linear search for getting subset of coords and samplers array of a child
Used offset from parent instead of backwards linear search to find a child proc's coords and transforms in Auto...Advance
append mangleString to variable name in nameVariable()
BUILDS! Added AutoFragmentChildProcAdvance class; fixed a few errors from previous commits
BUG=skia:4182
Review URL: https://codereview.chromium.org/
1286293002
caryclark [Tue, 18 Aug 2015 14:12:43 +0000 (07:12 -0700)]
fix pathops fuzz failures
If a curve has the identical start and control points, the
initial or final tangent can't be trivally determined. The
perpendicular to the tangent is used to measure coincidence.
Add logic for cubics, quadratics, and conics, to use the
secondary control points or the end points if the initial
control point alone can't determine the tangent.
Add debugging (currently untriggered by exhaustive testing)
to detect zero-length tangents which are not at the curve
endpoints.
Increase the number of temporary intersecions gathered from
10 to 12 but reduce the max passed in by cubic intersection from
27 to 12. Also, add checks if the max passed exceeds the
storage allocated.
When cleaning up parallel lines, choose the intersection which
is on the end of both segments over the intersection which
is on the end of a single segment.
TBR=reed@google.com
BUG=425140,516266
Review URL: https://codereview.chromium.org/
1288863004
benjaminwagner [Tue, 18 Aug 2015 13:25:14 +0000 (06:25 -0700)]
Reland of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/
1295213002/ )
Reason for revert:
Retry.
Original issue's description:
> Revert of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/
1291343006/ )
>
> Reason for revert:
> MacMini buildbots were unable to apply the patch.
> fatal: Could not parse object '
18af0a0080cc2b2b3464292d35a0886cdade551f'.
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1580
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Debug/builds/1474
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1566
> http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1480
> http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1456
> http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1364
>
>
> Original issue's description:
> > Fix a few bugs in the google3 sync scripts.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
18af0a0080cc2b2b3464292d35a0886cdade551f
>
> TBR=mtklein@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
e349d6b92574c1b0acdb4ba1ed8ff905ea830131
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1284093003
bsalomon [Tue, 18 Aug 2015 13:05:14 +0000 (06:05 -0700)]
Privatize GrBatch subclass overrides
Review URL: https://codereview.chromium.org/
1301663002
mtklein [Tue, 18 Aug 2015 12:51:56 +0000 (05:51 -0700)]
Remove a couple zombie pathops files.
These files don't compile and are not referenced by any GYP file.
BUG=skia:
Review URL: https://codereview.chromium.org/
1299773002
mtklein [Tue, 18 Aug 2015 12:18:52 +0000 (05:18 -0700)]
Remove SkOpts_sse2.cpp.
It's sort of pointless: all our clients that will have SSE2 at runtime have it
unconditionally at compile time, so the functions in namespace portable will
pick up the SSE2 code. The procs in SkOpts_sse2.o were just duplicate code.
A couple of the procs we had in _sse2.cpp can benefit slightly when compiled
with SSSE3. I've moved those to _ssse3.cpp. This should lead to small speedups
on platforms like Linux and Windows that have a baseline of SSE2.
Similarly, I've removed the call to Init_neon() when NEON is available globally... it's a no-op.
Renaming namespace portable to something clearer is TBD.
BUG=skia:4117
Review URL: https://codereview.chromium.org/
1294213002
reed [Tue, 18 Aug 2015 01:29:47 +0000 (18:29 -0700)]
Revert[8] "move some public headers into private"
This reverts commit
fb28cd2b13d76c324570341e1155aaadc1b532b6.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1298833002
robertphillips [Mon, 17 Aug 2015 22:04:47 +0000 (15:04 -0700)]
Move normal map creation methods to sk_tools
Split off of https://codereview.chromium.org/
1261433009/ (Add SkCanvas::drawLitAtlas call)
Review URL: https://codereview.chromium.org/
1298763002
mtklein [Mon, 17 Aug 2015 22:02:57 +0000 (15:02 -0700)]
Add a simple script to simulate BUILD file glob() expansion.
This lets us test changes to BUILD.public.
This is not yet automated in any way. My hope is to trigger it quietly via the presubmit for any CL that adds or removes a file, or changes BUILD.public.
BUG=skia:
Review URL: https://codereview.chromium.org/
1290833003
benjaminwagner [Mon, 17 Aug 2015 21:44:01 +0000 (14:44 -0700)]
Revert of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/
1291343006/ )
Reason for revert:
MacMini buildbots were unable to apply the patch.
fatal: Could not parse object '
18af0a0080cc2b2b3464292d35a0886cdade551f'.
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1580
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Debug/builds/1474
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1566
http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1480
http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1456
http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1364
Original issue's description:
> Fix a few bugs in the google3 sync scripts.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
18af0a0080cc2b2b3464292d35a0886cdade551f
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1295213002
benjaminwagner [Mon, 17 Aug 2015 21:23:03 +0000 (14:23 -0700)]
Fix a few bugs in the google3 sync scripts.
BUG=skia:
Review URL: https://codereview.chromium.org/
1291343006
benjaminwagner [Mon, 17 Aug 2015 19:58:10 +0000 (12:58 -0700)]
Add files added to Skia HEAD in google3 to the Git repo.
LICENSE is modified in google3 to mention some code copied from other projects.
BUG=skia:
Review URL: https://codereview.chromium.org/
1291603003
bsalomon [Mon, 17 Aug 2015 19:55:38 +0000 (12:55 -0700)]
Make GrVertexBatch objects hold their own draws during GrDrawTarget flush
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/
1286043004
joshualitt [Mon, 17 Aug 2015 18:53:44 +0000 (11:53 -0700)]
Stop ping ponging AA in SkGpuDevice
BUG=skia:
Review URL: https://codereview.chromium.org/
1299703003
mtklein [Mon, 17 Aug 2015 18:15:00 +0000 (11:15 -0700)]
Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin. (patchset #1 id:1 of https://codereview.chromium.org/
1296253003/ )
Reason for revert:
This will make the google3 roll awkward. Reverting.
Original issue's description:
> Depend on ETC1 via DEPS instead of a direct third_party checkin.
>
> Yes, this does mean we'll check out ~40M of code for 2 files...
>
> I think these trybots are moot... they gclient sync before patching.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
ca01d179347b5e848ded97c8228b79ffc6b5e7bf
TBR=robertphillips@google.com,djsollen@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1290913008
joshualitt [Mon, 17 Aug 2015 17:51:22 +0000 (10:51 -0700)]
drawBitmapImage can batch across AA rects
BUG=464835
Committed: https://skia.googlesource.com/skia/+/
0d4bcea0d570041434ac3de2df2bd9063138fdb5
Review URL: https://codereview.chromium.org/
1293543002
Derek Sollenberger [Mon, 17 Aug 2015 17:39:03 +0000 (13:39 -0400)]
fix typo in android_framework_lib.gyp
BUG=skia:
Review URL: https://codereview.chromium.org/
1293183002 .
djsollen [Mon, 17 Aug 2015 17:20:46 +0000 (10:20 -0700)]
Add GPU to the android include path.
Review URL: https://codereview.chromium.org/
1301623002
mtklein [Mon, 17 Aug 2015 17:20:16 +0000 (10:20 -0700)]
Depend on ETC1 via DEPS instead of a direct third_party checkin.
Yes, this does mean we'll check out ~40M of code for 2 files...
I think these trybots are moot... they gclient sync before patching.
BUG=skia:
Review URL: https://codereview.chromium.org/
1296253003
caryclark [Mon, 17 Aug 2015 17:01:23 +0000 (10:01 -0700)]
remove unused code
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
1297013002
fmalita [Mon, 17 Aug 2015 15:05:13 +0000 (08:05 -0700)]
SkPaintFilterCanvas should inherit the target canvas state
Currently, SkPaintFilterCanvas does not provide any help in cloning
target canvas state. While that could be handled in subclasses, it is
easy to miss (see linked bug).
This CL adds a new constructor variant which ensures that the initial
matrix and clip bounds are inherited from the target canvas.
BUG=516790
R=reed@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/
1294013002
msarett [Mon, 17 Aug 2015 14:49:37 +0000 (07:49 -0700)]
Fix webp compile warnings on windows
This fix was landed with:
https://codereview.chromium.org/
1280073002/
The above CL was reverted due to an unrelated bug in libwebp.
The above CL contains multiple components, and I think that
reverting this part of the change was unintentional.
BUG=skia:
Review URL: https://codereview.chromium.org/
1286903003
joshualitt [Mon, 17 Aug 2015 14:20:58 +0000 (07:20 -0700)]
Revert of drawBitmapImage can batch across AA rects (patchset #5 id:80001 of https://codereview.chromium.org/
1293543002/ )
Reason for revert:
a follow up patch exposes a bug
Original issue's description:
> drawBitmapImage can batch across AA rects
>
> BUG=464835
>
> Committed: https://skia.googlesource.com/skia/+/
0d4bcea0d570041434ac3de2df2bd9063138fdb5
TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464835
Review URL: https://codereview.chromium.org/
1291663005
joshualitt [Mon, 17 Aug 2015 13:59:36 +0000 (06:59 -0700)]
drawBitmapImage can batch across AA rects
BUG=464835
Review URL: https://codereview.chromium.org/
1293543002
rmistry [Sun, 16 Aug 2015 07:20:54 +0000 (00:20 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/
1296513004
reed [Sat, 15 Aug 2015 21:02:29 +0000 (14:02 -0700)]
support both box and circle lcd
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1292943003
reed [Sat, 15 Aug 2015 18:57:23 +0000 (11:57 -0700)]
show LCD on max fat-zoom
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1295483003
rmistry [Sat, 15 Aug 2015 18:00:57 +0000 (11:00 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/
1291273003
reed [Sat, 15 Aug 2015 15:46:27 +0000 (08:46 -0700)]
Revert[7] "move some public headers into private"
This reverts commit
e02716908fe82c7c4ae9b415793277620a22bcd6.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1300523002
reed [Sat, 15 Aug 2015 14:42:31 +0000 (07:42 -0700)]
increase zoom in fatbits
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1300513002
reed [Sat, 15 Aug 2015 14:28:34 +0000 (07:28 -0700)]
Revert[6] "move some public headers into private"
This reverts commit
cc1229c9d5e57b45305ba8f99ae33e92db0032bc.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1295003002
joshualitt [Fri, 14 Aug 2015 18:36:03 +0000 (11:36 -0700)]
Revert of stop dropping AA when rect stays rect (patchset #8 id:140001 of https://codereview.chromium.org/
1295523002/ )
Reason for revert:
breaks layout tests
Original issue's description:
> stop dropping AA when rect stays rect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
1bef9f59c566cc54c2259cc4d0171c115157cd1c
TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1295813005
halcanary [Fri, 14 Aug 2015 18:26:33 +0000 (11:26 -0700)]
SkPDF: Move SkFlate into src/pdf (part 3/3)
This must land after http://crrev.com/
1288053002
Motivation: Skia only uses SkFlate in the SkPDF module.
Review URL: https://codereview.chromium.org/
1288063002
mtklein [Fri, 14 Aug 2015 17:03:45 +0000 (10:03 -0700)]
A bit of misc cleanup.
- Update comments about skia_shared_lib
- Remove dead code (system_preferences)
- Remove non-building code (techtalk1)
- Turn gm/annotated_text back on.
BUG=skia:
Review URL: https://codereview.chromium.org/
1286133004
joshualitt [Fri, 14 Aug 2015 16:01:21 +0000 (09:01 -0700)]
fix valgrind issue
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1289203004
joshualitt [Fri, 14 Aug 2015 15:45:39 +0000 (08:45 -0700)]
fix viewmatrix mapping in AAFillRect
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1293823003
egdaniel [Fri, 14 Aug 2015 15:37:50 +0000 (08:37 -0700)]
Add include paths in gputest.gyp for use by additional gpu tests.
BUG=skia:
Review URL: https://codereview.chromium.org/
1290553005
mtklein [Fri, 14 Aug 2015 15:33:50 +0000 (08:33 -0700)]
Build all GMs on Android.
Many of these were excluded from the build for bots that no longer exist.
Will fix up anything that starts failing using dm_flags.py.
BUG=skia:2326,skia:2313, skia:1978
Review URL: https://codereview.chromium.org/
1290943004
scroggo [Fri, 14 Aug 2015 15:32:46 +0000 (08:32 -0700)]
Support more swizzles to 565 in SkCodec
Add more swizzling functions for swizzling to 565. Much of this
code was revived from crrev.com/
1055743003 (for BMP). Also added
swizzling functions for WBMP.
Consolidate the static function conversion_possible.
In SkCodec::getPixels, check that the alphatype corresponds to the
colorType. This prevents requesting 565 + non-opaque.
In SkIcoCodec, report that the image is unpremul (instead of
whatever the largest embedded codec thinks), but modify the
requested info to have the alpha type expected/required by the
embedded codec.
Add tests for decoding to 565.
BUG=skia:3257
BUG=skia:3683
Review URL: https://codereview.chromium.org/
1277213002
emmaleer [Fri, 14 Aug 2015 14:44:46 +0000 (07:44 -0700)]
SkScaledCodec class
This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling
this class is currently only working for png and jpeg images
I will update other Codec types to work soon
For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
0944100ac89f797714eeae0cf2875e2335ff52ee
Committed: https://skia.googlesource.com/skia/+/
d518ea7927f9f4e0ed5b4134d1b4f48243855a47
Committed: https://skia.googlesource.com/skia/+/
b157917507d4f7d2651f0aeb566d31603cc02240
Review URL: https://codereview.chromium.org/
1260673002
joshualitt [Fri, 14 Aug 2015 14:10:57 +0000 (07:10 -0700)]
stop dropping AA when rect stays rect
BUG=skia:
Review URL: https://codereview.chromium.org/
1295523002
egdaniel [Fri, 14 Aug 2015 13:37:37 +0000 (06:37 -0700)]
Revert of SkScaledCodec class (patchset #35 id:680001 of https://codereview.chromium.org/
1260673002/ )
Reason for revert:
breaking ubuntu bots
Original issue's description:
> SkScaledCodec class
>
> This class does scaling by using a scanlineDecoder.
> getScanlines and skipScanlines are used for y sampling,
> the swizzler is used for x sampling
>
> this class is currently only working for png and jpeg images
> I will update other Codec types to work soon
>
> For SkJpegCodec to implement width wise swizzling it now
> uses a swizzler. I ran performance tests on this change.
> Here are the performance test results:
> https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
0944100ac89f797714eeae0cf2875e2335ff52ee
>
> Committed: https://skia.googlesource.com/skia/+/
d518ea7927f9f4e0ed5b4134d1b4f48243855a47
>
> Committed: https://skia.googlesource.com/skia/+/
b157917507d4f7d2651f0aeb566d31603cc02240
TBR=scroggo@google.com,msarett@google.com,djsollen@google.com,mtklein@google.com,emmaleer@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1285173003
joshualitt [Fri, 14 Aug 2015 13:30:50 +0000 (06:30 -0700)]
Add GM to test drawing atlas case
BUG=skia:
Review URL: https://codereview.chromium.org/
1294513002
mtklein [Fri, 14 Aug 2015 12:49:17 +0000 (05:49 -0700)]
Revert of Paranoid temporary check that Chrome's building with SSE2 on all Windows builders. (patchset #1 id:1 of https://codereview.chromium.org/
1283183004/ )
Reason for revert:
Nothing broke. Experiment is over... SSE2 is present.
Original issue's description:
> Paranoid temporary check that Chrome's building with SSE2 on all Windows builders.
>
> BUG=chromium:475596
>
> Committed: https://skia.googlesource.com/skia/+/
e8445307ac33eddcf04457ae21040e47dc9c2a97
TBR=egdaniel@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:475596
Review URL: https://codereview.chromium.org/
1296593002
emmaleer [Fri, 14 Aug 2015 12:46:08 +0000 (05:46 -0700)]
SkScaledCodec class
This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling
this class is currently only working for png and jpeg images
I will update other Codec types to work soon
For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
0944100ac89f797714eeae0cf2875e2335ff52ee
Committed: https://skia.googlesource.com/skia/+/
d518ea7927f9f4e0ed5b4134d1b4f48243855a47
Review URL: https://codereview.chromium.org/
1260673002
mtklein [Fri, 14 Aug 2015 00:53:28 +0000 (17:53 -0700)]
Paranoid temporary check that Chrome's building with SSE2 on all Windows builders.
BUG=chromium:475596
Review URL: https://codereview.chromium.org/
1283183004
bsalomon [Thu, 13 Aug 2015 21:55:50 +0000 (14:55 -0700)]
Split GrDrawBatch and GrVertexBatch into their own files
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/
1296483002
reed [Thu, 13 Aug 2015 21:06:46 +0000 (14:06 -0700)]
some catchup CL revisions
BUG=skia:
Review URL: https://codereview.chromium.org/
1295593002
mtklein [Thu, 13 Aug 2015 21:02:06 +0000 (14:02 -0700)]
Every pixel ref gets its own mutex.
Seems like a memory-saving flourish follow up would be to use SkSpinlock.
BUG=Florin's email.
Review URL: https://codereview.chromium.org/
1289623004
emmaleer [Thu, 13 Aug 2015 20:59:21 +0000 (13:59 -0700)]
Revert of SkScaledCodec class (patchset #34 id:660001 of https://codereview.chromium.org/
1260673002/ )
Reason for revert:
Seg-faulting:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Release/builds/1608/steps/dm/logs/stdio
Original issue's description:
> SkScaledCodec class
>
> This class does scaling by using a scanlineDecoder.
> getScanlines and skipScanlines are used for y sampling,
> the swizzler is used for x sampling
>
> this class is currently only working for png and jpeg images
> I will update other Codec types to work soon
>
> For SkJpegCodec to implement width wise swizzling it now
> uses a swizzler. I ran performance tests on this change.
> Here are the performance test results:
> https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
0944100ac89f797714eeae0cf2875e2335ff52ee
>
> Committed: https://skia.googlesource.com/skia/+/
d518ea7927f9f4e0ed5b4134d1b4f48243855a47
TBR=scroggo@google.com,msarett@google.com,djsollen@google.com,mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1294613002
jvanverth [Thu, 13 Aug 2015 20:41:03 +0000 (13:41 -0700)]
Belt and suspenders for colors in DrawAtlasBatch test
Review URL: https://codereview.chromium.org/
1290253002
bsalomon [Thu, 13 Aug 2015 20:34:48 +0000 (13:34 -0700)]
Introduce GrBatch subclasses GrDrawBatch and GrVertexBatch to prepare for non-drawing batches
Review URL: https://codereview.chromium.org/
1293583002
reed [Thu, 13 Aug 2015 20:32:39 +0000 (13:32 -0700)]
Extend SkImageGenerator to support natively generated GrTextures. As part of this, added uniqueID() to the generator, and made it be in the same namespace is bitmaps, pixelrefs, images.
To do this, create SkImageCacherator, which wraps a generator and provides an
interface to get a cached answer for either the raster or texture output of
the generator.
BUG=skia:
Review URL: https://codereview.chromium.org/
1291803002
mtklein [Thu, 13 Aug 2015 20:10:30 +0000 (13:10 -0700)]
Normalize SkXfermode_opts.h argument order as d,s[,aa].
At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa]
so we ended up having to write weird little lambda shims to match impedance.
There's no reason for these to disagree, and d,s[,aa] is the One True Order
(because no matter what you're doing in graphics, there's always a dst).
Should be no perf or image diff, though I'm suspicious it might help MSVC code generation.
BUG=skia:4117
Committed: https://skia.googlesource.com/skia/+/
6028a8476504022fe40b6870b1460b5e4a80969f
CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot
Review URL: https://codereview.chromium.org/
1289903002
emmaleer [Thu, 13 Aug 2015 20:07:03 +0000 (13:07 -0700)]
SkScaledCodec class
This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling
this class is currently only working for png and jpeg images
I will update other Codec types to work soon
For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
0944100ac89f797714eeae0cf2875e2335ff52ee
Review URL: https://codereview.chromium.org/
1260673002
jvanverth [Thu, 13 Aug 2015 18:53:39 +0000 (11:53 -0700)]
Fix for VALGRIND DrawAtlas test issue.
Don't pre-alloc color array.
Review URL: https://codereview.chromium.org/
1289003002
emmaleer [Thu, 13 Aug 2015 18:44:05 +0000 (11:44 -0700)]
Revert of SkScaledCodec class (patchset #32 id:620001 of https://codereview.chromium.org/
1260673002/ )
Reason for revert:
Segfaulting:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Release/builds/1605/steps/dm/logs/stdio
Original issue's description:
> SkScaledCodec class
>
> This class does scaling by using a scanlineDecoder.
> getScanlines and skipScanlines are used for y sampling,
> the swizzler is used for x sampling
>
> this class is currently only working for png and jpeg images
> I will update other Codec types to work soon
>
> For SkJpegCodec to implement width wise swizzling it now
> uses a swizzler. I ran performance tests on this change.
> Here are the performance test results:
> https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
0944100ac89f797714eeae0cf2875e2335ff52ee
TBR=scroggo@google.com,msarett@google.com,djsollen@google.com,mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1294593002
emmaleer [Thu, 13 Aug 2015 18:26:57 +0000 (11:26 -0700)]
SkScaledCodec class
This class does scaling by using a scanlineDecoder.
getScanlines and skipScanlines are used for y sampling,
the swizzler is used for x sampling
this class is currently only working for png and jpeg images
I will update other Codec types to work soon
For SkJpegCodec to implement width wise swizzling it now
uses a swizzler. I ran performance tests on this change.
Here are the performance test results:
https://docs.google.com/a/google.com/spreadsheets/d/1D7-Q_GXD_dI68LZO005NNvb8Wq2Ee0wEBEPG72671yw/edit?usp=sharing
BUG=skia:
Review URL: https://codereview.chromium.org/
1260673002