platform/upstream/v8.git
9 years agoEnsure double alignment when deserializing.
yangguo [Thu, 27 Nov 2014 09:22:10 +0000 (01:22 -0800)]
Ensure double alignment when deserializing.

R=rmcilroy@chromium.org
BUG=chromium:436510
LOG=N
TEST=compile with V8_OOL_CONSTANT_POOL=1, run d8 with --verify-heap --test

Review URL: https://codereview.chromium.org/759823006

Cr-Commit-Position: refs/heads/master@{#25534}

9 years ago[turbofan] add initial move optimizer
dcarney [Thu, 27 Nov 2014 09:19:31 +0000 (01:19 -0800)]
[turbofan] add initial move optimizer

R=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/750813004

Cr-Commit-Position: refs/heads/master@{#25533}

9 years agoX87: harmony-scoping: make assignment to 'const' a late error.
Chunyang Dai [Thu, 27 Nov 2014 07:19:47 +0000 (15:19 +0800)]
X87: harmony-scoping: make assignment to 'const' a late error.

port 6ac4de87a8b01500b066a3e401e921d2d84b42db

original commit message:
  harmony-scoping: make assignment to 'const' a late error.

  Per TC39 Nov 2014 decision. This patch also changes behavior for "legacy const":
  assignments to sloppy const in strict mode is now also a type error. This fixes
  v8:2243 and also brings us in compliance with other engines re assignment to function
  names (see updated webkit test), but might have bigger implications. That change can
  easily be reverted by changing Variable::IsSignallingAssignmentToConst.

BUG=
R=dslomov@chromium.org, weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/763033002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

Cr-Commit-Position: refs/heads/master@{#25532}

9 years agoMove linked list for RPO order into BasicBlock itself.
mstarzinger [Wed, 26 Nov 2014 17:39:06 +0000 (09:39 -0800)]
Move linked list for RPO order into BasicBlock itself.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/762723004

Cr-Commit-Position: refs/heads/master@{#25531}

9 years agoMap::CopyGeneralizeAllRepresentations() left incorrect layout descriptor in a new...
ishell [Wed, 26 Nov 2014 17:36:57 +0000 (09:36 -0800)]
Map::CopyGeneralizeAllRepresentations() left incorrect layout descriptor in a new map.

BUG=chromium:436820
LOG=N

Review URL: https://codereview.chromium.org/759823004

Cr-Commit-Position: refs/heads/master@{#25530}

9 years agoFix raw TemplateLiteral spans with non-ascii characters
caitpotter88 [Wed, 26 Nov 2014 17:15:47 +0000 (09:15 -0800)]
Fix raw TemplateLiteral spans with non-ascii characters

BUG=v8:3710

Review URL: https://codereview.chromium.org/745233002

Cr-Commit-Position: refs/heads/master@{#25529}

9 years agoAbort optimization in corner case.
titzer [Wed, 26 Nov 2014 16:57:45 +0000 (08:57 -0800)]
Abort optimization in corner case.

The %OptimizeFunctionOnNextCall sledgehammer can cause a function to be
marked for optimization before it's ever been compiled by fullcode.
This can lead to the situation where a function doesn't have optimization
disabled until we try to compile it optimized.

Basically, the assert should just handle this case more gracefully.

R=yangguo@chromium.org
BUG=436893
LOG=Y

Review URL: https://codereview.chromium.org/760063002

Cr-Commit-Position: refs/heads/master@{#25528}

9 years agoDo not try to inline if the function has an illegal redeclaration.
jarin [Wed, 26 Nov 2014 16:32:37 +0000 (08:32 -0800)]
Do not try to inline if the function has an illegal redeclaration.

R=mvstanton@chromium.org
BUG=chromium:436896
LOG=n

Review URL: https://codereview.chromium.org/755333003

Cr-Commit-Position: refs/heads/master@{#25527}

9 years agoPush roll candidates based on candidate ref instead of lkgr.
machenbach [Wed, 26 Nov 2014 15:23:35 +0000 (07:23 -0800)]
Push roll candidates based on candidate ref instead of lkgr.

This pushes v8 to the candidates branch based on the
candidate ref, which is guaranteed to be the same for 8
hours.

The candidate ref is maintained by this bot:
http://build.chromium.org/p/client.v8/builders/Auto-roll%20-%20release%20process

NOTRY=true
BUG=chromium:431669
LOG=n

Review URL: https://codereview.chromium.org/760793003

Cr-Commit-Position: refs/heads/master@{#25526}

9 years agoReuse CFGBuilder in the scheduler to save memory.
mstarzinger [Wed, 26 Nov 2014 14:19:34 +0000 (06:19 -0800)]
Reuse CFGBuilder in the scheduler to save memory.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/755353003

Cr-Commit-Position: refs/heads/master@{#25525}

9 years agoMake GCTracer not reentrant.
hpayer [Wed, 26 Nov 2014 14:11:28 +0000 (06:11 -0800)]
Make GCTracer not reentrant.

BUG=

Review URL: https://codereview.chromium.org/754023003

Cr-Commit-Position: refs/heads/master@{#25524}

9 years agoSome micro-optimizations in the scheduler.
mstarzinger [Wed, 26 Nov 2014 13:13:34 +0000 (05:13 -0800)]
Some micro-optimizations in the scheduler.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/764533003

Cr-Commit-Position: refs/heads/master@{#25523}

9 years agoFix Windows 32.
Ben L. Titzer [Wed, 26 Nov 2014 13:06:32 +0000 (14:06 +0100)]
Fix Windows 32.

TBR=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/755323007

Cr-Commit-Position: refs/heads/master@{#25522}

9 years ago[turbofan] Implement jump threading after register allocation.
titzer [Wed, 26 Nov 2014 12:41:46 +0000 (04:41 -0800)]
[turbofan] Implement jump threading after register allocation.

R=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/754843002

Cr-Commit-Position: refs/heads/master@{#25521}

9 years agoStage ES6 block scoping.
dslomov [Wed, 26 Nov 2014 12:28:36 +0000 (04:28 -0800)]
Stage ES6 block scoping.

R=rossberg@chromium.org
BUG=v8:2198
LOG=Y

Review URL: https://codereview.chromium.org/751503004

Cr-Commit-Position: refs/heads/master@{#25520}

9 years agoIntroduce legacy const slots in correct context.
dslomov [Wed, 26 Nov 2014 12:16:19 +0000 (04:16 -0800)]
Introduce legacy const slots in correct context.

R=rossberg@chromium.org
BUG=chromium:410030
LOG=Y

Review URL: https://codereview.chromium.org/756293004

Cr-Commit-Position: refs/heads/master@{#25519}

9 years agoDon't use ConsStringIterator to compute string hashes
dcarney [Wed, 26 Nov 2014 11:53:27 +0000 (03:53 -0800)]
Don't use ConsStringIterator to compute string hashes

R=yangguo@chromium.org

BUG=

Review URL: https://codereview.chromium.org/762773002

Cr-Commit-Position: refs/heads/master@{#25518}

9 years ago[turbofan] Recognize rotate right.
rodolph.perfetta [Wed, 26 Nov 2014 11:49:35 +0000 (03:49 -0800)]
[turbofan] Recognize rotate right.

Extended the rotate left detection code.

BUG=

Review URL: https://codereview.chromium.org/760523004

Cr-Commit-Position: refs/heads/master@{#25517}

9 years agoharmony-scoping: make assignment to 'const' a late error.
dslomov [Wed, 26 Nov 2014 11:21:09 +0000 (03:21 -0800)]
harmony-scoping: make assignment to 'const' a late error.

Per TC39 Nov 2014 decision.

This patch also changes behavior for "legacy const": assignments to sloppy const in strict mode is now also a type error. This fixes v8:2243 and also brings us in compliance with other engines re assignment to function names (see updated webkit test), but might have bigger implications.
That change can easily be reverted by changing Variable::IsSignallingAssignmentToConst.

BUG=v8:3713,v8:2243
LOG=N

Review URL: https://codereview.chromium.org/749633002

Cr-Commit-Position: refs/heads/master@{#25516}

9 years ago[arm] Fix recognition of VNEG.
Benedikt Meurer [Wed, 26 Nov 2014 11:18:46 +0000 (12:18 +0100)]
[arm] Fix recognition of VNEG.

TEST=mjsunit,unittests
R=svenpanne@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/2aed882fe74dbf9210159babe30fedccd900e7cf

Review URL: https://codereview.chromium.org/762493006

Cr-Commit-Position: refs/heads/master@{#25515}

9 years agoRevert of [arm] Fix recognition of VNEG. (patchset #3 id:40001 of https://codereview...
machenbach [Wed, 26 Nov 2014 11:07:08 +0000 (03:07 -0800)]
Revert of [arm] Fix recognition of VNEG. (patchset #3 id:40001 of https://codereview.chromium.org/762493006/)

Reason for revert:
Breaks arm compilation.

Original issue's description:
> [arm] Fix recognition of VNEG.
>
> TEST=mjsunit,unittests
> R=svenpanne@chromium.org
>
> Committed: https://chromium.googlesource.com/v8/v8/+/2aed882fe74dbf9210159babe30fedccd900e7cf

TBR=svenpanne@chromium.org,bmeurer@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/751653004

Cr-Commit-Position: refs/heads/master@{#25514}

9 years ago[arm] Fix recognition of VNEG.
Benedikt Meurer [Wed, 26 Nov 2014 10:46:22 +0000 (11:46 +0100)]
[arm] Fix recognition of VNEG.

TEST=mjsunit,unittests
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/762493006

Cr-Commit-Position: refs/heads/master@{#25513}

9 years agoDouble timeout for slow tests.
machenbach [Wed, 26 Nov 2014 09:34:54 +0000 (01:34 -0800)]
Double timeout for slow tests.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/752733003

Cr-Commit-Position: refs/heads/master@{#25512}

9 years agoMark slow tests as slow.
machenbach [Wed, 26 Nov 2014 08:51:35 +0000 (00:51 -0800)]
Mark slow tests as slow.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/755283004

Cr-Commit-Position: refs/heads/master@{#25511}

9 years agoDisable ParserSync test for now, it takes waaaaay too long.
svenpanne [Wed, 26 Nov 2014 08:15:46 +0000 (00:15 -0800)]
Disable ParserSync test for now, it takes waaaaay too long.

Running this in x64.release mode on a powerful HP620 takes 4 seconds,
this is at least 2 orders of magnitude too slow and leads to tons of
false positives on our build bots due to timeouts. As it is, the
cost-benefit ratio is far too low.

The whole approach needs to be changed: Instead of trying to exhaust
some search space in unit tests, this should be turned into a fuzzing
test where only a small but random number of things are tested. The
exhaustive approach can be done separately, but definitely not in the
unit tests.

BUG=v8:3707

Review URL: https://codereview.chromium.org/762743002

Cr-Commit-Position: refs/heads/master@{#25510}

9 years ago[x64] Introduce FMA3 instructions on scalar data elements.
Weiliang Lin [Wed, 26 Nov 2014 05:31:41 +0000 (06:31 +0100)]
[x64] Introduce FMA3 instructions on scalar data elements.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/757503002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

Cr-Commit-Position: refs/heads/master@{#25509}

9 years ago[turbofan] Use special constant type for RPO block number operands.
titzer [Wed, 26 Nov 2014 05:16:31 +0000 (21:16 -0800)]
[turbofan] Use special constant type for RPO block number operands.

R=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/758073002

Cr-Commit-Position: refs/heads/master@{#25508}

9 years agoDocument that Isolate::GetCurrent() must not be called before initialization
jochen [Wed, 26 Nov 2014 05:15:17 +0000 (21:15 -0800)]
Document that Isolate::GetCurrent() must not be called before initialization

Also, add a check for debug mode.

BUG=none
R=dcarney@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/758043002

Cr-Commit-Position: refs/heads/master@{#25507}

9 years agoRevert "Distinguish beween final incremental mark-compact and full mark-compact event...
Benedikt Meurer [Wed, 26 Nov 2014 05:12:25 +0000 (06:12 +0100)]
Revert "Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotification."

This reverts commit d15d453fa5aaeeb1f7e010a1baf71e7b3306802b for
breaking cctest/test-api/Threading3.

TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/758163003

Cr-Commit-Position: refs/heads/master@{#25506}

9 years agoMove C++ flags for Android to cxxflags section
jochen [Tue, 25 Nov 2014 15:42:20 +0000 (07:42 -0800)]
Move C++ flags for Android to cxxflags section

BUG=v8:3693
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/752063002

Cr-Commit-Position: refs/heads/master@{#25505}

9 years agoForce inline Stirng::GetCharVector<>.
yangguo [Tue, 25 Nov 2014 15:29:50 +0000 (07:29 -0800)]
Force inline Stirng::GetCharVector<>.

R=mvstanton@chromium.org
BUG=chromium:436447

Review URL: https://codereview.chromium.org/756983003

Cr-Commit-Position: refs/heads/master@{#25504}

9 years agoharmony-scoping: Catch variable should be VAR, not LET
dslomov [Tue, 25 Nov 2014 14:48:27 +0000 (06:48 -0800)]
harmony-scoping: Catch variable should be VAR, not LET

R=rossberg@chromium.org
BUG=v8:2858
LOG=N

Review URL: https://codereview.chromium.org/748113003

Cr-Commit-Position: refs/heads/master@{#25503}

9 years agoFixed race condition in HBranch::observed_input_representation.
svenpanne [Tue, 25 Nov 2014 14:47:18 +0000 (06:47 -0800)]
Fixed race condition in HBranch::observed_input_representation.

Non-numeric static local variables are not thread-safe, and the case
at hand was a premature optimization anyway: The generated code for
the check in question is exactly the same when unfolded.

BUG=chromium:420483

Review URL: https://codereview.chromium.org/756903003

Cr-Commit-Position: refs/heads/master@{#25502}

9 years agoDistinguish beween final incremental mark-compact and full mark-compact event in...
hpayer [Tue, 25 Nov 2014 13:41:47 +0000 (05:41 -0800)]
Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotification.

BUG=

Review URL: https://codereview.chromium.org/727323004

Cr-Commit-Position: refs/heads/master@{#25501}

9 years agoPartially revert "Optimize function across closures."
yangguo [Tue, 25 Nov 2014 13:21:57 +0000 (05:21 -0800)]
Partially revert "Optimize function across closures."

BUG=chromium:434447

Review URL: https://codereview.chromium.org/755173002

Cr-Commit-Position: refs/heads/master@{#25500}

9 years agoRefactor use of Isolate::use_crankshaft.
yangguo [Tue, 25 Nov 2014 12:46:45 +0000 (04:46 -0800)]
Refactor use of Isolate::use_crankshaft.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/755883003

Cr-Commit-Position: refs/heads/master@{#25499}

9 years agoReset code age on the cloned code when serializing.
yangguo [Tue, 25 Nov 2014 12:03:27 +0000 (04:03 -0800)]
Reset code age on the cloned code when serializing.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/757983002

Cr-Commit-Position: refs/heads/master@{#25498}

9 years agoMIPS64: Load prototype from map in PropertyHandlerCompiler::CheckPrototypes.
balazs.kilvady [Tue, 25 Nov 2014 11:37:55 +0000 (03:37 -0800)]
MIPS64: Load prototype from map in PropertyHandlerCompiler::CheckPrototypes.

Port 100db75808486b9a85b5ba6384f27b3274438684

BUG=v8:3629
LOG=N

Review URL: https://codereview.chromium.org/755693002

Cr-Commit-Position: refs/heads/master@{#25497}

9 years ago[turbofan] Insert appropriate conversions for typed array stores.
jarin [Tue, 25 Nov 2014 08:40:18 +0000 (00:40 -0800)]
[turbofan] Insert appropriate conversions for typed array stores.

BUG=

Review URL: https://codereview.chromium.org/758643003

Cr-Commit-Position: refs/heads/master@{#25496}

9 years agoFix platform unittests.
Benedikt Meurer [Tue, 25 Nov 2014 07:21:43 +0000 (08:21 +0100)]
Fix platform unittests.

Follow-up to 87db4ff1f4d76eecb8f19d62f4c04279d56bf229, which added
suppressions to unittests.status and a special case for Android to the
ThreadLocalStorageTest, both of which are unneccessary and should be
handled differently for the GTest based unittests.

BUG=v8:3706
LOG=n
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/757913002

Cr-Commit-Position: refs/heads/master@{#25495}

9 years agoReduce context disposal gc overhead.
hpayer [Mon, 24 Nov 2014 19:19:04 +0000 (11:19 -0800)]
Reduce context disposal gc overhead.

BUG=

Review URL: https://codereview.chromium.org/750963002

Cr-Commit-Position: refs/heads/master@{#25494}

9 years agoDon't double smi-tag the mask used to check read-only / field mode in the dictionary...
verwaest [Mon, 24 Nov 2014 19:16:16 +0000 (11:16 -0800)]
Don't double smi-tag the mask used to check read-only / field mode in the dictionary-store-stub on X64

BUG=

Review URL: https://codereview.chromium.org/757673002

Cr-Commit-Position: refs/heads/master@{#25493}

9 years agoFix/suppress unittests broken on Android
cullinan [Mon, 24 Nov 2014 18:05:56 +0000 (10:05 -0800)]
Fix/suppress unittests broken on Android

cctest/test-threads/ThreadJoinSelf is suppressed for Android, but the
test has since been moved to unittests/Thread.SelfJoin. Move the
suppression to unittests.status.

unittests/ThreadLocalStorageTest.DoTest fails on older Android devices
as it assumes the availability of more TLS slots than many devices
implement. Test a smaller number of slots (32) on Android. Remove old
suppression of test-platform-tls/FastTLS (which no longer exists).

cctest/test-mark-compact/RegressJoinThreadsOnIsolateDeinit can't deal
with shared mappings. Check for 's' instead of '-'.

BUG=v8:3706
LOG=

Review URL: https://codereview.chromium.org/735863003

Cr-Commit-Position: refs/heads/master@{#25492}

9 years ago[turbofan] Fix matching of the lea instruction.
jarin [Mon, 24 Nov 2014 17:45:20 +0000 (09:45 -0800)]
[turbofan] Fix matching of the lea instruction.

Resets the scaled exponent to 0 when the scaling match fails.

BUG=

Review URL: https://codereview.chromium.org/756643002

Cr-Commit-Position: refs/heads/master@{#25491}

9 years agoLoad prototype from map in PropertyHandlerCompiler::CheckPrototypes.
ulan [Mon, 24 Nov 2014 17:44:12 +0000 (09:44 -0800)]
Load prototype from map in PropertyHandlerCompiler::CheckPrototypes.

BUG=v8:3629
LOG=N
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/753223002

Cr-Commit-Position: refs/heads/master@{#25490}

9 years agoDisable regress-3717 for gc-stress.
Yang Guo [Mon, 24 Nov 2014 16:29:05 +0000 (17:29 +0100)]
Disable regress-3717 for gc-stress.

TBR=ulan@chromium.org
BUG=v8:3723
LOG=N

Review URL: https://codereview.chromium.org/749283002

Cr-Commit-Position: refs/heads/master@{#25489}

9 years agoRemove lineprocessor sample.
yangguo [Mon, 24 Nov 2014 16:22:56 +0000 (08:22 -0800)]
Remove lineprocessor sample.

This sample used to demonstrate the usage of the DebuggerAgent. The latter
has been removed, so this sample has no point anymore.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/754043002

Cr-Commit-Position: refs/heads/master@{#25488}

9 years agoRemove v8::StartupData::compressed_size.
yangguo [Mon, 24 Nov 2014 16:14:26 +0000 (08:14 -0800)]
Remove v8::StartupData::compressed_size.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/739253006

Cr-Commit-Position: refs/heads/master@{#25487}

9 years agoCorrectly find shared function info for debugging when compiling eagerly.
yangguo [Mon, 24 Nov 2014 15:43:28 +0000 (07:43 -0800)]
Correctly find shared function info for debugging when compiling eagerly.

R=ulan@chromium.org
BUG=v8:3717
LOG=N

Review URL: https://codereview.chromium.org/758523004

Cr-Commit-Position: refs/heads/master@{#25486}

9 years agoMake use of post-scoping information to compute feedback vector requirements.
Michael Stanton [Mon, 24 Nov 2014 14:59:55 +0000 (15:59 +0100)]
Make use of post-scoping information to compute feedback vector requirements.

This avoids allocating vector ic slots that we don't use.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/758543002

Cr-Commit-Position: refs/heads/master@{#25485}

9 years agoDictionary-mode PropertyDetails printing fixed.
ishell [Mon, 24 Nov 2014 14:55:35 +0000 (06:55 -0800)]
Dictionary-mode PropertyDetails printing fixed.

BUG=chromium:435974
LOG=N

Review URL: https://codereview.chromium.org/755583003

Cr-Commit-Position: refs/heads/master@{#25484}

9 years agoReland of "Enable inobject double fields unboxing for 64-bit archs."
ishell [Mon, 24 Nov 2014 14:54:26 +0000 (06:54 -0800)]
Reland of "Enable inobject double fields unboxing for 64-bit archs."

Review URL: https://codereview.chromium.org/751643005

Cr-Commit-Position: refs/heads/master@{#25483}

9 years agoReland of "TransitionArray::Search() now returns insertion index if the entry was...
ishell [Mon, 24 Nov 2014 14:31:31 +0000 (06:31 -0800)]
Reland of "TransitionArray::Search() now returns insertion index if the entry was not found."

Review URL: https://codereview.chromium.org/739013004

Cr-Commit-Position: refs/heads/master@{#25482}

9 years agoEnsure external snapshot is only set once.
baixo [Mon, 24 Nov 2014 12:44:34 +0000 (04:44 -0800)]
Ensure external snapshot is only set once.

BUG=421063

Review URL: https://codereview.chromium.org/746263002

Cr-Commit-Position: refs/heads/master@{#25481}

9 years agoThe file snapshot_blob_host.bin was supposed to be generated when building the host...
baixo [Mon, 24 Nov 2014 12:43:28 +0000 (04:43 -0800)]
The file snapshot_blob_host.bin was supposed to be generated when building the host toolset. However, the file snapshot_blob.bin was being generated instead, under every set of conditions.

Because of this, every time we build the host toolset, snapshot_blob_host.bin is not found. This causes the target (v8_external_snapshot) that generates such file to be run. This target generates snapshot_blob.bin instead of snapshot_blob_host.bin. This in turn causes all the targets that depend on snapshot_blob.bin to run again.

After this, we still don't have snapshot_blob_host.bin. So the next time we build, the whole process described above happens again.

BUG=421063

Review URL: https://codereview.chromium.org/741223002

Cr-Commit-Position: refs/heads/master@{#25480}

9 years ago[turbofan] Combine Word32And with Int32Add and negative power of two.
Benedikt Meurer [Mon, 24 Nov 2014 12:30:20 +0000 (13:30 +0100)]
[turbofan] Combine Word32And with Int32Add and negative power of two.

TEST=unittests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/749233002

Cr-Commit-Position: refs/heads/master@{#25479}

9 years agoDon't verify evacuation when it is not completed.
hpayer [Mon, 24 Nov 2014 11:58:26 +0000 (03:58 -0800)]
Don't verify evacuation when it is not completed.

BUG=

Review URL: https://codereview.chromium.org/756553002

Cr-Commit-Position: refs/heads/master@{#25478}

9 years ago[turbofan] Dump graph in RPO order as text.
Ben L. Titzer [Mon, 24 Nov 2014 11:54:59 +0000 (12:54 +0100)]
[turbofan] Dump graph in RPO order as text.

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/754803002

Cr-Commit-Position: refs/heads/master@{#25477}

9 years agoFix RegExp.source for uncompiled regexp.
yangguo [Mon, 24 Nov 2014 11:21:45 +0000 (03:21 -0800)]
Fix RegExp.source for uncompiled regexp.

R=jkummerow@chromium.org
BUG=435825
LOG=N

Review URL: https://codereview.chromium.org/753983002

Cr-Commit-Position: refs/heads/master@{#25476}

9 years ago[turbofan] Recognize sign extension of 8-bit and 16-bit values on arm64.
baptiste.afsa [Mon, 24 Nov 2014 11:00:10 +0000 (03:00 -0800)]
[turbofan] Recognize sign extension of 8-bit and 16-bit values on arm64.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/730183005

Cr-Commit-Position: refs/heads/master@{#25475}

9 years agoAdded test cases for truncating stores.
svenpanne [Mon, 24 Nov 2014 10:42:15 +0000 (02:42 -0800)]
Added test cases for truncating stores.

Review URL: https://codereview.chromium.org/741643003

Cr-Commit-Position: refs/heads/master@{#25474}

9 years agodon't use to-be-deprecated Value::To* without isolate parameter
dcarney [Mon, 24 Nov 2014 10:30:39 +0000 (02:30 -0800)]
don't use to-be-deprecated Value::To* without isolate parameter

R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/725293003

Cr-Commit-Position: refs/heads/master@{#25473}

9 years agoFix alignment of Code::kConstantPoolOffset.
andrew_low [Mon, 24 Nov 2014 10:22:09 +0000 (02:22 -0800)]
Fix alignment of Code::kConstantPoolOffset.

This is needed for 64bit alignment sensitive platforms (PowerPC)
Exposed bugs with new GC compare and swap changes updating the
field.

Example failing test:
out/ppc64.debug/cctest  test-decls/ExistsInPrototype

BUG=

Review URL: https://codereview.chromium.org/740443002

Cr-Commit-Position: refs/heads/master@{#25472}

9 years agoremove some isolate::currents from api.cc
dcarney [Mon, 24 Nov 2014 09:44:47 +0000 (01:44 -0800)]
remove some isolate::currents from api.cc

R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/691513005

Cr-Commit-Position: refs/heads/master@{#25471}

9 years agoRevert of Enable inobject double fields unboxing for 64-bit archs. (patchset #3 id...
ishell [Sat, 22 Nov 2014 20:32:55 +0000 (12:32 -0800)]
Revert of Enable inobject double fields unboxing for 64-bit archs. (patchset #3 id:40001 of https://codereview.chromium.org/753503002/)

Reason for revert:
GCMole and gc-stress issues.

Original issue's description:
> Enable inobject double fields unboxing for 64-bit archs.

TBR=verwaest@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/751863002

Cr-Commit-Position: refs/heads/master@{#25470}

9 years agoEnable inobject double fields unboxing for 64-bit archs.
ishell [Sat, 22 Nov 2014 17:30:15 +0000 (09:30 -0800)]
Enable inobject double fields unboxing for 64-bit archs.

Review URL: https://codereview.chromium.org/753503002

Cr-Commit-Position: refs/heads/master@{#25469}

9 years agoharmony-scoping: Disallow cross-script assignment to const
dslomov [Fri, 21 Nov 2014 18:09:25 +0000 (10:09 -0800)]
harmony-scoping: Disallow cross-script assignment to const

R=rossberg@chromium.org
BUG=v8:2198
LOG=N

Review URL: https://codereview.chromium.org/745963002

Cr-Commit-Position: refs/heads/master@{#25468}

9 years agoRevert "Remove deprecated ShouldSelfOptimize machinery."
mstarzinger [Fri, 21 Nov 2014 17:28:18 +0000 (09:28 -0800)]
Revert "Remove deprecated ShouldSelfOptimize machinery."

This reverts commit 9da92c1a336e because of performance regressions.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/752613002

Cr-Commit-Position: refs/heads/master@{#25467}

9 years ago[turbofan]: remove optimization of adds/subs to inc and dec
danno [Fri, 21 Nov 2014 13:18:40 +0000 (05:18 -0800)]
[turbofan]: remove optimization of adds/subs to inc and dec

They generally cause regressions on most modern Intel chips. Replace them with
addl/subl.

Review URL: https://codereview.chromium.org/737153003

Cr-Commit-Position: refs/heads/master@{#25466}

9 years ago[turbofan] put late ssa deconstruction in register allocator behind a flag
dcarney [Fri, 21 Nov 2014 13:13:49 +0000 (05:13 -0800)]
[turbofan] put late ssa deconstruction in register allocator behind a flag

BUG=

Review URL: https://codereview.chromium.org/751543002

Cr-Commit-Position: refs/heads/master@{#25465}

9 years agoRip out bzip compression for native sources.
yangguo [Fri, 21 Nov 2014 12:45:10 +0000 (04:45 -0800)]
Rip out bzip compression for native sources.

R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/750543002

Cr-Commit-Position: refs/heads/master@{#25464}

9 years agoSlightly improve tests that rely on lazy compilation.
yangguo [Fri, 21 Nov 2014 12:40:53 +0000 (04:40 -0800)]
Slightly improve tests that rely on lazy compilation.

R=rossberg@chromium.org
BUG=v8:3712
LOG=N

Review URL: https://codereview.chromium.org/743843003

Cr-Commit-Position: refs/heads/master@{#25463}

9 years agoIntroduce a flag to change the new space growth factor
jochen [Fri, 21 Nov 2014 12:14:22 +0000 (04:14 -0800)]
Introduce a flag to change the new space growth factor

A useful value would be 4, so we get 1, 4, 16MB (instead of the default
value 2 which leads to 1, 2, 4, 8, 16)

BUG=none
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/753513002

Cr-Commit-Position: refs/heads/master@{#25462}

9 years ago[turbofan] put spill slot reuse behind a flag
dcarney [Fri, 21 Nov 2014 11:32:56 +0000 (03:32 -0800)]
[turbofan] put spill slot reuse behind a flag

BUG=

Review URL: https://codereview.chromium.org/748773002

Cr-Commit-Position: refs/heads/master@{#25461}

9 years agoARM64: skip flaky mozilla/ecma/Date/15.9.5.26-1 until it is fixed.
ulan [Fri, 21 Nov 2014 11:24:42 +0000 (03:24 -0800)]
ARM64: skip flaky mozilla/ecma/Date/15.9.5.26-1 until it is fixed.

BUG=v8:3716
LOG=N

Review URL: https://codereview.chromium.org/746983002

Cr-Commit-Position: refs/heads/master@{#25460}

9 years agoRemove deprecated ShouldSelfOptimize machinery.
mstarzinger [Fri, 21 Nov 2014 11:23:34 +0000 (03:23 -0800)]
Remove deprecated ShouldSelfOptimize machinery.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/582683002

Cr-Commit-Position: refs/heads/master@{#25459}

9 years agoFix mozilla expectations after regexp change.
Yang Guo [Fri, 21 Nov 2014 11:23:07 +0000 (12:23 +0100)]
Fix mozilla expectations after regexp change.

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/749963002

Cr-Commit-Position: refs/heads/master@{#25458}

9 years agoCorrectly escape RegExp source.
yangguo [Fri, 21 Nov 2014 10:50:12 +0000 (02:50 -0800)]
Correctly escape RegExp source.

R=ulan@chromium.org
BUG=v8:3229
LOG=N

Review URL: https://codereview.chromium.org/736003002

Cr-Commit-Position: refs/heads/master@{#25457}

9 years agoAssert to protect against polymorphic string loads fires on valid stores.
Michael Stanton [Fri, 21 Nov 2014 10:28:55 +0000 (11:28 +0100)]
Assert to protect against polymorphic string loads fires on valid stores.

BUG=435477
LOG=N
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/751513002

Cr-Commit-Position: refs/heads/master@{#25456}

9 years agoFix for 435073: CHECK failure in CHECK(p->IsSmi()) failed.
Michael Stanton [Fri, 21 Nov 2014 10:14:08 +0000 (11:14 +0100)]
Fix for 435073: CHECK failure in CHECK(p->IsSmi()) failed.

The bug was an error when copying arrays in crankshaft. If it's a holey smi
array, the copy must be done as FAST_HOLEY_ELEMENTS to prevent representation
changes from being inserted that deopt on encountering the hole.

Also, prevent inlining array pop() and shift() if the length is read-only.

BUG=435073
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/737383002

Cr-Commit-Position: refs/heads/master@{#25455}

9 years ago[turbofan] Avoid useless zero-extension on arm64.
Baptiste Afsa [Fri, 21 Nov 2014 10:00:40 +0000 (10:00 +0000)]
[turbofan] Avoid useless zero-extension on arm64.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/737733002

Cr-Commit-Position: refs/heads/master@{#25454}

9 years agodump compiler stats from d8 on direct exit from js
dcarney [Fri, 21 Nov 2014 09:53:04 +0000 (01:53 -0800)]
dump compiler stats from d8 on direct exit from js

BUG=

Review URL: https://codereview.chromium.org/753483002

Cr-Commit-Position: refs/heads/master@{#25453}

9 years agoFix the compilation issue for turbofan unsupported backend which
chunyang.dai [Fri, 21 Nov 2014 09:22:31 +0000 (01:22 -0800)]
Fix the compilation issue for turbofan unsupported backend which
is introduced by https://chromium.googlesource.com/v8/v8/+/aed26c05a50b2a1257ef8accc67143825f2e1f60.
( [turbofan] Clean up and factor out branch generation logic.)

BUG=

Review URL: https://codereview.chromium.org/748673002

Cr-Commit-Position: refs/heads/master@{#25452}

9 years agoMIPS: [turbofan] Clean up and factor out branch generation logic.
Akos Palfi [Fri, 21 Nov 2014 01:15:35 +0000 (02:15 +0100)]
MIPS: [turbofan] Clean up and factor out branch generation logic.

Port aed26c05a50b2a1257ef8accc67143825f2e1f60

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/742243003

Cr-Commit-Position: refs/heads/master@{#25451}

9 years agoCache template literal callSiteObj
caitpotter88 [Thu, 20 Nov 2014 22:37:31 +0000 (14:37 -0800)]
Cache template literal callSiteObj

BUG=v8:3230
LOG=y

Review URL: https://codereview.chromium.org/742643003

Cr-Commit-Position: refs/heads/master@{#25450}

9 years agoDo not put D8 and TEST natives into the external snapshot.
baixo [Thu, 20 Nov 2014 21:04:19 +0000 (13:04 -0800)]
Do not put D8 and TEST natives into the external snapshot.

D8 natives, in particular, will cause Windows static builds to not link due to another definition in the generated file d8-js.cc.

BUG=421063

Review URL: https://codereview.chromium.org/738153003

Cr-Commit-Position: refs/heads/master@{#25449}

9 years agoRename String.prototype.contains to 'includes'.
dslomov [Thu, 20 Nov 2014 19:19:34 +0000 (11:19 -0800)]
Rename String.prototype.contains to 'includes'.

Per TC39 Nov 2014 decison.

R=arv@chromium.org,yangguo@chromium.org
LOG=Y

Committed: https://chromium.googlesource.com/v8/v8/+/b5379216e23ff0ec734e70361dd07057c2421c96

Review URL: https://codereview.chromium.org/742963002

Cr-Commit-Position: refs/heads/master@{#25448}

9 years agoDo not bailout from optimizing functions that use f(x, arguments)
ulan [Thu, 20 Nov 2014 17:07:34 +0000 (09:07 -0800)]
Do not bailout from optimizing functions that use f(x, arguments)
if there is not enough type-feedback to detect that f is Function.prototype.apply.

BUG=v8:3709
LOG=N
TEST=mjsunit/regress/regress-3709

Review URL: https://codereview.chromium.org/736043002

Cr-Commit-Position: refs/heads/master@{#25447}

9 years ago[turbofan] Clean up and factor out branch generation logic.
titzer [Thu, 20 Nov 2014 16:23:11 +0000 (08:23 -0800)]
[turbofan] Clean up and factor out branch generation logic.

R=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/745633002

Cr-Commit-Position: refs/heads/master@{#25446}

9 years agoRemove superflous SharedFunctionInfo::uses_super call.
mstarzinger [Thu, 20 Nov 2014 16:21:56 +0000 (08:21 -0800)]
Remove superflous SharedFunctionInfo::uses_super call.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/736383002

Cr-Commit-Position: refs/heads/master@{#25445}

9 years agoWhen optimizing deserialized code, make sure IC state is preserved.
yangguo [Thu, 20 Nov 2014 16:20:48 +0000 (08:20 -0800)]
When optimizing deserialized code, make sure IC state is preserved.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/737373003

Cr-Commit-Position: refs/heads/master@{#25444}

9 years ago[turbofan] use double temp registers for stack-stack swap on arm64
Dan Carney [Thu, 20 Nov 2014 16:11:22 +0000 (17:11 +0100)]
[turbofan] use double temp registers for stack-stack swap on arm64

TBR=vogelheim@chromium.org

BUG=

Review URL: https://codereview.chromium.org/744743002

Cr-Commit-Position: refs/heads/master@{#25443}

9 years agoFix Regress3540 after r25441.
Ulan Degenbaev [Thu, 20 Nov 2014 15:42:32 +0000 (16:42 +0100)]
Fix Regress3540 after r25441.

BUG=
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/746443002

Cr-Commit-Position: refs/heads/master@{#25442}

9 years agoReserve code range block for evacuation.
ulan [Thu, 20 Nov 2014 14:52:23 +0000 (06:52 -0800)]
Reserve code range block for evacuation.

If we run out of code range, then GC wouldn't be able to compact code space,
because it wouldn't be able to allocate a new page. This can cause code space
fragmentation and OOM crashes.

BUG=chromium:430118
LOG=Y

Review URL: https://codereview.chromium.org/742733002

Cr-Commit-Position: refs/heads/master@{#25441}

9 years ago[turbofan] More aggressive reuse of spill slots in the register allocator.
dcarney [Thu, 20 Nov 2014 14:40:56 +0000 (06:40 -0800)]
[turbofan] More aggressive reuse of spill slots in the register allocator.

BUG=

Review URL: https://codereview.chromium.org/725083004

Cr-Commit-Position: refs/heads/master@{#25440}

9 years ago[turbofan]: More optimizations to add and subtract operations on x64
Daniel Clifford [Thu, 20 Nov 2014 13:48:34 +0000 (14:48 +0100)]
[turbofan]: More optimizations to add and subtract operations on x64

- Use "leal" for subtraction of integer constant when non-constant input to
  subtract is used more than once.
- Use "incl", "decl", and "addl" when they are smaller/cheaper than their
  leal/addl/subl equivalant.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/738073002

Cr-Commit-Position: refs/heads/master@{#25439}

9 years ago[turbofan] remove redundant '& 0x1F' for shifts.
Rodolph Perfetta [Thu, 20 Nov 2014 13:09:04 +0000 (13:09 +0000)]
[turbofan] remove redundant '& 0x1F' for shifts.

JavaScript shifts perform an implicit '& 0x1F' on their right operand, this
patch removes it when the underlying architecture already does it.

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/732103002

Cr-Commit-Position: refs/heads/master@{#25438}

9 years agoEnable TurboFan for Win64 targets.
mstarzinger [Thu, 20 Nov 2014 11:51:04 +0000 (03:51 -0800)]
Enable TurboFan for Win64 targets.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/743963002

Cr-Commit-Position: refs/heads/master@{#25437}

9 years agoFix lower bound violation
Andreas Rossberg [Thu, 20 Nov 2014 11:22:43 +0000 (12:22 +0100)]
Fix lower bound violation

R=jarin@chromium.org
BUG=433332
LOG=N

Review URL: https://codereview.chromium.org/739563002

Cr-Commit-Position: refs/heads/master@{#25436}

9 years agoDisable classes in sloppy mode unless --harmony-sloppy is set
Andreas Rossberg [Thu, 20 Nov 2014 10:51:49 +0000 (11:51 +0100)]
Disable classes in sloppy mode unless --harmony-sloppy is set

Also clean up flag names a little.

Baseline: https://codereview.chromium.org/713413003/

R=arv@chromium.org, dslomov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/722203006

Cr-Commit-Position: refs/heads/master@{#25435}