reed [Wed, 11 Jun 2014 14:17:11 +0000 (07:17 -0700)]
remove SK_SUPPORT_LEGACY_DEVICE_CONFIG code
BUG=skia:
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
327263002
mtklein [Wed, 11 Jun 2014 14:12:09 +0000 (07:12 -0700)]
Code reviews -> reviews@skia.org.
BUG=skia:
R=reed@google.com, skia-review@googlegroups.com, hcm@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
328613003
djordje.pesut [Wed, 11 Jun 2014 13:56:10 +0000 (06:56 -0700)]
MIPS: added optimization for functions from SkBlitRow.
gain is ~40%
following function are optimized:
S32_D565_Blend
S32A_D565_Opaque_Dither
S32_D565_Opaque_Dither
S32_D565_Blend_Dither
S32A_D565_Opaque
S32A_D565_Blend
S32_Blend_BlitRow32
R=djsollen@google.com, teodora.petrovic@gmail.com
Author: djordje.pesut@imgtec.com
Review URL: https://codereview.chromium.org/
326913004
egdaniel [Wed, 11 Jun 2014 13:51:51 +0000 (06:51 -0700)]
Move Dashing filterPath to a dashing utils file
From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
576dcdc793a762ec63fbecdbfd5768066b548fe5
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
314623004
sugoi [Wed, 11 Jun 2014 13:31:29 +0000 (06:31 -0700)]
Support for larger than "signed 32b limit" sized bitmaps in BGRAConvolve2D.
The multiplication of 2 signed ints was producing a result larger than what's supported by a single signed int and the memory was accessed out of bounds. Using uint64_t solves the issue.
BUG=378491
R=reed@google.com, rmistry@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
323013005
reed [Wed, 11 Jun 2014 13:09:50 +0000 (06:09 -0700)]
switch to colortype for deepcopy
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
323283002
rmistry [Wed, 11 Jun 2014 13:03:31 +0000 (06:03 -0700)]
Whitespace change to test trybot triggering
BUG=skia:
TBR=
NOTREECHECKS=true
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
325213002
borenet [Wed, 11 Jun 2014 08:52:00 +0000 (01:52 -0700)]
Update SKP version to 20
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
329043002
krajcevski [Wed, 11 Jun 2014 00:25:28 +0000 (17:25 -0700)]
Add an LATC compressor to the A8 masks, and hide it behind an ifdef.
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
326223002
kelvinly [Tue, 10 Jun 2014 22:32:44 +0000 (15:32 -0700)]
Fix what I just broke
BUG=skia:
NOTRY=true
TBR=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
328883003
kelvinly [Tue, 10 Jun 2014 22:24:39 +0000 (15:24 -0700)]
Fix broken rebaseline code
BUG=skia:
NOTRY=true
R=bensong@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
327943003
krajcevski [Tue, 10 Jun 2014 22:06:47 +0000 (15:06 -0700)]
Split caching from allocation in GrClipMaskManager
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
324963005
kelvinly [Tue, 10 Jun 2014 22:05:08 +0000 (15:05 -0700)]
Try 1 at rebaseline
BUG=skia:
R=bensong@google.com, bsalomon@google.com, robertphillips@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
324083007
reed [Tue, 10 Jun 2014 21:56:29 +0000 (14:56 -0700)]
fix when DEVICE_CONFIG is still defined
BUG=skia:
R=djsollen@google.com, bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
329553005
krajcevski [Tue, 10 Jun 2014 21:52:28 +0000 (14:52 -0700)]
Add texture compression utility
R=robertphillips@google.com, egdaniel@google.com, halcanary@google.com, scroggo@google.com, reed@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
325733004
dandov [Tue, 10 Jun 2014 21:38:28 +0000 (14:38 -0700)]
SkShader::asNewEffect Refactoring
The new signature is:
bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const;
It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader.
BUG=skia:2646
R=jvanverth@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
318923005
krajcevski [Tue, 10 Jun 2014 21:34:00 +0000 (14:34 -0700)]
Add Daniel and Pavel to committers list
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
316403003
mtklein [Tue, 10 Jun 2014 19:52:09 +0000 (12:52 -0700)]
Silence TSAN warnings about is_lcd_supported for now.
BUG=skia:1792
NOTRY=true
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
328663006
robertphillips [Tue, 10 Jun 2014 18:45:46 +0000 (11:45 -0700)]
Fix error revealed by Android unit test
The issue is/was that the original Picture/PictureRecorder that is being partially replayed is not guaranteed to issue any more commands before attempting to modify the existing data. Such modification is prohibited if there is a extant copy-on-write snapshot. Rather then further complicate the SkWriter32::snapshot capability for a dis-preferred use case, this CL simply copies the operation data.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
316063005
mtklein [Tue, 10 Jun 2014 18:13:47 +0000 (11:13 -0700)]
Clean up SkScaledImageCache at exit only in SK_DEVELOPER mode.
This is triggering ASAN failures in Chrome unit tests.
c.f. https://codereview.chromium.org/
308003014
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
326913007
robertphillips [Tue, 10 Jun 2014 16:23:06 +0000 (09:23 -0700)]
Remove unused 'deepCopy' parameter
This is split out of https://codereview.chromium.org/
316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324093003
fmalita [Tue, 10 Jun 2014 16:18:04 +0000 (09:18 -0700)]
Remove SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE
Blink has been rebased.
R=humper@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
323093002
krajcevski [Tue, 10 Jun 2014 16:17:48 +0000 (09:17 -0700)]
Do a better job of enforcing the semantics of the setRequireUnpremultipliedColors flag
R=scroggo@google.com, halcanary@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
322813005
robertphillips [Tue, 10 Jun 2014 14:20:48 +0000 (07:20 -0700)]
Remove legacy drawPicture entry point
With Skia
5713352a (Chromium should no longer need the legacy SkCanvas::drawPicture interface - https://codereview.chromium.org/
317193002/) this code should no longer be needed.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324703002
jvanverth [Tue, 10 Jun 2014 13:42:56 +0000 (06:42 -0700)]
Gamma correction for distance field text.
Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
4d517fdbb145cb95e5e935470df331e1b6667cfc
R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
258883002
borenet [Tue, 10 Jun 2014 09:04:02 +0000 (02:04 -0700)]
Update SKP version to 19
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
322943003
tfarina [Tue, 10 Jun 2014 06:59:03 +0000 (23:59 -0700)]
Cleanup: Get rid of make_isize() function from gm.h.
This helper function is not necessary.
The same thing can be achieved by using SkISize::Make() provided by
SkTSize API.
BUG=skia:2645
TEST=make dm && out/Debug/dm
R=robertphillips@google.com, reed@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
326523002
reed [Tue, 10 Jun 2014 03:40:05 +0000 (20:40 -0700)]
teach Nacl to not call setConfig
TBR=
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
327643003
reed [Tue, 10 Jun 2014 02:52:07 +0000 (19:52 -0700)]
hide SkBitmap::setConfig
patch from issue
325733002
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
322963002
bsalomon [Mon, 9 Jun 2014 22:11:30 +0000 (15:11 -0700)]
GM/bench for text draws with various parameters and clip rects.
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
319053002
humper [Mon, 9 Jun 2014 21:35:21 +0000 (14:35 -0700)]
second try at landing improved blur rect
BUG=skia:2095
R=bsalomon@google.com
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/
325703002
krajcevski [Mon, 9 Jun 2014 21:29:11 +0000 (14:29 -0700)]
Add sampler options to SkScaledBitmapSampler
R=scroggo@google.com, halcanary@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
321873003
mtklein [Mon, 9 Jun 2014 21:18:02 +0000 (14:18 -0700)]
Add assertHeld() to SkMutex.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
313823004
scroggo [Mon, 9 Jun 2014 20:06:34 +0000 (13:06 -0700)]
Revert of Gamma correction for distance field text. (https://codereview.chromium.org/
258883002/)
Reason for revert:
Memory leaks. I suspect this is due to the lack of destructors in SkAutoGlyphCache
Original issue's description:
> Gamma correction for distance field text.
>
> Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
4d517fdbb145cb95e5e935470df331e1b6667cfc
NOTRY=true
NOTREECHECKS=true
R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
323513005
tfarina [Mon, 9 Jun 2014 19:05:34 +0000 (12:05 -0700)]
Reland "Clean up Test's resourcePath code."
This relands commit
91359bed48bc006a4319da86eb26db3b2e6d4afb (Clean up
Test's resourcePath code."
BUG=None
TEST=make dm && out/Debug/dm
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
321723002
jvanverth [Mon, 9 Jun 2014 19:04:55 +0000 (12:04 -0700)]
Gamma correction for distance field text.
Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance.
BUG=skia:
R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
258883002
egdaniel [Mon, 9 Jun 2014 18:57:28 +0000 (11:57 -0700)]
Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
311373003
cdalton [Mon, 9 Jun 2014 18:16:58 +0000 (11:16 -0700)]
Generate path names on the client side
Pre-allocates a range of path names and manages allocations within
that range on the client side. This allows us to generate new path
objects in a feed-forward manner that doesn't require round trips to
the GL server.
BUG=skia:
R=bsalomon@google.com, markkilgard@gmail.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
304403003
krajcevski [Mon, 9 Jun 2014 17:54:03 +0000 (10:54 -0700)]
New etcbitmap baselines
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
325783003
krajcevski [Mon, 9 Jun 2014 16:10:04 +0000 (09:10 -0700)]
Make sure to copy the LATC alias when copying the GrGLCaps
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
320273003
krajcevski [Mon, 9 Jun 2014 15:32:34 +0000 (08:32 -0700)]
Add LATC to alpha only pixel config
R=robertphillips@google.com, bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
323853003
mtklein [Mon, 9 Jun 2014 15:04:15 +0000 (08:04 -0700)]
bench_record: No need for --flags if there are no RecordingFlags anymore.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
327533002
robertphillips [Mon, 9 Jun 2014 14:59:25 +0000 (07:59 -0700)]
Add some comments to GrRectanizer_skyline
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
324693002
bsalomon [Mon, 9 Jun 2014 14:59:06 +0000 (07:59 -0700)]
Add dump() to SkClipStack to help with debugging.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
311263015
robertphillips [Mon, 9 Jun 2014 14:05:04 +0000 (07:05 -0700)]
Fix Chrome build after
9f1c241e (https://codereview.chromium.org/
316143003/)
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag (https://codereview.chromium.org/
316143003/) removed an SkPicture flag on which Chromium still relies.
R=scroggo@google.com
TBR=scroggo@google.com
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
325723002
epoger [Mon, 9 Jun 2014 13:49:13 +0000 (06:49 -0700)]
remove GM result-grooming tools that use skia-autogen
BUG=skia:553
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
320443002
robertphillips [Mon, 9 Jun 2014 13:25:34 +0000 (06:25 -0700)]
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag
The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer?
R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
316143003
robertphillips [Sun, 8 Jun 2014 20:17:54 +0000 (13:17 -0700)]
Chromium should no longer need the legacy SkCanvas::drawPicture interface
With:
Switch Blink to using new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/
316863003/
Switch Chromium to new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/
315963003/
Chromium/Blink should no longer need this flag.
Note: this patch cannot be landed until the Blink change rolls into Chromium.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
317193002
robertphillips [Sun, 8 Jun 2014 20:12:44 +0000 (13:12 -0700)]
No longer limit SkPictureRecorder::partialReplay to Android
Toggling this for local testing is a bit of a chore.
R=mtklein@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
316173004
mtklein [Sun, 8 Jun 2014 14:02:47 +0000 (07:02 -0700)]
Revert of Clean up Test's resourcePath code. (https://codereview.chromium.org/
319473003/)
Reason for revert:
Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that. We can try again after a more careful cleanup of GetResourcePath().
Original issue's description:
> Clean up resourcePath code.
>
> 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test.
> 2) Make gResourcePath a static pointer to const char and move it inside the classes.
>
> BUG=None
> TEST=make tests && out/Debug/tests
> make gm && out/Debug/gm
> make bench && out/Debug/bench
> R=mtklein@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
52e4f413ffe2d281f9e90ff2147db08083ffcba7
R=tfarina@chromium.org
TBR=tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
320733002
robertphillips [Sun, 8 Jun 2014 12:55:05 +0000 (05:55 -0700)]
First pass at splitting out SkPictureRecord from SkPicture
This patch begins the process of splitting apart SkPicture, SkPicturePlayback and SkPictureRecord.
This is still a bit messy. In a follow up CL I hope to delay the creation of SkPictureRecorder's SkPicture until endRecording time.
R=reed@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
318763004
tfarina [Sun, 8 Jun 2014 03:50:44 +0000 (20:50 -0700)]
Clean up resourcePath code.
1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test.
2) Make gResourcePath a static pointer to const char and move it inside the classes.
BUG=None
TEST=make tests && out/Debug/tests
make gm && out/Debug/gm
make bench && out/Debug/bench
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
319473003
mtklein [Sun, 8 Jun 2014 03:27:44 +0000 (20:27 -0700)]
whitespace to trigger builds
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
5037fceeab7d29b99a6497bcdf1c97f03e532956
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
314313004
mtklein [Sun, 8 Jun 2014 00:19:04 +0000 (17:19 -0700)]
whitespace to trigger builds
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
314313004
Mike Klein [Sat, 7 Jun 2014 23:15:14 +0000 (19:15 -0400)]
Clean up Skia for Clang's -Wtautological-undefined-compare
This is blocking Chrome from rolling a new Clang, and me too for our TSAN bots.
BUG=chromium:381910
Review URL: https://codereview.chromium.org/
325603002
mtklein [Fri, 6 Jun 2014 22:11:04 +0000 (15:11 -0700)]
use __atomics in SkBarriers_tsan.h
I am having a hard time getting TSAN's own atomic hooks to work on our bots,
but __atomic_foo work fine and are understood just fine by TSAN.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
320063003
djordje.pesut [Fri, 6 Jun 2014 21:09:12 +0000 (14:09 -0700)]
MIPS: modified gypi files to support build
R=teodora.petrovic@gmail.com, djsollen@google.com
Author: djordje.pesut@imgtec.com
Review URL: https://codereview.chromium.org/
304903003
jvanverth [Fri, 6 Jun 2014 20:40:35 +0000 (13:40 -0700)]
Rollback of
fe689c46 and all subsequent changes
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
324463005
humper [Fri, 6 Jun 2014 20:28:04 +0000 (13:28 -0700)]
remove extra debug prints
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
314423002
humper [Fri, 6 Jun 2014 19:55:23 +0000 (12:55 -0700)]
fix 10.6 shader tests
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
324543002
humper [Fri, 6 Jun 2014 19:21:03 +0000 (12:21 -0700)]
repair math error introduced by windows build fix
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
320593003
jvanverth [Fri, 6 Jun 2014 18:59:25 +0000 (11:59 -0700)]
Disable bigblurs GM (for
fe689c46a76)
BUG=skia:
R=humper@google.com
TBR=humper@google.com
NOTRY=True
NOTREECHECKS=True
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
325453002
humper [Fri, 6 Jun 2014 18:55:24 +0000 (11:55 -0700)]
one channel texture fix for blur shader
BUG=skia:
R=bsalomon@google.com
TBR=bsalomon
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
319543007
humper [Fri, 6 Jun 2014 18:37:24 +0000 (11:37 -0700)]
disable GPU/CPU blur match test (possibly temporary)
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
322593002
humper [Fri, 6 Jun 2014 18:22:49 +0000 (11:22 -0700)]
fix blur test
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
323583002
humper [Fri, 6 Jun 2014 18:18:17 +0000 (11:18 -0700)]
Revert of Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/
319943004/)
Reason for revert:
Hopefully working now
Original issue's description:
> Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/
319203002/)
>
> Reason for revert:
> Follow-on to
fe689c46a76, which needs to be reverted due to bot failures.
>
> Original issue's description:
> > another GM to ignore for blur rebaseline
> >
> > BUG=skia:
> > TBR=jvanverth
> > NOTRY=True
> > NOTREECHECKS=True
> >
> > Committed: https://skia.googlesource.com/skia/+/
f131055929afb9c9671aee3e575c380d48c5ee4d
>
> TBR=humper@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
f255de0fe160e33b340301859be1d9374c5607fe
R=jvanverth@google.com
TBR=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: humper@google.com
Review URL: https://codereview.chromium.org/
324453004
jvanverth [Fri, 6 Jun 2014 17:59:13 +0000 (10:59 -0700)]
Revert of another GM to ignore for blur rebaseline (https://codereview.chromium.org/
319203002/)
Reason for revert:
Follow-on to
fe689c46a76, which needs to be reverted due to bot failures.
Original issue's description:
> another GM to ignore for blur rebaseline
>
> BUG=skia:
> TBR=jvanverth
> NOTRY=True
> NOTREECHECKS=True
>
> Committed: https://skia.googlesource.com/skia/+/
f131055929afb9c9671aee3e575c380d48c5ee4d
R=humper@google.com
TBR=humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
319943004
humper [Fri, 6 Jun 2014 17:36:01 +0000 (10:36 -0700)]
another GM to ignore for blur rebaseline
BUG=skia:
TBR=jvanverth
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
319203002
humper [Fri, 6 Jun 2014 16:48:40 +0000 (09:48 -0700)]
Faster GPU rect blur that doesn't require computing vertical and horizontal
scanlines on the CPU first. Should make extremely large drop shadows fast
again.
BUG=skia:
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
316273004
mtklein [Fri, 6 Jun 2014 16:28:43 +0000 (09:28 -0700)]
DM: SKP source / PDF backend
Removed expectations code for PDF backend for now, given that we don't have any, and refactored a little to make that cleaner.
We can now test .skp -> .pdf -> .png in DM. Neat eh?
BUG=skia:2598
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
316643003
reed [Fri, 6 Jun 2014 16:02:22 +0000 (09:02 -0700)]
remove SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS from chrome
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
320583003
kevin.petit [Fri, 6 Jun 2014 15:45:36 +0000 (08:45 -0700)]
ARM Skia NEON patches - 39 - arm64 565 blitters
This enables all 565 blitters except S32A_D565_Opaque.
Here are some performance results:
S32_D565_Opaque:
================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -18.37% | -13.04% |
+-------+------------+------------+
| 2 | -9.90% | -13.78% |
+-------+------------+------------+
| 4 | -8.28% | -6.77% |
+-------+------------+------------+
| 8 | 157.63% | 78.15% |
+-------+------------+------------+
| 16 | 72.67% | 44.81% |
+-------+------------+------------+
| 64 | 76.78% | 40.89% |
+-------+------------+------------+
| 256 | 73.85% | 36.05% |
+-------+------------+------------+
| 1024 | 75.73% | 36.70% |
+-------+------------+------------+
S32_D565_Blend:
===============
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -9.99% | -13.79% |
+-------+------------+------------+
| 2 | -9.17% | -6.74% |
+-------+------------+------------+
| 4 | -6.73% | -4.42% |
+-------+------------+------------+
| 8 | 163.31% | 112.82% |
+-------+------------+------------+
| 16 | 55.21% | 44.68% |
+-------+------------+------------+
| 64 | 54.09% | 41.99% |
+-------+------------+------------+
| 256 | 52.63% | 40.64% |
+-------+------------+------------+
| 1024 | 52.46% | 40.45% |
+-------+------------+------------+
S32A_D565_Blend:
================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -5.88% | -6.06% |
+-------+------------+------------+
| 2 | -4.74% | -0.01% |
+-------+------------+------------+
| 4 | -5.42% | -3.03% |
+-------+------------+------------+
| 8 | 78.78% | 77.96% |
+-------+------------+------------+
| 16 | 98.19% | 79.61% |
+-------+------------+------------+
| 64 | 111.56% | 72.60% |
+-------+------------+------------+
| 256 | 113.80% | 69.96% |
+-------+------------+------------+
| 1024 | 114.42% | 70.85% |
+-------+------------+------------+
S32_D565_Opaque_Dither:
=======================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -4.18% | -0.93% |
+-------+------------+------------+
| 2 | -2.43% | -2.04% |
+-------+------------+------------+
| 4 | -1.09% | -1.23% |
+-------+------------+------------+
| 8 | 184.89% | 136.53% |
+-------+------------+------------+
| 16 | 128.64% | 89.11% |
+-------+------------+------------+
| 64 | 132.68% | 100.98% |
+-------+------------+------------+
| 256 | 157.02% | 100.86% |
+-------+------------+------------+
| 1024 | 163.85% | 103.62% |
+-------+------------+------------+
S32_D565_Blend_Dither:
======================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -4.87% | 0.01% |
+-------+------------+------------+
| 2 | -2.71% | 2.97% |
+-------+------------+------------+
| 4 | -2.20% | 0.28% |
+-------+------------+------------+
| 8 | 149.76% | 146.80% |
+-------+------------+------------+
| 16 | 85.69% | 95.77% |
+-------+------------+------------+
| 64 | 88.81% | 101.39% |
+-------+------------+------------+
| 256 | 97.32% | 107.22% |
+-------+------------+------------+
| 1024 | 98.08% | 115.71% |
+-------+------------+------------+
S32A_D565_Opaque_Dither:
========================
+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
| 1 | -1.86% | 0.02% |
+-------+------------+------------+
| 2 | -0.58% | -1.52% |
+-------+------------+------------+
| 4 | -0.75% | 1.16% |
+-------+------------+------------+
| 8 | 240.74% | 155.16% |
+-------+------------+------------+
| 16 | 181.97% | 132.15% |
+-------+------------+------------+
| 64 | 203.11% | 136.48% |
+-------+------------+------------+
| 256 | 223.45% | 133.05% |
+-------+------------+------------+
| 1024 | 225.96% | 134.05% |
+-------+------------+------------+
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
317193003
mtklein [Fri, 6 Jun 2014 15:27:07 +0000 (08:27 -0700)]
Effectively unlimited linking.
Ninja will still cap concurrency with it's default value (from -j), so we just
need a big number equal or greater than the number of cores in any machine.
BUG=skia:
R=borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
319153002
egdaniel [Fri, 6 Jun 2014 14:47:17 +0000 (07:47 -0700)]
Revert of Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. (https://codereview.chromium.org/
311373003/)
Reason for revert:
changed assert is failing
Original issue's description:
> Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
be4fd4f7349b97a7c34a4177ec26d8aea9616628
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
320573002
mtklein [Fri, 6 Jun 2014 14:37:46 +0000 (07:37 -0700)]
Pull in GYP_LINK_CONCURRENCY=N support.
BUG=skia:
R=borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
315183003
egdaniel [Fri, 6 Jun 2014 14:26:16 +0000 (07:26 -0700)]
Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
311373003
sugoi [Fri, 6 Jun 2014 13:44:16 +0000 (06:44 -0700)]
Fixing another clusterfuzz issue
This was introduced by removing SkValidatingReadBuffer::readBitmap in https://codereview.chromium.org/
295793002/
Since SkReadBuffer::skip wasn't virtual, it was using the unsafe SkReadBuffer::skip within SkReadBuffer::readBitmap rather than using SkValidatingReadBuffer::skip. I also removed direct uses of fReader within SkReadBuffer::readBitmap so that it can use the virtual readInt / readFixed functions that have a version in SkValidatingReadBuffer.
Also, I changed SkReadBuffer::readPoint so that it uses the virtual readScalar, that way, it becomes redundant with SkValidatingReadBuffer::readPoint, which can then be removed.
BUG=380723
R=reed@google.com, mtklein@google.com, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
317003003
qiankun.miao [Fri, 6 Jun 2014 13:43:46 +0000 (06:43 -0700)]
Fix android_run_skia script running with command line options
This script cannot recognize command line options when running bench:
e.g. android_run_skia bench --config 8888.
BUG=skia:
R=mtklein@google.com, djsollen@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
314903003
tfarina [Fri, 6 Jun 2014 13:35:28 +0000 (06:35 -0700)]
Remove GrIsPow2 in favor of SkIsPow2.
Looks like there is no good reason to have two copies of this function
doing the same thing with different name.
BUG=None
TEST=make tests
R=bsalomon@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
318873002
jcgregorio [Fri, 6 Jun 2014 13:30:31 +0000 (06:30 -0700)]
Add metrics reporting to SkFiddle.
Also update the headers for template.cpp while we're here.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
312373002
rmistry [Fri, 6 Jun 2014 13:26:59 +0000 (06:26 -0700)]
Whitespace change to test new CQ trybots
BUG=skia:2203
TBR=
(SkipBuildbotRuns)
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
319123002
sugoi [Fri, 6 Jun 2014 13:22:03 +0000 (06:22 -0700)]
Adding kernel offset validation
Fixing bug found by clusterfuzz in SkMatrixConvolutionImageFilter.
BUG=381244
R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
319003002
mtklein [Fri, 6 Jun 2014 13:21:46 +0000 (06:21 -0700)]
Add SkBarriers_tsan.h.
Slight counterproposal to crrev.com/
310663002.
BUG=skia:
No API changes.
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
306373002
bsalomon [Fri, 6 Jun 2014 13:16:34 +0000 (06:16 -0700)]
Use vertex attribute for text color in GrBitmapTextContext
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
316063002
krajcevski [Fri, 6 Jun 2014 13:16:28 +0000 (06:16 -0700)]
Initial KTX encoder
The encoder comes with tests to check that the encoding/decoding
operations between ETC encoded bitmaps and ARGB bitmaps are sane.
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
312353003
Ben Wagner [Thu, 5 Jun 2014 22:03:39 +0000 (18:03 -0400)]
Fix SK_API for DirectWrite port.
The declaration and definition should have the same calling convention.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
317993002
Ben Wagner [Thu, 5 Jun 2014 20:55:58 +0000 (16:55 -0400)]
Rename SkFontHost_win_dw.cpp SkScalerContext.
This is a continuation of https://codereview.chromium.org/
314193002/ .
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
315173004
bungeman [Thu, 5 Jun 2014 20:38:45 +0000 (13:38 -0700)]
Split SkFontHost_win_dw.
Split SkFontHost_win_dw into FontMgr, Typeface, and ScalerContext.
This makes working on these files easier, and moves away from the legacy
FontHost naming.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
314193002
fmalita [Thu, 5 Jun 2014 19:40:07 +0000 (12:40 -0700)]
SkClipStack::Element tweaks.
(
This is intended to facilitate efficient kMatrix_SaveFlags emulation
on restore():
* collect all clip stack elements for the current save count into a
side clip stack
* canvas.restore(everything)
* replay the collected clip ops to restore the initial clip state
=> we restored the matrix but the clip state is unchanged
)
Two main changes:
* expose the save count for SkClipStack::Element
* expose a replay method for the same (logic relocated from
SkCanvas::replayClips)
The SkCanvas::ClipVisitor shuffling is to enable forward decl
in SkClipStack.h (cannot fwdecl a nested class).
R=reed@google.com, robertphillips@google.com
TBR=reed@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
269693003
bungeman [Thu, 5 Jun 2014 19:14:44 +0000 (12:14 -0700)]
Update gyp for msvs-ninja clean.
BUG=skia:2439
R=borenet@google.com, epoger@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
317833005
scroggo [Thu, 5 Jun 2014 18:18:04 +0000 (11:18 -0700)]
Fixes for SkAlphaTypes.
When using allocPixels to set the info and create a new pixelRef in one
shot, create the pixelRef with the corrected info of the bitmap (i.e.
alphatype).
Simplify the check to determine whether to copy the genID in SkBitmap::
copyTo's same configs/same sizes case. The old logic (only checking the
height and assuming the others must be the same) relied on a deep
(mis?)understanding of the rest of the function, and I cannot convince
myself that it has to be true, given that readPixels may have switched
src to a different SkBitmap. Instead, just compare the SkImageInfos,
which is much clearer. (This also caught a bug where a 565 bitmap had
the wrong alphatype, leading to the allocPixels fixes.)
If readPixels succeeds but the source is unpremultiplied, fail out
of copyTo, since readPixels assumes premultiplied.
When copying from 8888 to 4444 or in the fallback case of drawing,
return false if the alphatype is unpremul, which would have failed
anyway.
BUG=skia:2012
R=reed@google.com, bsalomon@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
317053003
epoger [Thu, 5 Jun 2014 17:30:37 +0000 (10:30 -0700)]
reland "rebaseline_server: download actual-results.json files from GCS instead of SVN"
relands https://codereview.chromium.org/
310093003 with modifications.
BUG=skia:2641
R=jcgregorio@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
313343003
scroggo [Thu, 5 Jun 2014 17:28:36 +0000 (10:28 -0700)]
Add mips64 to the makefile.
Currently we have no optimizations for mips64, so it correctly
contains the various _none.cpps.
Corresponds to https://android-review.googlesource.com/#/c/96536/1
R=halcanary@google.com, djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
311163003
reed [Thu, 5 Jun 2014 17:00:04 +0000 (10:00 -0700)]
add SK_SUPPORT_LEGACY_COMPUTE_CONFIG_SIZE
TBR=scroggo
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
315263002
mtklein [Thu, 5 Jun 2014 15:51:26 +0000 (08:51 -0700)]
Rename skimage expectations for ASAN bot to match bot renaming.
BUG=skia:
R=borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
316063004
reed [Thu, 5 Jun 2014 15:51:20 +0000 (08:51 -0700)]
remove SkBitmap::allocConfigPixels and update dox
I see no callers in android
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
310283004
jvanverth [Thu, 5 Jun 2014 15:19:23 +0000 (08:19 -0700)]
Revert of Add SSE4 optimization of S32A_Opaque_Blitrow (https://codereview.chromium.org/
289473009/)
Reason for revert:
Buildbot failures on Mac 10.6 and Mac 10.7.
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com
TBR=reed@google.com
NOTRY=True
Original issue's description:
> Add SSE4 optimization of S32A_Opaque_Blitrow
>
> Adds optimization of Skia S32A_Opaque_Blitrow blitter using SSE4.2 SIMD
> instruction set. Special case for when alpha is zero or opaque.
>
> Performance increase of 10%-400% compared to the existing SSE2
> optimization (measured on Silvermont architecture).
> Noticeable in ~25 different skia bench subtests, especially in
> bitmap_8888_*, repeatTile_*, and morph_*.
>
> bitmap_8888_A - 100% faster
> bitmap_8888_A_source_transparent - 250% faster
> bitmap_8888_A_source_opaque - 25% faster
> bitmap_8888_A_scale_bicubic - 75% faster
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: https://skia.googlesource.com/skia/+/
e2527b147679b0c43019fae7d59cc3777d2d097e
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
311053009
halcanary [Thu, 5 Jun 2014 15:16:34 +0000 (08:16 -0700)]
remove ashmem from skia
R=scroggo@google.com, djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
319533004
bsalomon [Thu, 5 Jun 2014 14:56:55 +0000 (07:56 -0700)]
Rebaselines for drrect GM on GPU
TBR=
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
318773007
henrik.smiding [Thu, 5 Jun 2014 14:50:54 +0000 (07:50 -0700)]
Add SSE4 optimization of S32A_Opaque_Blitrow
Adds optimization of Skia S32A_Opaque_Blitrow blitter using SSE4.2 SIMD
instruction set. Special case for when alpha is zero or opaque.
Performance increase of 10%-400% compared to the existing SSE2
optimization (measured on Silvermont architecture).
Noticeable in ~25 different skia bench subtests, especially in
bitmap_8888_*, repeatTile_*, and morph_*.
bitmap_8888_A - 100% faster
bitmap_8888_A_source_transparent - 250% faster
bitmap_8888_A_source_opaque - 25% faster
bitmap_8888_A_scale_bicubic - 75% faster
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
289473009
projects / platform / upstream / libSkiaSharp.git / log