platform/upstream/libSkiaSharp.git
11 years agoremove experimental setAsABlur, as it forces the instance to be mutable, and was
reed@google.com [Tue, 18 Dec 2012 18:20:44 +0000 (18:20 +0000)]
remove experimental setAsABlur, as it forces the instance to be mutable, and was
not adopted by chrome
Review URL: https://codereview.appspot.com/6939071

git-svn-id: http://skia.googlecode.com/svn/trunk@6879 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange all interfaces for SkRasterizer to const, in preparation for marking it
reed@google.com [Tue, 18 Dec 2012 16:57:03 +0000 (16:57 +0000)]
change all interfaces for SkRasterizer to const, in preparation for marking it
as immutable/re-entrant safe.
Review URL: https://codereview.appspot.com/6936064

git-svn-id: http://skia.googlecode.com/svn/trunk@6878 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange all patheffect methods to const, in preparation for marking its
reed@google.com [Tue, 18 Dec 2012 16:12:09 +0000 (16:12 +0000)]
change all patheffect methods to const, in preparation for marking its
subclasses as immutable/re-entrant safe.
Review URL: https://codereview.appspot.com/6949071

git-svn-id: http://skia.googlecode.com/svn/trunk@6877 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix drawSprite to record correctly with SkBBoxRecord
junov@chromium.org [Tue, 18 Dec 2012 14:44:09 +0000 (14:44 +0000)]
Fix drawSprite to record correctly with SkBBoxRecord

BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm lighting with -tileGrid
Review URL: https://codereview.appspot.com/6947075

git-svn-id: http://skia.googlecode.com/svn/trunk@6876 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compile error on Windows -- remove unsupported branch hint.
jvanverth@google.com [Tue, 18 Dec 2012 14:41:18 +0000 (14:41 +0000)]
Fix compile error on Windows -- remove unsupported branch hint.

git-svn-id: http://skia.googlecode.com/svn/trunk@6875 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd AndroidPathRenderer to experimental gyp and get it compiling with Skia code.
jvanverth@google.com [Tue, 18 Dec 2012 14:13:46 +0000 (14:13 +0000)]
Add AndroidPathRenderer to experimental gyp and get it compiling with Skia code.

https://codereview.appspot.com/6938074/

git-svn-id: http://skia.googlecode.com/svn/trunk@6874 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 18 Dec 2012 02:03:03 +0000 (02:03 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6872 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SkBBoxRecord to correctly handle SkRect arguments that are inverted rects.
junov@chromium.org [Mon, 17 Dec 2012 22:32:06 +0000 (22:32 +0000)]
Fix SkBBoxRecord to correctly handle SkRect arguments that are inverted rects.

BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm strokerect with --tileGrid
Review URL: https://codereview.appspot.com/6945071

git-svn-id: http://skia.googlecode.com/svn/trunk@6870 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compiler warning-as-error issue
robertphillips@google.com [Mon, 17 Dec 2012 21:58:02 +0000 (21:58 +0000)]
Fix compiler warning-as-error issue

git-svn-id: http://skia.googlecode.com/svn/trunk@6867 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd RRect GM
robertphillips@google.com [Mon, 17 Dec 2012 21:48:19 +0000 (21:48 +0000)]
Add RRect GM

https://codereview.appspot.com/6945063/

git-svn-id: http://skia.googlecode.com/svn/trunk@6866 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing bounding box computation for inverse filled paths in SkBBoxRecord
junov@chromium.org [Mon, 17 Dec 2012 21:30:51 +0000 (21:30 +0000)]
Fixing bounding box computation for inverse filled paths in SkBBoxRecord

BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm emptypath with --tileGrid
Review URL: https://codereview.appspot.com/6944062

git-svn-id: http://skia.googlecode.com/svn/trunk@6865 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agowe do not correctly handle inner-style in blurmaskfilter w/ the 9patch
reed@google.com [Mon, 17 Dec 2012 21:20:53 +0000 (21:20 +0000)]
we do not correctly handle inner-style in blurmaskfilter w/ the 9patch
trick, so don't use it (until we fix it).

extend blurrect gm to test all 4 blurstyles
Review URL: https://codereview.appspot.com/6940075

git-svn-id: http://skia.googlecode.com/svn/trunk@6864 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFollow up on the previous patch :
sugoi@google.com [Mon, 17 Dec 2012 21:16:45 +0000 (21:16 +0000)]
Follow up on the previous patch :
- Moved the SkStrokeRec class in its own file
- Replaced SkStroke by SkStrokeRec in Ganesh
- Moved path stroking to the Ganesh level in some cases (everytime it isn't required to do it directly in SkGpuDevice). PathEffect and MaskFilter still require path stroking at the SkGpuDevice for now.
- Renamed static functions in SkPath with proper names

* No functionality shold have changed with this patch. This is a step towards enabling Ganesh Path Renderers to decide whether or not to stroke the path rather than always receiving the stroked path as an input argument.

BUG=chromium:135111
TEST=Try path rendering tests from the gm
Review URL: https://codereview.appspot.com/6946072

git-svn-id: http://skia.googlecode.com/svn/trunk@6861 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unused type GrCacheKey
bsalomon@google.com [Mon, 17 Dec 2012 20:44:22 +0000 (20:44 +0000)]
Remove unused type GrCacheKey

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6947074

git-svn-id: http://skia.googlecode.com/svn/trunk@6858 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake all colorfilter methods const, in preparation for declaring them
reed@google.com [Mon, 17 Dec 2012 20:21:44 +0000 (20:21 +0000)]
Make all colorfilter methods const, in preparation for declaring them
to be immutable and reentrant-safe

git-svn-id: http://skia.googlecode.com/svn/trunk@6856 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark all methods on SkXfermode as const, in preparation for declaring all
reed@google.com [Mon, 17 Dec 2012 19:55:24 +0000 (19:55 +0000)]
Mark all methods on SkXfermode as const, in preparation for declaring all
xfermodes as immutable/reentrant-safe
Review URL: https://codereview.appspot.com/6941065

git-svn-id: http://skia.googlecode.com/svn/trunk@6855 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow setting a scaleFactor in bench_pictures (and render_pictures).
scroggo@google.com [Mon, 17 Dec 2012 19:25:54 +0000 (19:25 +0000)]
Allow setting a scaleFactor in bench_pictures (and render_pictures).

In TiledPictureRenderer and CopyTilesRenderer, do a postTranslate so
the translate is not affected by the scale factor.

Likewise, use clipRegion for tiled renderer so it will be
unaffected by the scale factor.

Respect the viewport for record, playbackCreation, and pipe renderers.

Review URL: https://codereview.appspot.com/6947072

git-svn-id: http://skia.googlecode.com/svn/trunk@6853 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago3on/3off dashing optimization
robertphillips@google.com [Mon, 17 Dec 2012 18:56:29 +0000 (18:56 +0000)]
3on/3off dashing optimization

https://codereview.appspot.com/6891046/

git-svn-id: http://skia.googlecode.com/svn/trunk@6851 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRoll out r6843 to hopefully fix Windows builds
epoger@google.com [Mon, 17 Dec 2012 18:23:58 +0000 (18:23 +0000)]
Roll out r6843 to hopefully fix Windows builds
BUG=https://code.google.com/p/skia/issues/detail?id=1023
TBR=borenet
Review URL: https://codereview.appspot.com/6942061

git-svn-id: http://skia.googlecode.com/svn/trunk@6849 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAddress comments for r6822: https://codereview.appspot.com/6946052/
borenet@google.com [Mon, 17 Dec 2012 17:21:04 +0000 (17:21 +0000)]
Address comments for r6822: https://codereview.appspot.com/6946052/
Review URL: https://codereview.appspot.com/6943059

git-svn-id: http://skia.googlecode.com/svn/trunk@6847 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding missing oval and roundedRect primitives to SkBBoxRecord
junov@chromium.org [Mon, 17 Dec 2012 16:29:34 +0000 (16:29 +0000)]
Adding missing oval and roundedRect primitives to SkBBoxRecord

BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm with --tileGrid
Review URL: https://codereview.appspot.com/6937066

git-svn-id: http://skia.googlecode.com/svn/trunk@6846 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLimit the maximum number of dash segments per path
fmalita@google.com [Mon, 17 Dec 2012 16:27:34 +0000 (16:27 +0000)]
Limit the maximum number of dash segments per path

https://crbug.com/165432

In order to avoid trivial out-of-memory exploits, cap path dashing at 1000000 segments per path.

R=reed@google.com

BUG=

Review URL: https://codereview.appspot.com/6948063

git-svn-id: http://skia.googlecode.com/svn/trunk@6845 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd --writeJsonSummary option to gm
epoger@google.com [Mon, 17 Dec 2012 15:27:30 +0000 (15:27 +0000)]
Add --writeJsonSummary option to gm

This writes out a JSON file containing expected and actual checksum values for every test.
Next step: allow the same checksum file to be compared against, instead of PNG files.
Review URL: https://codereview.appspot.com/6940053

git-svn-id: http://skia.googlecode.com/svn/trunk@6843 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SampleApp busted images with --picture on windows.
bsalomon@google.com [Mon, 17 Dec 2012 15:28:56 +0000 (15:28 +0000)]
Fix SampleApp busted images with --picture on windows.
Review URL: https://codereview.appspot.com/6942060

git-svn-id: http://skia.googlecode.com/svn/trunk@6842 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix line rendering with TileGrid and Rtree
junov@chromium.org [Mon, 17 Dec 2012 14:38:59 +0000 (14:38 +0000)]
Fix line rendering with TileGrid and Rtree

BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm hairmodes with --tileGrid and --rtree
Review URL: https://codereview.appspot.com/6947056

git-svn-id: http://skia.googlecode.com/svn/trunk@6841 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodetect out-of-memory when we try to create a mask offscreen
reed@google.com [Mon, 17 Dec 2012 14:21:38 +0000 (14:21 +0000)]
detect out-of-memory when we try to create a mask offscreen

git-svn-id: http://skia.googlecode.com/svn/trunk@6839 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 17 Dec 2012 13:58:08 +0000 (13:58 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6837 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd 4th test
reed@google.com [Mon, 17 Dec 2012 13:39:25 +0000 (13:39 +0000)]
add 4th test

git-svn-id: http://skia.googlecode.com/svn/trunk@6835 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange delta to 5, to better show the inset trend
mike@reedtribe.org [Mon, 17 Dec 2012 03:48:12 +0000 (03:48 +0000)]
change delta to 5, to better show the inset trend

git-svn-id: http://skia.googlecode.com/svn/trunk@6834 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove inset out of SkRRect.h for now, and add experimental versions to gm
mike@reedtribe.org [Mon, 17 Dec 2012 02:34:28 +0000 (02:34 +0000)]
move inset out of SkRRect.h for now, and add experimental versions to gm

git-svn-id: http://skia.googlecode.com/svn/trunk@6833 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd gm for rrect, and rrect.inset/outset
mike@reedtribe.org [Mon, 17 Dec 2012 02:10:42 +0000 (02:10 +0000)]
add gm for rrect, and rrect.inset/outset

git-svn-id: http://skia.googlecode.com/svn/trunk@6832 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoif CG fails to decode an image, check to see if it was a problem in the colorspace
mike@reedtribe.org [Sat, 15 Dec 2012 12:35:17 +0000 (12:35 +0000)]
if CG fails to decode an image, check to see if it was a problem in the colorspace

git-svn-id: http://skia.googlecode.com/svn/trunk@6830 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 15 Dec 2012 02:03:10 +0000 (02:03 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6829 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImproving comment in SkTileGrid::search
junov@chromium.org [Fri, 14 Dec 2012 22:23:49 +0000 (22:23 +0000)]
Improving comment in SkTileGrid::search

TBR=reed

git-svn-id: http://skia.googlecode.com/svn/trunk@6828 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new "aarects" bench to establish baseline for aa rect drawing
robertphillips@google.com [Fri, 14 Dec 2012 22:10:30 +0000 (22:10 +0000)]
Add new "aarects" bench to establish baseline for aa rect drawing

https://codereview.appspot.com/6941057/

git-svn-id: http://skia.googlecode.com/svn/trunk@6827 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplacing alloca call in SkTileGrid with SkAutoSMalloc
junov@chromium.org [Fri, 14 Dec 2012 20:12:51 +0000 (20:12 +0000)]
Replacing alloca call in SkTileGrid with SkAutoSMalloc
Review URL: https://codereview.appspot.com/6946054

git-svn-id: http://skia.googlecode.com/svn/trunk@6824 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix for windows chromium bots.
junov@chromium.org [Fri, 14 Dec 2012 15:57:45 +0000 (15:57 +0000)]
Build fix for windows chromium bots.

git-svn-id: http://skia.googlecode.com/svn/trunk@6823 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bench_pictures.cfg and add sanity check
borenet@google.com [Fri, 14 Dec 2012 14:56:37 +0000 (14:56 +0000)]
Fix bench_pictures.cfg and add sanity check
Review URL: https://codereview.appspot.com/6946052

git-svn-id: http://skia.googlecode.com/svn/trunk@6822 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix r6808 fix & some compiler warnings
robertphillips@google.com [Fri, 14 Dec 2012 13:55:06 +0000 (13:55 +0000)]
Fix r6808 fix & some compiler warnings

https://codereview.appspot.com/6948047/

git-svn-id: http://skia.googlecode.com/svn/trunk@6820 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocall lock-pixels once we know we're a sprite
reed@google.com [Fri, 14 Dec 2012 13:46:53 +0000 (13:46 +0000)]
call lock-pixels once we know we're a sprite
Review URL: https://codereview.appspot.com/6938058

git-svn-id: http://skia.googlecode.com/svn/trunk@6819 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse the stencil buffer to avoid temporary alpha clip masks.
bsalomon@google.com [Fri, 14 Dec 2012 13:36:53 +0000 (13:36 +0000)]
Use the stencil buffer to avoid temporary alpha clip masks.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6935048

git-svn-id: http://skia.googlecode.com/svn/trunk@6818 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd per-draw checks for lockcounts
reed@google.com [Fri, 14 Dec 2012 13:13:55 +0000 (13:13 +0000)]
add per-draw checks for lockcounts
Review URL: https://codereview.appspot.com/6943056

git-svn-id: http://skia.googlecode.com/svn/trunk@6815 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly run bench_pictures once for debug builds
borenet@google.com [Fri, 14 Dec 2012 13:04:24 +0000 (13:04 +0000)]
Only run bench_pictures once for debug builds

git-svn-id: http://skia.googlecode.com/svn/trunk@6814 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_GM
reed@google.com [Fri, 14 Dec 2012 12:59:07 +0000 (12:59 +0000)]
use DEF_GM

git-svn-id: http://skia.googlecode.com/svn/trunk@6813 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 14 Dec 2012 02:02:06 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6809 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compiler warning as error bug
robertphillips@google.com [Fri, 14 Dec 2012 00:34:28 +0000 (00:34 +0000)]
Fix compiler warning as error bug

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@6808 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOptimized implementation of SkMatrix44::preScale
shawnsingh@chromium.org [Thu, 13 Dec 2012 22:21:36 +0000 (22:21 +0000)]
Optimized implementation of SkMatrix44::preScale

preScale() does not need to do a general matrix multiply.  It can do 4x less
arithmetic by directly scaling the columns of the input matrix.
Review URL: https://codereview.appspot.com/6923048

git-svn-id: http://skia.googlecode.com/svn/trunk@6807 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreland 6798 w/ fix for bitmap-as-mask pixel-locking
reed@google.com [Thu, 13 Dec 2012 22:16:30 +0000 (22:16 +0000)]
reland 6798 w/ fix for bitmap-as-mask pixel-locking

git-svn-id: http://skia.googlecode.com/svn/trunk@6806 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoProvide an option to bench drawing individual tiles in bench_pictures.
scroggo@google.com [Thu, 13 Dec 2012 22:09:28 +0000 (22:09 +0000)]
Provide an option to bench drawing individual tiles in bench_pictures.

Provides output like the following:
running bench [1236 12045] androidpolice.skp
  tile_256x256: tile [0,0] out of [5,48]: msecs =   1.00
  tile_256x256: tile [1,0] out of [5,48]: msecs =   1.50
  tile_256x256: tile [2,0] out of [5,48]: msecs =   1.00
  tile_256x256: tile [3,0] out of [5,48]: msecs =   1.50
  tile_256x256: tile [4,0] out of [5,48]: msecs =   2.50
  tile_256x256: tile [0,1] out of [5,48]: msecs =   2.00
  tile_256x256: tile [1,1] out of [5,48]: msecs =   3.50
  tile_256x256: tile [2,1] out of [5,48]: msecs =   3.50
  tile_256x256: tile [3,1] out of [5,48]: msecs =   6.00
  tile_256x256: tile [4,1] out of [5,48]: msecs =   2.50
  tile_256x256: tile [0,2] out of [5,48]: msecs =   2.00

BUG=https://code.google.com/p/skia/issues/detail?id=1016

Review URL: https://codereview.appspot.com/6937047

git-svn-id: http://skia.googlecode.com/svn/trunk@6805 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn the config name, report the viewport, if one is provided.
scroggo@google.com [Thu, 13 Dec 2012 22:07:08 +0000 (22:07 +0000)]
In the config name, report the viewport, if one is provided.

Review URL: https://codereview.appspot.com/6942048

git-svn-id: http://skia.googlecode.com/svn/trunk@6804 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 6798 (assert in GM)
reed@google.com [Thu, 13 Dec 2012 21:53:41 +0000 (21:53 +0000)]
revert 6798 (assert in GM)

git-svn-id: http://skia.googlecode.com/svn/trunk@6802 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd debugging flag SK_IGNORE_PIXELREF_SETPRELOCKED for pixelref locks (disabled)
reed@google.com [Thu, 13 Dec 2012 21:41:00 +0000 (21:41 +0000)]
add debugging flag SK_IGNORE_PIXELREF_SETPRELOCKED for pixelref locks (disabled)

git-svn-id: http://skia.googlecode.com/svn/trunk@6800 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow bench_pictures to have its viewport set on the command line.
scroggo@google.com [Thu, 13 Dec 2012 21:40:48 +0000 (21:40 +0000)]
Allow bench_pictures to have its viewport set on the command line.

Instead of drawing the entire (potentially very large) picture, only
draw one viewport's worth.

example:

bench_pictures <skp directory> --viewport 640 480

BUG=https://code.google.com/p/skia/issues/detail?id=1007

Review URL: https://codereview.appspot.com/6943052

git-svn-id: http://skia.googlecode.com/svn/trunk@6799 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGoal: ensure we always balance lock/unlock pixels calls.
reed@google.com [Thu, 13 Dec 2012 21:39:56 +0000 (21:39 +0000)]
Goal: ensure we always balance lock/unlock pixels calls.

A big caller of lockPixels is setContext in the bitmapshader.

This change replaces beginSession/endSession with adding endContext(), and
adds debugging code to ensure that
1. setContext calls are never nested
2. endContext is always called after each setContext call.
Review URL: https://codereview.appspot.com/6937046

git-svn-id: http://skia.googlecode.com/svn/trunk@6798 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix oversights in r6793.
bsalomon@google.com [Thu, 13 Dec 2012 20:43:56 +0000 (20:43 +0000)]
Fix oversights in r6793.

git-svn-id: http://skia.googlecode.com/svn/trunk@6794 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse GrDrawTarget::AutoClipRestore to set temporary irect clips.
bsalomon@google.com [Thu, 13 Dec 2012 20:38:14 +0000 (20:38 +0000)]
Use GrDrawTarget::AutoClipRestore to set temporary irect clips.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6937048

git-svn-id: http://skia.googlecode.com/svn/trunk@6793 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Android SampleApp
djsollen@google.com [Thu, 13 Dec 2012 20:07:21 +0000 (20:07 +0000)]
Fix Android SampleApp

Review URL: https://codereview.appspot.com/6949046

git-svn-id: http://skia.googlecode.com/svn/trunk@6792 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a state bit to GrDrawState that forces coverage to be blended.
bsalomon@google.com [Thu, 13 Dec 2012 19:59:23 +0000 (19:59 +0000)]
Add a state bit to GrDrawState that forces coverage to be blended.

Use this mode in GrClipMaskManager.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6945048

git-svn-id: http://skia.googlecode.com/svn/trunk@6790 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd the original path renderer files and some support files from Android.
jvanverth@google.com [Thu, 13 Dec 2012 19:53:18 +0000 (19:53 +0000)]
Add the original path renderer files and some support files from Android.
Renamed PathRenderer.{cpp,h} to AndroidPathRenderer.{cpp,h} to avoid name
collisions.

http://codereview.appspot.com/6938050/

git-svn-id: http://skia.googlecode.com/svn/trunk@6789 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 13 Dec 2012 19:47:53 +0000 (19:47 +0000)]
shape ops work in progress

things work pretty well up to this point
it's time to apply recent deletion of binary code
algorithms to the unary code path

git-svn-id: http://skia.googlecode.com/svn/trunk@6788 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange to BDS license (as we did with all the other files that were Apache)
reed@google.com [Thu, 13 Dec 2012 19:24:05 +0000 (19:24 +0000)]
Change to BDS license (as we did with all the other files that were Apache)
Review URL: https://codereview.appspot.com/6948045

git-svn-id: http://skia.googlecode.com/svn/trunk@6787 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android build by removing references to the old sampleApp
djsollen@google.com [Thu, 13 Dec 2012 18:27:44 +0000 (18:27 +0000)]
Fix android build by removing references to the old sampleApp

Review URL: https://codereview.appspot.com/6949045

git-svn-id: http://skia.googlecode.com/svn/trunk@6786 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModifying SkTileGrid to support arbitrary query rectangles.
junov@chromium.org [Thu, 13 Dec 2012 16:39:53 +0000 (16:39 +0000)]
Modifying SkTileGrid to support arbitrary query rectangles.
Exposing SkTileGrid functionality in the public API through SkTileGridPicture.
This patch also makes TileGrid and Rtree testable in gm, which revealed errors.

TEST=gm with '--tileGrid'
BUG=http://code.google.com/p/chromium/issues/detail?id=164636
Review URL: https://codereview.appspot.com/6933044

git-svn-id: http://skia.googlecode.com/svn/trunk@6783 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agokill unused SkFlipPixelRef
reed@google.com [Thu, 13 Dec 2012 16:35:37 +0000 (16:35 +0000)]
kill unused SkFlipPixelRef
Review URL: https://codereview.appspot.com/6949043

git-svn-id: http://skia.googlecode.com/svn/trunk@6781 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing clip region test in deferred canvas, used to determine whether a draw operatio...
junov@chromium.org [Thu, 13 Dec 2012 16:30:39 +0000 (16:30 +0000)]
Fixing clip region test in deferred canvas, used to determine whether a draw operation occludes the entire canvas.

BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test DeferredCanvas/TestDeferredCanvasFreshFrame
Review URL: https://codereview.appspot.com/6934045

git-svn-id: http://skia.googlecode.com/svn/trunk@6780 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMatrix inversion optimizations and benchmark; originally by whunt@google.com.
tomhudson@google.com [Thu, 13 Dec 2012 09:55:42 +0000 (09:55 +0000)]
Matrix inversion optimizations and benchmark; originally by whunt@google.com.

https://codereview.appspot.com/6901046/

git-svn-id: http://skia.googlecode.com/svn/trunk@6775 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 13 Dec 2012 02:01:33 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6774 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse double precision when iterating in SkDashPathEffect::filterPath()
fmalita@google.com [Wed, 12 Dec 2012 22:13:58 +0000 (22:13 +0000)]
Use double precision when iterating in SkDashPathEffect::filterPath()

Extremely large path_length/dash_length ratios may cause us to loop
indefinitely otherwise.

R=reed@google.com

BUG=

Review URL: https://codereview.appspot.com/6926051

git-svn-id: http://skia.googlecode.com/svn/trunk@6773 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet git to ignore .android_config
scroggo@google.com [Wed, 12 Dec 2012 21:21:29 +0000 (21:21 +0000)]
Set git to ignore .android_config

Review URL: https://codereview.appspot.com/6863056

git-svn-id: http://skia.googlecode.com/svn/trunk@6772 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 6766, thereby re-landing 6762-6763 now that the bots are ready
reed@google.com [Wed, 12 Dec 2012 20:48:18 +0000 (20:48 +0000)]
revert 6766, thereby re-landing 6762-6763 now that the bots are ready

git-svn-id: http://skia.googlecode.com/svn/trunk@6770 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd bench_pictures config
borenet@google.com [Wed, 12 Dec 2012 20:13:26 +0000 (20:13 +0000)]
Add bench_pictures config
Review URL: https://codereview.appspot.com/6873073

git-svn-id: http://skia.googlecode.com/svn/trunk@6768 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 6762-6763, since those require new skps to be generated, and we can't
reed@google.com [Wed, 12 Dec 2012 19:15:31 +0000 (19:15 +0000)]
revert 6762-6763, since those require new skps to be generated, and we can't
do that immediately right now... will re-submit when we can.

git-svn-id: http://skia.googlecode.com/svn/trunk@6766 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopart of prev CL for rrect
reed@google.com [Wed, 12 Dec 2012 19:03:29 +0000 (19:03 +0000)]
part of prev CL for rrect

git-svn-id: http://skia.googlecode.com/svn/trunk@6763 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomake RRect and Oval first-class drawing primitives in SkCanvas.
reed@google.com [Wed, 12 Dec 2012 19:02:53 +0000 (19:02 +0000)]
make RRect and Oval first-class drawing primitives in SkCanvas.
add RRect as a first-class clip primitive.
Review URL: https://codereview.appspot.com/6923058

git-svn-id: http://skia.googlecode.com/svn/trunk@6762 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding quickContains API method to SkClipStack
junov@chromium.org [Wed, 12 Dec 2012 17:58:15 +0000 (17:58 +0000)]
Adding quickContains API method to SkClipStack

BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test ClipStack/quickContains
Review URL: https://codereview.appspot.com/6919044

git-svn-id: http://skia.googlecode.com/svn/trunk@6760 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate SkBitmapChecksummer and associated SkBitmapTransformer
epoger@google.com [Wed, 12 Dec 2012 17:22:23 +0000 (17:22 +0000)]
Create SkBitmapChecksummer and associated SkBitmapTransformer

As needed to start capturing gm image checksums.
Review URL: https://codereview.appspot.com/6920050

git-svn-id: http://skia.googlecode.com/svn/trunk@6759 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor cleanup
robertphillips@google.com [Wed, 12 Dec 2012 15:58:25 +0000 (15:58 +0000)]
Minor cleanup

https://codereview.appspot.com/6927054/

git-svn-id: http://skia.googlecode.com/svn/trunk@6756 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix generation of random two point gradients for program unit test.
bsalomon@google.com [Tue, 11 Dec 2012 15:32:04 +0000 (15:32 +0000)]
Fix generation of random two point gradients for program unit test.

git-svn-id: http://skia.googlecode.com/svn/trunk@6751 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 11 Dec 2012 02:01:20 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6746 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing logic error in deferred canvas unittest.
junov@chromium.org [Mon, 10 Dec 2012 21:24:38 +0000 (21:24 +0000)]
Fixing logic error in deferred canvas unittest.

Fixing an inverted test condition.  The tested feature is not broken, but the test was passing the inverted test because code just above was missing a restore call, which was affecting the test.
Review URL: https://codereview.appspot.com/6921044

git-svn-id: http://skia.googlecode.com/svn/trunk@6745 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse new enum-constructors
reed@google.com [Mon, 10 Dec 2012 21:21:27 +0000 (21:21 +0000)]
use new enum-constructors

git-svn-id: http://skia.googlecode.com/svn/trunk@6744 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for Mac-specific OpenGL == complaint in GrGLProgram.cpp
robertphillips@google.com [Mon, 10 Dec 2012 21:05:19 +0000 (21:05 +0000)]
Fix for Mac-specific OpenGL == complaint in GrGLProgram.cpp

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@6743 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkMatrix44 constructor that allows user to control the initialization
vollick@chromium.org [Mon, 10 Dec 2012 20:16:10 +0000 (20:16 +0000)]
Add SkMatrix44 constructor that allows user to control the initialization
method.  Preliminary results using Chromium's cc_perftests
show that we can avoid almost half of the default constructors from
redundantly/unnecessarily initializing the matrix to identity.

Review URL: https://codereview.appspot.com/6872056

git-svn-id: http://skia.googlecode.com/svn/trunk@6742 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModifications to GrPatherRenderer(Chain) interfaces to support clip mask manager.
bsalomon@google.com [Mon, 10 Dec 2012 19:10:17 +0000 (19:10 +0000)]
Modifications to GrPatherRenderer(Chain) interfaces to support clip mask manager.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6904069

git-svn-id: http://skia.googlecode.com/svn/trunk@6741 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhen cloning picture, use a bitmap heap to avoid flattening bitmaps.
scroggo@google.com [Mon, 10 Dec 2012 18:20:23 +0000 (18:20 +0000)]
When cloning picture, use a bitmap heap to avoid flattening bitmaps.

When cloning a picture, the paints are reflattened. Use a bitmap
heap so the bitmaps do not get unnecessarily get flattened as well.

For br.337, this speeds up bench_pictures timing the clone
operation (not yet checked in, but currently timing making five
clones) from around 180 ms to around 24ms.

Review URL: https://codereview.appspot.com/6903063

git-svn-id: http://skia.googlecode.com/svn/trunk@6740 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooptimize for paints that don't require deep copy during clone
reed@google.com [Mon, 10 Dec 2012 17:39:36 +0000 (17:39 +0000)]
optimize for paints that don't require deep copy during clone
Review URL: https://codereview.appspot.com/6903062

git-svn-id: http://skia.googlecode.com/svn/trunk@6739 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisable failing test on android.
bsalomon@google.com [Mon, 10 Dec 2012 17:32:07 +0000 (17:32 +0000)]
Disable failing test on android.
Review URL: https://codereview.appspot.com/6899059

git-svn-id: http://skia.googlecode.com/svn/trunk@6738 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomark our unflattened bitmap as immutable (just as picture deserialization does)
reed@google.com [Mon, 10 Dec 2012 16:10:33 +0000 (16:10 +0000)]
mark our unflattened bitmap as immutable (just as picture deserialization does)

git-svn-id: http://skia.googlecode.com/svn/trunk@6736 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd '--mode clone' option to bench_pictures
reed@google.com [Mon, 10 Dec 2012 16:05:09 +0000 (16:05 +0000)]
add '--mode clone' option to bench_pictures

git-svn-id: http://skia.googlecode.com/svn/trunk@6735 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't convert clipPath -> clipRect if the path is inverse-filled
reed@google.com [Mon, 10 Dec 2012 15:50:37 +0000 (15:50 +0000)]
don't convert clipPath -> clipRect if the path is inverse-filled

git-svn-id: http://skia.googlecode.com/svn/trunk@6734 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn SKP serialization, use existing encoded data.
scroggo@google.com [Mon, 10 Dec 2012 15:40:55 +0000 (15:40 +0000)]
In SKP serialization, use existing encoded data.

If an SkBitmap has encoded data, write that during serialization
rather than reencoding it.

Add a test to ensure that this does not modify the output stream,
so the reader need not know the difference.

Review URL: https://codereview.appspot.com/6884054

git-svn-id: http://skia.googlecode.com/svn/trunk@6732 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing SkClipStack::clipDevPath so that it will not convert rectangular paths to...
junov@chromium.org [Mon, 10 Dec 2012 14:57:54 +0000 (14:57 +0000)]
Fixing SkClipStack::clipDevPath so that it will not convert rectangular paths to rectangle clips if inverse fill.

BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test ClipStackTest/test_rect_inverse_fill
Review URL: https://codereview.appspot.com/6880044

git-svn-id: http://skia.googlecode.com/svn/trunk@6731 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 10 Dec 2012 14:50:04 +0000 (14:50 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6730 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReapply (r6718) with fix for compiler error on linux.
djsollen@google.com [Mon, 10 Dec 2012 14:12:55 +0000 (14:12 +0000)]
Reapply (r6718) with fix for compiler error on linux.

git-svn-id: http://skia.googlecode.com/svn/trunk@6729 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)
djsollen@google.com [Mon, 10 Dec 2012 14:10:20 +0000 (14:10 +0000)]
revert Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)

git-svn-id: http://skia.googlecode.com/svn/trunk@6728 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)
djsollen@google.com [Mon, 10 Dec 2012 13:55:02 +0000 (13:55 +0000)]
Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)

This reverts r5378.

Review URL: https://codereview.appspot.com/6815056

git-svn-id: http://skia.googlecode.com/svn/trunk@6727 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 10 Dec 2012 12:50:53 +0000 (12:50 +0000)]
shape ops work in progress

rewrite binary edge inclusion lookup
fix warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@6726 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd helpers for isTranslate and isScaleTranslate
mike@reedtribe.org [Mon, 10 Dec 2012 03:27:47 +0000 (03:27 +0000)]
add helpers for isTranslate and isScaleTranslate
special-case determinant for isScaleTranslate

git-svn-id: http://skia.googlecode.com/svn/trunk@6725 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 8 Dec 2012 02:01:38 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6721 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Added the following 3 features to sample app."
djsollen@google.com [Fri, 7 Dec 2012 22:10:39 +0000 (22:10 +0000)]
Revert "Added the following 3 features to sample app."

Review URL: https://codereview.appspot.com/6906054

git-svn-id: http://skia.googlecode.com/svn/trunk@6719 2bbb7eff-a529-9590-31e7-b0007b416f81