Martin Pitt [Mon, 29 Feb 2016 14:19:10 +0000 (15:19 +0100)]
Merge pull request #2766 from keszybz/coverity
test-clock: fix fd "leak"
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 13:03:32 +0000 (08:03 -0500)]
test-clock: fix fd "leak"
CID #1352301.
Ronny Chevalier [Mon, 29 Feb 2016 11:23:55 +0000 (12:23 +0100)]
Merge pull request #2764 from benjarobin/fix-stdio-bridge
stdio-bridge: Correctly propagate error
Benjamin Robin [Mon, 29 Feb 2016 09:36:11 +0000 (10:36 +0100)]
stdio-bridge: Correctly propagate error
Return EXIT_FAILURE and print the correct errno code if sd_bus_get_fd() or sd_bus_get_events() fail
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 00:23:29 +0000 (19:23 -0500)]
Merge pull request #2746 from daurnimator/patch-1
ISSUE_TEMPLATE: Use a list for submission type so that it appears as a checkbox
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 00:12:31 +0000 (19:12 -0500)]
Merge pull request #2753 from phomes/trivial-fixes2
Trivial fixes
Zbigniew Jędrzejewski-Szmek [Sun, 28 Feb 2016 23:56:07 +0000 (18:56 -0500)]
Merge pull request #2749 from martinpitt/adjtime
Thomas Hindoe Paaboel Andersen [Wed, 24 Feb 2016 23:29:09 +0000 (00:29 +0100)]
stdio-bridge: remove dead code
Thomas Hindoe Paaboel Andersen [Wed, 24 Feb 2016 23:27:56 +0000 (00:27 +0100)]
tree-wide: indentation fixes
Martin Pitt [Fri, 26 Feb 2016 14:54:05 +0000 (15:54 +0100)]
timedated: be more tolerant in parsing /etc/adjtime
Similarly to the previous commit, make context_write_data_local_rtc()
understand /etc/adjtime files with just one or two lines, with or without a
final newline.
Normalize the file to the current definition in hwclock(8), in the spirit of
"be liberal what you accept and strict what you produce": Add line terminators,
and set the second line to "0" if missing.
Fixes: #2638
Martin Pitt [Fri, 26 Feb 2016 11:33:41 +0000 (12:33 +0100)]
clock-util: be more tolerant in parsing /etc/adjtime
As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it
also makes sense to have that default if /etc/adjtime contains only one or two
lines.
Drop the "gibberish" test case, as this was just EIO because of not containing
three lines, which is already contained in other tests. clock_is_localtime()
never actually validated the format of the first two lines, and there is little
point in doing that.
This addresses the reading half of issue #2638.
Martin Pitt [Fri, 26 Feb 2016 10:25:22 +0000 (11:25 +0100)]
clock-util: make clock_is_localtime() testable and add initial tests
Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's
NULL. This makes the function testable.
Add test-clock: initial test cases for some scenarios, using a temporary file.
This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime)
file.
daurnimator [Thu, 25 Feb 2016 22:54:30 +0000 (09:54 +1100)]
.github/ISSUE_TEMPLATE: Use a list for submission type so that it appears as a checkbox
Zbigniew Jędrzejewski-Szmek [Thu, 25 Feb 2016 20:29:59 +0000 (15:29 -0500)]
Merge pull request #2671 from 0xAX/move-pager-open-to-one-place
tree-wide: merge pager_open_if_enabled() to the pager_open()
Alexander Kuleshov [Fri, 19 Feb 2016 18:25:13 +0000 (00:25 +0600)]
tree-wide: merge pager_open_if_enabled() to the pager_open()
Many subsystems define own pager_open_if_enabled() function which
checks '--no-pager' command line argument and open pager depends
on its value. All implementations of pager_open_if_enabled() are
the same. Let's merger this function with pager_open() from the
shared/pager.c and remove pager_open_if_enabled() from all subsytems
to prevent code duplication.
Lennart Poettering [Thu, 25 Feb 2016 19:01:56 +0000 (20:01 +0100)]
Merge pull request #2743 from pfl/dhcp4_server
sd-dhcp-server: Send replies to BOOTP relay server port
Patrik Flykt [Thu, 25 Feb 2016 13:36:40 +0000 (15:36 +0200)]
sd-dhcp-server: Send replies to BOOTP relay server port
RFC 2131 Section 4.1 says that
"If the ’giaddr’ field in a DHCP message from a client is non-zero,
the server sends any return messages to the ’DHCP server’ port on the
BOOTP relay agent whose address appears in ’giaddr’."
Fix this by adding a destination port when sending unicast UDP packets
and provide the server port when a BOOTP relay agent is being used.
Daniel Mack [Wed, 24 Feb 2016 14:51:34 +0000 (15:51 +0100)]
Merge pull request #2722 from torstehu/fix-typo2
treewide: fix typos and then/that use
Torstein Husebø [Mon, 8 Feb 2016 12:27:22 +0000 (13:27 +0100)]
treewide: fix typos and then/that use
Martin Pitt [Wed, 24 Feb 2016 07:06:53 +0000 (08:06 +0100)]
Merge pull request #2719 from evverx/add-test-to-makefile
tests: various fixes
Zbigniew Jędrzejewski-Szmek [Wed, 24 Feb 2016 05:40:48 +0000 (00:40 -0500)]
Merge pull request #2726 from ssiloti/master
dnssec: only run tests that require gcrypt if we have it
Zbigniew Jędrzejewski-Szmek [Wed, 24 Feb 2016 05:39:06 +0000 (00:39 -0500)]
Merge pull request #2727 from ian-kelling/man-pr-v3
man: clarify unit ordering language
Ian Kelling [Mon, 22 Feb 2016 02:21:50 +0000 (18:21 -0800)]
man: clarify unit ordering language
Steven Siloti [Wed, 24 Feb 2016 04:15:23 +0000 (20:15 -0800)]
dnssec: only run tests that require gcrypt if we have it
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 23:48:37 +0000 (18:48 -0500)]
Merge pull request #2724 from vcaputo/minor-formatting-cleanups
tree-wide: minor formatting inconsistency cleanups
Vito Caputo [Tue, 23 Feb 2016 17:52:52 +0000 (09:52 -0800)]
tree-wide: minor formatting inconsistency cleanups
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 22:12:40 +0000 (17:12 -0500)]
Merge pull request #2639 from nafets227/master
Bugfix set virt=none when running on XEN Dom0
Stefan Schallenberg aka nafets227 [Tue, 16 Feb 2016 20:36:12 +0000 (21:36 +0100)]
basic: Bugfix Detect XEN Dom0 as no virtualization
When running in XEN Dom0 the virtualization check:
1) detect_xen returns HYPERVISOR_NONE so next checks are executed
2) /proc/sys/hypervisor detects a XEN hypervisor
it is lacking the special Dom0 detection as in detect_xen
With this patch, at the end of all virtualization checks we double-check if running in XEN Dom0 or DomU.
Stefan Schallenberg aka nafets227 [Thu, 18 Feb 2016 20:10:28 +0000 (21:10 +0100)]
basic: Debug-logging of Virtualisation detection
print out every single detection executed and its result.
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 19:58:01 +0000 (14:58 -0500)]
Merge pull request #2725 from phomes/misc-cleanup
Misc cleanup
Thomas Hindoe Paaboel Andersen [Tue, 23 Feb 2016 19:25:48 +0000 (20:25 +0100)]
networkctl: fix const
Thomas Hindoe Paaboel Andersen [Tue, 23 Feb 2016 19:16:59 +0000 (20:16 +0100)]
tree-wide: remove unused variables
Thomas Hindoe Paaboel Andersen [Tue, 23 Feb 2016 18:21:54 +0000 (19:21 +0100)]
basic: mark unused variable as such
Lennart Poettering [Tue, 23 Feb 2016 19:27:59 +0000 (20:27 +0100)]
Merge pull request #2664 from zonque/bootchart-removal
Remove systemd-bootchart
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 18:39:56 +0000 (13:39 -0500)]
Merge pull request #2723 from poettering/importd-man
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 18:46:16 +0000 (13:46 -0500)]
man: style fixes
Lennart Poettering [Tue, 23 Feb 2016 17:24:03 +0000 (18:24 +0100)]
man: change recommended order of NSS modules in /etc/nsswitch.conf
So far we recommended placing "nss-mymachines" after "nss-resolve" in the order
of preference in /etc/nsswitch.conf. This change reverse this order.
Rationale: single-label names are resolved via LLMNR by resolved, which has to
time out if no peer by that name exists. By placing "nss-mymachines" first
(which always responds immediately) we avoid running into this timeout for most
containers. Both modules should return the same data if LLMNR is used by the
container anyway.
While we are at it, improve the man pages of the three NSS modules in other
ways a bit.
Evgeny Vereshchagin [Tue, 23 Feb 2016 16:53:19 +0000 (16:53 +0000)]
tests: add exec-capabilityambientset* to Makefile.am
This is a follow-up to
70d7aea5c
Evgeny Vereshchagin [Tue, 23 Feb 2016 15:59:14 +0000 (15:59 +0000)]
tests: add exec-runtimedirectory* to Makefile.am
This is a follow-up to
cc3ddc851
Lennart Poettering [Tue, 23 Feb 2016 12:17:00 +0000 (13:17 +0100)]
tests: fix x86 personality tests to only on x86
Evgeny Vereshchagin [Tue, 23 Feb 2016 14:33:20 +0000 (14:33 +0000)]
tests: add exec-spec-interpolation.service to Makefile.am
This is a follow-up to 2525499
Lennart Poettering [Tue, 23 Feb 2016 15:55:16 +0000 (16:55 +0100)]
Merge pull request #2708 from vcaputo/journal-restore-offline-state-on-error
journal: restore offline state on error
Lennart Poettering [Tue, 23 Feb 2016 15:54:52 +0000 (16:54 +0100)]
Merge pull request #2717 from keszybz/networkctl-prettification
Networkctl prettification
Lennart Poettering [Tue, 23 Feb 2016 15:24:01 +0000 (16:24 +0100)]
man: link some unit files to their online bus API documentation
Lennart Poettering [Tue, 23 Feb 2016 15:23:42 +0000 (16:23 +0100)]
man: add minimal man page for systemd-importd.service
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 04:23:56 +0000 (23:23 -0500)]
networkctl: only print lldp legend for capabilities that were actually seen
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 13:17:19 +0000 (08:17 -0500)]
basic: simplify ether_addr_is_null
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 13:17:19 +0000 (08:17 -0500)]
Fix two typos
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 13:17:03 +0000 (08:17 -0500)]
man: update link to Fedora Cloud images
Better to use the mirror manager and https.
Daniel Mack [Mon, 22 Feb 2016 20:01:39 +0000 (21:01 +0100)]
architecture.h: remove PROC_CPUINFO_MODEL
This was only needed for bootchart, so it can go now.
Daniel Mack [Fri, 12 Feb 2016 14:03:51 +0000 (15:03 +0100)]
Remove systemd-bootchart
This commit rips out systemd-bootchart. It will be given a new home, outside
of the systemd repository. The code itself isn't actually specific to
systemd and can be used without systemd even, so let's put it somewhere
else.
Martin Pitt [Tue, 23 Feb 2016 07:45:54 +0000 (08:45 +0100)]
Merge pull request #2709 from vcaputo/normalize_inc_dec_usage
tree-wide: make ++/-- usage consistent WRT spacing
Martin Pitt [Tue, 23 Feb 2016 07:25:13 +0000 (08:25 +0100)]
Merge pull request #2707 from teg/man-network
network: minor manpage clarifications
Martin Pitt [Tue, 23 Feb 2016 07:19:20 +0000 (08:19 +0100)]
Merge pull request #2698 from poettering/personality
Personality fixes
Vito Caputo [Tue, 23 Feb 2016 04:32:04 +0000 (20:32 -0800)]
tree-wide: make ++/-- usage consistent WRT spacing
Throughout the tree there's spurious use of spaces separating ++ and --
operators from their respective operands. Make ++ and -- operator
consistent with the majority of existing uses; discard the spaces.
Vito Caputo [Tue, 23 Feb 2016 04:00:13 +0000 (20:00 -0800)]
journal: restore offline state on error
If we fail to create the thread, technically we should leave the
offline_state as OFFLINE_JOINED, not OFFLINE_SYNCING.
Zbigniew Jędrzejewski-Szmek [Tue, 23 Feb 2016 00:56:23 +0000 (19:56 -0500)]
Merge pull request #2706 from whot/hwdb-updates
Lenovo T460 and P50 touchpad axis corrections
Tom Gundersen [Tue, 23 Feb 2016 00:09:31 +0000 (01:09 +0100)]
man: link - add suggestion for debugging
udevadm test-builtin can be very useful for testing .link files, so add a reference.
Addresses issue #2406.
Tom Gundersen [Mon, 22 Feb 2016 23:29:32 +0000 (00:29 +0100)]
man: network - clarify BindCarrier documentation
Make it clear that we are talking of links (in the sense used in networkd) and not ports.
Addresses issue #964.
Tom Gundersen [Mon, 22 Feb 2016 23:21:53 +0000 (00:21 +0100)]
man: network - improve IPv6Token documentation
Enabling router advertisement may even trigger SLAAC or DHCPv6 to be used to configure
IPv6 addresses on the link. It may not be obvious that only in the SLAAC case will the
Token have an effect. Clarify this in the man page.
Addresses issue #863.
Peter Hutterer [Mon, 22 Feb 2016 23:52:21 +0000 (09:52 +1000)]
hwdb: reshuffle Lenovo entries to sort alphabetically by model
Peter Hutterer [Mon, 22 Feb 2016 23:49:08 +0000 (09:49 +1000)]
hwdb: add axis range corrections for the Lenovo T460 and P50
Lennart Poettering [Mon, 22 Feb 2016 22:25:36 +0000 (23:25 +0100)]
Merge pull request #2701 from keszybz/udev-rules
udev-rules cleanup fix
Lennart Poettering [Mon, 22 Feb 2016 22:22:42 +0000 (23:22 +0100)]
github: CONTRIBUTING.md moved, let's fix the link to it
Lennart Poettering [Mon, 22 Feb 2016 17:36:54 +0000 (18:36 +0100)]
tests: add personality tests
Lennart Poettering [Mon, 22 Feb 2016 17:29:05 +0000 (18:29 +0100)]
util-lib: simplify personality() string matching
Lennart Poettering [Mon, 22 Feb 2016 15:28:17 +0000 (16:28 +0100)]
virt: make sure we don't ignore some errors
Lennart Poettering [Mon, 22 Feb 2016 15:01:53 +0000 (16:01 +0100)]
man: extend the Personality= documentation
Among other fixes, add information about more architectures that are supported
these days.
Lennart Poettering [Mon, 22 Feb 2016 14:50:35 +0000 (15:50 +0100)]
util-lib: support various ppc archs in personality logic
Lennart Poettering [Mon, 22 Feb 2016 14:39:52 +0000 (15:39 +0100)]
util-lib: use the architecture ids from architecture.h for personalities
We have this ids, hence let's use them universally.
Lennart Poettering [Mon, 22 Feb 2016 14:26:54 +0000 (15:26 +0100)]
build-sys: move shared/architecture.[ch] into basic/
After all, it is pretty generic, has no external deps besides libc, and is very
similar to virt.[ch] which is also in basic/
Martin Pitt [Mon, 22 Feb 2016 22:21:46 +0000 (23:21 +0100)]
Merge pull request #2704 from poettering/lldp-internal-fix
build-sys: add missing header file to Makefile.am
Lennart Poettering [Mon, 22 Feb 2016 20:55:22 +0000 (21:55 +0100)]
build-sys: add missing header file to Makefile.am
Fixes: #2700
Zbigniew Jędrzejewski-Szmek [Mon, 22 Feb 2016 17:17:08 +0000 (12:17 -0500)]
udev-rules: fix querying of attributes
faccessat returns 0 on success.
A cosmetic fix is also included: the slash was doubled unnecessarily.
Zbigniew Jędrzejewski-Szmek [Mon, 22 Feb 2016 17:15:17 +0000 (12:15 -0500)]
udev-test.pl: add --strace option
It's useful when trying to see what the tests are doing.
I hardcoded '-efile' as the option to strace, but in the future
it might be useful to make this configurable.
Tom Gundersen [Mon, 22 Feb 2016 16:38:34 +0000 (17:38 +0100)]
Merge pull request #2685 from poettering/lldp-fixes2
lldp fixes, second iteration
Lennart Poettering [Mon, 22 Feb 2016 15:16:05 +0000 (16:16 +0100)]
Merge pull request #2695 from mustrumr/fix-calendarspec-skip
calendarspec: fix find_next skipping times
Zbigniew Jędrzejewski-Szmek [Mon, 22 Feb 2016 13:59:39 +0000 (08:59 -0500)]
Merge pull request #2692 from ssahani/tunnel
networkd: tunnel fix tunnel address
Lennart Poettering [Mon, 22 Feb 2016 13:33:27 +0000 (14:33 +0100)]
Merge pull request #2694 from zonque/proxyarp-missing
missing.h: Explicitly check for IFLA_BRPORT_PROXYARP
Hristo Venev [Mon, 22 Feb 2016 13:02:48 +0000 (08:02 -0500)]
calendarspec: fix find_next skipping times
reset usec when bumping hours/minutes
Daniel Mack [Mon, 22 Feb 2016 12:10:16 +0000 (13:10 +0100)]
missing.h: Explicitly check for IFLA_BRPORT_PROXYARP
RHEL explicitly disables IFLA_BRPORT_PROXYARP by renaming the enum value.
In order to support unpatched builds, we have two options:
a) redefine the enum value through missing.h and ignore the fact that it
is really unsupported, or
b) omit that enum value on rtnl_prot_info_bridge_port_types[]
As we are not actually using this netlink type anywhere, and because it
is only hooked up for the sake of completeness, this patch opts for the
former.
Daniel Mack [Mon, 22 Feb 2016 08:59:07 +0000 (09:59 +0100)]
Merge pull request #2687 from poettering/resolved-fix-2683
networkd: make sure we allocate the NTA set before we add items to it
Daniel Mack [Mon, 22 Feb 2016 08:58:23 +0000 (09:58 +0100)]
Merge pull request #2686 from poettering/github-templates
add github issue template
Zbigniew Jędrzejewski-Szmek [Mon, 22 Feb 2016 02:29:41 +0000 (21:29 -0500)]
Merge pull request #2688 from poettering/calendar-fix-2678
A fix for #2678
Lennart Poettering [Sun, 21 Feb 2016 22:27:20 +0000 (23:27 +0100)]
util-lib: fix returned error code
Make sure we propagate errors properly.
Lennart Poettering [Sun, 21 Feb 2016 22:25:38 +0000 (23:25 +0100)]
util-lib: add (void) cast to indicate that we don't care about the normalization success
After all, we verify that every calendar part is not out of bounds later on,
and it's fully OK if the normalization has no effect.
Lennart Poettering [Sun, 21 Feb 2016 21:27:01 +0000 (22:27 +0100)]
networkd: make sure we allocate the NTA set before we add items to it
See: #2683
Lennart Poettering [Sun, 21 Feb 2016 20:35:50 +0000 (21:35 +0100)]
Merge pull request #2650 from vcaputo/async_fsync
Perform journal offlines asynchronously when possible
Lennart Poettering [Sun, 21 Feb 2016 20:22:55 +0000 (21:22 +0100)]
Merge pull request #2681 from keszybz/udev-rules
udev-rules cleanup and coverity warning silencing
Lennart Poettering [Sun, 21 Feb 2016 20:15:17 +0000 (21:15 +0100)]
github: add a basic issue template
As documented here:
https://help.github.com/articles/creating-an-issue-template-for-your-repository/
Lennart Poettering [Sun, 21 Feb 2016 20:05:02 +0000 (21:05 +0100)]
github: move CONTRIBUTING.md into .github subdirectory
As suggested by:
https://github.com/blog/2111-issue-and-pull-request-templates
Lennart Poettering [Sun, 21 Feb 2016 19:58:01 +0000 (20:58 +0100)]
man: document the new EmitLLDP= .network setting
Also, beef up the LLDP documentation a bit.
Lennart Poettering [Thu, 18 Feb 2016 21:54:57 +0000 (22:54 +0100)]
update TODO
Lennart Poettering [Sun, 21 Feb 2016 19:38:39 +0000 (20:38 +0100)]
sd-lldp: beef up callback logic
Instead of just notifying about the fact that something changed in the
database, actually inform the callback what precisely changed. This is useful,
so that the LLDP tx logic can be put into "fast" mode as soon as a previously
unknown peer appears, as suggested by the LLDP spec.
Lennart Poettering [Sun, 21 Feb 2016 13:31:51 +0000 (14:31 +0100)]
networkctl: ellipsize long LLDP fields in table output
Lennart Poettering [Sun, 21 Feb 2016 13:27:06 +0000 (14:27 +0100)]
networkctl: add missing newline to printf() format string
Lennart Poettering [Sun, 21 Feb 2016 13:06:08 +0000 (14:06 +0100)]
network: turn on LLDP tx+rx for the default container network configuration
Containers are relatively trusted and the veth tunnels are small networks,
hence let's turn on LLDP both ways for them.
Lennart Poettering [Sun, 21 Feb 2016 13:14:08 +0000 (14:14 +0100)]
networkd: add basic LLDP transmission support
Let's add some minimalistic LLDP sender support. The idea is that this is
either on or off, and all fields determined automatically rather than
configured explicitly.
Lennart Poettering [Sun, 21 Feb 2016 13:11:34 +0000 (14:11 +0100)]
sd-lldp: filter out LLDP messages coming from our own MAC address
Let's not get confused should we be connected to some bridge that mirrors back
our packets.
Lennart Poettering [Sat, 20 Feb 2016 23:10:55 +0000 (00:10 +0100)]
import: don't claim we had copied a settings file if we didn't