ziga-lunarg [Mon, 25 Jul 2022 21:44:21 +0000 (23:44 +0200)]
Fix passing temporary object as reference
Components:
Vulkan, OpenGL, EGL, Framework
VK-GL-CTS issue: 3382
Affects:
dEQP-VK*
dEQP-GL*
dEQP-EGL*
Change-Id: Ibff4e4a7bc8c9da3ea82337a84da6c4118608b11
Piers Daniell [Mon, 6 Jun 2022 16:10:39 +0000 (10:10 -0600)]
Improve image capability check compressed image tests
The image creation routine for the dEQP-VK.image.texel_view_compatible.*
tests was throwing false "Not Supported" because it was checking if the
compressed image format supported image load/store, but the tests didn't
need it.
This CL replaces the false check with an improved capability check that
uses the actual image creationg parameters the tests uses. This allows
extended usage to be taken into account where the uncompressed image views
can support image load/store.
Affects:
dEQP-VK.image.texel_view_compatible.*
Components: Vulkan
VK-GL-CTS issue: 3745
Change-Id: I14be9f7bbf48b8700ef522d1e0481a8d69295b94
Ricardo Garcia [Fri, 8 Jul 2022 08:15:03 +0000 (10:15 +0200)]
Test conditional rendering does not affect render pass clears
Clearing attachments at the start of the render pass should happen
unconditionally even if the render pass falls inside a conditional
rendering block.
Affected and new tests:
dEQP-VK.conditional_rendering.*
Components: Vulkan
VK-GL-CTS issue: 3710
Change-Id: I826a787b5cf3b61f2a08c9ce381d29e931653be6
Ilkka Saarelainen [Mon, 23 May 2022 11:33:33 +0000 (14:33 +0300)]
Add dynamic rendering MSRTSS tests
This CL adds dynamic rendering variants of the MultiSampled
Render To SingleSampled tests. This CL also adds Multisample
test variants not requiring the MSRTSS extension.
New tests:
dEQP-VK.pipeline.*.multisample.multisampled_render_to_single_sampled.dynamic_rendering.*
dEQP-VK.pipeline.*.multisample.misc.dynamic_rendering.*
Affects:
dEQP-VK.pipeline.*.multisample.multisampled_render_to_single_sampled.*
dEQP-VK.pipeline.*.multisample.misc.*
VK-GL-CTS Issue: 3581
Components: Vulkan
Change-Id: Id525423d527a201d8218b9bf6a7e8ccabc6ba52e
Matthew Netsch [Fri, 29 Jul 2022 15:03:31 +0000 (15:03 +0000)]
Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main" into main
Matthew Netsch [Thu, 28 Jul 2022 23:56:56 +0000 (16:56 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main
Change-Id: I2e4800b23af1ca78e7b0612c80d01f0b39c4be25
Matthew Netsch [Thu, 28 Jul 2022 21:44:27 +0000 (14:44 -0700)]
Merge vk-gl-cts/vulkansc-cts-1.0.1 to vk-gl-cts/main
Change-Id: Ib378b15ee800a194a1554c57bdd78082c166a1c9
feishengfei [Tue, 12 Jul 2022 05:20:36 +0000 (13:20 +0800)]
Fix C++ tuple constexpr initial list on old compiler
Components: Vulkan
Change-Id: I1511592b4afe3d1cc9bb426c6014d90828ae6a17
JoniSt [Mon, 25 Jul 2022 22:03:14 +0000 (00:03 +0200)]
Fix script arguments in vulkancts CMakeLists
The missing "-o" flag was causing build failures on Linux with python3.
Components: Framework
VK-GL-CTS public issue: 339
Change-Id: I1de93d1bf6a5653528210d11f7815c69ac30ec76
michal_jakubek [Fri, 17 Jun 2022 08:04:29 +0000 (10:04 +0200)]
Fix for attachment count in EXT_color_write_enable tests.
Affects:
dEQP-VK.pipeline.*.color_write_enable_maxa.*
Components: Vulkan
VK-GL-CTS issue: 3860
Change-Id: I104166abcb8169a43c6a4dc959b085585d4e2489
Matthew Netsch [Thu, 28 Jul 2022 20:28:03 +0000 (20:28 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ide2d2e48acbd9485050376f1d3a7b9f85733533e
Ricardo Garcia [Wed, 20 Jul 2022 09:57:38 +0000 (11:57 +0200)]
Avoid using empty descriptor set layouts with libraries
When creating pipeline libraries, the different pipeline layouts need to
be combined on a union of pipeline layouts, and sets not used for a
particular library can be VK_NULL_HANDLE when those pipeline layouts are
created with VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT.
Some of the pipeline library tests are using empty descriptor sets
instead of null handles for this case, breaking some drivers.
Affected tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
VK-GL-CTS issue: 3584
Components: Vulkan
Change-Id: I6ee66f5d350bf586ac680f222ac5e426cb36a2e5
Matthew Netsch [Thu, 28 Jul 2022 19:55:59 +0000 (19:55 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I55ea5df83f5be721690df56e52a32c9281761077
ziga-lunarg [Mon, 20 Jun 2022 16:21:43 +0000 (18:21 +0200)]
Add missing required extension in pageable allocation tests
Extension VK_EXT_pageable_device_local_memory requires
VK_EXT_memory_priority
Components: Vulkan
VK-GL-CTS issue: 3783
Affects:
dEQP-VK.memory.pageable_allocation.*
Change-Id: Ib29a5d908549d64342dc186c19ce533dec953d3f
Matthew Netsch [Thu, 28 Jul 2022 19:31:30 +0000 (19:31 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I501ed2d53ae848c8c6fcf0f674cdb4d28202a04d
Matthew Netsch [Thu, 28 Jul 2022 18:59:20 +0000 (18:59 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I9d6e9415440bdafefb45374e021e47041dd4e237
Aidan Fabius [Mon, 25 Jul 2022 15:34:52 +0000 (11:34 -0400)]
Re-enable fence, event, barrier, and binary semaphore tests when timeline semaphores aren't supported
Components: Vulkan
VK-GL-CTS issue: 3847
Affects:
dEQP-VKSC.synchronization.op.*
dEQP-VKSC.synchronization2.op.*
dEQP-VK.synchronization.op.*
dEQP-VK.synchronization2.op.*
Change-Id: I95a0073b291f9288dcd2efae4a3302b3c98558a3
Matthew Netsch [Thu, 28 Jul 2022 18:29:57 +0000 (18:29 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I1353fd5c9aef95c5f0b776ffbd3bf5a1c252c0f1
Piotr Byszewski [Tue, 19 Jul 2022 10:48:15 +0000 (12:48 +0200)]
Handle latest Wayland version
CTS used a deprecated protocol wl_shell, which has been replaced
in Ubuntu 22.04 by xdg-shell. This change replaces all wl_shell
calls with corresponding xdg-shell calls.
Note that xdg-shell is a protocol and in wayland-protocols repository
we have only xml that defines this protocol. wayland-scanner tool is
used to generate the .h and .c files in build directory.
VK-GL-CTS issue: 3774
Components: Vulkan
Affects:
*
dEQP-VK.image.swapchain_mutable.wayland*
dEQP-VK.wsi.wayland.swapchain.*
dEQP-VK.wsi.wayland.incremental_present.*
Change-Id: I44879d9eb072dbfa5e172eaac81968e65e8a276c
Matthew Netsch [Thu, 28 Jul 2022 18:02:44 +0000 (18:02 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I467ac13c25862ebfd2f1844e9e6574796cdc3f66
Aidan Fabius [Mon, 25 Jul 2022 15:34:52 +0000 (11:34 -0400)]
Re-enable fence, event, barrier, and binary semaphore tests when timeline semaphores aren't supported
Components: Vulkan
VK-GL-CTS issue: 3847
Affects:
dEQP-VKSC.synchronization.op.*
dEQP-VKSC.synchronization2.op.*
dEQP-VK.synchronization.op.*
dEQP-VK.synchronization2.op.*
Change-Id: I95a0073b291f9288dcd2efae4a3302b3c98558a3
Arkadiusz Sarwa [Tue, 26 Jul 2022 14:48:51 +0000 (16:48 +0200)]
Fix barrier VK_AMD_buffer_marker tests
Affected tests:
dEQP-VK.api.buffer_marker.*
Components: Vulkan
VK-GL-CTS issue: 3854
Change-Id: I92571c00f1392652684ece1d4bbfb8122367e3ce
Matthew Netsch [Mon, 25 Jul 2022 15:53:12 +0000 (08:53 -0700)]
Update known conformance version for SC 1.0.1.0
Components: Vulkan, Framework
Affects:
dEQP-VK.api.driver_properties.conformance_version
Change-Id: I40ebdab676e26ffe85a328078c7af71b9c9d13b4
Matthew Netsch [Sat, 23 Jul 2022 12:39:00 +0000 (05:39 -0700)]
Merge dev/VK_EXT_shader_module_identifier to vk-gl-cts/main
Change-Id: I7d8c6e8e052eb202ade7e379d4f69447a77de9dd
Matthew Netsch [Sat, 23 Jul 2022 00:07:24 +0000 (17:07 -0700)]
Merge vk-gl-cts/main to vk-gl-cts/dev/VK_EXT_shader_module_identifier
Change-Id: I5c5b57c5d3a5440a57cb3e65e21e46ad7bfc34c3
Matthew Netsch [Sat, 23 Jul 2022 00:02:47 +0000 (17:02 -0700)]
Merge vk-gl-cts/dev/VK_EXT_multisampled_render_to_single_sampled to vk-gl-cts/main
Change-Id: I32561191732b150075421feed992e6900d4c10a4
Matthew Netsch [Fri, 22 Jul 2022 21:24:42 +0000 (14:24 -0700)]
Notice of withdrawal of Vulkan CTS 1.2.7.x
Components: Vulkan
Change-Id: I9f4151d1caabd0136da5badc464ee3489ce002f9
Matthew Netsch [Fri, 22 Jul 2022 18:51:12 +0000 (18:51 +0000)]
Merge "Merge vk-gl-cts/github-main into vk-gl-cts/main" into main
Matthew Netsch [Fri, 22 Jul 2022 18:21:20 +0000 (11:21 -0700)]
Update known conformance version for 1.3.3.1
Components: Vulkan, Framework
Affects:
dEQP-VK.api.driver_properties.conformance_version
Change-Id: I568ff655a7f279b5bad52dd2af13ddb9d5d55b12
Matthew Netsch [Fri, 22 Jul 2022 18:15:41 +0000 (11:15 -0700)]
Merge vk-gl-cts/main to vk-gl-cts/dev/VK_EXT_multisampled_render_to_single_sampled
Change-Id: Iec8f3117115dfbd2d250ba2a27db8f9037fb8818
Matthew Netsch [Fri, 22 Jul 2022 17:28:22 +0000 (17:28 +0000)]
Merge vk-gl-cts/github-main into vk-gl-cts/main
Change-Id: I5fa68b84497dbea3a6793b64067d207d7e1b5010
Matthew Netsch [Fri, 22 Jul 2022 17:00:20 +0000 (17:00 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I19b0c75e8e7ba0927e1b69a2dc4e1f2df1e952d1
Marcin Zając [Fri, 27 May 2022 13:54:27 +0000 (15:54 +0200)]
VKSC issues in api modules
VKSC related issues discovered transfer operations
Components: Vulkan
VK-GL-CTS issue: 3699
Affects:
dEQP-VKSC.api.copy_and_blit.*
dEQP-VK.api.copy_and_blit.*
Change-Id: I40bb0e9cf7b5a3fde30b32cd2ef7b79dabd66aae
Piotr Byszewski [Wed, 13 Jul 2022 14:37:12 +0000 (16:37 +0200)]
Fix validation errors for DR multiview tests
Some dynamic rendering multiview tests triggered validation errors
related to VkRenderingInfo::viewMask and ::flags parameters.
Components: Vulkan
VK-GL-CTS issue: 3822
Affects:
dEQP-VK.draw.dynamic_rendering.*multiview*
Change-Id: If7cc2cd503e0523c03883d2c607a0516afd2da22
Jeff Bolz [Tue, 19 Jul 2022 03:55:24 +0000 (22:55 -0500)]
Support commandPoolResetCommandBuffer==VK_FALSE for VulkanSC
When this property is false, resetting command buffers (either
explicitly or implicitly via vkBeginCommandBuffer) is not supported,
and the only way to reset is to reset the whole pool.
Add a helper method to the Context to reset a pool if needed, and call
it everywhere it's needed (at least, in tests that NVIDIA's
implementation supports).
Also add a missing VK_CHECK around calls to
vk{Reset,Begin}CommandBuffer.
Affects: dEQP-VKSC.*
Components: VulkanSC
VK-GL-CTS Issue: 3837
Change-Id: Ia2f80997103881c9b644b5a8124bef5d41ab5a43
Vidar Lilleboe [Tue, 5 Apr 2022 15:07:03 +0000 (17:07 +0200)]
Add tests for VK_EXT_image_compression_control_swapchain
Add tests for creating swapchain images with image compression control
extension.
New Tests:
dEQP-VK.api.image_compression_control.swapchain.*
Components: Vulkan
VK-GL-CTS issue: 3379
Change-Id: I9060110bf5af847109a87ffd35e061583b8ae9d4
Antto Mäkinen [Tue, 31 May 2022 10:36:09 +0000 (13:36 +0300)]
Add coverage of indirect dispatches on the compute queue
This commit adds variants of the existing tests for indirect dispatches
that use a compute queue without graphics capabilities.
VK-GL-CTS issue: 3525
New Tests:
dEQP-VK.compute.indirect_dispatch.gen_in_compute.*_compute_only_queue
dEQP-VK.compute.indirect_dispatch.upload_buffer.*_compute_only_queue
dEQP-VKSC.compute.indirect_dispatch.gen_in_compute.*_compute_only_queue
dEQP-VKSC.compute.indirect_dispatch.upload_buffer.*_compute_only_queue
Components: Vulkan
Change-Id: I591483a32e2ee3ffc7c19b75068e439f5e49c078
Ricardo Garcia [Fri, 8 Jul 2022 13:25:21 +0000 (15:25 +0200)]
Test dynamic patch control points without tessellation
Bind and use a pipeline with dynamic patch control points and no
tessellation before attempting to bind and use a proper pipeline with
dynamic patch control points and tessellation. The fact that the first
pipeline has no tessellation should not affect the dynamic state in the
command buffer, as needed and used by the second pipeline.
New tests:
dEQP-VK.pipeline.*.extended_dynamic_state.*.patch_control_points_extra_pipeline
Affected tests:
dEQP-VK.pipeline.*.extended_dynamic_state.*
Components: Vulkan
VK-GL-CTS issue: 3737
Change-Id: Icf25f2805b2bd9377210cb36b594b08033ab8e5c
Matthew Netsch [Fri, 22 Jul 2022 14:39:08 +0000 (10:39 -0400)]
Merge pull request #338 from PanGao-h/patch-1
Fix portability of python3
Matthew Netsch [Fri, 22 Jul 2022 14:23:20 +0000 (14:23 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I6fb90c4344a6cc3e27a8dfd95847738061a0a65a
Vidar Lilleboe [Tue, 5 Jul 2022 12:30:36 +0000 (14:30 +0200)]
Fix expected validation for image compression control tests.
Disabled bit is not required when quering supported modes.
Affects:
dEQP-VK.api.image_compression_control.*
Components: Vulkan
VK-GL-CTS issue: 3799
Change-Id: I33d118614083fc58ea453565f9f25d10875cdf8d
Ricardo Garcia [Tue, 12 Jul 2022 12:05:34 +0000 (14:05 +0200)]
Fix Linux build due to VK_EXT_metal_objects types
This commit adds new platform-specific types to the framework-generation
script so CTS code compiles again on Linux and other platforms.
No tests are affected by these changes.
Components: Vulkan
VK-GL-CTS issue: 3813
Change-Id: Id27dec6a07d78802b2a84ae741b208b27510da53
Peter Quayle [Wed, 29 Jun 2022 17:12:47 +0000 (18:12 +0100)]
Check depth stencil format support in FSR tests
Some FSR tests assume that VK_FORMAT_D32_SFLOAT_S8_UINT is supported
for depth stencil attachment use but the spec only guarantees that
one of VK_FORMAT_D32_SFLOAT_S8_UINT and VK_FORMAT_D24_UNORM_S8_UINT
are supported. This change adds a check to see if
VK_FORMAT_D32_SFLOAT_S8_UINT is supported and falls back to
VK_FORMAT_D24_UNORM_S8_UINT if it isn't.
Affects:
dEQP-VK.fragment_shading_rate.*.fragdepth.*
Components: Vulkan
Change-Id: Ie0b8992a2d94dcef7509618b64125a7c408461d6
Jeff Bolz [Tue, 12 Jul 2022 02:59:16 +0000 (21:59 -0500)]
Valid usage fixes for VulkanSC
For SC, have Deleter<VkDescriptorPool> call vkResetDescriptorPool to free
descriptor sets. Many tests rely on the pool freeing the sets.
Use Move<VkCommandBuffer> with Deleter<VkCommandBuffer> in more places to
avoid leaking command buffers. Add a helper function to allocate an array
of Move<VkCommandBuffer> using Deleter.
vktApiDescriptorSetTests.cpp: Use the same set layout for the pipeline layout
as for the set. Fixes VUID-vkCmdBindDescriptorSets-pDescriptorSets-00358.
vktBindingShaderAccessTests.cpp: Write one command buffer at a time, to
accommodate a VulkanSC limit.
Affects: all
Components: Vulkan
VK-GL-CTS Issue: 3746
VulkanSC Issues 160, 161
Change-Id: I57286f513e8d07369f5f0cf8e5941364ba08dd90
Jeff Bolz [Tue, 19 Jul 2022 03:27:32 +0000 (22:27 -0500)]
Reenable memory_model tests for VulkanSC
When SC was merged to main these were inadvertently ifdefed out,
but only the Amber tests need to be disabled.
Affects: dEQP-VKSC.memory_model.*
Components: VulkanSC
VK-GL-CTS Issue: 3839
Change-Id: I95c248c8dc92f923a2c6f1239ec85a1ae45799c0
Sławomir Cygan [Wed, 20 Jul 2022 12:21:44 +0000 (14:21 +0200)]
Set proper size in VkBufferCopy
Use size instead of VkBuffer as size in VkBufferCopy structure
Components: Vulkan
VK-GL-CTS Issue: 3841
Affects: dEQP-VK.ray_tracing_pipeline.acceleration_structures.copy_within_pipeline.gpu*
Change-Id: Ic5159bb637d4047b84c75338db2e7e360f99b563
PanGao-h [Fri, 22 Jul 2022 04:46:25 +0000 (12:46 +0800)]
Fix portability of python3
When running log_to_xml.py to convert qpa files under python3.10, the method `next()` is missing. Replace this with a built-in function that works for both python 2 and 3.
Matthew Netsch [Thu, 21 Jul 2022 18:30:59 +0000 (11:30 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.2 to vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I5c0bfb8a853ed3d97f2e10d90c1dcef6ab8580e2
Piers Daniell [Wed, 13 Jul 2022 23:39:25 +0000 (17:39 -0600)]
Fix the gl_TessLevelInner values in depth_bias_patch_list_tri_point.amber
This problem was unique to this amber file. The others in this folder
were already correct.
Affects:
dEQP-VK.draw.renderpass.depth_bias.depth_bias_patch_list_tri_point
Components: Vulkan
VK-GL-CTS issue: 3829
Change-Id: I6744a40f1bd7c927ea533dd9260ea1d56fb7c79a
Marcin Kańtoch [Thu, 14 Jul 2022 12:34:49 +0000 (14:34 +0200)]
graphics_pipeline_library missing on extension list
Test cases dEQP-VK.pipeline.fast_linked_library.* don't add
VK_EXT_graphics_pipeline_library into extension list
although it is using fast-link.
Component: Vulkan
VK-GL-CTS Issue: 3811
Affected tests:
dEQP-VK.pipeline.fast_linked_library.*
Change-Id: I6a12ee415b5be52671b0ce24b2f67f19e0c8b802
Matthew Netsch [Thu, 21 Jul 2022 17:40:00 +0000 (17:40 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I65295c4d9556742620ca49023dbf6389b957569d
Sai Kiran Korwar [Wed, 6 Jul 2022 10:43:34 +0000 (16:13 +0530)]
Fix vkwsi Display control tests
Tests that attempt to interact with display via the display
control extension must not be run when other windowing systems
have display access.
Return NotSupported if Display is unavailable because the
windowing system has access.
Affects:
dEQP-VK.wsi.display_control.display_power_control
dEQP-VK.wsi.display_control.register_display_event
Components: Vulkan
VK-GL-CTS issue: 3804
Change-Id: I59b78cf1dc8089d1741e1b23bc7391d30c85bebd
Matthew Netsch [Thu, 21 Jul 2022 17:15:10 +0000 (17:15 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I654e931f5f841201dc2f4d0d80c6edb7357ac90f
Matthew Netsch [Thu, 21 Jul 2022 16:44:06 +0000 (16:44 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I70f2eff0aee69bc3ed882d1ad4f6fc9ffb4b10b6
Matthew Netsch [Tue, 5 Jul 2022 20:21:31 +0000 (13:21 -0700)]
Limits buffer size to vulkan limit
Test was allocating buffer size larger than
sparseAddressSpace
Components: Vulkan
VK-GL-CTS Issue: 3803
Affects:
dEQP-VK.api.buffer.basic
Change-Id: Ia5a421c11804b60f05557d75e2140f1b2afb4c66
Matthew Netsch [Thu, 21 Jul 2022 16:12:34 +0000 (16:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ie7d7c989b3c81202f9e9dd2454b6087aa7cc49e1
michal_jakubek [Wed, 6 Jul 2022 04:17:26 +0000 (06:17 +0200)]
Fix for different values of subTexelPrecisionBits.
Affects: dEQP-VK.texture.conversion.snorm_clamp_linear.*
Components: Vulkan
VK-GL-CTS issue: 3724
Change-Id: I5ec839ea8169aa5749f6ff9e7b80298a475d6207
Matthew Netsch [Thu, 21 Jul 2022 15:45:40 +0000 (15:45 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I25a2d0cdd0a876568dede576e384d9ff8d1b93ea
Graeme Leese [Mon, 6 Jun 2022 14:00:35 +0000 (15:00 +0100)]
Backport CMake library change from master
Following the VKSC update the syntax used for CMake link libraries
includes a visibility specifier. Because CMake requires that all uses of
this command on a single target are consistent (either all with or all
without the specifier), having this mismatch between main and the
release branches creates an integration problem, so this backports that
part of the change. The qualifier added here is both the value used in
later changes and the default if nothing is specified, so the effect of
this change should be minimal.
Components: All (CMake build only)
Change-Id: I1c7e850d52de3cc0493a47bf36ad35bd55b05184
Jeff Bolz [Fri, 15 Jul 2022 15:47:38 +0000 (10:47 -0500)]
Fix imprecise occlusion query inheritance tests
Out of the four combinations of {precise query, imprecise query} X
{precise inheritance info, imprecise inheritance info}, three
combinations are valid under VUID-vkCmdExecuteCommands-commandBuffer-00103.
The two test cases that were supposed to use imprecise queries were
using precise.
Affects: dEQP-VK.api.command_buffers.record_query_imprecise*
Components: Vulkan
Change-Id: Idc8ceb2cf2d978c24c60c36ffa3406d9d16b55e6
Jeff Bolz [Tue, 19 Jul 2022 13:59:55 +0000 (08:59 -0500)]
Fix invalid usage in descriptor_indexing.input_attachment tests
Input attachments are only supported in the fragment stage. Tweak the
descriptorbinding's stageFlags to follow this rule.
Affects: dEQP-VK.descriptor_indexing.*
Components: Vulkan, VulkanSC
VK-GL-CTS Issue: 3840
Change-Id: Id6a2fac8563bfb8a83b71cc9dd0428fe9e3c46a6
Matthew Netsch [Fri, 15 Jul 2022 18:58:04 +0000 (18:58 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main
Change-Id: Iac76df59d2a646073234c23de8f0961996998c54
Matthew Netsch [Fri, 15 Jul 2022 18:29:58 +0000 (18:29 +0000)]
Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2
Change-Id: I0c3adedad43fdc5e21c36e42eff9339421f5aac7
Danylo Piliaiev [Mon, 20 Jun 2022 14:28:58 +0000 (10:28 -0400)]
fix fp64 dvec fmod precision strictness
Test case 978 fails on Turnip (Qualcomm):
it does mod(dvec2(14.50, 14.625), dvec2(1.5, 1.625)),
the expected result is (1, 0), but the actual result is (1, 1.625)
4ee7c26d6e81b0cbc80c483188511e18aef5148e tried to fix the strictness of this test,
but even in the general case of x = N * y the driver is allowed to return 0 for mod,
because mod is defined as a - b * floor(a/b) and OpenGL allows for some error in division
Affects:
KHR-GL46.gpu_shader_fp64.builtin.mod_dvec2
KHR-GL46.gpu_shader_fp64.builtin.mod_dvec3
KHR-GL46.gpu_shader_fp64.builtin.mod_dvec4
Change-Id: Ia7a43f2be8aa1eb320302e0ed422dc852f4de85c
janharald [Tue, 12 Jul 2022 14:12:11 +0000 (16:12 +0200)]
Avoid dependency on geometry shaders for VK_ARM_rasterization_order_attachment_access
Test cases for extension VK_ARM_rasterization_order_attachment_access had a dependency on
the geometryShader feature for access to gl_PrimitiveID. Since this is not a required
feature, this updates the test to avoid this dependency.
Components: Vulkan
Affects:
dEQP-VK.rasterization.rasterization_order_attachment_access.*
Change-Id: I088c5ae2f41da7123b95b30f88cefac650734338
michal_jakubek [Mon, 11 Apr 2022 06:55:55 +0000 (08:55 +0200)]
Global Priority Queue Families Tests
New tests:
dEQP-VK.synchronization.global_priority_transition.*
Components: Vulkan
VK-GL-CTS issue: 3392
Change-Id: I29586166be8e5f07110a7705bf264cc5b1b68ab3
Ricardo Garcia [Thu, 7 Jul 2022 12:19:54 +0000 (14:19 +0200)]
Test resetting queries after copying results
Commands operating on the same query should be executed in the order
specified in the command buffer and be synchronized automatically, so a
reset executed after copying the query results should have no effect on
the copied results.
New tests:
dEQP-VK.query_pool.statistics_query.reset_after_copy.*
dEQP-VKSC.query_pool.statistics_query.reset_after_copy.*
Affected tests:
dEQP-VK.query_pool.statistics_query.*
dEQP-VKSC.query_pool.statistics_query.*
Components: Vulkan
VK-GL-CTS issue: 3772
Change-Id: I91f499eba6d0d3868d594865232780889cbc8c72
Piotr Byszewski [Tue, 12 Jul 2022 14:51:53 +0000 (16:51 +0200)]
Remove some RT SkipTriangles tests
Some conformance tests set SkipTriangles flag together with
either CullBackFacingTri or CullFrontFacingTri. This is now
illegal and those tests were removed.
Components: Vulkan
VK-GL-CTS issue: 3647
Affects:
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.triangles.rayskiptriangles.*
Change-Id: I0122fec91deca58ddd093dfa6ea03f51983f77c9
Piotr Byszewski [Thu, 19 May 2022 15:43:20 +0000 (17:43 +0200)]
Enable FSR basic tests for Vulkan SC
This change enables fragment_shading_rate basic tests for
Vulkan SC. To reduce number of ifdefs in the code changes
in GraphicsPipelineWrapper were made. Additional wrapper
template class is used to wrapp structures that can't be
used in Vulkan SC tests. Because of that this change also
affects all VK_EXT_graphics_pipeline_library tests.
Components: Vulkan, Vulkan SC
VK-GL-CTS issue: 3684
Affects:
dEQP-VK.fragment_shading_rate.*
dEQP-VKSC.fragment_shading_rate.*
dEQP-VK.pipeline.*
dEQP-VKSC.pipeline.*
Change-Id: I19c470d71297723e173969543d28fe7154ef4909
Toni Merilehti [Fri, 10 Jun 2022 11:42:39 +0000 (14:42 +0300)]
Add tests for array comparisons
This CL adds tests that compare GLSL arrays of different precisions.
Iterates various array types.
New tests:
dEQP-GLES3.functional.shaders.arrays.compare.*
VK-GL-CTS Issue: 3674
Components: OpenGL ES
Change-Id: I38c7420be1fa2717fe3c45b894243411b5422629
yiyang fan [Thu, 9 Jun 2022 16:13:17 +0000 (00:13 +0800)]
Add Texture2D array test in which Texture2D array is rendered and
sampled.
Create an external texture 2d array with different buffer formats.
The test's behavior is like this:
1,create one 2d texture, and initialize the 2d texture with reference
2,sample the 2d texture, and then render the data into 2d array layer 0
3,compare the rendering result with reference
4,bind the 2d texture to fbo
5,sample the 2d texture array layer 0, and then render the data into the
2d texture
6,compare the rendering result with reference
New tests:
dEQP-EGL.functional.image.create.gles3_android_native_array_rgba4_render_sample_texture_array
dEQP-EGL.functional.image.create.gles3_android_native_array_rgb5_a1_render_sample_texture_array
dEQP-EGL.functional.image.create.gles3_android_native_array_rgb565_render_sample_texture_array
dEQP-EGL.functional.image.create.gles3_android_native_array_rgb8_render_sample_texture_array
dEQP-EGL.functional.image.create.gles3_android_native_array_rgba8_render_sample_texture_array
Components: EGL
Change-Id: I97d763f3ce2acce18e9bda9df5badb140e37c0cc
michal_jakubek [Fri, 17 Jun 2022 08:04:29 +0000 (10:04 +0200)]
Fix for attachment count in EXT_color_write_enable tests.
Affects:
dEQP-VK.pipeline.*.color_write_enable_maxa.*
Components: Vulkan
VK-GL-CTS issue: 3759
Change-Id: I104166abcb8169a43c6a4dc959b085585d4e2489
Piotr Byszewski [Thu, 7 Jul 2022 11:27:24 +0000 (13:27 +0200)]
Fix maxImageView(MipLevels/ArrayLayers) bug in SC
Certain tests request MAX_UINT32 number of mipmap levels and array
layers, which breaks VU and ends up failing the device creation.
This change resolves the issue by convert VK_REMAINING* values
into the device-specific maximums.
Components: Vulkan
VK-GL-CTS issue: 3622
Affects:
dEQP-VKSC.*
Change-Id: I3135f93a21d46cb8be00923a933f0645ead31c14
Sai Kiran Korwar [Wed, 6 Jul 2022 10:43:34 +0000 (16:13 +0530)]
Fix vkwsi Display control tests
Tests that attempt to interact with display via the display
control extension must not be run when other windowing systems
have display access.
Return NotSupported if Display is unavailable because the
windowing system has access.
Affects:
dEQP-VK.wsi.display_control.display_power_control
dEQP-VK.wsi.display_control.register_display_event
Components: Vulkan
VK-GL-CTS issue: 3804
Change-Id: I59b78cf1dc8089d1741e1b23bc7391d30c85bebd
Matthew Netsch [Fri, 15 Jul 2022 17:05:14 +0000 (17:05 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: If28f029620cb8af4b699c3979a95f5e492ce62ac
Graeme Leese [Thu, 23 Jun 2022 11:56:24 +0000 (12:56 +0100)]
Add image format in 2d_view_of_3d compute tests
The fragment version of these tests was already giving the format in the
shader, so adding it for the compute variant means that the test can run
on cores that don't support StorageImageWriteWithoutFormat.
Components: Vulkan
Affects: dEQP-VK.pipeline.*.image_2d_view_3d_image.compute.*
Change-Id: I34f4deace5ba4fbcb6e669a98dc3314ddd6b7ef5
Piotr Byszewski [Mon, 25 Apr 2022 12:14:16 +0000 (14:14 +0200)]
Refix extension data for EXT_texel_buffer_alignment
The original fix was broken by the SC merge, so this reapplies change
0e4b820 to up-to-date branches (that is, those following the merge).
VK-GL-CTS issue: 3564
Components: Framework, Vulkan
Affects: dEQP-VK.*
Change-Id: If1873b8292f1e79ef557876ebb7d8d9cf9d7de83
Matthew Netsch [Fri, 15 Jul 2022 16:21:00 +0000 (16:21 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ib544f0b79e3a27eb6892932f6d8cff817d6dcb08
Joe Withers [Thu, 7 Jul 2022 13:41:17 +0000 (14:41 +0100)]
Fix unused result in OpPtrEqual OpPtrNotEqual tests
These tests were storing the result of a prior comparison, instead of
the result of the final "Pointers to individual columns of row-major
matrices" test.
Components: Vulkan
Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.opptrequal.simple_variable_pointers_ptr_equal
dEQP-VK.spirv_assembly.instruction.spirv1p4.opptrnotequal.simple_variable_pointers_ptr_not_equal
Change-Id: I0320d887b1f9701037e7df6a605e51236892bbd8
Matthew Netsch [Fri, 15 Jul 2022 15:46:36 +0000 (15:46 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I4746c7728a783911f57a4a0307355384e5782e1f
wu jingxiang [Wed, 29 Jun 2022 10:06:00 +0000 (10:06 +0000)]
Modify Store Op setting
Set up VK_ATTACHMENT_LOAD_OP_DONT_CARE on VkAttachmentStoreOp. If m_numRenderPass equal 1.
Set up VK_ATTACHMENT_LOAD_OP_STORE on VkAttachmentStoreOp. If m_numRenderPass is greater than 1.
Affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*
Components: Vulkan
Change-Id: I226336ee9eeac5a9db14817cc8d1bec2f881ebbb
Matthew Netsch [Fri, 15 Jul 2022 15:22:13 +0000 (15:22 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I860e6b43aca52008fecc755bd0a377dca99e8927
Matthew Netsch [Fri, 15 Jul 2022 14:54:36 +0000 (14:54 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ia0fe8e8eb8f699fdcb15c85d129f5f237a60b02a
Fredrik Bergstrand [Thu, 7 Jul 2022 07:08:37 +0000 (09:08 +0200)]
Fix incorrect staging buffer size calculation
The dEQP-VK.api.image_clearing.* tests use a staging buffer to
pre-clear the images to a known value before each test. The size
of this buffer was previously determined by taking the size from the
VkMemoryRequirements obtained for the image. This fails if the size
required to store the image is less than the size required to store
the raw texel data in the buffer, which is later to be copied into
the image. This commit changes that and instead computes the size
of the staging buffer based on image extent, format and number of
layers.
Affects:
dEQP-VK.api.image_clearing.*
Components: Vulkan
VK-GL-CTS issue: 3809
Change-Id: I2b74697d54e11ddd7598299d57d02205bd2571d5
Matthew Netsch [Thu, 9 Jun 2022 18:56:58 +0000 (14:56 -0400)]
Add missing calls to vkResetCommandBuffer
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.header_bottom_address.*
Components: Vulkan
VK-GL-CTS Issue: 3802
Change-Id: Ieaf337e028db0bb64c3c954210a75bdda7e2e7b8
Matthew Netsch [Fri, 15 Jul 2022 14:26:51 +0000 (14:26 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I3f5a753e75050a8c66e4737bbd3eff861138ea60
Yifan Dai [Mon, 20 Jun 2022 11:29:19 +0000 (19:29 +0800)]
Fix missing support check in rtp test
The binding descriptor AS tests for rtp stage missed support check
when maxRayRecursionDepth equals 1
Affects:
dEQP-VK.binding_model.descriptor_update.acceleration_structure.
ray_tracing*
Components: vulkan
VK-GL-CTS issue: 3700
Change-Id: I8f2886aa60de2855799b43c27a853e903955f422
Graeme Leese [Fri, 24 Jun 2022 14:02:19 +0000 (15:02 +0100)]
Fix image feature checking in YCbCr view tests
The tests were using midpoint chroma sampling without checking for
support.
Components: Vulkan
VK-GL-CTS issue: 3601
Affects: dEQP-VK.ycbcr.plane_view.*
Change-Id: Iffd248b40c8d3c71cb2be28ad4fe7457bad25fa9
Alan Baker [Mon, 13 Jun 2022 13:06:25 +0000 (09:06 -0400)]
Fix control flow in SPIR-V test cases
Adapts three graphicsfuzz test cases to reflect changes in the SPIR-V
specification that tighten the rules for structured control flow.
Component: Vulkan
VK-GL-CTS Issue: 3612, 3613, 3615
Affected tests:
dEQP-VK.graphicsfuzz.control-flow-switch
dEQP-VK.graphicsfuzz.cov-dead-branch-func-return-arg
dEQP-VK.graphicsfuzz.nested-for-loops-with-return
Change-Id: I3b581dcdc685717421c7c7a7299bf378b3cc3b01
Thomas Aven [Mon, 13 Jun 2022 07:30:40 +0000 (09:30 +0200)]
Fix checkSupport for pipeline bind point tests
Ray tracing tests are unconditionally skipped if VK_KHR_push_descriptor
or VK_KHR_descriptor_update_template is not supported by the
implementation, as the support check logic is mistakenly checking only
the graphics and compute pipeline usages. Fix the support checks by
first checking which pipelines are used in the test.
Affects:
dEQP-VK.pipeline.monolithic.bind_point.*
Components: Vulkan
VK-GL-CTS issue: 3820
Change-Id: Ic6f0b78ca2d4d5415db03ca1186100494201548f
Matthew Netsch [Fri, 8 Jul 2022 16:20:11 +0000 (16:20 +0000)]
Merge vk-gl-cts/github-main into vk-gl-cts/main
Change-Id: Ic174cec9274d4a81a4e5a55d8018041fd482e0c0
Matthew Netsch [Fri, 8 Jul 2022 16:19:22 +0000 (16:19 +0000)]
Merge "Merge vk-gl-cts/vulkan-cts-1.3.3 to vk-gl-cts/main" into main
ziga-lunarg [Sat, 18 Jun 2022 23:14:24 +0000 (01:14 +0200)]
Fix duplicated file in CMakeLists
vktImageExtendedUsageBitTests cpp file is added twice instead of hpp
Components: Vulkan
VK-GL-CTS issue: 3780
Change-Id: I917d09e26554f9c01b73287fe5a6f9a7a77d5998
Lujin Wang [Tue, 14 Jun 2022 20:29:01 +0000 (13:29 -0700)]
Add back InvalidApiVersion test for Vulkan SC
Vulkan SC may only fail with VK_ERROR_INCOMPATIBLE_DRIVER if an incompatible
variant is requested.
Affects tests:
dEQP-VK.api.device_init.create_instance_invalid_api_version.basic
dEQP-VKSC.api.device_init.create_instance_invalid_api_version.basic
Components: Vulkan VulkanSC
VK-GL-CTS Issue: 3753
Change-Id: I9064cd814b3870d9514c964ed0e5e3b1c94a4708
Ricardo Garcia [Mon, 20 Jun 2022 14:25:29 +0000 (16:25 +0200)]
Fix initial color attachment layout in conditional rendering tests
Color attachments were never properly transitioned out of the undefined
layout into the general layout as specified in the render pass.
Affected tests:
dEQP-VK.conditional_rendering.*
Components: Vulkan
VK-GL-CTS issue: 3781
Change-Id: Iaa2dbe3badaa1ed6ab49c02259c7d0a626e60fde
Mikko Tiusanen [Tue, 31 May 2022 09:45:42 +0000 (12:45 +0300)]
Test additional robustBufferAccess requirements for vertex attribute
These tests verify that out of bounds vertex attribute access returns
invalid values within the same binding with different buffer memory
layouts, including both zero and non zero binding stride.
VK-GL-CTS Issue: 3067
New tests:
dEQP-VK.robustness.robustness1_vertex_access.out_of_bounds_*
Components: Vulkan
Change-Id: I727610ba60acc392af3ceb9ff72cc4325fccdb04
Ricardo Garcia [Tue, 7 Jun 2022 14:56:35 +0000 (16:56 +0200)]
Remove unneeded check for graphicsPipelineLibraryFastLinking
Graphics pipeline tests using libraries that are linked into final
pipelines without using CREATE_LINK_TIME_OPTIMIZATION_BIT_EXT were
checking if the graphicsPipelineLibraryFastLinking property was set to
true. This is not needed, because
(a) it's a property and not a feature and
(b) linking pipelines without link-time optimization is always allowed.
This commit removes the check and allows more graphics pipeline library
tests run on a wider variety of implementations.
In addition, checkPipelineLibraryRequirements was checking if the
implementation supported VK_KHR_pipeline_library, but this type of
dependencies are checked in dEQP-VK.info.device_extensions.
Affected tests:
dEQP-VK.*fast_linked_library*
VK-GL-CTS issue: 3743
Components: Vulkan
Change-Id: I4c67c195b87a4ab1c24d5d28caf54ea565551b14
Antto Mäkinen [Tue, 14 Jun 2022 12:57:31 +0000 (15:57 +0300)]
Test sRGB storage image writes
This commit adds coverage for "formatless" storage image writes
of sRGB images.
VK-GL-CTS issue: 3673
New Tests:
dEQP-VK.image.store.without_format.*.*_srgb
dEQP-VK.image.format_reinterpret.*.*_srgb_*
dEQP-VKSC.image.store.without_format.*.*_srgb
dEQP-VKSC.image.format_reinterpret.*.*_srgb_*
Components: Vulkan
Change-Id: I9b75ec7d5d08fecf3e03d4123cc7455fb56d2b1d
Ari Suonpaa [Thu, 24 Feb 2022 10:22:37 +0000 (12:22 +0200)]
Add random tests for dynamic rendering
VK-GL-CTS Issue: 3475
New tests:
dEQP-VK.dynamic_rendering.random.*
Components: Vulkan
Change-Id: If2f6b0945e5bf855a9510968a1bc19b62c1e9c47
Thomas Weber [Fri, 17 Jun 2022 11:55:25 +0000 (13:55 +0200)]
Add mandatory features check for VK_EXT_subpass_merge_feedback
Affects:
dEQP-VK.info.device_mandatory_features
Components: Vulkan
Change-Id: I8013c812045b3b30a1c0c97ddb71fb7c7a26b8fc