platform/upstream/efl.git
6 years agoelm_gen****: ensure the correct parent is set
Marcel Hollerbach [Tue, 12 Jun 2018 08:56:43 +0000 (10:56 +0200)]
elm_gen****: ensure the correct parent is set

fixes T6474

6 years agoefl_ui_focus_parent_provider_gen: do not accidently flatten the widgets
Marcel Hollerbach [Tue, 12 Jun 2018 08:40:38 +0000 (10:40 +0200)]
efl_ui_focus_parent_provider_gen: do not accidently flatten the widgets

in the provider we accidently flattend out the widget history by
returning the wrong parent. However, this flattening code was required
for the element focus code of the two generic widgets, so the item is
found for every widget, in every subtree.

6 years agoelm_genlist: remove duplicated smart callback description
Jaehyun Cho [Tue, 12 Jun 2018 06:40:54 +0000 (15:40 +0900)]
elm_genlist: remove duplicated smart callback description

This commit applies some missing changes of
4b4e830a64d210936e7bab231f5b196eb6bb0821.

Change-Id: I82fc818df497b5c819ecc4b7593334f06c05b7f7

6 years agopackaging: replace a symbol link of efl.manifest with the file itself
Wonki Kim [Thu, 17 May 2018 03:51:44 +0000 (12:51 +0900)]
packaging: replace a symbol link of efl.manifest with the file itself

a symbol link of efl.manifest makes a problem sometimes.
this commit replaces it with the file itself.

Change-Id: I7486f1f9415a3aa5693e9acf01341f60a70e8deb
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agoedje_cc: Fix coverity issue of acessing invalid memory.
subhransu mohanty [Fri, 4 May 2018 01:41:35 +0000 (10:41 +0900)]
edje_cc: Fix coverity issue of acessing invalid memory.

Details: As token pointer is assined with the tmp pointer we don't need to free the tmp anymore.

Change-Id: Ib315b28ab0a776fe36971df1d2bb4d6bc35d9f15

6 years agoedje_util: fix typo
Bowon Ryu [Wed, 9 May 2018 04:23:20 +0000 (13:23 +0900)]
edje_util: fix typo

Change-Id: I19c6698d21a0eac44c85768ed16b3d2ca846a7e0
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 years agoevas vg: get rid of memory leak.
Hermet Park [Tue, 12 Jun 2018 02:27:51 +0000 (11:27 +0900)]
evas vg: get rid of memory leak.

alloc mem only if it didn't alloc'd yet.

@fix

6 years agoedje: fix an issue "description.text.text" is not shown
Youngbok Shin [Mon, 11 Jun 2018 13:19:38 +0000 (16:19 +0300)]
edje: fix an issue "description.text.text" is not shown

Summary:
"description.text.text" is not shown after applying a patch for
supporting text translation of Textblock part.
@fix T6997

Test Plan:
- Try to show a TEXTBLOCK part which has built-in text.
ex)
  textblock {
     scale;
     desc { "default";
        text {
           style: "my_style";
           text: "You can't see this text without this patch";
        }
     }
  }

Reviewers: Hermet, subodh6129, herdsman

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T6997

Differential Revision: https://phab.enlightenment.org/D6257

6 years agoevas vg: fix wrong obj deletion.
Hermet Park [Mon, 11 Jun 2018 11:06:19 +0000 (20:06 +0900)]
evas vg: fix wrong obj deletion.

Cached roots are constructed out of canvas.
Means, they have no parents, generated efl_add_ref()
which requests to call efl_unref() instead of explicit deletion.

6 years agoeolian: silence a potentially uninitialized warning
Daniel Kolesa [Mon, 11 Jun 2018 11:07:23 +0000 (13:07 +0200)]
eolian: silence a potentially uninitialized warning

Compiler thinks mname might be used uninitialized, which is never
the case, because cl only exists if mname has been set. It still
creates an annoying warning though, so fix that.

6 years agoevas vg: fix broken vg rendering.
Hermet Park [Mon, 11 Jun 2018 07:23:28 +0000 (16:23 +0900)]
evas vg: fix broken vg rendering.

This fixes vg to connect node tree properly on copying nodes.

Vector rendering was broken when vg cache tries to reconstruct the scene-graph
tree on copying from the original cached one. Exactly, nodes lost parents on
copying. Here it fixes the lost links of the scene-graph tree.

@fix T6993

6 years agoedje: fix edje_part_helpers refcounting
Marcel Hollerbach [Sun, 10 Jun 2018 14:30:07 +0000 (16:30 +0200)]
edje: fix edje_part_helpers refcounting

Summary:
the reference from efl_reuse was forgotten & the parent relation was not
correctlty setted, which led to the fact that NOREF was never emitted.
This caused that thte object never really was destructed probebly, and
thus the del_interceptor_cb was not executed, and the object simply
leaked.

The test checks that those properties are correctly set, additionally a
error is printed in the efl code when a part has not the expected
reference properties. This also enforces errors when users are doing
wrong things with objects returned by efl_part.

Reviewers: ManMower, zmike

Reviewed By: zmike

Subscribers: cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6254

6 years agoexamples: fix efl_model parent loop add
Larry Lira [Thu, 7 Jun 2018 21:50:48 +0000 (18:50 -0300)]
examples: fix efl_model parent loop add

6 years agoelm: fix efl_model property_get and children_slice_get in views
Larry Lira [Thu, 7 Jun 2018 21:44:37 +0000 (18:44 -0300)]
elm: fix efl_model property_get and children_slice_get in views

6 years agoEio: fix eio_model children_slice_get all
Larry Lira [Thu, 7 Jun 2018 21:41:48 +0000 (18:41 -0300)]
Eio: fix eio_model children_slice_get all

6 years agoecore_con : Fix that null pointer access for segmentation fault
JunsuChoi [Thu, 7 Jun 2018 14:49:42 +0000 (10:49 -0400)]
ecore_con : Fix that null pointer access for segmentation fault

Summary:
"cl->svr" was to be null on line 281.
This problem occurred from 384f30c8ecc9.
Replacing "cl->svr" with "svr" corrects the error
while preserving the changes in 384f30c8ecc9.

Test Plan: N/A

Reviewers: #committers, cedric, Hermet, zmike

Subscribers: bowonryu, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6255

Change-Id: Idaf69e4ee4be9cd4a87476a8db7d76b04f677c5f

6 years agoedje: fix a regression error by 7fb47fc064b8f429242b4d5cdf57071475087821.
Hermet Park [Thu, 7 Jun 2018 10:34:46 +0000 (19:34 +0900)]
edje: fix a regression error by 7fb47fc064b8f429242b4d5cdf57071475087821.

That shouldn't be touched, just confused by its name.

6 years agocanvas vg: move a comment to right place.
Hermet Park [Thu, 7 Jun 2018 10:14:30 +0000 (19:14 +0900)]
canvas vg: move a comment to right place.

no any logic changes.

6 years agoedje: code refactoring for readibility.
Hermet Park [Thu, 7 Jun 2018 08:53:12 +0000 (17:53 +0900)]
edje: code refactoring for readibility.

collection.part is too ambigious, since group has parts as well.
Normally we regard it as "name" (of group) instead of part.

6 years agoedje_cc: fixup edje_collections_lookup hash ids during collection pruning
Mike Blumenkrantz [Thu, 7 Jun 2018 08:29:46 +0000 (17:29 +0900)]
edje_cc: fixup edje_collections_lookup hash ids during collection pruning

Summary:
unused groups are pruned during this stage of edje_cc, and it becomes
necessary to update the values in this hash in order to maintain the
key:value pairing between the Edje_Part_Collection_Directory_Entry and
its corresponding Edje_Part_Collection so that lookups return consistent
results after pruning has completed

@fix

Reviewers: cedric, Hermet

Reviewed By: Hermet

Subscribers: Hermet, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6041

6 years agoeo: add testcase for basic eventing and lifetime checking
Marcel Hollerbach [Wed, 6 Jun 2018 11:50:11 +0000 (13:50 +0200)]
eo: add testcase for basic eventing and lifetime checking

checks if a object is really freed, even under error conditions.

The test suite now has the following timing:

TC TIME Eo general: 0.035713
SUITE TIME(8227) Eo: 0.036046

Differential Revision: https://phab.enlightenment.org/D6253

6 years agoeo: unref compensate is not requires here
Marcel Hollerbach [Wed, 6 Jun 2018 12:42:13 +0000 (14:42 +0200)]
eo: unref compensate is not requires here

this check caused a leaked reference.

Eo objects are having two reference counters a internal and external
one. The external one can be manipulated via efl_ref / efl_unref. The
internal one can be manipulated via _efl_ref _efl_unref.

The external reference counter is keeping a internal reference by the
time the external counter is > 0. When the external counter reaches ==
0 this internal reference is given up with the _efl_unref call in
eo.c:1928.

However, checking unref_compensate in the block in line 1950 leads that
to the leak that this internal reference is not given up at the pointer
user_refcount reaches exactly 0. This check also does not prevent
anything, the object is kept alive anywayys as the efl_unref method
keeps its private internal reference.

This lead to leaks in efl_device_* classes, parts have not been
destructed correctly.

Differential Revision: https://phab.enlightenment.org/D6252

6 years agoevas map: an alternative patch for map rendering issue.
Hermet Park [Thu, 7 Jun 2018 05:50:41 +0000 (14:50 +0900)]
evas map: an alternative patch for map rendering issue.

This is an alternative patch for 9fcd03952ee51d34871794cb95585f3e589a3bb9.

Since canvas map rendering sequence is quite complex,
Not easy to estimiate the logic sequence by all scenarios.

The brings me to fix the code case by case.

6 years agoevas: modify return value for compatibility 10/181310/1
Jaeun Choi [Wed, 16 May 2018 11:33:58 +0000 (20:33 +0900)]
evas: modify return value for compatibility

@tizen_only

Change-Id: I33b8215113ce5761289454e85636ab40d5b17191

6 years agoevas: maintian return value of deprecated APIs for compatibility 09/181309/1
Jaeun Choi [Wed, 16 May 2018 08:20:50 +0000 (17:20 +0900)]
evas: maintian return value of deprecated APIs for compatibility

@tizen_only

Change-Id: I1216b7cdca1b559ad2a73c022f846494a8642768

6 years agoevas: modify return value for compatibility 08/181308/1
Jaeun Choi [Tue, 15 May 2018 12:34:55 +0000 (21:34 +0900)]
evas: modify return value for compatibility

@tizen_only

Change-Id: If19d0cc76c8e80feeebf30a7f7d157762687da57

6 years agoelm_spinner: Fix typo
Jaehyun Cho [Mon, 11 Jun 2018 11:11:42 +0000 (20:11 +0900)]
elm_spinner: Fix typo

Change-Id: Ife0fd94116220b0f91e64d6ba23e9f42a024c00b

6 years agoelm_spinner: Call changed callback when value changed in min_max_set() API. 57/181257/2
Woochan Lee [Thu, 17 May 2018 06:59:59 +0000 (15:59 +0900)]
elm_spinner: Call changed callback when value changed in min_max_set() API.

@tizen_feature

Change-Id: I4bcc15422852b3c9aa5411c4a2a3575bf65ce697

6 years agoelm_focus: Restore legacy focus of tizen genlist 56/181256/2
Jaehyun Cho [Mon, 11 Jun 2018 08:17:43 +0000 (17:17 +0900)]
elm_focus: Restore legacy focus of tizen genlist

This commit is a part of missing code of
2a28a50a105b2262e84388a45fc8af04c2b48e15

@tizen-fix

Change-Id: Ia791e204043aeafc892a04f8add8632c2de35c48

6 years agoefl_ui_dnd: fix the TC break 00/181200/2
Taehyub Kim [Fri, 4 May 2018 08:47:56 +0000 (17:47 +0900)]
efl_ui_dnd: fix the TC break

Change-Id: I848d2c6e1530a8ad1141d1d7024525c5d09456c9

6 years agocbhm_helper: fixed the memory leak for coverity 99/181199/2
Taehyub Kim [Fri, 4 May 2018 02:08:03 +0000 (11:08 +0900)]
cbhm_helper: fixed the memory leak for coverity

Change-Id: I1de8488d19bf9de1ce3bac7dad147ff5e7da1445

6 years agoeldbus: remove EINA_DEPRECATED for removing warning message 98/181198/2
Taehyub Kim [Fri, 11 May 2018 08:06:46 +0000 (17:06 +0900)]
eldbus: remove EINA_DEPRECATED for removing warning message

Change-Id: I69da5509a8eafd29fcdeef69b9d85170cfd477ce

6 years agoeldbus: deprecate eldbus APIs 97/181197/2
Taehyub Kim [Mon, 2 Apr 2018 12:48:36 +0000 (21:48 +0900)]
eldbus: deprecate eldbus APIs

Change-Id: If2dd327f94a1cc29c7f600778553080337b013d0

6 years agoevas_render: disable render cache feature 83/181183/3
Shinwoo Kim [Thu, 10 May 2018 06:39:04 +0000 (15:39 +0900)]
evas_render: disable render cache feature

Following commit added render cache feature.

   commit 69cb85aaca1e8d6bd7ef070fc1f2a3cb78b838f6
   Author: Carsten Haitzler (Rasterman) <raster@rasterman.com>
   Date:   Sat Nov 26 10:47:34 2016 +0900

       evas render - cache object arrays rto avoid processing them in phase1

It has an issue. If a smart object does not changed...
i.e. obj_changed in _evas_render_phase1_object_process does not changed,

then _evas_render_phase1_object_(no_)changed_smart does not call
_evas_render_phase1_object_process using its smart members at all.

So even though there is a changed smart member object, the object cannot be
rendered. The following would be the issue case.

smart object A       - changed: 0 -> 0
smart member B of A  - changed: 1 -> 1
smart member C of B  - changed: 0 -> 1

Moreover, the changed value of C is changed but it cannot make change the
value of A, because the value of B is aready 1. see evas_object_change.

@tizen_only

Change-Id: Ifaf9b4d58f2c87cac79a3b37102955d4877ea9bd

6 years agoefl: generate efl-locale package when generating elementary package 71/181071/2
Jongmin Lee [Wed, 23 May 2018 01:25:14 +0000 (10:25 +0900)]
efl: generate efl-locale package when generating elementary package

@tizen_fix

Change-Id: I72485bcdb355e69adbce1cd226abf6b04fcceba1

6 years agoefl: use tizen_profile_name build macro instead of TIZEN_PRODUCT_TV 67/181067/2
Jongmin Lee [Fri, 11 May 2018 08:04:31 +0000 (17:04 +0900)]
efl: use tizen_profile_name build macro instead of TIZEN_PRODUCT_TV

replacing TIZEN_PRODUCT_TV build macro into tizen_profile_name build macro
since TIZEN_PRODUCT_TV build macro is deprecated.

@tizen_fix

Change-Id: I86b32e28083b235d999f172826a4c20bdf898759

6 years agoefl: support elementary optional build 66/181066/2
Jongmin Lee [Thu, 10 May 2018 01:26:00 +0000 (10:26 +0900)]
efl: support elementary optional build

add --with-elementary=[elm/efl/both] to configure option.
By default, "--with-elementary=both" option is applied.

@tizen_feature

Change-Id: I34d00cb30063087526602a355287a0495e2723f9

6 years agoElementary: Move eldbus dependency from public header to private header 64/181064/2
Jongmin Lee [Mon, 30 Apr 2018 03:59:42 +0000 (12:59 +0900)]
Elementary: Move eldbus dependency from public header to private header

Since eldbus is deprecated and removed in Tizen for the security reason,
Eldbus header dependency in Elementary public header should be removed
in order to hide it to application developer who use Tizen SDK.

@tizen_fix

Change-Id: I4f92529fc7185c17e2700c576ef3fe40a1a33120

6 years ago efl_ui_win: fix double free bug related with fake window 75/181175/2
Jiyoun Park [Fri, 18 May 2018 08:14:34 +0000 (17:14 +0900)]
   efl_ui_win: fix double free bug related with fake window

   fake window should call ecore_wl2_window_free only when it make ecore_wl2_window by itself

Change-Id: I2f8d4bba93aea2f66cf9a25a7dfbbe2471cfcaa8

6 years agoecore_con: Check valid port number 77/181177/2
Myoungwoon Roy, Kim [Fri, 11 May 2018 05:25:31 +0000 (14:25 +0900)]
ecore_con: Check valid port number

Add a handling code to check valid port number input

Change-Id: I6655202dd5e2b3aff674d900c2917a5005a1f776

6 years agoevas_out: Restores evas_out APIs 72/181172/1
Myoungwoon Roy, Kim [Thu, 10 May 2018 09:57:44 +0000 (18:57 +0900)]
evas_out: Restores evas_out APIs

Restores evas_out_add, evas_output_del, evas_output_view_get APIs for backward compatibility.

Change-Id: Ia4b44f222ee13df166337a4ad93c0222349cf7b6

6 years agoefl_ui_layout: fix build failure casued by renamed Eo class
Youngbok Shin [Fri, 8 Jun 2018 10:16:53 +0000 (19:16 +0900)]
efl_ui_layout: fix build failure casued by renamed Eo class

@tizen_fix

Change-Id: Ifa8555c5fa6eecd80db964dc7aaf7384613f6133

6 years agoentry: fix build break caused by recent changes of Eo
Youngbok Shin [Fri, 8 Jun 2018 10:09:43 +0000 (19:09 +0900)]
entry: fix build break caused by recent changes of Eo

Change-Id: I5620b0cb01f054f2ca970d6de945a19f76b1c31b

6 years agoelementary: add elm_entry_cursor_coord_set/get
Youngbok Shin [Tue, 5 Jun 2018 04:32:33 +0000 (13:32 +0900)]
elementary: add elm_entry_cursor_coord_set/get

@tizen_feature

Change-Id: I9018f8c8d0dcddf2e4ae22aa521b8327f1a5bf9a

6 years agoedje: send cursor,changed signal when cursor is changed by function call
Youngbok Shin [Tue, 11 Jul 2017 11:30:53 +0000 (20:30 +0900)]
edje: send cursor,changed signal when cursor is changed by function call

@tizen_fix

Change-Id: Ic905c59a3adc4bf7bc528d5ac3f916478c383866

6 years agoelementary_tizen: remove unreachable code
Youngbok Shin [Fri, 18 May 2018 09:26:08 +0000 (18:26 +0900)]
elementary_tizen: remove unreachable code

@tizen_fix

Change-Id: I2b1da0c190dcfc392e9b2721d6b2caa99239a0b3

6 years agoelementary: fix wrong non-void return value of void function
Youngbok Shin [Fri, 18 May 2018 09:01:45 +0000 (18:01 +0900)]
elementary: fix wrong non-void return value of void function

@tizen_fix

Change-Id: I5e6085c6d85b2f8cb6f61fa70c09c0c5632b2de7

6 years agoelementary image: fix elm_image_smooth_scale_* TC fails
Youngbok Shin [Tue, 15 May 2018 06:24:38 +0000 (15:24 +0900)]
elementary image: fix elm_image_smooth_scale_* TC fails

It was caused by recent change for fixing no_scale issue.

@tizen_fix

Change-Id: Ie95ecae86ba56ef24f2307fbbd42efb0acaba187

6 years agoelementary layout: fix elm_layout_text_set to return proper result
Youngbok Shin [Mon, 14 May 2018 05:26:49 +0000 (14:26 +0900)]
elementary layout: fix elm_layout_text_set to return proper result

It fixes API breaks of upstream EFL.

@tizen_fix

Change-Id: I8b917a7bc0fed8373d2c09f7dfcf61fe1eab4789

6 years agoelementary entry: support legacy focused/unfocused callback calls
Youngbok Shin [Mon, 14 May 2018 05:06:41 +0000 (14:06 +0900)]
elementary entry: support legacy focused/unfocused callback calls

It is needed to replace focus callbacks of reverted new focus feature.

@tizen_fix

Change-Id: Iffed6f8e09a636575b83ab61b93fb956a2480046

6 years agoelementary label: restore label size calc logic from Tizen 4.0
Youngbok Shin [Fri, 11 May 2018 05:27:36 +0000 (14:27 +0900)]
elementary label: restore label size calc logic from Tizen 4.0

@tizen_fix

Change-Id: Ic636e617a87a23b8572467d32df063b4a58c041b
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
6 years agoevas text: update paragraph direction before layouting its text
Youngbok Shin [Mon, 13 Nov 2017 06:22:33 +0000 (15:22 +0900)]
evas text: update paragraph direction before layouting its text

It fixes the following issue.
 - Edje's alignment is not updated when paragraph direction is changed.

@tizen_fix

Change-Id: Ic7b5e35d82e2e6615f5dd7ebc39667611ca400e0
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
6 years agoevas textblock: fix default values for text alignment
Youngbok Shin [Wed, 9 May 2018 04:58:33 +0000 (13:58 +0900)]
evas textblock: fix default values for text alignment

From upstream EFL, the text alignment default values are not handled properly.

@tizen_fix

Change-Id: Id5d14783ac5ac25a5116cc48281509d08bc924d5

6 years agoelementary: fix layout_part_cursor things and eo hierarchy of part_box/part_table
Youngbok Shin [Tue, 8 May 2018 13:16:30 +0000 (22:16 +0900)]
elementary: fix layout_part_cursor things and eo hierarchy of part_box/part_table

All elm_layout_part_cursor_* had worked at box and table parts.
After applying new interfaces, all elm_layout_part_cursor_* ignored box/table parts.
It caused a lot of problems. I don't know why part_box/part_table didn't inherit Efl.Ui.Part.
But, it needs Efl.Ui.Part for keeping backward compatiblity.

@tizen_fix

Change-Id: I35152f46d14b6d9f71ad328d0de1d4b8e8e957ce

6 years agoelementary: remove warning message from paragraph_direction_set/get
Youngbok Shin [Wed, 2 May 2018 07:00:43 +0000 (16:00 +0900)]
elementary: remove warning message from paragraph_direction_set/get

@tizen_fix

Change-Id: Id478c1134e812535c4e71ed4b53195431b82cc36

6 years agoelementary cnp: fix duplicated string memory issue
Youngbok Shin [Mon, 30 Apr 2018 06:22:37 +0000 (15:22 +0900)]
elementary cnp: fix duplicated string memory issue

The eina_slice_dup() function does not take care of NULL termination of
a duplicated memory. It caused wrong copy&paste results.

@tizen_fix

Change-Id: I6778ad3c68c508fc391c1bf961501ec65909febc

6 years agoecore_wl2_window: modified window shutdown location. 28/181128/1
Hosang Kim [Thu, 24 May 2018 08:06:09 +0000 (17:06 +0900)]
ecore_wl2_window: modified window shutdown location.

_ecore_wl2_window_shutdown should not be called
before _ecore_wl2_init_count is 0.
@fix

Change-Id: Idc3e39ee4da750d6c3189345fff1b9a44d5c7b76

6 years agoecore_con_url: disable unused initialization. 27/181127/1
Hosang Kim [Thu, 17 May 2018 12:59:24 +0000 (21:59 +0900)]
ecore_con_url: disable unused initialization.

@tizen_fix

Change-Id: Ib10782eaff0b142df0523c7c958d37bf344d1381

6 years agoefl_ui_win: apply precreated window. 26/181126/1
Hosang Kim [Fri, 8 Jun 2018 09:48:31 +0000 (18:48 +0900)]
efl_ui_win: apply precreated window.

@tizen_feature

Change-Id: Ic5b239288f8506a3027006d500799d879422ce2c

6 years agoecore_event: fix backword compatibility bug for ecore event handler 25/181125/1
Hosang Kim [Mon, 14 May 2018 09:44:00 +0000 (18:44 +0900)]
ecore_event: fix backword compatibility bug for ecore event handler

add missing condition
@tizen

Change-Id: I269362a1e773211e28e458a23b2b38fc04cfd07f

6 years agogenlist : refactoring on_focus_update as none legacy case 93/181093/3
SangHyeon Lee [Thu, 17 May 2018 02:03:40 +0000 (11:03 +0900)]
genlist : refactoring on_focus_update as none legacy case

Change-Id: Ic5655c568aa05abaa65b36d67f6a33a41f5dfd86
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agotizen ctxpopup: fix backward compatibility for "default" name part 16/181116/2
YeongJong Lee [Wed, 23 May 2018 12:24:37 +0000 (21:24 +0900)]
tizen ctxpopup: fix backward compatibility for "default" name part

If you use legacy content/text set/get/unset with "default" part name,
_elm_layout_part_aliasing_eval change the part name to "elm.swallow.content".
Because internal _content_set/get/unset checked only "default" string,
legacy content/test set/get/unset with "default" part name was not working.

This patch fixes that bug.

Change-Id: I8400a47e6e9d159066ea022cc14945212381b084

6 years agoelc_ctxpopup: use data(ctxpopup) instead of obj(edje) 15/181115/2
YeongJong Lee [Thu, 10 May 2018 11:46:05 +0000 (20:46 +0900)]
elc_ctxpopup: use data(ctxpopup) instead of obj(edje)

Change-Id: Ib43f4a5c32b73ee6086ecc2418cdf5613b32e1fc

6 years agoecore_device: fix migration issue. 10/181110/1
Hermet Park [Fri, 8 Jun 2018 07:35:25 +0000 (16:35 +0900)]
ecore_device: fix migration issue.

It doesn't allow efl_add() with no parent.
That case, use efl_add_ref() instead.

Change-Id: I380baa798d2a3199e8651e2f8c6542a42fe2eeab

6 years agomigration: fix crash in elm_genlist_clear 74/180974/4
Jaehyun Cho [Thu, 7 Jun 2018 05:02:02 +0000 (14:02 +0900)]
migration: fix crash in elm_genlist_clear

Change-Id: I17f66605d732d6d67bfec332a75561ea921dcdb2

6 years agoUi layout: fix another text retrieval line of code
Daniel Hirt [Thu, 1 Feb 2018 17:24:44 +0000 (19:24 +0200)]
Ui layout: fix another text retrieval line of code

This is a follow-up to a44ae48df811ff2bd085da86db1688c0f387efc4.Need to
undo the markup_get call, so that the correct code path
(_efl_ui_layout_text_set) is used. Legacy checks are in that code path.

ref T6642

6 years agoecore_con : Fix that null pointer access for segmentation fault 45/181045/2
JunsuChoi [Fri, 8 Jun 2018 00:00:56 +0000 (09:00 +0900)]
ecore_con : Fix that null pointer access for segmentation fault

Summary:
"cl->svr" was to be null on line 281.
This problem occurred from 384f30c8ecc9.
Replacing "cl->svr" with "svr" corrects the error
while preserving the changes in 384f30c8ecc9.

Test Plan: N/A

Reviewers: #committers, cedric, Hermet, zmike

Subscribers: bowonryu, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6255

Change-Id: I91c2cf9db48e510a4f6d7c9373de8dedcc634b21

6 years agoeo: Turn thread-validation off for unstable Tizen 5.0 apps which are violating thread... 91/181091/1
Hermet Park [Fri, 18 May 2018 06:51:43 +0000 (15:51 +0900)]
eo: Turn thread-validation off for unstable Tizen 5.0 apps which are violating thread-safety.

Eo has gotten more strict-check for thread violiation API calls.
Since Tizen 5.0, many apps(which violates EAPI thread safety rules) unexpectedly became unstable cause of thread-validation.
We disable this function for now but wish to remove this temporary code in the near future when apps are ready to go.

Change-Id: Ibbd99d3b26609fca23fd4c5bd029e67f63e3a830

6 years agoefl_ecore_input_device: unify efl_ecore_input_device in efl_input_device. 90/181090/1
Hermet Park [Thu, 26 Apr 2018 11:20:37 +0000 (20:20 +0900)]
efl_ecore_input_device: unify efl_ecore_input_device in efl_input_device.

Efl_Ecore_Input_Device was introduced wrongly in merging upstream efl.

First, conceptually, efl interface should not allow Ecore.
This is totally wrong in interface design.

Second, Efl_Ecore_Input_Device conceptually same with Efl_Input_Device.
We don't need both interfaces. Even their bodies are perfectly same.

Third, EFl_Ecore_Input_Device is not compatible with Efl_Input_Device,
Whole Events in efl will be passing through with Efl_Input_Device interface,
but their classes are different, Eo will fault in type checking,
Efl_Ecore_Input_Device(or Ecore_Device) won't be passed properly.

All in all, current Efl_Ecore_Input_Device just breaks system and useless.

Change-Id: I276761e67d598457087bd2e3e06f44e58161427f

6 years agoecore_con: update doc. 89/181089/2
Hermet Park [Wed, 2 May 2018 06:13:22 +0000 (15:13 +0900)]
ecore_con: update doc.

fix invalid parameter name in doc.

Change-Id: I5d9d27f0fcb412384210af667d6803efc6105fe5

6 years agoelm_spinner: fix wrong use of ev 34/181034/2
WooHyun Jung [Wed, 25 Apr 2018 11:12:05 +0000 (20:12 +0900)]
elm_spinner: fix wrong use of ev

Legacy ev should be gotten from efl_input_legacy_info_get.

@tizen_fix

Change-Id: I9c4d9ab2a61297f152fcc2eeeabf09ccc3251792
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
6 years agofocus: onscreen_is should not be checked for keeping compatiblity 33/181033/2
WooHyun Jung [Tue, 8 May 2018 06:49:58 +0000 (15:49 +0900)]
focus: onscreen_is should not be checked for keeping compatiblity

@tizen_fix

Change-Id: If81e7b3e49d6813f3d45237fd9f25c2511cc6cbd
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
6 years agoefl_ui_widget: fixed wrong character in _elm_widget_edje_class_get 49/181049/1
Jeonghyun Yun [Wed, 23 May 2018 01:45:44 +0000 (10:45 +0900)]
efl_ui_widget: fixed wrong character in _elm_widget_edje_class_get

@tizen_fix

Change-Id: I61bfdc2f331e227b0b7da33c4519a6c81c046cee
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agoelementry: add missing item class and add exception handling code for edjc_class... 48/181048/1
Jeonghyun Yun [Fri, 11 May 2018 02:56:57 +0000 (11:56 +0900)]
elementry: add missing item class and add exception handling code for edjc_class parse

@tizen_fix

Change-Id: I3341c98052d80e2cdbac5cd5468fa82ee70882bd
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
6 years agoelementary: add missing item class names and fix edje_class parse rule for legacy 47/181047/1
Youngbok Shin [Fri, 4 May 2018 06:41:35 +0000 (15:41 +0900)]
elementary: add missing item class names and fix edje_class parse rule for legacy

@tizen_fix

Change-Id: I480cd5a4bac02ba11d806cef25bcdc2d92d74f7a

6 years agoelementary widget: fix missing legacy type for Gesture_Layer 46/181046/1
Youngbok Shin [Mon, 30 Apr 2018 07:52:14 +0000 (16:52 +0900)]
elementary widget: fix missing legacy type for Gesture_Layer

There is a missing legacy type in the table: Elm.Gesture_Layer => Elm_Gesture_Layer

@tizen_fix

Change-Id: I34f002fc037c1453494659518a101087704357d0

6 years agoelm_interface_scrollable: fix wrong use of animator_del 32/181032/1
WooHyun Jung [Wed, 9 May 2018 15:48:54 +0000 (00:48 +0900)]
elm_interface_scrollable: fix wrong use of animator_del

Change-Id: I7aadec676120a01a53e072952ee085d5b90b246b
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
6 years agoelm_panes : Add deprecated version for deprecated APIs 28/181028/2
JunsuChoi [Thu, 17 May 2018 06:37:22 +0000 (15:37 +0900)]
elm_panes : Add deprecated version for deprecated APIs

   Deprecated APIs since 5.0
   elm_panes_content_left_unset
   elm_panes_content_right_unset

Change-Id: I5dee4f4c4be280b15a996fe4f2af12acad64180c

6 years agoefl_access: Support legacy API for elm_atspi_text 27/181027/2
JunsuChoi [Wed, 9 May 2018 10:10:28 +0000 (19:10 +0900)]
efl_access: Support legacy API for elm_atspi_text

Change-Id: Id65cec0f250b8105ad8278763c75d57ea03c5498

6 years agoelm_conform: fix condition for recalculating vkbd area. 29/181029/1
Hosang Kim [Mon, 4 Apr 2016 09:37:27 +0000 (18:37 +0900)]
elm_conform: fix condition for recalculating vkbd area.

Vkbd geometry is not (0, 0, 0, 0), when vkbd is hidden in Wayland.

@tizen_fix

Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: Icc481af1580d735480d69410391b8072fdbf46da

6 years agoelm_conform: support different thing in Tizen 3.0 24/181024/1
Hosang Kim [Mon, 9 May 2016 10:34:22 +0000 (19:34 +0900)]
elm_conform: support different thing in Tizen 3.0

In Tizen 2.4, virtual keyboard size is 0 when virtual keyboard is off.
But it is different in Tizen 3.0. So I added one condition before
calculating keyboard size.

Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: Id76b80bead0bfaf88d681bff45eda325e8818e98

6 years agoelm_focus: Restore legacy focus 98/180998/3
YeongJong Lee [Thu, 7 Jun 2018 04:16:13 +0000 (13:16 +0900)]
elm_focus: Restore legacy focus

@tizen-fix

Change-Id: I3b270f4998386a39818635f8cc8f47011d2059ea

6 years agoeo: _efl_unref correctly
Marcel Hollerbach [Wed, 6 Jun 2018 19:20:11 +0000 (14:20 -0500)]
eo: _efl_unref correctly

Summary:
this function calls _efl_ref in the beginning, so _efl_unref them in the
end. This fixes bugs where wrong evas_object_del is called to often,
which would lead to the internal refcount rising instead of getting to
0.

Reviewers: cedric, zmike, stefan_schmidt, q66

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6246

6 years agoecore: Use poller instead of animator for mem stats
Derek Foreman [Wed, 6 Jun 2018 17:40:56 +0000 (12:40 -0500)]
ecore: Use poller instead of animator for mem stats

Summary:
Animators shouldn't be used as a general purpose timer mechanism,
we could use a timer, but a poller seems to make more sense as
it limits the impact of the instrumentation on the code it's
instrumenting.

Reviewers: stephenmhouston, zmike

Reviewed By: stephenmhouston, zmike

Subscribers: stephenmhouston, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6251

6 years agoevas engines: do not immediately free native surface when unsetting it
Mike Blumenkrantz [Tue, 5 Jun 2018 17:13:08 +0000 (12:13 -0500)]
evas engines: do not immediately free native surface when unsetting it

Summary:
this is a longstanding issue which was exposed by recent patches to standardize
object lifecycles. when a native surface is used by multiple images, unsetting
the surface from one image must not destroy the native surface or else the
remaining images

fix T6970

@fix

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: cedric, #committers

Tags: #efl

Maniphest Tasks: T6970

Differential Revision: https://phab.enlightenment.org/D6235

6 years agoeo: make noref also a special count
Marcel Hollerbach [Tue, 5 Jun 2018 14:56:09 +0000 (10:56 -0400)]
eo: make noref also a special count

Summary:
this brings down the first frame time from 2.0 sec. to something at 0.7
sec.

ref T6983

Reviewers: zmike

Reviewed By: zmike

Subscribers: YOhoho, cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T6983

Differential Revision: https://phab.enlightenment.org/D6244

6 years agoRevert "evas canvas: remove unused goto tag."
Hermet Park [Tue, 5 Jun 2018 12:36:22 +0000 (21:36 +0900)]
Revert "evas canvas: remove unused goto tag."

This reverts commit b2f85bb9ed69a4f2baf303b8d58ef7ea44493ea6.

this is a subsquent patch for the previous revert:
77684dc53a5bdaf59fa70917c5f6680825484204

ps. JackDaniel saved efl world from a guy who broke the system and ran away...

6 years agoRevert "evas: fix a map rendering problem."
Hermet Park [Tue, 5 Jun 2018 11:58:35 +0000 (20:58 +0900)]
Revert "evas: fix a map rendering problem."

This reverts commit 9fcd03952ee51d34871794cb95585f3e589a3bb9.

Just noticed from ManMower, this caused a side-effect that drops
enlightenment performance. I need to check it seriously then
decide again how this patch to be.

6 years agoelementary widget: fix to trigger object signal emit properly.
Hermet Park [Tue, 5 Jun 2018 11:22:04 +0000 (20:22 +0900)]
elementary widget: fix to trigger object signal emit properly.

This is more generic way to trigger signals for all derived classes of layout.

This fixes the dayselector item signal emit issue as well.

@fix T6981

6 years agoTest/Genlist: set back selection to item in show/bring test
Daniel Zaoui [Tue, 5 Jun 2018 07:16:27 +0000 (10:16 +0300)]
Test/Genlist: set back selection to item in show/bring test

For some unknown reason, the selected_set has been removed from the
test.

Since no response has been given in D5499, I assume it has been removed
by mistake so I put it back.

6 years agoelm_label: remove needless variable
YeongJong Lee [Mon, 4 Jun 2018 11:12:50 +0000 (20:12 +0900)]
elm_label: remove needless variable

Reviewers: Hermet

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6238

6 years agoelementary: fix wrong signal emission
YeongJong Lee [Mon, 4 Jun 2018 08:48:06 +0000 (17:48 +0900)]
elementary: fix wrong signal emission

Summary:
When _icon_signal_emit is called, "icon" part always exist. so, it only make
"visible" signal.
this fixes that issue

Test Plan:
elm_object_content_unset(button);
elm_object_content_unset(radio);
elm_object_content_unset(check);
elm_object_content_unset(progressbar);

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6241

6 years agoecore_imf: turn off autocapital mode in password layout
Jihoon Kim [Mon, 4 Jun 2018 01:47:55 +0000 (10:47 +0900)]
ecore_imf: turn off autocapital mode in password layout

Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
6 years agoelm_table/grid: remove non-widgets from focus elements.
YeongJong Lee [Thu, 31 May 2018 12:04:55 +0000 (12:04 +0000)]
elm_table/grid: remove non-widgets from focus elements.

ref 5a3ee984a1229c069c84e71a109a7d39437d5cc0
Differential Revision: https://phab.enlightenment.org/D6236

6 years agoee_wayland: remove needless variable
YeongJong Lee [Fri, 1 Jun 2018 14:13:14 +0000 (09:13 -0500)]
ee_wayland: remove needless variable

Reviewers: ManMower, zmike

Reviewed By: ManMower

Subscribers: cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6239

6 years agoelm_hoversel: inherit elm_button
YeongJong Lee [Fri, 1 Jun 2018 02:36:01 +0000 (11:36 +0900)]
elm_hoversel: inherit elm_button

Summary:
elm_hoversel is legacy widget. it should inherit legacy Elm_Button instead of
Efl.Ui.Button.
this patch also fixes icon signal emit bug.

fixes T6971

Test Plan:
1. elementary_test -to hoversel
2. check that ther is icon (sky) on "Icon + Lebel" hoversel

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #committers, JackDanielZ, zmike

Tags: #efl

Maniphest Tasks: T6971

Differential Revision: https://phab.enlightenment.org/D6240

6 years agomigration: modify elementary-tizen code to match with upstream code 58/180858/1
Wonki Kim [Tue, 5 Jun 2018 03:36:07 +0000 (12:36 +0900)]
migration: modify elementary-tizen code to match with upstream code

Change-Id: Ide74c1e2eeff990bf2a1899febcb2db56ebccab0
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agoRevert "migration: turn off tizen only elementary" 57/180857/1
Wonki Kim [Mon, 4 Jun 2018 08:06:05 +0000 (17:06 +0900)]
Revert "migration: turn off tizen only elementary"

This reverts commit 43802272a9da1632cae7b0002e1d09eac1f10083.

Change-Id: I729ef9f285fb10c60287494046a51702fee4e8b1

6 years agomigration: update elementary-tizen automake script
Wonki Kim [Mon, 4 Jun 2018 08:23:20 +0000 (17:23 +0900)]
migration: update elementary-tizen automake script

Change-Id: Ic85a4477b6e90cc249d93067aa29646e17b62715
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agoecore_input_device: Modify efl_add by efl_add_ref
Wonki Kim [Mon, 4 Jun 2018 07:24:24 +0000 (16:24 +0900)]
ecore_input_device: Modify efl_add by efl_add_ref

@tizen_fix

Change-Id: I8ae012abe9101c99a3c8a7adf83a1028406ede35
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>