profile/ivi/weston.git
12 years agoTrack server changes.
Scott Moreau [Sat, 18 Feb 2012 12:05:29 +0000 (05:05 -0700)]
Track server changes.

12 years agocompositor: Move fullscreen_output to shell_surface
Kristian Høgsberg [Sat, 18 Feb 2012 04:49:07 +0000 (23:49 -0500)]
compositor: Move fullscreen_output to shell_surface

12 years agocompositor: Make weston_surface_damage_below_noupdate() the default
Kristian Høgsberg [Fri, 17 Feb 2012 17:45:43 +0000 (12:45 -0500)]
compositor: Make weston_surface_damage_below_noupdate() the default

We never want to update the transform and then damage below.  Damage
below is always used to trigger a repaint where the surface used to be
so we need to record the damage before updating the transform.

12 years agocompositor: Move unmap logic to new function weston_surface_unmap()
Kristian Høgsberg [Fri, 17 Feb 2012 17:43:56 +0000 (12:43 -0500)]
compositor: Move unmap logic to new function weston_surface_unmap()

12 years agocompositor: Only delete surface texture if we have one
Kristian Høgsberg [Fri, 17 Feb 2012 17:15:27 +0000 (12:15 -0500)]
compositor: Only delete surface texture if we have one

12 years agocompositor: Get rid of surface->visual
Kristian Høgsberg [Fri, 17 Feb 2012 15:45:16 +0000 (10:45 -0500)]
compositor: Get rid of surface->visual

12 years agoshell: Set geometry directly in configure
Kristian Høgsberg [Fri, 17 Feb 2012 04:43:59 +0000 (23:43 -0500)]
shell: Set geometry directly in configure

We already set half of it directly, and overwrite it in other cases, so
just skip weston_surface_configure().

12 years agoshell: Restore basic fullscreen functionality
Kristian Høgsberg [Fri, 17 Feb 2012 04:38:14 +0000 (23:38 -0500)]
shell: Restore basic fullscreen functionality

This just fixes the default case.

12 years agowindow: Don't draw decorations in fullscreen mode
Kristian Høgsberg [Fri, 17 Feb 2012 03:57:21 +0000 (22:57 -0500)]
window: Don't draw decorations in fullscreen mode

12 years agowindow: Set window type as it changes, not on every attach
Kristian Høgsberg [Fri, 17 Feb 2012 03:56:12 +0000 (22:56 -0500)]
window: Set window type as it changes, not on every attach

It was always a bit sloppy, and the new fullscreen request doesn't work
that way.

12 years agoview: Don't schedule resize after setting fullscreen
Kristian Høgsberg [Fri, 17 Feb 2012 03:51:33 +0000 (22:51 -0500)]
view: Don't schedule resize after setting fullscreen

window_set_fullscreen will schedule a resize or wait for the configure
event as needed.

12 years agowindow: Use constant keycode offset of 8
Daniel Stone [Thu, 16 Feb 2012 12:48:00 +0000 (12:48 +0000)]
window: Use constant keycode offset of 8

The X11 compositor currently posts its key presses as keycode - 8; this
is due to X11 having a historical minimum keycode of 8, whereas evdev is
numbered starting from 1.  So while the KEY_* constants begin with
KEY_ESC at 1, the corresponding keycode in both X11 and the XKB keymaps
is 9.

window, on the other hand, was relying on xkb->min_key_code being 8 to
translate its keycodes back to useful values in the XKB 'evdev' keycode
map.  min_key_code may not always be 8, for restricted subsets of the
keycode map.

Perhaps not the best solution, but at least consistent.

Signed-off-by: Daniel Stone <daniel@fooishbar.org>
12 years agowindow: Use new xkbcommon include path
Daniel Stone [Wed, 15 Feb 2012 16:33:21 +0000 (16:33 +0000)]
window: Use new xkbcommon include path

xkbcommon in current git has moved its include files.

Signed-off-by: Daniel Stone <daniel@fooishbar.org>
12 years agoprotocol: remove absolute coordinates from pointer
Pekka Paalanen [Tue, 14 Feb 2012 12:59:18 +0000 (14:59 +0200)]
protocol: remove absolute coordinates from pointer

This change depens on the Wayland core commit:
"protocol: remove absolute coordinates from pointer".

Remove the absolute coordinates from pointer motion and pointer_focus
events.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agowindow: do not store absolute coordinates
Pekka Paalanen [Mon, 13 Feb 2012 13:33:28 +0000 (15:33 +0200)]
window: do not store absolute coordinates

These were not used for anything, anyway.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoclients/dnd: adapt to new data_device icon protocol
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:58 +0000 (17:02 +0200)]
clients/dnd: adapt to new data_device icon protocol

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agocompositor: implement drag'n'drop icons
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:57 +0000 (17:02 +0200)]
compositor: implement drag'n'drop icons

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agoshell: update position of surfaces with type none on map()
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:56 +0000 (17:02 +0200)]
shell: update position of surfaces with type none on map()

Needed for implementing drag'n'drop icons. When a drag starts, the
compositor will position the top-left corner of the client supplied
icon surface at the cursor hotspot. On the first attach to that
surface, the client may want to reposition it but shell->map did not
take sx and sy parameters.

This changes shell->map interface to take sx and sy parameters and
change dekstop shell implementation to update the position of a
surface of type none according to those parameters. Since a surface
of type none won't actually be mapped, the effect of this change is
only visible for surfaces that are made visible by the compositor.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agocompositor: add a way to disable picking of client surfaces
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:55 +0000 (17:02 +0200)]
compositor: add a way to disable picking of client surfaces

Surfaces like drag'n'drop icons shouldn't receive events as a normal
surface but are still created by the client so add a way for the
compositor to enable or disable the picking of a client surface.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agoshell: don't map surfaces with type NONE
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:54 +0000 (17:02 +0200)]
shell: don't map surfaces with type NONE

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agocompositor: fix two crashs on surface_attach() with null buffer
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:53 +0000 (17:02 +0200)]
compositor: fix two crashs on surface_attach() with null buffer

The condition to return from surface_attach with a null buffer involves
es->output being non-null. However if a surface was just created this
field would be null and an attach of a null buffer would cause the
compositor to crash.

The other crash happened if surface_attach was called twice with a
null buffer after a valid buffer was attached to the surface. Since
es->buffer was not being set to NULL, surface_attach() would call
wl_list_remove(&es->buffer_destroy_listener.link) twice for the same
surface.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agoFollow set_fullscreen protocol change
Kristian Høgsberg [Thu, 16 Feb 2012 20:58:14 +0000 (15:58 -0500)]
Follow set_fullscreen protocol change

12 years agowindow: Toggle maximized with super-f5
Kristian Høgsberg [Thu, 16 Feb 2012 20:53:46 +0000 (15:53 -0500)]
window: Toggle maximized with super-f5

12 years agoshell: Add the set_maximized implementation
Juan Zhao [Tue, 7 Feb 2012 00:45:41 +0000 (08:45 +0800)]
shell: Add the set_maximized implementation

12 years agocompositor, shell: add and use weston_surface_set_position()
Pekka Paalanen [Mon, 13 Feb 2012 11:03:59 +0000 (13:03 +0200)]
compositor, shell: add and use weston_surface_set_position()

Another shorthand like weston_surface_configure().

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: remove two redundant statements from map()
Pekka Paalanen [Fri, 10 Feb 2012 14:40:22 +0000 (16:40 +0200)]
shell: remove two redundant statements from map()

I stared at this function for some time, and these were the only lines
I could sanely remove.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: make functions static
Tiago Vignatti [Fri, 10 Feb 2012 14:26:19 +0000 (16:26 +0200)]
compositor: make functions static

I know it's hard to figure out what the shells or backends will be
using as internal API at this point but we can try to minimize the
amount of WL_EXPORT being used anyway.

[pq: redone due to my earlier changes]

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: remove duplicated code
Tiago Vignatti [Fri, 10 Feb 2012 14:17:23 +0000 (16:17 +0200)]
shell: remove duplicated code

This clean-up seems alright, but someone with better knowledge has to
doublecheck this function. I guess there's a lot of space for clean-up
there.

[pq: looks ok, redone since did not apply after my changes]

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoclients: fix spelling
Tiago Vignatti [Thu, 9 Feb 2012 17:06:56 +0000 (19:06 +0200)]
clients: fix spelling

Signed-off-by: Tiago Vignatti <vignatti@freedesktop.org>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agowindow: simplify a bit widget_set_size and widget_set_allocation
Tiago Vignatti [Thu, 9 Feb 2012 17:06:55 +0000 (19:06 +0200)]
window: simplify a bit widget_set_size and widget_set_allocation

Signed-off-by: Tiago Vignatti <vignatti@freedesktop.org>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agowindow: explicitly set TYPE_TOPLEVEL for new windows
Tiago Vignatti [Thu, 9 Feb 2012 17:06:54 +0000 (19:06 +0200)]
window: explicitly set TYPE_TOPLEVEL for new windows

Signed-off-by: Tiago Vignatti <vignatti@freedesktop.org>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: do not apply damage on window type set
Pekka Paalanen [Mon, 13 Feb 2012 09:04:30 +0000 (11:04 +0200)]
shell: do not apply damage on window type set

Setting a window type is a non-visual operation, it is not supposed to
affect the rendering immediately. Therefore it does not need to apply
surface damage.

The proper surface damage is applied on an attach request following a
window type change.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: remove redundant cursor damage calls
Pekka Paalanen [Mon, 13 Feb 2012 09:01:59 +0000 (11:01 +0200)]
compositor: remove redundant cursor damage calls

As weston_surface_update_transform() automatically applies before and
after damage on surface geometry change, we don't need to explicitly add
the same damage in motion_notify() for the cursor surface.

We still need the side-effect, that is scheduling a repaint.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: round off fractions
Pekka Paalanen [Mon, 13 Feb 2012 08:34:04 +0000 (10:34 +0200)]
compositor: round off fractions

Round off fractions from non-transformed surface position coordinates.

Transformed surface moved by a client may have non-integer position
coordinates. That is required to prevent drifting on continuous
resizing.

We can round the position to integers when the surface is not (anymore)
transformed.

This change may fix a rounding inconsistency in the opaque region setup,
where the rectangle is initialised from the coordinates without explicit
rounding operation.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: replace identity calls to weston_surface_configure()
Pekka Paalanen [Fri, 10 Feb 2012 13:33:10 +0000 (15:33 +0200)]
shell: replace identity calls to weston_surface_configure()

In the past, weston_surface_configure() was used to change the geometry,
apply damage, and assign an output.

Remove all calls to weston_surface_configure() that do not change the
surface geometry. Add damage calls where needed to keep the wanted
configure side-effects.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: move output assignment to update_transform
Pekka Paalanen [Fri, 10 Feb 2012 11:34:36 +0000 (13:34 +0200)]
compositor: move output assignment to update_transform

Move the call to assign an output from weston_surface_configure() to
weston_surface_update_transform().

As update_transform takes new geometry into use, it should also reassign
the output for the surface, but only if an output was already assigned.

Add explicit assing output calls to where we relied on
weston_surface_configure() unconditionally assigning the output.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: move opaque tracking into transform
Pekka Paalanen [Thu, 9 Feb 2012 14:39:38 +0000 (16:39 +0200)]
compositor: move opaque tracking into transform

Move the surface opaque region setup from weston_surface_configure() to
weston_surface_update_transform(), so we have less reason to call
update_transform from configure. Opaque region depends on geometry,
after all.

Also move the opaque field from weston_surface to
weston_surface::transform to make this obvious.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: clarify update_transform vs. repaint
Pekka Paalanen [Thu, 9 Feb 2012 13:58:44 +0000 (15:58 +0200)]
compositor: clarify update_transform vs. repaint

Remove redundant weston_surface_update_transform() calls from within
output repaint paths, and add a comment that we need to rely on
surface->geometry.dirty == 0 within the repaint sub-functions.

Now that weston_surface_update_transform() does damage as needed, and
weston_output_repaint() explicitly calls update_transform, we can reduce
the updates in rotate_grab_motion() to simply scheduling a repaint. This
will guarantee that the change in rotation ends up on screen ASAP.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: let update_transform deal damage
Pekka Paalanen [Thu, 9 Feb 2012 13:32:15 +0000 (15:32 +0200)]
compositor: let update_transform deal damage

weston_surface_update_transform() is similar to
weston_surface_configure() in that it changes the surface region on
screen. Unlike configure, update_transform forgets to deal damage at
all, yet it is the only place where we can do damage_below() as needed.

Add a damage_below call to deal damage for the old surface region only
when needed. This uses the cached state from surface->transform to get
the old region.

Add a damage call to deal damage for the new surface region, after
updating the cached state.

Add a repaint call, since we have changed the scene and should render it
out.

This change fixes the rotation not updating the screen properly.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: simplify weston_surface_damage_rectangle()
Pekka Paalanen [Thu, 9 Feb 2012 13:27:45 +0000 (15:27 +0200)]
compositor: simplify weston_surface_damage_rectangle()

The non-transformed case looked a little odd, calling
weston_surface_to_global(), since it already tests for transform.enabled
and simply uses width, height for the box.

Streamline it, by open-coding weston_surface_to_global(), and avoiding
another call into weston_surface_update_transform(). This way it does
not look suspicious to me.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: use floats in computing bounding box
Pekka Paalanen [Wed, 8 Feb 2012 13:38:37 +0000 (15:38 +0200)]
compositor: use floats in computing bounding box

In surface_compute_bbox(), call surface_to_global_float() instead of
weston_surface_to_global(). This avoids the recursion:

weston_surface_update_transform()
  weston_surface_update_transform_enable()
    surface_compute_bbox()
       weston_surface_to_global()
         weston_surface_update_transform()

which might be non-obvious when reading the code.

Computing the min and max coordinates in floats, we can have a tight
rounding margin by using floor() and ceil().

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: move surface_to_global_float() definition
Pekka Paalanen [Wed, 8 Feb 2012 13:23:15 +0000 (15:23 +0200)]
compositor: move surface_to_global_float() definition

Move surface_to_global_float() definition earlier in the file. No code
changes.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: split weston_surface_update_transform()
Pekka Paalanen [Wed, 8 Feb 2012 13:14:17 +0000 (15:14 +0200)]
compositor: split weston_surface_update_transform()

Split two helper functions out of weston_surface_update_transform() to:
- make the code clearer
- update the bounding box properly even if transformation fails
- unify the return point

Also add a comment on what matrix.d[12] is.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: split weston_surface_damage_below()
Pekka Paalanen [Wed, 8 Feb 2012 12:49:37 +0000 (14:49 +0200)]
compositor: split weston_surface_damage_below()

Extract the core into a function that does not call
weston_surface_update_transform() or schedule repaint.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: remove excessive damage from rotating
Pekka Paalanen [Wed, 8 Feb 2012 12:19:18 +0000 (14:19 +0200)]
shell: remove excessive damage from rotating

Rotating a surface should not force a full display repaint, so remove
that.

This change exposes a bug: weston_surface_update_transform() does not
apply damage, but it does change surface geometry. While you rotate a
surface, repaints do not work.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoconfigure: Fix build on debian by avoiding bashisms in the test command.
Eric Anholt [Thu, 9 Feb 2012 16:36:03 +0000 (08:36 -0800)]
configure: Fix build on debian by avoiding bashisms in the test command.

12 years agoUse dist-xz for tarballs
Kristian Høgsberg [Thu, 9 Feb 2012 16:18:16 +0000 (11:18 -0500)]
Use dist-xz for tarballs

12 years agoDisable setuid install for distcheck
Kristian Høgsberg [Thu, 9 Feb 2012 14:20:44 +0000 (09:20 -0500)]
Disable setuid install for distcheck

12 years agoconfigure: Change project to weston, set version to 0.89
Kristian Høgsberg [Wed, 8 Feb 2012 21:35:12 +0000 (16:35 -0500)]
configure: Change project to weston, set version to 0.89

12 years agocompositor: Don't destroy sprite surface, just hide it
Kristian Høgsberg [Wed, 8 Feb 2012 21:33:57 +0000 (16:33 -0500)]
compositor: Don't destroy sprite surface, just hide it

12 years agosmoke: Use normal window resize mechanism
Kristian Høgsberg [Wed, 8 Feb 2012 19:47:53 +0000 (14:47 -0500)]
smoke: Use normal window resize mechanism

12 years agowindow: Don't set the window size in widget_set_size()
Kristian Høgsberg [Wed, 8 Feb 2012 19:45:02 +0000 (14:45 -0500)]
window: Don't set the window size in widget_set_size()

We propagate the toplevel widget size to the window size in the
window.c resize code.

12 years agosmoke: fix the segment fault error
Juan Zhao [Fri, 3 Feb 2012 00:02:06 +0000 (16:02 -0800)]
smoke: fix the segment fault error

Add widget_set_size in the initiate time to allow smoke get the
correct surface later. Or it will report segment fault error because
of the null surface.

Also add resize_handler to not allow resizing just like flower.

Signed-off-by: Juan Zhao <juan.j.zhao@linux.intel.com>
12 years agoAdd support for webp image format
Kristian Høgsberg [Wed, 8 Feb 2012 17:46:57 +0000 (12:46 -0500)]
Add support for webp image format

12 years agocairo-util: Only look at first two bytes for jpegs
Kristian Høgsberg [Wed, 8 Feb 2012 15:11:42 +0000 (10:11 -0500)]
cairo-util: Only look at first two bytes for jpegs

The next two bytes aren't fixed.

12 years agoterminal: run $SHELL if set
Peter Hutterer [Fri, 3 Feb 2012 10:58:19 +0000 (20:58 +1000)]
terminal: run $SHELL if set

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
12 years agoconfigure.ac: fix cairo-glesv2 help text
Jesse Barnes [Tue, 7 Feb 2012 20:42:28 +0000 (12:42 -0800)]
configure.ac: fix cairo-glesv2 help text

Finally figured out why --enable-cairo-gles2 wasn't working like
configure --help said it should.

12 years agoMerge remote-tracking branch 'pq/transform-fixes2'
Kristian Høgsberg [Tue, 7 Feb 2012 16:04:11 +0000 (11:04 -0500)]
Merge remote-tracking branch 'pq/transform-fixes2'

12 years agocompositor-wayland: Add window border
Kristian Høgsberg [Wed, 1 Feb 2012 12:45:51 +0000 (07:45 -0500)]
compositor-wayland: Add window border

12 years agocompositor-wayland: Add display sub-option for wayland backend
Kristian Høgsberg [Tue, 7 Feb 2012 14:57:25 +0000 (09:57 -0500)]
compositor-wayland: Add display sub-option for wayland backend

This lets us launch the compositor on a separate wayland socket that
what we're listening on.

12 years agocompositor-wayland: Hide cursor for compositor surfaces
Kristian Høgsberg [Tue, 7 Feb 2012 14:56:51 +0000 (09:56 -0500)]
compositor-wayland: Hide cursor for compositor surfaces

12 years agocompositor-wayland: Destroy wl_callback in callback function
Kristian Høgsberg [Tue, 7 Feb 2012 14:56:15 +0000 (09:56 -0500)]
compositor-wayland: Destroy wl_callback in callback function

12 years agocompositor: Drop setuid when launching clients
Kristian Høgsberg [Wed, 1 Feb 2012 03:17:25 +0000 (22:17 -0500)]
compositor: Drop setuid when launching clients

12 years agocompositor: simple menu transform
Pekka Paalanen [Tue, 7 Feb 2012 12:19:01 +0000 (14:19 +0200)]
compositor: simple menu transform

Transform a menu popup the same as its parent surface.

The parent's transformation is snapshotted at the popup map() time, and
does not follow further parent motion.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: add weston_surface transformation doc
Pekka Paalanen [Tue, 7 Feb 2012 11:18:00 +0000 (13:18 +0200)]
compositor: add weston_surface transformation doc

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: fix transformed opaque surface repainting
Pekka Paalanen [Mon, 6 Feb 2012 14:26:57 +0000 (16:26 +0200)]
compositor: fix transformed opaque surface repainting

Computing the real maximal opaque screen aligned rectangle of a
transformed surface is hard. Let's drop the opaque optimisation
instead.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: q&d solution for surface drift
Pekka Paalanen [Mon, 6 Feb 2012 12:54:20 +0000 (14:54 +0200)]
compositor: q&d solution for surface drift

When a transformed (rotated) surface is continuously resized from its
top-left corner, its location will drift. This is due to accumulating
rounding errors in transforming an offset from surface-local to global
coordinates in surface_attach().

Diminish the drift down to unobservable level by changing the
weston_surface global position from integer to float.

The offset transformation is now done without rounding. To preserve the
precision, wl_shell::configure() interface must use floats, and so does
weston_surface_configure(), too.

The con of this patch is that it adds inconsistency to the surface
position coordinates: sometimes they are floats, sometimes integers.

12 years agocompositor: clear surface damage on draw
Pekka Paalanen [Mon, 6 Feb 2012 10:16:07 +0000 (12:16 +0200)]
compositor: clear surface damage on draw

Commit a0d6dc4f26c95ae08ffff7d5f1ee7c1f53bdf545 lost one line of code in
the refactoring, and so did not reset the surface damage on repaint
anymore. This causes damage to only accumulate, leading to a full
display redraw every cycle and hiding damage tracking issues.

Put the damage clear back.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: fix and simplify shader uniform handling
Pekka Paalanen [Thu, 2 Feb 2012 14:49:05 +0000 (16:49 +0200)]
compositor: fix and simplify shader uniform handling

The uniform location variables should be signed, according to the OpenGL
ES 2 specification. Moreover, GL_NONE, i.e. 0, is not an invalid nor
special location; it is actually used as a valid uniform location.

Change struct weston_shader uniform members to signed.

Stop using 0 for identifying a non-existing uniform, use -1 instead.
Furthermore, as the spec says a) glGetUniformLocation() will return -1
for non-active/existing uniforms, and b) glUniform*() function will
simply ignore all calls with location -1, we can simplify the code. We
don't have to avoid locating uniforms that don't exist, and we don't
need to test for them in weston_surface_draw() either.

Remove the micro-optimisation that avoids setting 'alpha' uniform if it
has not changed, in the name of simplification.

Unify shader creation by dropping init_solid_shader(), and calling
weston_shader_init() instead. The downside is that we compile the vertex
shader twice at startup now.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoconfigure: add libpng to client libs
Pekka Paalanen [Wed, 1 Feb 2012 09:31:31 +0000 (11:31 +0200)]
configure: add libpng to client libs

http://lists.freedesktop.org/archives/wayland-devel/2012-January/001975.html
reports a linking problem:

/usr/bin/ld: libtoytoolkit.a(cairo-util.o): undefined reference to
symbol 'png_set_filler@@PNG12_0'
/usr/bin/ld: note: 'png_set_filler@@PNG12_0' is defined in DSO
/usr/lib/i386-linux-gnu/libpng12.so.0 so try adding it to the linker command line
/usr/lib/i386-linux-gnu/libpng12.so.0: could not read symbols: Invalid
operation
collect2: ld returned 1 exit status
make[3]: [weston-terminal] Error 1 (ignored)

A similar problem is diagnosed here:
http://lists.fedoraproject.org/pipermail/devel/2010-March/133601.html

As some distros are shipping linkers, that do not resolve symbols from
implicitly linked libraries, check and link libpng explicitly.

Cc: nerdopolis <bluescreen_avenger@verizon.net>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: Don't just update uniforms when we change shaders
Kristian Høgsberg [Tue, 31 Jan 2012 20:38:36 +0000 (15:38 -0500)]
compositor: Don't just update uniforms when we change shaders

The uniforms change from surface to surface or output to output, so always
set them.

12 years agowindow: Fold window_resize into idle_resize
Kristian Høgsberg [Tue, 31 Jan 2012 20:34:15 +0000 (15:34 -0500)]
window: Fold window_resize into idle_resize

12 years agowindow: Don't overwrite window->allocation until we've done the resize
Kristian Høgsberg [Tue, 31 Jan 2012 20:30:47 +0000 (15:30 -0500)]
window: Don't overwrite window->allocation until we've done the resize

This way we can actually detect whether or not a window resizes.

12 years agowindow: Dont take width and height in window constructor
Kristian Høgsberg [Tue, 31 Jan 2012 20:24:48 +0000 (15:24 -0500)]
window: Dont take width and height in window constructor

Always set this by scheduling an initial resize.

12 years agoflower: Dont allow resizing
Kristian Høgsberg [Tue, 31 Jan 2012 16:53:20 +0000 (11:53 -0500)]
flower: Dont allow resizing

12 years agoflower: Redraw flower on middle click, pop up window menu on right click
Kristian Høgsberg [Tue, 31 Jan 2012 14:54:04 +0000 (09:54 -0500)]
flower: Redraw flower on middle click, pop up window menu on right click

12 years agowindow: Make window frame menu available to client
Kristian Høgsberg [Tue, 31 Jan 2012 14:53:44 +0000 (09:53 -0500)]
window: Make window frame menu available to client

12 years agoconfigure: use --disable-tests, since default is enabled
Pekka Paalanen [Tue, 31 Jan 2012 14:35:19 +0000 (16:35 +0200)]
configure: use --disable-tests, since default is enabled

Add a nice help text, too.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoconfigure: toytoolkit GL apps depend on cairo-egl
Pekka Paalanen [Tue, 31 Jan 2012 14:35:18 +0000 (16:35 +0200)]
configure: toytoolkit GL apps depend on cairo-egl

Do not build toytoolkit applications that use GL, if Cairo-egl is not
available. These applications (which happen to be also the full GL
clients) do not work at all without Cairo-egl, and fail at runtime with
"unable to acquire window surface".

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: handle attach request in surface-local coordinates
Pekka Paalanen [Tue, 31 Jan 2012 10:04:54 +0000 (12:04 +0200)]
compositor: handle attach request in surface-local coordinates

The x, y offsets in attach request are in surface-local coordinates, as
that is the only coordinate system the clients know about. The offset
must be transformed to global coordinate system to be applied properly.

This approximately fixes the top-left resizing of transformed surfaces.
However, it suffers from drift due to accumulating rounding errors in
continuous resizing.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: fix resize for transformed surfaces
Pekka Paalanen [Mon, 30 Jan 2012 14:19:47 +0000 (16:19 +0200)]
shell: fix resize for transformed surfaces

This fixes the resize pointer motion vs. surface size mismatch for
right/bottom direction resizes. Top/left resizes need further fixes in
surface motion.

Additionally there is some clean-up in weston_surface_resize() to
eliminate a failure path, and fixing the Weston resize binding's resize
direction heuristic to follow transformations.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agoshell: fix move of transformed surfaces
Pekka Paalanen [Mon, 30 Jan 2012 12:16:34 +0000 (14:16 +0200)]
shell: fix move of transformed surfaces

In the stack of transformations, change the rotation to be applied
to the surface before the absolute positioning. Doing so avoids having
to undo and redo the absolute positioning, and we can simply use the
surface center in local coordinates as the origin.

This fixes the surface move. Before, the surface moved along the surface
local axis, but the user expects it to move along the global axis with
the pointer.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agotest: Fix out-of-tree builds
Kristian Høgsberg [Tue, 31 Jan 2012 00:15:04 +0000 (19:15 -0500)]
test: Fix out-of-tree builds

12 years agobuild: fix build of matrix test
Ander Conselvan de Oliveira [Mon, 30 Jan 2012 13:02:06 +0000 (15:02 +0200)]
build: fix build of matrix test

This test uses files from src/ so use COMPOSITOR_CFLAGS to find headers
in non-standard locations.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agoUpdate config files to reflect new terminal name, weston-terminal
Scott Moreau [Mon, 30 Jan 2012 14:05:14 +0000 (07:05 -0700)]
Update config files to reflect new terminal name, weston-terminal

krh: Updated to use /usr/bin/weston-terminal.

12 years agocompositor: Allow attaching null buffer
Kristian Høgsberg [Mon, 30 Jan 2012 14:10:14 +0000 (09:10 -0500)]
compositor: Allow attaching null buffer

Attaching a null buffer is allowed and takes the surface back to the
unattached state it starts in.

12 years agoImplement CONFIG_KEY_UNSIGNED_INTEGER
Scott Moreau [Fri, 27 Jan 2012 20:25:49 +0000 (13:25 -0700)]
Implement CONFIG_KEY_UNSIGNED_INTEGER

strtol() does not work when trying to assign 32 bits of data into a
regular signed int on 32 bit systems. Use corresponding strtoul()
instead.

12 years agoshell: Rotate relative to current rotation
Kristian Høgsberg [Fri, 27 Jan 2012 18:36:13 +0000 (13:36 -0500)]
shell: Rotate relative to current rotation

This avoids the surface jumping around when you start rotating it.

12 years agocompositor: Only set surface geometry through weston_surface_configure()
Kristian Høgsberg [Fri, 27 Jan 2012 16:58:31 +0000 (11:58 -0500)]
compositor: Only set surface geometry through weston_surface_configure()

There are too many things to keep track of now, so let's require going
through this.

12 years agocompositor: Link to libm
Kristian Høgsberg [Fri, 27 Jan 2012 16:57:28 +0000 (11:57 -0500)]
compositor: Link to libm

12 years agoMerge remote-tracking branch 'pq/transform-v1'
Kristian Høgsberg [Fri, 27 Jan 2012 16:42:18 +0000 (11:42 -0500)]
Merge remote-tracking branch 'pq/transform-v1'

12 years agodesktop-shell: print what failed on exec
Pekka Paalanen [Fri, 27 Jan 2012 07:50:02 +0000 (09:50 +0200)]
desktop-shell: print what failed on exec

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agowindow: fix resizing of windows backed by shm buffers
Ander Conselvan de Oliveira [Fri, 27 Jan 2012 15:17:39 +0000 (17:17 +0200)]
window: fix resizing of windows backed by shm buffers

When window_attach_surface() calls window_get_resize_dx_dy(),
window->resize_edges is cleared. However if there is already a pending
surface to be attached, the resize won't be done until the following
call to window_attach_surface(). In this next call, since resize_edges
is now zero, the top-left corner of the window will be unchanged. If
the user is resizing from the top or left border, this causes the
resize to happen in the wrong direction.

This patch changes window_attach_surface() to call
window_get_resize_dx_dy() only if an attach will actually happen.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
12 years agowindow: Handle data_device.selection events with offer=NULL
Kristian Høgsberg [Fri, 27 Jan 2012 16:04:18 +0000 (11:04 -0500)]
window: Handle data_device.selection events with offer=NULL

This happens when the current selection data_offer is removed.

12 years agoCollabora copyright updates
Pekka Paalanen [Fri, 27 Jan 2012 14:25:16 +0000 (16:25 +0200)]
Collabora copyright updates

which I forgot to add while working on these files.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: make overlap computation use the boundingbox
Pekka Paalanen [Fri, 27 Jan 2012 12:38:33 +0000 (14:38 +0200)]
compositor: make overlap computation use the boundingbox

This makes the overlap to account for surface transformations.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: use bounding box for damage regions
Pekka Paalanen [Thu, 26 Jan 2012 11:12:45 +0000 (13:12 +0200)]
compositor: use bounding box for damage regions

Change weston_surface_damage*() functions to use the full surface
bounding box or call surface_compute_bbox() to find the bounding box for
an arbitrary rectangle.

This should fix all rendering artifacts for non-opaque (i.e. ARGB)
transformed surfaces.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: weston_surface_assign_output() to use bounding box
Pekka Paalanen [Thu, 26 Jan 2012 09:34:16 +0000 (11:34 +0200)]
compositor: weston_surface_assign_output() to use bounding box

Use the bounding box to compute an approximation of which output
contains most of the surface.

Move the region32 init outside the loop, and fini it, too.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: weston_output_set_cursor() to use bounding box
Pekka Paalanen [Thu, 26 Jan 2012 09:31:01 +0000 (11:31 +0200)]
compositor: weston_output_set_cursor() to use bounding box

If we ever have transformed cursor surfaces, we would better use the
bounding box to check if it is on the given output.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
12 years agocompositor: weston_surface_draw() to use bounding box
Pekka Paalanen [Thu, 26 Jan 2012 09:28:08 +0000 (11:28 +0200)]
compositor: weston_surface_draw() to use bounding box

Use the proper bounding box in clipping the surface repaint area. Fixes
excessive clipping for transformed surfaces.

Also don't leak the region32 on early return.

Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>