Anshil Gandhi [Sun, 15 Aug 2021 05:37:15 +0000 (23:37 -0600)]
[Remarks] Emit optimization remarks for atomics generating CAS loop
Implements ORE in AtomicExpand pass to report atomics generating
a compare and swap loop.
Differential Revision: https://reviews.llvm.org/D106891
Itay Bookstein [Sun, 15 Aug 2021 05:01:10 +0000 (22:01 -0700)]
[Linker] Import GlobalIFunc when importing symbols from another module
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D107988
Vitaly Buka [Sun, 15 Aug 2021 01:42:05 +0000 (18:42 -0700)]
[msan] Fix ppc64 format warning
Vitaly Buka [Sun, 15 Aug 2021 01:33:03 +0000 (18:33 -0700)]
[sanitizer] Improve VSNPrintf internal diagnostics
Craig Topper [Sun, 15 Aug 2021 00:24:21 +0000 (17:24 -0700)]
[X86] Add parentheses around casts in X86 intrinsic headers.
Fixes PR51324.
Dmitry Vyukov [Sun, 15 Aug 2021 00:41:14 +0000 (17:41 -0700)]
sanitizer_common: support %l in format strings
Currently we only support %z and %ll width modifiers,
but surprisingly not %l. This makes it impossible to print longs
(sizeof(long) not necessary equal to sizeof(size_t)).
We had some printf's that printed longs with %zu,
but that's wrong and now with __attribute__((format)) in place
they are flagged by compiler. So we either have a choice of
doing static_cast<uptr>(long) everywhere or add %l.
Adding %l looks better, that's a standard modifier.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D108066
Wang, Pengfei [Sun, 15 Aug 2021 00:17:30 +0000 (08:17 +0800)]
[X86] AVX512FP16 instructions enabling 2/6
Enable FP16 binary operator instructions.
Ref.: https://software.intel.com/content/www/us/en/develop/download/intel-avx512-fp16-architecture-specification.html
Reviewed By: LuoYuanke
Differential Revision: https://reviews.llvm.org/D105264
Vitaly Buka [Sat, 14 Aug 2021 23:51:10 +0000 (16:51 -0700)]
[sanitizer] Define 32bit uptr as uint
This makes it consistent with uintptr_t.
Vitaly Buka [Sat, 14 Aug 2021 23:26:06 +0000 (16:26 -0700)]
[sanitizer] Fix format string
Craig Topper [Sat, 14 Aug 2021 23:41:50 +0000 (16:41 -0700)]
[X86] Use a do {} while (0) in the _MM_EXTRACT_FLOAT implementation.
Previously we just used {}, but that doesn't work in situations
like this.
if (1)
_MM_EXTRACT_FLOAT(d, x, n);
else
...
The semicolon would terminate the if.
Craig Topper [Sat, 14 Aug 2021 23:34:52 +0000 (16:34 -0700)]
[X86] Use __builtin_bit_cast _mm_extract_ps instead of type punning through a union. NFC
Rainer Orth [Sat, 14 Aug 2021 22:20:47 +0000 (00:20 +0200)]
[test] Avoid unportable echo in Other/lit-quoting.txt
`LLVM :: Other/lit-quoting.txt` currently `FAIL`s on Solaris:
llvm/test/Other/lit-quoting.txt:8:9: error: CHECK2: expected string not found in input
CHECK2: {{^a\[b\\c$}}
^
<stdin>:1:1: note: scanning from here
a[b
^
This happens because echo with backslashes or special characters is
unportable, as extensively documented in the Autoconf manual. In the case
at hand, `echo 'a[b\c'` yields `a[b\c` on Linux, but `a[b` (no newline) on
Solaris.
This patch fixes this by using the portable alternative suggested in the
Autoconf manual.
Tested on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and
`x86_64-pc-linux-gnu`.
Differential Revision: https://reviews.llvm.org/D108031
Nico Weber [Sat, 14 Aug 2021 21:58:21 +0000 (17:58 -0400)]
Simplify a .mailmap entry
Only one person committed with these email addresses, so there's no need to use
the map-different-names-for-one-email-address syntax.
No behavior change.
Differential Revision: https://reviews.llvm.org/D108007
David Green [Sat, 14 Aug 2021 21:48:10 +0000 (22:48 +0100)]
[InstCombine] Extend sadd.sat tests to include min/max patterns. NFC
This tests code starting from smin/smax, as opposed to the icmp/select
form. Also adds a ARM MVE phase ordering test for vectorizing to
sadd.sat from the original IR.
Stephen Neuendorffer [Thu, 24 Sep 2020 18:54:46 +0000 (11:54 -0700)]
[MLIR] Move TestDialect to ::test namespace
While the changes are extensive, they basically fall into a few
categories:
1) Moving the TestDialect itself.
2) Updating C++ code in tablegen to explicitly use ::mlir, since it
will be put in a headers that shouldn't expect a 'using'.
3) Updating some generic MLIR Interface definitions to do the same thing.
4) Updating the Tablegen generator in a few places to be explicit about
namespaces
5) Doing the same thing for llvm references, since we no longer pick
up the definitions from mlir/Support/LLVM.h
Differential Revision: https://reviews.llvm.org/D88251
Nikita Popov [Sat, 14 Aug 2021 18:54:19 +0000 (20:54 +0200)]
[Tests] Remove explicit -enable-mssa-loop-dependency options (NFC)
This is enabled by default. Drop explicit uses in preparation for
removing the option.
Also drop RUN lines that are now the same (typically modulo a
-verify-memoryssa option).
luxufan [Sat, 14 Aug 2021 16:30:42 +0000 (00:30 +0800)]
[JITLink] Unify x86-64 MachO and ELF 's optimize GOT/Stub function
This patch unify optimizeELF_x86_64_GOTAndStubs and optimizeMachO_x86_64_GOTAndStubs into a pure optimize_x86_64_GOTAndStubs
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D108025
Kazu Hirata [Sat, 14 Aug 2021 15:49:40 +0000 (08:49 -0700)]
[Aarch64] Remove redundant c_str (NFC)
Identified with readability-redundant-string-cstr.
Owen [Thu, 12 Aug 2021 13:12:25 +0000 (06:12 -0700)]
[clang-format] Distinguish K&R C function definition and attribute
This is a follow-up to https://reviews.llvm.org/D107950 which
missed user-defined types in K&R C.
Differential Revision: https://reviews.llvm.org/D107961
eopXD [Sat, 14 Aug 2021 07:58:05 +0000 (15:58 +0800)]
[LoopIdiom] let the pass deal with runtime memset size
The current LIR does not deal with runtime-determined memset-size. This patch
utilizes SCEV and check if the PointerStrideSCEV and the MemsetSizeSCEV are equal.
Before comparison the pass would try to fold the expression that is already
protected by the loop guard.
Testcase file `memset-runtime.ll`, `memset-runtime-debug.ll` added.
This patch deals with proper loop-idiom. Proceeding patch wants to deal with SCEV-s
that are inequal after folding with the loop guards.
Reviewed By: lebedev.ri, Whitney
Differential Revision: https://reviews.llvm.org/D107353
mydeveloperday [Sat, 14 Aug 2021 11:05:21 +0000 (12:05 +0100)]
[clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]
https://bugs.llvm.org/show_bug.cgi?id=50069
When clang-tidy sees:
```
if (true) [[unlikely]] {
...
}
```
It thinks the braces are missing and add them again.
```
if (true) { [[unlikely]] {
...
}
}
```
This revision aims to prevent that incorrect code generation
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D105479
mydeveloperday [Sat, 14 Aug 2021 09:29:07 +0000 (10:29 +0100)]
[clang-format] NFC update the ClangFormatStyleOption.rst following previous change
clang/docs/tool/dump_format_style.py was not run as part of {D99840}
Bring ClangFormatStyleOptions.rst back in line.
Reviewed By: HazardyKnusperkeks
Differential Revision: https://reviews.llvm.org/D107958
Dawid Jurczak [Tue, 10 Aug 2021 10:56:44 +0000 (12:56 +0200)]
[NFC][DSE] Clean up KnownNoReads and MemorySSAScanLimit in DSE
Another simple cleanups set in DSE. CheckCache is removed since
1f1145006b32 and in consequence KnownNoReads is useless.
Also update description of MemorySSAScanLimit which default value is 150 instead 100.
Differential Revision: https://reviews.llvm.org/D107812
Lang Hames [Sat, 14 Aug 2021 08:27:16 +0000 (18:27 +1000)]
[JITLink][x86-64] Rename *Relaxable edges to *REXRelaxable.
The existing relaxable edges all assume a REX prefix. ELF includes non-REX
relaxations, so rename these edges to make room for the new kinds.
Lang Hames [Sat, 14 Aug 2021 07:49:31 +0000 (17:49 +1000)]
[JITLink][x86-64] Rename BranchPCRel32ToPtrJumpStub(Relaxable -> Bypassable).
ELF allows for branch optimizations other than bypass, so rename this edge kind
to avoid any confusion.
Anshil Gandhi [Sat, 14 Aug 2021 05:58:04 +0000 (23:58 -0600)]
Revert "[Remarks] Emit optimization remarks for atomics generating CAS loop"
This reverts commit
c4e5425aa579d21530ef1766d7144b38a347f247.
Anshil Gandhi [Fri, 13 Aug 2021 22:32:02 +0000 (16:32 -0600)]
[Remarks] Emit optimization remarks for atomics generating CAS loop
Implements ORE in AtomicExpandPass to report atomics generating a compare
and swap loop.
Differential Revision: https://reviews.llvm.org/D106891
liuke [Sat, 14 Aug 2021 02:47:27 +0000 (10:47 +0800)]
[clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init
The overload of the constructor will repeatedly fix the member variables that need to be initialized.
Removed the duplicate '{}'.
```
struct A {
A() {}
A(int) {}
int _var; // int _var{}{}; <-- wrong fix
};
```
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D107641
David Blaikie [Fri, 13 Aug 2021 05:56:43 +0000 (22:56 -0700)]
Migrate DWARFVerifier tests to lit-based yaml instead of gtest with embedded yaml
Improves maintainability (edit/modify the tests without recompiling) and
error messages (previously the failure would be a gtest failure
mentioning nothing of the input or desired text) and the option to
improve tests with more checks.
(maybe these tests shouldn't all be in separate files - we could
probably have DWARF yaml that contains multiple errors while still being
fairly maintainable - the various invalid offsets (ref_addr, rnglists,
ranges, etc) could probably be all in one test, but for the simple sake
of the migration I just did the mechanical thing here)
Jessica Paquette [Wed, 11 Aug 2021 20:20:33 +0000 (13:20 -0700)]
[GlobalISel] Narrow binops feeding into G_AND with a mask
This is a fairly common pattern:
```
%mask = G_CONSTANT iN <mask val>
%add = G_ADD %lhs, %rhs
%and = G_AND %add, %mask
```
We have combines to eliminate G_AND with a mask that does nothing.
If we combined the above to this:
```
%mask = G_CONSTANT iN <mask val>
%narrow_lhs = G_TRUNC %lhs
%narrow_rhs = G_TRUNC %rhs
%narrow_add = G_ADD %narrow_lhs, %narrow_rhs
%ext = G_ZEXT %narrow_add
%and = G_AND %ext, %mask
```
We'd be able to take advantage of those combines using the trunc + zext.
For this to work (or be beneficial in the best case)
- The operation we want to narrow then widen must only be used by the G_AND
- The G_TRUNC + G_ZEXT must be free
- Performing the operation at a narrower width must not produce a different
value than performing it at the original width *after masking.*
Example comparison between SDAG + GISel: https://godbolt.org/z/63jzb1Yvj
At -Os for AArch64, this is a 0.2% code size improvement on CTMark/pairlocalign.
Differential Revision: https://reviews.llvm.org/D107929
Matt Arsenault [Sat, 31 Jul 2021 16:05:33 +0000 (12:05 -0400)]
GlobalISel: Add helper function for getting EVT from LLT
This can only give an imperfect approximation, but is enough to avoid
crashing in places where we call into EVT functions starting from LLTs.
Craig Topper [Sat, 14 Aug 2021 00:39:52 +0000 (17:39 -0700)]
[RISCV] Support RISCVISD::SELECT_CC in ComputeNumSignBitsForTargetNode.
Matt Arsenault [Thu, 12 Aug 2021 19:19:54 +0000 (15:19 -0400)]
AMDGPU: Stop attributor adding attributes to intrinsic declarations
Matt Arsenault [Wed, 11 Aug 2021 23:01:30 +0000 (19:01 -0400)]
AMDGPU: Add indirect and extern calls to attributor test
Matt Arsenault [Fri, 13 Aug 2021 13:20:17 +0000 (09:20 -0400)]
AMDGPU: Respect compute ABI attributes with unknown OS
Unfortunately Mesa is still using amdgcn-- as the triple for OpenGL,
so we still have the awkward unknown OS case to deal with. Previously
if the HSA ABI intrinsics appeared, we we would not add the ABI
registers to the function. We would emit an error later, but we still
need to produce some compile result. Start adding the registers to any
compute function, regardless of the OS. This keeps the internal state
more consistent, and will help avoid numerous test crashes in a future
patch which starts assuming the ABI inputs are present on functions by
default.
Arthur Eubanks [Fri, 13 Aug 2021 23:56:42 +0000 (16:56 -0700)]
[NFC] One more AttributeList::getAttribute(FunctionIndex) -> getFnAttr()
Arthur Eubanks [Sat, 7 Aug 2021 07:28:19 +0000 (00:28 -0700)]
[CallPromotion] Check for inalloca/byval mismatch
Previously we would allow promotion even if the byval/inalloca
attributes on the call and the callee didn't match.
It's ok if the byval/inalloca types aren't the same. For example, LTO
importing may rename types.
Fixes PR51397.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D107998
Arthur Eubanks [Fri, 13 Aug 2021 23:49:05 +0000 (16:49 -0700)]
[NFC] One more AttributeList::getAttribute(FunctionIndex) -> getFnAttr()
Arthur Eubanks [Fri, 13 Aug 2021 21:35:48 +0000 (14:35 -0700)]
[NFC] Make AttributeList::hasAttribute(AttributeList::ReturnIndex) its own method
AttributeList::hasAttribute() is confusing. In an attempt to change the
name to something that suggests using other methods, fix up some
existing uses.
Arthur Eubanks [Fri, 13 Aug 2021 21:16:44 +0000 (14:16 -0700)]
[NFC] Cleanup calls to AttributeList::getAttribute(FunctionIndex)
getAttribute() is confusing, use a clearer method.
zoecarver [Fri, 13 Aug 2021 18:36:55 +0000 (11:36 -0700)]
[libcxx][ranges] Move `namespace views` into `namespace ranges` and add an alias.
Differential Revision: https://reviews.llvm.org/D108047
Manoj Gupta [Fri, 13 Aug 2021 20:25:14 +0000 (13:25 -0700)]
[lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set
When cross compiling lldb-server, do not create a host build
for building lldb-tblgeb when LLDB_TABLEGEN_EXE is already
provided. This avoids an expensive and time-consuming build step
if lldb-tblgen was already built previously for host.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D108053
Sanjay Patel [Fri, 13 Aug 2021 21:03:22 +0000 (17:03 -0400)]
[x86] add tests for fcmps with logic ops; NFC
harsh-nod [Fri, 13 Aug 2021 19:54:30 +0000 (12:54 -0700)]
[mlir] Add support for moving reductions to outer most dimensions in vector.multi_reduction
The approach for handling reductions in the outer most
dimension follows that for inner most dimensions, outlined
below
First, transpose to move reduction dims, if needed
Convert reduction from n-d to 2-d canonical form
Then, for outer reductions, we emit the appropriate op
(add/mul/min/max/or/and/xor) and combine the results.
Differential Revision: https://reviews.llvm.org/D107675
Arthur Eubanks [Fri, 13 Aug 2021 19:07:05 +0000 (12:07 -0700)]
[NFC] Cleanup callers of AttributeList::hasAttributes()
AttributeList::hasAttributes() is confusing, use clearer methods like
hasFnAttrs().
Arthur Eubanks [Fri, 13 Aug 2021 18:59:18 +0000 (11:59 -0700)]
[NFC] Clean up users of AttributeList::hasAttribute()
AttributeList::hasAttribute() is confusing, use clearer methods like
hasParamAttr()/hasRetAttr().
Add hasRetAttr() since it was missing from AttributeList.
Arthur Eubanks [Fri, 13 Aug 2021 18:37:26 +0000 (11:37 -0700)]
[NFC] Remove public uses of AttributeList::getAttributes()
Use methods that better convey the intent.
LLVM GN Syncbot [Fri, 13 Aug 2021 18:34:09 +0000 (18:34 +0000)]
[gn build] Port
df324bba5c4c
LLVM GN Syncbot [Fri, 13 Aug 2021 18:34:09 +0000 (18:34 +0000)]
[gn build] Port
7b20e05c714e
zoecarver [Fri, 6 Aug 2021 22:33:46 +0000 (15:33 -0700)]
[libcxx][ranges] Add `ranges::join_view`.
Differential Revision: https://reviews.llvm.org/D107671
zoecarver [Tue, 3 Aug 2021 20:05:20 +0000 (13:05 -0700)]
[libcxx][ranges] Add `ranges::iota_view`.
Differential Revision: https://reviews.llvm.org/D107396
Arthur Eubanks [Fri, 13 Aug 2021 18:29:20 +0000 (11:29 -0700)]
Add missed rename of getFnAttributes() -> getFnAttrs()
Arthur Eubanks [Fri, 13 Aug 2021 18:16:52 +0000 (11:16 -0700)]
[NFC] Rename AttributeList::getParam/Ret/FnAttributes() -> get*Attributes()
This is more consistent with similar methods.
Arthur Eubanks [Fri, 13 Aug 2021 18:09:18 +0000 (11:09 -0700)]
[NFC] Rename AttributeList::hasFnAttribute() -> hasFnAttr()
This is more consistent with similar methods.
Arthur Eubanks [Fri, 13 Aug 2021 17:57:15 +0000 (10:57 -0700)]
[NFC] Remove AttributeList::hasParamAttribute()
It's the same as AttributeList::hasParamAttr().
Michael Kruse [Fri, 13 Aug 2021 17:39:23 +0000 (12:39 -0500)]
[Polly] Rename CodeGen -> generateCode. NFC.
To conform to function naming convention: camelCase and start with a
verb.
Michael Kruse [Fri, 13 Aug 2021 17:26:35 +0000 (12:26 -0500)]
[Polly] Decompose object construction and detection algorithm. NFC.
Avoid doing the detection work inside the constructor. In addition to
polymorphism being unintuitive in constructors and other design problems
such as if an exception is thrown, the ScopDetection class is usable
without detection in the sense of "no Scop found" or "function skipped".
Amy Kwan [Fri, 13 Aug 2021 16:22:38 +0000 (11:22 -0500)]
[PowerPC] Disable CTR Loop generate for fma with the PPC double double type.
It is possible to generate the llvm.fmuladd.ppcf128 intrinsic, and there is no actual
FMA instruction that corresponds to this intrinsic call for ppcf128. Thus, this
intrinsic needs to remain as a call as it cannot be lowered to any instruction, which
also means we need to disable CTR loop generation for fma involving the ppcf128 type.
This patch accomplishes this behaviour.
Differential Revision: https://reviews.llvm.org/D107914
Haowei Wu [Thu, 12 Aug 2021 21:33:47 +0000 (14:33 -0700)]
[IFS] Fix the copy constructor warning in IFSStub.cpp
This change fixes the gcc warning on copy constructor in IFSStub.cpp
file.
Differential Revision: https://reviews.llvm.org/D108000
Kiran Chandramohan [Fri, 13 Aug 2021 17:05:35 +0000 (18:05 +0100)]
[Flang] Fix for CI failure, Remove default case
Remove default case when all the enum values are covered in switch
statements.
Florian Mayer [Fri, 13 Aug 2021 15:24:11 +0000 (16:24 +0100)]
[sanitizer_common] disable format errors.
This broke https://lab.llvm.org/buildbot/#/builders/37/builds/6061/steps/32/logs/stdio
Reviewed By: dvyukov
Differential Revision: https://reviews.llvm.org/D108042
Craig Topper [Fri, 13 Aug 2021 16:42:06 +0000 (09:42 -0700)]
[Clang] Add an explicit makeArrayRef to appease gcc 5.4.
Craig Topper [Fri, 13 Aug 2021 16:22:43 +0000 (09:22 -0700)]
[X86] Add parentheses around casts in some of the X86 intrinsic headers.
This covers the SSE and AVX/AVX2 headers. AVX512 has a lot more macros
due to rounding mode.
Fixes part of PR51324.
Reviewed By: pengfei
Differential Revision: https://reviews.llvm.org/D107843
Alfonso Gregory [Fri, 13 Aug 2021 16:31:13 +0000 (09:31 -0700)]
[AsmWriter][NFC] Simplify writeDIGenericSubrange
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D107469
Jessica Paquette [Mon, 9 Aug 2021 18:41:52 +0000 (11:41 -0700)]
[AArch64][GlobalISel] Legalize scalar G_SSUBSAT + G_SADDSAT
These are lowered, matching SDAG behaviour. (See
llvm/test/CodeGen/AArch64/ssub_sat.ll and llvm/test/CodeGen/AArch64/sadd_sat.ll)
These fall back ~159 times on a build of clang with GISel enabled.
Differential Revision: https://reviews.llvm.org/D107777
Lorenzo Chelini [Fri, 13 Aug 2021 16:00:14 +0000 (18:00 +0200)]
[MLIR][Linalg] Fix typo
Dmitry Vyukov [Fri, 13 Aug 2021 15:16:27 +0000 (17:16 +0200)]
tsan/dd: fix format strings
Reviewed By: melver
Differential Revision: https://reviews.llvm.org/D108040
David Spickett [Fri, 13 Aug 2021 15:25:32 +0000 (16:25 +0100)]
Revert "[clang-format] Distinguish K&R C function definition and attribute"
This reverts commit
de763c4037157e60551ba227ccd0ed02e109c317.
Causing test failures on the Arm/AArch64 quick bots:
https://lab.llvm.org/buildbot/#/builders/188/builds/2202
Jamie Schmeiser [Fri, 13 Aug 2021 14:53:24 +0000 (10:53 -0400)]
Fix bad assert in print-changed code
Summary:
The assertion that both functions were not missing was incorrect and would
fail when one of the functions was missing. Fixed it and moved the
assertion earlier to check the input parameters to better capture
first-failure. Added lit test.
Author: Jamie Schmeiser <schmeise@ca.ibm.com>
Reviewed By: aeubanks (Arthur Eubanks)
Differential Revision: https://reviews.llvm.org/D107989
Roman Lebedev [Fri, 13 Aug 2021 14:38:36 +0000 (17:38 +0300)]
Revert "[SCEV] Remove premature assert. PR46786"
Since then, the SCEV pointer handling as been improved,
so the assertion should now hold.
This reverts commit
b96114c1e1fc4448ea966bce013706359aee3fa9,
relanding the assertion from commit
141e845da5dda6743a09f858b4aec0133a931453.
Peixin Qiao [Fri, 13 Aug 2021 14:20:38 +0000 (10:20 -0400)]
[flang][OpenMP] Add semantic check for teams nesting
This patch implements the following check for TEAMS construct:
```
OpenMP Version 5.0 Teams construct restriction: A teams region can
only be strictly nested within the implicit parallel region or a target
region. If a teams construct is nested within a target construct, that
target construct must contain no statements, declarations or directives
outside of the teams construct.
```
Also add one test case for the check.
Reviewed By: kiranchandramohan, clementval
Differential Revision: https://reviews.llvm.org/D106335
Dmitry Vyukov [Fri, 13 Aug 2021 13:24:23 +0000 (15:24 +0200)]
tsan: fix latent bug in shadow computation
We use kShadowCnt (number of shadow cells per application granule)
when computing shadow, but it's wrong. We need the ratio
between shadow and app memory (how much shadow is larger than app memory),
which is kShadowMultiplier.
Currently both are equal to 4, so it works fine.
Use the correct constant.
Reviewed By: melver
Differential Revision: https://reviews.llvm.org/D108033
Kristóf Umann [Fri, 13 Aug 2021 13:46:32 +0000 (15:46 +0200)]
[analyzer][NFC] Make test/Analysis/self-assign.cpp readable
Peixin Qiao [Fri, 13 Aug 2021 12:19:01 +0000 (08:19 -0400)]
[flang][OpenMP] Add semantic checks for cancellation nesting
This patch implements the following semantic checks for cancellation constructs:
```
OpenMP Version 5.0 Section 2.18.1: CANCEL construct restriction:
If construct-type-clause is taskgroup, the cancel construct must be
closely nested inside a task or a taskloop construct and the cancel
region must be closely nested inside a taskgroup region. If
construct-type-clause is sections, the cancel construct must be closely
nested inside a sections or section construct. Otherwise, the cancel
construct must be closely nested inside an OpenMP construct that matches
the type specified in construct-type-clause of the cancel construct.
OpenMP Version 5.0 Section 2.18.2: CANCELLATION POINT restriction:
A cancellation point construct for which construct-type-clause is
taskgroup must be closely nested inside a task or taskloop construct,
and the cancellation point region must be closely nested inside a
taskgroup region. A cancellation point construct for which
construct-type-clause is sections must be closely nested inside a
sections or section construct. A cancellation point construct for which
construct-type-clause is neither sections nor taskgroup must be closely
nested inside an OpenMP construct that matches the type specified in
construct-type-clause.
```
Also add test cases for the check.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D106538
Alexey Bader [Fri, 13 Aug 2021 06:04:09 +0000 (09:04 +0300)]
[NFC] Drop idle compiler option from the test.
Differential Revision: https://reviews.llvm.org/D108020
Justas Janickas [Fri, 6 Aug 2021 12:50:13 +0000 (13:50 +0100)]
[OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.
Some Clang diagnostics could only report OpenCL C version. Because
C++ for OpenCL can be used as an alternative to OpenCL C, the text
for diagnostics should reflect that.
Desrciptions modified for these diagnostics:
`err_opencl_unknown_type_specifier`
`warn_option_invalid_ocl_version`
`err_attribute_requires_opencl_version`
`warn_opencl_attr_deprecated_ignored`
`ext_opencl_ext_vector_type_rgba_selector`
Differential Revision: https://reviews.llvm.org/D107648
Roman Lebedev [Fri, 13 Aug 2021 12:08:10 +0000 (15:08 +0300)]
Reland "[NFCI][SimplifyCFG] simplifyCondBranch(): assert that branch is non-tautological""
The commit originally unearthed a problem, reported as
https://reviews.llvm.org/rGf30a7dff8a5b32919951dcbf92e4a9d56c4679ff#1019890
Now that the problem has been fixed, and the assertion no longer fires,
let's see if there are other cases it fires on.
This reverts commit
5c8c24d2decae4a76047777271d60411fc3316eb,
relanding commit
f30a7dff8a5b32919951dcbf92e4a9d56c4679ff.
Roman Lebedev [Fri, 13 Aug 2021 12:35:01 +0000 (15:35 +0300)]
[SimplifyCFG] Restart if `removeUndefIntroducingPredecessor()` made changes
It might changed the condition of a branch into a constant,
so we should restart and constant-fold terminator,
instead of continuing with the tautological "conditional" branch.
This fixes the issue reported at https://reviews.llvm.org/rGf30a7dff8a5b32919951dcbf92e4a9d56c4679ff
Roman Lebedev [Fri, 13 Aug 2021 12:08:00 +0000 (15:08 +0300)]
[NFC][SimplifyCFG] Add test for failed assertion
This would trigger an assertion that was added in rGf30a7dff8a5b.
Need to fix that before relanding.
Reduced from https://reviews.llvm.org/rGf30a7dff8a5b#1019890
Rainer Orth [Fri, 13 Aug 2021 12:31:32 +0000 (14:31 +0200)]
[MC][ELF] Mark Solaris objects as ELFOSABI_SOLARIS
Prompted by D107747 <https://reviews.llvm.org/D107747>, it seems prudent to
mark objects as `ELFOSABI_SOLARIS` on Solaris.
Tested on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and
`x86_64-pc-linux-gnu`.
Differential Revision: https://reviews.llvm.org/D107748
Owen [Thu, 12 Aug 2021 13:12:25 +0000 (06:12 -0700)]
[clang-format] Distinguish K&R C function definition and attribute
This is a follow-up to https://reviews.llvm.org/D107950 which
missed user-defined types in K&R C.
Differential Revision: https://reviews.llvm.org/D107961
Adrian Kuegel [Fri, 13 Aug 2021 11:43:58 +0000 (13:43 +0200)]
[mlir] Remove unused header include.
Also adjust BUILD.bazel and remove an unused dependency.
Differential Revision: https://reviews.llvm.org/D108027
Dmitry Vyukov [Fri, 13 Aug 2021 05:29:41 +0000 (07:29 +0200)]
scudo/standalone: prepare for enabling format string checking
Move __attribute__((format)) to the function declarations in the header file.
It's almost pointless in the source file.
But disable the warning with -Wno-format for now
since there is a number of existing warnings.
Depends on D107984.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D108014
Dmitry Vyukov [Thu, 12 Aug 2021 18:00:16 +0000 (20:00 +0200)]
ubsan: fix few format string bugs
This fixes just a few of the warnings.
Ubsan is not completely clean yet,
but these somehow pop up while I was
fixing other sanitizers.
Depends on D107983.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107984
Dmitry Vyukov [Thu, 12 Aug 2021 17:57:31 +0000 (19:57 +0200)]
tsan: clean up and enable format string checking
Depends on D107982.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107983
Dmitry Vyukov [Thu, 12 Aug 2021 17:55:59 +0000 (19:55 +0200)]
msan: clean up and enable format string checking
Depends on D107981.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107982
Dmitry Vyukov [Thu, 12 Aug 2021 17:52:24 +0000 (19:52 +0200)]
sanitizer_common: enable format string checking
Enable -Wformat in sanitizer_common now that it's
cleaned up from existing warnings.
But disable it in all sanitizers for now since
they are not cleaned up yet, but inherit sanitizer_common CFLAGS.
Depends on D107980.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107981
Dmitry Vyukov [Thu, 12 Aug 2021 17:47:23 +0000 (19:47 +0200)]
sanitizer_common: fix format strings
Fix existing -Wformat warnings.
Depends on D107979.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107980
Dmitry Vyukov [Fri, 13 Aug 2021 05:36:56 +0000 (07:36 +0200)]
sanitizer_common: declare vars more locally in VSNPrintf
No point in declaring variables separately before use.
Depends on D107979.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D108015
Dmitry Vyukov [Thu, 12 Aug 2021 18:07:05 +0000 (20:07 +0200)]
Revert "sanitizer_common: support printing __m128i type"
This reverts commits
"sanitizer_common: support printing __m128i type"
and "[sanitizer] Fix VSNPrintf %V on Windows".
Unfortunately, custom "%V" is inherently incompatible with -Wformat,
it produces both:
warning: invalid conversion specifier 'V' [-Wformat-invalid-specifier]
warning: data argument not used by format string [-Wformat-extra-args]
If we disable both of these warnings we lose lots of useful warnings as well.
Depends on D107978.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107979
Dmitry Vyukov [Thu, 12 Aug 2021 17:59:12 +0000 (19:59 +0200)]
scudo: fix __attribute__((format))
The attribute should be in the header on declaration.
It's almost pointless in the source file.
Depends on D107977.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107978
Dmitry Vyukov [Thu, 12 Aug 2021 17:37:29 +0000 (19:37 +0200)]
sanitizer_common: prepare for enabling format string checking
The __attribute__((format)) was added somewhere in 2012,
the lost during refactoring, then re-added in 2014 but
to te source files, which is a no-op.
Move it back to header files so that it actually takes effect.
But over the past 7 years we've accumulated whole lot of
format string bugs of different types, so disable the warning
with -Wno-format for now for incremental clean up.
Among the bugs that it warns about are all kinds of bad things:
- wrong sizes of arguments
- missing/excessive arguments
- printing wrong things (e.g. *ptr instead of ptr)
- completely messed up format strings
- security issues where external string is used as format
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107977
Florian Mayer [Fri, 13 Aug 2021 10:50:52 +0000 (11:50 +0100)]
[hwasan] Fix wild free tests on x86.
Jan Svoboda [Fri, 13 Aug 2021 10:48:14 +0000 (12:48 +0200)]
[clang][deps] Move `SingleCommandCompilationDatabase` to a header
This makes `SingleCommandCompilationDatabase` reusable.
Roman Lebedev [Fri, 13 Aug 2021 10:15:24 +0000 (13:15 +0300)]
Revert "[NFCI][SimplifyCFG] simplifyCondBranch(): assert that branch is non-tautological"
The assertion does not hold on a provided reproducer.
Reverting until after fixing the problem.
This reverts commit
f30a7dff8a5b32919951dcbf92e4a9d56c4679ff.
Dylan Fleming [Fri, 13 Aug 2021 08:36:31 +0000 (09:36 +0100)]
[SVE] Add folds for truncation of vscale
Reviewed By: david-arm
Differential Revision: https://reviews.llvm.org/D107453
Rosie Sumpter [Mon, 9 Aug 2021 11:51:17 +0000 (12:51 +0100)]
[LoopFlatten] Fix assertion failure in checkOverflow
There is an assertion failure in computeOverflowForUnsignedMul
(used in checkOverflow) due to the inner and outer trip counts
having different types. This occurs when the IV has been widened,
but the loop components are not successfully rediscovered.
This is fixed by some refactoring of the code in findLoopComponents
which identifies the trip count of the loop.
Alexey Bader [Mon, 24 May 2021 08:38:16 +0000 (11:38 +0300)]
[NFC] Add commas in code comments.
Sam McCall [Fri, 13 Aug 2021 08:38:42 +0000 (10:38 +0200)]
[clangd] Guard against null Attrs in the AST
Andrzej Warzynski [Thu, 12 Aug 2021 19:17:39 +0000 (19:17 +0000)]
[flang][nfc] Remove `flang-new-driver` from LIT
After merging https://reviews.llvm.org/D105811, `flang-new-driver` is no
longer required.
Differential Revision: https://reviews.llvm.org/D107990