bungeman@google.com [Tue, 20 Aug 2013 15:20:34 +0000 (15:20 +0000)]
Fix stack buffer read overflow in GrConvolutionEffect::TestCreate.
BUG=skia:1532
R=bsalomon@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
23340003
git-svn-id: http://skia.googlecode.com/svn/trunk@10816
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 Aug 2013 15:12:01 +0000 (15:12 +0000)]
Change comments about size internal formats
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22912007
git-svn-id: http://skia.googlecode.com/svn/trunk@10815
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 Aug 2013 14:45:45 +0000 (14:45 +0000)]
Add direct bezier cubic support for GPU shaders
BUG=
R=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
Author: egdaniel@google.com
Review URL: https://chromiumcodereview.appspot.com/
22900007
git-svn-id: http://skia.googlecode.com/svn/trunk@10814
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 20 Aug 2013 14:36:59 +0000 (14:36 +0000)]
Revert r10788 (allow both GDI and DW fontmgrs at the same time) due to Chromium XP bot failures
git-svn-id: http://skia.googlecode.com/svn/trunk@10813
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 20 Aug 2013 14:31:59 +0000 (14:31 +0000)]
Final rebaselines for r10769.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10812
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 20 Aug 2013 13:48:33 +0000 (13:48 +0000)]
Revert "Changed rules about sized internal formats on GLES3."
This reverts commit r10806.
git-svn-id: http://skia.googlecode.com/svn/trunk@10811
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 20 Aug 2013 12:28:23 +0000 (12:28 +0000)]
Fix merge problem between r10805 and 10803
git-svn-id: http://skia.googlecode.com/svn/trunk@10810
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 Aug 2013 12:23:18 +0000 (12:23 +0000)]
Add correctness test to bbh_shootout.
R=caryclark@google.com, reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/
23121002
git-svn-id: http://skia.googlecode.com/svn/trunk@10809
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 Aug 2013 12:23:06 +0000 (12:23 +0000)]
Replace uses of GR_API by SK_API.
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22881005
git-svn-id: http://skia.googlecode.com/svn/trunk@10808
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 20 Aug 2013 12:22:57 +0000 (12:22 +0000)]
default to device type of last build if no device type is given
R=borenet@google.com
Review URL: https://codereview.chromium.org/
22929006
git-svn-id: http://skia.googlecode.com/svn/trunk@10807
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 Aug 2013 12:22:48 +0000 (12:22 +0000)]
Changed rules about sized internal formats on GLES3.
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22823006
git-svn-id: http://skia.googlecode.com/svn/trunk@10806
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 20 Aug 2013 12:13:48 +0000 (12:13 +0000)]
Fix name of "bleed" flag
https://codereview.chromium.org/
22812014/
git-svn-id: http://skia.googlecode.com/svn/trunk@10805
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 20 Aug 2013 12:11:31 +0000 (12:11 +0000)]
Fix for nested rect drawing bug
https://codereview.chromium.org/
22824016/
git-svn-id: http://skia.googlecode.com/svn/trunk@10804
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 20 Aug 2013 12:09:32 +0000 (12:09 +0000)]
Update tiled bitmap path to respect bleed flag
https://codereview.chromium.org/
23261003/
git-svn-id: http://skia.googlecode.com/svn/trunk@10803
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 20 Aug 2013 07:01:14 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10802
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 19 Aug 2013 21:28:18 +0000 (21:28 +0000)]
Remove unused typedef.
git-svn-id: http://skia.googlecode.com/svn/trunk@10801
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 19 Aug 2013 20:05:38 +0000 (20:05 +0000)]
Fix size_t to int conversion warning on Win64 in SkRTConf.h.
Review URL: https://codereview.chromium.org/
23213004
git-svn-id: http://skia.googlecode.com/svn/trunk@10800
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 19 Aug 2013 18:51:32 +0000 (18:51 +0000)]
Refer to the correct file for rebaselining benches.
The file has moved, so update the instructions in the
expectations file.
R=bensong@google.com
Review URL: https://codereview.chromium.org/
23033009
git-svn-id: http://skia.googlecode.com/svn/trunk@10799
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 19 Aug 2013 18:43:34 +0000 (18:43 +0000)]
add new GM to try to reproduce a bug
BUG=7671058
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
23299004
git-svn-id: http://skia.googlecode.com/svn/trunk@10798
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 19 Aug 2013 18:38:08 +0000 (18:38 +0000)]
skia: Added SkDiscardableMemory interface.
Chrome's implementation of SkDiscardableMemory is provided here:
https://codereview.chromium.org/
23206002. SkDiscardableMemory is
intended to be used for image caching.
R=reed@google.com, scroggo@google.com, hclam@chromium.org, jamesr@chromium.org
BUG=229120
Author=ernstm@chromium.org
Submitted on behalf of ernstm@chromium.org due to commit queue bug.
Review URL: https://codereview.chromium.org/
22950012
git-svn-id: http://skia.googlecode.com/svn/trunk@10797
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 19 Aug 2013 18:26:04 +0000 (18:26 +0000)]
Add libraries to fix Ubuntu13 Clang build
R=bungeman@google.com, djsollen@google.com
Review URL: https://codereview.chromium.org/
23281003
git-svn-id: http://skia.googlecode.com/svn/trunk@10796
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 19 Aug 2013 17:30:50 +0000 (17:30 +0000)]
Whitespace change to test bots
Review URL: https://codereview.chromium.org/
23331002
git-svn-id: http://skia.googlecode.com/svn/trunk@10794
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 19 Aug 2013 13:35:47 +0000 (13:35 +0000)]
Whitespace change to test the new master.
git-svn-id: http://skia.googlecode.com/svn/trunk@10793
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 17 Aug 2013 07:01:54 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10790
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Sat, 17 Aug 2013 00:02:59 +0000 (00:02 +0000)]
Replace uses of GrAssert by SkASSERT.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
22850006
git-svn-id: http://skia.googlecode.com/svn/trunk@10789
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 16 Aug 2013 20:31:11 +0000 (20:31 +0000)]
allow both GDI and DW fontmgrs at the same time
BUG=
R=bungeman@google.com
Committed: https://code.google.com/p/skia/source/detail?r=10718
Review URL: https://codereview.chromium.org/
23058002
git-svn-id: http://skia.googlecode.com/svn/trunk@10788
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 16 Aug 2013 19:48:40 +0000 (19:48 +0000)]
Win7 performance trigger rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10787
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 19:18:12 +0000 (19:18 +0000)]
Fixes for factory GM.
Skip cross process pipe playback in gm/factory.cpp. Add a new flag to
gm.h to skip only this form of pipe playback.
In gmmain.cpp, use a bitmap encoder function for serialization that
stores the encoded data if present, and use a bitmap decoder on
deserialization. This allows gm/factory to work through serialization.
Also respect the new pipe skipping flag.
BUG=https://code.google.com/p/skia/issues/detail?id=1231
R=borenet@google.com
Author: scroggo@google.com
Review URL: https://chromiumcodereview.appspot.com/
23192004
git-svn-id: http://skia.googlecode.com/svn/trunk@10786
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 18:13:48 +0000 (18:13 +0000)]
Always support NPOT tiling/MIPs on ES3
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22887022
git-svn-id: http://skia.googlecode.com/svn/trunk@10784
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 16 Aug 2013 17:37:31 +0000 (17:37 +0000)]
pdfviewer: remove one #include to STL, that is not needed
Review URL: https://codereview.chromium.org/
23082004
git-svn-id: http://skia.googlecode.com/svn/trunk@10783
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 16 Aug 2013 17:07:20 +0000 (17:07 +0000)]
More rebaselines for r10769.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10782
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 16 Aug 2013 17:01:24 +0000 (17:01 +0000)]
pdfviewer: fix typo in sample app
Review URL: https://codereview.chromium.org/
22861007
git-svn-id: http://skia.googlecode.com/svn/trunk@10781
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 16 Aug 2013 16:30:02 +0000 (16:30 +0000)]
pdfviewer: update interface of derived canvas and device, to reflect lastest changes in the interfaces.
Review URL: https://codereview.chromium.org/
23048006
git-svn-id: http://skia.googlecode.com/svn/trunk@10780
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 16 Aug 2013 16:13:44 +0000 (16:13 +0000)]
pdfviewer: (cleanup) put the gyp for library code in a separate file
Review URL: https://codereview.chromium.org/
23038004
git-svn-id: http://skia.googlecode.com/svn/trunk@10779
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 16:12:23 +0000 (16:12 +0000)]
Always support pack/unpack row length on ES3. Add support for NV_pack_subimage extension.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23003009
git-svn-id: http://skia.googlecode.com/svn/trunk@10778
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 15:53:46 +0000 (15:53 +0000)]
Change Atlas recycling to track current flush count and recycle if Atlas not used in current flush.
BUG=
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
23120004
git-svn-id: http://skia.googlecode.com/svn/trunk@10777
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 15:53:33 +0000 (15:53 +0000)]
Support VAO when on ES3.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22909015
git-svn-id: http://skia.googlecode.com/svn/trunk@10776
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 16 Aug 2013 15:44:52 +0000 (15:44 +0000)]
More rebaselines for r10769.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10775
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 16 Aug 2013 15:32:23 +0000 (15:32 +0000)]
First set of rebaselines for r10769.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10774
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 16 Aug 2013 15:05:08 +0000 (15:05 +0000)]
pdfviewer: code cleanup - remove STL usage
Review URL: https://codereview.chromium.org/
23258004
git-svn-id: http://skia.googlecode.com/svn/trunk@10772
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 16 Aug 2013 15:01:03 +0000 (15:01 +0000)]
Ubuntu flaky performance trigger rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10770
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 16 Aug 2013 14:51:51 +0000 (14:51 +0000)]
Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=10640
Committed: http://code.google.com/p/skia/source/detail?r=10707
R=bsalomon@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
22486003
git-svn-id: http://skia.googlecode.com/svn/trunk@10769
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 16 Aug 2013 13:16:01 +0000 (13:16 +0000)]
more rebaselines of convexpaths
git-svn-id: http://skia.googlecode.com/svn/trunk@10766
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 10:24:37 +0000 (10:24 +0000)]
This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path.
R=bsalomon@google.com, reed@google.com, edisonn@google.com, scroggo@google.com, jvanverth@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
20806003
git-svn-id: http://skia.googlecode.com/svn/trunk@10765
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 16 Aug 2013 07:01:49 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10764
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 16 Aug 2013 01:01:01 +0000 (01:01 +0000)]
Patch for r10762
git-svn-id: http://skia.googlecode.com/svn/trunk@10763
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 00:53:34 +0000 (00:53 +0000)]
This CL addresses "SkCanvas::save flags are not respected by GPU backend" (https://code.google.com/p/skia/issues/detail?id=1503).
R=reed@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
22947003
git-svn-id: http://skia.googlecode.com/svn/trunk@10762
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 16 Aug 2013 00:40:34 +0000 (00:40 +0000)]
This bench attempts to recreate Chromium's Canvas_putImageData performance test to track down https://code.google.com/p/chromium/issues/detail?id=270649.
Cranking the repitition count up to 500 on a MacPro yields:
WITHOUT 10624:
running bench [640 480] writepix_rgba_UPM 8888: cmsecs = 748.25 GPU: cmsecs = 225.95 gmsecs = 244.80
running bench [640 480] writepix_rgba_PM 8888: cmsecs = 54.12 GPU: cmsecs = 225.77 gmsecs = 244.59
WITH 10624:
running bench [640 480] writepix_rgba_UPM 8888: cmsecs = 747.70 GPU: cmsecs = 230.30 gmsecs = 249.51
running bench [640 480] writepix_rgba_PM 8888: cmsecs = 55.05 GPU: cmsecs = 230.13 gmsecs = 249.38
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
22895012
git-svn-id: http://skia.googlecode.com/svn/trunk@10761
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 15 Aug 2013 23:53:11 +0000 (23:53 +0000)]
Revert "Make SkMatrix44::invert() check for finite 1/det instead of magic value"
This reverts commit
f109b4ac6ef21ccb8b76891e50e63dae820af116.
git-svn-id: http://skia.googlecode.com/svn/trunk@10760
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 15 Aug 2013 22:42:54 +0000 (22:42 +0000)]
Revert r10718 to unblock roll
git-svn-id: http://skia.googlecode.com/svn/trunk@10759
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 Aug 2013 21:56:38 +0000 (21:56 +0000)]
Make SkMatrix44::invert() check for finite 1/det instead of magic value
Previously we were checking to see if the magnitude of determinant of the
matrix to be inverted was less than 1.0e-8, which is a magic number possibly
plucked from Graphics Gems. After some discussion, it's been determined (ha)
that we can simply check to see if 1/det is finite and if so proceed.
BUG=222926
R=reed@google.com, shawnsingh@chromium.org
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
22904003
git-svn-id: http://skia.googlecode.com/svn/trunk@10758
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Thu, 15 Aug 2013 21:20:14 +0000 (21:20 +0000)]
Nobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it.
I left the dummy value in the flattened paint. I'm hoping to do an overhaul of
the paint serialization format which will need a picture version bump anyway,
so it can all go together. If that doesn't pan out we can remove this on its
own later.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
23056005
git-svn-id: http://skia.googlecode.com/svn/trunk@10757
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Thu, 15 Aug 2013 21:14:51 +0000 (21:14 +0000)]
Update how SkPath handles fGenerationID and fSourcePath, and add tests to cover.
BUG=
R=bungeman@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
22911002
git-svn-id: http://skia.googlecode.com/svn/trunk@10756
2bbb7eff-a529-9590-31e7-
b0007b416f81
egdaniel@google.com [Thu, 15 Aug 2013 21:12:11 +0000 (21:12 +0000)]
Add homogeneous point mapping to Matrix
Adds mapping of homogeneous points (points with three scalar components,
where the last component is not 1). Includes fix for tests when
running on 32 bit debug builds
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
22816005
git-svn-id: http://skia.googlecode.com/svn/trunk@10755
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Thu, 15 Aug 2013 21:01:32 +0000 (21:01 +0000)]
Write NULL as "" so readString() always returns a non-NULL string.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
22862002
git-svn-id: http://skia.googlecode.com/svn/trunk@10754
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 15 Aug 2013 20:57:42 +0000 (20:57 +0000)]
fine-tune tolerance for pinchy quads in stroker
BUG=
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
22947005
git-svn-id: http://skia.googlecode.com/svn/trunk@10753
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 20:34:45 +0000 (20:34 +0000)]
temporarily disable assert in convexpaths GM while it is debugged
git-svn-id: http://skia.googlecode.com/svn/trunk@10752
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 19:51:53 +0000 (19:51 +0000)]
Add missing baselines for convexpaths GM
git-svn-id: http://skia.googlecode.com/svn/trunk@10751
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 19:49:42 +0000 (19:49 +0000)]
rebaseline convex paths after test was changed.
git-svn-id: http://skia.googlecode.com/svn/trunk@10750
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 19:45:26 +0000 (19:45 +0000)]
temporary kES2_GrGLBinding alias to unblock DEPS roll
git-svn-id: http://skia.googlecode.com/svn/trunk@10749
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 18:57:53 +0000 (18:57 +0000)]
missing header from previous commit
git-svn-id: http://skia.googlecode.com/svn/trunk@10748
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 18:54:39 +0000 (18:54 +0000)]
Rename kES2_GrGLBinding to kES_GrGLBinding. Step 0 for supporting ES3.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
23185004
git-svn-id: http://skia.googlecode.com/svn/trunk@10747
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 15 Aug 2013 18:24:53 +0000 (18:24 +0000)]
Rebaseline GMs for Galaxy Nexus: looks like updated fonts and some GMs out of date.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10746
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:41 +0000 (18:16 +0000)]
Enable coverage when drawing to the stencil buffer.
Currently, we set kEmitTransBlack_BlendOptFlag when drawing to the stencil buffer - but that
prevents masks from being drawn correctly as they receive full coverage and no fragments get
discarded.
R=bsalomon@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23197003
git-svn-id: http://skia.googlecode.com/svn/trunk@10745
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:27 +0000 (18:16 +0000)]
Fix repeated point quads/cubics in convex pr and update convexpaths GM
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
23034003
git-svn-id: http://skia.googlecode.com/svn/trunk@10744
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:07 +0000 (18:16 +0000)]
Add missing fallback blending to SkA8_Shader_Blitter::blitMask()
Similarly to SkA8_Shader_Blitter::blitAntiH() and SkA8_Shader_Blitter::blitH(), blitMask() should handle a missing SkXfermode gracefully.
R=reed@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22867008
git-svn-id: http://skia.googlecode.com/svn/trunk@10743
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 15 Aug 2013 18:15:20 +0000 (18:15 +0000)]
Rebaseline GMs for Nexus-10: looks like fonts changed due to OS upgrade.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10742
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 17:42:33 +0000 (17:42 +0000)]
one more flakly GL_LINES win7/intel/gpu test to ignore
git-svn-id: http://skia.googlecode.com/svn/trunk@10741
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 17:10:28 +0000 (17:10 +0000)]
Expect to fail on images with GL_LINES snapping issue on win7/intel/gpu
git-svn-id: http://skia.googlecode.com/svn/trunk@10740
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 15:40:31 +0000 (15:40 +0000)]
try one last time for xfermodes3 pdf rebaselines, will delete if this doesn't stick
git-svn-id: http://skia.googlecode.com/svn/trunk@10739
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 15 Aug 2013 14:51:04 +0000 (14:51 +0000)]
Revert "Unpremultiply SkBitmaps for PDF output"
This reverts commit
16a6c9d28c8ef6f827d50ef258005fa5ec971bd9.
Seems to be breaking all of the windows debug bots in GM.
git-svn-id: http://skia.googlecode.com/svn/trunk@10737
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 15 Aug 2013 14:16:52 +0000 (14:16 +0000)]
Rebaseline Ubuntu after revert of r10705 (in r10729)
git-svn-id: http://skia.googlecode.com/svn/trunk@10731
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 15 Aug 2013 13:55:00 +0000 (13:55 +0000)]
Performance trigger rebaselines
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10730
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 15 Aug 2013 13:43:23 +0000 (13:43 +0000)]
Revert r10705 (ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG) due to 1000+ linux_layout failures (build.chromium.org/p/tryserver.chromium/builders/linux_layout_rel/builds/18997/steps/webkit_tests/logs/stdio)
git-svn-id: http://skia.googlecode.com/svn/trunk@10729
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 15 Aug 2013 13:43:01 +0000 (13:43 +0000)]
more xfermodes3 rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@10728
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 15 Aug 2013 07:01:06 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10727
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 14 Aug 2013 22:05:06 +0000 (22:05 +0000)]
pdfviewer: workaround gyp issue with multiple files, not being translated into an array in linux (works in mac, as per spec)
Review URL: https://codereview.chromium.org/
23157003
git-svn-id: http://skia.googlecode.com/svn/trunk@10726
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 22:02:23 +0000 (22:02 +0000)]
Unpremultiply SkBitmaps for PDF output
BUG=skia:236, chromium:175548
R=vandebo@chromium.org, edisonn@google.com, reed@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22329003
git-svn-id: http://skia.googlecode.com/svn/trunk@10725
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 21:56:47 +0000 (21:56 +0000)]
Refactor GM to separate config parsing, attempt 2
R=vandebo@chromium.org, reed@google.com, edisonn@google.com, epoger@google.com, scroggo@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
23072014
git-svn-id: http://skia.googlecode.com/svn/trunk@10724
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 21:56:37 +0000 (21:56 +0000)]
Add blend optimization helpers and use to convert rect draws to clears.
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22558003
git-svn-id: http://skia.googlecode.com/svn/trunk@10723
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 14 Aug 2013 21:55:32 +0000 (21:55 +0000)]
rebaseline xfermodes3 after change to the test.
git-svn-id: http://skia.googlecode.com/svn/trunk@10722
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 14 Aug 2013 21:35:27 +0000 (21:35 +0000)]
pdfviewer: make pdfviewer compile on mac
Review URL: https://codereview.chromium.org/
23163007
git-svn-id: http://skia.googlecode.com/svn/trunk@10721
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 19:20:45 +0000 (19:20 +0000)]
Make xfermodes3 GM also test stroked rects
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
22866002
git-svn-id: http://skia.googlecode.com/svn/trunk@10720
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 19:20:35 +0000 (19:20 +0000)]
fix path issues on mac and win for skpdiff_server.py
R=djsollen@google.com, epoger@google.com, jvanverth@google.com
Author: zachr@google.com
Review URL: https://chromiumcodereview.appspot.com/
22650009
git-svn-id: http://skia.googlecode.com/svn/trunk@10719
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 14 Aug 2013 18:59:28 +0000 (18:59 +0000)]
allow both GDI and DW fontmgrs at the same time
BUG=
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
23058002
git-svn-id: http://skia.googlecode.com/svn/trunk@10718
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Wed, 14 Aug 2013 18:37:27 +0000 (18:37 +0000)]
Deletes warning on no graph outputs, since we don't output graphs anymore.
Review URL: https://codereview.chromium.org/
23071002
git-svn-id: http://skia.googlecode.com/svn/trunk@10717
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 14 Aug 2013 18:26:20 +0000 (18:26 +0000)]
pdfviewer: 1) debug code for drawText (show magenta background for text, to show text even when we fail to load/show it), 2) some cleanup: refactor and rename classes and files
Review URL: https://codereview.chromium.org/
23020003
git-svn-id: http://skia.googlecode.com/svn/trunk@10716
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 18:14:37 +0000 (18:14 +0000)]
Fix crash when querying a runtime config that is defined in environment
Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.
Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.
Previous version of the patch failed Windows build due to setenv usage.
On Windows, use _putenv_s instead.
BUG=skia:1494
R=bsalomon@google.com, humper@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
23174002
git-svn-id: http://skia.googlecode.com/svn/trunk@10715
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 14 Aug 2013 18:14:31 +0000 (18:14 +0000)]
Delete compare_baselines.py and download_baselines.py ; we use rebaseline.py now
Review URL: https://codereview.chromium.org/
23082002
git-svn-id: http://skia.googlecode.com/svn/trunk@10714
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 18:14:19 +0000 (18:14 +0000)]
Refactor GrGLUniformManager::UniformHandle to initialize itself by default
Refactor GrGLUniformManager::UniformHandle to initialize itself to
"invalid" state by default. This simplifies the effect
constructors. In the future, it should also help catch potential
uninitialized uniform variable usage.
Remove unneeded explicit uniform handle validity assertions before the
handle usage. The assertion will always be made when handle is
converted to index.
BUG=skia:1492
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
22340010
git-svn-id: http://skia.googlecode.com/svn/trunk@10713
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 14 Aug 2013 16:22:02 +0000 (16:22 +0000)]
update expectations after SkLONGLONG change
BUG=
Review URL: https://codereview.chromium.org/
23198003
git-svn-id: http://skia.googlecode.com/svn/trunk@10712
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 14 Aug 2013 15:43:18 +0000 (15:43 +0000)]
Nexus 7 performance trigger rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10711
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 14 Aug 2013 15:40:30 +0000 (15:40 +0000)]
Another Win7 performance trigger rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10710
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 14 Aug 2013 14:29:29 +0000 (14:29 +0000)]
Reverting r10707. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@10709
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 14 Aug 2013 14:07:09 +0000 (14:07 +0000)]
Revert "Refactor gmmain to separate out config parsing"
This reverts commit
210340a02d7d56890a1630cc307b7263fbe9106f.
git-svn-id: http://skia.googlecode.com/svn/trunk@10708
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 13:02:13 +0000 (13:02 +0000)]
Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=10640
R=robertphillips@google.com, egdaniel@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
22486003
git-svn-id: http://skia.googlecode.com/svn/trunk@10707
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 12:09:00 +0000 (12:09 +0000)]
effects: Replaces uses of GrAssert with SkASSERT.
This is the first step on migrating from GrAssert to SkASSERT as requested by
Brian.
R=bsalomon@google.com, robertphillips@google.com, scroggo@google.com
Author: tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22418006
git-svn-id: http://skia.googlecode.com/svn/trunk@10706
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 11:43:52 +0000 (11:43 +0000)]
ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG
It removes SkLONGLONG and uses int64_t to implement the SkFixed
operations for which a SkLONGLONG version existed. It also
removes the 32 bit version that are being replaced.
BUG=
R=djsollen@google.com, reed@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/
18539004
git-svn-id: http://skia.googlecode.com/svn/trunk@10705
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 11:36:27 +0000 (11:36 +0000)]
Fix build with SK_SUPPORT_UNITTEST on
Fix build with SK_SUPPORT_UNITTEST on. Parenthesis with && and || is
fixed similarly to r1386.
BUG=skia:1493
R=scroggo@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
22732004
git-svn-id: http://skia.googlecode.com/svn/trunk@10704
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 14 Aug 2013 11:36:15 +0000 (11:36 +0000)]
Refactor gmmain to separate out config parsing
R=vandebo@chromium.org, reed@google.com, edisonn@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
21715002
git-svn-id: http://skia.googlecode.com/svn/trunk@10703
2bbb7eff-a529-9590-31e7-
b0007b416f81