platform/upstream/libSkiaSharp.git
8 years agoEnable RAW codec for Windows
yujieqin [Wed, 6 Apr 2016 13:47:15 +0000 (06:47 -0700)]
Enable RAW codec for Windows

BUG=skia:4890 b/26973157
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853093002

Review URL: https://codereview.chromium.org/1853093002

8 years agoAnother NDK release. Still just bug fixes.
mtklein [Wed, 6 Apr 2016 13:12:01 +0000 (06:12 -0700)]
Another NDK release.  Still just bug fixes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864073002

Review URL: https://codereview.chromium.org/1864073002

8 years agoFirst pass at VulkanViewer
jvanverth [Wed, 6 Apr 2016 13:08:59 +0000 (06:08 -0700)]
First pass at VulkanViewer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848833005

Review URL: https://codereview.chromium.org/1848833005

8 years ago"Fix" compiler issue in SkRandomScalerContext
robertphillips [Tue, 5 Apr 2016 23:55:41 +0000 (16:55 -0700)]
"Fix" compiler issue in SkRandomScalerContext

BUG=skia:5164
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862643002

Review URL: https://codereview.chromium.org/1862643002

8 years agoUpdate SkMatrixImageFilter to sk_sp
robertphillips [Tue, 5 Apr 2016 22:09:00 +0000 (15:09 -0700)]
Update SkMatrixImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858353002

Review URL: https://codereview.chromium.org/1858353002

8 years agoGet back on mainline libpng 1.6 now that 3bpp perf patches are merged.
mtklein [Tue, 5 Apr 2016 20:46:00 +0000 (13:46 -0700)]
Get back on mainline libpng 1.6 now that 3bpp perf patches are merged.

Checked manually in Instruments that we're still running our SSE filters for both RGB and RGBA PNGs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865633002

Review URL: https://codereview.chromium.org/1865633002

8 years agoOne signature for creating unit tests that run on premade GrContexts
bsalomon [Tue, 5 Apr 2016 19:59:06 +0000 (12:59 -0700)]
One signature for creating unit tests that run on premade GrContexts
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860593002

Review URL: https://codereview.chromium.org/1860593002

8 years agoDo an in-place replacement of SkRandom with Fuzz for FilterFuzz
kjlubick [Tue, 5 Apr 2016 19:48:47 +0000 (12:48 -0700)]
Do an in-place replacement of SkRandom with Fuzz for FilterFuzz

This feels rather clunky, because we aren't using the full potential of the
fuzzer, but it works, it seems.

BUG=skia:4969
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710183002

Review URL: https://codereview.chromium.org/1710183002

8 years agoUpdate SkXfermodeImageFilter to sk_sp
robertphillips [Tue, 5 Apr 2016 19:48:34 +0000 (12:48 -0700)]
Update SkXfermodeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852123002

Committed: https://skia.googlesource.com/skia/+/3bc969264d4720d67f0b137552b3777a03b431a8

Review URL: https://codereview.chromium.org/1852123002

8 years agoSet 'device_cfg' parameter for iOS bots
borenet [Tue, 5 Apr 2016 19:14:59 +0000 (12:14 -0700)]
Set 'device_cfg' parameter for iOS bots

For https://codereview.chromium.org/1859993003/

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862723002

Review URL: https://codereview.chromium.org/1862723002

8 years agoRevert of Delete SkFlattenable::Type (part 1) (patchset #1 id:1 of https://codereview...
msarett [Tue, 5 Apr 2016 19:00:49 +0000 (12:00 -0700)]
Revert of Delete SkFlattenable::Type (part 1) (patchset #1 id:1 of https://codereview.chromium.org/1861013002/ )

Reason for revert:
See sugoi's comment.

Original issue's description:
> Delete SkFlattenable::Type (part 1)
>
> This should allow me to delete uses of SkFlattenable::Type in Chrome.
> Then I'll follow up with the full delete.
> https://codereview.chromium.org/1834303003/
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002
>
> Committed: https://skia.googlesource.com/skia/+/6b63536e917d86028630199c4eef4aa1597292ce

TBR=reed@google.com,mtklein@google.com,sugoi@chromium.org,senorblanco@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1860693005

8 years agoUpdate SkColorFilterImageFilter to sk_sp
robertphillips [Tue, 5 Apr 2016 18:50:42 +0000 (11:50 -0700)]
Update SkColorFilterImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1858813002

Review URL: https://codereview.chromium.org/1858813002

8 years agoCreate output directory in skdiff
brianosman [Tue, 5 Apr 2016 18:37:49 +0000 (11:37 -0700)]
Create output directory in skdiff

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865563002

Review URL: https://codereview.chromium.org/1865563002

8 years agoRename enums in GrContextFactory to remove "GL"
bsalomon [Tue, 5 Apr 2016 18:06:27 +0000 (11:06 -0700)]
Rename enums in GrContextFactory to remove "GL"

Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004

Committed: https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb

Review URL: https://codereview.chromium.org/1845923004

8 years agoFix vulkan dual source blending
egdaniel [Tue, 5 Apr 2016 18:00:29 +0000 (11:00 -0700)]
Fix vulkan dual source blending

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856283003

Review URL: https://codereview.chromium.org/1856283003

8 years agoRemove 'native' context unit test macro.
bsalomon [Tue, 5 Apr 2016 17:57:13 +0000 (10:57 -0700)]
Remove 'native' context unit test macro.

The only test ran long is GLPrograms. I halved its iteration count to preserve the runtime on devices that support GL and GLES.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855993002

Review URL: https://codereview.chromium.org/1855993002

8 years agoReland of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https...
borenet [Tue, 5 Apr 2016 17:12:56 +0000 (10:12 -0700)]
Reland of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1861713002/ )

Reason for revert:
Retry again

Original issue's description:
> Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1856373003/ )
>
> Reason for revert:
> Try again.
>
> Original issue's description:
> > Whitespace change to test Bugdroid+AutoRoll
> >
> > BUG=598773
> > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003
> >
> > Committed: https://skia.googlesource.com/skia/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf
>
> TBR=borenet@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=598773
>
> Committed: https://skia.googlesource.com/skia/+/cd76ae50e9bba22282a283eb18d092291b1f98ad

TBR=borenet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598773

Review URL: https://codereview.chromium.org/1864573002

8 years agoDelete SkFlattenable::Type (part 1)
msarett [Tue, 5 Apr 2016 16:32:35 +0000 (09:32 -0700)]
Delete SkFlattenable::Type (part 1)

This should allow me to delete uses of SkFlattenable::Type in Chrome.
Then I'll follow up with the full delete.
https://codereview.chromium.org/1834303003/

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1861013002

Review URL: https://codereview.chromium.org/1861013002

8 years agoUpdate SkMorphology ImageFilters to sk_sp
robertphillips [Tue, 5 Apr 2016 16:09:36 +0000 (09:09 -0700)]
Update SkMorphology ImageFilters to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1860573002

Review URL: https://codereview.chromium.org/1860573002

8 years agoAdd predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL...
bsalomon [Tue, 5 Apr 2016 15:49:38 +0000 (08:49 -0700)]
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003

Committed: https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89

Review URL: https://codereview.chromium.org/1853103003

8 years agoAdd valgrind suppression file to infrabots.isolate
rmistry [Tue, 5 Apr 2016 15:31:48 +0000 (08:31 -0700)]
Add valgrind suppression file to infrabots.isolate

BUG=skia:5149
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1859083002

Review URL: https://codereview.chromium.org/1859083002

8 years agoRevert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https...
borenet [Tue, 5 Apr 2016 15:25:38 +0000 (08:25 -0700)]
Revert of Whitespace change to test Bugdroid+AutoRoll (patchset #1 id:1 of https://codereview.chromium.org/1856373003/ )

Reason for revert:
Try again.

Original issue's description:
> Whitespace change to test Bugdroid+AutoRoll
>
> BUG=598773
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003
>
> Committed: https://skia.googlesource.com/skia/+/74f047b58b70935f21cc08d30b7cc789b22bc7cf

TBR=borenet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598773

Review URL: https://codereview.chromium.org/1861713002

8 years agoDo not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind
rmistry [Tue, 5 Apr 2016 15:24:29 +0000 (08:24 -0700)]
Do not set do_perf_steps for Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind

BUG=skia:5149
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856403002

Review URL: https://codereview.chromium.org/1856403002

8 years agogive up if huge paths have unresolvable coincidence
caryclark [Tue, 5 Apr 2016 14:28:48 +0000 (07:28 -0700)]
give up if huge paths have unresolvable coincidence

This fuzzy test has enormous curves with coincidence runs that break numerics.
If the computed intersections identify that the span of coincidence has been deleted,
give up and return that the path op failed.

TBR=reed@google.com
BUG=597926
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854333002

Review URL: https://codereview.chromium.org/1854333002

8 years agoRevert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly...
bsalomon [Tue, 5 Apr 2016 14:26:28 +0000 (07:26 -0700)]
Revert of Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GL… (patchset #3 id:40001 of https://codereview.chromium.org/1853103003/ )

Reason for revert:
causing crashes on win8 bot?

Original issue's description:
> Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003
>
> Committed: https://skia.googlesource.com/skia/+/74cb44dee50b5db94c1374cbcf0b0a1babd09d89

TBR=egdaniel@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1857233002

8 years agoImplement blit image for copySurface in Vulkan
egdaniel [Tue, 5 Apr 2016 14:23:38 +0000 (07:23 -0700)]
Implement blit image for copySurface in Vulkan

Also allows CopyImage to handle GrRenderTargets which are not textures.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852413002

Review URL: https://codereview.chromium.org/1852413002

8 years agoAdd predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL...
bsalomon [Tue, 5 Apr 2016 14:03:42 +0000 (07:03 -0700)]
Add predfined configs for msaa4, nvpr4, nvpr4dit, and srgb that explictly use OpenGL rather than GLES and use them on the X1 bot
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103003

Review URL: https://codereview.chromium.org/1853103003

8 years agoremove avoid and pixelxor xfermodes
reed [Tue, 5 Apr 2016 13:25:14 +0000 (06:25 -0700)]
remove avoid and pixelxor xfermodes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853103005

Review URL: https://codereview.chromium.org/1853103005

8 years agoWhitespace change to test Bugdroid+AutoRoll
borenet [Tue, 5 Apr 2016 12:57:46 +0000 (05:57 -0700)]
Whitespace change to test Bugdroid+AutoRoll

BUG=598773
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856373003

Review URL: https://codereview.chromium.org/1856373003

8 years agoFix failed filter followed by an affects-transparent-black filter.
senorblanco [Tue, 5 Apr 2016 11:43:45 +0000 (04:43 -0700)]
Fix failed filter followed by an affects-transparent-black filter.

When an upstream filter returns null, either through failure or clipping, a downstream affects-transparent-black
filter should still produce non-transparent pixels.

This patch fixes SkColorFilterImageFilter.

Note: this will affect the results of the imagefilterscropexpand GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844593002

Review URL: https://codereview.chromium.org/1844593002

8 years agoRevert of Delete SkFlattenable::Type (patchset #2 id:20001 of https://codereview...
mtklein [Mon, 4 Apr 2016 21:57:19 +0000 (14:57 -0700)]
Revert of Delete SkFlattenable::Type (patchset #2 id:20001 of https://codereview.chromium.org/1834303003/ )

Reason for revert:
Used by Chrome.

c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C2039: 'GetFlattenableType': is not a member of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\third_party\skia\include\core\skshader.h(19): note: see declaration of 'SkColorFilter'
c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C3861: 'GetFlattenableType': identifier not found

Original issue's description:
> Delete SkFlattenable::Type
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003
>
> Committed: https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f

TBR=reed@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1853383002

8 years agoDelete SkFlattenable::Type
msarett [Mon, 4 Apr 2016 20:53:02 +0000 (13:53 -0700)]
Delete SkFlattenable::Type

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003

Review URL: https://codereview.chromium.org/1834303003

8 years agoRoll up to use >=4.
mtklein [Mon, 4 Apr 2016 20:48:41 +0000 (13:48 -0700)]
Roll up to use >=4.

    https://github.com/mtklein/libpng/commit/d0513638e7cc7d22b7dace879afea848b342fe33

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854293002

Review URL: https://codereview.chromium.org/1854293002

8 years agoFixes for iOS Swarming bot
borenet [Mon, 4 Apr 2016 19:39:32 +0000 (12:39 -0700)]
Fixes for iOS Swarming bot

BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855223002

Review URL: https://codereview.chromium.org/1855223002

8 years agoFix ParseConfigs_OutParam tests
halcanary [Mon, 4 Apr 2016 19:14:46 +0000 (12:14 -0700)]
Fix ParseConfigs_OutParam tests

Review URL: https://codereview.chromium.org/1857923002

8 years agoPoint libpng at upstream libpng 1.6 + my new perf patch.
mtklein [Mon, 4 Apr 2016 19:08:46 +0000 (12:08 -0700)]
Point libpng at upstream libpng 1.6 + my new perf patch.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852363002

Review URL: https://codereview.chromium.org/1852363002

8 years agoSwitch internal testing ImageFilters over to new onFilterImage interface
robertphillips [Mon, 4 Apr 2016 19:07:47 +0000 (12:07 -0700)]
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854133002

Review URL: https://codereview.chromium.org/1854133002

8 years agoRevert of added GrMSAAPathRenderer (patchset #9 id:160001 of https://codereview.chrom...
ethannicholas [Mon, 4 Apr 2016 18:41:30 +0000 (11:41 -0700)]
Revert of added GrMSAAPathRenderer (patchset #9 id:160001 of https://codereview.chromium.org/1834133003/ )

Reason for revert:
driver crash on Windows

Original issue's description:
> added GrMSAAPathRenderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834133003
>
> Committed: https://skia.googlesource.com/skia/+/47a2dc8e229e93e1bcf7405747320920da1ab742
>
> Committed: https://skia.googlesource.com/skia/+/b0fabd4ed55abcb6f5ed2f331c96c783f42bd37c

TBR=bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1853223003

8 years agoadded GrMSAAPathRenderer
ethannicholas [Mon, 4 Apr 2016 18:00:00 +0000 (11:00 -0700)]
added GrMSAAPathRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834133003

Committed: https://skia.googlesource.com/skia/+/47a2dc8e229e93e1bcf7405747320920da1ab742

Review URL: https://codereview.chromium.org/1834133003

8 years agoAdd SK_API to SkROBuffer::Iter
scroggo [Mon, 4 Apr 2016 17:05:23 +0000 (10:05 -0700)]
Add SK_API to SkROBuffer::Iter

Necessary for crrev.com/1812273003 in Chromium.

Also remove trailing whitespace.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856033002

Review URL: https://codereview.chromium.org/1856033002

8 years agoswitch maskfilters to sk_sp
reed [Mon, 4 Apr 2016 17:02:58 +0000 (10:02 -0700)]
switch maskfilters to sk_sp

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852113003

Review URL: https://codereview.chromium.org/1852113003

8 years agoSwitch SkDownSampleImageFilter over to new onFilterImage interface
robertphillips [Mon, 4 Apr 2016 16:18:52 +0000 (09:18 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface

This will slightly change the testimagefilters GM images

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002

Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5

Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44

Review URL: https://codereview.chromium.org/1851583002

8 years agoRevert of added GrMSAAPathRenderer (patchset #8 id:140001 of https://codereview.chrom...
ethannicholas [Mon, 4 Apr 2016 15:27:03 +0000 (08:27 -0700)]
Revert of added GrMSAAPathRenderer (patchset #8 id:140001 of https://codereview.chromium.org/1834133003/ )

Reason for revert:
nanobench failure

Original issue's description:
> added GrMSAAPathRenderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834133003
>
> Committed: https://skia.googlesource.com/skia/+/47a2dc8e229e93e1bcf7405747320920da1ab742

TBR=bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1860563002

8 years agoRevert of Update SkXfermodeImageFilter to sk_sp (patchset #4 id:60001 of https:/...
robertphillips [Mon, 4 Apr 2016 15:06:17 +0000 (08:06 -0700)]
Revert of Update SkXfermodeImageFilter to sk_sp (patchset #4 id:60001 of https://codereview.chromium.org/1852123002/ )

Reason for revert:
Chrome-land compilation failure.

Original issue's description:
> Update SkXfermodeImageFilter to sk_sp
>
> TBR=reed@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852123002
>
> Committed: https://skia.googlesource.com/skia/+/3bc969264d4720d67f0b137552b3777a03b431a8

TBR=fmalita@chromium.org,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1852273002

8 years agoadded GrMSAAPathRenderer
ethannicholas [Mon, 4 Apr 2016 14:57:39 +0000 (07:57 -0700)]
added GrMSAAPathRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834133003

Review URL: https://codereview.chromium.org/1834133003

8 years agoUpdate SkXfermodeImageFilter to sk_sp
robertphillips [Mon, 4 Apr 2016 14:13:49 +0000 (07:13 -0700)]
Update SkXfermodeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852123002

Review URL: https://codereview.chromium.org/1852123002

8 years agoDM/PDF: stop adding unused rasterizer keywords
halcanary [Mon, 4 Apr 2016 13:12:15 +0000 (06:12 -0700)]
DM/PDF: stop adding unused rasterizer keywords

We can always add it back if we need it in the future.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852713002

Review URL: https://codereview.chromium.org/1852713002

8 years agoRevert of Rename enums in GrContextFactory to remove "GL" (patchset #4 id:60001 of...
bsalomon [Mon, 4 Apr 2016 12:56:59 +0000 (05:56 -0700)]
Revert of Rename enums in GrContextFactory to remove "GL" (patchset #4 id:60001 of https://codereview.chromium.org/1845923004/ )

Reason for revert:
Many GM images unexpectedly changed with this CL.

Original issue's description:
> Rename enums in GrContextFactory to remove "GL"
>
> Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004
>
> Committed: https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb

TBR=egdaniel@google.com,jvanverth@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review URL: https://codereview.chromium.org/1856703002

8 years agoRevert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchse...
robertphillips [Mon, 4 Apr 2016 12:28:03 +0000 (05:28 -0700)]
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #6 id:100001 of https://codereview.chromium.org/1851583002/ )

Reason for revert:
changing images on bots

Original issue's description:
> Switch SkDownSampleImageFilter over to new onFilterImage interface
>
> This will slightly change the testimagefilters GM images
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002
>
> Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5
>
> Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44

TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1859533002

8 years agoUpdate internal testing ImageFilters to sk_sp
robertphillips [Mon, 4 Apr 2016 12:05:11 +0000 (05:05 -0700)]
Update internal testing ImageFilters to sk_sp

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854023003

Review URL: https://codereview.chromium.org/1854023003

8 years agoSwitch SkDownSampleImageFilter over to new onFilterImage interface
robertphillips [Mon, 4 Apr 2016 12:04:45 +0000 (05:04 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface

This will slightly change the testimagefilters GM images

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002

Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5

Review URL: https://codereview.chromium.org/1851583002

8 years agoUpdate SkBlurImageFilter to sk_sp
robertphillips [Mon, 4 Apr 2016 11:31:25 +0000 (04:31 -0700)]
Update SkBlurImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852743002

Review URL: https://codereview.chromium.org/1852743002

8 years agochange flattenable factory to return sk_sp
reed [Sun, 3 Apr 2016 16:11:13 +0000 (09:11 -0700)]
change flattenable factory to return sk_sp

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855733002

Review URL: https://codereview.chromium.org/1855733002

8 years agoUpdate SKP version
update-skps [Sun, 3 Apr 2016 07:59:16 +0000 (00:59 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851323002

Review URL: https://codereview.chromium.org/1851323002

8 years agocheck for bad params sent to discrete patheffect
reed [Sun, 3 Apr 2016 01:40:40 +0000 (18:40 -0700)]
check for bad params sent to discrete patheffect

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853953002

TBR=

Review URL: https://codereview.chromium.org/1853953002

8 years agoImage filters: optimize crop rect application.
senorblanco [Fri, 1 Apr 2016 23:41:10 +0000 (16:41 -0700)]
Image filters: optimize crop rect application.

If a filter does not affect transparent black, there's no
reason to allow the crop rect to expand beyond the optimal
size determined by onFilterNodeBounds(). So don't enlarge
the bounds unless the filter affects transparent black.

In order to determine which filters affect transparent
black, I've pulled the inverse of the canComputeFastBounds()
logic into a non-recursive, affectsTransparentBlack()
virtual, and left canComputeFastBounds() as a non-virtual,
recursive function that calls it.

BUG=599933
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848953002
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1848953002

8 years agoRename enums in GrContextFactory to remove "GL"
bsalomon [Fri, 1 Apr 2016 20:38:04 +0000 (13:38 -0700)]
Rename enums in GrContextFactory to remove "GL"

Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004

Review URL: https://codereview.chromium.org/1845923004

8 years agoAdd GrContext::releaseAndAbandonContext()
bsalomon [Fri, 1 Apr 2016 18:54:31 +0000 (11:54 -0700)]
Add GrContext::releaseAndAbandonContext()

Like abandonContext() this disconnects the GrContext from the underlying 3D API. However, unlike abandonContext it first frees all allocated GPU resources.

BUG=skia:5142
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852733002

Review URL: https://codereview.chromium.org/1852733002

8 years agoSkPDF: properly dedup bitmaps in shaders
halcanary [Fri, 1 Apr 2016 18:51:00 +0000 (11:51 -0700)]
SkPDF: properly dedup bitmaps in shaders

BUG=skia:5161
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848383002

Review URL: https://codereview.chromium.org/1848383002

8 years agoSkPDF: PDFShader does not hold images/bitmaps
halcanary [Fri, 1 Apr 2016 18:43:39 +0000 (11:43 -0700)]
SkPDF: PDFShader does not hold images/bitmaps

motivation: measurable memory savings.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851123002

Review URL: https://codereview.chromium.org/1851123002

8 years agoUpdate SkAlphaThresholdFilter to sk_sp
robertphillips [Fri, 1 Apr 2016 17:34:43 +0000 (10:34 -0700)]
Update SkAlphaThresholdFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847053004

Review URL: https://codereview.chromium.org/1847053004

8 years agoUpdate vulkan format features in caps.
egdaniel [Fri, 1 Apr 2016 17:10:45 +0000 (10:10 -0700)]
Update vulkan format features in caps.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847963003

Review URL: https://codereview.chromium.org/1847963003

8 years agoUpdate SkImageSource to sk_sp
robertphillips [Fri, 1 Apr 2016 16:28:51 +0000 (09:28 -0700)]
Update SkImageSource to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842243002

Review URL: https://codereview.chromium.org/1842243002

8 years agoFix padding bug in SkTileImageFilter.
senorblanco [Fri, 1 Apr 2016 16:24:48 +0000 (09:24 -0700)]
Fix padding bug in SkTileImageFilter.

When padding an image out to tile size, use the filter input, not the
source primitive.

NOTE: this will affect the tileimagefilter GM (new test case & size).

R=robertphillips@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853803003

Review URL: https://codereview.chromium.org/1853803003

8 years agoDelete duplicate null GL interface implementation
bsalomon [Fri, 1 Apr 2016 16:04:35 +0000 (09:04 -0700)]
Delete duplicate null GL interface implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1846253002

Review URL: https://codereview.chromium.org/1846253002

8 years agoInitialize variable to appease compiler warning
egdaniel [Fri, 1 Apr 2016 15:47:35 +0000 (08:47 -0700)]
Initialize variable to appease compiler warning

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854773002

Review URL: https://codereview.chromium.org/1854773002

8 years agoRespect build type arg in build_shaderc.py
bsalomon [Fri, 1 Apr 2016 15:40:55 +0000 (08:40 -0700)]
Respect build type arg in build_shaderc.py
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854733004

Review URL: https://codereview.chromium.org/1854733004

8 years agoRevert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchse...
robertphillips [Fri, 1 Apr 2016 15:09:44 +0000 (08:09 -0700)]
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #2 id:20001 of https://codereview.chromium.org/1851583002/ )

Reason for revert:
Some images are incorrect

Original issue's description:
> Switch SkDownSampleImageFilter over to new onFilterImage interface
>
> This will slightly change the testimagefilters GM images
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002
>
> Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5

TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1853823002

8 years agoRestore Vulkan setup code accidentally reverted in GrContextFactory.cpp
bsalomon [Fri, 1 Apr 2016 14:42:05 +0000 (07:42 -0700)]
Restore Vulkan setup code accidentally reverted in GrContextFactory.cpp

TBR=egdaniel@google.com,jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852553004

Review URL: https://codereview.chromium.org/1852553004

8 years agoSupport for Android Swarming bots
borenet [Fri, 1 Apr 2016 14:18:27 +0000 (07:18 -0700)]
Support for Android Swarming bots

BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819033002

Review URL: https://codereview.chromium.org/1819033002

8 years agoSwitch SkMatrixImageFilter over to new onFilterImage interface
robertphillips [Fri, 1 Apr 2016 14:13:42 +0000 (07:13 -0700)]
Switch SkMatrixImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847953003

Review URL: https://codereview.chromium.org/1847953003

8 years agoSwitch SkDownSampleImageFilter over to new onFilterImage interface
robertphillips [Fri, 1 Apr 2016 14:13:23 +0000 (07:13 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface

This will slightly change the testimagefilters GM images

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002

Review URL: https://codereview.chromium.org/1851583002

8 years agoAdd SK_SUPPORT_LEGACY_IMAGEFILTER_PTR to public.bzl DEFINES to fix build.
benjaminwagner [Fri, 1 Apr 2016 13:54:34 +0000 (06:54 -0700)]
Add SK_SUPPORT_LEGACY_IMAGEFILTER_PTR to public.bzl DEFINES to fix build.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1853773002

Review URL: https://codereview.chromium.org/1853773002

8 years agoSimplify GrDrawBatch uploads and token uage.
bsalomon [Fri, 1 Apr 2016 13:06:20 +0000 (06:06 -0700)]
Simplify GrDrawBatch uploads and token uage.

GrVertexBatch subclasses no longer need "initDraw".

Simplifies GrTestBatch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835283002

Review URL: https://codereview.chromium.org/1835283002

8 years agoIn public.bzl, change file locations after https://codereview.chromium.org/1815823002
benjaminwagner [Fri, 1 Apr 2016 12:00:51 +0000 (05:00 -0700)]
In public.bzl, change file locations after https://codereview.chromium.org/1815823002

Depends on https://codereview.chromium.org/1847923002

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842363002

Review URL: https://codereview.chromium.org/1842363002

8 years agosk_sp for SkCanvas::drawAnnotation()
mtklein [Fri, 1 Apr 2016 11:55:51 +0000 (04:55 -0700)]
sk_sp for SkCanvas::drawAnnotation()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849703003

Review URL: https://codereview.chromium.org/1849703003

8 years agofix typo: add missing const
mtklein [Fri, 1 Apr 2016 11:55:47 +0000 (04:55 -0700)]
fix typo: add missing const

TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1848533004

Review URL: https://codereview.chromium.org/1848533004

8 years agoAdd CreatePlatformGLTestContext_none.cpp for Google3 build
bsalomon [Fri, 1 Apr 2016 11:50:45 +0000 (04:50 -0700)]
Add CreatePlatformGLTestContext_none.cpp for Google3 build

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847923002

Review URL: https://codereview.chromium.org/1847923002

8 years agoRemove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget
kkinnunen [Fri, 1 Apr 2016 11:50:37 +0000 (04:50 -0700)]
Remove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget

Remove ownership parameter from
GrResourceProvider::wrapBackendTextureAsRenderTarget.
The function leaks the texture id if kAdopt_LifeCycle is passed.

There is no public API to access the parameter.

BUG=594928
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842313003

Review URL: https://codereview.chromium.org/1842313003

8 years agoFix compilation of GLTestContext_angle.cpp"
Brian Salomon [Thu, 31 Mar 2016 18:30:08 +0000 (14:30 -0400)]
Fix compilation of GLTestContext_angle.cpp"

TBR=robertphillips@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1850783003
BUG=skia:

Review URL: https://codereview.chromium.org/1850783003 .

8 years agorename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
bsalomon [Thu, 31 Mar 2016 17:59:06 +0000 (10:59 -0700)]
rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext

rename subclasses

Fix up the EGL native GLTestContext
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849463002

TBR=jvanverth@google.com

Committed: https://skia.googlesource.com/skia/+/4c7f0a16312c374eba4e8d5d46435ce9eb0b9971

Review URL: https://codereview.chromium.org/1849463002

8 years agoFiddle: update to new GrGLAssembleInterface API
halcanary [Thu, 31 Mar 2016 17:35:13 +0000 (10:35 -0700)]
Fiddle: update to new GrGLAssembleInterface API

NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1849753003

8 years agoRevert of Add unit repeat tiler (patchset #4 id:60001 of https://codereview.chromium...
robertphillips [Thu, 31 Mar 2016 17:27:26 +0000 (10:27 -0700)]
Revert of Add unit repeat tiler (patchset #4 id:60001 of https://codereview.chromium.org/1837893004/ )

Reason for revert:
ASAN bot failures

Original issue's description:
> Add unit repeat tiler.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1837893004
>
> Committed: https://skia.googlesource.com/skia/+/865a289bfec169cb19970c734e9aa855c267f060

TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1844713005

8 years agoRevert of rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext (patchset ...
bsalomon [Thu, 31 Mar 2016 17:22:40 +0000 (10:22 -0700)]
Revert of rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext (patchset #5 id:80001 of https://codereview.chromium.org/1849463002/ )

Reason for revert:
breaking bots

Original issue's description:
> rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
>
> rename subclasses
>
> Fix up the EGL native GLTestContext
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849463002
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/4c7f0a16312c374eba4e8d5d46435ce9eb0b9971

TBR=jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1850543003

8 years agoExpose GrGLAssembleInterface
bsalomon [Thu, 31 Mar 2016 17:22:20 +0000 (10:22 -0700)]
Expose GrGLAssembleInterface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842363003

Review URL: https://codereview.chromium.org/1842363003

8 years agorename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
bsalomon [Thu, 31 Mar 2016 17:07:23 +0000 (10:07 -0700)]
rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext

rename subclasses

Fix up the EGL native GLTestContext
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849463002

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1849463002

8 years agoUpdate SkOffsetImageFilter to sk_sp
robertphillips [Thu, 31 Mar 2016 16:05:49 +0000 (09:05 -0700)]
Update SkOffsetImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842193002

Review URL: https://codereview.chromium.org/1842193002

8 years agoAdd unit repeat tiler.
herb [Thu, 31 Mar 2016 15:48:21 +0000 (08:48 -0700)]
Add unit repeat tiler.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1837893004

Review URL: https://codereview.chromium.org/1837893004

8 years agoAdd 'P' to SampleApp to cycle through pixel geometries.
bungeman [Thu, 31 Mar 2016 15:30:38 +0000 (08:30 -0700)]
Add 'P' to SampleApp to cycle through pixel geometries.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834243002

Review URL: https://codereview.chromium.org/1834243002

8 years agoRemode dead code from SkReadBuffer
msarett [Thu, 31 Mar 2016 15:25:19 +0000 (08:25 -0700)]
Remode dead code from SkReadBuffer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845283002

Review URL: https://codereview.chromium.org/1845283002

8 years agoImage filters: fix crop rect application in SkXfermodeImageFilter.
senorblanco [Thu, 31 Mar 2016 15:24:29 +0000 (08:24 -0700)]
Image filters: fix crop rect application in SkXfermodeImageFilter.

The crop rect was being incorrectly applied in SkXfermodeImageFilter:
the background and foreground bounds were having the crop rect applied
individually to them, and then unioned. The correct approach is to take
the union of their bounds, and apply the crop rect to that. (A similar
bug in SkMergeImageFilter was fixed a while back.)

This is important when applying a compositing mode
which affects pixels outside the foreground bounds
(e.g., SrcIn, SrcOut).

NOTE: this will change the results of the xfermodeimagefilter GM (new
test case).
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842033005

Review URL: https://codereview.chromium.org/1842033005

8 years agoFix Vulkan tests after GrContextFactory move to sk_gpu_test
kkinnunen [Thu, 31 Mar 2016 15:08:20 +0000 (08:08 -0700)]
Fix Vulkan tests after GrContextFactory move to sk_gpu_test

Fix Vulkan tests after GrContextFactory move to sk_gpu_test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844983003

Review URL: https://codereview.chromium.org/1844983003

8 years agoSkPDF: Use Pathops clipping
halcanary [Thu, 31 Mar 2016 14:33:57 +0000 (07:33 -0700)]
SkPDF: Use Pathops clipping

Turn this on all the time.  Remove the SK_PDF_USE_PATHOPS_CLIPPING
define that used to hide this functionality.

All rendering tests are the same or improved by this.

Also, remove non-functional SK_ALLOW_LARGE_PDF_SCALARS.

TBR=reed@google.com
    removing dead #defines from SkUserConfig.h

BUG=591805
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845623002

Review URL: https://codereview.chromium.org/1845623002

8 years agoSkPDF: Make magic make sense
halcanary [Thu, 31 Mar 2016 13:59:00 +0000 (06:59 -0700)]
SkPDF: Make magic make sense

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1849453004

Review URL: https://codereview.chromium.org/1849453004

8 years agoUpdate shaderc to ToT.
egdaniel [Thu, 31 Mar 2016 13:16:31 +0000 (06:16 -0700)]
Update shaderc to ToT.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847643002

Review URL: https://codereview.chromium.org/1847643002

8 years agoMake SkRandom::next[US]Fixed1 private; update documentation for SkRandom::nextSScalar1.
benjaminwagner [Thu, 31 Mar 2016 13:13:22 +0000 (06:13 -0700)]
Make SkRandom::next[US]Fixed1 private; update documentation for SkRandom::nextSScalar1.

SkRandom is unused in Chromium, Android, Mozilla, and Google3.

SkRandom::nextSScalar1 and LCGRandom::nextSScalar1 appear to me by inspection to potentially return -1, so I updated the documentation to match.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1846773002

Review URL: https://codereview.chromium.org/1846773002

8 years agoFix C4334 warning about 32-bit shift assigned to 64-bits
brucedawson [Thu, 31 Mar 2016 12:53:44 +0000 (05:53 -0700)]
Fix C4334 warning about 32-bit shift assigned to 64-bits

VS 2015 has a new or louder warning about 32-bit shifts that are then
assigned to a 64-bit target. This type of code triggers it:

int64_t size = 1 << shift_amount;

Because the '1' being shifted is a 32-bit int the result of the shift
will be a 32-bit result, so assigning it to a 64-bit variable is just
misleading.

In this case the code that triggers it is this:

  size_t alloc = 1<<fLgSize++;

The destination is a size_t so the warning only shows up on 64-bit
builds and doesn't indicate a real bug. But, casting the '1' constant
to size_t makes the behavior/intent more obvious and consistent and
allows enabling C4334 in Chromium.

BUG=593448
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845123002

Review URL: https://codereview.chromium.org/1845123002

8 years agoMake skgputest target depend on gl/glx/glu or egl/gles2 libs on linux
Brian Salomon [Thu, 31 Mar 2016 03:20:09 +0000 (23:20 -0400)]
Make skgputest target depend on gl/glx/glu or egl/gles2 libs on linux
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1846623003

Review URL: https://codereview.chromium.org/1846623003 .

8 years agoMove SkGLContext and some GrGLInterface implementations to skgputest module
bsalomon [Thu, 31 Mar 2016 01:56:19 +0000 (18:56 -0700)]
Move SkGLContext and some GrGLInterface implementations to skgputest module

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1815823002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/fe3456cb006110d045b26ff3f8681b893a757b58

Review URL: https://codereview.chromium.org/1815823002

8 years agoUpdate SkMergeImageFilter to sk_sp
robertphillips [Wed, 30 Mar 2016 20:34:16 +0000 (13:34 -0700)]
Update SkMergeImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847583002

Review URL: https://codereview.chromium.org/1847583002