platform/upstream/mesa.git
14 months agonvk: Fully populate QMDs before uploading
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Fully populate QMDs before uploading

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: memcpy root descriptors for compute instead of doing a DMA
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: memcpy root descriptors for compute instead of doing a DMA

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Return VkResult from nvk_cmd_buffer_upload_alloc
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Return VkResult from nvk_cmd_buffer_upload_alloc

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Add BO recycling to the command pool
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Add BO recycling to the command pool

Command BOs (nvk_cmd_bo) are automatically mapped recyclable BOs to use
for upload and push buffers.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use cmd instead of cmd_buffer
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use cmd instead of cmd_buffer

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Break nvk_cmd_pool into its own file
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Break nvk_cmd_pool into its own file

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use queue_submit_simple for zero_vram
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use queue_submit_simple for zero_vram

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use submit_simple for draw state init
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use submit_simple for draw state init

We also move it to being a queue function.  This architecturally makes
more sense even if it seems a bit redundant at first. Worst case, we
initialize multiple times but this guarantees that we're initialized by
the time we try to submit something.  It also doesn't matter now because
we only have the one queue.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Initialize the queue later in device setup
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Initialize the queue later in device setup

We basically want it at the end but before we set up meta.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Add an nvk_queue_submit_simple helper
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Add an nvk_queue_submit_simple helper

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use a regular BO for the queue state push
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use a regular BO for the queue state push

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use a regular BO for the empty push
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use a regular BO for the empty push

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Submit pushbufs directly
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Submit pushbufs directly

By getting rid of the winsys stuff we can batch everything into a single
ioctl which should be a bit more efficient.  It also simplifies BO
reference handling because we no longer need any of the save/restore
nonsense because we're the ones building the BO list, not the pushbuf
code.  This should be a lot more robust.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Move queue_sumbit to nvk_queue_drm_nouveau.c
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Move queue_sumbit to nvk_queue_drm_nouveau.c

We're about to start doing nouveau DRM specific stuff in here so let's
move it to a nouveau DRM specific file.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Always allocate empty_push
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Always allocate empty_push

We always allocate it on queue_submit anyway so we may as well allocate
it up-front.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use bo_new_mapped for the zero page
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use bo_new_mapped for the zero page

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau: Add a nouveau_ws_bo_new_mapped helper
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau: Add a nouveau_ws_bo_new_mapped helper

Error handling for allocating a bo and immediately mapping it is a pain.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use nv_push directly for graphics pipelines
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use nv_push directly for graphics pipelines

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau: Move push dumping to nv_push.c
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau: Move push dumping to nv_push.c

Because we need access to classes, we also add a basic device info
struct.  We'll expand on this a bit later.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau: Move push validate to nv_push.c
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau: Move push validate to nv_push.c

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/parser: Take a FILE* in DUMP_*_MTHD_DATA
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau/parser: Take a FILE* in DUMP_*_MTHD_DATA

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau: Move nv_push and helpers to their own header
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau: Move nv_push and helpers to their own header

We put this in nvidia-headers to separate it from the pushbuf stuff.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau: Rename the fields of vk_push
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau: Rename the fields of vk_push

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau: Add an nv_push struct
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nouveau: Add an nv_push struct

This encapsulates the minimum we need for the push macros/functions.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use p for the nouveau_ws_push_buffer in zero_vram
Faith Ekstrand [Tue, 31 Jan 2023 02:11:58 +0000 (20:11 -0600)]
nvk: Use p for the nouveau_ws_push_buffer in zero_vram

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Implement vkCmdDraw[Indexed]Indirect()
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Implement vkCmdDraw[Indexed]Indirect()

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use MME for vkCmdDraw[Indexed]()
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Use MME for vkCmdDraw[Indexed]()

This lets us move the instance loop to the MME and stop emitting state
per-instance.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add helper macros for setting fields
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add helper macros for setting fields

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use MME for clears
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Use MME for clears

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Add MME infrastructure
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Add MME infrastructure

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add unit tests for the Turing+ MME simulator
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add unit tests for the Turing+ MME simulator

These verify that its behavior is the same as the hardware.  Very useful
for reverse engineering.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Make the winsys headers C++ safe
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Make the winsys headers C++ safe

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add an isaspec-based dumper
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add an isaspec-based dumper

This actually dumps everything, unlike the pretty printer which tries to
dump something readable and may ignore bits of instructions if it thinks
they're no-ops.  Useful for debugging the pretty printer.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add a tiny simulator for the Turing+ MME
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add a tiny simulator for the Turing+ MME

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add a builder for the Turing+ MME
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add a builder for the Turing+ MME

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add an assembler and disassembler for the Turring+ MME
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add an assembler and disassembler for the Turring+ MME

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add isaspec XML for the Turing+ MME
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add isaspec XML for the Turing+ MME

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/mme: Add basic structures for the Turing+ MME
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/mme: Add basic structures for the Turing+ MME

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/parser: Add more arrays
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/parser: Add more arrays

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/push: Fix a void pointer arithmetic bug
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/push: Fix a void pointer arithmetic bug

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonil: Don't claim texture support for 2-bit SNORM
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nil: Don't claim texture support for 2-bit SNORM

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Increase the graphics pipeline push space
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Increase the graphics pipeline push space

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use VK_IMAGE_USAGE_*_ATTACHMENT_BIT for image clears
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Use VK_IMAGE_USAGE_*_ATTACHMENT_BIT for image clears

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Drop a TODO
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Drop a TODO

Dynamic buffer bindings work fine

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use f for extension features
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Use f for extension features

It's shorter and more ergonamic and the driver is still small so we can
pick a reasonable convention before things get out-of-hand.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Fix unused result warnings in pushbuf resets.
Emma Anholt [Sun, 11 Sep 2022 05:24:18 +0000 (22:24 -0700)]
nvk: Fix unused result warnings in pushbuf resets.

We know we aren't hitting the resize paths here, so errors can't be
thrown.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Fix uninitialized result usage in NVK_DEBUG_ZERO_MEMORY.
Emma Anholt [Sun, 11 Sep 2022 05:22:12 +0000 (22:22 -0700)]
nvk: Fix uninitialized result usage in NVK_DEBUG_ZERO_MEMORY.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Avoid strict aliasing warning in the pushbuffer encoding.
Emma Anholt [Sun, 11 Sep 2022 05:19:57 +0000 (22:19 -0700)]
nvk: Avoid strict aliasing warning in the pushbuffer encoding.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: fix zero page refing
Karol Herbst [Sat, 10 Sep 2022 20:44:03 +0000 (22:44 +0200)]
nvk: fix zero page refing

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/parser: Put the dump helpers in C files
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/parser: Put the dump helpers in C files

This should make the build faster since we don't have to compile those
giant functions with giant switch statements constantly.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/parser: Use more idiomatic python
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/parser: Use more idiomatic python

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/parser: Convert to mako
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nouveau/parser: Convert to mako

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: alloc a zero page and use it for vertex runouts
Karol Herbst [Thu, 8 Sep 2022 23:31:42 +0000 (01:31 +0200)]
nvk: alloc a zero page and use it for vertex runouts

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Initialize fixed draw/default state once
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Initialize fixed draw/default state once

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Start every command buffer with a nop
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Start every command buffer with a nop

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Split nvk_queue into its own file
Faith Ekstrand [Tue, 31 Jan 2023 02:11:57 +0000 (20:11 -0600)]
nvk: Split nvk_queue into its own file

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: fix mem leaks
Thomas H.P. Andersen [Wed, 7 Sep 2022 21:05:13 +0000 (23:05 +0200)]
nvk: fix mem leaks

device would leak in various situations.
Separate out lables were needed in the earlier
versions of this function but now we can just
use a single label

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: delete commented code
Thomas H.P. Andersen [Wed, 7 Sep 2022 21:01:40 +0000 (23:01 +0200)]
nvk: delete commented code

nvk_CmdClearColorImage first lived in nvk_cmd_copy,
then moved to nvk_cmd_meta, and finally in nvk_cmd_clear

I seems that this was left behind in one of the moves

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: fix implicit-fallthrough warnings with clang
Thomas H.P. Andersen [Wed, 7 Sep 2022 20:58:51 +0000 (22:58 +0200)]
nvk: fix implicit-fallthrough warnings with clang

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: use common physical device enumeration
Thomas H.P. Andersen [Sun, 4 Sep 2022 22:11:20 +0000 (00:11 +0200)]
nvk: use common physical device enumeration

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: fix OOB read inside nvk_get_va_format
Karol Herbst [Sun, 4 Sep 2022 18:31:57 +0000 (20:31 +0200)]
nvk: fix OOB read inside nvk_get_va_format

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Update to the new command buffer infrastructure
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Update to the new command buffer infrastructure

We leave nvk_command_pool because we'll want to use it for recycling
individual pushbufs.  Drop reset_on_submit becuse there was never really
that much point in that micro-optimization and it isn't thread-safe
anyway if we recycle things in the pool.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/ws: push chaining
Karol Herbst [Sat, 20 Aug 2022 18:28:40 +0000 (20:28 +0200)]
nouveau/ws: push chaining

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/ws: rework refing push buffer bos
Karol Herbst [Sat, 20 Aug 2022 17:49:12 +0000 (19:49 +0200)]
nouveau/ws: rework refing push buffer bos

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/ws: bound check nouveau_ws_push_append
Karol Herbst [Sat, 20 Aug 2022 16:54:32 +0000 (18:54 +0200)]
nouveau/ws: bound check nouveau_ws_push_append

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Add some asserts for nv50 compiler image restrictions
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Add some asserts for nv50 compiler image restrictions

These just ensure that we assert instead of doing something that the
nv50 compiler is likely to screw up.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Zero unused descriptors
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Zero unused descriptors

When a descriptor gets freed because a buffer/image veiw or sampler is
deleted, zero out the descriptor memory.  This prevents the descriptor
from being used later and faulting on possibly non-existant memory.

While we're here, clean up the function a bit.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Implement descriptor table growing
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Implement descriptor table growing

Now that command buffers are no longer referencing descriptor table BOs
directly and we're not handing out maps, we can support growing.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Rework nvk_descriptor_table_add/remove
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Rework nvk_descriptor_table_add/remove

The new api returns a VkResult for more accurate error checking.  More
importantly, it also does copies the descriptor data into the table
instead of returning a map.  This means the users of the descriptor
table will never see a map and we can make sure that the copy happens
under the lock in case we have to grow.  Since each descriptor is only
32 bytes, this isn't going to be a perf problem.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk/sampler: Free descriptor table entries
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk/sampler: Free descriptor table entries

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Invalidate texture header and sampler caches each submit
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Invalidate texture header and sampler caches each submit

It's possible descriptors have been added or removed.  We could track
it, but there's really no point.  Per-submit shouldn't be terrible.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Rework TLS/SLM and image/sampler table handling
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Rework TLS/SLM and image/sampler table handling

When Dave originally added SLM, he did so with a preamble pushbuf which
sets up the SLM area prior to executing any actual command buffers.
This has the advantage that the SLM BO is never directly referenced in
any command buffer and we can swap it out even after command buffers
have been built.  When I added image/sampler tables, I sort-of went
along with it but then did something different for 3D.

Thanks to buffer reference counting, we can employ a fairly simple
locking scheme.  Each of the globals: images, samplers, and TSL has a
lock which gets taken whenever the table is modified.  When we go to do
a submit, we take each lock and take a queue-local reference to the BO
and grab a copy of its size parameter under the lock.  If anything has
changed, we update the queue-local preamble pushbuf.  Because the queue
also holds a reference, we can safely proceed to submit command buffers
which reference those global BOs without the individual global locks
taken.  If SLM or one of the descriptor tables resizes while we're
mid-submit, our reference to the BO will remain valid until either the
destruction of the queue or the next submit.

The one small bit of threaded cleverness (one always has to be careful
with that) is that the SLM size can be checked without taking the lock
because the SLM size only ever increases.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Drop most buffer tracking
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Drop most buffer tracking

If it's backed by an nvk_device_memory, we don't need to track it since
we always add all of those to every submit so that bindless works.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk/dispatch: Rename push to p
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk/dispatch: Rename push to p

I took to using this convention in nvk_cmd_draw.c because it's shorter.
Let's use it other places too.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk/blit: Rename push to p
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk/blit: Rename push to p

I took to using this convention in nvk_cmd_draw.c because it's shorter.
Let's use it other places too.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk/copy: Rename push to p
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk/copy: Rename push to p

I took to using this convention in nvk_cmd_draw.c because it's shorter.
Let's use it other places too.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Inline nouveau_copy_linear
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Inline nouveau_copy_linear

It has exactly one caller so the helper's not really doing us much.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: clean up bo mappings
Karol Herbst [Mon, 29 Aug 2022 13:59:44 +0000 (15:59 +0200)]
nvk: clean up bo mappings

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/ws: add a bo unmap helper function
Karol Herbst [Mon, 29 Aug 2022 13:48:44 +0000 (15:48 +0200)]
nouveau/ws: add a bo unmap helper function

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/ws: add API to query if the context was killed
Karol Herbst [Wed, 24 Aug 2022 11:38:18 +0000 (13:38 +0200)]
nouveau/ws: add API to query if the context was killed

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Fix dynamic buffer descriptor copies
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Fix dynamic buffer descriptor copies

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Set up clip and cull distances
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Set up clip and cull distances

Closes: https://gitlab.freedesktop.org/nouveau/mesa/-/issues/12
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonil: Fix nonnormalized coordinates
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nil: Fix nonnormalized coordinates

Also, replace our TODO with a real comment explaining how nonnormalized
coordinate select works between image and texture header.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonil: Fix max mip level
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nil: Fix max mip level

The MAX_MIP_LEVEL field needs the actual number from the image because
it's used to compute the stride between layers.  The restrictions on mip
level come entirely from the RES_VIEW fields.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonil/format: Depth/stencil formats appear as red
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nil/format: Depth/stencil formats appear as red

Previously, it was treated as luminance and the depth or stencil
component was broadcast to all channels except alpha.  In Vulkan, depth
and stencil textures are treated as red.  If we want it treated
differntly by some other API, that driver can do that with a swizzle.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Fix border color alpha
Faith Ekstrand [Tue, 31 Jan 2023 02:11:56 +0000 (20:11 -0600)]
nvk: Fix border color alpha

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: VkSamplerCreateInfo::mipLodBias is signed
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: VkSamplerCreateInfo::mipLodBias is signed

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Assert on CmdExecuteCommands
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Assert on CmdExecuteCommands

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Fix max anisotropy
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Fix max anisotropy

Now that we're using the bitpack helpers, we don't need the extra shift

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Don't advertise tiling on non-power-of-two formats
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Don't advertise tiling on non-power-of-two formats

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use a UINT format to clear non-renderable images
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Use a UINT format to clear non-renderable images

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Implement vkCmdClear*Image directly
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Implement vkCmdClear*Image directly

Instead of invoking the meta code, implement it ourselves so we get the
HW clear path.  We could probably put these implementations somewhere
common since they only set up a few things and invoke Begin/EndRendering
but there's not that much point for now.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Add image_view_init/finish functions
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Add image_view_init/finish functions

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Use hardware clears for attachment clears
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Use hardware clears for attachment clears

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonouveau/parser: Add array and float tags for clear values
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nouveau/parser: Add array and float tags for clear values

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agovulkan/meta: fix gnu-empty-initializer build error
Mauro Rossi [Tue, 23 Aug 2022 08:36:11 +0000 (10:36 +0200)]
vulkan/meta: fix gnu-empty-initializer build error

Fixes the following building error:

../src/vulkan/runtime/vk_meta_clear.c:213:42: error: use of GNU empty initializer extension [-Werror,-Wgnu-empty-initializer]
   struct vk_meta_clear_push_data push = { };
                                         ^
1 error generated.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Save/restore push constants around meta ops
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Save/restore push constants around meta ops

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: Wire up early z and post depth coverage
Faith Ekstrand [Tue, 31 Jan 2023 02:11:55 +0000 (20:11 -0600)]
nvk: Wire up early z and post depth coverage

Was crawling through header bits and found that we weren't plumbing
these through.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: add basic primitive restart
Dave Airlie [Tue, 16 Aug 2022 04:27:40 +0000 (14:27 +1000)]
nvk: add basic primitive restart

fixes crucible
func.draw-index16-restart
func.draw-index32-restart

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>

14 months agonvk: support GetImageSparseMemoryRequirements2
Yusuf Khan [Tue, 23 Aug 2022 21:28:05 +0000 (16:28 -0500)]
nvk: support GetImageSparseMemoryRequirements2

KHR_get_memory_requirements2 was enabled but GetImageMemoryRequirem
ents2 was not. This stubs out GetImageMemoryRequirements2 to fix it.

Signed-off-by: Yusuf Khan <yusisamerican@gmail.com>
v2: remove the v1 version of the command as its provided by the
common runtime

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24326>