platform/upstream/ofono.git
13 years agocall-forwarding: More style fixes
Denis Kenzior [Fri, 17 Dec 2010 22:30:43 +0000 (16:30 -0600)]
call-forwarding: More style fixes

13 years agocall-forwarding: Use a flag instead of a boolean
Denis Kenzior [Fri, 17 Dec 2010 22:11:29 +0000 (16:11 -0600)]
call-forwarding: Use a flag instead of a boolean

For storing the presence of CPHS CFF file

13 years agocall-forwarding: Get rid of cfis_indicator
Denis Kenzior [Fri, 17 Dec 2010 21:59:53 +0000 (15:59 -0600)]
call-forwarding: Get rid of cfis_indicator

There's no need to track this information, since if we pick a record
with cfis_indicator for something besides Voice only, then when we
set the record again, the number we set is no longer applicable to
those services.

13 years agosimutil: Remove inaccurate comment
Denis Kenzior [Fri, 17 Dec 2010 21:48:10 +0000 (15:48 -0600)]
simutil: Remove inaccurate comment

13 years agocall-forwarding: Minor style fixes
Denis Kenzior [Fri, 17 Dec 2010 18:51:52 +0000 (12:51 -0600)]
call-forwarding: Minor style fixes

13 years agocall-forwarding: Get rid of unneeded variable
Denis Kenzior [Fri, 17 Dec 2010 18:51:18 +0000 (12:51 -0600)]
call-forwarding: Get rid of unneeded variable

13 years agocall-forwarding: Read/Write cfis/cphs-cff
Jeevaka Badrappan [Fri, 17 Dec 2010 07:04:31 +0000 (23:04 -0800)]
call-forwarding: Read/Write cfis/cphs-cff

13 years agoAUTHORS: Mention John's contributions
Denis Kenzior [Fri, 17 Dec 2010 17:09:03 +0000 (11:09 -0600)]
AUTHORS: Mention John's contributions

13 years agodoc: Update features document
Denis Kenzior [Fri, 17 Dec 2010 17:08:14 +0000 (11:08 -0600)]
doc: Update features document

13 years agoTODO: Mark CNAP task as done
Gustavo F. Padovan [Fri, 17 Dec 2010 16:54:18 +0000 (14:54 -0200)]
TODO: Mark CNAP task as done

13 years agoTODO: Mark emergency voicecall property task done
Denis Kenzior [Fri, 17 Dec 2010 16:54:08 +0000 (10:54 -0600)]
TODO: Mark emergency voicecall property task done

13 years agovoicecall: Minor style nitpick
Denis Kenzior [Fri, 17 Dec 2010 16:52:42 +0000 (10:52 -0600)]
voicecall: Minor style nitpick

13 years agovoicecall: Add emergency property
John Mathew [Tue, 7 Dec 2010 12:20:43 +0000 (07:20 -0500)]
voicecall: Add emergency property

13 years agodoc: Add emergency property to Voicecall
John Mathew [Tue, 7 Dec 2010 12:20:43 +0000 (07:20 -0500)]
doc: Add emergency property to Voicecall

13 years agoTODO: add owner to 'Network updating the ECC' task
Petteri Tikander [Fri, 17 Dec 2010 09:56:27 +0000 (11:56 +0200)]
TODO: add owner to 'Network updating the ECC' task

13 years agoAUTHORS: Mention Lasse's contributions
Denis Kenzior [Fri, 17 Dec 2010 00:59:21 +0000 (18:59 -0600)]
AUTHORS: Mention Lasse's contributions

13 years agotest: test case for changing Call Barring password
Lasse Kunnasluoto [Thu, 16 Dec 2010 13:12:55 +0000 (14:12 +0100)]
test: test case for changing Call Barring password

13 years agoTODO: add blacklisting
Pekka Pessi [Fri, 3 Dec 2010 09:02:07 +0000 (11:02 +0200)]
TODO: add blacklisting

13 years agoexamples: Add network name handling to history
Denis Kenzior [Fri, 17 Dec 2010 00:39:15 +0000 (18:39 -0600)]
examples: Add network name handling to history

13 years agoatmodem: Always poll clcc, even if cring + clip
Denis Kenzior [Fri, 17 Dec 2010 00:33:19 +0000 (18:33 -0600)]
atmodem: Always poll clcc, even if cring + clip

Even in the case of CRING and CLIP being used, we should start a CLCC
poll.  This is because we must still rely on polling CLCC to detect when
an incoming call has been terminated by the remote side.

13 years agoatmodem: Fix reporting of CLIP
Denis Kenzior [Thu, 16 Dec 2010 23:12:38 +0000 (17:12 -0600)]
atmodem: Fix reporting of CLIP

When RING & CLCC polling is used, the CLIP will not be reported
correctly if the CLIP: notification does not arrive

13 years agoatmodem: Do not re-parse CLIP / CNAP
Denis Kenzior [Thu, 16 Dec 2010 23:09:09 +0000 (17:09 -0600)]
atmodem: Do not re-parse CLIP / CNAP

These needs to be parsed once and not parsed unnecessarily once the
information has been recorded

13 years agoatmodem: Set cnap validity to not provided
Denis Kenzior [Wed, 15 Dec 2010 23:09:39 +0000 (17:09 -0600)]
atmodem: Set cnap validity to not provided

13 years agotest: add CNAP to test-ss-control-cs
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:42 +0000 (18:12 -0200)]
test: add CNAP to test-ss-control-cs

13 years agoatmodem: Unify COLR/CNAP/CLIP/COLP parser
Denis Kenzior [Wed, 15 Dec 2010 19:41:16 +0000 (13:41 -0600)]
atmodem: Unify COLR/CNAP/CLIP/COLP parser

13 years agoatmodem: Fix parsing of CNAP status
Denis Kenzior [Wed, 15 Dec 2010 19:34:19 +0000 (13:34 -0600)]
atmodem: Fix parsing of CNAP status

13 years agoatmodem: add CNAP to call-settings
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:41 +0000 (18:12 -0200)]
atmodem: add CNAP to call-settings

13 years agodoc: add CallingNamePresentation to CallSettings
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:40 +0000 (18:12 -0200)]
doc: add CallingNamePresentation to CallSettings

13 years agocall-settings: add CNAP support
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:39 +0000 (18:12 -0200)]
call-settings: add CNAP support

13 years agoinclude: add cnap_query callback
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:38 +0000 (18:12 -0200)]
include: add cnap_query callback

13 years agocall-settings: fix coding style
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:37 +0000 (18:12 -0200)]
call-settings: fix coding style

13 years agotest-stkutil: Modify the check logic of time zone
Yang Gu [Mon, 13 Dec 2010 03:03:23 +0000 (11:03 +0800)]
test-stkutil: Modify the check logic of time zone

13 years agoifx: Take out unused defines
Denis Kenzior [Tue, 14 Dec 2010 13:39:47 +0000 (07:39 -0600)]
ifx: Take out unused defines

13 years agoatmodem: Add CNAP parsing to voicecall
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:36 +0000 (18:12 -0200)]
atmodem: Add CNAP parsing to voicecall

13 years agodoc: add Name property
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:35 +0000 (18:12 -0200)]
doc: add Name property

13 years agovoicecall: Use cnap validity in get_properties
Denis Kenzior [Sun, 12 Dec 2010 11:11:30 +0000 (05:11 -0600)]
voicecall: Use cnap validity in get_properties

13 years agovoicecall: Use clip_validity in get_properties
Denis Kenzior [Sun, 12 Dec 2010 11:03:36 +0000 (05:03 -0600)]
voicecall: Use clip_validity in get_properties

13 years agovoicecall: Minor style fixes
Denis Kenzior [Sun, 12 Dec 2010 11:03:09 +0000 (05:03 -0600)]
voicecall: Minor style fixes

13 years agovoicecall: add support for CNAP
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:34 +0000 (18:12 -0200)]
voicecall: add support for CNAP

Enable oFono to get a info about the Calling Name.

13 years agocommon: add CNAP defines
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:33 +0000 (18:12 -0200)]
common: add CNAP defines

13 years agoinclude: add CNAP types to ofono_call structure
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:33 +0000 (18:12 -0200)]
include: add CNAP types to ofono_call structure

13 years agodoc: Add short FAQ for release process details
Marcel Holtmann [Wed, 15 Dec 2010 07:56:43 +0000 (08:56 +0100)]
doc: Add short FAQ for release process details

13 years agosimfs: Add unknown sim phase check
Jeevaka Badrappan [Mon, 6 Dec 2010 18:39:17 +0000 (10:39 -0800)]
simfs: Add unknown sim phase check

13 years agosim: fix minor issue in ofono_sim_get_phase
Jeevaka Badrappan [Mon, 6 Dec 2010 18:39:16 +0000 (10:39 -0800)]
sim: fix minor issue in ofono_sim_get_phase

13 years agohuawei: Pass the HUAWEI vendor ID to gprs driver
Denis Kenzior [Sat, 11 Dec 2010 17:38:29 +0000 (11:38 -0600)]
huawei: Pass the HUAWEI vendor ID to gprs driver

13 years agoatutil: Fix parsing of un-quoted CREG / CGREG
Denis Kenzior [Tue, 7 Dec 2010 03:36:54 +0000 (21:36 -0600)]
atutil: Fix parsing of un-quoted CREG / CGREG

On broken hardware like the Huawei, it is possible to receive both an
unsolicited and a solicited version of the CREG / CGREG within within
the same response set.  Skipping of the unsolicited version was not
handled correctly.  This attempts to fix this issue.

13 years agoatmodem: use macros for CLIP validity
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:30 +0000 (18:12 -0200)]
atmodem: use macros for CLIP validity

13 years agoatmodem: cleanup DBG messages
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:31 +0000 (18:12 -0200)]
atmodem: cleanup DBG messages

13 years agotest: fix bug in test-ss-control-cs
Gustavo F. Padovan [Mon, 6 Dec 2010 20:12:29 +0000 (18:12 -0200)]
test: fix bug in test-ss-control-cs

13 years agostkutil: Allow empty strings in for Text dataobj
Denis Kenzior [Fri, 10 Dec 2010 18:13:06 +0000 (12:13 -0600)]
stkutil: Allow empty strings in for Text dataobj

Explicitly allow length = 1 (DCS) followed by zero characters.  This
seems to be explicitly allowed by the test specification (namely Get
Input 1.9.1A)

13 years agostk: fix issue to avoid null pointer for alpha_id
Guillaume Lucas [Wed, 8 Dec 2010 12:33:32 +0000 (12:33 +0000)]
stk: fix issue to avoid null pointer for alpha_id

If a SET UP CALL proactive command with no alpha identifier
occurs, the alpha_id pointer will be set to NULL. This will
generate a crash in the stkagent with dbus function. To avoid
this we use an empty string if the alpha identifier is not
present in the command.

13 years agounit: Fix up stk test data timezone handling
Denis Kenzior [Fri, 10 Dec 2010 16:26:30 +0000 (10:26 -0600)]
unit: Fix up stk test data timezone handling

13 years agounit: Use empty text instead of NULL
Denis Kenzior [Fri, 10 Dec 2010 16:26:09 +0000 (10:26 -0600)]
unit: Use empty text instead of NULL

13 years agostk: No need to check for null text
Denis Kenzior [Fri, 10 Dec 2010 15:25:02 +0000 (09:25 -0600)]
stk: No need to check for null text

For Set up idle mode text

13 years agostkutil: fix crash cause by null text string
Guillaume Lucas [Tue, 7 Dec 2010 10:58:47 +0000 (10:58 +0000)]
stkutil: fix crash cause by null text string

According to 3GPP TS 31.124 a zero length for the text string
should be allowed. An empty string must be returned to the
user in this case.

13 years agogdbus: fix accessing freed callback data
Johan Hedberg [Thu, 9 Dec 2010 19:52:54 +0000 (21:52 +0200)]
gdbus: fix accessing freed callback data

cb->disc_func or cb->conn_func could remove the callback so this needs
to be checked for before continuing processing.

13 years agodoc: Add RoamingPreference property
Rajesh Kadhiravan Nagaiah [Thu, 2 Dec 2010 23:29:05 +0000 (15:29 -0800)]
doc: Add RoamingPreference property

13 years agotest: Fixup build issues with test-sms
Denis Kenzior [Thu, 9 Dec 2010 07:53:05 +0000 (01:53 -0600)]
test: Fixup build issues with test-sms

13 years agoradio-settings: Minor style fixes for rule M13
Denis Kenzior [Wed, 8 Dec 2010 17:55:07 +0000 (11:55 -0600)]
radio-settings: Minor style fixes for rule M13

13 years agoAUTHORS: Mention Rafael's contributions
Denis Kenzior [Wed, 8 Dec 2010 17:41:36 +0000 (11:41 -0600)]
AUTHORS: Mention Rafael's contributions

13 years agoTODO: Add owner to 'GPS power control atom' task
Rafael Ignacio Zurita [Thu, 2 Dec 2010 19:22:47 +0000 (16:22 -0300)]
TODO: Add owner to 'GPS power control atom' task

13 years agodoc: Reword the description of GsmBand and UmtsBand
Denis Kenzior [Wed, 8 Dec 2010 17:38:25 +0000 (11:38 -0600)]
doc: Reword the description of GsmBand and UmtsBand

13 years agodoc: document frequency band selection
Lucas De Marchi [Thu, 2 Dec 2010 01:55:59 +0000 (23:55 -0200)]
doc: document frequency band selection

13 years agoradio-settings: Minor style issues
Denis Kenzior [Wed, 8 Dec 2010 17:35:44 +0000 (11:35 -0600)]
radio-settings: Minor style issues

13 years agoradio-settings: add frequency band selection props
Lucas De Marchi [Thu, 2 Dec 2010 01:55:58 +0000 (23:55 -0200)]
radio-settings: add frequency band selection props

13 years agoinclude: Minor style fixes
Denis Kenzior [Wed, 8 Dec 2010 17:26:58 +0000 (11:26 -0600)]
include: Minor style fixes

13 years agoradio-settings: add frequency band selection methods
Lucas De Marchi [Thu, 2 Dec 2010 01:55:57 +0000 (23:55 -0200)]
radio-settings: add frequency band selection methods

13 years agoTODO: Mark Provide Local Information task as done
Denis Kenzior [Wed, 8 Dec 2010 16:39:59 +0000 (10:39 -0600)]
TODO: Mark Provide Local Information task as done

13 years agoTODO: Mark Language Notification task as done
Jeevaka Badrappan [Wed, 1 Dec 2010 19:47:21 +0000 (11:47 -0800)]
TODO: Mark Language Notification task as done

13 years agounit: Minor style updates to test-sms
Denis Kenzior [Wed, 8 Dec 2010 16:31:05 +0000 (10:31 -0600)]
unit: Minor style updates to test-sms

13 years agoAUTHORS: Mention Oleg's contributions
Denis Kenzior [Wed, 8 Dec 2010 16:27:48 +0000 (10:27 -0600)]
AUTHORS: Mention Oleg's contributions

13 years agounit: add national dialect SMS character set tests
Oleg Zhurakivskyy [Wed, 1 Dec 2010 12:27:42 +0000 (14:27 +0200)]
unit: add national dialect SMS character set tests

13 years agosimutil: fixup style according to M11
Denis Kenzior [Wed, 8 Dec 2010 15:43:25 +0000 (09:43 -0600)]
simutil: fixup style according to M11

13 years agogdbus: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:01 +0000 (17:39 -0200)]
gdbus: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agostk: Handle provide local info proactive command
Yang Gu [Tue, 30 Nov 2010 10:44:50 +0000 (18:44 +0800)]
stk: Handle provide local info proactive command

13 years agosmsutil: Make timezone an optional field
Yang Gu [Tue, 30 Nov 2010 10:44:49 +0000 (18:44 +0800)]
smsutil: Make timezone an optional field

13 years agotest: When priting help for enter-pin, exit
Denis Kenzior [Wed, 8 Dec 2010 13:03:01 +0000 (07:03 -0600)]
test: When priting help for enter-pin, exit

13 years agosmsutil: Change the range of time zone
Yang Gu [Tue, 30 Nov 2010 10:44:48 +0000 (18:44 +0800)]
smsutil: Change the range of time zone

13 years agophonesim: Add modem reset trigger
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:56 +0000 (16:52 -0200)]
phonesim: Add modem reset trigger

13 years agoAdd ofono_modem_reset()
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:55 +0000 (16:52 -0200)]
Add ofono_modem_reset()

Some modems can screw up everything and then we will need to do a silent
reset of the modem. This patch take the modem back to the OFFLINE state.

13 years agomodem: add ofono_modem_reset() to modem.h
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:54 +0000 (16:52 -0200)]
modem: add ofono_modem_reset() to modem.h

13 years agomodem: only unref pending if it is a powered pending
Gustavo F. Padovan [Fri, 3 Dec 2010 21:40:22 +0000 (19:40 -0200)]
modem: only unref pending if it is a powered pending

13 years agoTODO: add owner to 'SIM PIN retry counter' task
Lucas De Marchi [Thu, 2 Dec 2010 12:46:46 +0000 (10:46 -0200)]
TODO: add owner to 'SIM PIN retry counter' task

13 years agoTODO: Add owner for the CNAP task
Gustavo F. Padovan [Thu, 2 Dec 2010 17:14:43 +0000 (15:14 -0200)]
TODO: Add owner for the CNAP task

13 years agogatchat: fix canceling in progress commands
Vinicius Costa Gomes [Thu, 2 Dec 2010 20:13:42 +0000 (17:13 -0300)]
gatchat: fix canceling in progress commands

As g_queue_peek_head() returns the node data field, we have to compare
it against the actual command, not against the pointer to the queue node.

13 years agosmsutil: Minor style fix
Denis Kenzior [Tue, 7 Dec 2010 02:11:55 +0000 (20:11 -0600)]
smsutil: Minor style fix

13 years agobuild: Silence another make message
Marcel Holtmann [Tue, 7 Dec 2010 09:00:36 +0000 (10:00 +0100)]
build: Silence another make message

13 years agoMark ofono/*.h symbolink links as built sources
Rémi Denis-Courmont [Mon, 6 Dec 2010 15:49:56 +0000 (17:49 +0200)]
Mark ofono/*.h symbolink links as built sources

This forces automake/make to build them first if needed (as before).
But it avoids marking every single header as a dependency of every
single object. Thus we do not need a bogus full rebuild of the tree
everytime a header is added.

13 years agovoicecall: fix dial result handling
Pekka Pessi [Fri, 26 Nov 2010 15:14:49 +0000 (17:14 +0200)]
voicecall: fix dial result handling

The existing call will be automatically put on hold if there is an
existing active call when dialing. On some modems the dial request
returns only after the dialed call is active and the existing call has
been put on hold.

However, on isimodem driver the dial request returns immediately before
the existing call has changed its status. With isimodem driver the
dial_handle_result() selected the existing call from the list when it
should have created a new one.

The dial result handling now guards againt returning a previously dialed
active call as result.

13 years agonetwork: Send strength as a byte, not uint16
Denis Kenzior [Fri, 3 Dec 2010 18:14:06 +0000 (12:14 -0600)]
network: Send strength as a byte, not uint16

To be consistent with the documentation

13 years agoAUTHORS: Mention Helen's contributions
Denis Kenzior [Thu, 2 Dec 2010 20:24:07 +0000 (14:24 -0600)]
AUTHORS: Mention Helen's contributions

13 years agoste: Minor style fixes
Denis Kenzior [Thu, 2 Dec 2010 20:23:35 +0000 (14:23 -0600)]
ste: Minor style fixes

13 years agoste: Restructure caif channel creation
Helen Clemson [Thu, 2 Dec 2010 11:05:40 +0000 (12:05 +0100)]
ste: Restructure caif channel creation

This is restructuring the caif channel creation, so that at a later
date multiple AT channels can be supported. This effectively moves
the channel creation from ste_enable, into its own function,
ste_create_channel.

13 years agoisi/voicecall: fix handling of waiting calls
Pekka Pessi [Fri, 3 Dec 2010 08:30:50 +0000 (10:30 +0200)]
isi/voicecall: fix handling of waiting calls

Also, do not retrieve calls after isi_release_all_active() because
retrieving is now only an unwanted side-effect .

13 years agoisi/voicecall: avoid side-effects of release
Pekka Pessi [Fri, 3 Dec 2010 08:30:49 +0000 (10:30 +0200)]
isi/voicecall: avoid side-effects of release

If a call was held automatically when an another call was dialed or
answered, it gets retrieved when the other call is released unless
auto change features is explicitly disabled.

Drop cause_type parameter because it is never used.

Use cause code for busy when releasing incoming or waiting calls.

13 years agoisi/voicecall: add call id to queued requests
Pekka Pessi [Fri, 3 Dec 2010 08:30:48 +0000 (10:30 +0200)]
isi/voicecall: add call id to queued requests

13 years agoisi/voicecall: fix status reporting
Pekka Pessi [Fri, 3 Dec 2010 08:30:47 +0000 (10:30 +0200)]
isi/voicecall: fix status reporting

Do not report incoming calls to the oFono core until they can be
answered.

Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(),
TERMINATED calls via ofono_voicecall_disconnected().

13 years agocoding-style M14: parenthesis around sizeof arg
Pekka Pessi [Fri, 3 Dec 2010 09:05:28 +0000 (11:05 +0200)]
coding-style M14: parenthesis around sizeof arg

13 years agotest: Unregister agents on keyboard interrupt
Aki Niemi [Fri, 3 Dec 2010 12:47:40 +0000 (14:47 +0200)]
test: Unregister agents on keyboard interrupt

Control-C now calls UnregisterAgent(), so the agents exit cleanly.

13 years agotest: Fix script output
Aki Niemi [Fri, 3 Dec 2010 12:46:51 +0000 (14:46 +0200)]
test: Fix script output

There is no proposing, just action.