Rui Marinho [Thu, 9 Mar 2017 19:19:44 +0000 (19:19 +0000)]
Fix build
Rui Marinho [Wed, 28 Jun 2017 20:25:23 +0000 (21:25 +0100)]
[UWP] Fixes for usage of XF with .net native toolchain (#1024)
* [UWP]Add required info for .net native when using AccessibilityView on UWP
* [UWP] Add reference to xaml assembly
* [UWP] Change rd.xml to be a embeded resource
* [UWP] Move code to the right place
* [UW]Only specify namespace we need
Rui Marinho [Mon, 26 Jun 2017 18:13:37 +0000 (19:13 +0100)]
[UWP] Make sure to update HitTestVisible when IsEnable changes (#1015)
Samantha Houts [Mon, 26 Jun 2017 18:11:53 +0000 (11:11 -0700)]
[Android] Dispose check before setting properties on Button (#1013)
E.Z. Hart [Mon, 26 Jun 2017 17:17:25 +0000 (11:17 -0600)]
Add missing member variable to FormsApplicationActivity
E.Z. Hart [Sat, 24 Jun 2017 00:29:38 +0000 (18:29 -0600)]
Fix NRE when background color of button set in FormsApplicationActivity (#1010)
Rui Marinho [Thu, 1 Jun 2017 10:27:12 +0000 (11:27 +0100)]
Fix border on android buttons (#941)
* [Android] Add a button background tracker to handle background and border properties and be shared between button renderers
* [Android]Fix border radius dependency
* [Android] Make sure we always create or updated the background button tracker
Samantha Houts [Fri, 23 Jun 2017 10:37:00 +0000 (03:37 -0700)]
[iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (#994)
* Add repro for 56896
* [iOS] Cached defined row heights for estimation
* [iOS] Null check source
E.Z. Hart [Thu, 22 Jun 2017 22:33:03 +0000 (16:33 -0600)]
Set the Id field for Android Views created by Forms #1004
Rui Marinho [Thu, 22 Jun 2017 19:12:59 +0000 (20:12 +0100)]
Fix build
Jimmy Garrido [Thu, 22 Jun 2017 18:49:39 +0000 (11:49 -0700)]
Fix possible crash on API 21+ at launch when using Holo theme and FormsApplicationActivity (#961)
* Fix possible crash on API 21+ at launch
* Do not use an explicit cast
* Do not use C# 7 pattern matching
Samantha Houts [Thu, 22 Jun 2017 18:19:26 +0000 (11:19 -0700)]
[Android] Remove the ". " on empty labels (Accessibility) on Fastrenderers (#915)
* [Android] Concatenate Name/HelpText better
Also remove some parameters that were added to workaround an issue that
no longer exists.
* Add repro
* Listen to Stephane
he's usually right
* oops, didn't save
Paul DiPietro [Thu, 22 Jun 2017 17:52:38 +0000 (12:52 -0500)]
Remove debug outputs (#1008)
Matthias [Thu, 27 Apr 2017 14:42:12 +0000 (16:42 +0200)]
Add check for instance of UITableView (#885)
Stephane Delcroix [Wed, 17 May 2017 11:20:22 +0000 (13:20 +0200)]
[XamlC] fix release builds of Xaml Unit Tests
bentmar [Mon, 12 Jun 2017 09:22:32 +0000 (11:22 +0200)]
Dispose check on ButtonRenderer (#975)
Check if buttonrenderer is disposed when making changes
Stephane Delcroix [Thu, 1 Jun 2017 07:12:00 +0000 (09:12 +0200)]
[previewer] make sure we do not crash even if the previewer doesn't s… (#946)
* [previewer] make sure we do not crash even if the previewer doesn't sets the flag
* make the tests pass
Stephane Delcroix [Tue, 16 May 2017 19:12:20 +0000 (21:12 +0200)]
[XamlC] fix build
E.Z. Hart [Tue, 16 May 2017 17:27:41 +0000 (11:27 -0600)]
Remove VisualElement finalizer (#918)
* [Controls] Add repo for bugzilla 55365
* Remove finalizer from VisualElement
* Remove unused using directive
* Removing test for 44074
* Update docs
Stephane Delcroix [Tue, 16 May 2017 17:07:31 +0000 (19:07 +0200)]
[XamlC] process symbols if DebugType is set (#925)
Stephane Delcroix [Wed, 10 May 2017 18:07:37 +0000 (20:07 +0200)]
[C] fix BP declaring Types for A11y (#913)
Samantha Houts [Wed, 10 May 2017 17:20:57 +0000 (10:20 -0700)]
[All] Rename Accessibility -> AutomationProperties (#912)
* [All] Renamed Accessibility -> AutomationProperties
* Update docs
* Restore doc summaries
* Revert unintended csproj changes
Rui Marinho [Wed, 10 May 2017 15:05:27 +0000 (16:05 +0100)]
Fix build
Samantha Houts [Wed, 10 May 2017 06:50:20 +0000 (23:50 -0700)]
[Core] Accessibility works with XamlC (#911)
* Add unit tests for a11y XAML parsing
* [Core] Add Get/Set methods for XamlC
* Update docs
* Fix rogue blank line
Rui Marinho [Thu, 4 May 2017 14:27:30 +0000 (15:27 +0100)]
Fix bugzilla55542 (#898)
* [Controls] Add repo for bugzilla 55542
* [Core] Fix caching null renderer for ViewCell view
Koen Hendriks [Thu, 4 May 2017 14:08:30 +0000 (16:08 +0200)]
[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)
* [Android] Add null check before creating and drawing canvas bugzilla 55559 & bugzilla 45602.
* [Android] REFACTOR Add null check before creating and drawing canvas bugzilla 55559 & 45602 #899
E.Z. Hart [Thu, 4 May 2017 09:51:01 +0000 (03:51 -0600)]
Give layouts a chance to handle touch events after passing though immediate children (#902)
* Repro for Bugzilla 55912
* Automate test
* Give the layout a chance to actually handle gestures before bubbling up
bentmar [Fri, 28 Apr 2017 09:27:15 +0000 (11:27 +0200)]
Add disposed check on FastRenderer.VisualElemen... (#888)
bentmar [Fri, 28 Apr 2017 09:15:09 +0000 (11:15 +0200)]
[Android] Add disposed check on FastRenderers.LabelRenderer (#886)
* add disposed check on FastLabelRenderer
Description of Change
Check is the Label is dispodes on GetDesiredSize() on fast LabelRenderer
Bugs Fixed
System.ObjectDisposedException: Cannot access a disposed object.
API Changes
None
Behavioral Changes
None
* Update LabelRenderer.cs
bentmar [Fri, 28 Apr 2017 09:14:42 +0000 (11:14 +0200)]
add disposed check on FastRenderers.FrameRenderer (#887)
Samantha Houts [Tue, 2 May 2017 23:18:05 +0000 (16:18 -0700)]
[iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
* Add repro for 55745
* [iOS] Null Element before disposing trial renderers
Stephane Delcroix [Fri, 28 Apr 2017 19:11:38 +0000 (21:11 +0200)]
[Xaml] move ValueConverterProvider to Core (#890)
* [Xaml] move ValueConverterProvider to Core
* [docs] fix docs
Stephane Delcroix [Thu, 27 Apr 2017 09:17:27 +0000 (11:17 +0200)]
[XamlC] support valueTypes x:Arrays (#875)
Jason Smith [Wed, 26 Apr 2017 17:11:46 +0000 (10:11 -0700)]
Merge master
Samantha Houts [Tue, 25 Apr 2017 21:43:51 +0000 (14:43 -0700)]
Add netstandard group to nuspec (#884)
E.Z. Hart [Tue, 25 Apr 2017 18:16:25 +0000 (12:16 -0600)]
Better error handling for image loading errors on iOS/Android (#849)
* First run at removing async void image update methods
Consistent error logging and IsLoading on Android,iOS,UWP
Move error logging into image handlers for better messages
Add demo of custom ImageRenderer error handling
Update docs
Make the test smaller so the results don't get pushed offscreen
Fix namespace error
* Update error handling for fast image renderer
* Update 37625 test to use image we control
* Add java disposed check to avoid ObjectDisposedException in async operations
* Add disposed checks to legacy renderer; null check element before SetIsLoading
* Check disposed on GetDesiredSize for fast renderer
Use local disposed member where possible for disposed check
* Check for disposal after async handlers in iOS
* Add disposal checks after async methods in Windows
* Reset linker settings on project; reduce redundant casts in ImageViewExtensions
Stephane Delcroix [Tue, 25 Apr 2017 18:15:36 +0000 (20:15 +0200)]
[XamlC] Check param type in op_Implicit (#876)
Samantha Houts [Tue, 25 Apr 2017 18:14:16 +0000 (11:14 -0700)]
[iOS] Prevent NRE in ListView OnItemSelected (#883)
* Add repro
* [iOS] Prevent NRE in ListView
* [Android] Prevent NRE in ListView
Not observed, but adding defensive check just in case
Stephane Delcroix [Tue, 25 Apr 2017 18:06:29 +0000 (20:06 +0200)]
[Xaml] OnPlatform.Default value (#873)
* [Xaml] OnPlatform.Default value
* docs
Stephane Delcroix [Tue, 25 Apr 2017 18:06:29 +0000 (20:06 +0200)]
[Xaml] OnPlatform.Default value (#873)
* [Xaml] OnPlatform.Default value
* docs
Stephane Delcroix [Thu, 20 Apr 2017 19:06:00 +0000 (21:06 +0200)]
[XamlC] support nested types type declarations (#872)
Stephane Delcroix [Thu, 20 Apr 2017 18:53:13 +0000 (20:53 +0200)]
[XamlC] allow namespaces in {x:Type} markups (#867)
* [XamlC] allow namespaces in {x:Type} markups
* missing test
E.Z. Hart [Tue, 18 Apr 2017 09:28:03 +0000 (03:28 -0600)]
Make OnElementPropertyChanged virtual on fast renderers (#870)
kingces95 [Wed, 19 Apr 2017 16:50:07 +0000 (12:50 -0400)]
calling API not available in all versions (#877)
kingces95 [Wed, 19 Apr 2017 16:50:07 +0000 (12:50 -0400)]
calling API not available in all versions (#877)
Stephane Delcroix [Wed, 19 Apr 2017 08:37:01 +0000 (10:37 +0200)]
[Xaml][test] Passing test for Bz55343
Stephane Delcroix [Tue, 18 Apr 2017 12:47:35 +0000 (14:47 +0200)]
(Passing) test for 54977
E.Z. Hart [Tue, 18 Apr 2017 09:28:03 +0000 (03:28 -0600)]
Make OnElementPropertyChanged virtual on fast renderers (#870)
Andres G. Aragoneses [Tue, 18 Apr 2017 09:27:10 +0000 (17:27 +0800)]
README: add macOS to list of supported platforms (#871)
Support was added in https://github.com/xamarin/Xamarin.Forms/pull/650
(https://github.com/xamarin/Xamarin.Forms/commit/
52fc04724fc163c68c54cf33a5931871f8c1ee8e)
E.Z. Hart [Thu, 13 Apr 2017 14:40:05 +0000 (08:40 -0600)]
Update ListProxyTest.WeakToWeak so it works in Release mode (#866)
* Update ListProxyTest.WeakToWeak so it works in Release mode
* Disable CS0414 for test
E.Z. Hart [Thu, 13 Apr 2017 15:11:50 +0000 (09:11 -0600)]
Verify FragmentContainer created when queueing fragment transaction (Android) (#865)
* Add check for disposed MasterDetailContainer when queueing fragment transaction
* Fix various ObjectDisposedExceptions when setting main page
* Add check for legacy renderers when querying control properties
E.Z. Hart [Thu, 13 Apr 2017 14:40:05 +0000 (08:40 -0600)]
Update ListProxyTest.WeakToWeak so it works in Release mode (#866)
* Update ListProxyTest.WeakToWeak so it works in Release mode
* Disable CS0414 for test
Rui Marinho [Wed, 12 Apr 2017 18:04:55 +0000 (19:04 +0100)]
[Test]Ignore Weak reference test, failing only on release
Rui Marinho [Wed, 12 Apr 2017 16:10:18 +0000 (17:10 +0100)]
[UITest]Fix release build
Rob Lyndon [Wed, 12 Apr 2017 10:57:13 +0000 (11:57 +0100)]
Resource Manager fix for F# File Resources (Bugzilla 53515) (#825)
* Resource Manager fix for F# File Resources (Bugzilla 53515)
* Changed spaces to tabs and changed the argument name in the ResourceManager.GetId() function.
* Improved the type checking in GetId().
jcmanke [Tue, 11 Apr 2017 22:52:04 +0000 (17:52 -0500)]
Map renderer extensibility (#844)
* Added extensibility features to Maps
Android MapRenderer:
- Moved map initialization to protected virtual method OnMapReady, called by explicit implementation of IOnMapReady
- Added protected virtual method CreateMarker for customization of pins
iOS MapRenderer:
- Added protected virtual method CreateAnnotation for customization of pins
Pin:
- Unsealed the Pin class
- Made Label a bindable property
* [Docs] Update docs
Mike Norman [Tue, 11 Apr 2017 22:51:14 +0000 (17:51 -0500)]
Marking exposed plumbing internal only in the docs. (#863)
* Marking exposed plumbing internal only in the docs.
* Update docs
Stephane Delcroix [Tue, 11 Apr 2017 18:09:06 +0000 (20:09 +0200)]
[C] Lookup in RD also lookup in merged RDs (#861)
kingces95 [Tue, 11 Apr 2017 18:02:06 +0000 (14:02 -0400)]
Implicit impl of controller ifaces (#807)
* Simplify ICtrl callsites
* Rebase fix
Jimmy Garrido [Tue, 11 Apr 2017 09:48:41 +0000 (02:48 -0700)]
Clean up NavigationBar code in Platform (#753)
Anders Rasmussen [Tue, 11 Apr 2017 09:03:07 +0000 (11:03 +0200)]
Spell correction of FromattedString (#864)
kingces95 [Mon, 10 Apr 2017 06:48:54 +0000 (02:48 -0400)]
Do not emit implict_op if from/to are same type (#862)
Stephane Delcroix [Fri, 7 Apr 2017 07:48:17 +0000 (09:48 +0200)]
[Xaml] Set the TargetProperty on ServiceProvider (#847)
Samantha Houts [Fri, 7 Apr 2017 07:47:33 +0000 (00:47 -0700)]
[Internal] Normalize Obsolete attributes (#860)
* [All] Normalize Obsolete attributes.
Make sure we include the version in which the member was deprecated and
consistent instructions for working around the deprecation, if
applicable.
* Update docs
kingces95 [Thu, 6 Apr 2017 21:47:12 +0000 (17:47 -0400)]
Fix 52962; Cont refresh even when pullToRefresh is disabled (#810)
Stephane Delcroix [Thu, 6 Apr 2017 21:37:59 +0000 (23:37 +0200)]
More Xaml generic support (#857)
* [XamlG] allow x:Name on nested generic types
* [Xaml*] fail on undeclared xmlns
* [XamlC] allow x:Arguments on generic ctors
Stephane Delcroix [Thu, 6 Apr 2017 21:22:50 +0000 (23:22 +0200)]
[Xaml[C]] supports 'using:' xmlns declarations (#851)
Stephane Delcroix [Thu, 6 Apr 2017 21:13:49 +0000 (23:13 +0200)]
Fix 54334 (#855)
* [C] unset the FromStyle flag on manual setting
* [C] Do not reset overriden values to default
* complete the fix
App Bureauet [Thu, 6 Apr 2017 21:11:05 +0000 (23:11 +0200)]
OnResume assumed that _application had been set (#859)
When OnResume is called it should not expect the _application to be set already.
I have an app where I use one activity for showing a splash screen and then it starts an intent to show the main activity containing the application.
This used to work before 2.3.4.224.
E.Z. Hart [Thu, 6 Apr 2017 18:55:51 +0000 (12:55 -0600)]
Fix NRE when RecycleElement is on and list is scrolled quickly (#856)
adrianknight89 [Thu, 6 Apr 2017 18:25:47 +0000 (13:25 -0500)]
[iOS] ActivityIndicator should not disappear when used in a ViewCell (#495)
* preserve activity indicator state
* changed to using listviewrenderer
* remove whitespace
* moved message to constructor
* add sample code
* remove message sending
* changes
* remove curly braces
James Clancey [Thu, 6 Apr 2017 17:54:00 +0000 (09:54 -0800)]
Added Section indexes when FastScrolled is enabled (#850)
* Added Section indexes when FastScrolled is enabled
* Moved the GroupListAdapater to its own file
* Renamed Setup to ValidateSectionData
Rui Marinho [Thu, 6 Apr 2017 13:19:52 +0000 (14:19 +0100)]
Android fastrenderers (#845)
* Obsolete IVisualElementRenderer.ViewGroup in favor of .View
* Fix NRE
* Changing TContainer in PlatformEffect to View
* Fix "View" type
* new VisualElementRenderer
* First attempt at a fast(er) button renderer
* Fast Label Renderer
* Let's try that again. Behold: Label Fast Renderer
* Move FrameRenderer into Fast Renderers
* Fix Disposable on VisualElementRenderer
* Simplify touch and click handlers
* Drop empty if clause
* [Android] Add initial Image fast renderer
* Split accessibility out to a separate helper class; fix tapgesture bug with label
* [Android] Small fixes to VisualElementRenderer
* Move accessiblity stuff to a separate class (which needs a good name)
* Prevent query from looking to parent for fast renderers
* [Android] ImageRenderer refactoring
* Fix elevation/z-index bugs with Button (e.g., 40173)
* Move SetLabeledBy to Accessibilitizer
* Un-break automation IDs for Labels
* Move gesture handling to its own class
* Split gesture and effect management into separate classes
* Remove unneeded packager from LabelRenderer
* LabelRenderer inherits from FormsTextView
* Batch updates to View
* Fix isOnParentRenderer check for non-Android platforms
* [Controls] Update Xamarin.Forms.ControlGallery.iOS.csproj
* [Android,IOS] Small fixes to rebase and use of Internals
* [Android] Ignroe warning for now
* Fast renderers now passing InputTransparent and IsEnabled tests
* Fast and legacy renderers now pass the Enabled and InputTransparent tests
* Change PlatformEffect back, default container to null
* Fix mangled using directives
Stephane Delcroix [Wed, 5 Apr 2017 11:41:02 +0000 (13:41 +0200)]
[Xaml] updating the unittests project to cecil .10-b5 too
Mike Norman [Mon, 3 Apr 2017 19:31:40 +0000 (14:31 -0500)]
Early april doc bugs (#854)
* Fixed: https://github.com/xamarin/documentation/issues/2071
Pulled dated and exuberant examples.
* Fixed: https://github.com/xamarin/documentation/issues/2002
Also added content for Load method in HtmlWebViewSource.xml
* Fixed: https://github.com/xamarin/documentation/issues/1959
* Fixed: https://github.com/xamarin/documentation/issues/1866
Jimmy Garrido [Fri, 31 Mar 2017 00:04:29 +0000 (17:04 -0700)]
Hide alert window before setting result (#848)
Stephane Delcroix [Thu, 30 Mar 2017 11:31:27 +0000 (13:31 +0200)]
[XamlC] update cecil to 0.10.0-beta5
E.Z. Hart [Wed, 29 Mar 2017 08:52:45 +0000 (02:52 -0600)]
Align iOS, Android, Windows handling of tap gesture event bubbling (#842)
* Add test for gesture bubbling behavior on all controls;
Make Windows behavior consistent with other platforms;
* Fix the stepper test
* Make Frame on Android handle tap event bubbling like the other platforms
* Formatting changes and query syntax instead of SelectMany
Paul DiPietro [Mon, 27 Mar 2017 17:26:56 +0000 (12:26 -0500)]
[WinRT/UWP] Enable selection in password entry (#677)
* [WinRT/UWP] Enable selection in password entry
* Remove unnecessary if
Rui Marinho [Mon, 27 Mar 2017 14:52:23 +0000 (15:52 +0100)]
[Docs] Fix docs Scrollview IOS Specific (#843)
kingces95 [Mon, 27 Mar 2017 10:32:18 +0000 (03:32 -0700)]
Fix 53427; Change default UAP styling for a label (#837)
Samantha Houts [Mon, 27 Mar 2017 10:31:04 +0000 (03:31 -0700)]
[iOS] Prevent NRE when page is switched on Appearing (#840)
Rui Marinho [Fri, 24 Mar 2017 22:11:20 +0000 (22:11 +0000)]
[Android]Refactor to use a extension method to get the drawable (#841)
* [Android]Refactor to use a extension method to get the drawable
* [Android] Use local variable on check
BradChase2011 [Fri, 24 Mar 2017 20:12:45 +0000 (16:12 -0400)]
Bz53803 Android app crashes during initialization due to invalid cast of toolbar TextView. (#835)
adrianknight89 [Fri, 24 Mar 2017 19:07:59 +0000 (14:07 -0500)]
[iOS] Platform specifics to control ScrollView content touch delay (#563)
* can delay content touches optionally
* revert bug fix
* add back _tapGesture
* remove extra declaration
Shane Neuville [Fri, 24 Mar 2017 18:58:28 +0000 (12:58 -0600)]
Setup a ConditionalWeakTable in ListProxy to hold weak references so that a ListView will work when connected to a Weak Source (#802)
Rui Marinho [Fri, 24 Mar 2017 17:54:12 +0000 (17:54 +0000)]
[Android] Still look for the normal drawable on resources (#839)
* [Android] Still look for the normal drawable on resources
* [Android]Fix code style
Samantha Houts [Fri, 24 Mar 2017 11:02:59 +0000 (04:02 -0700)]
[iOS] Don't skip row height estimation for grouped lists (#838)
* Nest bugzilla 51536 classes for less pollution
* Add repro for 53834
* [iOS] Don't skip row height estimation for grouped lists
Samantha Houts [Thu, 23 Mar 2017 23:12:41 +0000 (16:12 -0700)]
[Android] ScrollView can now consume Effects (#836)
* Add repro
* [Android] Make ScrollView an IEffectControlProvider
E.Z. Hart [Thu, 23 Mar 2017 17:18:38 +0000 (11:18 -0600)]
UI tests for InputTransparent and fixes for Android/Windows (#808)
* Set up automated UI tests for InputTransparent
* Pull in Adrian's UI tests from PR 483
* Fix bugs with box/label/image gestures passing through when not transparent
* Fix disabling of layouts on Windows; fix 44096 test for iOS/Windows;
* Automate the 53445 test
Rui Marinho [Thu, 23 Mar 2017 11:03:48 +0000 (11:03 +0000)]
[UITests]Add Xamarin.Forms.Core.UITests.Shared (#711)
* [UITests]Add Xamarin.Forms.Core.UITests.Shared
* fix
* [UITests]Use shared UITest project on macOS
* [UITests] Add correct platform queries
* [Controls] Add missing Preserve
Rui Marinho [Wed, 22 Mar 2017 19:38:19 +0000 (19:38 +0000)]
[Android] Fix NRE on Picker (#834)
Stephane Delcroix [Wed, 22 Mar 2017 16:53:24 +0000 (17:53 +0100)]
[XamlC] accept assignment of Object from unboxed value types in SetValue (#832)
Stephane Delcroix [Wed, 22 Mar 2017 16:09:41 +0000 (17:09 +0100)]
[C] Make sure all children are parented (#831)
* unit test
* [C] make sure all children are properly parented
Samantha Houts [Wed, 22 Mar 2017 10:43:17 +0000 (03:43 -0700)]
[iOS/Win] Label will not unnecessarily expand (#827)
* Add repro for 53362
* [iOS] Label will not unnecessarily expand
* [Win] Label will not unnecessarily expand
E.Z. Hart [Wed, 22 Mar 2017 10:40:15 +0000 (04:40 -0600)]
Add gesture disposed check to FrameRenderer (#829)
Stephane Delcroix [Tue, 21 Mar 2017 16:39:01 +0000 (17:39 +0100)]
[C] fix NIE in Span (#828)
James Clancey [Tue, 21 Mar 2017 15:02:39 +0000 (07:02 -0800)]
iOS renderers now properly look up the ImageSourceHandler for FileImageSource (#826)
Stephane Delcroix [Tue, 21 Mar 2017 11:44:31 +0000 (12:44 +0100)]
[C] fix BP DeclaringType in TextElement[C
Jason Smith [Tue, 21 Mar 2017 10:38:36 +0000 (03:38 -0700)]
Convert Android maps to GetMapAsync call (#824)
* [A] Move map renderer to calling GetMapAsync
* [A] Make sure Map initializes correctly with Async map fetching