borenet [Mon, 2 Jun 2014 19:19:29 +0000 (12:19 -0700)]
Revert of Update SKP version to 13 (https://codereview.chromium.org/
309753004/)
Reason for revert:
Did not include perf baselines.
Original issue's description:
> Update SKP version to 13
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
7574153e9cc52b1b560ded02a2b219cda4b1816c
R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
309813003
Robert Phillips [Mon, 2 Jun 2014 19:18:27 +0000 (15:18 -0400)]
Adding resource files
The ktx file is to test the new ktx reader
The pkm shrinks the size of the pkm test file
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/
312563002
borenet [Mon, 2 Jun 2014 19:15:31 +0000 (12:15 -0700)]
Update SKP version to 13
R=rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
309753004
robertphillips [Mon, 2 Jun 2014 19:09:29 +0000 (12:09 -0700)]
Remove legacy Picture-recording flags from Android build
R=scroggo@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
304333002
scroggo [Mon, 2 Jun 2014 18:32:56 +0000 (11:32 -0700)]
Remove unitmappers header.
This file contained a bunch of unitmappers. Luckily noone includes
it, since it wouldn't compile (the unitmapper class was removed in
https://codereview.chromium.org/
288313009).
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
295383013
mtklein [Mon, 2 Jun 2014 18:26:59 +0000 (11:26 -0700)]
Clean up SkOnce:
1 Remove atExit feature: clients can do it just as well as SkOnce can.
2 Remove support for functors: no one but the unit test did that.
3 Remove support for unused non-static SkOnceFlag (no SK_ONCE_INIT).
4 Add SkOnce variants for no-arg functions so we're not forced to pass dummy values all the time.
5 Merge SkSpinlock and SkOnceFlag, making all members private.
6 More notes about memory barriers, adding an acquire load after acquiring the spinlock.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
302083003
humper [Mon, 2 Jun 2014 18:09:12 +0000 (11:09 -0700)]
invert comparison sense for reason return
BUG=skia:
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
313433003
mtklein [Mon, 2 Jun 2014 17:59:35 +0000 (10:59 -0700)]
Compile-time initialize special SkMatrices.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
303263011
robertphillips [Mon, 2 Jun 2014 17:20:14 +0000 (10:20 -0700)]
Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h)
R=bsalomon@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
309683002
mtklein [Mon, 2 Jun 2014 15:44:27 +0000 (08:44 -0700)]
Port most uses of SkOnce to SkLazyPtr.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=15006
Committed: http://code.google.com/p/skia/source/detail?r=15014
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
304383005
krajcevski [Mon, 2 Jun 2014 15:02:45 +0000 (08:02 -0700)]
Fix bracket outside of ifdef
R=jvanverth@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
305333003
mtklein [Mon, 2 Jun 2014 14:53:01 +0000 (07:53 -0700)]
Clean up SkLazyPtrs only in SK_DEVELOPER mode.
Checking only SK_DEBUG may make SkLazyPtr too anal about leaks for
clients. Still working through strange leak problems inside Skia
tests, so it's probably premature to turn it on in Chrome tests.
BUG=379570
R=reed@google.com, mtklein@google.com, bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
308003014
krajcevski [Mon, 2 Jun 2014 14:38:14 +0000 (07:38 -0700)]
Initial work to get ETC1 data up to the GPU
Committed: http://code.google.com/p/skia/source/detail?r=15001
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
302783002
scroggo [Mon, 2 Jun 2014 14:19:13 +0000 (07:19 -0700)]
Update comments about debugging on master.
Update the makefile to reference the correct location of
config.mk.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
308703009
robertphillips [Mon, 2 Jun 2014 14:15:18 +0000 (07:15 -0700)]
Add Sample slide for Rectanizers
R=jvanverth@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
303263005
reed [Mon, 2 Jun 2014 12:45:31 +0000 (05:45 -0700)]
hide SkDevice::config()
TBR=robertphilips
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
302253002
rmistry [Mon, 2 Jun 2014 12:29:08 +0000 (05:29 -0700)]
Whitespace change to test the Git Skia CQ
NOTREECHECKS=true
BUG=skia:2613
TBR=
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
311603002
rmistry [Mon, 2 Jun 2014 12:20:32 +0000 (05:20 -0700)]
Use googlesource VIEW_VC in codereview.settings
BUG=skia:2613
NOTREECHECKS=true
NOTRY=true
R=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
309643005
rmistry [Mon, 2 Jun 2014 12:12:27 +0000 (05:12 -0700)]
Whitespace change to test the Git Skia CQ
NOTREECHECKS=true
TBR=
BUG=skia:
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
308703008
Eric Boren [Mon, 2 Jun 2014 12:03:43 +0000 (08:03 -0400)]
Whitespace
BUG=skia:
Review URL: https://codereview.chromium.org/
304233004
commit-bot@chromium.org [Sat, 31 May 2014 21:47:03 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
308953002
git-svn-id: http://skia.googlecode.com/svn/trunk@15016
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 31 May 2014 00:15:22 +0000 (00:15 +0000)]
Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/
304383005/)
Reason for revert:
linux x86-64 release segfault in src/ports/SkFontHost_fontconfig.cpp:107
http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/builds/905/steps/RunTests/logs/stdio
Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006
>
> Committed: http://code.google.com/p/skia/source/detail?r=15014
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
306063004
git-svn-id: http://skia.googlecode.com/svn/trunk@15015
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 23:59:12 +0000 (23:59 +0000)]
Port most uses of SkOnce to SkLazyPtr.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=15006
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
304383005
git-svn-id: http://skia.googlecode.com/svn/trunk@15014
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 21:53:01 +0000 (21:53 +0000)]
New file for simpler updating of Android defines.
When building Skia for the Android framework, we will now read a
file which only includes defines. This will make it easier for
people deprecating APIs to add the guard to Android.
R=reed@google.com, djsollen@google.com, bungeman@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
305193002
git-svn-id: http://skia.googlecode.com/svn/trunk@15013
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 21:52:52 +0000 (21:52 +0000)]
Add a way for the gpu veto to report back the reason why it said no
BUG=2334
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
301423002
git-svn-id: http://skia.googlecode.com/svn/trunk@15012
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 21:07:05 +0000 (21:07 +0000)]
fix casting issue with or operator
R=reed@google.com, epoger@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
305253002
git-svn-id: http://skia.googlecode.com/svn/trunk@15011
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 21:03:38 +0000 (21:03 +0000)]
Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS (https://codereview.chromium.org/
308083010/)
Reason for revert:
broke skia/ext/bitmap_platform_device_cairo.cc:44:56: error: no matching function for call to ‘SkBitmap::installPixels
Original issue's description:
> remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
>
> TBR=
> NOTRY=
>
> Committed: http://code.google.com/p/skia/source/detail?r=15007
TBR=
NOTREECHECKS=true
NOTRY=true
Author: reed@google.com
Review URL: https://codereview.chromium.org/
301353006
git-svn-id: http://skia.googlecode.com/svn/trunk@15010
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 21:00:52 +0000 (21:00 +0000)]
Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/
304383005/)
Reason for revert:
Leaking refs on SkTypeface on Macs.
Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
304283007
git-svn-id: http://skia.googlecode.com/svn/trunk@15009
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 30 May 2014 20:50:56 +0000 (20:50 +0000)]
Allow SkPictureImageFilter to be serialized when not run cross-process.
Picture serialization is not yet hardened, but it turns out we do need
serialization of SkPictureImageFilter for deferred SVG-on-SVG filters,
since the SkPaints (and thus the SkImageFilters) are serialized by
SkPictureRecord. However, deferred filters are always drawn in the
same process, so we can safely serialize them in this case. We do this
by turning the compile-time check for
SK_ALLOW_PICTUREIMAGEFILTER_SERIALIZATION to a runtime check for
isCrossProcess().
The image filter fuzzer sample was also modified to enable fuzzing
of basic picture image filters (the code had rotted a bit, being behind
an #ifdef that no one sets).
BUG=375162
R=sugoi@google.com
Review URL: https://codereview.chromium.org/
311443003
git-svn-id: http://skia.googlecode.com/svn/trunk@15008
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 20:47:13 +0000 (20:47 +0000)]
remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
TBR=
NOTRY=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
308083010
git-svn-id: http://skia.googlecode.com/svn/trunk@15007
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 20:42:00 +0000 (20:42 +0000)]
Port most uses of SkOnce to SkLazyPtr.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
304383005
git-svn-id: http://skia.googlecode.com/svn/trunk@15006
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 20:41:20 +0000 (20:41 +0000)]
Add an OR operator overload for SaveFlags to avoid extra static casts.
R=reed@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
303373003
git-svn-id: http://skia.googlecode.com/svn/trunk@15005
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 20:36:21 +0000 (20:36 +0000)]
Revert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium.org/
302783002/)
Reason for revert:
ETC1 linking problems with chrome.
Original issue's description:
> Initial work to get ETC1 data up to the GPU
>
> Committed: http://code.google.com/p/skia/source/detail?r=15001
R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
303273008
git-svn-id: http://skia.googlecode.com/svn/trunk@15004
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 30 May 2014 20:36:15 +0000 (20:36 +0000)]
Implement SkPictureImageFilter bounds computation.
SkPictureImageFilter::onFilterBounds() was unimplemented, causing
incorrect results for SVG filters and impl-side painting (see Chrome
bug https://code.google.com/p/chromium/issues/detail?id=375162).
BUG=skia:
R=reed@google.com
Review URL: https://codereview.chromium.org/
306733003
git-svn-id: http://skia.googlecode.com/svn/trunk@15003
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 18:55:03 +0000 (18:55 +0000)]
Use GrGLShaderBuilder::GenProgramOutput in GrGLProgram.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
305203002
git-svn-id: http://skia.googlecode.com/svn/trunk@15002
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 18:41:39 +0000 (18:41 +0000)]
Initial work to get ETC1 data up to the GPU
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
302783002
git-svn-id: http://skia.googlecode.com/svn/trunk@15001
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 17:32:50 +0000 (17:32 +0000)]
Fixing clusterfuzz issue
When reading an SkSSE2ProcCoeffXfermode object, fProcSIMD should never be NULL. The reason for this is that it's not possible to create such an object through SkPlatformXfermodeFactory_impl_SSE2(), which is the only function used to create these objects, so if we're reading one, it's clearly invalid.
BUG=379181
R=reed@google.com, mtklein@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
306183002
git-svn-id: http://skia.googlecode.com/svn/trunk@15000
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 17:23:31 +0000 (17:23 +0000)]
add --dryRun flag to dm
BUG=2294
R=mtklein@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
305963007
git-svn-id: http://skia.googlecode.com/svn/trunk@14999
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 30 May 2014 17:15:23 +0000 (17:15 +0000)]
check for null typeface from paint
git-svn-id: http://skia.googlecode.com/svn/trunk@14998
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 16:46:10 +0000 (16:46 +0000)]
Test font created from paint
This is meant to allow clients to migrate over to a SkFont api on canvas (e.g. drawText(text, font, paint)) while still permitting the current setters in paint (e.g. setTextSize, setFlags).
R=bungeman@google.com, eae@chromium.org, fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
245953003
git-svn-id: http://skia.googlecode.com/svn/trunk@14997
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 15:14:56 +0000 (15:14 +0000)]
move all code generation under genProgram() in GrGLShaderBuilder.
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
306063002
git-svn-id: http://skia.googlecode.com/svn/trunk@14996
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 15:11:28 +0000 (15:11 +0000)]
more rebaselines for filterbitmap and downsamplebitmap.
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
304353007
git-svn-id: http://skia.googlecode.com/svn/trunk@14995
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 15:09:44 +0000 (15:09 +0000)]
Revert of TSAN caught us racing in ScalarBench.cpp (https://codereview.chromium.org/
305033002/)
Reason for revert:
windows doesn't like it
Original issue's description:
> TSAN caught us racing in ScalarBench.cpp
>
> http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14992
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
308883003
git-svn-id: http://skia.googlecode.com/svn/trunk@14994
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 15:06:24 +0000 (15:06 +0000)]
using real tiles when simulating tiling
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
303403003
git-svn-id: http://skia.googlecode.com/svn/trunk@14993
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 14:56:58 +0000 (14:56 +0000)]
TSAN caught us racing in ScalarBench.cpp
http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
305033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14992
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 13:55:58 +0000 (13:55 +0000)]
Move the LATC and ETC1 enum values to GrPixelConfig. I also tried to put in checks in a few places to make sure that we weren't using these pixel configurations in places that we shouldn't be.
LATC is a DXT-esque alpha compression format that goes by a few other names (RGTC, 3DC). It might be useful to investigate using it to compress the alpha masks that we get from software rasterization. This patch set adds enums for that and recognition whether or not the device can support it.
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
304743004
git-svn-id: http://skia.googlecode.com/svn/trunk@14991
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 30 May 2014 13:45:36 +0000 (13:45 +0000)]
fix int->scalar warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@14990
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 13:26:10 +0000 (13:26 +0000)]
Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/
308683005/)"
This reverts commit
eecaea4148805834f223681f70b6488ceba12d09.
R=robertphillips@google.com, scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
301283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14989
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 12:12:41 +0000 (12:12 +0000)]
Whitespace change to test CQ throttling
(SkipBuildbotRuns)
TBR=
NOTREECHECKS=True
NOTRY=True
BUG=skia:2472
Committed: http://code.google.com/p/skia/source/detail?r=14986
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
307993004
git-svn-id: http://skia.googlecode.com/svn/trunk@14988
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 12:08:27 +0000 (12:08 +0000)]
Revert of Whitespace change to test CQ throttling (https://codereview.chromium.org/
307993004/)
Reason for revert:
Testing CQ throttling
Original issue's description:
> Whitespace change to test CQ throttling
>
> (SkipBuildbotRuns)
> TBR=
> NOTREECHECKS=True
> NOTRY=True
>
> BUG=skia:2472
>
> Committed: http://code.google.com/p/skia/source/detail?r=14986
(SkipBuildbotRuns)
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:2472
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
304323007
git-svn-id: http://skia.googlecode.com/svn/trunk@14987
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 12:07:20 +0000 (12:07 +0000)]
Whitespace change to test CQ throttling
(SkipBuildbotRuns)
TBR=
NOTREECHECKS=True
NOTRY=True
BUG=skia:2472
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
307993004
git-svn-id: http://skia.googlecode.com/svn/trunk@14986
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 10:08:22 +0000 (10:08 +0000)]
Fix the rendering error of SkDraw::drawVertices in gpu path for solid color.
If both textures and vertex-colors are NULL, drawVertices should stroke hairlines with the paint's color.
This behavior is a useful debugging mode to visualize the mesh.
BUG=skia:2266
R=bsalomon@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
189963004
git-svn-id: http://skia.googlecode.com/svn/trunk@14985
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 30 May 2014 03:06:10 +0000 (03:06 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14984
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 30 May 2014 01:06:44 +0000 (01:06 +0000)]
Fixing a clusterfuzz found issue
BUG=378175
R=reed@google.com, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
306033003
git-svn-id: http://skia.googlecode.com/svn/trunk@14983
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 22:20:03 +0000 (22:20 +0000)]
Make GrGLShaderBuilder store a GenProgramOutput
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
304383002
git-svn-id: http://skia.googlecode.com/svn/trunk@14982
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 22:01:08 +0000 (22:01 +0000)]
new animated sample to show subpixel translate bug with high quality scaling
BUG=1445
R=reed@google.com, robertphillips@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
303123003
git-svn-id: http://skia.googlecode.com/svn/trunk@14981
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 21:29:51 +0000 (21:29 +0000)]
Incremental refactoring of GrGLProgram and GrGLShaderBuilder
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
302663006
git-svn-id: http://skia.googlecode.com/svn/trunk@14980
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 21:10:32 +0000 (21:10 +0000)]
Revert of setConfig -> setInfo (https://codereview.chromium.org/
308683005/)
Reason for revert:
broke all Windows bots
Original issue's description:
> setConfig -> setInfo
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14978
R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
302053002
git-svn-id: http://skia.googlecode.com/svn/trunk@14979
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 20:47:53 +0000 (20:47 +0000)]
setConfig -> setInfo
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
308683005
git-svn-id: http://skia.googlecode.com/svn/trunk@14978
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 20:14:48 +0000 (20:14 +0000)]
DM tweaks
- Don't print status updates for skipped tasks or count them as pending tasks.
- Refactor DMReporter a bit for better symmetry, be more explicit about
how we read atomics (that is, approximately) in printStatus() (née finish()).
- Remove mutex locking from printStatus().
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
309483003
git-svn-id: http://skia.googlecode.com/svn/trunk@14977
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 20:13:22 +0000 (20:13 +0000)]
SkLazyPtr, mk. 2
SK_DECLARE_STATIC_LAZY_PTR and
SK_DECLARE_STATIC_LAZY_PTR_ARRAY let you declare a single or
array of static pointers that are lazily initialized.
You can think of this as a restricted, lighter-weight
version of SkOnce. There's no guarantee that Create will be
called exactly once, but we do guarantee all threads will
agree on the resulting pointer.
We'll clean up any other extra pointers we Create()ed by
calling Destroy(), which defaults to SkDELETE. In debug
mode, we also clean up the winning pointer at process exit,
so we can make sure we didn't leak it or free it early.
I've ported SkData (singleton) and SkXfermode (array) as
examples. Once this lands I'll port most other users of
SkOnce.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
306943003
git-svn-id: http://skia.googlecode.com/svn/trunk@14976
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 19:26:48 +0000 (19:26 +0000)]
Constify the arguments to createTexture
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
301993002
git-svn-id: http://skia.googlecode.com/svn/trunk@14975
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 19:09:52 +0000 (19:09 +0000)]
Move all code generation from GrGLProgram to GrGLShaderBuilder
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
306663003
git-svn-id: http://skia.googlecode.com/svn/trunk@14974
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 May 2014 18:47:06 +0000 (18:47 +0000)]
move SkImageGenerator.cpp from src/images to src/core
git-svn-id: http://skia.googlecode.com/svn/trunk@14973
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 18:46:38 +0000 (18:46 +0000)]
Add testing for Rectanizer-derived classes
This in preparation for expanding the Rectanizer API for removing rects and adding a new derived class
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
304313002
git-svn-id: http://skia.googlecode.com/svn/trunk@14972
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 18:29:48 +0000 (18:29 +0000)]
Tinker with SkLazyFnPtr a bit.
I moved the choice function from a get() arg to a template parameter.
I think this removes some of the overemphasis on "choose" from the call
site, making it a bit more clear it's normally very cheap.
It's also now more in line with what I'm thinking now for the general
SkLazyPtr<T>, which needs a "create" parameter just like SkLazyFnPtr's
"choose", but also a "destroy" that it might use both in .get() but also
at process exit. That "destroy" needs to be made part of the type to be
called at exit, so might as well make "create" and "choose" template
parameters too so it's all consistent.
Also, add (C).
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
298393005
git-svn-id: http://skia.googlecode.com/svn/trunk@14971
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 18:24:54 +0000 (18:24 +0000)]
Add SkBarriers to ports.
This completes a TODO we've had to move our memory-barrier code out of
SkOnce. I also want to start using sk_acquire_load elsewhere.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
304593003
git-svn-id: http://skia.googlecode.com/svn/trunk@14970
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 May 2014 18:10:46 +0000 (18:10 +0000)]
Mark remaining Ubuntu msaa shadertext2 images as ignore-failure.
BUG=skia:2619
Review URL: https://codereview.chromium.org/
304323002
git-svn-id: http://skia.googlecode.com/svn/trunk@14969
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 17:28:11 +0000 (17:28 +0000)]
add SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
309543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14968
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 May 2014 17:10:54 +0000 (17:10 +0000)]
fix bug in legacy code for SK_SUPPORT_LEGACY_IMAGEGENERATORAPI
git-svn-id: http://skia.googlecode.com/svn/trunk@14967
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 17:10:24 +0000 (17:10 +0000)]
Reland https://codereview.chromium.org/
286903025
BUG=skia:
R=bensong@google.com, epoger@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
304613002
git-svn-id: http://skia.googlecode.com/svn/trunk@14966
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 May 2014 17:00:28 +0000 (17:00 +0000)]
cleanup gyp common_variables
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
301173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14965
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 May 2014 16:56:53 +0000 (16:56 +0000)]
Rebaseline stragglers, mark shadertext2 as ignore on ubunutu for msaa configs.
BUG=skia:2619
Review URL: https://codereview.chromium.org/
308723002
git-svn-id: http://skia.googlecode.com/svn/trunk@14964
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 16:52:40 +0000 (16:52 +0000)]
Remove SkRecorder's kWriteOnly mode.
I'm soon going to have SkRecorder start calling getTotalMatrix(), which
would be broken in write-only mode. That change is big and nebulous,
but it's clear kWriteOnly needs to go, so we might as well kill it now.
My notes in bench_playback about kWriteOnly mode being important were
probably overly cautious. I now think this is a fair enough comparison
even re-recording into a read-write canvas.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
290653004
git-svn-id: http://skia.googlecode.com/svn/trunk@14963
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 16:05:48 +0000 (16:05 +0000)]
Bench rebaseline from codereview: fix is_finished
R=epoger@google.com, bensong@google.com
TBR=benchen, epoger
BUG=skia:2225
NOTREECHECKS=true
NOTRY=true
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
304943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14962
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 May 2014 16:05:47 +0000 (16:05 +0000)]
legacy refEncodedData() returns data, not bool
git-svn-id: http://skia.googlecode.com/svn/trunk@14961
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 15:58:00 +0000 (15:58 +0000)]
Add the ability to select a source image to use in the code.
A much farther ranging change than I suspected.
Basically add a 'source' integer to every Try, store that in the database with every Try, add the source to the computation of the hash, and load and use the 'source' value when navigating history.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
294903017
git-svn-id: http://skia.googlecode.com/svn/trunk@14960
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 15:57:47 +0000 (15:57 +0000)]
replace config() with colorType()
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
303543009
git-svn-id: http://skia.googlecode.com/svn/trunk@14959
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 15:57:20 +0000 (15:57 +0000)]
Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/
304443003/)"
Fix is to add colortable param to installPixels()
This reverts commit
924205aaf2e0c3c65dda13e0eaccde3e7b2a5c40.
BUG=skia:
R=scroggo@google.com, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
300263005
git-svn-id: http://skia.googlecode.com/svn/trunk@14958
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 15:57:11 +0000 (15:57 +0000)]
Make SkPictureRecorder::partialReplay const
This will make it easier to integrate this into Android's use case.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
307693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14957
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 29 May 2014 15:54:27 +0000 (15:54 +0000)]
Put DirectWrite bitmap fix behind the SK_IGNORE_DWRITE_BITMAP_FIX flag.
R=reed@google.com
Review URL: https://codereview.chromium.org/
309503002
git-svn-id: http://skia.googlecode.com/svn/trunk@14956
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 May 2014 15:45:19 +0000 (15:45 +0000)]
Rebase shadertext2,3 and stroketext on gpu configs
Review URL: https://codereview.chromium.org/
304203003
git-svn-id: http://skia.googlecode.com/svn/trunk@14955
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 May 2014 15:36:09 +0000 (15:36 +0000)]
New baselines for imagefilter GMs in perspective mode post-r14920.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
301183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14954
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 14:53:24 +0000 (14:53 +0000)]
re-enable downsample and filterbitmap GMs
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
301963003
git-svn-id: http://skia.googlecode.com/svn/trunk@14953
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 14:42:32 +0000 (14:42 +0000)]
rebaselines for ignored filterbitmap / downsamplebitmap tests
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
305933002
git-svn-id: http://skia.googlecode.com/svn/trunk@14952
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 14:31:28 +0000 (14:31 +0000)]
Bench Rebaseline from Codereview: separate out all_trybots_finished()
BUG=skia:2225
NOTREECHECKS=true
R=epoger@google.com, bensong@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
301143002
git-svn-id: http://skia.googlecode.com/svn/trunk@14951
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 May 2014 14:27:16 +0000 (14:27 +0000)]
Rebaseline GMs with missing expectated images and shadertext2 msaa
Review URL: https://codereview.chromium.org/
308673002
git-svn-id: http://skia.googlecode.com/svn/trunk@14950
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 14:05:56 +0000 (14:05 +0000)]
ignore failing pdf-native for shadertext
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
304923002
git-svn-id: http://skia.googlecode.com/svn/trunk@14949
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 13:56:19 +0000 (13:56 +0000)]
rebaselines for shadertext after unitmapper removal
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
308653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14948
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 13:43:05 +0000 (13:43 +0000)]
ignore failures for acutals that never appear
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
304153003
git-svn-id: http://skia.googlecode.com/svn/trunk@14947
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 May 2014 13:30:42 +0000 (13:30 +0000)]
Massive rebaseline of gpu images after matrix change.
Review URL: https://codereview.chromium.org/
304153002
git-svn-id: http://skia.googlecode.com/svn/trunk@14946
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 04:04:54 +0000 (04:04 +0000)]
whitespace change to trigger buildbots and get all GM images uploaded
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
304823003
git-svn-id: http://skia.googlecode.com/svn/trunk@14945
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 01:12:10 +0000 (01:12 +0000)]
separate view matrix from rt adjustment
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
299943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14944
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 01:03:18 +0000 (01:03 +0000)]
git cl dcommit# Enter a description of the change.
shadertext2 rebaselines
TBR=
NOTRY=True
NOTREECHECKS=True
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
305853002
git-svn-id: http://skia.googlecode.com/svn/trunk@14943
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 22:47:26 +0000 (22:47 +0000)]
Add sk_memcpy32 to Memcpy bench.
The bench predates the implementation in SkUtils, but now that we've got it of course we want to measure our actual implementation.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
302763006
git-svn-id: http://skia.googlecode.com/svn/trunk@14942
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 22:42:31 +0000 (22:42 +0000)]
Shut up windows build errors on new GM
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
300973005
git-svn-id: http://skia.googlecode.com/svn/trunk@14941
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:52:12 +0000 (21:52 +0000)]
make new blurrect GM and replace the dozens of existing ones
BUG=
NOTRY=True
R=reed@google.com, epoger@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
306583007
git-svn-id: http://skia.googlecode.com/svn/trunk@14940
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:44:05 +0000 (21:44 +0000)]
Set the default discardable pool size for Android framework.
BUG=skia:2389
R=halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
303893002
git-svn-id: http://skia.googlecode.com/svn/trunk@14939
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:43:59 +0000 (21:43 +0000)]
Spin off just SkLazyFnPtr from
305513002.
The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
SkUtils on ARM. We can do a lot better for function pointers.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14929
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
305753002
git-svn-id: http://skia.googlecode.com/svn/trunk@14938
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:32:25 +0000 (21:32 +0000)]
rebaseline #5 for shadertext2
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
305603005
git-svn-id: http://skia.googlecode.com/svn/trunk@14937
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log