platform/upstream/coreclr.git
6 years agoFix shuffling thunk for Unix AMD64 (#16904)
Jan Vorlicek [Tue, 13 Mar 2018 18:56:34 +0000 (19:56 +0100)]
Fix shuffling thunk for Unix AMD64 (#16904)

The shufflign thunk was generated incorrectly for some edge cases when
a struct was passed in a register or a pair of registers in the
destination, but on stack in the source.
This change implements a new algorithm that ensures that argument slots
are never overwritten before their current value is moved out.

It also adds an extensive regression test that checks various
interesting combinations of arguments that were causing issues before.

6 years agoMerge pull request #16888 from jashook/up_jit_stress_timeout
Bruce Forstall [Tue, 13 Mar 2018 18:42:04 +0000 (11:42 -0700)]
Merge pull request #16888 from jashook/up_jit_stress_timeout

Up the jit stress timeout to 5 hours

6 years agoUnblock official builds (#16913)
Matt Mitchell [Tue, 13 Mar 2018 17:45:45 +0000 (10:45 -0700)]
Unblock official builds (#16913)

Removing arm64 linux cross build for now

6 years agoMerge pull request #16390 from sdmaclea/PR-16176
Carol Eidt [Tue, 13 Mar 2018 17:13:31 +0000 (10:13 -0700)]
Merge pull request #16390 from sdmaclea/PR-16176

[Arm64] Mark removed compare zero nodes unused

6 years agoMerge pull request #16822 from sdmaclea/PR-ARM64-BASE-INTRINSICS
Carol Eidt [Tue, 13 Mar 2018 17:02:45 +0000 (10:02 -0700)]
Merge pull request #16822 from sdmaclea/PR-ARM64-BASE-INTRINSICS

[Arm64] Base HW Intrinsics

6 years ago[local gc] refactor apis for threading and suspension to avoid redundant calls in...
David Mason [Tue, 13 Mar 2018 08:24:20 +0000 (01:24 -0700)]
[local gc] refactor apis for threading and suspension to avoid redundant calls in to the runtime (#16765)

* [Local GC] Refactor calls involving thread modes, suspension, and alloc contexts to always operate on current thread

* BOOL -> bool for enable/disable preemptive routines, also remove an unused call to GetThread

* avoid one indirection by having GCToEEInterface::EnablePreemptiveGC return a bool indicating whether the mode was changed

* Callback on IGCHeap for the runtime to notify the GC when it is trapping threads

* use g_fSuspensionPending instead of GCToEEInterface::CatchAtSafePoint for allow_fgc

* Remove CatchAtSafePoint

* Remove GetThread from WaitLongerNoInstru

* code review feedback

* code review feedback

* change BOOL to bool

6 years agoUpdate BuildTools, CoreFx to preview2-02612-03, preview2-26313-01, respectively ...
dotnet-maestro-bot [Tue, 13 Mar 2018 05:07:57 +0000 (00:07 -0500)]
Update BuildTools, CoreFx to preview2-02612-03, preview2-26313-01, respectively (#16902)

6 years agoFix short path expansion (#16901)
Jeremy Kuhne [Tue, 13 Mar 2018 00:38:26 +0000 (17:38 -0700)]
Fix short path expansion (#16901)

Also make methods internal so I can add better unit tests.

6 years agoMissing Case In Remove Relative Segments (#16869)
Anirudh Agnihotry [Mon, 12 Mar 2018 23:47:47 +0000 (16:47 -0700)]
Missing Case In Remove Relative Segments (#16869)

6 years agoUse a cached canceled task in ValueTask (dotnet/corefx#27967)
Stephen Toub [Mon, 12 Mar 2018 19:25:17 +0000 (15:25 -0400)]
Use a cached canceled task in ValueTask (dotnet/corefx#27967)

When an IValueTaskSource reports it completed due to cancellation by the time we AsTask it, we can use a cached canceled task if a) this is the netstandard build, or b) this is the netcoreapp build and it reported cancellation but threw an exception other than a cancellation exception.  We cache the non-generic one in a readonly static, since there's only one of them, but lazily cache the generic one.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
6 years agoMerge pull request #16884 from mikedn/lclvar-dead
Carol Eidt [Mon, 12 Mar 2018 21:51:32 +0000 (14:51 -0700)]
Merge pull request #16884 from mikedn/lclvar-dead

Remove unused LclVarDsc members

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview2-02612-02, preview2-26310-01, preview2...
dotnet-maestro-bot [Mon, 12 Mar 2018 17:51:36 +0000 (10:51 -0700)]
Update BuildTools, CoreClr, CoreFx to preview2-02612-02, preview2-26310-01, preview2-26312-02, respectively

6 years ago[Arm64/Ubuntu] Update docker tag to include binutils (#16896)
Steve MacLean [Mon, 12 Mar 2018 19:42:23 +0000 (15:42 -0400)]
[Arm64/Ubuntu] Update docker tag to include binutils (#16896)

6 years agoRun ILLInk on System.Private.CoreLib.dll to remove dead code. (#16876)
Eugene Rozenfeld [Mon, 12 Mar 2018 19:39:02 +0000 (12:39 -0700)]
Run ILLInk on System.Private.CoreLib.dll to remove dead code. (#16876)

We already run ILLInk on corefx assemblies to remove dead code;
this change enables that for System.Private.CoreLib.dll.

The new ILLink.targets file is similar to the one in corefx.

All runtime dependencies were already computed and rooted in an xml file that
was embedded in System.Private.CoreLib.dll. This change adds ILLinkTrim.xml
with a few manual roots. They are also included in the embedded xml.

The dead code found by ILLink that could be removed from sources was already
removed in https://github.com/dotnet/coreclr/pull/16759 The remaining code removed by ILLink
falls into 4 categories:
1. Inlined constants.
2. Private default constructors when there are no other instance constructors.
3. System.Number+DoubleHelper.Sign that needs to stay in the sources for corert mirror.
4. EventListener._EventSourceCreated event methods (the even field is retained).

ILLink also clears initlocals on all methods so I removed the workaround
we had in jitinterface.cpp.

6 years ago[Arm64] Mark removed compare zero nodes unused
Steve MacLean [Wed, 14 Feb 2018 17:27:03 +0000 (12:27 -0500)]
[Arm64] Mark removed compare zero nodes unused

6 years agoOptimize MemoryExtensions SequenceEqual for more T's (dotnet/corefx#27859)
Atsushi Kanamori [Mon, 12 Mar 2018 16:57:10 +0000 (09:57 -0700)]
Optimize MemoryExtensions SequenceEqual for more T's (dotnet/corefx#27859)

* Optimize MemoryExtensions SequenceEqual for more T's

https://github.com/dotnet/corefx/issues/27487

* Add testcoverage for SequenceEqual<long>

* Remove #if BIT64 dependency for netstandard

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
6 years agoMerge pull request #16709 from sdmaclea/PR-ARM64-Bootstrapping
Wes Haggard [Mon, 12 Mar 2018 17:11:25 +0000 (10:11 -0700)]
Merge pull request #16709 from sdmaclea/PR-ARM64-Bootstrapping

Revise init-tools.sh to support bootstrapping

6 years agoMerge pull request #16877 from CarolEidt/Fix16578
Carol Eidt [Mon, 12 Mar 2018 16:02:44 +0000 (09:02 -0700)]
Merge pull request #16877 from CarolEidt/Fix16578

Fix LSRA enregisterLocalVars

6 years agoMerge pull request #16879 from tannergooding/hwintrin-encode
Carol Eidt [Mon, 12 Mar 2018 15:38:20 +0000 (08:38 -0700)]
Merge pull request #16879 from tannergooding/hwintrin-encode

Ensure that `id->idReg2()` is properly encoded for 4-Byte SIMD instructions

6 years agoFix lldb-3.9-dev package name (#16885)
Steve MacLean [Mon, 12 Mar 2018 09:37:26 +0000 (05:37 -0400)]
Fix lldb-3.9-dev package name (#16885)

6 years agoUp the jit stress timeout to 5 hours
jashook [Sun, 11 Mar 2018 04:04:38 +0000 (20:04 -0800)]
Up the jit stress timeout to 5 hours

Current jitx86hwintrinsicnoavx job runs around 4 hours. Which will cause timeouts if over.

6 years agoRemove unused LclVarDsc members
Mike Danes [Sat, 10 Mar 2018 18:47:19 +0000 (20:47 +0200)]
Remove unused LclVarDsc members

6 years agoSet IsGeneratingNgenPDB flag early (#16882)
Jan Kotas [Sun, 11 Mar 2018 02:29:42 +0000 (18:29 -0800)]
Set IsGeneratingNgenPDB flag early (#16882)

Fixes #16864

6 years agoConvert SSE SetVector128 implementation to managed
Jacek Blaszczynski [Fri, 9 Mar 2018 23:26:39 +0000 (00:26 +0100)]
Convert SSE SetVector128 implementation to managed

6 years agoAdd SSE2 SetVector128 HW intrinsic tests
Jacek Blaszczynski [Thu, 8 Mar 2018 00:41:41 +0000 (01:41 +0100)]
Add SSE2 SetVector128 HW intrinsic tests

6 years agoImplement SSE2 SetVector128 HW intrinsics - managed
Jacek Blaszczynski [Wed, 7 Mar 2018 22:58:43 +0000 (23:58 +0100)]
Implement SSE2 SetVector128 HW intrinsics - managed

6 years ago[Arm64] Add Base HW intrinsic tests
Steve MacLean [Thu, 8 Mar 2018 00:07:51 +0000 (19:07 -0500)]
[Arm64] Add Base HW intrinsic tests

6 years agocrossgen plumbing cleanup (#16883)
Jan Kotas [Sat, 10 Mar 2018 21:35:40 +0000 (13:35 -0800)]
crossgen plumbing cleanup (#16883)

* Delete unused ForceFullTrust command line option for crossgen

* Delete ALLOW_LOCAL_WORKER define

* Delete Zapper::m_legacyMode

* Delete ngenparser.inl

6 years agoAdding tests for the Extend, GetLowerHalf, and StaticCast intrinsics
Tanner Gooding [Tue, 6 Mar 2018 00:00:35 +0000 (16:00 -0800)]
Adding tests for the Extend, GetLowerHalf, and StaticCast intrinsics

6 years agoAdding support for the Extend, GetLowerHalf, and StaticCast AVX intrinsics
Tanner Gooding [Mon, 5 Mar 2018 23:11:30 +0000 (15:11 -0800)]
Adding support for the Extend, GetLowerHalf, and StaticCast AVX intrinsics

6 years agofix r2r relative indirection for arm. (#16171)
Sergey Andreenko [Sat, 10 Mar 2018 18:48:57 +0000 (10:48 -0800)]
fix r2r relative indirection for arm. (#16171)

6 years agoEnsure that `id->idReg2()` is properly encoded for 4-Byte SIMD instructions
Tanner Gooding [Sat, 10 Mar 2018 06:54:21 +0000 (22:54 -0800)]
Ensure that `id->idReg2()` is properly encoded for 4-Byte SIMD instructions

6 years ago[Arm64/Linux] Enable arm64 nuget builds (#16707)
Steve MacLean [Sat, 10 Mar 2018 02:18:22 +0000 (21:18 -0500)]
[Arm64/Linux] Enable arm64 nuget builds (#16707)

6 years agoFix LSRA enregisterLocalVars
Carol Eidt [Sat, 10 Mar 2018 01:50:29 +0000 (17:50 -0800)]
Fix LSRA enregisterLocalVars

We don't bother with the parts of LSRA that deal with lclVars if we have no tracked lclVars. However, we need to check that *after* liveness has run post-Lowering - otherwise we miss any lclVars created by optimizations or during Lowering.

Fix #16578

6 years agoUse ValueStringBuilder instead of StringBuilderCache
Jan Kotas [Fri, 9 Mar 2018 20:45:12 +0000 (12:45 -0800)]
Use ValueStringBuilder instead of StringBuilderCache

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
6 years agoFix the RMW delay handling for hwintrinsic nodes with RMW semantics and more than...
Tanner Gooding [Fri, 9 Mar 2018 03:36:21 +0000 (19:36 -0800)]
Fix the RMW delay handling for hwintrinsic nodes with RMW semantics and more than 2 args

6 years agoUpdate isRMWHWIntrinsic to explicitly cover intrinsics that are always RMW
Tanner Gooding [Thu, 8 Mar 2018 23:34:33 +0000 (15:34 -0800)]
Update isRMWHWIntrinsic to explicitly cover intrinsics that are always RMW

6 years agoUpdating the hwintrinsic codegen to handle the case where `op2Reg == targetReg`
Tanner Gooding [Thu, 8 Mar 2018 22:08:37 +0000 (14:08 -0800)]
Updating the hwintrinsic codegen to handle the case where `op2Reg == targetReg`

6 years agoLog inner exceptions for Environment.Failfast (#16622)
Sung Yoon Whang [Sat, 10 Mar 2018 00:33:26 +0000 (18:33 -0600)]
Log inner exceptions for Environment.Failfast  (#16622)

* Add inner exception log to failfast

* cleanup

* Address PR comments

* Address more GC hole issue

* address more PR comments

6 years agoFix build with Clang 6.0 and enable build with Clang 5.0 (#16855)
Jan Vorlicek [Sat, 10 Mar 2018 00:12:14 +0000 (01:12 +0100)]
Fix build with Clang 6.0 and enable build with Clang 5.0 (#16855)

* Fix build with Clang 6.0

* Add support for clang 5.0 too

6 years agoMerge pull request #16860 from briansull/valuenum-fix
Brian Sullivan [Fri, 9 Mar 2018 23:20:42 +0000 (15:20 -0800)]
Merge pull request #16860 from briansull/valuenum-fix

Add implicit cast for assignments in ValueNumbering when necessary

6 years agoMerge branch 'master' into valuenum-fix
Brian Sullivan [Fri, 9 Mar 2018 21:41:15 +0000 (13:41 -0800)]
Merge branch 'master' into valuenum-fix

6 years agofix typo
Brian Sullivan [Fri, 9 Mar 2018 21:40:52 +0000 (13:40 -0800)]
fix typo

6 years agoFix value numbering of assignments to insert an implicit cast when necessary
Brian Sullivan [Fri, 9 Mar 2018 20:48:46 +0000 (12:48 -0800)]
Fix value numbering of assignments to insert an implicit cast when necessary

6 years agoRevert "Disable fragile NGen for System.Private.CoreLib.dll on ARM" (#16863)
Sergey Andreenko [Fri, 9 Mar 2018 20:28:34 +0000 (12:28 -0800)]
Revert "Disable fragile NGen for System.Private.CoreLib.dll on ARM" (#16863)

This reverts commit bc3b01b5612b21fdb8f11ec6917e5ec4503f1dcc.

6 years agoRevise init-tools.sh to support bootstrapping
Steve MacLean [Wed, 28 Feb 2018 17:00:31 +0000 (12:00 -0500)]
Revise init-tools.sh to support bootstrapping

Add $DotNetBootstrapCliTarPath
Disable ILAsm nuget fetch while bootstrapping

6 years agoWhen value numbering an assignment we may need to insert an implicit cast operation
Brian Sullivan [Fri, 9 Mar 2018 18:59:41 +0000 (10:59 -0800)]
When value numbering an assignment we may need to insert an implicit cast operation

Test case opt/CSE/NarrowStore.cs added

6 years agoDisable fragile NGen for System.Private.CoreLib.dll on ARM
Egor Chesakov [Fri, 9 Feb 2018 00:34:27 +0000 (16:34 -0800)]
Disable fragile NGen for System.Private.CoreLib.dll on ARM

6 years agoDon't build superpmi as crosscomponent (#16729)
Egor Chesakov [Fri, 9 Mar 2018 06:43:13 +0000 (22:43 -0800)]
Don't build superpmi as crosscomponent (#16729)

* Don't build superpmi as crosscomponent
* Replace install with _install in all superpmi CMakeLists.txt files

6 years agoUpdate UsingYourBuild.md (#16842)
Luqun Lou [Fri, 9 Mar 2018 02:37:38 +0000 (18:37 -0800)]
Update UsingYourBuild.md (#16842)

This topic is about DotnetCli instead of CoreRun -- CoreRun is next topic

6 years agoFix Compile error
Tarek Mahmoud Sayed [Fri, 9 Mar 2018 01:03:32 +0000 (17:03 -0800)]
Fix Compile error

6 years agoCollapse AsSpan().Slice(...) into .AsSpan(...) (dotnet/corefx#27867)
Tarek Mahmoud Sayed [Thu, 8 Mar 2018 21:56:43 +0000 (13:56 -0800)]
Collapse AsSpan().Slice(...) into .AsSpan(...) (dotnet/corefx#27867)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
6 years ago[RyuJit] Fix DCE in liveness. (#16845)
Sergey Andreenko [Fri, 9 Mar 2018 01:17:31 +0000 (17:17 -0800)]
[RyuJit] Fix DCE in liveness. (#16845)

* add repro

* fix

6 years ago Disable some GC tests from GCStress runs (#16846)
Sung Yoon Whang [Fri, 9 Mar 2018 00:25:20 +0000 (18:25 -0600)]
 Disable some GC tests from GCStress runs  (#16846)

6 years agoRemoveRelativeSegments moved from path to pathinternal (#16829)
Anirudh Agnihotry [Thu, 8 Mar 2018 20:55:00 +0000 (12:55 -0800)]
RemoveRelativeSegments moved from path to pathinternal (#16829)

6 years agoPass generic context argument for shared instance methods on generic interfaces ...
Andon Andonov [Thu, 8 Mar 2018 20:47:19 +0000 (21:47 +0100)]
Pass generic context argument for shared instance methods on generic interfaces (#16690)

* Add checks and regression test

* Uncomment InvokeConsumer tests

* Revert JIT Interface Check

6 years agoMerge pull request #16809 from sdmaclea/PR-Enable-crypto-test
Carol Eidt [Thu, 8 Mar 2018 20:45:28 +0000 (12:45 -0800)]
Merge pull request #16809 from sdmaclea/PR-Enable-crypto-test

[Arm64] Enable crypto test

6 years agoUpdating the x86 hardware-intrinsics tests to properly accept filter arguments
Tanner Gooding [Tue, 6 Mar 2018 16:48:42 +0000 (08:48 -0800)]
Updating the x86 hardware-intrinsics tests to properly accept filter arguments

6 years agoFix inlining of IAsyncStateMachineBox (#16830)
Stephen Toub [Thu, 8 Mar 2018 19:26:14 +0000 (14:26 -0500)]
Fix inlining of IAsyncStateMachineBox (#16830)

Prior to .NET Core 2.1, if a task was awaited in a default context (or if ConfigureAwait(false) was used), and if the task was then completed on a non-default context (e.g. code running a non-default TaskScheduler calling SetResult on a TaskCompletionSource), its await continuations are not allowed to be inlined, due to concerns that we could be running an arbitrary amount of unknown code in a scheduling environment that's not amenable to it, like a UI thread. The optimizations added in 2.1 erroneously ended up bypassing that IsValidLocationForInlining check, leading to continuations getting inlined in places they weren't previously.

This commit fixes that.  Previously we'd made the IAsyncStateMachineBox interface inherit ITaskCompletionAction, with its Invoke interface method just delegating to MoveNext; then the box could be added to a task as a continuation.  But that ITaskCompletionAction logic isn't specific to async/await and doesn't invoke IsValidLocationForInlining.  We instead need to follow the Action logic that is meant to be used for async/await.  I've removed the ITaskCompletionAction from IAsyncStateMachineBox, replacing it just with a MoveNext interface method, and added a case for IAsyncStateMachineBox to Task's RunContinuations logic.  I then duplicated the AwaitTaskContinuation.RunOrScheduleAction logic that's there for Action and tweaked it for IAsyncStateMachineBox.  In the process I cleaned up a little code to use some newer C# features.

6 years agoDelete incorrect assert in stackLevelSetter. (#16816)
Sergey Andreenko [Thu, 8 Mar 2018 18:24:38 +0000 (10:24 -0800)]
Delete incorrect assert in stackLevelSetter. (#16816)

* add repro
* delete the assert

6 years agoMake member visibility first accross corlib (#16836)
Jan Kotas [Thu, 8 Mar 2018 18:18:50 +0000 (10:18 -0800)]
Make member visibility first accross corlib (#16836)

Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md

6 years agoSet helix source correctly for prodcon build (#16412) (#16837)
Matt Mitchell [Thu, 8 Mar 2018 18:17:20 +0000 (10:17 -0800)]
Set helix source correctly for prodcon build (#16412) (#16837)

* Set helix source correctly for prodcon build

6 years agoUpdate CoreClr, CoreFx to preview2-26308-06, preview2-26308-06, respectively (#16835)
dotnet-maestro-bot [Thu, 8 Mar 2018 17:13:30 +0000 (11:13 -0600)]
Update CoreClr, CoreFx to preview2-26308-06, preview2-26308-06, respectively (#16835)

6 years agoTurn perf jobs back on (#16824)
Michelle McDaniel [Thu, 8 Mar 2018 17:07:40 +0000 (09:07 -0800)]
Turn perf jobs back on (#16824)

6 years agoUpdating isRMWRegOper, OperIsCommutative, and canBeContained to handle HWIntrinsic...
Tanner Gooding [Wed, 7 Mar 2018 20:15:31 +0000 (12:15 -0800)]
Updating isRMWRegOper, OperIsCommutative, and canBeContained to handle HWIntrinsic nodes

6 years agoMove String to shared corelib partition (#16749)
Jan Kotas [Thu, 8 Mar 2018 14:09:03 +0000 (06:09 -0800)]
Move String to shared corelib partition (#16749)

6 years agoDial back `\\?\ ` insertion (dotnet/corefx#27827)
Jeremy Kuhne [Wed, 7 Mar 2018 23:58:06 +0000 (15:58 -0800)]
Dial back `\\?\ ` insertion (dotnet/corefx#27827)

Only premptively adding for FileSystemInfo if we end in period or space.
Long path is taken care of later.

Clean up code a little and add test for DirectoryInfo.Move.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
6 years agoFix ensuring primary stack size (#16698)
Jan Vorlicek [Thu, 8 Mar 2018 11:44:33 +0000 (12:44 +0100)]
Fix ensuring primary stack size (#16698)

1. Make it happen for Alpine only (it was incorrectly being done for
   OSX too.
2. Do it only when the Initialize is called for CLR initialization

6 years agoAdd back method needed by CoreRT
Jan Kotas [Wed, 7 Mar 2018 23:27:00 +0000 (15:27 -0800)]
Add back method needed by CoreRT

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
6 years agoUpdate BuildTools, CoreFx to preview2-02607-03, preview2-26308-02, respectively ...
dotnet-maestro-bot [Thu, 8 Mar 2018 04:32:11 +0000 (22:32 -0600)]
Update BuildTools, CoreFx to preview2-02607-03, preview2-26308-02, respectively (#16821)

6 years agoWorkaround coreclr issue (#16828)
Matt Mitchell [Thu, 8 Mar 2018 02:22:20 +0000 (18:22 -0800)]
Workaround coreclr issue (#16828)

VSTS does not seem to be correctly honoring the working directory for batch script steps.  Explicitly qualify the setup_vs_env.cmd path

6 years ago[RyuJIt] Clean and fix gen return (#16725)
Sergey Andreenko [Thu, 8 Mar 2018 01:26:27 +0000 (17:26 -0800)]
[RyuJIt] Clean and fix gen return (#16725)

* create genSimpleReturn for arm64

* create genFloatReturn for x86

* create genLongReturn for x86 and arm

* merge genReturn

6 years agoFix for issue 14144 (#16674)
Luqun Lou [Thu, 8 Mar 2018 01:19:46 +0000 (17:19 -0800)]
Fix for issue 14144 (#16674)

6 years agoan additional assert for fgValueNumberHelperCallFunc (#16789)
Sergey Andreenko [Thu, 8 Mar 2018 00:51:56 +0000 (16:51 -0800)]
an additional assert for fgValueNumberHelperCallFunc (#16789)

6 years ago[Arm64] Add Base HW intrinsics
Steve MacLean [Thu, 8 Mar 2018 00:01:57 +0000 (19:01 -0500)]
[Arm64] Add Base HW intrinsics

6 years agoDelete AsReadOnly* APIs that are no longer part of the public surface (#16799)
Jan Kotas [Wed, 7 Mar 2018 22:47:49 +0000 (14:47 -0800)]
Delete AsReadOnly* APIs that are no longer part of the public surface (#16799)

6 years agoPerf fix for month-day parsing ambiguity (#16782)
Hugh Zabriskie [Wed, 7 Mar 2018 22:39:22 +0000 (14:39 -0800)]
Perf fix for month-day parsing ambiguity (#16782)

* Perf fix for month-day parsing ambiguity

* Use DateTime.TryCreate

6 years agoRemove dead code found by ILLink. (#16759)
Eugene Rozenfeld [Wed, 7 Mar 2018 22:16:49 +0000 (14:16 -0800)]
Remove dead code found by ILLink. (#16759)

I'm preparing changes to enable running ILLink on SPC
(similarly to what we do on corefx assemblies).
There will be a separate PR for those changes.

This PR just removes the dead code flagged by ILLink from the sources.

6 years agoAddress issue 16800 (#16810)
Jarret Shook [Wed, 7 Mar 2018 21:37:02 +0000 (13:37 -0800)]
Address issue 16800 (#16810)

6 years agoRemove libuuid from scripts and docs (#16805)
kasper3 [Wed, 7 Mar 2018 21:03:35 +0000 (23:03 +0200)]
Remove libuuid from scripts and docs (#16805)

6 years ago[Arm64] Enable crypto test
Steve MacLean [Wed, 7 Mar 2018 21:01:13 +0000 (16:01 -0500)]
[Arm64] Enable crypto test

6 years agoUpdate CoreFx to preview2-26307-06 (#16798)
dotnet-maestro-bot [Wed, 7 Mar 2018 19:56:51 +0000 (13:56 -0600)]
Update CoreFx to preview2-26307-06 (#16798)

6 years agofix inconsistent AVX/AVX2 intrinsic names (#16772)
Fei Peng [Wed, 7 Mar 2018 14:40:45 +0000 (06:40 -0800)]
fix inconsistent AVX/AVX2 intrinsic names (#16772)

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview2-02606-05, preview2-26307-01, preview2...
dotnet-maestro-bot [Wed, 7 Mar 2018 06:33:16 +0000 (00:33 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02606-05, preview2-26307-01, preview2-26307-03, respectively (#16791)

6 years agoMerge pull request #16662 from jashook/remove_vs2015_dependencies
Jarret Shook [Wed, 7 Mar 2018 03:03:36 +0000 (19:03 -0800)]
Merge pull request #16662 from jashook/remove_vs2015_dependencies

Remove vs2015 build dependencies

6 years agoAdd debugger usage note (#16788)
Noah Falk [Wed, 7 Mar 2018 03:02:44 +0000 (19:02 -0800)]
Add debugger usage note (#16788)

6 years agoUpdating the x86 hardware-intrin test templates to use named format arguments
Tanner Gooding [Tue, 6 Mar 2018 16:49:24 +0000 (08:49 -0800)]
Updating the x86 hardware-intrin test templates to use named format arguments

6 years agoCoreFX #24343 Vector Ctor using Span (#16733)
Mandar Sahasrabuddhe [Wed, 7 Mar 2018 00:42:46 +0000 (06:12 +0530)]
CoreFX #24343 Vector Ctor using Span (#16733)

* CoreFX #24343 Vector using Span

dotnet/corefx#24343

* CoreFX #24343 Vector using Span

dotnet/corefx#24343

* CoreFX #24343 Vector using Span

dotnet/corefx#24343

6 years agoRevert "Fix handling of incorrect assemblies on Unix (#16747)" (#16790)
Jan Kotas [Wed, 7 Mar 2018 00:37:51 +0000 (16:37 -0800)]
Revert "Fix handling of incorrect assemblies on Unix (#16747)" (#16790)

This reverts commit 383736b96b643ba46ad290fc86601fc2d62a9436.

6 years agoRemove vs2015 build dependencies
jashook [Mon, 5 Mar 2018 21:35:19 +0000 (13:35 -0800)]
Remove vs2015 build dependencies

6 years agoMerge pull request #16785 from dotnet-maestro-bot/master-UpdateDependencies
Davis Goodin [Tue, 6 Mar 2018 23:33:27 +0000 (17:33 -0600)]
Merge pull request #16785 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2-26306-04, respectively (master)

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2...
dotnet-maestro-bot [Tue, 6 Mar 2018 21:27:48 +0000 (13:27 -0800)]
Update BuildTools, CoreClr, CoreFx to preview2-02606-04, preview2-26306-01, preview2-26306-04, respectively

6 years agoDisable Perf Runs on Commit (#16781)
Michelle McDaniel [Tue, 6 Mar 2018 20:37:23 +0000 (12:37 -0800)]
Disable Perf Runs on Commit (#16781)

We need to disable these jobs on commit until dotnet/core-eng#2808 is fixed.

6 years agoFix hang on Ctrl+C when tiering is enabled (#16719)
Koundinya Veluri [Tue, 6 Mar 2018 19:42:13 +0000 (11:42 -0800)]
Fix hang on Ctrl+C when tiering is enabled (#16719)

Fix hang on Ctrl+C when tiering is enabled

- When the work thread count is nonzero at the time of Ctrl+C, by the time `TieredCompilationManager::Shutdown(BOOL)` runs (during `DllMain` for process detach), the background worker thread has already been torn down abruptly and it does not get a chance to exit gracefully and set the event, and Shutdown() hangs the process waiting for the event forever.
- It looks like there is no benefit to waiting for the work to complete, fixed by removing the wait and the event
- In the MusicStore benchmark it looks like the arch folder was missing in the 'publish' folder path. In case there is a difference in bin directory layout between the CI dotnet and current dotnet, changed to check for both paths.

6 years agoConvert Byte Arrays to Hexidecimal Strings When Writing to LTTng via EventSource...
Brian Robbins [Tue, 6 Mar 2018 19:31:40 +0000 (11:31 -0800)]
Convert Byte Arrays to Hexidecimal Strings When Writing to LTTng via EventSource (#16762)

6 years agoFix potential buffer overrun in ClearWithReferences
Levi Broderick [Tue, 6 Mar 2018 17:11:52 +0000 (09:11 -0800)]
Fix potential buffer overrun in ClearWithReferences

6 years agoMerge pull request #16700 from briansull/fix_dyn_blk
Brian Sullivan [Tue, 6 Mar 2018 18:29:37 +0000 (10:29 -0800)]
Merge pull request #16700 from briansull/fix_dyn_blk

Fix morph issue with a fixed size block copy

6 years agoAdd tracepointprovider.cpp directly to PAL instead of to a separate tracepointprovide...
Brian Robbins [Tue, 6 Mar 2018 10:51:22 +0000 (02:51 -0800)]
Add tracepointprovider.cpp directly to PAL instead of to a separate tracepointprovider library. (#16771)

6 years agoFix whitespace
Levi Broderick [Tue, 6 Mar 2018 02:18:23 +0000 (18:18 -0800)]
Fix whitespace

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
6 years agoFix whitespace
Levi Broderick [Tue, 6 Mar 2018 02:00:07 +0000 (18:00 -0800)]
Fix whitespace

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>