platform/upstream/coreclr.git
8 years agoMerge pull request #7075 from tarekgh/DisableZh-CHS-CHT
Tarek Mahmoud Sayed [Wed, 7 Sep 2016 15:25:01 +0000 (08:25 -0700)]
Merge pull request #7075 from tarekgh/DisableZh-CHS-CHT

Avoid creating zh-CHS/zh-CHT durng culture enumeration

8 years agoExclude smallFrame.sh test for ARM (#7080)
Hyung-Kyu Choi [Wed, 7 Sep 2016 13:50:44 +0000 (22:50 +0900)]
Exclude smallFrame.sh test for ARM (#7080)

JIT/Methodical/tailcall_v4/smallFrame/smallFrame.sh contains
"tail.call, pop, ret" pattern. The pattern is not allowed in ECMA and
is only supported on x64 for compatibility. (issue #7036)

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
8 years agoCorrect the virtual overload of Stream.CopyTo (#7082)
James Ko [Wed, 7 Sep 2016 13:01:33 +0000 (09:01 -0400)]
Correct the virtual overload of Stream.CopyTo (#7082)

8 years agoTask<T> Exceptions to ThrowHelper (#7076)
Ben Adams [Wed, 7 Sep 2016 05:49:53 +0000 (06:49 +0100)]
Task<T> Exceptions to ThrowHelper (#7076)

8 years agoAvoid creating zh-CHS/zh-CHT durng culture enumeration
Tarek Mahmoud Sayed [Wed, 7 Sep 2016 01:33:41 +0000 (18:33 -0700)]
Avoid creating zh-CHS/zh-CHT durng culture enumeration

zh-CHS and zh-CHT are old names that is not really supported in the standards.
when we enabled CultureInfo.GetCultures() there was some code that create cultures
for zh-CHS and zh-CHT. The fix here is disable that otherwise we'll have to enable
a good chunk of legacy code to support it while it never supported by coreclr and in
same time are not names used in standards

8 years agoMake Stream.CopyTo virtual (#7070)
James Ko [Wed, 7 Sep 2016 01:19:51 +0000 (21:19 -0400)]
Make Stream.CopyTo virtual (#7070)

8 years agoMerge pull request #7022 from lemmaa/prevent-build-output-contamination
Rama krishnan Raghupathy [Wed, 7 Sep 2016 00:20:54 +0000 (17:20 -0700)]
Merge pull request #7022 from lemmaa/prevent-build-output-contamination

[Script] Prevent build output contamination while building test overlay

8 years agoMerge pull request #7064 from JosephTremoulet/MakeCse
Joseph Tremoulet [Tue, 6 Sep 2016 19:54:32 +0000 (15:54 -0400)]
Merge pull request #7064 from JosephTremoulet/MakeCse

Fix GTF_ flag collision

8 years agoMerge pull request #6922 from gkhanna79/WinArm32
Gaurav Khanna [Tue, 6 Sep 2016 19:42:14 +0000 (12:42 -0700)]
Merge pull request #6922 from gkhanna79/WinArm32

Enable Arm32 Test Build

8 years agoArray<T> exceptions to ThrowHelper (#7059)
Ben Adams [Tue, 6 Sep 2016 18:14:42 +0000 (19:14 +0100)]
Array<T> exceptions to ThrowHelper (#7059)

8 years ago[Linux][LLDB][GDB/JIT] Add support for lldb 'breakpoint set' for jitted code (#6956)
Dmitri-Botcharnikov [Tue, 6 Sep 2016 17:27:13 +0000 (21:27 +0400)]
[Linux][LLDB][GDB/JIT] Add support for lldb 'breakpoint set' for jitted code (#6956)

* Add support for lldb 'breakpoint set' for jitted code

* Updated after review

* Enlarge buffer for line program

8 years agoMove genIncRegBy() to codegenclassic.h (#7063)
Hyung-Kyu Choi [Tue, 6 Sep 2016 17:13:31 +0000 (02:13 +0900)]
Move genIncRegBy() to codegenclassic.h (#7063)

We don't have to keep genIncRegBy() in codegen.h anymore,
since genIncRegBy() is defined in codegenlegacy.cpp and only used in LEGACY_BACKEND code.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
8 years ago[ARM] Remove ARM_HAZARD_AVOIDANCE (#7019)
Hanjoung Lee [Tue, 6 Sep 2016 16:42:03 +0000 (01:42 +0900)]
[ARM] Remove ARM_HAZARD_AVOIDANCE (#7019)

remove `ARM_HAZARD_AVOIDANCE` as it is a rare case.

For #7003

8 years agoEnable FEATURE_JIT_METHOD_PERF always (even when FEATURE_CORECLR is on). (#7028)
Peter Kukol [Tue, 6 Sep 2016 16:21:13 +0000 (10:21 -0600)]
Enable FEATURE_JIT_METHOD_PERF always (even when FEATURE_CORECLR is on). (#7028)

8 years agoFix GTF_ flag collision
Joseph Tremoulet [Fri, 2 Sep 2016 19:22:01 +0000 (15:22 -0400)]
Fix GTF_ flag collision

Define flag `GTF_IS_IN_CSE` (which is used only to communicate in a call to
`gtNodeHasSideEffects` that the caller wants to disregard the side-effect
of running a .cctor) as `GTF_BOOLEAN` rather than `GTF_MAKE_CSE` -- as the
comment at the definition of `GTF_IS_IN_CSE` indicates, the only
requirement on its value is that it not conflict with one of the
side-effect flags, but `gtNodeHasSideEffects` does in fact check for
`GTF_MAKE_CSE`, so the current value conflicts.

Also update the code in `gtNodeHasSideEffects` that is dictated by
`GTF_IS_IN_CSE` to check just for that bit, instead of checking that the
caller passed in exactly `GTF_PERSISTENT_SIDE_EFFECTS_IN_CSE` -- no need
to entangle conceptually independent parameters.

Fixes #7042.

8 years agoAdd proper support for custom installed llvm tool chain. (#7050)
Sung-Jae Lee [Tue, 6 Sep 2016 15:45:33 +0000 (00:45 +0900)]
Add proper support for custom installed llvm tool chain. (#7050)

* Add LLVM_HOME enviroment variable support

8 years agofix helpers' flag: ULDiv, ULMod can throw Div-by-zero exception (#7052)
Hyeongseok Oh [Tue, 6 Sep 2016 15:43:39 +0000 (00:43 +0900)]
fix helpers' flag: ULDiv, ULMod can throw Div-by-zero exception (#7052)

8 years agoArraySegment<T> exceptions to ThrowHelper (#7058)
Ben Adams [Tue, 6 Sep 2016 14:23:37 +0000 (15:23 +0100)]
ArraySegment<T> exceptions to ThrowHelper (#7058)

8 years agoExclude two more tests for ARM (#7062)
Hyung-Kyu Choi [Tue, 6 Sep 2016 14:21:11 +0000 (23:21 +0900)]
Exclude two more tests for ARM (#7062)

According to issue #6217, following three tests fails
, because FEATURE_FASTTAILCALL is not supported in ARM.

  JIT/Directed/tailcall/tailcall/tailcall.sh
  JIT/Methodical/tailcall_v4/hijacking/hijacking.sh
  JIT/Regression/JitBlue/devdiv_902271/DevDiv_902271/DevDiv_902271.sh

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
8 years agoPrevent build output contamination while building test overlay
Sung-Jae Lee [Thu, 1 Sep 2016 08:06:30 +0000 (17:06 +0900)]
Prevent build output contamination while building test overlay

While building test overlay, all files in `$mscorlibDir/bin` are
copyed to `$mscorlibDir` where usually `$coreclrBinDir`.
It contaminates build output. This commit prevent it by moving
copy commend to function `create_core_overlay`.

8 years agoAllow mapping LCID and culture names mapping for neutral culture (#7049)
Tarek Mahmoud Sayed [Mon, 5 Sep 2016 19:13:23 +0000 (12:13 -0700)]
Allow mapping LCID and culture names mapping for neutral culture (#7049)

This change is to pass the flag LOCALE_ALLOW_NEUTRAL_NAMES to the OS API to allow mapping
LCID to/from culture names.

8 years agoImprove ThrowHelper (#7048)
Ben Adams [Mon, 5 Sep 2016 03:34:28 +0000 (04:34 +0100)]
Improve ThrowHelper (#7048)

8 years agoMerge pull request #7027 from CarolEidt/1stClassStructBlkOps
Carol Eidt [Sun, 4 Sep 2016 23:42:04 +0000 (16:42 -0700)]
Merge pull request #7027 from CarolEidt/1stClassStructBlkOps

1st Class Struct Block Assignments

8 years agoMerge pull request #7015 from ramarag/fixup_precode
Rama krishnan Raghupathy [Sat, 3 Sep 2016 04:56:43 +0000 (21:56 -0700)]
Merge pull request #7015 from ramarag/fixup_precode

Implement FixupPrecode for Arm64

8 years agoImplement FixupPrecode for Arm64
Rama Krishnan Raghupathy [Wed, 31 Aug 2016 23:55:28 +0000 (16:55 -0700)]
Implement FixupPrecode for Arm64

8 years agoMore PR comments
Carol Eidt [Fri, 2 Sep 2016 23:28:31 +0000 (16:28 -0700)]
More PR comments

8 years agoReduce item format allocations in AppendFormat (#4702)
Bruce Bowyer-Smyth [Fri, 2 Sep 2016 22:48:57 +0000 (08:48 +1000)]
Reduce item format allocations in AppendFormat (#4702)

8 years agoMerge pull request #6976 from kvochko/prof_elt_callbacks
Rahul Kumar [Fri, 2 Sep 2016 21:00:58 +0000 (14:00 -0700)]
Merge pull request #6976 from kvochko/prof_elt_callbacks

Enable FunctionEnter/FunctionLeave callbacks on ARM

8 years agoMerge pull request #7041 from mmitche/add-help-job
Matt Mitchell [Fri, 2 Sep 2016 18:29:56 +0000 (11:29 -0700)]
Merge pull request #7041 from mmitche/add-help-job

Add help job

8 years agoAdd help job
Matt Mitchell [Fri, 2 Sep 2016 18:11:18 +0000 (11:11 -0700)]
Add help job

8 years agoRestore the change to gtNewBlkOpNode
Carol Eidt [Fri, 2 Sep 2016 14:53:11 +0000 (07:53 -0700)]
Restore the change to gtNewBlkOpNode

8 years agoLTO build: fix perf regression from strict alias violation and incorrect inline assem...
kchoi [Fri, 2 Sep 2016 11:00:41 +0000 (04:00 -0700)]
LTO build: fix perf regression from strict alias violation and incorrect inline assembly (#7018)

Fix inline assembly implementation of getextcpuid() and strict aliasing violations in its callers

The implementation writes to the unsigned char result array, so
the clobber "memory" is needed.

As well its callers have strict aliasing violations from reading the
result array as a DWORD array. The fix is to memcpy the resulting
buffer onto the DWORD array.

8 years agoEnabled FunctionEnter/FunctionLeave hooks on ARM (#6939)
Andrey Kvochko [Fri, 26 Aug 2016 16:57:51 +0000 (19:57 +0300)]
Enabled FunctionEnter/FunctionLeave hooks on ARM (#6939)

8 years agoMore PR Feedback
Carol Eidt [Fri, 2 Sep 2016 04:27:46 +0000 (21:27 -0700)]
More PR Feedback

8 years agoImprove StringBuilder ctor(), ctor(int), and ToString() performance. Consistent chang...
Bruce Bowyer-Smyth [Fri, 2 Sep 2016 01:25:53 +0000 (11:25 +1000)]
Improve StringBuilder ctor(), ctor(int), and ToString() performance. Consistent changes in other functions. (#7029)

8 years agoMerge pull request #7032 from mmitche/make-triggers-non-default
Matt Mitchell [Thu, 1 Sep 2016 23:11:09 +0000 (16:11 -0700)]
Merge pull request #7032 from mmitche/make-triggers-non-default

Changing new perf.groovy triggers to be non-default

8 years agoChanging new perf.groovy triggers to be non-default
Matt Mitchell [Thu, 1 Sep 2016 23:10:04 +0000 (16:10 -0700)]
Changing new perf.groovy triggers to be non-default

8 years agoAddress PR Feedback
Carol Eidt [Thu, 1 Sep 2016 22:48:01 +0000 (15:48 -0700)]
Address PR Feedback

8 years agoImprove ToUpper/ToLower perf (#7026)
Jan Kotas [Thu, 1 Sep 2016 21:26:48 +0000 (14:26 -0700)]
Improve ToUpper/ToLower perf (#7026)

8 years agoMake Lazy initialization of TextInfo::m_IsAsciiCasingSameAsInvariant thread safe...
Jose Manuel Heredia Hidalgo [Thu, 1 Sep 2016 21:24:22 +0000 (14:24 -0700)]
Make Lazy initialization of TextInfo::m_IsAsciiCasingSameAsInvariant thread safe (#7021)

Replace bool? with Tristate enum to make it thread safe. Also use Tristate instead of TurkishCasing enum

8 years agoMerge pull request #6978 from adiaaida/fixFormat
Michelle McDaniel [Thu, 1 Sep 2016 20:20:56 +0000 (13:20 -0700)]
Merge pull request #6978 from adiaaida/fixFormat

Fix format.py

8 years agoFix format.py
Michelle McDaniel [Tue, 30 Aug 2016 16:52:13 +0000 (09:52 -0700)]
Fix format.py

In format.py, we were downloading bootstrap.sh/cmd to the current working
directory, but assuming that it was in coreclr/bootstrap, which is
incorrect. This change downloads it directly to coreclr/bootstrap, so that
we download and run to the same location.

This change also modifies where we install the newer version of dotnetcli
needed for jitutils to the coreclr/dotnetcli-jitutils directory. This
change is necessary because build.cmd->run.cmd->init-tools.cmd removes the
Tools directory, including our dotnetcli directory, so we don't want our
version of the cli to be trashed.

We also clean up our work at the end of the script by removing the
created jitutils and dotnetcli directories, and the bootstrap script.

Finally, this change adds some comments to tell the user what it's doing.

8 years ago1st Class Struct Block Assignments
Carol Eidt [Thu, 21 Jul 2016 06:07:32 +0000 (23:07 -0700)]
1st Class Struct Block Assignments

Change block ops to assignments, with block nodes (GT_BLK, GT_OBJ and GT_DYN_BLK) as the lhs, and with GT_STORE_* in the backend.
For this initial change, existing behavior is preserved as much as possible, with a few differences in lea generation for SIMD types.
This causes pessimization in some areas; those, as well as the additional opportunities that can be enabled after this change, have all been marked TODO-1stClassStructs.

8 years agoGlobalization update from CoreRT - part 2 (#7020)
Jan Kotas [Thu, 1 Sep 2016 17:57:04 +0000 (10:57 -0700)]
Globalization update from CoreRT - part 2 (#7020)

- Persian calendar date formatting
- Fix IsPrefix handling of empty strings
- Formatting changes

8 years agoMerge pull request #7025 from dotnet/revert-6994-replace_which_with_hash
Jan Kotas [Thu, 1 Sep 2016 17:56:37 +0000 (10:56 -0700)]
Merge pull request #7025 from dotnet/revert-6994-replace_which_with_hash

Revert "Avoid using 'which' for verifying prereqs"

8 years agoRevert "Avoid using 'which' for verifying prereqs"
Jan Kotas [Thu, 1 Sep 2016 16:15:22 +0000 (09:15 -0700)]
Revert "Avoid using 'which' for verifying prereqs"

8 years agoMerge pull request #7024 from pgavlin/RunTestFix
Pat Gavlin [Thu, 1 Sep 2016 16:11:26 +0000 (09:11 -0700)]
Merge pull request #7024 from pgavlin/RunTestFix

Pass /p:Platform to msbuild in runtest.cmd.

8 years agoMerge pull request #7014 from pgavlin/TestBuildSpeedup
Pat Gavlin [Thu, 1 Sep 2016 14:22:29 +0000 (07:22 -0700)]
Merge pull request #7014 from pgavlin/TestBuildSpeedup

Stop groveling for project.json files when building every test.

8 years agoPass /p:Platform to msbuild in runtest.cmd.
Pat Gavlin [Thu, 1 Sep 2016 13:09:54 +0000 (06:09 -0700)]
Pass /p:Platform to msbuild in runtest.cmd.

Otherwise, the tests will use the ambient setting of the Platform
variable, which might not match the architecture specified on the
command line. This results in the wrong build of the tests running
against the correct runtime, which e.g. causes failures in tests
with native components.

8 years agoMerge pull request #7013 from swaroop-sridhar/PtrStruct
Swaroop Sridhar [Thu, 1 Sep 2016 04:15:56 +0000 (21:15 -0700)]
Merge pull request #7013 from swaroop-sridhar/PtrStruct

GcInfo: Report Struct containing one GcPointer correctly

8 years agoGcInfo: Report Struct containing one GcPointer correctly
Swaroop Sridhar [Wed, 31 Aug 2016 23:04:30 +0000 (16:04 -0700)]
GcInfo: Report Struct containing one GcPointer correctly

This change fixes a bug in the the GcInfo header,
where the ReturnKind is reported incorrectly for certain structs.

Structs that contain only one GCPointer or ByRef, can be returned
in a single register (Windows/Unix/OSX). The ReturnKind for these
struct-returns should be RT_Object/RT_ByRef, but they are currently
incorrectly reported as RT_Scalar. This change fixes the problem.

Fixes: dotnet/corefx#11260

8 years agoMerge pull request #6807 from lemmaa/add-options-for-arm-target-test
Aditya Mandaleeka [Thu, 1 Sep 2016 01:24:08 +0000 (18:24 -0700)]
Merge pull request #6807 from lemmaa/add-options-for-arm-target-test

[Linux/ARM/Script] Add some features help for arm target test

8 years agoUpdate Unix System.Globalization implementation from CoreRT (#7004)
Jan Kotas [Thu, 1 Sep 2016 00:21:40 +0000 (17:21 -0700)]
Update Unix System.Globalization implementation from CoreRT (#7004)

8 years agoStop groveling for project.json files when building every test.
Pat Gavlin [Wed, 31 Aug 2016 23:51:58 +0000 (16:51 -0700)]
Stop groveling for project.json files when building every test.

This information is only needed by build.proj. Do not compute it in dir.props,
which is included by every test project.

8 years agoMerge pull request #7010 from dotnet-bot/from-tfs
Jan Kotas [Wed, 31 Aug 2016 22:24:46 +0000 (15:24 -0700)]
Merge pull request #7010 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoMerge pull request #6772 from mellinoe/fix-build-packages
Eric Mellino [Wed, 31 Aug 2016 21:47:07 +0000 (14:47 -0700)]
Merge pull request #6772 from mellinoe/fix-build-packages

Specify packages.builds by default in build-packages command

8 years agoMerge pull request #6552 from pgavlin/RemovePreRationalizeLiveness
Pat Gavlin [Wed, 31 Aug 2016 21:23:32 +0000 (14:23 -0700)]
Merge pull request #6552 from pgavlin/RemovePreRationalizeLiveness

Do not run local var liveness before rationalize.

8 years agoMerge pull request #5884 from mikedn/x86-addsub-long
Pat Gavlin [Wed, 31 Aug 2016 21:04:15 +0000 (14:04 -0700)]
Merge pull request #5884 from mikedn/x86-addsub-long

Fix add/sub decomposition

8 years agoMerge pull request #7009 from BruceForstall/PrintErrorForFuncInfoFailure
Bruce Forstall [Wed, 31 Aug 2016 19:59:14 +0000 (12:59 -0700)]
Merge pull request #7009 from BruceForstall/PrintErrorForFuncInfoFailure

Print an error, in DEBUG, if we fail to open the JitFuncInfoLogFile

8 years agoMerge pull request #6943 from mellinoe/fedora-24
Eric Mellino [Wed, 31 Aug 2016 19:36:37 +0000 (12:36 -0700)]
Merge pull request #6943 from mellinoe/fedora-24

Add fedora24 native packages

8 years agoFix funceval of a function returning 16 byte value type. (#6997)
Mike McLaughlin [Wed, 31 Aug 2016 19:27:12 +0000 (12:27 -0700)]
Fix funceval of a function returning 16 byte value type. (#6997)

On Linux and OS X, structs less or equal to 16 bytes (instead of 8 bytes
on Windows) are enregistered. Only 8 bytes is being passed back to
debugger during a funceval of a property or method that returns a 16
byte value type.

To fix this, the 16 byte return value (which is only used for enregistered
structures of that size on xplat) needed to be plumbed from CallTargetWorker
through the MethodDescCallSite macros to the func eval code.

The func eval code needed to also deal with 16 byte results.

NUMBER_RETURNVALUE_SLOTS is the number of ARG_SLOTs that will contain the
maximum enregistered return value.

CordbEval:m_result is now ARG_SLOT[NUMBER_RETURNVALUE_SLOTS].

CallTargetWorker is now passed a pointer and the count of bytes to/of the
return value buffer.

Minor fix to SOS SymbolReader function.

8 years agoAvoid using 'which' for verifying prereqs (#6994)
Aditya Mandaleeka [Wed, 31 Aug 2016 19:01:28 +0000 (12:01 -0700)]
Avoid using 'which' for verifying prereqs (#6994)

* Use hash instead of which in build.sh

* Use hash instead of which in init-tools.sh.

* Use hash instead of which in gen-buildsys-clang.sh.

8 years agoFix #6893. (#6932)
Pat Gavlin [Wed, 31 Aug 2016 17:56:11 +0000 (10:56 -0700)]
Fix #6893. (#6932)

Aggregate arguments to calls (i.e. arguments that are made up
of multiple, independent values such as those to be passed in
multiple registers) are represented by GT_LIST nodes that are
not distiguishable from normal GT_LIST nodes without the extra
context of the call. GT_LIST nodes, however, are disallowed in
LIR ranges. The intersection of these two design choices causes
problems for code that operates on LIR but wants to observe
aggregate arguments as a whole (rather than piecewise). In the
case of #6893, this caused lowering to attempt to insert a
PUTARG_STK node after the GT_LIST node that represented the
aggregate argument that was being forced to the stack, which
caused an assertion in the LIR utilities to fail (the GT_LIST
node was passed as the insertion point to `LIR::Range::InsertAfter`,
which requires that the insertion point be a part of the given
range).

Conceptually, the fix is simple: the nodes that represent
aggregate arguments must be allowed to be part of LIR ranges.
The implementation, however, is complicated somewhat by the
need to distinguish the nodes used for aggregate arguments from
normal GT_LIST nodes. These changes implement a short-term
fix that distiguished these nodes by adding a node-specific flag,
`GTF_LIST_AGGREGATE`, to indicate that a GT_LIST node is in fact
an aggregate argument. In the long term, a more palatable
implementation would be the introduction of a new node and operator
type to represent aggregate arguments, but this is likely to
require broader changes to the compiler.

8 years agoMerge pull request #6989 from adiaaida/updateCodingConventions
Michelle McDaniel [Wed, 31 Aug 2016 17:45:08 +0000 (10:45 -0700)]
Merge pull request #6989 from adiaaida/updateCodingConventions

Update coding conventions

8 years agoFix the build break
Tarek Mahmoud Sayed [Wed, 31 Aug 2016 17:21:08 +0000 (10:21 -0700)]
Fix the build break

[tfs-changeset: 1625162]

8 years agoDo not run local var liveness before rationalize.
Pat Gavlin [Sun, 31 Jul 2016 17:02:51 +0000 (10:02 -0700)]
Do not run local var liveness before rationalize.

Neither rationalize nor lowering depend on liveness being run. The assertion mentioned
in the comment was caused by `fgExtendDbgLifetimes` inserting HIR nodes (GT_ASG nodes,
specifically) into LIR blocks.

8 years agoPrint an error, in DEBUG, if we fail to open the JitFuncInfoLogFile
Bruce Forstall [Wed, 31 Aug 2016 16:38:54 +0000 (09:38 -0700)]
Print an error, in DEBUG, if we fail to open the JitFuncInfoLogFile

8 years agoMerge pull request #7001 from BruceForstall/CleanUpX86LegacyIssuesFile
Bruce Forstall [Wed, 31 Aug 2016 16:50:00 +0000 (09:50 -0700)]
Merge pull request #7001 from BruceForstall/CleanUpX86LegacyIssuesFile

Clean up test issues files

8 years agoClean up test issues files
Bruce Forstall [Wed, 31 Aug 2016 05:18:14 +0000 (22:18 -0700)]
Clean up test issues files

Re-enable some tests that pass. Rearrange x86_legacy_backend_issues.targets
to more closely resemble issues.targets so it is easier to see the
difference.

8 years agoUpdate coding conventions
Michelle McDaniel [Tue, 30 Aug 2016 20:41:27 +0000 (13:41 -0700)]
Update coding conventions

Add a note to the jit coding conventions that jit-format changes supersede
the conventions in the doc. Add a link to jit-format's documentation.

8 years agoMerge pull request #6988 from adiaaida/shiftLong
Michelle McDaniel [Wed, 31 Aug 2016 13:38:54 +0000 (06:38 -0700)]
Merge pull request #6988 from adiaaida/shiftLong

Implement DecomposeShift

8 years agoMerge pull request #6917 from svick/fixing-alltestprojects
Rama krishnan Raghupathy [Wed, 31 Aug 2016 05:18:57 +0000 (22:18 -0700)]
Merge pull request #6917 from svick/fixing-alltestprojects

Fixed AllTestProjects.sln

8 years agoAdd some features help for arm target test
Sung-Jae Lee [Fri, 19 Aug 2016 08:05:07 +0000 (17:05 +0900)]
Add some features help for arm target test

* Add `--build-overlay-only` option to help building test package for arm target.
  You can use this option on host after cross building, to make a
  test package that will run on target device.
* Make `setup-runtime-dependencies.sh` called on `x64` architecture only.
  Because dependent packages are not supported on other architectures now.
* Add `testsUnsupportedOnARM32.txt` file for list up test exclusions.
* minor style fix.

8 years agoUpdate CoreClr, CoreFx, External to beta-24431-01, beta-24431-01, beta-24430-00,...
Jan Kotas [Wed, 31 Aug 2016 04:54:44 +0000 (21:54 -0700)]
Update CoreClr, CoreFx, External to beta-24431-01, beta-24431-01, beta-24430-00, respectively (#6879)

8 years agoRemove obsolete add/sub NYI
Mike Danes [Wed, 13 Jul 2016 19:05:22 +0000 (22:05 +0300)]
Remove obsolete add/sub NYI

8 years agoFix the srcCount for an unused GT_LONG. (#6996)
Pat Gavlin [Wed, 31 Aug 2016 03:51:33 +0000 (20:51 -0700)]
Fix the srcCount for an unused GT_LONG. (#6996)

GT_LONG nodes that do not have a corresponding use need to
consume their operands. There was already code in lowerxarch
that attempted to do so, but this code was no longer valid in
LIR.

8 years agoRemove System.Reflection.AssemblyNameProxy and fix System.Reflection.Pointer construc...
Wes Haggard [Wed, 31 Aug 2016 03:15:23 +0000 (20:15 -0700)]
Remove System.Reflection.AssemblyNameProxy and fix System.Reflection.Pointer constructor (#6987)

8 years agoUpdate CoreClr, CoreFx, External to beta-24431-01, beta-24431-01, beta-24430-00,...
dotnet-bot [Wed, 31 Aug 2016 02:30:14 +0000 (02:30 +0000)]
Update CoreClr, CoreFx, External to beta-24431-01, beta-24431-01, beta-24430-00, respectively

8 years agoImplement DecomposeShift
Michelle McDaniel [Tue, 30 Aug 2016 16:38:20 +0000 (09:38 -0700)]
Implement DecomposeShift

This change adds support for GT_LSH, GT_RSH, and GT_RSZ for x86 longs.
These nodes are implemented via helpers, so in decompose, we must remove
the shift node from the tree and replace it with a call to the helper.
Additionally, these helpers require that the long operand is in EAX:EDX,
so rather than adding a GT_LONG to the call arg list like we would
normally, we split the high and low parts of the arg and mark them as
non-standard args in gtMorphArgs to force the low part to be in EAX and
the high part to be in EDX. The shift amount is already defaulted to ECX,
which is where the helper expects it to be.

8 years agoRemove System.Reflection.AssemblyNameProxy and fix System.Reflection.Pointer constructor
sepidehMS [Wed, 31 Aug 2016 01:28:19 +0000 (18:28 -0700)]
Remove System.Reflection.AssemblyNameProxy and fix System.Reflection.Pointer constructor

8 years agoMerge pull request #6993 from tarekgh/AddMissingSystemTextAPIs
Tarek Mahmoud Sayed [Wed, 31 Aug 2016 01:17:09 +0000 (18:17 -0700)]
Merge pull request #6993 from tarekgh/AddMissingSystemTextAPIs

Expose missing Global/Encoding APIs in coreclr and remove empty stubs

8 years agoMerge pull request #6983 from BruceForstall/ReformatIssuesFiles
Bruce Forstall [Wed, 31 Aug 2016 00:28:50 +0000 (17:28 -0700)]
Merge pull request #6983 from BruceForstall/ReformatIssuesFiles

Reformat test issues files so they are more easily comparable

8 years agoFix the srcCount for an unused GT_LONG.
Pat Gavlin [Tue, 30 Aug 2016 23:53:40 +0000 (16:53 -0700)]
Fix the srcCount for an unused GT_LONG.

GT_LONG nodes that do not have a corresponding use need to
consume their operands. There was already code in lowerxarch
that attempted to do so, but this code was no longer valid in
LIR.

8 years agoPort String reorganization from CoreRT (#6985)
James Ko [Tue, 30 Aug 2016 22:53:10 +0000 (18:53 -0400)]
Port String reorganization from CoreRT (#6985)

8 years agoGC update from CoreRT (#6984)
Jan Kotas [Tue, 30 Aug 2016 22:47:34 +0000 (15:47 -0700)]
GC update from CoreRT (#6984)

https://github.com/dotnet/corert/tree/master/src/Native/gc 97dd6d2cbb50901cc3651f41a53a4ff9a1052391

8 years agoSkipped letter in a word (#6991)
Evgeniy Devyatkin [Tue, 30 Aug 2016 22:47:21 +0000 (02:47 +0400)]
Skipped letter in a word (#6991)

8 years agoExpose missing Global/Encoding APIs in coreclr and remove empty stubs
Tarek Mahmoud Sayed [Tue, 30 Aug 2016 22:46:50 +0000 (15:46 -0700)]
Expose missing Global/Encoding APIs in coreclr and remove empty stubs

This change is to expose all missing globalization and Encoding APIs in corelib
to have the complete exposed list for such namespaces.
Also we are removing the empty methods stubs for Windows implementation
And have the actual implementation in-place

8 years agoMerge pull request #6992 from dotnet/suse421-buildbadge
Eric Mellino [Tue, 30 Aug 2016 22:24:35 +0000 (15:24 -0700)]
Merge pull request #6992 from dotnet/suse421-buildbadge

Add openSUSE 42.1 build badge to README.md

8 years agoAdd openSUSE 42.1 build badge to README.md
Eric Mellino [Tue, 30 Aug 2016 22:23:03 +0000 (15:23 -0700)]
Add openSUSE 42.1 build badge to README.md

8 years agoMerge pull request #6990 from smile21prc/coreclr-perf
smile21prc [Tue, 30 Aug 2016 21:28:38 +0000 (14:28 -0700)]
Merge pull request #6990 from smile21prc/coreclr-perf

Create coreclr perf jobs for Linux.

8 years agoCreate coreclr perf jobs for Linux.
Smile Wei [Tue, 30 Aug 2016 19:31:25 +0000 (12:31 -0700)]
Create coreclr perf jobs for Linux.

8 years agoMerge pull request #6986 from dotnet-bot/from-tfs
Jan Kotas [Tue, 30 Aug 2016 21:18:05 +0000 (14:18 -0700)]
Merge pull request #6986 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoReformat test issues files so they are more easily comparable
Bruce Forstall [Tue, 30 Aug 2016 16:16:22 +0000 (09:16 -0700)]
Reformat test issues files so they are more easily comparable

This change reformats the issues files, and sorts the excluded tests
by name, so it is possible to easily compare the baseline issues.targets
file against the x86_jit32_issues.targets and x86_legacy_backend_issues.targets
files.

8 years agoDelete non-existing method
Jan Kotas [Tue, 30 Aug 2016 18:21:59 +0000 (11:21 -0700)]
Delete non-existing method

[tfs-changeset: 1624957]

8 years agoMerge pull request #6973 from BruceForstall/MoveTailcallTestExclusion
Bruce Forstall [Tue, 30 Aug 2016 18:17:41 +0000 (11:17 -0700)]
Merge pull request #6973 from BruceForstall/MoveTailcallTestExclusion

Move TailcallVerifyWithPrefix test to "baseline x86" exclusion section

8 years agoMerge pull request #6867 from rahku/returnHijack
Rahul Kumar [Tue, 30 Aug 2016 18:11:43 +0000 (11:11 -0700)]
Merge pull request #6867 from rahku/returnHijack

Enable return address hijacking for arm64

8 years agoMerge pull request #6980 from smile21prc/coreclr-perf
smile21prc [Tue, 30 Aug 2016 17:59:12 +0000 (10:59 -0700)]
Merge pull request #6980 from smile21prc/coreclr-perf

More fixes.

8 years agoMore fixes.
Smile Wei [Tue, 30 Aug 2016 17:58:34 +0000 (10:58 -0700)]
More fixes.

8 years agoMerge pull request #6979 from smile21prc/coreclr-perf
smile21prc [Tue, 30 Aug 2016 17:58:02 +0000 (10:58 -0700)]
Merge pull request #6979 from smile21prc/coreclr-perf

Fixed wrong env vars.

8 years agoFixed wrong env vars.
Smile Wei [Tue, 30 Aug 2016 17:57:13 +0000 (10:57 -0700)]
Fixed wrong env vars.