platform/upstream/libgc.git
5 years agoFix 'duplicate symbol' error for tests using multiple static libs (OS X)
Ivan Maidanski [Tue, 26 Feb 2019 21:48:12 +0000 (00:48 +0300)]
Fix 'duplicate symbol' error for tests using multiple static libs (OS X)

Issue #263 (bdwgc).

If configured with --enable-static, libtool passes libgc.a to gcc
twice (with a relative path and with an absolute one) when linking
tests that depend on libcord.a, libgccpp.a or libstaticrootslib_test.a
which, in turn, depends on libgc.a.  Double specification of libgc.a
seems to confuse ld tool of MacOS 10.14.

The workaround is to omit libgc.la in *_LDADD specification of the
mentioned tests when the shared libraries are not requested, at least.

* configure.ac (ENABLE_SHARED): New AM_CONDITIONAL.
* cord/cord.am (cordtest_LDADD): Do not add libgc.la unless
ENABLE_SHARED; add comment.
* tests/tests.am (staticrootstest_LDADD): Likewise.
* tests/tests.am [CPLUSPLUS && !AVOID_CPP_LIB] (test_cpp_LDADD):
Likewise.

5 years ago.gitignore: Ignore /out folder
Ivan Maidanski [Tue, 26 Feb 2019 20:11:29 +0000 (23:11 +0300)]
.gitignore: Ignore /out folder

5 years agoFix assertion violation about the number of freed objects in test_cpp
Ivan Maidanski [Mon, 25 Feb 2019 21:51:45 +0000 (00:51 +0300)]
Fix assertion violation about the number of freed objects in test_cpp
(fix of commit 6e0590ef1)

Issue Unity-Technologies#37 (bdwgc).

* tests/test_cpp.cc (C::Test): Call GC_gcollect() if incremental mode
and nFreed is too low.

5 years agoAvoid a full GC when growing finalizer tables if in incremental mode
Jonas Echterhoff [Thu, 21 Feb 2019 10:49:16 +0000 (11:49 +0100)]
Avoid a full GC when growing finalizer tables if in incremental mode

Issue Unity-Technologies#37 (bdwgc).

* finalize.c (GC_grow_table): Do not call GC_try_to_collect_inner
if GC_incremental; add comment.

5 years agoUpdate ChangeLog file
Ivan Maidanski [Sun, 17 Feb 2019 18:41:02 +0000 (21:41 +0300)]
Update ChangeLog file

5 years agoUpdate ChangeLog file (v8.0 changes)
Ivan Maidanski [Sun, 17 Feb 2019 17:09:02 +0000 (20:09 +0300)]
Update ChangeLog file (v8.0 changes)
(a cherry-pick of commit 011e159e from 'release-8_0')

5 years agoUpdate ChangeLog file (v7.6 changes)
Ivan Maidanski [Sun, 17 Feb 2019 16:53:15 +0000 (19:53 +0300)]
Update ChangeLog file (v7.6 changes)
(a cherry-pick of commit 1d3beb1c from 'release-7_6')

5 years agoUpdate ChangeLog file (v7.2 - v7.4 changes only)
Ivan Maidanski [Sat, 16 Feb 2019 22:49:24 +0000 (01:49 +0300)]
Update ChangeLog file (v7.2 - v7.4 changes only)
(a cherry-pick of commit dd4558f0 from 'release-7_4')

5 years agoAvoid unexpected heap growth in gctest caused by GC_disable
Ivan Maidanski [Fri, 15 Feb 2019 20:40:49 +0000 (23:40 +0300)]
Avoid unexpected heap growth in gctest caused by GC_disable
(fix of commit 8fc1ebf6d)

Issue #264 (bdwgc).

This commit eliminates the scenario when one thread disables garbage
collections while other threads intensively allocate memory objects.

* tests/test.c (run_one_test): Do not call GC_disable and GC_enable.
* tests/test.c (run_single_threaded_test): New function (which tests
GC_disable and GC_enable).
* tests/test.c (main): Call run_single_threaded_test() (before
check_heap_stats).

5 years agoAppVeyor CI: Fix 'no source or binary dir provided' cmake error
Ivan Maidanski [Fri, 15 Feb 2019 20:22:58 +0000 (23:22 +0300)]
AppVeyor CI: Fix 'no source or binary dir provided' cmake error

The error is fixed by passing "." argument to cmake.

5 years agoWorkaround 'uninitialized variable: info' cppcheck false positive (OS X)
Ivan Maidanski [Thu, 14 Feb 2019 20:17:36 +0000 (23:17 +0300)]
Workaround 'uninitialized variable: info' cppcheck false positive (OS X)

* darwin_stop_world.c [DEBUG_THREADS && CPPCHECK] (GC_thread_resume):
Initialize info.run_state value (to 0) before thread_info() call.

5 years agoFix thread_info() count argument value (OS X)
Ivan Maidanski [Thu, 14 Feb 2019 19:55:20 +0000 (22:55 +0300)]
Fix thread_info() count argument value (OS X)

* darwin_stop_world.c [DEBUG_THREADS || GC_ASSERTIONS]
(GC_thread_resume): Set outCount to THREAD_BASIC_INFO_COUNT (instead
of THREAD_INFO_MAX) to match the size of info passed to thread_info().

5 years agoFix 'wrong __data_start/_end pair' error on Android
Ivan Maidanski [Wed, 13 Feb 2019 22:06:26 +0000 (01:06 +0300)]
Fix 'wrong __data_start/_end pair' error on Android
(fix of commits b746e637b5e73ff184a25965b5f)

Issue #259 (bdwgc).

* include/gc.h [(HOST_ANDROID || __ANDROID__)
&& IGNORE_DYNAMIC_LOADING] (_etext, __data_start, __end__, _end): Do
not declare weak symbols.
* os_dep.c [SEARCH_FOR_DATA_START && (LINUX || HURD) && HOST_ANDROID]
(etext, __dso_handle): Likewise.
* include/gc.h [(HOST_ANDROID || __ANDROID__)
&& IGNORE_DYNAMIC_LOADING] (GC_find_limit): Declare function as public.
* include/gc.h [(HOST_ANDROID || __ANDROID__)
&& IGNORE_DYNAMIC_LOADING] (GC_INIT_CONF_ROOTS): Update comment;
do not use _etext, __data_start, __end__, _end symbols; use
GC_find_limit(__dso_handle,1) as the end of the added GC data root.
* include/private/gc_priv.h [SEARCH_FOR_DATA_START
|| NETBSD && __ELF__] (GC_find_limit): Change ptr_t type to void*,
GC_bool to int.
* include/private/gcconfig.h [(SPARC || ALPHA) && FREEBSD]
(GC_find_limit): Likewise.
* os_dep.c [NEED_FIND_LIMIT || USE_PROC_FOR_LIBRARIES] (GC_find_limit):
Likewise.
* include/private/gcconfig.h [(SPARC || ALPHA) && FREEBSD]
(DATAEND): Cast the result to ptr_t.
* include/private/gcconfig.h [AARCH64 && LINUX && HOST_ANDROID]
(SEARCH_FOR_DATA_START): Remove outdated comment about __data_start.
* os_dep.c [SEARCH_FOR_DATA_START && (LINUX || HURD)
&& !IGNORE_PROG_DATA_START && HOST_ANDROID && !CPPCHECK]
(GC_init_linux_data_start): Do not compare __dso_handle to _etext and
do not use __dso_handle as data start.
* os_dep.c [SEARCH_FOR_DATA_START] (GC_init_linux_data_start): Cast the
result of GC_find_limit() to ptr_t.
* os_dep.c [NETBSD && __ELF__] (GC_init_netbsd_elf): Likewise.
* os_dep.c [LINUX_STACKBOTTOM && IA64] (GC_get_register_stack_base):
Likewise.
* os_dep.c [!AMIGA && !HAIKU && !OS2 && !MSWIN32 && !MSWINCE
&& !CYGWIN32 && !GC_OPENBSD_THREADS && (!GC_SOLARIS_THREADS
|| _STRICT_STDC)] (GC_get_main_stack_base): Likewise.
* os_dep.c [DATASTART_USES_BSDGETDATASTART] (GC_FreeBSDGetDataStart):
Likewise.

5 years agoAdjust printf calls in gctest check_heap_stats so that each has new-line
Ivan Maidanski [Wed, 13 Feb 2019 14:41:51 +0000 (17:41 +0300)]
Adjust printf calls in gctest check_heap_stats so that each has new-line

This is useful if GC_printf uses Android logging.

* tests/test.c (finalizable_count): Do not define if
GC_NO_FINALIZATION.
* tests/test.c (mktree): Do not increment finalizable_count if
GC_NO_FINALIZATION.
* tests/test.c (check_heap_stats): Do not print finalization counts
if GC_NO_FINALIZATION or GC_get_find_leak() is true; call GC_printf
to output finalization counts and the check result just once (i.e.
the whole line is printed in a single GC_printf call).
* tests/test.c [!NO_CLOCK] (check_heap_stats): Call GC_printf just
once to output "Completed <N> collections" together with the total
GC time value and the number of marker threads (i.e. the whole line
is printed in a single GC_printf call).

5 years agoUpdate AUTHORS file
Ivan Maidanski [Tue, 12 Feb 2019 20:28:33 +0000 (23:28 +0300)]
Update AUTHORS file

5 years agoUse atomic primitives for Sony PlayStation Portable 2
Michael Herring [Mon, 28 Jan 2019 03:44:20 +0000 (12:44 +0900)]
Use atomic primitives for Sony PlayStation Portable 2
(a cherry-pick of commit e08e069bc from Unity-Technologies/bdwgc)

Issue #173 (bdwgc).

* include/private/gc_priv.h [THREADS]: Include gc_atomic_ops.h also
if SN_TARGET_PSP2.

5 years agoFix GetThreadContext stale register values use if WoW64 (Win32)
Hamayama [Thu, 7 Feb 2019 21:51:25 +0000 (00:51 +0300)]
Fix GetThreadContext stale register values use if WoW64 (Win32)

Issue #262 (bdwgc).

* misc.c [MSWIN32 && !MSWINRT_FLAVOR && !MSWIN_XBOX1]
(GC_win32_MessageBoxA): Do not define unless SMALL_CONFIG.
* misc.c [MSWIN32 && !_WIN64 && GC_WIN32_THREADS && CHECK_NOT_WOW64]
(GC_init): Do not call IsWow64Process() and GC_win32_MessageBoxA().
* win32_threads.c [I386] (isWow64): New static variable.
* win32_threads.c [I386] (GC_push_stack_for): If isWow64 then set also
CONTEXT_EXCEPTION_REQUEST and CONTEXT_SEGMENTS bits in ContextFlags;
if isWow64, and CONTEXT_EXCEPTION_REPORTING and
CONTEXT_EXCEPTION_ACTIVE are set on return from GetThreadContext then
call GetThreadSelectorEntry and use StackLimit of FS selector to set
sp local variable (instead of context.Esp); add comment.
* win32_threads.c [I386 && DEBUG_THREADS] (GC_push_stack_for): Call
GC_log_printf() to report TIB stack limit/base and the case when
CONTEXT_EXCEPTION_REQUEST is not supported.
* win32_threads.c [I386] (GC_thr_init): Set isWow64 by IsWow64Process()
if the later is available.

5 years agoWorkaround 'checking if unsigned expression < 0' cppcheck warnings
Ivan Maidanski [Thu, 7 Feb 2019 17:43:13 +0000 (20:43 +0300)]
Workaround 'checking if unsigned expression < 0' cppcheck warnings

* alloc.c [CPPCHECK] (GC_compute_heap_usage_percent): Replace
GC_WORD_MAX/100 with (GC_WORD_MAX>>1)/50; add comment.
* os_dep.c [!AMIGA && !HAIKU && !OPENBSD && !OS2 && !MSWIN32]
(GC_get_main_stack_base): Skip assertion on result if CPPCHECK.

5 years agoTravis CI: Test --disable-shared on OS X (x86_64)
Ivan Maidanski [Thu, 7 Feb 2019 06:38:56 +0000 (09:38 +0300)]
Travis CI: Test --disable-shared on OS X (x86_64)

5 years agoEnable mprotect-based incremental GC for Linux/arm and Linux/aarch64
Ivan Maidanski [Fri, 25 Jan 2019 08:42:43 +0000 (11:42 +0300)]
Enable mprotect-based incremental GC for Linux/arm and Linux/aarch64

* include/private/gcconfig.h [AARCH64 && LINUX && !(GC_LINUX_THREADS
&& REDIRECT_MALLOC)] (MPROTECT_VDB): Define macro (similar to X86_64
and I386 cases).
* include/private/gcconfig.h [ARM32 && LINUX && !(GC_LINUX_THREADS
&& REDIRECT_MALLOC)] (MPROTECT_VDB): Likewise.

5 years agoFix 'undefined reference to __data_start' linker error (Android/aarch64)
Ivan Maidanski [Fri, 25 Jan 2019 07:44:25 +0000 (10:44 +0300)]
Fix 'undefined reference to __data_start' linker error (Android/aarch64)

As of NDK r18b, __data_start symbol is only provided by bfd linker.

* include/private/gcconfig.h [AARCH64 && LINUX && HOST_ANDROID]
(__data_start): Do not declare extern variable.
* include/private/gcconfig.h [AARCH64 && LINUX && HOST_ANDROID]
(SEARCH_FOR_DATA_START): Define (instead of DATASTART); add comment.

5 years agoWorkaround 'wrong __data_start/_end' if __end__ is incorrect (Android)
Ivan Maidanski [Thu, 24 Jan 2019 21:54:18 +0000 (00:54 +0300)]
Workaround 'wrong __data_start/_end' if __end__ is incorrect (Android)

Issue #259 (bdwgc).

To prevent use of __end__ symbol, "-D BROKEN_UUENDUU_SYM" should be
passed to CFLAGS.

* include/private/gcconfig.h [HOST_ANDROID && __clang__] (DATAEND):
Do not redefine to __end__ if BROKEN_UUENDUU_SYM.

5 years agoFix 'unexpected mark stack overflow' abort in push_all_stack
Ivan Maidanski [Mon, 21 Jan 2019 22:01:45 +0000 (01:01 +0300)]
Fix 'unexpected mark stack overflow' abort in push_all_stack

Issue #260 (bdwgc).

* mark.c [!NEED_FIXUP_POINTER] (GC_push_all_stack): Call
GC_push_all_eager() instead of GC_push_all() if GC_mark_stack_top is
rather close to GC_mark_stack_limit.

5 years agoWorkaround 'local t shadows outer var' cppcheck warning in disclaim_bench
Ivan Maidanski [Tue, 15 Jan 2019 20:36:55 +0000 (23:36 +0300)]
Workaround 'local t shadows outer var' cppcheck warning in disclaim_bench
(fix of commit 4880d09f6)

Issue #258 (bdwgc).

* include/private/gc_priv.h [!NO_CLOCK && (MSWINRT_FLAVOR
|| WINXP_USE_PERF_COUNTER)] (GET_TIME): Rename t local variable to tc.

5 years agoWorkaround 'if condition is the same as the previous one' cppcheck warnings
Ivan Maidanski [Tue, 15 Jan 2019 16:52:15 +0000 (19:52 +0300)]
Workaround 'if condition is the same as the previous one' cppcheck warnings

* alloc.c [THREAD_LOCAL_ALLOC] (GC_stopped_mark): Set GC_world_stopped
to FALSE after GC_on_collection_event(GC_EVENT_PRE_START_WORLD).
* alloc.c [THREAD_LOCAL_ALLOC] (GC_stopped_mark): Collapse adjacent
"if" statements.
* mark.c [!GC_DISABLE_INCREMENTAL] (GC_initiate_gc): Likewise.
* pthread_stop_world.c [!NACL && !GC_OPENBSD_UTHREADS
&& !GC_NETBSD_THREADS_WORKAROUND] (GC_start_world): Likewise.

5 years agoAppveyor CI: Test MinGW with -D WINXP_USE_PERF_COUNTER
Ivan Maidanski [Mon, 14 Jan 2019 22:01:38 +0000 (01:01 +0300)]
Appveyor CI: Test MinGW with -D WINXP_USE_PERF_COUNTER

5 years agoUse better precision Windows timers
Jonas Echterhoff [Fri, 19 Oct 2018 10:56:45 +0000 (12:56 +0200)]
Use better precision Windows timers
(a cherry-pick of commits 2fe2d43, 4d2d250, f72b9cf, 583af80
from Unity-Technologies/bdwgc)

Issue #258 (bdwgc).

The feature is enabled if MSWINRT_FLAVOR or WINXP_USE_PERF_COUNTER.

* include/private/gc_priv.h [!NO_CLOCK && !BSD_TIME
&& WINXP_USE_PERF_COUNTER]: Include windows.h and winbase.h.
* include/private/gc_priv.h [!NO_CLOCK && !BSD_TIME && (MSWINRT_FLAVOR
|| WINXP_USE_PERF_COUNTER)] (CLOCK_TYPE): Define ULONGLONG (instead of
DWORD).
* include/private/gc_priv.h [!NO_CLOCK && !BSD_TIME && (MSWINRT_FLAVOR
|| WINXP_USE_PERF_COUNTER)] (GET_TIME): Use QueryPerformanceFrequency()
and QueryPerformanceCounter() to get the current time (instead of
GetTickCount64()).
* include/private/gc_priv.h [!NO_CLOCK && !BSD_TIME && (MSWINRT_FLAVOR
|| WINXP_USE_PERF_COUNTER)] (MS_TIME_DIFF): Divide by a million.
* include/private/gc_priv.h [!NO_CLOCK && !BSD_TIME && (MSWINRT_FLAVOR
|| WINXP_USE_PERF_COUNTER)] (NS_FRAC_TIME_DIFF): Return (a-b)%1000000
(instead of 0).

5 years agoReport time with a nanosecond precision where available
Ivan Maidanski [Mon, 14 Jan 2019 06:52:57 +0000 (09:52 +0300)]
Report time with a nanosecond precision where available

Issue #258 (bdwgc).

* alloc.c [!NO_CLOCK] (GC_time_lim_nsec): Update comment.
* alloc.c [!NO_CLOCK && !GC_DISABLE_INCREMENTAL]
(GC_timeout_stop_func): Declare nsec_diff local variable; use
GC_time_lim_nsec.
* alloc.c [!NO_CLOCK && !GC_DISABLE_INCREMENTAL]
(GC_timeout_stop_func): Use NS_FRAC_TIME_DIFF(); print "ns" value after
"ms" one.
* alloc.c [!NO_CLOCK] (GC_try_to_collect_inner, GC_stopped_mark,
GC_finish_collection): Likewise.
* reclaim.c [!NO_CLOCK] (GC_reclaim_all): Likewise.
* include/private/gc_priv.h [!NO_CLOCK && BSD_TIME] (MS_TIME_DIFF):
Always round the result of division toward minus infinity.
* include/private/gc_priv.h [!NO_CLOCK] (NS_FRAC_TIME_DIFF): New macro.

5 years agoReplace "msecs" with "ms" in all comments and messages
Ivan Maidanski [Sun, 6 Jan 2019 11:11:10 +0000 (14:11 +0300)]
Replace "msecs" with "ms" in all comments and messages

* README.md (Bugs): Replace "msecs" with "ms".
* doc/README.environment (GC_PAUSE_TIME_TARGET): Likewise.
* doc/gcdescr.md (Generational Collection and Dirty Bits): Likewise.
* alloc.c [!NO_CLOCK] (full_gc_total_time): Replace "msecs" with "ms"
in comment.
* cord/tests/de.c [WIN32] (beep): Likewise.
* pthread_support.c [USE_SPIN_LOCK] (GC_lock): Likewise.
* alloc.c [!GC_DISABLE_INCREMENTAL && !NO_CLOCK]
(GC_timeout_stop_func): Replace "msecs" with "ms" in the printed
string.
* alloc.c [!NO_CLOCK] (GC_try_to_collect_inner, GC_stopped_mark,
GC_finish_collection): Likewise.
* misc.c [!NO_CLOCK] (GC_dump_named): Likewise.
* reclaim.c [!NO_CLOCK] (GC_reclaim_all): Likewise.
* tests/test.c [!NO_CLOCK] (check_heap_stats): Likewise.

5 years agoTravis CI: Test with -D BSD_TIME passed to CFLAGS
Ivan Maidanski [Sat, 5 Jan 2019 08:56:58 +0000 (11:56 +0300)]
Travis CI: Test with -D BSD_TIME passed to CFLAGS

5 years agoEnsure result of every variant of MS_TIME_DIFF has unsigned long type
Ivan Maidanski [Fri, 4 Jan 2019 16:55:34 +0000 (19:55 +0300)]
Ensure result of every variant of MS_TIME_DIFF has unsigned long type
(code refactoring)

Previously, MS_TIME_DIFF had the result of long type for Nintendo and
Win32 targets.

* include/private/gc_priv.h [!NO_CLOCK && BSD_TIME] (MS_TIME_DIFF): Add
comment.
* include/private/gc_priv.h [!NO_CLOCK && !BSD_TIME && (MSWIN32
|| MSWINCE || NN_PLATFORM_CTR)] (MS_TIME_DIFF): Cast result to
unsigned long (instead of long).

5 years agoFix BSD_TIME variant of MS_TIME_DIFF for the case of a.tv_usec < b.tv_usec
Ivan Maidanski [Fri, 4 Jan 2019 16:37:50 +0000 (19:37 +0300)]
Fix BSD_TIME variant of MS_TIME_DIFF for the case of a.tv_usec < b.tv_usec
(fix of commit 6b2796b69)

* include/private/gc_priv.h [!NO_CLOCK && BSD_TIME] (MS_TIME_DIFF):
Cast the result of a.tv_usec-b.tv_usec to long (so that the result of
the division should be negative if a.tv_usec is less than b.tv_usec).

5 years agoAdd API for accessing incremental GC time limit with nanosecond precision
Ivan Maidanski [Fri, 4 Jan 2019 13:17:31 +0000 (16:17 +0300)]
Add API for accessing incremental GC time limit with nanosecond precision

Issue #258 (bdwgc).

This commit only adds the API (GC_set_time_limit_tv,
GC_get_time_limit_tv).

* alloc.c [!NO_CLOCK] (GC_time_lim_nsec): New STATIC variable.
* alloc.c [!NO_CLOCK] (TV_NSEC_LIMIT): New macro.
* alloc.c [!NO_CLOCK] (GC_set_time_limit_tv, GC_get_time_limit_tv):
New public function definition.
* include/gc.h (GC_time_limit, GC_set_time_limit): Update comment.
* include/gc.h (GC_timeval_s): New struct definition.
* include/gc.h (GC_set_time_limit_tv, GC_get_time_limit_tv): New public
function declaration.
* include/gc.h [GC_TIME_LIMIT && !CPPCHECK] (GC_INIT_CONF_TIME_LIMIT):
Refine comment.
* tests/test.c [!PCR && !GC_WIN32_THREADS && !GC_PTHREADS && CPPCHECK
&& !NO_CLOCK] (main): Add UNTESTED() for GC_get_time_limit_tv and
GC_set_time_limit_tv.

5 years agoFix invalid initializer of CLOCK_TYPE variables if BSD_TIME
Ivan Maidanski [Sat, 5 Jan 2019 08:52:53 +0000 (11:52 +0300)]
Fix invalid initializer of CLOCK_TYPE variables if BSD_TIME
(fix of commits 7e59301c106ecaefca)

* alloc.c [!NO_CLOCK] (GC_start_time): Initialize to
CLOCK_TYPE_INITIALIZER (instead of 0).
* alloc.c [!NO_CLOCK] (GC_try_to_collect_inner, GC_stopped_mark,
GC_finish_collection): Initialize local variable of CLOCK_TYPE type to
CLOCK_TYPE_INITIALIZER (instead of 0); remove comment (duplicating that
in gc_priv.h).
* reclaim.c [!NO_CLOCK] (GC_reclaim_all): Likewise.
* include/private/gc_priv.h [!NO_CLOCK] (CLOCK_TYPE_INITIALIZER):
Define macro.

5 years agoWorkaround 'me assigned value never used' cppcheck FP in register_my_thread
Ivan Maidanski [Sat, 29 Dec 2018 07:12:44 +0000 (10:12 +0300)]
Workaround 'me assigned value never used' cppcheck FP in register_my_thread

* pthread_support.c [CPPCHECK] (GC_register_my_thread): Call
GC_noop1(me->flags) after reassigning me to the result of
GC_register_my_thread_inner(sb,self).
* win32_threads.c [CPPCHECK] (GC_register_my_thread): Likewise.

5 years agoTravis CI: Do not pass --quiet to cppcheck
Ivan Maidanski [Sat, 29 Dec 2018 07:02:12 +0000 (10:02 +0300)]
Travis CI: Do not pass --quiet to cppcheck
(fix of commit e3d3b3bec)

In case of cppcheck quiet mode, grep (in the pipe) exits with an error.

5 years agoTravis CI: Workaround timeout of 'cppcheck --enable=unusedFunction --force'
Ivan Maidanski [Fri, 28 Dec 2018 21:50:34 +0000 (00:50 +0300)]
Travis CI: Workaround timeout of 'cppcheck --enable=unusedFunction --force'

"cppcheck --enable=unusedFunction --force extra/gc.c" takes longer than
the Travis CI timeout (50m), so gc.c is checked for unused functions
without --force option for now.

5 years agoSupport de_win.c compilation by Makefile.direct (cord/de)
Ivan Maidanski [Thu, 27 Dec 2018 09:03:29 +0000 (12:03 +0300)]
Support de_win.c compilation by Makefile.direct (cord/de)

* Makefile.direct (cord/de): Add dependency on de_win.c and de_win.h;
compile cord/tests/de_win.c (in case of if_not_there case).
* cord/tests/de_win.c [!__BORLANDC__ && !__CYGWIN__ && !__MINGW32__
&& !__NT__ && !_WIN32 && !WIN32]: Skip the whole file (compile
"extern int GC_quiet" instead).

5 years agoAvoid test.o rebuild on tests folder timestamp change (Makefile.direct)
Ivan Maidanski [Thu, 27 Dec 2018 08:36:15 +0000 (11:36 +0300)]
Avoid test.o rebuild on tests folder timestamp change (Makefile.direct)

* Makefile.direct (tests/test.o): Remove dependency on "tests" target;
execute "mkdir tests".
* Makefile.direct (tests): Remove target.

5 years agoRemove Linux-specific commands for building cord/de from Makefile.direct
Ivan Maidanski [Thu, 27 Dec 2018 08:28:04 +0000 (11:28 +0300)]
Remove Linux-specific commands for building cord/de from Makefile.direct
(code refactoring)

The cord/de build options are not specific for Linux targets.

* Makefile.direct (cord/de): Remove "if_mach * LINUX" commands.

5 years agoUpdate ChangeLog file
Ivan Maidanski [Wed, 26 Dec 2018 08:01:21 +0000 (11:01 +0300)]
Update ChangeLog file

5 years agoUse atomics on PS4
Jonas Echterhoff [Tue, 18 Dec 2018 10:14:55 +0000 (11:14 +0100)]
Use atomics on PS4
(a cherry-pick of commit 46615fe1d from Unity-Technologies/bdwgc)

* include/private/gc_priv.h [THREADS && SN_TARGET_ORBIS]: Include
gc_atomic_ops.h too.

5 years agoUpdate ChangeLog file (set v8.0.2 release date)
Ivan Maidanski [Sun, 23 Dec 2018 20:22:11 +0000 (23:22 +0300)]
Update ChangeLog file (set v8.0.2 release date)

5 years agoUpdate ChangeLog file (v8.0 changes)
Ivan Maidanski [Sun, 23 Dec 2018 08:56:50 +0000 (11:56 +0300)]
Update ChangeLog file (v8.0 changes)

5 years agoUpdate libgc.so version info to differentiate against v8.0.x
Ivan Maidanski [Sun, 23 Dec 2018 17:20:56 +0000 (20:20 +0300)]
Update libgc.so version info to differentiate against v8.0.x

There are no API/implementation changes in libcord and libgccpp against
release-8_0 for now, so the corresponding version info is not updated.

There are some implementation changes and new API functions addition in
libgc (without API incompatible changes) against release-8_0, so the
"current" and "age" parts of the version info are incremented.

* Makefile.am (LIBGC_VER_INFO): Change version info to 6:0:5.

5 years agoTurn on memory unmapping in BCC/DMC/NT/WCC makefiles and Makefile.direct
Ivan Maidanski [Sun, 23 Dec 2018 07:50:15 +0000 (10:50 +0300)]
Turn on memory unmapping in BCC/DMC/NT/WCC makefiles and Makefile.direct

* BCC_MAKEFILE (defines): Add -D USE_MUNMAP.
* NT_MAKEFILE (CFLAGS_DEFAULT): Likewise.
* WCC_MAKEFILE [MSWIN32] (DEFS): Likewise.
* digimars.mak (DEFINES): Likewise.
* Makefile.direct (CFLAGS): Add -D USE_MMAP -D USE_MUNMAP.

5 years agoDocument HANDLE_FORK macro optional usage in Makefile.direct
Ivan Maidanski [Sat, 22 Dec 2018 18:55:17 +0000 (21:55 +0300)]
Document HANDLE_FORK macro optional usage in Makefile.direct

* Makefile.direct (CFLAGS): Add comment about -D HANDLE_FORK.

5 years agoDo not prevent GC from looking at environment variables (BCC_MAKEFILE)
Ivan Maidanski [Sat, 22 Dec 2018 18:49:22 +0000 (21:49 +0300)]
Do not prevent GC from looking at environment variables (BCC_MAKEFILE)

* BCC_MAKEFILE (defines): Remove -D NO_GETENV.

5 years agoTurn on gcj functionality in BCC, DMC, NT, OS/2, WCC makefiles
Ivan Maidanski [Sat, 22 Dec 2018 18:27:19 +0000 (21:27 +0300)]
Turn on gcj functionality in BCC, DMC, NT, OS/2, WCC makefiles

* BCC_MAKEFILE (defines): Add -D GC_GCJ_SUPPORT.
* Makefile.direct (CFLAGS): Likewise.
* OS2_MAKEFILE (CFLAGS): Likewise.
* WCC_MAKEFILE (DEFS): Likewise.
* digimars.mak (DEFINES): Likewise.
* BCC_MAKEFILE (XXXOBJS): Add XXXgcj_mlc.obj.
* NT_MAKEFILE (CFLAGS_DEFAULT): New variable (value copied from .c.obj);
add -D GC_GCJ_SUPPORT.
* NT_MAKEFILE (OBJS): Add gcj_mlc.obj.
* OS2_MAKEFILE (OBJS): Likewise.
* WCC_MAKEFILE (OBJS): Likewise.
* digimars.mak (OBJS): Likewise.
* NT_MAKEFILE (.c.obj, .cpp.obj): Use CFLAGS_DEFAULT variable.

5 years agoAbort with appropriate message if executable pages cannot be allocated
Ivan Maidanski [Thu, 20 Dec 2018 23:33:49 +0000 (02:33 +0300)]
Abort with appropriate message if executable pages cannot be allocated

This may happen e.g. if PaX MPROTECT feature is enabled.

* os_dep.c [!OS2 && !PCR && !AMIGA && !USE_WINALLOC && !MACOS
&& !DOS4GW && !NONSTOP && !SN_TARGET_PSP2 && !RTEMS && !__CC_ARM
&& MMAP_SUPPORTED] (GC_unix_mmap_get_mem): Treat result==MAP_FAILED as
unlikely; if the first mmap call returns MAP_FAILED then ABORT with the
appropriate message if GC_pages_executable (and errno is EACCES).

5 years agoFix 'mprotect remapping failed' abort on NetBSD with PaX enabled
Ivan Maidanski [Thu, 20 Dec 2018 21:54:55 +0000 (00:54 +0300)]
Fix 'mprotect remapping failed' abort on NetBSD with PaX enabled

Issue #255 (bdwgc).

Without this patch, GC_remap() works on NetBSD which has the PaX feature
only if PaX MPROTECT is off (sysctl -w security.pax.mprotect.enabled=0).

* os_dep.c [USE_MUNMAP && !USE_WINALLOC && NETBSD] (GC_remap): Call
mmap() instead of mprotect().

5 years agoTravis CI: Test with -D TEST_PAGES_EXECUTABLE passed to CFLAGS
Ivan Maidanski [Thu, 20 Dec 2018 21:30:57 +0000 (00:30 +0300)]
Travis CI: Test with -D TEST_PAGES_EXECUTABLE passed to CFLAGS

5 years agoAllow to force executable pages allocation in gctest
Ivan Maidanski [Thu, 20 Dec 2018 08:34:12 +0000 (11:34 +0300)]
Allow to force executable pages allocation in gctest

Pass -D TEST_PAGES_EXECUTABLE to CFLAGS to enable the executable pages
allocation in gctest even if the collector is compiled with
NO_EXECUTE_PERMISSION.

* tests/test.c (INIT_PAGES_EXECUTABLE): New macro (calls
GC_set_pages_executable(1) if TEST_PAGES_EXECUTABLE).
* tests/test.c (GC_COND_INIT): Call INIT_PAGES_EXECUTABLE (before
GC_OPT_INIT).
* tests/test.c [!PCR && !GC_WIN32_THREADS && !GC_PTHREADS && CPPCHECK]
(main): Remove UNTESTED(GC_set_pages_executable).

5 years agoFix executable memory allocation in GC_unix_get_mem
Ivan Maidanski [Thu, 20 Dec 2018 08:12:06 +0000 (11:12 +0300)]
Fix executable memory allocation in GC_unix_get_mem

Previously, sbrk() was used for the memory allocation even if the
executable pages were requested.

* os_dep.c [!OS2 && !PCR && !AMIGA && !USE_WINALLOC && !MACOS
&& !DOS4GW && !NONSTOP && !SN_TARGET_PSP2 && !RTEMS && !__CC_ARM
&& MMAP_SUPPORTED] (GC_unix_get_mem): Do not call GC_unix_sbrk_get_mem
if GC_pages_executable; add comment.

5 years agoWorkaround 'nl-result_buf is out of bounds' cppcheck false positive
Ivan Maidanski [Wed, 19 Dec 2018 23:14:16 +0000 (02:14 +0300)]
Workaround 'nl-result_buf is out of bounds' cppcheck false positive

* os_dep.c [NEED_CALLINFO && LINUX && !SMALL_CONFIG] (GC_print_callers):
Replace nl-result_buf to (word)nl-COVERT_DATAFLOW(result_buf).

5 years agoWorkaround 'argument dummy to GC_noop1 is always 1' cppcheck false positive
Ivan Maidanski [Wed, 19 Dec 2018 23:10:04 +0000 (02:10 +0300)]
Workaround 'argument dummy to GC_noop1 is always 1' cppcheck false positive

* misc.c [!ALWAYS_SMALL_CLEAR_STACK && !STACK_NOT_SCANNED
&& !ASM_CLEAR_CODE && CPPCHECK] (GC_clear_stack_inner): Pass dummy[0]
instead of address of dummy variable.

5 years agoEliminate 'stop variable is always 0' compiler warning in print_callers
Ivan Maidanski [Wed, 19 Dec 2018 19:50:57 +0000 (22:50 +0300)]
Eliminate 'stop variable is always 0' compiler warning in print_callers

* os_dep.c [NEED_CALLINFO] (GC_print_callers): Declare (and use value
of) stop local variable only if LINUX && !SMALL_CONFIG; move stop local
variable to the scope of its use.

5 years agoWorkaround '__data_start<_etext is always false' cppcheck false positive
Ivan Maidanski [Wed, 19 Dec 2018 19:17:25 +0000 (22:17 +0300)]
Workaround '__data_start<_etext is always false' cppcheck false positive

* os_dep.c [SEARCH_FOR_DATA_START && (LINUX || HURD)
&& !IGNORE_PROG_DATA_START && HOST_ANDROID] (GC_init_linux_data_start):
Skip the workaround for "gold" linker if CPPCHECK.

5 years agoEliminate 'hash_val value is never used' cppcheck false positive
Ivan Maidanski [Wed, 19 Dec 2018 19:11:42 +0000 (22:11 +0300)]
Eliminate 'hash_val value is never used' cppcheck false positive

* specific.c [USE_CUSTOM_SPECIFIC] (GC_setspecific): Change type of
hash_val local variable from int to unsigned.
* specific.c [USE_CUSTOM_SPECIFIC] (GC_slow_getspecific): Remove
hash_val local variable.

5 years agoUpdate NO_EXECUTE_PERMISSION documentation
Ivan Maidanski [Tue, 18 Dec 2018 23:28:21 +0000 (02:28 +0300)]
Update NO_EXECUTE_PERMISSION documentation

* doc/README.macros (NO_EXECUTE_PERMISSION): Update and refine the
documentation (e.g. mention memory unmapping).

5 years agoDefine GC_ATOMIC_UNCOLLECTABLE and JAVA_FINALIZATION in all make scripts
Ivan Maidanski [Tue, 18 Dec 2018 23:17:58 +0000 (02:17 +0300)]
Define GC_ATOMIC_UNCOLLECTABLE and JAVA_FINALIZATION in all make scripts

This matches the policy of configure and CMakeLists.txt.

* BCC_MAKEFILE (defines): Add -D GC_ATOMIC_UNCOLLECTABLE.
* NT_MAKEFILE (.cpp.obj): Likewise.
* Makefile.direct (CFLAGS): Add -D JAVA_FINALIZATION; reorder options.
* NT_MAKEFILE (.c.obj): Add -D GC_ATOMIC_UNCOLLECTABLE
-D JAVA_FINALIZATION.
* OS2_MAKEFILE (CFLAGS): Likewise.
* WCC_MAKEFILE (DEFS): Likewise.
* build/s60v3/libgc.mmp: Likewise.
* digimars.mak (DEFINES): Likewise.
* gc.mak [$CFG=="gc - Win32 Release" || $CFG=="gc - Win32 Debug"]
(CPP_PROJ): Likewise.
* NT_MAKEFILE (.cpp.obj): Remove redundant -I $(AO_INCLUDE_DIR)
-D ALL_INTERIOR_POINTERS.

5 years agoRemove redundant options for building 'cord' in gc.mak
Ivan Maidanski [Tue, 18 Dec 2018 22:19:53 +0000 (01:19 +0300)]
Remove redundant options for building 'cord' in gc.mak
(code refactoring)

* gc.mak [$CFG=="cord - Win32 Release" || $CFG=="cord - Win32 Debug"]
(CPP_PROJ): Remove -D ALL_INTERIOR_POINTERS -D ENABLE_DISCLAIM
-I libatomic_ops/src.

5 years agoDefault to non-executable memory allocation across all make scripts
Ivan Maidanski [Tue, 18 Dec 2018 21:48:13 +0000 (00:48 +0300)]
Default to non-executable memory allocation across all make scripts

This matches the policy of Makefile.direct, configure and CMakeLists.txt.

* BCC_MAKEFILE (defines): Add -D NO_EXECUTE_PERMISSION.
* NT_MAKEFILE (.c.obj): Likewise.
* OS2_MAKEFILE (CFLAGS): Likewise.
* WCC_MAKEFILE (DEFS): Likewise.
* digimars.mak (DEFINES): Likewise.
* gc.mak [$CFG=="gc - Win32 Release" || $CFG=="gc - Win32 Debug"]
(CPP_PROJ): Likewise.

5 years agoUpdate ChangeLog file (set v7.6.10 release date)
Ivan Maidanski [Thu, 13 Dec 2018 06:47:35 +0000 (09:47 +0300)]
Update ChangeLog file (set v7.6.10 release date)

5 years agoUpdate ChangeLog file (set v7.4.16 release date)
Ivan Maidanski [Thu, 13 Dec 2018 05:57:24 +0000 (08:57 +0300)]
Update ChangeLog file (set v7.4.16 release date)

5 years agoUpdate ChangeLog file (set v7.2m release date)
Ivan Maidanski [Tue, 11 Dec 2018 19:46:20 +0000 (22:46 +0300)]
Update ChangeLog file (set v7.2m release date)

5 years agoRemove goto statement in print_callers
Ivan Maidanski [Thu, 6 Dec 2018 08:41:33 +0000 (11:41 +0300)]
Remove goto statement in print_callers
(code refactoring)

* os_dep.c [NEED_CALLINFO && LINUX && !SMALL_CONFIG] (GC_print_callers):
Replace "goto out" to "break" statement in a do-while(0) block; remove
"out" label; move ret_code local variable declaration to the scope of
its usage; close pipe immediately after fread().

5 years agoEliminate 'assigned value never used' compiler warning in test_cpp WinMain
Ivan Maidanski [Thu, 6 Dec 2018 08:23:52 +0000 (11:23 +0300)]
Eliminate 'assigned value never used' compiler warning in test_cpp WinMain

* tests/test_cpp.cc [(MSWIN32 && !__MINGW32__ || MSWINCE)
&& !NO_WINMAIN_ENTRY] (WinMain): Remove first argv[argc]=cmd (when cmd
points to a space or tab character).

5 years agoWorkaround 'name var reassign before old value use' cppcheck false positive
Ivan Maidanski [Thu, 6 Dec 2018 08:14:37 +0000 (11:14 +0300)]
Workaround 'name var reassign before old value use' cppcheck false positive

* os_dep.c [NEED_CALLINFO && LINUX && !SMALL_CONFIG && CPPCHECK]
(GC_print_callers): Call GC_noop1(name[0]) before reassigning name;
add comment.

5 years agoDo not use 'ifndef AO_CLEAR' in mark, pthread_support and gctest
Ivan Maidanski [Wed, 5 Dec 2018 22:47:19 +0000 (01:47 +0300)]
Do not use 'ifndef AO_CLEAR' in mark, pthread_support and gctest
(code refactoring of commits 272283d5bd6c7ee31d2178db2b6)

* include/private/gc_priv.h [THREADS && !NN_PLATFORM_CTR
&& !SN_TARGET_ORBIS && !SN_TARGET_PSP2 && !AO_HAVE_compiler_barrier]
(AO_HAVE_compiler_barrier): Define private macro (after include
gc_atomic_ops.h).
* mark.c [!BASE_ATOMIC_OPS_EMULATED] (GC_noop6): Call
AO_compiler_barrier() only if AO_HAVE_compiler_barrier.
* pthread_support.c [(USE_SPIN_LOCK || !NO_PTHREAD_TRYLOCK)
&& !BASE_ATOMIC_OPS_EMULATED] (GC_pause): Likewise.
* tests/test.c (AO_t): Define only if AO_HAVE_compiler_barrier is not
defined.

5 years agoDo not use 'ifndef AO_CLEAR' in disclaim_weakmap_test
Ivan Maidanski [Wed, 5 Dec 2018 22:02:30 +0000 (01:02 +0300)]
Do not use 'ifndef AO_CLEAR' in disclaim_weakmap_test
(code refactoring of commit 95e074727)

* tests/disclaim_weakmap_test.c [!GC_PTHREADS] (AO_t): Define (as
GC_word).
* tests/disclaim_weakmap_test.c (AO_t): Do not check whether AO_CLEAR
is defined; remove comment.

5 years agoUpdate ChangeLog file
Ivan Maidanski [Tue, 4 Dec 2018 21:45:52 +0000 (00:45 +0300)]
Update ChangeLog file

5 years agoUpdate ChangeLog file (v8.0 changes)
Ivan Maidanski [Tue, 4 Dec 2018 09:06:26 +0000 (12:06 +0300)]
Update ChangeLog file (v8.0 changes)

5 years agoUpdate ChangeLog file (v7.6 changes)
Ivan Maidanski [Tue, 4 Dec 2018 08:42:54 +0000 (11:42 +0300)]
Update ChangeLog file (v7.6 changes)

5 years agoUpdate ChangeLog file (v7.2 - v7.4 changes only)
Ivan Maidanski [Mon, 3 Dec 2018 22:40:03 +0000 (01:40 +0300)]
Update ChangeLog file (v7.2 - v7.4 changes only)

5 years agoRefine HIDE_POINTER documentation for the case of the leak-finding mode
Ivan Maidanski [Thu, 29 Nov 2018 09:04:07 +0000 (12:04 +0300)]
Refine HIDE_POINTER documentation for the case of the leak-finding mode

* include/gc.h (GC_HIDE_POINTER, GC_REVEAL_POINTER): Refine comment
(warn about usage in the leak-finding mode).

5 years agoFix disclaim_weakmap_test failures in leak-finding mode
Ivan Maidanski [Thu, 29 Nov 2018 08:53:21 +0000 (11:53 +0300)]
Fix disclaim_weakmap_test failures in leak-finding mode

Issue #252 (bdwgc).

* tests/disclaim_weakmap_test.c (weakmap_add, weakmap_disclaim): Bypass
GC_REVEAL_POINTER() and GC_HIDE_POINTER() logic if GC_find_leak.

5 years agoFix GC_register_disclaim_proc for leak-finding mode
Ivan Maidanski [Thu, 29 Nov 2018 08:46:48 +0000 (11:46 +0300)]
Fix GC_register_disclaim_proc for leak-finding mode

Issue #252 (bdwgc).

This makes the behavior of GC_register_disclaim_proc() and
GC_finalized_malloc() somewhat consistent with
GC_register_disappearing_link() and GC_register_finalizer() when
find-leak is on.  The documentation is updated accordingly.

* fnlz_mlc.c [ENABLE_DISCLAIM] (GC_finalized_disclaim): Add assertion
that GC_find_leak is off.
* fnlz_mlc.c [ENABLE_DISCLAIM] (GC_register_disclaim_proc): Do not
assign ok_disclaim_proc, ok_mark_unconditionally fields if GC_find_leak.
* include/gc_disclaim.h (GC_register_disclaim_proc,
GC_finalized_malloc): Refine comment about leak-find mode and GC_free
invocation.

5 years agoWorkaround 'var reassigned before old value use' cppcheck false positive
Ivan Maidanski [Wed, 28 Nov 2018 22:05:26 +0000 (01:05 +0300)]
Workaround 'var reassigned before old value use' cppcheck false positive

* extra/AmigaOS.c [!GC_AMIGA_ONLYFAST && CPPCHECK]
(GC_amiga_allocwrapper_any): Add a dummy read of GC_amiga_dontalloc
global variable; add comment.
* pthread_support.c [CPPCHECK] (GC_do_blocking_inner): Add a dummy read
of thread_blocked field of GC_thread.
* pthread_support.c [CPPCHECK] (GC_call_with_gc_active): Add a dummy
read of traced_stack_sect field of GC_thread.

5 years agoTravis CI: Pass extra/gc.c to cppcheck --enable=unusedFunction
Ivan Maidanski [Wed, 28 Nov 2018 09:09:59 +0000 (12:09 +0300)]
Travis CI: Pass extra/gc.c to cppcheck --enable=unusedFunction

This fixes a dozen of 'the function is never used' cppcheck style
warnings (for GC_core_gcj_malloc, GC_durango_get_mem,
GC_FreeBSDGetDataStart, GC_haiku_get_mem, GC_mprotect_resume,
GC_mprotect_stop, GC_remove_roots_subregion, GC_win32_get_mem,
GC_wince_get_mem).

5 years agoPrefix internal durango_get_mem symbol with 'GC_'
Ivan Maidanski [Wed, 28 Nov 2018 09:03:04 +0000 (12:03 +0300)]
Prefix internal durango_get_mem symbol with 'GC_'
(code refactoring of commit d16debf3e)

Issue #173 (bdwgc).

* include/private/gcconfig.h [MSWIN_XBOX1] (durango_get_mem): Rename
to GC_durango_get_mem; change return type from void* to ptr_t; remove
page_size argument.
* os_dep.c [MSWIN_XBOX1] (durango_get_mem): Likewise.
* include/private/gcconfig.h [MSWIN_XBOX1] (GET_MEM): Use
GC_durango_get_mem (instead of durango_get_mem).

5 years agoWorkaround 'GC_get_thr_restart_signal is never used' cppcheck warning
Ivan Maidanski [Wed, 28 Nov 2018 08:28:23 +0000 (11:28 +0300)]
Workaround 'GC_get_thr_restart_signal is never used' cppcheck warning

* tests/test.c [GC_PTHREADS && CPPCHECK && (GC_DARWIN_THREADS
|| GC_OPENBSD_UTHREADS)] (main): Add UNTESTED(GC_get_thr_restart_signal).

5 years agoTravis CI: Test with -D TEST_WITH_SYSTEM_MALLOC passed to CFLAGS
Ivan Maidanski [Fri, 23 Nov 2018 18:41:07 +0000 (21:41 +0300)]
Travis CI: Test with -D TEST_WITH_SYSTEM_MALLOC passed to CFLAGS

5 years agoEliminate 'function is never used' cppcheck warning for calloc/realloc
Ivan Maidanski [Fri, 23 Nov 2018 18:36:20 +0000 (21:36 +0300)]
Eliminate 'function is never used' cppcheck warning for calloc/realloc

* tests/test.c [TEST_WITH_SYSTEM_MALLOC] (run_one_test): Call calloc(),
realloc() and free().

5 years agoAdd initial testing of GC_enable/disable, MALLOC[_ATOMIC]_IGNORE_OFF_PAGE
Ivan Maidanski [Fri, 23 Nov 2018 11:42:57 +0000 (14:42 +0300)]
Add initial testing of GC_enable/disable, MALLOC[_ATOMIC]_IGNORE_OFF_PAGE

* tests/test.c (run_one_test): Call GC_MALLOC_ATOMIC_IGNORE_OFF_PAGE(),
GC_disable(), GC_MALLOC_IGNORE_OFF_PAGE(), GC_enable().

5 years agoWorkaround 'GC_dump function is never used' cppcheck warning
Ivan Maidanski [Fri, 23 Nov 2018 08:57:29 +0000 (11:57 +0300)]
Workaround 'GC_dump function is never used' cppcheck warning

* tests/test.c [!PCR && !GC_WIN32_THREADS && !GC_PTHREADS && CPPCHECK
&& !NO_DEBUGGING] (main): Add UNTESTED(GC_dump).

5 years agoWorkaround '*_stubborn function is never used' cppcheck warnings
Ivan Maidanski [Fri, 23 Nov 2018 08:49:31 +0000 (11:49 +0300)]
Workaround '*_stubborn function is never used' cppcheck warnings

* dbg_mlc.c (GC_debug_malloc_stubborn, GC_debug_change_stubborn): Do
not define if CPPCHECK.
* mallocx.c (GC_malloc_stubborn, GC_end_stubborn_change): Likewise.
* include/gc.h (GC_debug_change_stubborn): Always mark as
GC_ATTR_DEPRECATED (regardless of CPPCHECK).
* tests/test.c [!PCR && !GC_WIN32_THREADS && !GC_PTHREADS && CPPCHECK]
(main): Remove UNTESTED(GC_debug_change_stubborn).

5 years agoFix mutex_trylock failure in disclaim_weakmap_test in leak detection mode
Ivan Maidanski [Fri, 23 Nov 2018 06:23:02 +0000 (09:23 +0300)]
Fix mutex_trylock failure in disclaim_weakmap_test in leak detection mode

* tests/disclaim_weakmap_test.c (weakmap.links): Add comment.
* tests/disclaim_weakmap_test.c (weakmap_disclaim): If wm->links is
null then return 0 (do not use wm).
* tests/disclaim_weakmap_test.c (weakmap_destroy): Set links to null.

5 years agoFix 'collecting from unknown thread' abort in leak-finding mode for Win32
Ivan Maidanski [Thu, 22 Nov 2018 23:22:41 +0000 (02:22 +0300)]
Fix 'collecting from unknown thread' abort in leak-finding mode for Win32
(fix of commit 8e6460052)

* include/private/gc_priv.h [THREADS] (GC_in_thread_creation): Declare
not only for pthreads.
* misc.c [!DONT_USE_ATEXIT && THREADS] (GC_exit_check): Set
GC_in_thread_creation to true before calling GC_gcollect for windows
threads as well.
* win32_threads.c (GC_in_thread_creation): Change STATIC to GC_INNER.

5 years agoTurn off leak detection mode explicitly in cord/de
Ivan Maidanski [Thu, 22 Nov 2018 23:10:10 +0000 (02:10 +0300)]
Turn off leak detection mode explicitly in cord/de

* cord/tests/de.c [!WIN32] (main): Call GC_set_find_leak(0) before
GC_INIT() to disable leak detection mode.
* cord/tests/de_win.c [WIN32] (WinMain): Likewise.

5 years agoPrint relevant message in tests not appropriate for leak detection mode
Ivan Maidanski [Thu, 22 Nov 2018 22:17:28 +0000 (01:17 +0300)]
Print relevant message in tests not appropriate for leak detection mode

* cord/tests/cordtest.c (main): If GC_get_find_leak() then print a
message that the test is not designed for leak detection mode (i.e.,
plenty of leaks could be reported).
* tests/disclaim_bench.c (main): Likewise.
* tests/disclaim_test.c (main): Likewise.
* tests/disclaim_weakmap_test.c (main): Likewise.
* tests/initsecondarythread.c (main): Likewise.
* tests/middle.c (main): Likewise.
* tests/realloc_test.c (main): Likewise.
* tests/staticrootstest.c (main): Likewise.
* tests/test_cpp.cc (main): Likewise.
* tests/threadkey_test.c (main): Likewise.
* tests/trace_test.c (main): Likewise.

5 years agoTravis CI: Pass -U GC_PRIVATE_H to cppcheck
Ivan Maidanski [Thu, 22 Nov 2018 13:39:52 +0000 (16:39 +0300)]
Travis CI: Pass -U GC_PRIVATE_H to cppcheck

5 years agoWorkaround 'nonlocal var will use ptr to local var' cppcheck false positive
Ivan Maidanski [Thu, 22 Nov 2018 11:34:03 +0000 (14:34 +0300)]
Workaround 'nonlocal var will use ptr to local var' cppcheck false positive

* extra/msvc_dbg.c (sym_namebuf_u): New union type.
* extra/msvc_dbg.c (GetSymbolNameFromAddress): Use sym_namebuf_u
instead of anonymous union.
* os_dep.c [MPROTECT_VDB && DARWIN] (mp_reply_s, mp_msg_s): Move struct
type definition out of GC_mprotect_thread (adding mp_ prefix).

5 years agoEliminate 'struct member is never used' cppcheck warnings in os_dep
Ivan Maidanski [Thu, 22 Nov 2018 10:01:16 +0000 (13:01 +0300)]
Eliminate 'struct member is never used' cppcheck warnings in os_dep

* os_dep.c [SPARC && LINUX] (struct frame): Declare only if
SAVE_CALL_CHAIN.

5 years agoWorkaround 'value of _MAX_PATH is unknown' cppcheck warning
Ivan Maidanski [Thu, 22 Nov 2018 05:29:31 +0000 (08:29 +0300)]
Workaround 'value of _MAX_PATH is unknown' cppcheck warning

* include/private/gcconfig.h [CPPCHECK] (_MAX_PATH): Undefine.

5 years agoTravis CI: Test with FIND_LEAK
Ivan Maidanski [Wed, 21 Nov 2018 22:01:46 +0000 (01:01 +0300)]
Travis CI: Test with FIND_LEAK

5 years agoFix test_cpp assertion violation in find-leak mode
Ivan Maidanski [Wed, 21 Nov 2018 21:32:50 +0000 (00:32 +0300)]
Fix test_cpp assertion violation in find-leak mode

* tests/test_cpp.cc (C.Test, D.Test, F.Test): Do not fail on
nFreed>=0.8*nAllocated[F] assertion violation if GC_get_find_leak() returns
non-zero; replace .8*nAllocated[F] to (nAllocated[F]/5)*4 to avoid
floating-point operations.

5 years agoNew macro to suppress printing of leaked objects
Ivan Maidanski [Wed, 21 Nov 2018 21:09:14 +0000 (00:09 +0300)]
New macro to suppress printing of leaked objects

The macro (SKIP_LEAKED_OBJECTS_PRINTING) might be useful for running
GC general tests in the find-leak mode.

* reclaim.c (GC_print_all_errors): Do not call GC_print_heap_obj
if SKIP_LEAKED_OBJECTS_PRINTING is defined.

5 years agoTravis CI: Test with AO_USE_PTHREAD_DEFS passed in CFLAGS to configure
Ivan Maidanski [Wed, 21 Nov 2018 09:30:24 +0000 (12:30 +0300)]
Travis CI: Test with AO_USE_PTHREAD_DEFS passed in CFLAGS to configure

5 years agoTurn off parallel marker, thread-local allocation if used AO ops emulated
Ivan Maidanski [Wed, 21 Nov 2018 09:16:01 +0000 (12:16 +0300)]
Turn off parallel marker, thread-local allocation if used AO ops emulated

* configure.ac (use_parallel_mark, use_thread_local_alloc): New
variable (set to enable_parallel_mark and enable_thread_local_alloc,
respectively, if threads are enabled).
* configure.ac (PARALLEL_MARK, THREAD_LOCAL_ALLOC): Group and move
AC_DEFINE down (the definition depends on the final value of
use_parallel_mark or use_thread_local_alloc, respectively).
* configure.ac (THREAD_LOCAL_ALLOC): Move AM_CONDITIONAL down to use
the final value of use_thread_local_alloc; do not check THREADS.
* configure.ac (handle-fork): Move AC_ARG_ENABLE and its processing
down to use the final value of use_parallel_mark (the latter is used
instead of enable_parallel_mark).
* configure.ac [$with_libatomic_ops!=none && $need_atomic_ops_asm!=true]
(use_thread_local_alloc): Set explicitly to "no" if
BASE_ATOMIC_OPS_EMULATED is defined.
* configure.ac [$with_libatomic_ops!=none && $need_atomic_ops_asm!=true
&& $use_parallel_mark!=no] (use_parallel_mark): Set explicitly to "no"
in case of a failure of AC_TRY_LINK of a code snippet calling
AO_fetch_and_add and AO_compare_and_swap (provided AO_REQUIRE_CAS is
defined).
* include/private/gc_pmark.h [USE_MARK_BYTES && PARALLEL_MARK
&& AO_HAVE_char_store] (SET_MARK_BIT_EXIT_IF_SET): Do not use
AO_char_load() and AO_char_store() if BASE_ATOMIC_OPS_EMULATED.