Amitesh Singh [Sat, 15 Aug 2015 17:16:51 +0000 (22:46 +0530)]
list: fix crash while setting nearest item in viewport
This is an example of classic code copy and paste mistake.
Probably inspired from similar code in genlist/gengrid.
We were actually deleting the other items (except selected one) in
viewport in _elm_list_nearest_visible_item_get() which results into crash
while deleting the list object.
@fix
Resolves: T2662
Amitesh Singh [Sat, 15 Aug 2015 15:32:33 +0000 (21:02 +0530)]
popup: make scroller optional in popup
Summary:
@feature
Resolves: T2651
Test Plan:
1. elementary_test -to "popup"
2. Enable/disable checkbox named "Enable popup scoller"
Reviewers: raster, herb, herdsman, SanghyeonLee, tasn, simotek, cedric, jeffhoogland
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2945
Cedric BAIL [Sat, 15 Aug 2015 10:43:05 +0000 (12:43 +0200)]
view_list: small optimization reducing memory consumption using Eo_Event array of callbacks.
Now that smart callback have been converted to Eo_Event to, there is a lot of place in
our code base where we can do this easy memory optimization.
Jaehwan Kim [Fri, 14 Aug 2015 14:59:06 +0000 (23:59 +0900)]
focus: add the comment about focus origin property.
Anand [Fri, 14 Aug 2015 06:21:02 +0000 (09:21 +0300)]
elm_gengrid:Added Eolian changes in gengrid reorder Api
Summary:
Modified gengrid reorder Api's(elm_gengrid_reorder_mode_start, elm_gengrid_reorder_mode_stop,
elm_gengrid_reorder_type_set) in Eolian format.
Test Plan: elementry_test->gengrid->gengrid_focus
Reviewers: seoz, raster, Hermet, JackDanielZ
Subscribers: cedric, JackDanielZ, mvsovani, singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2510
Yeshwanth Reddivari [Fri, 14 Aug 2015 05:50:30 +0000 (11:20 +0530)]
Gengrid: Set focus after item looping
Summary:
After item looping, Gengrid item was getting selected.
So, checked for item_select_on_focus_disable flag and
accordingly set focus state or selected state of Gengrid item.
@fix
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Reviewers: raster, Hermet, singh.amitesh, SanghyeonLee
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2937
Mike Blumenkrantz [Thu, 13 Aug 2015 19:45:19 +0000 (15:45 -0400)]
cnp: redo wayland drop to nul terminate for text_uri drops and free on every drop
@fix
Jérémy Zurcher [Thu, 13 Aug 2015 19:41:27 +0000 (21:41 +0200)]
win: declare elm_win_wm_rotation_available_rotations_set
this should not have been removed in a0fdbad
Mike Blumenkrantz [Thu, 13 Aug 2015 19:27:14 +0000 (15:27 -0400)]
cnp: only nul terminate wayland drops for text type drops
also move data allocation into block where dropping is guaranteed
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 19:18:55 +0000 (15:18 -0400)]
cnp: end wayland drag on allocation failure
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 19:10:52 +0000 (15:10 -0400)]
cnp: pass wayland drop event size to handler, do not nul terminate drop data
performing strlen() on potential non-string data is not recommended and can
even lead to crashes. nul terminating non-string data is pointless and enables
bad application behavior such as calling strlen() on potentially non-string data
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 18:51:17 +0000 (14:51 -0400)]
cnp: fix wayland drop format selection
previously the drop format was chosen in a manner unrelated to what
the offered format was, leading to applications receiving either the correct
data with the wrong format, the wrong data with the wrong format, or
the wrong data with the correct format. by comparing the drop handler
types with the offered type and ensuring that there is a match, the
correctness of the format that the application receives is more reliable
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 18:49:28 +0000 (14:49 -0400)]
cnp: initialize Elm_Selection_Data.action for wayland drops
wayland drops are probably always copy, though there's no real functional
equivalent for the x11 meaning of this
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 18:48:35 +0000 (14:48 -0400)]
cnp: init wayland dnd handlers upon creating the first drop target
previously this would only init when the app was initiating the drag,
which would result in an app being unable to receive drags
@fix
Daniel Kolesa [Thu, 13 Aug 2015 15:46:57 +0000 (16:46 +0100)]
win: convert docs
With this, documentation conversion in elm is complete.
Daniel Kolesa [Thu, 13 Aug 2015 15:05:38 +0000 (16:05 +0100)]
gengrid: convert docs
Daniel Kolesa [Thu, 13 Aug 2015 13:21:49 +0000 (14:21 +0100)]
layout: convert docs
Carsten Haitzler (Rasterman) [Thu, 13 Aug 2015 10:26:52 +0000 (19:26 +0900)]
elm theme - conformant - fix to have proper min size of conformant
conformant would ignore min size of content (and propagate min size
to paent widget - eg window). this was just wrong. remove fixed here
(also align is useless as that is a default).
@fix
Jaehwan Kim [Thu, 13 Aug 2015 04:45:21 +0000 (13:45 +0900)]
focus: item focus moves by geometry.
In the widget code, focus origin is added. It can know
the focus movement is originated by which action.
The widgets can choose the item focus moves to last focused item
or geometrically nearby item by focus origin.
In gengrid, focus moves to last focused item if focus origin is
ELM_FOCUS_REVERT. It moves to nearby item if focus origin is from
ELM_FOCUS_UP to ELM_FOCUS_LEFT.
TODO: widgets have items should add the direction feature if it
want the focus to move to nearby item.
@feature
Jaehwan Kim [Thu, 13 Aug 2015 04:32:43 +0000 (13:32 +0900)]
test_gengrid: change the min size of gengrid
Amitesh Singh [Wed, 12 Aug 2015 18:13:29 +0000 (23:43 +0530)]
entry: fix since tag for entry_input_panel_show_on_demand_set()
Daniel Kolesa [Wed, 12 Aug 2015 16:12:16 +0000 (17:12 +0100)]
map: convert docs
Chris Michael [Wed, 12 Aug 2015 14:18:41 +0000 (10:18 -0400)]
elementary: Fix Copy and Paste test to actually paste clipboard text
Summary: The Elm Copy and Paste test was not actually pasting the
copied text into the entry when the Paste button was clicked. This
patch fixes that issue.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Wed, 12 Aug 2015 12:45:30 +0000 (13:45 +0100)]
datetime: convert docs
Daniel Kolesa [Wed, 12 Aug 2015 11:45:31 +0000 (12:45 +0100)]
web: convert docs
Daniel Kolesa [Wed, 12 Aug 2015 11:22:14 +0000 (12:22 +0100)]
genlist_item: convert docs
Jaehwan Kim [Wed, 12 Aug 2015 08:25:15 +0000 (17:25 +0900)]
focus: add the focus region show mode
When the focus is move to the object in scroller, it is scrolled
to show the focus region as a widget.
If the focus region want to be shown as an item,
set the mode ELM_FOCUS_REGION_SHOW_ITEM.
If then, it will be scrolled as an item.
TODO: Widgets have items are added on_focus_region function.
@feature
Dave Andreoli [Wed, 12 Aug 2015 07:15:09 +0000 (09:15 +0200)]
Fix docs for elm_object_tooltip_orient_set
The function is not visible in docs,
this should make it visible
Jaehwan Kim [Wed, 12 Aug 2015 02:09:14 +0000 (11:09 +0900)]
gengird: change focus move mechanism in gengrid.
This commit is related to
4d553d2bcf2157053433994ca3facb56bd670da9.
It doesn't work if item_select_on_focus_disable is 1.
So _item_focus_down is changed like _item_single_select_down.
@fix
Daniel Kolesa [Tue, 11 Aug 2015 15:57:08 +0000 (16:57 +0100)]
slider: convert docs
Daniel Kolesa [Tue, 11 Aug 2015 14:27:06 +0000 (15:27 +0100)]
toolbar_item: convert docs
Tom Hacohen [Tue, 11 Aug 2015 13:46:41 +0000 (14:46 +0100)]
Toolbar: migrate docs.
Jyotiprakash Sahoo [Tue, 11 Aug 2015 13:08:21 +0000 (22:08 +0900)]
gengrid: extends D2418 to horizontal mode.
Summary:
do not return yet in case of edge items if looping
is disabled. try to select/focus last item.
Signed-off-by: Jyotiprakash Sahoo <jp.sahoo@samsung.com>
@fix
Test Plan: elementary_test -> Gengrid 2
Reviewers: raster, singh.amitesh, cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2865
Jaehwan Kim [Tue, 11 Aug 2015 09:56:52 +0000 (18:56 +0900)]
scroller: fix the focus move bug in scroller.
When the focused object is out of the viewport and the key direction
is only the direction focus is out, it should find the next focus.
@fix
Tom Hacohen [Tue, 11 Aug 2015 11:48:37 +0000 (12:48 +0100)]
Interface scrollable: migrate docs.
Tom Hacohen [Tue, 11 Aug 2015 08:02:09 +0000 (09:02 +0100)]
List: migrate docs.
Tom Hacohen [Tue, 11 Aug 2015 07:35:32 +0000 (08:35 +0100)]
Multibutton entry: migrate docs.
Mike Blumenkrantz [Mon, 10 Aug 2015 20:19:56 +0000 (16:19 -0400)]
cnp test: add callback to print info when paste button is clicked
Mike Blumenkrantz [Mon, 10 Aug 2015 20:07:41 +0000 (16:07 -0400)]
cnp: add docs for Elm_Selection_Data members
Tom Hacohen [Mon, 10 Aug 2015 17:37:13 +0000 (18:37 +0100)]
Image: migrate docs.
Tom Hacohen [Mon, 10 Aug 2015 14:00:27 +0000 (15:00 +0100)]
Prefs: migrate docs.
Tom Hacohen [Mon, 10 Aug 2015 13:17:49 +0000 (14:17 +0100)]
Spinner: migrate docs.
Tom Hacohen [Mon, 10 Aug 2015 11:51:51 +0000 (12:51 +0100)]
Genlist: migrate one missing doc string.
Tom Hacohen [Mon, 10 Aug 2015 11:51:00 +0000 (12:51 +0100)]
Gengrid item: migrate docs.
Stefan Schmidt [Mon, 10 Aug 2015 10:55:09 +0000 (12:55 +0200)]
build: Exclude some more files from coverage as they are not in the correct path
These files come from some modules in src/modules while we set out base dir to
src/lib. In result these files are search for in src/lib and not found. In the
long term we want to find out how to collect them as well but for now a working
coverage is already good.
Overall coverage rate:
lines......: 18.1% (12596 of 69412 lines)
functions..: 18.6% (1766 of 9500 functions)
Will work on getting these run by jenkins once it is back.
Dave Andreoli [Sun, 9 Aug 2015 16:59:14 +0000 (18:59 +0200)]
Add a new (failing) test for table padding
This test expose a bug in table as explained in T2655
Dave Andreoli [Sat, 8 Aug 2015 15:08:45 +0000 (17:08 +0200)]
Add a no-wrap mode to the "Entry Style Default" test
I'm trying to reproduce an issue, not spotted by this,
but can still be usefull.
Daniel Kolesa [Fri, 7 Aug 2015 14:54:50 +0000 (15:54 +0100)]
glview: convert docs
Tom Hacohen [Fri, 7 Aug 2015 14:48:51 +0000 (15:48 +0100)]
Progressbar: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 14:47:32 +0000 (15:47 +0100)]
genlist: convert docs
Tom Hacohen [Fri, 7 Aug 2015 14:36:47 +0000 (15:36 +0100)]
Segment control: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 14:19:21 +0000 (15:19 +0100)]
Index: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 14:04:10 +0000 (15:04 +0100)]
Widget item: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:37:49 +0000 (14:37 +0100)]
Inwin: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 13:44:49 +0000 (14:44 +0100)]
gesture_layer: convert and fix docs
Tom Hacohen [Fri, 7 Aug 2015 13:30:44 +0000 (14:30 +0100)]
Interface atspi image: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:29:11 +0000 (14:29 +0100)]
Interface atspi value: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:28:40 +0000 (14:28 +0100)]
Interface atspi selection: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:28:13 +0000 (14:28 +0100)]
Interface atspi component: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:26:50 +0000 (14:26 +0100)]
Interface atspi action: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:25:45 +0000 (14:25 +0100)]
Interface atspi text: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 13:24:37 +0000 (14:24 +0100)]
popup: convert docs
Tom Hacohen [Fri, 7 Aug 2015 13:16:55 +0000 (14:16 +0100)]
Widget: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:10:49 +0000 (14:10 +0100)]
Label: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 13:08:01 +0000 (14:08 +0100)]
table: convert docs
Daniel Kolesa [Fri, 7 Aug 2015 12:50:21 +0000 (13:50 +0100)]
slideshow: convert docs
Daniel Kolesa [Fri, 7 Aug 2015 12:30:06 +0000 (13:30 +0100)]
flip: convert docs
Tom Hacohen [Fri, 7 Aug 2015 12:30:05 +0000 (13:30 +0100)]
Naviframe: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 12:19:35 +0000 (13:19 +0100)]
Interface fileselector: migrate docs.
Vivek Ellur [Fri, 7 Aug 2015 12:04:27 +0000 (13:04 +0100)]
elm_entry: Convert eo docs to new format
Summary:
Changed elm_entry.eo docs to the new format
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric, q66
Reviewed By: q66
Differential Revision: https://phab.enlightenment.org/D2924
Stefan Schmidt [Fri, 7 Aug 2015 09:00:25 +0000 (11:00 +0200)]
po: Update po files
Amitesh Singh [Fri, 7 Aug 2015 08:27:30 +0000 (17:27 +0900)]
intf scroll: handle wheel logic in post event cb.
Summary:
@Fix
Resolves: T2216
Reviewers: seoz, raster, JackDanielZ, Hermet
Reviewed By: Hermet
Subscribers: cedric, eagleeye, SanghyeonLee, seoz, sachin.dev
Maniphest Tasks: T2216
Differential Revision: https://phab.enlightenment.org/D2393
Conflicts:
src/lib/elm_interface_scrollable.c
woochan lee [Fri, 7 Aug 2015 07:58:54 +0000 (16:58 +0900)]
spinner: Add to support spinner value %d format.
Summary:
When user set min max as 50, 150 with %d format, then value set as 100.
The spinner value set as '0'
Because the sd->val type is double.
Spinner entry has same problem.
@fix
Test Plan:
Set spinner format as %d.
Check the spinner value.
It's not supported.
Reviewers: Jaehyun_Cho, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2898
Conflicts:
src/lib/elm_spinner.c
Umesh Tanwar [Fri, 7 Aug 2015 07:51:41 +0000 (16:51 +0900)]
Theme: Scroller.edc-Improvement in left/right/top/bottom arrow behavior.
Summary:
When the scroller size changes by dragging the
corners, the calculations will miss the condition "x+w == x1 + w1".
This is because of format specific computer calculations. So,
improvisation is made in comparisons.
@ fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan:
elementary_test -> scroller -> scroll to the extreme right (right arrow brightness changes).
Now, drag the lower right corner to increase the width of scroller. Drag the corner slowly to see the issue clearly.
The arrow brightness changes alternatively, instead the hbar is positioned to the extreme right.
Reviewers: Hermet, cedric, raster
Subscribers: singh.amitesh, eagleeye, SanghyeonLee, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2796
Sung-Taek Hong [Fri, 7 Aug 2015 07:42:29 +0000 (16:42 +0900)]
elm_toolbar: fix icon_size to consider edje base scale
Summary:
When icon is set, icon size is calculated without considering
edje base scale. This can lead to a miscalculation when
base scale is set other than 1.0.
@fix
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2798
ChunEon Park [Fri, 7 Aug 2015 06:30:49 +0000 (15:30 +0900)]
win: remove usage of deprecated api.
ChunEon Park [Fri, 7 Aug 2015 06:29:49 +0000 (15:29 +0900)]
win: code refactoring.
simplify code.
Youngbok Shin [Fri, 7 Aug 2015 06:15:45 +0000 (15:15 +0900)]
multibuttonentry/spinner: Fix memory leak when eina_strbuf_string_steal is misused.
Summary:
_elm_access_say() does not free the given text.
But, the text from eina_strbuf_string_steal() is not cared
from outside of _elm_access_say(), too.
It should be changed to eina_strbuf_string_get().
Test Plan: N/A
Reviewers: cedric, woohyun, kimcinoo, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2918
ChunEon Park [Fri, 7 Aug 2015 06:11:59 +0000 (15:11 +0900)]
config: add missing since tag in doc.
jiin.moon [Fri, 7 Aug 2015 06:10:02 +0000 (15:10 +0900)]
elm_win: add new condition about engine set when generate the elm_win object
Summary:
Calling the elm_config_accel_preference_get api with "none" as parameter,
it means user does not want to use acceleration.
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2920
Stefan Schmidt [Wed, 22 Apr 2015 15:16:15 +0000 (17:16 +0200)]
build: Enable make check run during distcheck
Hand over the regular tests configure option for the internal distcheck run.
Fixes T2028
Stefan Schmidt [Thu, 6 Aug 2015 13:55:02 +0000 (15:55 +0200)]
tests: Correct ATSPI role check for popup.
ctxpopup is using ELM_ATSPI_ROLE_POPUP_MENU while the normal popup uses
ELM_ATSPI_ROLE_NOTIFICATION.
ref T2028
Stefan Schmidt [Thu, 23 Apr 2015 09:27:06 +0000 (11:27 +0200)]
elm_module: Load not installed modules from build dir with ELM_RUN_IN_TREE
If we want to run from the local build dir without make install before
elm_module would fail to load the modules as it is expecting them in the
final install location.
We can now change this by setting ELM_RUN_IN_TREE to force it load the not
yet installed modules.
ref T2028
Stefan Schmidt [Wed, 22 Apr 2015 15:03:18 +0000 (17:03 +0200)]
tests/build: Make sure tests are finding the theme file
Our tests require a theme file. So far they picked this just from the system
where it was installed to in a previous run. We have situations where this would
not work though. Running make check before install on a new system or during
distcheck comes to mind.
With AM_TESTS_ENVIRONMENT we make that the theme is also looked for in the not
yet installed builddir.
Thanks to Lukasz Stanislawski for pointing me to this.
ref T2028
Tom Hacohen [Thu, 6 Aug 2015 14:12:27 +0000 (15:12 +0100)]
Eo files docs: replace all @c/@p with $.
This is part of the new syntax.
Tom Hacohen [Thu, 6 Aug 2015 14:11:22 +0000 (15:11 +0100)]
Eo files: Replace all occurances of EINA_TRUE/FALSE to true/false.
Tom Hacohen [Thu, 6 Aug 2015 14:05:42 +0000 (15:05 +0100)]
Elm segment control item: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:59:32 +0000 (14:59 +0100)]
Elm index item: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:56:47 +0000 (14:56 +0100)]
Elm slideshow item: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:53:50 +0000 (14:53 +0100)]
Atspi accessible: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:52:01 +0000 (14:52 +0100)]
Atspi widget action: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:48:25 +0000 (14:48 +0100)]
Hoversel item: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:47:09 +0000 (14:47 +0100)]
Hoversel: migrate docs.
Tom Hacohen [Thu, 6 Aug 2015 13:30:34 +0000 (14:30 +0100)]
Eo files: Use Elm.Widget_Item instead of Elm_Object_Item.
This is the correct Eolian type. Elm_Object_Item is dead.
Tom Hacohen [Thu, 6 Aug 2015 13:25:44 +0000 (14:25 +0100)]
Multibuttonentry item: Migrate docs to new eolian format.
Jaehyun Cho [Thu, 6 Aug 2015 05:59:06 +0000 (14:59 +0900)]
elm_config: Add flag to control pushing naviframe prev button automatically.
It is decided that the naviframe prev button is automatically pushed or not
by the flag "naviframe_prev_btn_auto_pushed" in config.
@feature
Daniel Hirt [Thu, 6 Aug 2015 06:12:24 +0000 (09:12 +0300)]
entry: Add null safety check in _elm_entry_entry_paste function.
Summary: Add null safety check for the given text.
Reviewers: tasn, woohyun, thiepha, herdsman
Reviewed By: herdsman
Subscribers: thiepha, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2868
Daniel Kolesa [Wed, 5 Aug 2015 11:27:34 +0000 (12:27 +0100)]
configure: we can actually safely imply -ldl is only needed on linux
Daniel Kolesa [Wed, 5 Aug 2015 11:24:40 +0000 (12:24 +0100)]
configure: the BSDs all supply the dlfcn funcs without -ldl
Daniel Kolesa [Wed, 5 Aug 2015 11:01:44 +0000 (12:01 +0100)]
mapbuf: convert docs