Adrian Szyndela [Fri, 17 Jan 2020 11:22:57 +0000 (12:22 +0100)]
Merge 2.54.1 into tizen
Change-Id: I9e6959ba57b540d6ab763c967b45f6434571a830
Adrian Szyndela [Fri, 17 Jan 2020 11:22:40 +0000 (12:22 +0100)]
Merge 2.54.0 into tizen
Change-Id: I3a8c6dc9cda35dd0701c68339178ad298b343ebd
Adrian Szyndela [Fri, 17 Jan 2020 11:22:03 +0000 (12:22 +0100)]
Merge 2.53.7 into tizen
Change-Id: I99922bc8d7fdbd1668f408eadfd25bbb5948e7b0
Adrian Szyndela [Fri, 17 Jan 2020 11:21:34 +0000 (12:21 +0100)]
Merge 2.53.6 into tizen
Change-Id: Ibcc608686e6fc65137383be1dae173c355c8480b
Adrian Szyndela [Fri, 17 Jan 2020 11:21:04 +0000 (12:21 +0100)]
Merge 2.53.5 into tizen
Change-Id: Ice0babed16cb3ec467030e4bdce98b43e916d202
Adrian Szyndela [Fri, 17 Jan 2020 11:18:41 +0000 (12:18 +0100)]
Merge 2.53.4 into tizen
Change-Id: I92c3ee01a88e92717ab46ca59f3323a6b6a895c6
Adrian Szyndela [Fri, 17 Jan 2020 11:15:05 +0000 (12:15 +0100)]
Merge 2.53.3 into tizen
Change-Id: Iacdfcab900941fbdd53a919b0ecfda0cafeca486
Adrian Szyndela [Mon, 5 Dec 2016 14:38:08 +0000 (15:38 +0100)]
fix for race condition in watching names in kdbus env.
This brings back a necessary fix for watching names in kdbus environment.
The scenario for race condition is as follows:
1. Client calls g_bus_watch_name for a name
2. g_bus_watch_name subscribes for NameOwnerChanged for the name
3. g_bus_watch_name gets name owner for the name
4. the name appears on the bus
5. NameOwnerChanged is received
For non-kdbus system, dbus-daemon is a process which handles names,
sends NameOwnerChanged signals and handles GetNameOwner requests.
Because of its nature, it orders events. On the other side, D-Bus also
guarantees order of messages. Thus, the client will surely get the following
messages in order:
1. GetNameOwner response
2. NameOwnerChanged signal
Some part in it takes client->initialized field. Because the order is
guaranteed, gdbus ignores NameOwnerChanged signals until GetNameOwner
response is received.
For kdbus system, there is no dbus-daemon. NameOwnerChanged signal is sent
by kernel. The response for GetNameOwner is taken synchronously by ioctl.
Before the fix, GetNameOwner response was taken, and put into the receiving
queue artificially. However, if the name appeared on the bus just after ioctl,
the NameOwnerChanged signal could appear before the GetNameOwner response was
processed. It resulted in ignoring the signal. The client was left with
"no name on the bus" state, although the name was already present.
The fix ensures the order of events processing - GetNameOwner response is
processed synchronously, any subsequent NameOwnerChanged signals are not
ignored anymore.
Change-Id: I11fa92a6dae62cb3bdaa4159db0da160752063d1
(cherry picked from commit
f1f2e5e4df63f06cac53148e5c91a27a56eea9ca)
Adrian Szyndela [Fri, 17 Jan 2020 11:07:07 +0000 (12:07 +0100)]
Revert name watching race condition fix
This reverts three commits aimed to fix a race condition:
a0dc33df372eb7a54a89221b97db753d560fcfd7
dc8a71bcd7e904a6419f8e7cd1a772d8a066c95f
75ab298452793ea20ab1daa255602200bb309ac8
The race condition was fixed in upstream in a different way, so we're
importing it.
Change-Id: Icab842f507b033ef83c984cdc30004a681c69c43
Adrian Szyndela [Fri, 17 Jan 2020 11:14:16 +0000 (12:14 +0100)]
Merge 2.53.2 into tizen
Change-Id: If32a06713d2d82d60b99b1480cdffc48aeb4a4de
Adrian Szyndela [Fri, 17 Jan 2020 10:44:32 +0000 (11:44 +0100)]
Merge 2.53.1 into tizen
Change-Id: I042296dc6c0260aef55f19927dc5a43a79b200ba
Adrian Szyndela [Fri, 17 Jan 2020 10:43:30 +0000 (11:43 +0100)]
Merge 2.52.3 into tizen
Change-Id: I8958c4fafd2d751c6440a082eacdc8bf302cd160
Ernestas Kulik [Tue, 29 Jan 2019 08:50:46 +0000 (09:50 +0100)]
[Tizen_6_build] gdbus: Avoid printing null strings
This mostly affects the 2.56 branch, but, given that GCC 9 is being
stricter about passing null string pointers to printf-like functions, it
might make sense to proactively fix such calls.
gdbusauth.c: In function '_g_dbus_auth_run_server':
gdbusauth.c:1302:11: error: '%s' directive argument is null
[-Werror=format-overflow=]
1302 | debug_print ("SERVER: WaitingForBegin, read '%s'",
line);
|
gdbusmessage.c: In function ‘g_dbus_message_to_blob’:
gdbusmessage.c:2730:30: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
2730 | tupled_signature_str = g_strdup_printf ("(%s)", signature_str);
|
Change-Id: I8ce45f2a4759df60b8ed071cfcec4aa455563941
Signed-off-by: Hyunjee Kim <hj0426.kim@samsung.com>
Philip Withnall [Wed, 24 Jul 2019 13:17:02 +0000 (14:17 +0100)]
glib: Stop using g_get_current_time() in various places
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Change-Id: I5baa3ebebdfd84b94fb32633c990905213421fa6
Helps: #1438
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
sanghyeok.oh [Tue, 23 Jul 2019 10:37:28 +0000 (19:37 +0900)]
kdbus: modified to check null value
Change-Id: I630159453a711f9951ab09535c5417ec9040a0b9
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Adrian Szyndela [Fri, 19 Jul 2019 08:27:28 +0000 (10:27 +0200)]
kdbus: fix computing bloom filters
The bloom filters computing had been implemented in the past, basing
on systemd. However, the reimplementation introduced two bugs:
- no clearing of 'p' variable;
- clearing of hash_index variable in a wrong place.
This fixes the bugs.
The same applies to libdbus.
Change-Id: I92d5fe7f270306c96e8a38c96d0a06d38b8e59b1
Adrian Szyndela [Thu, 27 Jun 2019 14:04:29 +0000 (16:04 +0200)]
gkdbus: async StartServiceByName handled by GTask
Change-Id: I65b29cc58c9a275dca3018309c06d25eaf6d6166
sanghyeok.oh [Tue, 19 Feb 2019 06:47:41 +0000 (15:47 +0900)]
kdbus: modified to support asynchronous StartServiceByName
Change-Id: I57c30fb86b1ec266037a4583ef64888ca92f2bc9
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Ondrej Holy [Thu, 23 May 2019 08:41:53 +0000 (10:41 +0200)]
[CVE-2019-12450]gfile: Limit access to files when copying
file_copy_fallback creates new files with default permissions and
set the correct permissions after the operation is finished. This
might cause that the files can be accessible by more users during
the operation than expected. Use G_FILE_CREATE_PRIVATE for the new
files to limit access to those files.
Change-Id: Id071a47323fcd0690dec6a5d519d5ab4f2f43562
Signed-off-by: Hyunjee Kim <hj0426.kim@samsung.com>
(cherry picked from commit
ec54d211518bf3c2f397f565088a7054219f194e)
sanghyeok.oh [Wed, 27 Mar 2019 00:17:15 +0000 (09:17 +0900)]
kdbus: svace fix
Change-Id: I8166bd83bcd4b5fbca516daa2f1917437820ea8c
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Adrian Szyndela [Thu, 14 Mar 2019 12:46:10 +0000 (13:46 +0100)]
kdbus: share fd and pool with libdbuspolicy
This uses new functionality of libdbuspolicy: using client's pool and fd.
This way libdbuspolicy doesn't have to create its own connection,
and what is more important it doesn't have to create its own 1MB pool.
This is at the cost of using client's pool for receiving responses
to ioctl(KDBUS_CMD_GET_CONN_INFO), which are small.
Change-Id: If31a3636be87f04559781f2ba68cb05c1c18d865
Adrian Szyndela [Thu, 14 Mar 2019 11:55:47 +0000 (12:55 +0100)]
kdbus: check policy after opening, before Hello
This moves checking access policy to the point after
the kdbus file descriptor is open, just before "Hello" is performed.
Now, it reflects standard process a bit more.
The standard process is:
- open fd (e.g. socket);
- check authentication, if needed and possible;
- connect to the bus (say hello).
In kdbus, we have only:
- open kdbus fd;
- connect to the bus (ioctl KDBUS_CMD_HELLO).
Calling libdbuspolicy for authentication fits between the two.
Additionally, and most importantly, this is required to share
the connection between gio and libdbuspolicy in the future.
Change-Id: Iee49b36e482a099d061dff4a8ba1826c2a53bb9a
Beniamino Galvani [Sat, 30 Sep 2017 09:26:29 +0000 (11:26 +0200)]
gio: fix race condition in GDBusObjectManagerClient
priv->map_object_path_to_object_proxy must be protected to avoid
concurrent access by multiple threads. Move the hash table insertion
into the critical section.
https://bugzilla.gnome.org/show_bug.cgi?id=788368
Change-Id: I0fc7b7ab9edea681cc71b3c36cc0b5cebb6a1cf8
Lars Uebernickel [Thu, 28 Jan 2016 14:39:18 +0000 (15:39 +0100)]
gdbus: fix use-after-free
g_dbus_connection_call_internal() accesses the user data it passes to
g_dbus_connection_send_message_with_reply() after the call. That data
might be freed already in the case that the callback is called
immediately.
Fix this by removing the 'serial' field from the user data altogether
and fetch the serial from the message in the callback.
https://bugzilla.gnome.org/show_bug.cgi?id=748263
Change-Id: I6c6406f4782bbaeb19dad6b4ae08b3375592d3bc
Jonghwa Lee [Tue, 12 Feb 2019 14:32:44 +0000 (23:32 +0900)]
kdbus: Fix memory leakage in _g_kdbus_StartServiceByName()
GDBusMessage isn't freed after use.
Change-Id: I6f4b8b01dc6e8d3966ca8b8e9fde3d613635ab4d
Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
(cherry picked from commit
6097bfc743d6c9d9c1005b3fe1cf029bf934dfac)
Karol Lewandowski [Wed, 7 Nov 2018 10:28:50 +0000 (10:28 +0000)]
Merge "Remove kdbus interface header" into tizen
Michal Bloch [Mon, 5 Nov 2018 12:59:09 +0000 (13:59 +0100)]
Remove kdbus interface header
kdbus.h is now provided with other linux kernel headers.
Change-Id: I48514dce66e7edf309724765c0dd72707a5a47b8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
DongHun Kwak [Tue, 30 Oct 2018 07:36:07 +0000 (16:36 +0900)]
CVE-2018-16429
When formatting the error messages for markup parsing errors, the parser
was unconditionally reading a UTF-8 character from the input buffer —
but the buffer might end with a partial code sequence, resulting in
reading off the end of the buffer by up to three bytes.
Fix this and add a test case, courtesy of pdknsk.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://gitlab.gnome.org/GNOME/glib/issues/1462
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Occurrence Version] N/A
[Problem] Security Patch
[Cause & Measure]
[Checking Method]
[Team] Open Source Management and Setting Part
[Developer] dh0128.kwak
[Solution company] Samsung
[Change Type] N/A
Change-Id: If7bc858e6de684d5a571b57bd2b3d2a8c48cfc63
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Tue, 30 Oct 2018 07:32:47 +0000 (16:32 +0900)]
CVE-2018-16428
If something which looks like a closing tag is left unfinished, but
isn’t paired to an opening tag in the document, the error handling code
would do a null pointer dereference. Avoid that, at the cost of
introducing a new translatable error message.
Includes a test case, courtesy of pdknsk.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://gitlab.gnome.org/GNOME/glib/issues/1461
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Occurrence Version] N/A
[Problem] Security patch
[Cause & Measure]
[Checking Method]
[Team] Open Source Management and Setting Part
[Developer] dh0128.kwak
[Solution company] Samsung
[Change Type] N/A
Change-Id: Icd7c1bf8da55b501d9471df5ad18e7c7b0892d6b
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
sanghyeok.oh [Wed, 8 Aug 2018 02:47:31 +0000 (11:47 +0900)]
kdbus: svace fix
Change-Id: I5618c10d9c6c2daa6cbd9c8285becf154d667c44
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Aleksy Barcz [Tue, 8 May 2018 09:36:16 +0000 (11:36 +0200)]
kdbus: check policy first, only then open kdbus
A process shouldn't hold an open kdbus descriptor, if according to
security policy this process has no rights to open the bus at all.
Change-Id: Icd5a0c8fd68e1a7ec0e419f77272d279cf3289f6
Aleksy Barcz [Tue, 24 Apr 2018 11:08:57 +0000 (13:08 +0200)]
fix for incorrect session bus descriptor lookup
Bugfix for error handling on dbus-daemon systems.
If get_session_address_platform_specific failed, both error and return value would be set,
resulting in subsequent error overwrite and a glib warning.
Change-Id: Ic0e42ed6868fc9dd71965ce23e68c8dbc8596ff5
Aleksy Barcz [Fri, 13 Apr 2018 07:59:45 +0000 (09:59 +0200)]
kdbus: patch for error=NULL argument
Fixes segfault in *error dereference introduced in:
"kdbus: make access error behaviour consistent with dbus-daemon".
Change-Id: I4790cac9c051927d6c9f03c665ef5f2f7650294c
DongHun Kwak [Mon, 9 Apr 2018 07:39:40 +0000 (16:39 +0900)]
ASAN patch ( add pie compile option )
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Occurrence Version] N/A
[Problem] asan build fail
[Cause & Measure] add pie option
[Checking Method] build test
[Team] Open Source Management and Setting Part
[Developer] dh0128.kwak
[Solution company] Samsung
[Change Type] N/A
Change-Id: I558c2de2174d9215538b5f771f1d5d7213ff076e
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Aleksy Barcz [Thu, 15 Mar 2018 11:43:28 +0000 (12:43 +0100)]
kdbus: make access error behaviour consistent with dbus-daemon
Bugfix. When used with dbus-daemon, when an AccessDenied or ServiceUnknown
error occurs, gdbus returns a dbus error message to the sender (synchronously
or asynchronously) and doesn't set GError. Up to now the kdbus implementation
didn't return any error message and did set GError, which made the following
low-level functions behaviour inconsistent between dbus-daemon and kdbus:
g_dbus_connection_send_message_with_reply_sync
g_dbus_connection_send_message_with_reply
g_dbus_connection_send_message_with_reply_finish
This patch makes this behaviour consistent. Any code that relied on the inconsistent
behaviour should be corrected. The high-level function interface, returning GVariants
is NOT affected by this change.
Change-Id: I60cd4822ccef0e0fc0d7b99244f4ceb03512b97f
Jonghwa Lee [Thu, 25 Jan 2018 08:28:33 +0000 (17:28 +0900)]
glib2.spec: Change -mimplicit-it option to ARM
If -mimplicit-it option is set to thumb, then it will shows below warning logs.
[ 135s] {standard input}:4839: Warning: conditional outside an IT block for Thumb.
[ 135s] {standard input}:4850: Warning: conditional outside an IT block for Thumb.
[ 135s] {standard input}:4872: Warning: conditional outside an IT block for Thumb.
[ 135s] {standard input}:4899: Warning: conditional outside an IT block for Thumb.
[ 135s] {standard input}:4973: Warning: conditional outside an IT block for Thumb.
Since output code was changed to ARM state ('switch compilation mode fom Thumb to ARM'),
-mimplicit-it option also should be changed to ARM mode.
Change-Id: I244f92313a89a70236c3a571847ab6bbd918d823
Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
(cherry picked from commit
231ca1b5b0e3a0d4ea2afea70cb3a6bd02d58150)
DongHun Kwak [Thu, 18 Jan 2018 04:48:03 +0000 (13:48 +0900)]
Add ASLR Patch
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Occurrence Version] N/A
[Problem] not adjust pie compile option
[Cause & Measure] add compile option at spec file
[Checking Method]
[Team] Open Source Management and Setting Part
[Developer] dh0128.kwak
[Solution company] Samsung
[Change Type] N/A
Change-Id: I2a0741fb7c31ff14fc9fce5ab7226fe436757a11
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
MyoungJune Park [Tue, 28 Nov 2017 00:32:32 +0000 (00:32 +0000)]
Merge "glog: fix crash on Linux without stderr stream" into tizen
INSUN PYO [Fri, 18 Aug 2017 04:42:44 +0000 (13:42 +0900)]
glog: fix crash on Linux without stderr stream
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:58
1 0xb67c43f0 in __GI_abort () at abort.c:89
2 0xb69ee9d8 in _g_log_abort (breakpoint=2, breakpoint@entry=1) at gmessages.c:548
3 0xb69ef692 in g_logv (log_domain=0xb6a1dfc8 "GLib", log_level=-
1254563840, log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0xb6a26a48 "%s: assertion '%s' failed", args=..., args@entry=...) at gmessages.c:1357
4 0xb69ef728 in g_log (log_domain=<optimized out>, log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=0xb6a26a48 "%s: assertion '%s' failed") at gmessages.c:1398
5 0xb69efa5a in g_return_if_fail_warning (log_domain=<optimized out>, pretty_function=<optimized out>, expression=<optimized out>) at gmessages.c:2687
6 0xb69efe7c in g_log_writer_is_journald (output_fd=-1) at gmessages.c:2122
7 0xb69f02a2 in g_log_writer_default (log_level=G_LOG_LEVEL_CRITICAL, fields=0xbedc9d00, n_fields=4, user_data=0x0) at gmessages.c:2584
8 0xb69ef21a in g_log_structured_array (log_level=G_LOG_LEVEL_CRITICAL, fields=0xbedc9d00, n_fields=4) at gmessages.c:1933
9 0xb69ef47e in g_log_default_handler (log_domain=0xb6a1dfc8 "GLib", log_level=G_LOG_LEVEL_CRITICAL, message=<optimized out>, unused_data=<optimized out>) at gmessages.c:3036
10 0xb69ef5fc in g_logv (log_domain=0xb6a1dfc8 "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0xb6a26a48 "%s: assertion '%s' failed", args=..., args@entry=...) at gmessages.c:1336
11 0xb69ef728 in g_log (log_domain=<optimized out>, log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=0xb6a26a48 "%s: assertion '%s' failed") at gmessages.c:1398
12 0xb69efa5a in g_return_if_fail_warning (log_domain=<optimized out>, pretty_function=<optimized out>, expression=<optimized out>) at gmessages.c:2687
If stderr is not associated with an output stream, the fileno(stderr) returned is -1.
So, g_return_if_fail_warning is recursively called and the abort occurs on the second call.
Change-Id: I417efda0bfafb45fadea5da1332dc56474f36405
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Adrian Szyndela [Mon, 6 Nov 2017 13:53:11 +0000 (14:53 +0100)]
kdbus: handle sending messages with any number of vectors
Bugfix. Sending function had an arbitrary limit for kdbus_msg structure size.
Any additional vector added 32 bytes to the structure. Due to the way glib
handles data, in some specific cases number of vectors could increase
significantly, eventually exhausting the limit.
The fix removes the arbitrary limit, exchanging it to standard system memory
limits, by precalculating and allocating needed space, instead of allocating
fixed amount of memory.
Change-Id: I5aa483e26f6bababababadd79422b7abe0b46b7d
INSUN PYO [Fri, 3 Nov 2017 05:38:46 +0000 (14:38 +0900)]
Modify indentation
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I6d8118bb36541bc8a17bbf915aafa68687e45e8c
Adrian Szyndela [Wed, 18 Oct 2017 09:30:14 +0000 (11:30 +0200)]
switch compilation mode fom Thumb to ARM
This is needed to be able to put uprobes in the library code as
the uprobes in current kernel versions work only with ARM code.
Change-Id: I0868bf63128900230c849cca48c5601d42b80bfa
DongHun Kwak [Tue, 17 Oct 2017 07:50:43 +0000 (16:50 +0900)]
Imported Upstream version 2.54.1
Change-Id: I4a93aff027ce3f995d04804f20e9f81eb5290c1c
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:19:28 +0000 (10:19 +0900)]
Imported Upstream version 2.54.0
Change-Id: I5389a495532472102dc0e8b2826e29e7d2c03d6d
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:17:14 +0000 (10:17 +0900)]
Imported Upstream version 2.53.7
Change-Id: I8b9315cea2a8fe73f3fbc91010836219d67b4dbf
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:13:49 +0000 (10:13 +0900)]
Imported Upstream version 2.53.6
Change-Id: If964220944e32c1b47c50784be38bcdd84514183
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:12:01 +0000 (10:12 +0900)]
Imported Upstream version 2.53.5
Change-Id: Ic5ebea56d852bf73b3c52afe342819e339412ef9
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:10:38 +0000 (10:10 +0900)]
Imported Upstream version 2.53.4
Change-Id: I17e5e677f01d881ae678eb79578dde29dd2950b3
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:08:39 +0000 (10:08 +0900)]
Imported Upstream version 2.53.3
Change-Id: I620ef00381ff01f0dd7c6d644b3c0a88e29aaedb
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:07:13 +0000 (10:07 +0900)]
Imported Upstream version 2.53.2
Change-Id: Ie5f62282cb6613e2c5cde213dd6b231f2c3ef0da
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 01:06:13 +0000 (10:06 +0900)]
Imported Upstream version 2.53.1
Change-Id: Ib0e6300c6063e8d638e99eb22b58ddebf7768e79
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 29 Sep 2017 00:42:48 +0000 (09:42 +0900)]
Imported Upstream version 2.52.3
Change-Id: If358c3502e4820a888b34011119821ea38b2b563
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Michal Bloch [Mon, 18 Sep 2017 12:05:52 +0000 (14:05 +0200)]
Fix build warnings.
Change-Id: I25b3cbbde5f4f8b7016556c2b9c203a743bb6632
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
INSUN PYO [Thu, 14 Sep 2017 02:08:15 +0000 (11:08 +0900)]
API: Deprecated Gdbus APIs in Tizen Public #2 - fix build error.
Many processes, such as aul, tlm and gli, generate the following error.
======================================================================
In file included from /usr/include/glib-2.0/gio/gio.h:50:0,
from corrupt.c:30:
/usr/include/glib-2.0/gio/gdbusaddress.h:29:51: fatal error: tizen.h: No such file or directory
include <tizen.h> /* for TIZEN_DEPRECATED_API */
======================================================================
To solve this problem, glib include own macro file.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Iea4077919fec54626b2ef063e2c5223025e95ac6
INSUN PYO [Tue, 12 Sep 2017 03:10:06 +0000 (12:10 +0900)]
API: Deprecated Gdbus APIs in Tizen Public
In Tizen Public, Gdbus APIs have been deprecated since Tizen 2.4.
This patch shows warning messages to Tizen Public SDK developers.
https://developer.tizen.org/development/api-references/native-application?redirect=https://developer.tizen.org/dev-guide/3.0.0/org.tizen.native.mobile.apireference/group__OPENSRC__GLIB__FRAMEWORK.html
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I07de7c48e6b94caa4d9f31af98b180a218d11275
sanghyeok.oh [Mon, 17 Jul 2017 06:00:49 +0000 (15:00 +0900)]
kdbus: libdbuspolicy: To perform policy check, pass unique name to libdbuspolicy
In case of signal broadcasting, message has null destination,
To perform policy check correctly, gdbus should pass unique name to libdbuspolicy as destination.
Change-Id: I563f7ad5ab99a9c91b5180350bb32259d3fed2b6
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
MyoungJune Park [Wed, 12 Jul 2017 08:32:03 +0000 (17:32 +0900)]
avoid compilation error from -Wshadow gcc option
- if arg name of an inline function at a header file is identical to
other simbol, gcc make warnings and turn it into failing build.
Change-Id: I73390d0d55574089d1a045be821edcbfc2a7a8f6
Signed-off-by: MyoungJune Park <mj2004.park@samsung.com>
sanghyeok.oh [Fri, 9 Jun 2017 07:16:13 +0000 (16:16 +0900)]
kdbus: pass sender to dbuspolicy1_check_out
Change-Id: I741f2dedc77654889362b3853728dba54a5cef0b
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Adrian Szyndela [Tue, 9 May 2017 08:16:53 +0000 (10:16 +0200)]
gkdbus bugfix: allow long names
D-Bus names, paths, interfaces, members may be longer than
127 characters now.
Change-Id: Id917c77f638d72fd0c7c618fe02a3181b57321b4
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Adrian Szyndela [Thu, 1 Jun 2017 11:08:22 +0000 (13:08 +0200)]
gkdbus: make error messages more consistent with libdbus
Change-Id: I5b21152f84ccc43ae8d72fe83e9e6d32aba58002
Adrian Szyndela [Tue, 9 May 2017 12:50:14 +0000 (14:50 +0200)]
kdbus: bugfix for return codes on call to non-existing destination
Calling a method on non-existing destination with auto start disabled
caused error org.freedesktop.DBus.ServiceUnknown.
Non-kdbus implementation gives org.freedesktop.DBus.NameHasNoOwner.
This patch makes kdbus return the same error as non-kdbus implementation.
Change-Id: I0320adf1205e2db11259e3f544eef27873acf8b0
Adrian Szyndela [Fri, 26 May 2017 12:31:59 +0000 (14:31 +0200)]
gkdbus: allow payloads larger than 2M in signals
In kdbus signals can't use memfd - only vectors. There is
2M size limit for kdbus vectors. We divide message data
into GVariantVectors, but they were matched 1:1 to kdbus vectors
even if their size was larger than 2M.
This patch divides GVariantVectors larger than 2M into multiple
kdbus vectors when sending a message.
Change-Id: Ided2de80535cf039ea53bd1ab9d4d68c71b6c478
Adrian Szyndela [Mon, 29 May 2017 11:37:07 +0000 (13:37 +0200)]
gkdbus: preserving NUM_UNIX_FDS header field
NUM_UNIX_FDS was discarded during sending, but it is needed
to handle file descriptors properly in libdbus.
It is also preserved by sd-bus.
Change-Id: I35ba0535bb7e92748edd51e09085f0321724de2e
Adrian Szyndela [Mon, 29 May 2017 13:48:26 +0000 (15:48 +0200)]
gkdbus: fix special rule for name signals
Sender_unique_name can never be NULL. However, it is checked
if it is NULL. It should be tested for emptiness,
but not for being NULL, but for being an empty string.
Change-Id: I2c968d614f34d7d388a629e0ce4bc9148b7e148e
Adrian Szyndela [Thu, 25 May 2017 10:01:25 +0000 (12:01 +0200)]
Bump to glib 2.52.2
tests: add gdbus-peer test back
Glib 2.51.1 moved gdbus-peer to programs compiled
only when dbus-daemon is detected. We can't easily make
dbus-daemon to be detected without creating a cycle in
the packages dependencies. Thus, I added an option
to force building programs dependent on dbus-daemon
without checking its presence.
Change-Id: Iac77bc4491ff4cadd7263edf510153bd4a38838a
Adrian Szyndela [Thu, 25 May 2017 09:50:11 +0000 (11:50 +0200)]
Merge tag 'upstream/2.52.2' into tizen
upstream/2.52.2
Change-Id: I60b56ce4eaa45877acc7e53ac4551d0a31234f7e
DongHun Kwak [Fri, 19 May 2017 00:26:29 +0000 (09:26 +0900)]
Imported Upstream version 2.52.2
Change-Id: I71ac7d11a2d40ffe74a13b1d190dbe652cba140a
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:26:07 +0000 (09:26 +0900)]
Imported Upstream version 2.52.1
Change-Id: Idca68df633e439e8492a9e0d40f78b49d689d84b
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:25:57 +0000 (09:25 +0900)]
Imported Upstream version 2.52.0
Change-Id: I7fdddaaf827f7a4f314ba570ff45b481406f5c67
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:25:27 +0000 (09:25 +0900)]
Imported Upstream version 2.51.5
Change-Id: If8ad379b8e3c0268a99759a5bf621c201926d3fe
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:25:12 +0000 (09:25 +0900)]
Imported Upstream version 2.51.4
Change-Id: I0a090d45ab8f1805c5f98fd4d804da23a4033a41
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:24:56 +0000 (09:24 +0900)]
Imported Upstream version 2.51.3
Change-Id: I69068bfdeb46efddb7a09fa8c19386aedca2dd71
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:24:38 +0000 (09:24 +0900)]
Imported Upstream version 2.51.2
Change-Id: I134d2267df41e44bec49ca802fe31ad39a8874b2
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:24:21 +0000 (09:24 +0900)]
Imported Upstream version 2.51.1
Change-Id: Id21981348a71b1395dc86225b819cd1ea103428e
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:23:56 +0000 (09:23 +0900)]
Imported Upstream version 2.51.0
Change-Id: I4219f1e9924abb0277e06eb3575732907a86e82d
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:20:59 +0000 (09:20 +0900)]
Imported Upstream version 2.50.3
Change-Id: Ib95600d2b9af114ede0d7291f53745bf373c8b26
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Mon, 27 Mar 2017 07:02:20 +0000 (16:02 +0900)]
Add license file
- Add license file all packages
[Model] ALL
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Occurrence Version] N/A
[Problem] license file does not exist at package
[Cause & Measure] add license file at each package
[Checking Method] N/A
[Team] Open Source Management and Setting Part
[Developer] dh0128.kwak
[Solution company] Samsung
[Change Type] N/A
Change-Id: Idddce1432c3b140537864a95950dff65f67ae8bf
MyungJoo Ham [Tue, 7 Mar 2017 03:53:17 +0000 (12:53 +0900)]
[4.0] Remove OBS Project Dependency (kdbus/TV)
- Please add "libgio-extension-kdbus" for TV/arm-wayland images via JIRA-TRE issue.
- Without this commit, this package won't be built correctly in Tizen 4.0.
Change-Id: I42182599e930499fdd9b862f4a2e87bede2db33f
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Adrian Szyndela [Mon, 6 Feb 2017 11:16:44 +0000 (12:16 +0100)]
tests: generating coverage version of the libraries
Change-Id: I2cb0a26bc55cd0f932d59a8fc14da96349aa0b8a
Konrad Lipinski [Thu, 2 Feb 2017 11:58:31 +0000 (12:58 +0100)]
gbs incremental build support
Change-Id: Ic7d7bab4aa03f6707e1bf5482cfc16460b950584
DongHun Kwak [Fri, 3 Feb 2017 01:24:10 +0000 (10:24 +0900)]
Imported Upstream version 2.50.2
Change-Id: I83acaeb7a15edec96b064845383396695b865613
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Lukasz Skalski [Tue, 27 Sep 2016 12:24:15 +0000 (14:24 +0200)]
gdbus: add support for 'dbus-integration-tests' framework
Change-Id: Icd3e73b5221996945b0b9e6e34813aba2ebf0ab5
INSUN PYO [Thu, 29 Dec 2016 02:26:43 +0000 (11:26 +0900)]
gdbus:fix race condition between signal callback and g_bus_unwatch_name function
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ia19381a866674a3343503dab7feab0950bb49238
(cherry picked from commit
9002008efdce0bbf351dae5338fbe782369c3e20)
Adrian Szyndela [Thu, 22 Dec 2016 11:57:32 +0000 (12:57 +0100)]
name watching: fix for freeing client prematurely
on_name_owner_changed() is called with user_data being client
with no additional reference kept (ref_count is most probably 1,
taken with one of g_bus_watch_name*() functions).
This function calls user code through call_vanished_handler()
and call_appeared_handler(). The handlers may decrease client's
reference count by calling g_bus_unwatch_name().
Thus, we need to keep this reference locally to prevent freeing
client.
Note: this is also a bug in upstream glib, but it needs two things to happen:
1. call_vanished_handler must call user code that in turn calls g_bus_unwatch_name().
2. signal NameOwnerChanged for watched name, with not empty old and new owner
- it happens when a name changes its owner.
Note: if g_bus_unwatch_name() is called from other thread than the thread,
whose main context was default while calling g_bus_watch_name*, race condition
may appear. This is not changed. This is glib's design:
https://developer.gnome.org/glib/stable/glib-Threads.html
Quote:
[...] individual data structure instances are not automatically
locked for performance reasons. For example, you must coordinate accesses
to the same GHashTable from multiple threads.
It seems the same applies for data structures kept in global data, but for which
users keep their id, as in the above case.
Change-Id: Iaa125555f6908e05f999e407fb3ba9364995b21b
Konrad Lipinski [Thu, 22 Dec 2016 10:26:01 +0000 (11:26 +0100)]
kdbus: set error when dbuspolicy1_init fails
Change-Id: I99466bde6f7cecd62d6f911cf39bf9204b81d6de
Karol Lewandowski [Thu, 15 Dec 2016 13:13:14 +0000 (14:13 +0100)]
kdbus: Do not use fstat() to determinte memfd size
Memfd size is available via kdbus metadata so there is no need to use fstat.
This fixes failure on Smack system:
[ 5352.471226] audit: type=1400 audit(
946690155.785:99): lsm=SMACK fn=smack_inode_getattr action=denied subject="USER::server" object="USER::client" requested=r pid=13139 comm="gkdbus" path=2F6D656D66643A6B64627573202864656C657465642
Original idea by Insun Pyo <insun.pyo@samsung.com>
Change-Id: Ia7fe30c9604277d5ccf7cafedb0909a2c62b0d59
Adrian Szyndela [Mon, 5 Dec 2016 14:38:08 +0000 (15:38 +0100)]
fix for race condition in watching names
Change-Id: I11fa92a6dae62cb3bdaa4159db0da160752063d1
(cherry picked from commit
f1f2e5e4df63f06cac53148e5c91a27a56eea9ca)
Hyotaek Shim [Thu, 1 Dec 2016 07:01:21 +0000 (23:01 -0800)]
Revert "kdbus: fix race-condition in GDBusNameWatching component"
This reverts commit
f942d75a0ae909ef1f7419f093edb7826148a23d.
Change-Id: Ic13b87efa9e8a73bf5e7a968fbfa4d9813071796
(cherry picked from commit
d071aa0a622f39aeb066d468278f30c45070e016)
INSUN PYO [Thu, 1 Dec 2016 02:11:03 +0000 (11:11 +0900)]
kdbus: fix g_dbus_connection_call_sync ("NameHasOwner") failure
The caller _dbus_daemon_synthetic_reply function uses the error for a special purpose.
So, _g_kdbus_NamehasOwner never makes error and only return FALSE even if an error occurs.
================ the call stck of failure =====================================
0 g_kdbus_NameHasOwner_internal (worker=worker@entry=0x42a40, name=name@entry=0x5df78 "org.not.existing.busname") at gkdbus.c:1190
1 0xb6f18a0c in _g_kdbus_NameHasOwner (worker=worker@entry=0x42a40, name=0x5df78 "org.not.existing.busname", error=error@entry=0xbefff6d0) at gkdbus.c:1314 ==> generate gdbus error
2 0xb6f1a526 in _dbus_daemon_synthetic_reply (worker=worker@entry=0x42a40, message=message@entry=0x57c60) at gkdbusfakedaemon.c:542 ==> This function only check error value rather than return value. So, after appling patch, this logic has been changed.
3 0xb6f19a9c in _g_kdbus_worker_send_message_sync (worker=0x42a40, message=message@entry=0x57c60, out_reply=out_reply@entry=0xbefff768, timeout_msec=timeout_msec@entry=-1, cancellable=cancellable@entry=0x0, error=error@entry=0xbefff7ac) at gkdbus.c:3888
4 0xb6f3fe78 in g_dbus_connection_send_message_with_reply_sync (connection=connection@entry=0x421e0, message=message@entry=0x57c60, flags=G_DBUS_SEND_MESSAGE_FLAGS_NONE, timeout_msec=timeout_msec@entry=-1, out_serial=0xbefff76c, out_serial@entry=0x0, cancellable=0x0, error=error@entry=0xbefff7ac) at gdbusconnection.c:3019
5 0xb6f4013e in g_dbus_connection_call_sync_internal (connection=0x421e0, bus_name=<optimized out>, object_path=0x24058 "/org/freedesktop/DBus", interface_name=0x24040 "org.freedesktop.DBus", method_name=method_name@entry=0x24030 "NameHasOwner", parameters=parameters@entry=0x3d6a8, reply_type=reply_type@entry=0x24130, flags=flags@entry=G_DBUS_CALL_FLAGS_NONE, timeout_msec=timeout_msec@entry=-1, fd_list=fd_list@entry=0x0, out_fd_list=out_fd_list@entry=0x0, cancellable=cancellable@entry=0x0, error=error@entry=0xbefff83c) at gdbusconnection.c:6641
6 0xb6f4187a in g_dbus_connection_call_sync (connection=<optimized out>, bus_name=<optimized out>, object_path=<optimized out>, interface_name=<optimized out>, method_name=0x24030 "NameHasOwner", parameters=0x3d6a8, reply_type=0x24130, flags=G_DBUS_CALL_FLAGS_NONE, timeout_msec=-1, cancellable=0x0, error=0xbefff83c) at gdbusconnection.c:6868
==============================================================================
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I4959eaeeaad79de641f6b0c1ce10020ae9fe3760
MyungJoo Ham [Thu, 1 Dec 2016 05:16:24 +0000 (14:16 +0900)]
Remove Profile Build Dependency
Apply Tizen-TV profile optimization for ALL Tizen profiles
because it would not have side effects on the correctness.
(simply ref/unref a Tizen-wide "dbus")
Change-Id: I209f9bf798b02f674a95dfc38142b4a44e194883
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
sanghyeok.oh [Wed, 30 Nov 2016 09:43:21 +0000 (18:43 +0900)]
gdbus:add null check for error variable
Change-Id: Ib51dd62ebc066b9393ae7c59f2f63d3330a16518
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
(cherry picked from commit
22aff71838c2aafc27196886fff317d146f749e1)
Hyotaek Shim [Fri, 25 Nov 2016 10:04:10 +0000 (19:04 +0900)]
Kdbus: Fix for handling EPERM errors
Change-Id: I63b35469d0fe660a33880ac02b9dcb405ceeafac
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Thu, 24 Nov 2016 09:01:34 +0000 (18:01 +0900)]
kdbus: check return status of KDBUS_CMD_FREE iotcl
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I35ae1afffc01aaf1df54d6d2466cb0ecb3417c73
Lukasz Skalski [Wed, 23 Nov 2016 11:18:07 +0000 (12:18 +0100)]
kdbus: check return status of KDBUS_CMD_CONN_INFO iotcl
Change-Id: If6ea3c1825333aca2af4a2599b0187b1ff931b34
sanghyeok.oh [Tue, 22 Nov 2016 08:19:13 +0000 (17:19 +0900)]
gdbus: change timeout error code from 'gdbus error' to 'gio error'
sync/async call return different error code when timeout was occured
modify it to return G_IO_ERROR_TIMED_OUT
Change-Id: I7b9fb847240311ce40f59ab7d552aaa2efeecb45
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
(cherry picked from commit
7a6fcd470025060f220b51ed8a4ecd57cf2b84b7)
Lukasz Skalski [Mon, 31 Oct 2016 10:49:11 +0000 (11:49 +0100)]
kdbus: fix race-condition in GDBusNameWatching component
To avoid race-condition between GetNameOwner replay and
NameOwnerChanged signal in GDBusNameWatching component,
let's always use GetNameOwner sync call on kdbus bus.
Change-Id: Iebb780737d753d989a7d928f65d433d86d79284a
sanghyeok.oh [Tue, 11 Oct 2016 01:21:55 +0000 (10:21 +0900)]
coding style:errno must referenced right after calling standard function
Change-Id: I8eff8b174ecb621acbbe73734aa5c35cf5c60bfc
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Wed, 28 Sep 2016 03:38:26 +0000 (12:38 +0900)]
Fix for missing g_source_unref(Gkdbus worker source)
Change-Id: Ia5fb338b8b69b76c52d2dee8f6ccbb39e101a1c7
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Tue, 27 Sep 2016 09:28:51 +0000 (18:28 +0900)]
glib:remove self-join deadlock:change to g_thread_unref
Change-Id: I1b98bed183510ca79c3448da5e2bd2a4115de709
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Tue, 27 Sep 2016 02:33:36 +0000 (11:33 +0900)]
glib:remove self-join deadlock
Change-Id: Ia9fffe62c90d596efe29929c50e835d4a93fac52
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>