Søren Sandmann Pedersen [Fri, 7 Aug 2009 03:52:11 +0000 (23:52 -0400)]
Fix a couple of alpha==0 vs src==0 issues in pixman-sse2.c
Søren Sandmann Pedersen [Fri, 7 Aug 2009 03:05:36 +0000 (23:05 -0400)]
Rename mmx_composite_add_8888_8_8() to mmx_composite_add_n_8_8().
Søren Sandmann Pedersen [Fri, 7 Aug 2009 02:46:50 +0000 (22:46 -0400)]
Fix a couple more alpha==0 vs src==0 bugs in pixman-mmx.c
Søren Sandmann Pedersen [Fri, 7 Aug 2009 02:42:25 +0000 (22:42 -0400)]
Make pix_add_mul() in pixman-mmx.c produce exact results.
Previously this routine would compute (x * a + y * b) / 255. Now it
computes (x * a) / 255 + (y * b) / 255, so that the results are
bitwise equivalent to the non-mmx versions.
Søren Sandmann Pedersen [Fri, 7 Aug 2009 00:29:44 +0000 (20:29 -0400)]
Rewrite the two-component arithmetic macros.
Previously they were not bit-for-bit equivalent to the one-component
versions. The new code is also simpler and easier to read because it
factors out some common sub-macros.
The x * a + y * b macro now only uses four multiplications - the
previous version used eight.
Søren Sandmann Pedersen [Fri, 7 Aug 2009 00:41:04 +0000 (20:41 -0400)]
Fix a bunch of srca == 0 checks that should be src == 0 in pixman-mmx.c
Søren Sandmann Pedersen [Thu, 6 Aug 2009 01:24:50 +0000 (21:24 -0400)]
Don't run fast paths if the format requires wide compositing.
This could happen because the wide formats would still be considered
solid if the image was 1x1 and repeating.
Søren Sandmann Pedersen [Thu, 6 Aug 2009 01:16:14 +0000 (21:16 -0400)]
Fix bug in combine_mask_alpha_ca()
If the mask was 0xffffffff, the source would end up being shifted
twice by A_SHIFT.
Søren Sandmann Pedersen [Thu, 6 Aug 2009 00:40:36 +0000 (20:40 -0400)]
Fix another case of changing the solid source.
This time in fast_path_composite_n_8888_8888().
Søren Sandmann Pedersen [Thu, 6 Aug 2009 00:31:41 +0000 (20:31 -0400)]
Fix incorrect optimization in combine_over_ca().
Previously the code assumed that an alpha of 0 meant that no change
would take place. This is incorrect because an alpha of 0 can happen
as the result of the source having alpha=0, but rgb != 0.
Søren Sandmann Pedersen [Wed, 5 Aug 2009 22:18:37 +0000 (18:18 -0400)]
Don't change the constant source in fast_composite_over_n_8888_0565.
Søren Sandmann Pedersen [Wed, 5 Aug 2009 20:17:52 +0000 (16:17 -0400)]
Fix bugs in combine_over_reverse_ca().
The computation cannot be optimized away when alpha is 0 because that
can happen when the source has alpha zero and rgb non-zero.
Søren Sandmann Pedersen [Fri, 31 Jul 2009 21:27:38 +0000 (17:27 -0400)]
Add a dirty bit to the image struct, and validate before using the image.
This cuts down the number of property_changed calls significantly.
Søren Sandmann Pedersen [Fri, 31 Jul 2009 14:39:41 +0000 (10:39 -0400)]
Add sse2 version of add_n_8888_8888()
Søren Sandmann Pedersen [Fri, 31 Jul 2009 14:26:10 +0000 (10:26 -0400)]
Add a fast path for the add_n_8888_8888() operation.
It shows up on gnome-terminal traces.
Søren Sandmann Pedersen [Fri, 31 Jul 2009 11:29:31 +0000 (07:29 -0400)]
Move bounds checks for REPEAT_NONE to get_pixel()
On a P4, this is a large speedup for the swfdec-fill-rate-2xaa trace:
After:
[ # ] backend test min(s) median(s) stddev. count
[ 0] image swfdec-fill-rate-2xaa 33.061 33.061 0.00% 1/1
Before:
[ # ] backend test min(s) median(s) stddev. count
[ 0] image swfdec-fill-rate-2xaa 40.342 40.342 0.00% 1/1
Pixman 0.14.0 produces this:
[ # ] backend test min(s) median(s) stddev. count
[ 0] image swfdec-fill-rate-2xaa 36.896 36.896 0.00% 1/1
Søren Sandmann Pedersen [Thu, 30 Jul 2009 14:51:38 +0000 (10:51 -0400)]
Remove leftover 0xffffffff in repeat()
Søren Sandmann Pedersen [Thu, 30 Jul 2009 14:45:18 +0000 (10:45 -0400)]
Remove unused function
Søren Sandmann Pedersen [Thu, 30 Jul 2009 14:03:44 +0000 (10:03 -0400)]
Misc formatting
Søren Sandmann Pedersen [Thu, 30 Jul 2009 13:58:12 +0000 (09:58 -0400)]
Change all the fetch_pixels() functions to only fetch one pixel.
Søren Sandmann Pedersen [Tue, 28 Jul 2009 13:43:12 +0000 (09:43 -0400)]
Add fetch_pixel_raw_32 and fetch_pixel_32 virtual functions.
By default both are intialized to bits_image_fetch_pixel_raw(), but if
there is an alpha map, then fetch_pixel_32() is set to
bits_image_fetch_pixel_alpha().
Søren Sandmann Pedersen [Tue, 28 Jul 2009 13:12:51 +0000 (09:12 -0400)]
Various renamings and clean-ups
Søren Sandmann Pedersen [Tue, 28 Jul 2009 12:58:41 +0000 (08:58 -0400)]
Change bits_image_fetch_alpha_pixels() to fetch just one pixel.
Søren Sandmann Pedersen [Tue, 28 Jul 2009 12:44:40 +0000 (08:44 -0400)]
Change bits_image_fetch_pixels_convolution() to fetch just one pixel.
Søren Sandmann Pedersen [Tue, 28 Jul 2009 12:33:28 +0000 (08:33 -0400)]
Change bits_image_fetch_bilinear_pixels() to fetch one pixel at a time.
Søren Sandmann Pedersen [Tue, 28 Jul 2009 12:03:44 +0000 (08:03 -0400)]
Make the repeat routine work on only one coordinate at a time.
Søren Sandmann Pedersen [Tue, 28 Jul 2009 11:55:27 +0000 (07:55 -0400)]
Make bits_image_fetch_nearest() return one pixel.
Previously it would work on a buffer of coordinates.
Søren Sandmann Pedersen [Tue, 28 Jul 2009 11:42:34 +0000 (07:42 -0400)]
Change bits_image_fetch_transformed() to work one pixel at a time.
Previously, it would generate a buffer of coordinates, then pass that
off to a pixel fetcher, but this caused a large performance regression
with the swfdec-fill-rate-2xfsaa cairo trace.
This is the first step towards fixing that.
Søren Sandmann Pedersen [Fri, 7 Aug 2009 04:11:20 +0000 (00:11 -0400)]
Only define PIXMAN_TIMERS if timers are actually enabled [bug 23169]
Søren Sandmann Pedersen [Tue, 28 Jul 2009 13:58:52 +0000 (09:58 -0400)]
Various updates to the CODING_STYLE document
Søren Sandmann Pedersen [Tue, 28 Jul 2009 08:05:26 +0000 (04:05 -0400)]
Add a CODING_STYLE document based on the one from cairo.
Søren Sandmann Pedersen [Wed, 22 Jul 2009 08:51:08 +0000 (04:51 -0400)]
Remove a couple of unused variables
Søren Sandmann Pedersen [Wed, 22 Jul 2009 08:32:07 +0000 (04:32 -0400)]
Rename source_pict_class_t to source_image_class_t
Søren Sandmann Pedersen [Wed, 22 Jul 2009 08:28:08 +0000 (04:28 -0400)]
Replace a bunch of 'pict's with 'image'
Chris Wilson [Fri, 24 Jul 2009 08:36:08 +0000 (09:36 +0100)]
Explain how we can simplify the radial gradient computation
Soeren rightfully complained that I had removed all the comments from
André's patch, most importantly that explain why the transformation is
valid. So add a few details to show that B varies linearly across the
scanline and how we can therefore reduce the per-pixel cost of evaluating
B.
Chris Wilson [Thu, 23 Jul 2009 18:08:40 +0000 (19:08 +0100)]
Fix inversion of radial gradients when r2 > r1
Fixes: Bug 22908 -- Invalid output of radial gradient
http://bugs.freedesktop.org/show_bug.cgi?id=22908
We also include a modified patch by André Tupinambá <andrelrt@gmail.com>,
to pull constant expressions out of the inner radial gradient walker.
Benjamin Otte [Thu, 23 Jul 2009 07:54:49 +0000 (09:54 +0200)]
Don't warn for empty rectangles, only degenerate ones
Benjamin Otte [Tue, 21 Jul 2009 13:00:52 +0000 (15:00 +0200)]
Log errors for invalid rectangles passed to region code
Benjamin Otte [Tue, 21 Jul 2009 12:57:59 +0000 (14:57 +0200)]
Simplify code that logs errors
Benjamin Otte [Tue, 21 Jul 2009 12:50:30 +0000 (14:50 +0200)]
Make the text when reporting a broken region more useful
Søren Sandmann Pedersen [Tue, 21 Jul 2009 11:24:40 +0000 (07:24 -0400)]
Post-release version bump
Søren Sandmann Pedersen [Tue, 21 Jul 2009 11:20:57 +0000 (07:20 -0400)]
Pre-release version bump
Søren Sandmann Pedersen [Tue, 21 Jul 2009 11:01:10 +0000 (07:01 -0400)]
Don't assert when malformed regions are detected.
Instead print a message to stderr so that it will end up in the X log
file.
Søren Sandmann Pedersen [Tue, 21 Jul 2009 08:23:56 +0000 (04:23 -0400)]
Fix another search and replace issue
Søren Sandmann Pedersen [Tue, 21 Jul 2009 08:18:35 +0000 (04:18 -0400)]
Fix search-and-replace issue pointed out by Koen Kooi.
George Yohng [Tue, 21 Jul 2009 07:43:42 +0000 (03:43 -0400)]
Add implementation of MMX __m64 functions for MSVC x64.
Microsoft C++ does not define __m64 and all related MMX functions in
x64. However, it succeeds in generating object files for SSE2 code
inside pixman.
The real problem happens during linking, when it cannot find MMX functions
(which are not defined as intrinsics for AMD64 platform).
I have implemented those missing functions using general programming.
MMX __m64 is used relatively scarcely within SSE2 implementation, and the
performance impact probably is negligible.
Bug 22390.
Chris Wilson [Mon, 20 Jul 2009 13:07:18 +0000 (14:07 +0100)]
Fix read of BITS members from a solid image.
During the fast-path query, the read_func and write_func from the bits
structure are queried for the solid image.
==32723== Conditional jump or move depends on uninitialised value(s)
==32723== at 0x412AF20: _pixman_run_fast_path (pixman-utils.c:681)
==32723== by 0x4136319: sse2_composite (pixman-sse2.c:5554)
==32723== by 0x4100CD2: _pixman_implementation_composite
(pixman-implementation.c:227)
==32723== by 0x412396E: pixman_image_composite (pixman.c:140)
==32723== by 0x4123D64: pixman_image_fill_rectangles (pixman.c:322)
==32723== by 0x40482B7: _cairo_image_surface_fill_rectangles
(cairo-image-surface.c:1180)
==32723== by 0x4063BE7: _cairo_surface_fill_rectangles
(cairo-surface.c:1883)
==32723== by 0x4063E38: _cairo_surface_fill_region
(cairo-surface.c:1840)
==32723== by 0x4067FDC: _clip_and_composite_trapezoids
(cairo-surface-fallback.c:625)
==32723== by 0x40689C5: _cairo_surface_fallback_paint
(cairo-surface-fallback.c:835)
==32723== by 0x4065731: _cairo_surface_paint (cairo-surface.c:1923)
==32723== by 0x4044098: _cairo_gstate_paint (cairo-gstate.c:900)
==32723== Uninitialised value was created by a heap allocation
==32723== at 0x402732D: malloc (vg_replace_malloc.c:180)
==32723== by 0x410099F: _pixman_image_allocate (pixman-image.c:100)
==32723== by 0x41265B8: pixman_image_create_solid_fill
(pixman-solid-fill.c:75)
==32723== by 0x4123CE1: pixman_image_fill_rectangles (pixman.c:314)
==32723== by 0x40482B7: _cairo_image_surface_fill_rectangles
(cairo-image-surface.c:1180)
==32723== by 0x4063BE7: _cairo_surface_fill_rectangles
(cairo-surface.c:1883)
==32723== by 0x4063E38: _cairo_surface_fill_region
(cairo-surface.c:1840)
==32723== by 0x4067FDC: _clip_and_composite_trapezoids
(cairo-surface-fallback.c:625)
==32723== by 0x40689C5: _cairo_surface_fallback_paint
(cairo-surface-fallback.c:835)
==32723== by 0x4065731: _cairo_surface_paint (cairo-surface.c:1923)
==32723== by 0x4044098: _cairo_gstate_paint (cairo-gstate.c:900)
==32723== by 0x403C10B: cairo_paint (cairo.c:2052)
Søren Sandmann Pedersen [Tue, 21 Jul 2009 04:17:15 +0000 (00:17 -0400)]
Only apply the workaround if the clip region extends beyond the drawable.
This works because the X server always attempts to set a clip region
within the bounds of the drawable, and it only fails at it when it is
computing the wrong translation and therefore needs the workaround.
Søren Sandmann Pedersen [Tue, 21 Jul 2009 03:46:06 +0000 (23:46 -0400)]
Rework the workaround for bogus X server images.
Bug 22844 demonstrates that it is not sufficient to play tricks with
the clip regions to work around the bogus images from the X
server. The problem there is that if the operation hits the general
path and the destination has a different format than a8r8g8b8, the
destination pixels will be fetched into a temporary array. But because
those pixels would be outside the clip region, they would be fetched
as black. The previous workaround was relying on fast paths fetching
those pixels without checking the clip region.
In the new scheme we work around the problem at the
pixman_image_composite() level. If an image is determined to need a
work around, we translate both the bits pointer, the coordinates, and
the clip region, thus effectively undoing the X server's broken
computation.
Søren Sandmann Pedersen [Tue, 21 Jul 2009 02:45:47 +0000 (22:45 -0400)]
Add test case for bug 22844.
Søren Sandmann Pedersen [Tue, 21 Jul 2009 05:24:43 +0000 (01:24 -0400)]
Fix typo in sse2_combine_over_pixbuf_0565()
Adrian Bunk [Tue, 21 Jul 2009 00:16:32 +0000 (20:16 -0400)]
Fix NEON build for older ARM CPUs
The pld instruction used in the NEON assembler code is only available
for ARMv5e and >= ARMv6.
Set -mcpu=cortex-a8 when compiling the source file (similar to what is
already done for the SIMD build).
Søren Sandmann Pedersen [Mon, 20 Jul 2009 23:56:46 +0000 (19:56 -0400)]
Some formatting changes to pixman-arm-neon.c
Siarhei Siamashka [Fri, 17 Jul 2009 10:03:21 +0000 (13:03 +0300)]
ARM: Fixes for the inline assembly constraints in pixman_fill_neon
Some of the variables in the inline assembly arguments list are
actually modified by the assembly code, they are now marked
appropriately.
Siarhei Siamashka [Fri, 17 Jul 2009 09:54:44 +0000 (12:54 +0300)]
ARM: Workaround cs2007q3 compiler bug for NEON registers clobber list
128-bit registers "qX" are incorrectly handled in inline assembly
clobber list for codesourcery cs2007q3 gcc toolchain. Only the
first 64-bit half is saved and restored by gcc. Changing clobber
list to use only 64-bit register aliases can solve this problem.
For example, 128-bit register q0 is mapped to two 64-bit
registers d0 and d1, q1 is mapped to d2 and d3, etc.
Siarhei Siamashka [Thu, 16 Jul 2009 21:11:14 +0000 (00:11 +0300)]
ARM: Commented out the rest of buggy NEON optimizations
These functions have problems with invalid memory accesses and often
crash X server
Siarhei Siamashka [Thu, 16 Jul 2009 21:08:42 +0000 (00:08 +0300)]
ARM: Use Ian's variant of 'neon_composite_over_n_8_0565' function again
This patch effectively reverts the changes done by commit
8eeeca993252edc39da9c5c57545b81215fafc81 which was causing
severe stability issues, and restores old variant of
'neon_composite_over_n_8_0565' function, which used to work
correctly.
Miha Vrhovnik [Mon, 20 Jul 2009 23:30:59 +0000 (19:30 -0400)]
Update Makefile.win32 to make it work again.
Benjamin Otte [Mon, 20 Jul 2009 22:49:40 +0000 (00:49 +0200)]
Add a lot more sanity checks to region code
- Introduce a GOOD_RECT() macro that checks that a pixman_box_t is not
empty or degenerate an use it.
- Use GOOD_RECT() instead of magic if statements for funtions that take
x, y, width, height arguments
- Use GOOD_RECT() in _reset(). The checks in the previous code seemed to
allow an empty box, but then created a broken region from it.
- Add GOOD(region) check at the end of _translate()
Benjamin Otte [Mon, 20 Jul 2009 21:38:36 +0000 (23:38 +0200)]
Handle degenerate case in pixman_init_extents()
Create an empty region instead
Søren Sandmann Pedersen [Sun, 19 Jul 2009 16:29:42 +0000 (12:29 -0400)]
Replace // comments with /* */ comments in various places
Søren Sandmann Pedersen [Sat, 18 Jul 2009 21:59:43 +0000 (17:59 -0400)]
Align the stack in _pixman_implementation_create_sse2()
When compiled without optimization, GCC will place various temporaries
on the stack. Since Firefox sometimes causes the stack to be aligned
to four bytes, this causes movdqa to generate faults.
M Joonas Pihlaja [Sun, 19 Jul 2009 15:20:53 +0000 (18:20 +0300)]
Check whether the linker understands the hwcap file before using it.
If we're trying to use the GNU linker on Solaris we shouldn't use
our solaris-hwcap.mapfile since it doesn't grok the mapfile format.
Søren Sandmann Pedersen [Sat, 18 Jul 2009 02:40:41 +0000 (22:40 -0400)]
Move read and write functions to the bits_image_t struct.
Those fields were duplicated between image_common and bits_image_t
before.
Benjamin Otte [Fri, 17 Jul 2009 14:01:59 +0000 (16:01 +0200)]
Handle degenerate case in pixman_init_rect()
Create an empty region in that case.
Søren Sandmann Pedersen [Fri, 17 Jul 2009 10:43:35 +0000 (06:43 -0400)]
Add back check for need_workaround that got removed during reindenting
Søren Sandmann Pedersen [Thu, 16 Jul 2009 14:38:22 +0000 (10:38 -0400)]
Fix combine_src_ca() to fill out all of the destination line.
Søren Sandmann Pedersen [Thu, 16 Jul 2009 13:34:22 +0000 (09:34 -0400)]
Change composite test to use a rainbow gradient as source.
Also make the destination a yellow patch. This makes the output a bit
more comparable to the image in the PDF specification.
Søren Sandmann Pedersen [Thu, 16 Jul 2009 10:23:25 +0000 (06:23 -0400)]
Various minor formatting changes
Søren Sandmann Pedersen [Thu, 16 Jul 2009 10:06:17 +0000 (06:06 -0400)]
Change name of macro from RGB16_TO_ENTRY to RGB15_TO_ENTRY
Benjamin Otte [Thu, 16 Jul 2009 13:33:43 +0000 (15:33 +0200)]
Clarify color burn code - no semantical changes
- Improve documentation to be equal to Proposed ISO32000 Extension
- Simplify code in default case
Benjamin Otte [Thu, 16 Jul 2009 13:28:05 +0000 (15:28 +0200)]
Clarify color dodge code - no semantical changes
- Improve documentation to be equal to Proposed ISO32000 Extension
- Simplify code in default case
Benjamin Otte [Thu, 16 Jul 2009 13:02:51 +0000 (15:02 +0200)]
Fix terms in comments describing the blend modes
Søren Sandmann Pedersen [Tue, 14 Jul 2009 22:49:43 +0000 (18:49 -0400)]
Add -fno-strict-aliasing
Søren Sandmann Pedersen [Tue, 14 Jul 2009 02:22:20 +0000 (22:22 -0400)]
Post-release version bump
Søren Sandmann Pedersen [Tue, 14 Jul 2009 02:00:52 +0000 (22:00 -0400)]
Pre-release version bump
Søren Sandmann Pedersen [Mon, 13 Jul 2009 23:58:04 +0000 (19:58 -0400)]
Reindent and rename identifiers in scaling-test.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 06:37:19 +0000 (02:37 -0400)]
Reformat pixman.h
Søren Sandmann Pedersen [Mon, 13 Jul 2009 05:35:15 +0000 (01:35 -0400)]
Reindent and reformat pixman-private.h
Søren Sandmann Pedersen [Mon, 13 Jul 2009 05:17:53 +0000 (01:17 -0400)]
Reindent and reformat pixman-combine.h.template
Søren Sandmann Pedersen [Mon, 13 Jul 2009 05:13:47 +0000 (01:13 -0400)]
Reindent and reformat pixman-combine.c.template
Søren Sandmann Pedersen [Mon, 13 Jul 2009 02:05:32 +0000 (22:05 -0400)]
Reindent and reformat pixman-vmx.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 01:57:08 +0000 (21:57 -0400)]
Reformat and reindent pixman-utils.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 01:40:41 +0000 (21:40 -0400)]
Reformat and reindent pixman-trap.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 01:37:16 +0000 (21:37 -0400)]
Reformat pixman-timer.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 01:36:32 +0000 (21:36 -0400)]
Reformat and reindent pixman-sse2.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 00:31:26 +0000 (20:31 -0400)]
Reformat and reindent pixman-solid-fill.c
Søren Sandmann Pedersen [Mon, 13 Jul 2009 00:30:44 +0000 (20:30 -0400)]
Reformat and reindent pixman-region.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:59:17 +0000 (19:59 -0400)]
Reindent and reformat pixman-radial-gradient.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:37:45 +0000 (19:37 -0400)]
Reindent and reformat pixman-mmx.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:24:31 +0000 (19:24 -0400)]
Reindent and reformat pixman-matrix.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:19:13 +0000 (19:19 -0400)]
Reindent and reformat pixman-linear-gradient.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:15:17 +0000 (19:15 -0400)]
Reindent and reformat pixman-implementation.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:13:17 +0000 (19:13 -0400)]
Reindent and reformat pixman-image.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:10:53 +0000 (19:10 -0400)]
Reindent and reformat pixman-gradient-walker.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:09:24 +0000 (19:09 -0400)]
Reindent and reformat pixman-general.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:06:30 +0000 (19:06 -0400)]
Reindent and reformat pixman-fastpath.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 23:02:29 +0000 (19:02 -0400)]
Reindent and reformat pixman-edge.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 22:59:10 +0000 (18:59 -0400)]
Reindent and reformat pixman-cpu.c
Søren Sandmann Pedersen [Sun, 12 Jul 2009 22:55:45 +0000 (18:55 -0400)]
Reindent and reformat pixman-conical-gradient.c