platform/upstream/libSkiaSharp.git
7 years agoUpgrade Windows 10 to v1703.
Ben Wagner [Tue, 2 May 2017 17:13:13 +0000 (13:13 -0400)]
Upgrade Windows 10 to v1703.

No-Try: true
Change-Id: Ifb8528d889233fa14320b9f665ddcaf2f5fae6fb
Reviewed-on: https://skia-review.googlesource.com/15141
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoAllow TextureSamplers to have null GrTexture pointer
Robert Phillips [Mon, 1 May 2017 17:12:20 +0000 (13:12 -0400)]
Allow TextureSamplers to have null GrTexture pointer

Bug: 715488

Change-Id: I69775cbb50d334d81872e236e59368fe65e698ff
Reviewed-on: https://skia-review.googlesource.com/14605
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
7 years agoAdd sweep gradient to SkRasterPipeline
Herb Derby [Tue, 2 May 2017 23:04:39 +0000 (19:04 -0400)]
Add sweep gradient to SkRasterPipeline

This is a prototype. I have remove the tiling,
but maybe I should add it back in.

I thinking about factoring out the common code with
linear gradient in its own CL.

I think radial gradient will be very close to this.

Change-Id: I1dfcb4f944138ee623afdf10b2a8befde797c604
Reviewed-on: https://skia-review.googlesource.com/13766
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>

7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 16:11:20 +0000 (09:11 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/6b56eb2b7989ff5e9dbc2bc9fd1ff3e03742c7f5 Use new sanitizer coverage flags on builders. (ochang@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4de3c8fea34a2c8f1afeec0d9744703cff8a1191
Reviewed-on: https://skia-review.googlesource.com/15197
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agodrawfilter is legacy-guarded, no need for deprecated
Mike Reed [Wed, 3 May 2017 14:52:00 +0000 (10:52 -0400)]
drawfilter is legacy-guarded, no need for deprecated

Bug: skia:
Change-Id: Ic8dbe9aa043bd793e49975f5b6f08a0ac38e4faa
Reviewed-on: https://skia-review.googlesource.com/15185
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

7 years agoRevert "Reland: Remove SkLights include from SkCanvas.h"
Florin Malita [Wed, 3 May 2017 15:41:00 +0000 (15:41 +0000)]
Revert "Reland: Remove SkLights include from SkCanvas.h"

This reverts commit fed00319c9bafa41c8df658708030c072b301a41.

Reason for revert: breaking the Android roll.

Original change's description:
> Reland: Remove SkLights include from SkCanvas.h
>
> SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
> works fine).
>
> Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb
> TBR=reed@google.com
> Reviewed-on: https://skia-review.googlesource.com/15143
> Commit-Queue: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
>

TBR=fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I3b0e69f1d04d160f16a5567b09982d35cc9ca84e
Reviewed-on: https://skia-review.googlesource.com/15195
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 14:40:32 +0000 (07:40 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5d0485f2f56fbc83b7405e2120295d935ff835bc WebRTC: Make win_asan build ASan instead of Syzyasan. (ehmaldonado@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib4434c7a2a4ba0da36c016062230f28a72db97d2
Reviewed-on: https://skia-review.googlesource.com/15190
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 14:10:42 +0000 (07:10 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/1819fe2afd36da781454626345ea87dedae14643 Revert "zip_build.py: Exclude secondary toolchain obj and gen, as well as .ninja" (machenbach@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I672fa0184f56825a067c85c1cc25db427acbab50
Reviewed-on: https://skia-review.googlesource.com/15188
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agoRevert "Revert "eliminated GrGLSLExpr""
Ethan Nicholas [Wed, 3 May 2017 13:49:07 +0000 (09:49 -0400)]
Revert "Revert "eliminated GrGLSLExpr""

This reverts commit 5e550ab57e0204bfadd2cb69c47d2a85e38d6a4c.

Bug: skia:
Change-Id: I4705e47dbd209aa8f43db3d28c856bd3aa9e49ab
Reviewed-on: https://skia-review.googlesource.com/15187
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 13:30:33 +0000 (06:30 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/1c881be4fb63733820a29955a7e0772f1898921e zip_build.py: Exclude secondary toolchain obj and gen, as well as .ninja (agrieve@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I933bb4526a69d5472478c031ff397e7bb4497c1d
Reviewed-on: https://skia-review.googlesource.com/15186
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 13:00:35 +0000 (06:00 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/fb4b3222dc1a951b98720c877f8b622c71857481 Disable kitchen on Site Isolation Linux for now. (dpranke@chromium.org)
  https://crrev.com/251a99c260bc8bf457e435aceab6b69758b4db81 Bisect - Support perf try with specified revisions. (simonhatch@chromium.org)
  https://crrev.com/d3c3fb83f87b375365639f05cef8786596003e96 Add a smoke test for run_slave.py. (dsansome@chromium.org)
  https://crrev.com/8565f13839c6d768f429e20e6b36c21943677718 cleanup: Remove redundant TEST_TMPDIR (shinyak@google.com)
  https://crrev.com/df328b84fe2f17ac3c5042df5ae833cdb63ccfa4 Rename hammerhead -> angler and update angler device. (ngeoffray@google.com)
  https://crrev.com/bee6a1dbe093a8ad8c47af591a7ffcb0974f8b62 Bisect - Remove whitespace from results label. (simonhatch@chromium.org)
  https://crrev.com/eea5d3819da5c97b58089a73d2eee042b0a5b61b Includes logdog cipd packages for Android webrtc gtests. (hzl@google.com)
  https://crrev.com/912cb7c67f116ecf350908f4b450dd300a4b883c Revert "Includes logdog cipd packages for Android webrtc gtests." (kjellander@chromium.org)
  https://crrev.com/d734dc32b3c4c59f9e451b7ce0c18bb92ff8735c Add tests for chromium_tests recipe module (patch #4) (phajdan.jr@chromium.org)
  https://crrev.com/cd5b7d84f3c4028f147ae1d1d29fc8a5c9ca7774 Add ownership to goma team for goma client canary bots config (tikuta@google.com)
  https://crrev.com/b1e329c76e57736f34b11b5833e02c8bdfb7fc1f Temporarily disable LocalOutputCache on Win. (shinyak@google.com)
  https://crrev.com/d11b6353c4becd46396035eac7a30ed855d4fd88 V8: Bump branch bot timeouts on swarming and lower the prio (machenbach@chromium.org)
  https://crrev.com/daaf3a43b88868ca3dbbfd381b9348aceeac33fe V8: Bump shards on slowest bots (machenbach@chromium.org)
  https://crrev.com/4c45afbaad648695ef641847a54a8336b31acd8f Prepare for switching chromium's got_revision_mapping (machenbach@chromium.org)
  https://crrev.com/4fb14838b986da533701aad16fe72c85408c234c V8: Bump shards on slowest bot (machenbach@chromium.org)
  https://crrev.com/d5753bebd45ad4b460d981ee7c6c362fc3f1609f WebRTC: Add WebRtcMediaRecorderTest to our bare-metal bots. (kjellander@chromium.org)
  https://crrev.com/0b77199dcdc11c58c6ef4d3995a71605ef8a5db8 Dart: Shorten build directory name on Dartium builders (whesse@chromium.org)
  https://crrev.com/582bcc0da0968ec10566af5de08013cbc0e4a531 Add tests for chromium_tests recipe module (patch #5) (phajdan.jr@chromium.org)
  https://crrev.com/145292610fb7806f9aff430a237c95d433817a60 (Reland) Includes logdog cipd packages for Android webrtc gtests. (hzl@google.com)
  https://crrev.com/a0485b1c8e457ba6dd1a0a3e809885f3b49fe446 Expose run_mb()'s mb_config_path arg in more callers. (mmoss@google.com)
  https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d Remove gtests from the webkit waterfall. (danakj@chromium.org)
  https://crrev.com/fb1e08cef6a97967689f7d3dc4f4525120e92de6 Add generation support to LogDog prefixes. (dnj@chromium.org)
  https://crrev.com/13a85ae09b27268d7e7231fb8ee3c0bca33a2d36 Add a Linux bot to run servicification related tests. (jam@chromium.org)
  https://crrev.com/9b8071a40447ec753bb28afbdeb815834b3c08b4 Deploy build71-m1 as "Mac Experimental Release (Intel)". (kbr@chromium.org)
  https://crrev.com/ffa0c5817c8d2574308cb2bceb2e1fa145a27274 V8: Set swarming default dimension for cores. (machenbach@chromium.org)
  https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639 WebRTC: Add jingle_unittests to desktop bots. (kjellander@chromium.org)
  https://crrev.com/7e9590a51289827d249a9794913e6918df4d76fc Bisect - Switch Nexus5X to 32bit builder. (simonhatch@chromium.org)
  https://crrev.com/572574d3c7e25264b45377c873d07ae78c56de08 Bisect - Switch Nexus5X download path to 32 bit as well. (simonhatch@chromium.org)
  https://crrev.com/e8aa654ab538c1e53f180af8647af58cf795a848 Add func to list unblacklisted devices in chromium_android recipe module (bpastene@google.com)
  https://crrev.com/1afc3517609286df3f4b3fce730ddad3e1eefedc master.chromium.infra.cron: add 3p package builders (nodir@google.com)
  https://crrev.com/eee167b93de7b16b804bd212a6080d02c571c149 Switch nexus 5x to 32 bit build (martiniss@chromium.org)
  https://crrev.com/4981f692ed3c710e8270a481153e64273629d2f8 Add git log links to update scripts step (martiniss@chromium.org)
  https://crrev.com/3a99c2ed795b1f46d38e744d46f1eb6f5e290b40 Add --exclude filters for android builder archives (agrieve@chromium.org)
  https://crrev.com/b7712e04694d0e3da2609b7395f1dfd0293e3195 Don't force PGO builds to use VS 2015 (brucedawson@chromium.org)
  https://crrev.com/051e1d5fb424e2fcd985f87ef83a17781bdff369 Remove svn_url and TryJobSubversion from masters that use it. (dsansome@chromium.org)
  https://crrev.com/8acca5a336e00eab761363dfdaa081b7cdce3883 V8: Skip auto-rolling gtest depedency (machenbach@chromium.org)
depot_tools:
  https://crrev.com/80cae42d7f0f00ab29a8bd05f223f36e2589fa62 Fix git_footers to recognize footers with empty value. (tandrii@chromium.org)
  https://crrev.com/c06db440c9ed7876a401efe0b8d88f671aa61c36 Make git_footers.add_footer more flexible (agable@chromium.org)
  https://crrev.com/ff294c3001d02dcad1de1c8965bcdb00b31963f9 cpplint: Update Google Style Guide's URL (alexilin@chromium.org)
  https://crrev.com/c7e84d041306082117c5760c10bf19891a35e88e git-drover: TBR appropriate reviewers (agable@chromium.org)
  https://crrev.com/801d955c43e29ed711f0ad3566112cd1d8c8fdbd Reverse chromium's got_revision_mapping (machenbach@chromium.org)
  https://crrev.com/6fee2673e9c7356cff80bd32c196289c7d9cd79c Add vpython to depot_tools for linux and mac (sergeyberezin@google.com)
  https://crrev.com/b584c4f0d1709ca5302c38c68c6a8febf3273d17 Make CQ_INCLUDE_TRYBOTS support review-specific (agable@chromium.org)
  https://crrev.com/e0a1afbf4b0d41b10d9eb1463835647024eb25bc Fix bot_update parsing of gerrit footers with empty values. (tandrii@chromium.org)
  https://crrev.com/ff51bcd1f846053625c3428432020a6623abb419 [bot_update] fix Property default to be actual JSON. (iannucci@chromium.org)
recipe_engine:
  https://crrev.com/d84fead2a2eb7e0fe72c928fca0086df619509d9 Fix recipes.py test train when on-disk expectation files are invalid (phajdan.jr@chromium.org)
  https://crrev.com/68d2ac243180dbd51a1c3a672874d072235f961a [third_party] vendor argparse. (iannucci@chromium.org)
  https://crrev.com/ffe0201f64d5cd7b2cd6a458f8f1414a012a7daa [recipes.py] Move fetch, lint and bundle parsers to separate modules. (iannucci@chromium.org)
  https://crrev.com/0fa4d3588d8cb91e8da2247418b68a228a090891 [recipes.py] move depgraph arg parsing to its module (iannucci@chromium.org)
  https://crrev.com/a8d7f3279c321895575723d7e56e5798fd34b9bb Use "vpython" to bootstrap the recipe engine. (dnj@chromium.org)
  https://crrev.com/3cc22baad1f5cad990a9b0f7428ccf3627063e5f [recipes.py] move autoroll arg parsing to its module (iannucci@chromium.org)
  https://crrev.com/0b1247f8506739b0c6d6adc1f8145cb4d0d3cda8 [recipes.py] move remote arg parsing to its module (iannucci@chromium.org)
  https://crrev.com/bcf9286338730769356d98e274b71e1b6418f487 [recipes.py] move refs arg parsing to its module (iannucci@chromium.org)
  https://crrev.com/b6829668a6408ae319f98651864da96c59a8762c [recipes.py] move doc arg parsing to its module (iannucci@chromium.org)
  https://crrev.com/db10da8f2f560285dcb5f3d7638fcf69011e2326 [recipes.py] move test arg parsing to its module (iannucci@chromium.org)
  https://crrev.com/19f9db6216068ce8f6af43e95f80bd8954b256bd [recipes.py] move run arg parsing to its module. (iannucci@chromium.org)
  https://crrev.com/088cc7b5423bcf53a6545ac3483ed2a891ae723f [recipes.py] add missing helpstrings, merge test subcommands into main parser. (iannucci@chromium.org)
  https://crrev.com/73d1232b112d420c35023b2c8536f7f473cc61d0 [recipes.py] move common arg parsing to separate module. (iannucci@chromium.org)
  https://crrev.com/aa45f3d6a7daaf1d32c1efeda9645e2f134fc959 [autoroll] add tests for autoroll subcommand parsing. (iannucci@chromium.org)
  https://crrev.com/b88c9ec7e384c253a3d7839e00281c981f0eb87b [fetch] add tests for fetch subcommand parsing. (iannucci@chromium.org)
  https://crrev.com/67155798c0f28a983602c6c4760cacb82620b9be [test] add tests for test subcommand parsing. (iannucci@chromium.org)
  https://crrev.com/974abeac59bf52bfc6e3e9cee01fa729156154f4 [recipes.py] use argparse to set command automatically. (iannucci@chromium.org)
  https://crrev.com/11737a0978310326dcf0607c7532ade24f696c3d [lint] Fix lint to not raise an exception at the end. (iannucci@chromium.org)
  https://crrev.com/6816f322872665a9646feef369819f9c010b6ba1 vpython: Add pyOpenSSL, pull in Windows bugfix. (dnj@google.com)
  https://crrev.com/991fdf7d421a863eff087df095d0fd76b1cf3104 [fetch] capture stderr to reduce extraneous noise. (iannucci@chromium.org)
  https://crrev.com/af7abb5d24a477ca062c054034fe6b5cd44f17c5 [doc] Initial markdown doc generation. (iannucci@chromium.org)
  https://crrev.com/a582c6db898c82dec83aeb353431fc51d62591e6 [doc] fix doc to work in all known repos. (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id203a5a035c6032f55604293b7b447665aa567a2
Reviewed-on: https://skia-review.googlesource.com/15183
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agoReland: Remove SkLights include from SkCanvas.h
Florin Malita [Tue, 2 May 2017 19:33:01 +0000 (15:33 -0400)]
Reland: Remove SkLights include from SkCanvas.h

SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
works fine).

Change-Id: I3ed97cd7861e51dcb7cfa7950a97b420dbc6fbfb
TBR=reed@google.com
Reviewed-on: https://skia-review.googlesource.com/15143
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
7 years agoRoll recipe dependencies (nontrivial).
recipe-roller [Wed, 3 May 2017 12:32:29 +0000 (05:32 -0700)]
Roll recipe dependencies (nontrivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM+CQ.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5aeaa309400b74958fe31ae1c6bcb02b5c234ef1 Bisect - Macbook air/pro builders got mixed up. (simonhatch@chromium.org)
  https://crrev.com/f39ac3f107a8aad2852c5d9f6130aaad6320999a Remove remove_system_webview and disable_system_chrome args. (mikecase@google.com)
  https://crrev.com/ea628f4f2f2aee5d2c12d23f778aa7e83fb3ebe5 OWNERS for libfuzzer stuff: remove aizatsky@, add mmoroz@. (mmoroz@chromium.org)
  https://crrev.com/3c24183bd79cd763ee7c93d62e3cb6920a05b2ad Add "luci-go-web-packager" builder. (dnj@chromium.org)
  https://crrev.com/1ba91448466d5d6bbc75497a11e828dead54be08 Add tests for chromium_tests recipe module (patch #2) (phajdan.jr@chromium.org)
  https://crrev.com/4ec89ab8b30ff37cf12aad7c4cd1be609a98157c Support ranges of hostnames in builders.pyl. (dpranke@chromium.org)
  https://crrev.com/d0902ccf0320ae6a7ecd153439d366c0a5297adf Remove chromite config recipe configuration values that are no longer needed. (dgarrett@google.com)
  https://crrev.com/97c081d4dab9da4dcf36458d405928127f64c453 Add host poisoning and host valgrind. (ngeoffray@google.com)
  https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf WebRTC: Add video quality loopback test to android. Take 6 (oprypin@chromium.org)
  https://crrev.com/b61656b9936b78029aacaac9edc3c3581ec7c350 Fix valgrind bots and adjust number of threads on fugu. (ngeoffray@google.com)
  https://crrev.com/852bdd6b4047712be00b491f51e075af89c31c3d Set the number of threads for valgrind. (ngeoffray@google.com)
  https://crrev.com/902c9df1c55e10db441703cbbaea9e5f72165e0a WebRTC: Skip video_quality_loopback_test on Android K perf bot. (kjellander@chromium.org)
  https://crrev.com/42e4bfb3015ab4ed39433ce882162ff5d5d71834 Add tests for chromium_tests recipe module (patch #3) (phajdan.jr@chromium.org)
depot_tools:
  https://crrev.com/644a1d87e6ff99a19bfa2541ac03ee51deef589f Stop passing deprecated manifest flag to bot_update (machenbach@chromium.org)
  https://crrev.com/78628da995e92c2cc371de65a90142f8a91b62bf [cipd.ps1] catch CommandNotFoundException if git is not available yet (iannucci@chromium.org)
  https://crrev.com/df6e7348b977771d51162cb85bead08c883ca7ad Fix addition of CQ_INCLUDE_TRYBOTS on Gerrit. (kbr@chromium.org)
  https://crrev.com/20d2cbb8f59164f3e44b03600152e981dd0a23bd gerrit_util: Fix name of conn object data member (agable@chromium.org)
recipe_engine:
  https://crrev.com/c0617faf2648170732bec7f4f5139ac706fe1ebd [recipes.py] make `--properties-file -` work correctly again. (iannucci@chromium.org)
  https://crrev.com/77da3ca06f0c46b613b51eea0cf2186c7e8b58c9 [recipes.py] remove get_package_config. (iannucci@chromium.org)
  https://crrev.com/f162918ed7c917f187c8098b88e4fd02b82e06aa [recipes.py] refactor common argument parsing, directly validate --package (iannucci@chromium.org)
  https://crrev.com/ce0d4e67ec52fcf2aa662635e110a5427aaa4a09 [json] add dumps method to test_api. (iannucci@chromium.org)
  https://crrev.com/8b7295c5344ed0cb6ed7843f9df2c6b58a015fe5 [recipes.py] refactor loading for operational_arguments. (iannucci@chromium.org)

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id2483f1a5f46ca1c5f374b327ab4f0d0f96306a2
Reviewed-on: https://skia-review.googlesource.com/15182
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
7 years agoremove unused etc logic
Mike Reed [Wed, 3 May 2017 12:28:03 +0000 (08:28 -0400)]
remove unused etc logic

Bug: skia:
Change-Id: I913d348910db0b6ab930c4c5566ba9eb2320550e
Reviewed-on: https://skia-review.googlesource.com/15181
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>

7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 12:01:52 +0000 (05:01 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/99164f601e87f07d382889014617f15bca75f20b Revert "WebRTC: Add video quality loopback test to android. Take 5" (oprypin@chromium.org)
depot_tools:
  https://crrev.com/86989d7b0f709d43a4f48b8e7a17a111576c96fc Reland "Remove obsolete bot_update flag" (machenbach@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3ad013e2122a3cddb98d1d7dda0c60fc4c0249d1
Reviewed-on: https://skia-review.googlesource.com/15180
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agoRoll recipe dependencies (nontrivial).
recipe-roller [Wed, 3 May 2017 11:22:06 +0000 (04:22 -0700)]
Roll recipe dependencies (nontrivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM+CQ.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/44178cbebda775224e182b2fb0185b068dd0f72f WebRTC: Add additional solution for App Engine to Android perf bots. (kjellander@chromium.org)
recipe_engine:
  https://crrev.com/944125e6d1e8c831d09517bde658a38d8f81db37 Sort step presentation properties (machenbach@chromium.org)

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib2118f9d6c3e4a6877071694758b073623f88006
Reviewed-on: https://skia-review.googlesource.com/15159
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
7 years agoRoll recipe dependencies (trivial).
recipe-roller [Wed, 3 May 2017 10:42:16 +0000 (03:42 -0700)]
Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/05849d490d68fc3ca382dffe669e266b911d348b Show ninja stats on buildbots for goma canary (tikuta@google.com)
  https://crrev.com/96931083f84ce2e97e2d113a66b1fa06b58ed45d Remove direct read accesses to got_revision_mapping (machenbach@chromium.org)
  https://crrev.com/322e14b72577780d070d35723d46f7bc3e2fb81f Migrate V8 to use reversed got_revision mapping (machenbach@chromium.org)
  https://crrev.com/96bf6abc2c3cdc7b6b507929856dadf0b10871da V8: Remove obsolete bot_update flag (machenbach@chromium.org)
  https://crrev.com/30f8d6920b96bc43f9cd6cc63a99b95666398cb8 Switch ART recipes to use the CC collector by default. (rpl@google.com)
  https://crrev.com/9d20a223d82b56419650d8fccbc85e05d81ca140 LogDog: Emit build URL as LogDog tag. (dnj@chromium.org)
  https://crrev.com/1e18cf82c804945ff13c0b76fc872064f507f222 Revert "V8: Add link to docu in email." (franzih@chromium.org)
  https://crrev.com/4b06433ab99bee20b6b7fbce757f283ebc3001f5 Use depot_tools/{gitiles,url} modules. (dnj@chromium.org)
  https://crrev.com/379bf75cbf69331d7de1f031dd8bda4f7ccc662c chromium_tests: merge blink-paths subproject tag into blink (phajdan.jr@chromium.org)
  https://crrev.com/a833692a37332eda054a14ca211cfcffb6c0dce0 [Findit] Removing deprecated variable builder (lijeffrey@google.com)
  https://crrev.com/5bd3e7cb3b4567559ee8a3abd02170aaa5ef9eb8 Add Clang Static Analyzer to Trybot master+slave cfgs. (kmarshall@chromium.org)
  https://crrev.com/7f72c322020fed7782b50a3cf6d249d45811818f Add tests for chromium_tests recipe module (patch #1) (phajdan.jr@chromium.org)
  https://crrev.com/0ddf064628fa2bdffb88283de0beb2238e564787 Add build failure notifications for AFL/libFuzzer. (ochang@chromium.org)
  https://crrev.com/499ddadadfc9023a02977bef7bc7a13395520bbd Restrict Clang analysis build to Chrome non-test sources. (kmarshall@chromium.org)
  https://crrev.com/4bdf52d9e622aff6dca23b1d75bb48b160ecb123 Add target chrome for goma client canary bots (tikuta@google.com)
  https://crrev.com/7e47d24e24657520905e8025882c5a86f819c914 Fix LocalOutputCache mac builder name (shinyak@google.com)
  https://crrev.com/28e22583e822093cd3f29ce43437e991bd8b2959 Update master.chromium.mac to include a newly added 10.12 slave. (erikchen@chromium.org)
  https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac WebRTC: Add video quality loopback test to android. Take 5 (oprypin@chromium.org)
depot_tools:
  https://crrev.com/c180dc40305d69db346d9e6369dd8dcd87076be8 Remove directly accessing got_revision_mapping (machenbach@chromium.org)
  https://crrev.com/72048266d5cf68dc06c2cd20e173fbcb6f0dcfd2 Remove obsolete bot_update flag (machenbach@chromium.org)
  https://crrev.com/c91686c087704f3aeea594e6b7c82767fa7d753b Revert "Remove obsolete bot_update flag" (machenbach@chromium.org)
recipe_engine:
  https://crrev.com/9715f08144e7d8a8d7d543fa2cb5d266ae289849 Whitelist "hashlib" for import. (dnj@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib754858b9ef6d1bc8d10f676f99d7b9cb31173ca
Reviewed-on: https://skia-review.googlesource.com/15158
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7 years agook, add sRGB support
Mike Klein [Wed, 3 May 2017 01:04:34 +0000 (21:04 -0400)]
ok, add sRGB support

Change-Id: Ic375a593bcf67aad0d7bd0847ea6bcd0b9ac4ab6
Reviewed-on: https://skia-review.googlesource.com/15160
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agofix tricolor shader
Mike Reed [Tue, 2 May 2017 21:01:08 +0000 (17:01 -0400)]
fix tricolor shader

1. map pixel-centers through inverse (correctness)
2. forward-difference srcXY in loop (perf)

Lots of minor (but correct) changes in GMs

Bug: skia:6578
Change-Id: I2ad2ef939f58373d33212d4056c7d2f63eaafe0e
Reviewed-on: https://skia-review.googlesource.com/15153
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
7 years agoRemove translateZ and lights from SkCanvas
Jim Van Verth [Tue, 2 May 2017 20:49:24 +0000 (16:49 -0400)]
Remove translateZ and lights from SkCanvas

Bug: skia:6557
Change-Id: I0dbf70c4131ab59e7fc6c674a6587767af98e13a
Reviewed-on: https://skia-review.googlesource.com/15151
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
7 years agoRevert "eliminated GrGLSLExpr"
Brian Salomon [Tue, 2 May 2017 21:07:25 +0000 (21:07 +0000)]
Revert "eliminated GrGLSLExpr"

This reverts commit 93f20f5629e52eed732d2b9d6dbbb351cc30b2cd.

Reason for revert: Mismerge readded deleted files.

Original change's description:
> eliminated GrGLSLExpr
>
> Now that skslc performs all of the optimizations (and then some) that
> GrGLSLExpr is responsible for, it's just extra work for no benefit.
>
> Bug: skia:
> Change-Id: I40b0629e00a33873ed9fc6c0a9f41d8350221f9a
> Reviewed-on: https://skia-review.googlesource.com/14560
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
>

TBR=bsalomon@google.com,ethannicholas@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ia8b723594527afe34489fc78a4b49039081b6390
Reviewed-on: https://skia-review.googlesource.com/15154
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

7 years agoSupport numerical transfer functions in readPixels()
Matt Sarett [Tue, 2 May 2017 20:19:51 +0000 (16:19 -0400)]
Support numerical transfer functions in readPixels()

Let's do this because:
(1) We can.
(2) Android and Chrome have asked for it.
(3) It will simplify the implementation of SkImage::makeColorSpace().

Bug: skia:
Change-Id: Ia3c322b8a58c79ad67cdebe744e0623bd59dcffd
Reviewed-on: https://skia-review.googlesource.com/15148
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoAdd support for row-by-row jpeg encoding
Matt Sarett [Tue, 2 May 2017 20:04:56 +0000 (16:04 -0400)]
Add support for row-by-row jpeg encoding

Reland of:
https://skia-review.googlesource.com/c/14641/

Bug: 713862
Change-Id: I9dca5ede4ebf569c5f80edcfb23a506b6cfa935e
Reviewed-on: https://skia-review.googlesource.com/15144
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoRevert "Revert "Remove copyTo() legacy API flag from bzl""
Matt Sarett [Tue, 2 May 2017 20:36:18 +0000 (20:36 +0000)]
Revert "Revert "Remove copyTo() legacy API flag from bzl""

This reverts commit d271ba268876d3feca13e02d0a92ecaf79b6ddfc.

Reason for revert: Client failures should be fixed.  Will keep an eye on the roller.

Original change's description:
> Revert "Remove copyTo() legacy API flag from bzl"
>
> This reverts commit 65083e444c03cedecf45bc38bb8fea27e91e0a9e.
>
> Reason for revert: Causes build failures.
>
> Original change's description:
> > Remove copyTo() legacy API flag from bzl
> >
> > NOTRY=true
> >
> > Bug: skia:6464
> > Change-Id: Ia3935998960054df9e54cfb2aead66549c629c04
> > Reviewed-on: https://skia-review.googlesource.com/15001
> > Reviewed-by: Matt Sarett <msarett@google.com>
> > Commit-Queue: Matt Sarett <msarett@google.com>
> >
>
> TBR=msarett@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I9d82c7b699e106238981e32553e975c91e42cfb8
> Reviewed-on: https://skia-review.googlesource.com/15021
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
>

TBR=benjaminwagner@google.com,msarett@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ie9c9c1f8d06c8b422b8902e39645cd0d887d6b49
Reviewed-on: https://skia-review.googlesource.com/15150
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoAdd wireframe mode to Viewer.
Jim Van Verth [Tue, 2 May 2017 20:15:53 +0000 (16:15 -0400)]
Add wireframe mode to Viewer.

Change-Id: I0ff11088465a4702acf9841a791d76f286ddbaf1
Reviewed-on: https://skia-review.googlesource.com/15147
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
7 years agoeliminated GrGLSLExpr
Ethan Nicholas [Tue, 2 May 2017 19:37:57 +0000 (15:37 -0400)]
eliminated GrGLSLExpr

Now that skslc performs all of the optimizations (and then some) that
GrGLSLExpr is responsible for, it's just extra work for no benefit.

Bug: skia:
Change-Id: I40b0629e00a33873ed9fc6c0a9f41d8350221f9a
Reviewed-on: https://skia-review.googlesource.com/14560
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
7 years agospeedup exp() in gaussian colorfilter
Mike Reed [Tue, 2 May 2017 19:13:43 +0000 (15:13 -0400)]
speedup exp() in gaussian colorfilter

~20% faster
differs in low 1 from prev impl

Bug: skia:
Change-Id: If7aa7f5523f15a5424ebf5a09313c5e1d43e1a1f
Reviewed-on: https://skia-review.googlesource.com/15105
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
7 years agoManually roll skia recipe deps.
John Budorick [Sat, 29 Apr 2017 01:59:04 +0000 (18:59 -0700)]
Manually roll skia recipe deps.

This includes:
 recipes-py:  https://chromium.googlesource.com/external/github.com/luci/recipes-py/+log/f5e47cfc28b5964701572db12f96c7a5a3f1821a..554e8878ac6395262dc3c90bbb8a100ee844f766
 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/109907e6a95ae0301b1564c76c4a3e9d15e19366..1e71b8bdf0913b306b28141192272350cf68cdc2
 tools/build: https://chromium.googlesource.com/chromium/tools/build/+log/f7b41106d64b6517c67343f2cfb03f4a9d62afc2..dcca7cbe7ecda2c4d511f38c6f3eab29cad08cf7

The ranges include my generic postprocess/merge change in tools/build
that had been failing to roll over in https://skia-review.googlesource.com/c/13920/
along with a few corresponding fixes.

Change-Id: I7e328bdb3acfc9b4c219e408c226f181f3b05f3d
Reviewed-on: https://skia-review.googlesource.com/14678
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
7 years agoSetup support for UNIFORM_TEXEL_BUFFER descriptor sets in Vulkan
Greg Daniel [Tue, 2 May 2017 18:01:43 +0000 (14:01 -0400)]
Setup support for UNIFORM_TEXEL_BUFFER descriptor sets in Vulkan

This is the first CL to get support for using texel buffers in vulkan.

Bug: skia:
Change-Id: Iaac5ba4a356b487bc2b63111cca34ed968881f6b
Reviewed-on: https://skia-review.googlesource.com/15100
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

7 years agosksl support for buffer blocks
Ethan Nicholas [Mon, 1 May 2017 20:57:07 +0000 (16:57 -0400)]
sksl support for buffer blocks

Bug: skia:
Change-Id: Ic2cabaf2c7fb23cec7863f2b6152bbed133e0886
Reviewed-on: https://skia-review.googlesource.com/14947
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

7 years agoRemove EXPERIMENTAL_SHADOWING, Part 1
Jim Van Verth [Tue, 2 May 2017 14:37:45 +0000 (10:37 -0400)]
Remove EXPERIMENTAL_SHADOWING, Part 1

Bug: skia:6557
Change-Id: I6482d74be7b360c93141a73dd80c67854530c7a1
Reviewed-on: https://skia-review.googlesource.com/15101
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoRevert "Add support for row-by-row jpeg encoding"
Leon Scroggins [Tue, 2 May 2017 17:08:28 +0000 (17:08 +0000)]
Revert "Add support for row-by-row jpeg encoding"

This reverts commit 9b848d5749c5e34b56f927a3a3374c8ebafbd9db.

Reason for revert: ASAN reports leaked memory [1]. Google3 reports a "delete size mismatch" [2], which I suspect is the same issue.

[1] https://chromium-swarm.appspot.com/task?id=35e2c9fa9eac6310&refresh=10&show_raw=1
[2] https://test.corp.google.com/ui#cl=154838904&flags=CAMQBQ==&id=OCL:154838904:BASE:154839043:1493741642370:9c96115f&t=//chrome/skia/dm_wrapper:dm_wrapper

Original change's description:
> Add support for row-by-row jpeg encoding
>
> Bug: 713862
> Change-Id: I787b7c49662a00b89ae0ef35845dfbd6be3e6fb1
> Reviewed-on: https://skia-review.googlesource.com/14641
> Commit-Queue: Matt Sarett <msarett@google.com>
> Reviewed-by: Leon Scroggins <scroggo@google.com>
>

TBR=msarett@google.com,scroggo@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ic5a8d67e0d4a7733662586055ceff086a2ab335d
Reviewed-on: https://skia-review.googlesource.com/15140
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>

7 years agoAdd support for row-by-row jpeg encoding
Matt Sarett [Tue, 2 May 2017 15:32:42 +0000 (11:32 -0400)]
Add support for row-by-row jpeg encoding

Bug: 713862
Change-Id: I787b7c49662a00b89ae0ef35845dfbd6be3e6fb1
Reviewed-on: https://skia-review.googlesource.com/14641
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
7 years agoFix VkWrapTest
Greg Daniel [Tue, 2 May 2017 15:39:10 +0000 (11:39 -0400)]
Fix VkWrapTest

Fix current breakage on bots.

Bug: skia:
Change-Id: I4b60ef85d941a179d76cccc1a468aaa6437caddc
Reviewed-on: https://skia-review.googlesource.com/15104
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

7 years agoBlacklist memory intensive images on a bot
Leon Scroggins III [Tue, 2 May 2017 15:14:31 +0000 (11:14 -0400)]
Blacklist memory intensive images on a bot

Test-Win8-MSVC-Golo-CPU-AVX-x86-Debug is running out of memory running
interlaced image decoding tests. Stop running them on this particular
bot (others are still running them). For simplicity, also blacklist
the RAW images that have had similar problems on other devices.

Change-Id: I1071ca2f59ef26b9a9798924f2eefa0483017439
Reviewed-on: https://skia-review.googlesource.com/15074
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
7 years agoRevert "Remove SkLights include from SkCanvas.h"
Florin Malita [Tue, 2 May 2017 15:41:57 +0000 (15:41 +0000)]
Revert "Remove SkLights include from SkCanvas.h"

This reverts commit 9ff301bf918cd85d9f67047f10631b7a74345a90.

Reason for revert: need to update G3, Flutter.

Original change's description:
> Remove SkLights include from SkCanvas.h
>
> SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
> works fine).
>
> Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f
> Reviewed-on: https://skia-review.googlesource.com/14904
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Florin Malita <fmalita@chromium.org>
>

TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I4799ad5b31aaeaf529c8b912bbe09aa8869a5e6c
Reviewed-on: https://skia-review.googlesource.com/15107
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoReland "Add a clip mask bench"
Florin Malita [Tue, 2 May 2017 15:09:01 +0000 (11:09 -0400)]
Reland "Add a clip mask bench"

Change-Id: Iefbfd1ecec38d3db5bac4370c75e6701aa03076f
TBR=reed@google.com
Reviewed-on: https://skia-review.googlesource.com/15102
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoRemove SkLights include from SkCanvas.h
Florin Malita [Mon, 1 May 2017 17:22:11 +0000 (13:22 -0400)]
Remove SkLights include from SkCanvas.h

SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
works fine).

Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f
Reviewed-on: https://skia-review.googlesource.com/14904
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoFix up shadows in raster.
Jim Van Verth [Mon, 1 May 2017 20:06:48 +0000 (16:06 -0400)]
Fix up shadows in raster.

* Re-enable shadow blurs for raster circles and rrects
* Fix up the tessellation as much as possible to remove skinny triangles

Bug: skia:6425
Change-Id: I6548055084bc8596a052bcd3cec852766e084ba2
Reviewed-on: https://skia-review.googlesource.com/14943
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

7 years agoMake GrBackendTexture take Gr*Info refs in ctor, and copy them.
Greg Daniel [Wed, 26 Apr 2017 17:29:21 +0000 (13:29 -0400)]
Make GrBackendTexture take Gr*Info refs in ctor, and copy them.

Bug: skia:
Change-Id: Ic05d3384fa07560fc18c52bb8ae03541a72515f7
Reviewed-on: https://skia-review.googlesource.com/14374
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
7 years agoRemove declaration of SkTextureImageSetTexture, which does not exist
Brian Osman [Tue, 2 May 2017 13:36:17 +0000 (09:36 -0400)]
Remove declaration of SkTextureImageSetTexture, which does not exist

Bug: skia:
Change-Id: Ifb7edcae491ef48fbc69324d9dfb97a298104db9
Reviewed-on: https://skia-review.googlesource.com/15073
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

7 years agoExpose resetForNextPicture in SkNoDrawCanvas
Adrienne Walker [Mon, 1 May 2017 20:45:01 +0000 (13:45 -0700)]
Expose resetForNextPicture in SkNoDrawCanvas

SkRecorder has some private Skia behavior with the way it handles an
SkNoDrawCanvas that is not exposed.  In particular, it's able to create
an arbitrary SkIRect device clip at construction time.

This is a performance optimization when reusing SkNoDrawCanvas across
multiple recordings instead of reconstructing a new canvas every time.

https://codereview.chromium.org/2768143002 is trying to implement
another version of SkPictureBuilder/SkRecorder and so wants to be able
to use similar SkNoDrawCanvas behavior.

Change-Id: I0ac5f0eef8f0548cefd7354062311667cf448b07
Reviewed-on: https://skia-review.googlesource.com/11320
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agocolorspaceinfo tool: Add flag to indicate that the input is an icc profile
Matt Sarett [Mon, 1 May 2017 21:52:56 +0000 (17:52 -0400)]
colorspaceinfo tool: Add flag to indicate that the input is an icc profile

Bug: skia:
Change-Id: Ieb5cff92bae1aa64df5bc7f3a398514fe5b20f77
Reviewed-on: https://skia-review.googlesource.com/14956
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoRemove legacy pixelref flag from bzl
Matt Sarett [Mon, 1 May 2017 21:57:27 +0000 (17:57 -0400)]
Remove legacy pixelref flag from bzl

NOTRY=true

Bug: skia:6535
Change-Id: I29d786cef240aaeaca829b4a9a25ff1a8f078588
Reviewed-on: https://skia-review.googlesource.com/15000
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoRevert "Remove copyTo() legacy API flag from bzl"
Ben Wagner [Tue, 2 May 2017 01:19:03 +0000 (01:19 +0000)]
Revert "Remove copyTo() legacy API flag from bzl"

This reverts commit 65083e444c03cedecf45bc38bb8fea27e91e0a9e.

Reason for revert: Causes build failures.

Original change's description:
> Remove copyTo() legacy API flag from bzl
>
> NOTRY=true
>
> Bug: skia:6464
> Change-Id: Ia3935998960054df9e54cfb2aead66549c629c04
> Reviewed-on: https://skia-review.googlesource.com/15001
> Reviewed-by: Matt Sarett <msarett@google.com>
> Commit-Queue: Matt Sarett <msarett@google.com>
>

TBR=msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I9d82c7b699e106238981e32553e975c91e42cfb8
Reviewed-on: https://skia-review.googlesource.com/15021
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoAdded A2B support to colorspaceinfo tool
Matt Sarett [Mon, 1 May 2017 21:42:20 +0000 (17:42 -0400)]
Added A2B support to colorspaceinfo tool

Tool now parses A2B images/profiles.
Tool can now display a cross-section based visualization for the color
look-up tables in A2B profiles.

BUG=skia:

Change-Id: I68abb3e947b080c533e283783d7859feea8d35d6
Reviewed-on: https://skia-review.googlesource.com/6119
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
7 years agoRemove copyTo() legacy API flag from bzl
Matt Sarett [Mon, 1 May 2017 22:03:39 +0000 (18:03 -0400)]
Remove copyTo() legacy API flag from bzl

NOTRY=true

Bug: skia:6464
Change-Id: Ia3935998960054df9e54cfb2aead66549c629c04
Reviewed-on: https://skia-review.googlesource.com/15001
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoRevert "Revert "SaveLayerRec::fClipMask -> raw pointer""
Mike Klein [Mon, 1 May 2017 21:34:14 +0000 (21:34 +0000)]
Revert "Revert "SaveLayerRec::fClipMask -> raw pointer""

This reverts commit 3354969a4a4adcea159f3a0b01ad0a7c04fc9115.

Reason for revert: not the problem?

Original change's description:
> Revert "SaveLayerRec::fClipMask -> raw pointer"
>
> This reverts commit a6b72cb5729306fdd676d739c1e2c53afa0786a7.
>
> Reason for revert: red bots
>
> Original change's description:
> > SaveLayerRec::fClipMask -> raw pointer
> >
> > Use raw pointers for optional clip mask plumbing, to match the backdrop
> > API.
> >
> > Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2
> > Reviewed-on: https://skia-review.googlesource.com/14901
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
> >
>
> TBR=fmalita@chromium.org,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I4387620cdc3410018af9cef221e5cf8d09015380
> Reviewed-on: https://skia-review.googlesource.com/14955
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
>

TBR=mtklein@chromium.org,reviews@skia.org,fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I6dde9e0441928f7a7423139a5c39f520f892f4b5
Reviewed-on: https://skia-review.googlesource.com/14958
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoRevert "Add a clip mask bench"
Mike Klein [Mon, 1 May 2017 21:33:55 +0000 (21:33 +0000)]
Revert "Add a clip mask bench"

This reverts commit c59a38d12dce287427f3d3fe1d4b3ad8052cda35.

Reason for revert: whoops, sorry, this one must have been the problem.

Original change's description:
> Add a clip mask bench
>
> Change-Id: I230729492fc23e290136f7d62610abe5ca51c067
> Reviewed-on: https://skia-review.googlesource.com/14941
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Florin Malita <fmalita@chromium.org>
>

TBR=fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ifbd74a8985ebaa95e54032aaaa2891b0f1b67940
Reviewed-on: https://skia-review.googlesource.com/14957
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoRevert "SaveLayerRec::fClipMask -> raw pointer"
Mike Klein [Mon, 1 May 2017 21:31:32 +0000 (21:31 +0000)]
Revert "SaveLayerRec::fClipMask -> raw pointer"

This reverts commit a6b72cb5729306fdd676d739c1e2c53afa0786a7.

Reason for revert: red bots

Original change's description:
> SaveLayerRec::fClipMask -> raw pointer
>
> Use raw pointers for optional clip mask plumbing, to match the backdrop
> API.
>
> Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2
> Reviewed-on: https://skia-review.googlesource.com/14901
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Florin Malita <fmalita@chromium.org>
>

TBR=fmalita@chromium.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I4387620cdc3410018af9cef221e5cf8d09015380
Reviewed-on: https://skia-review.googlesource.com/14955
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoAdd a clip mask bench
Florin Malita [Mon, 1 May 2017 20:27:02 +0000 (16:27 -0400)]
Add a clip mask bench

Change-Id: I230729492fc23e290136f7d62610abe5ca51c067
Reviewed-on: https://skia-review.googlesource.com/14941
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoSaveLayerRec::fClipMask -> raw pointer
Florin Malita [Mon, 1 May 2017 16:17:12 +0000 (12:17 -0400)]
SaveLayerRec::fClipMask -> raw pointer

Use raw pointers for optional clip mask plumbing, to match the backdrop
API.

Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2
Reviewed-on: https://skia-review.googlesource.com/14901
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agofinish up constants
Mike Klein [Mon, 1 May 2017 20:01:38 +0000 (16:01 -0400)]
finish up constants

For whatever reason, if I swap the condition in the if_then_else tests
from < to >= and swap the then/else values, I can use constants in
hsl_to_rgb.  Still don't understand why, but I'll take it.  I suspect it
has something to do with SSE, IEEE, and NaN, but I don't care enough to
speculate any more concretely.

This does that, removes C() and _f, updates some comments, and adds a
guard in build_stages.py to yell if it sees trouble like LCPI40_4...

This reminds me to try -ffast-math soon.  I think that was mostly held
back by constants.

Change-Id: I3f8a37a4d4642f77422ce3261b750061e9e604a3
Reviewed-on: https://skia-review.googlesource.com/14942
Reviewed-by: Herb Derby <herb@google.com>
7 years agorefactor hsl_to_rgb a touch
Mike Klein [Mon, 1 May 2017 19:34:01 +0000 (15:34 -0400)]
refactor hsl_to_rgb a touch

This rewrites the existing logic to expose more of the symmetries,
and especially to make them clearly identical subexpressions.

I think it's clear that the intent in hue_to_rgb is to wrap the t value
back into 0-1... that's t = fract(t).

No GM diffs.

Change-Id: I9d62d8f80bcb45711ee334f953d3f6410e068ce4
Reviewed-on: https://skia-review.googlesource.com/14940
Reviewed-by: Herb Derby <herb@google.com>
7 years agoUpdate Nexus6p to Android O developer release.
Ben Wagner [Mon, 1 May 2017 15:24:17 +0000 (11:24 -0400)]
Update Nexus6p to Android O developer release.

No-Try: true
Change-Id: I1b39d3548d0979385b24558170fdcd6d766a63bd
Reviewed-on: https://skia-review.googlesource.com/14900
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agofix t / t2 confusion in hsl_to_rgb
Mike Klein [Mon, 1 May 2017 18:56:04 +0000 (14:56 -0400)]
fix t / t2 confusion in hsl_to_rgb

I think the original[1] SkRasterPipeline_opts.h version had a typo that
I faithfully copied over to hsl_to_rgb.  In Hue2RGB[2], the scalar
equivalent of hue_to_rgb, we mutate t to keep it in 0-1 range[3].  In
the SkRasterPipeline_opts.h code we introduced a new value t2 instead,
and then used it everywhere, but accidentally typed 't' in the t < 1/6 case.

The expression "p + (q - p)*6.0f*t" should have been "p + (q - p)*6.0f*t2".

This fixes things by changing t in place, much like Hue2RGB does.

The GM doesn't change anywhere, which is troubling.

[1] https://skia-review.googlesource.com/c/7460/21/src/opts/SkRasterPipeline_opts.h#808
[2] https://skia-review.googlesource.com/c/7460/21/src/effects/SkHighContrastFilter.cpp#26
[3] I think this whole clamp should probably become "t = fract(t)".
    Will follow up.

Change-Id: I3dcc1a79ffae46830178d931844ee3113f8bdfd1
Reviewed-on: https://skia-review.googlesource.com/14910
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agogetting close on float constants
Mike Klein [Mon, 1 May 2017 18:22:10 +0000 (14:22 -0400)]
getting close on float constants

I think I'm now down to just the constants used in comparisons in
hsl_to_rgb... so weird.  I don't get what's special about this code.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win7-MSVC-Golo-CPU-AVX-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE41,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE2

Change-Id: I398139f00371bdbc45281a49bca56d02ba59cba9
Reviewed-on: https://skia-review.googlesource.com/14909
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoSkFontMgr::matchFamily should not crash on nullptr.
bungeman [Mon, 1 May 2017 17:02:42 +0000 (13:02 -0400)]
SkFontMgr::matchFamily should not crash on nullptr.

While all systems can resolve a font from just a style request
(without a name) almost no systems specify a default font family.

BUG=skia:6574

Change-Id: If7c81808b62cd5d8212bce2eb4d9c476c45af80a
Reviewed-on: https://skia-review.googlesource.com/14902
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
7 years agosome float constants
Mike Klein [Mon, 1 May 2017 16:56:35 +0000 (12:56 -0400)]
some float constants

Trying to go slowly to find where problems arise.
Weirdly, I think I got everything except hsl_to_rgb.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win7-MSVC-Golo-CPU-AVX-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE41,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE2

Change-Id: I4d85a4c1f40bd87e7cb18fc9b5ce020812dc31db
Reviewed-on: https://skia-review.googlesource.com/14905
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoBlacklist SkImage_makeTextureImage on NVIDIA Win10 Vulkan
Leon Scroggins III [Mon, 1 May 2017 17:09:42 +0000 (13:09 -0400)]
Blacklist SkImage_makeTextureImage on NVIDIA Win10 Vulkan

Bug: skia:6554
Change-Id: I7c1086ce6afff84c1b1463ec58c2c6a9949aaa2e
Reviewed-on: https://skia-review.googlesource.com/14907
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>

7 years agoFix Creation of GrBackendRenderTarget from GrBackendRenderTargetDesc in GL
Greg Daniel [Mon, 1 May 2017 17:04:22 +0000 (13:04 -0400)]
Fix Creation of GrBackendRenderTarget from GrBackendRenderTargetDesc in GL

Bug: skia:
Change-Id: I970e7bc36ae799996f9b28e70f97cb7ce4382eb2
Reviewed-on: https://skia-review.googlesource.com/14906
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

7 years agoOnly store width and height on SkPixelRef (last part)
Matt Sarett [Mon, 1 May 2017 15:12:47 +0000 (11:12 -0400)]
Only store width and height on SkPixelRef (last part)

Relanding https://skia-review.googlesource.com/c/14105/
in pieces to try to diagnose problems with the Chrome
roll.

Bug: skia:6535
Change-Id: Iefe4825b9ce9be999baeec8ab7ae6651f1caf451
Reviewed-on: https://skia-review.googlesource.com/14860
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoBlacklist testimgari.jpg on CG
Matt Sarett [Mon, 1 May 2017 13:13:05 +0000 (09:13 -0400)]
Blacklist testimgari.jpg on CG

Bug: skia:
Change-Id: I2c471d18f29bb6d0e8ac4a4d0afa1815788bb121
Reviewed-on: https://skia-review.googlesource.com/14825
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoRestore legacy SaveLayerRec ctor
Florin Malita [Mon, 1 May 2017 14:58:40 +0000 (10:58 -0400)]
Restore legacy SaveLayerRec ctor

Let's not break existing clients.

Change-Id: I056fefefb49d46fb284597c5bcf0319470537524
Reviewed-on: https://skia-review.googlesource.com/14829
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoFix merge conflict.
Ben Wagner [Mon, 1 May 2017 15:09:18 +0000 (11:09 -0400)]
Fix merge conflict.

I accidentally caused a merged conflict between
https://skia-review.googlesource.com/14656 and
https://skia-review.googlesource.com/14821

No-Try: true
Change-Id: Ib00b293019fddc3951a5d413744b9d186dd103d8
Reviewed-on: https://skia-review.googlesource.com/14840
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoRemove unnecessary SkFILEStream::getMemoryBase
Leon Scroggins III [Mon, 1 May 2017 14:31:27 +0000 (10:31 -0400)]
Remove unnecessary SkFILEStream::getMemoryBase

It overrides the SkStream:: version, but does the same thing.

Change-Id: I857f2119a85bb3f942707ab3cef58b45a2cf4b7a
Reviewed-on: https://skia-review.googlesource.com/14828
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>

7 years agoOnly store width and height on SkPixelRef (part 2)
Matt Sarett [Mon, 1 May 2017 14:22:31 +0000 (10:22 -0400)]
Only store width and height on SkPixelRef (part 2)

Relanding https://skia-review.googlesource.com/c/14105/
in pieces to try to diagnose problems with the Chrome
roll.

Bug: skia:6535
Change-Id: Iada034fc41ef315f7f00984d8de9d9cc2f361ad2
Reviewed-on: https://skia-review.googlesource.com/14657
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Reed <reed@google.com>
7 years agoOmit shapes_mixed_10000_32x33 on GTX960 ANGLE Release
Ben Wagner [Fri, 28 Apr 2017 21:13:32 +0000 (17:13 -0400)]
Omit shapes_mixed_10000_32x33 on GTX960 ANGLE Release

Bug: skia:6534
Change-Id: I5634b35c3a231da8b5714209889921933ca38962
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/14656
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoOmit HalfFloatAlphaTextureTest on CommandBuffer bot.
Ben Wagner [Fri, 28 Apr 2017 19:28:32 +0000 (15:28 -0400)]
Omit HalfFloatAlphaTextureTest on CommandBuffer bot.

Bug: chromium:697030
No-Try: true
Change-Id: Ib56c88c384e6b363aefe91c7027fa587d0b000b5
Reviewed-on: https://skia-review.googlesource.com/14648
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoAdd Swarming bot id and task id to recipe expectations.
Ben Wagner [Sun, 30 Apr 2017 15:14:51 +0000 (11:14 -0400)]
Add Swarming bot id and task id to recipe expectations.

No-Try: true
Change-Id: Idd748bf61ab3d6611b85472de5d3f3a25d4ae9ee
Reviewed-on: https://skia-review.googlesource.com/14821
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoRevert "Revert "Plumb the use of GrBackendRenderTarget throughout Skia""
Greg Daniel [Mon, 1 May 2017 13:50:58 +0000 (13:50 +0000)]
Revert "Revert "Plumb the use of GrBackendRenderTarget throughout Skia""

This reverts commit e3bd422fafc74dd3410c3de24a576635be92c3b4.

Reason for revert: Pre-req changes have all landed in other projects at this point.

Original change's description:
> Revert "Plumb the use of GrBackendRenderTarget throughout Skia"
>
> This reverts commit fdd77daedbba3b7c53be74a82fb9fae891b51696.
>
> Reason for revert: Apparently I have a few more build files to update before this can land.
>
> Original change's description:
> > Plumb the use of GrBackendRenderTarget throughout Skia
> >
> > Bug: skia:
> > Change-Id: Ib99a58d9552f5c7b8d77c09dcc72fa88326c26aa
> > Reviewed-on: https://skia-review.googlesource.com/14148
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> >
>
> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I984e1909870182474c4c3cce257f01b6a9d8581f
> Reviewed-on: https://skia-review.googlesource.com/14531
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org
# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib7ab94aada8a7cb80fe38f24daf32f9208c5b169
Reviewed-on: https://skia-review.googlesource.com/14826
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

7 years agoInitial clip-mask-layer support
Florin Malita [Fri, 28 Apr 2017 17:48:37 +0000 (13:48 -0400)]
Initial clip-mask-layer support

SkBitmapDevice-only implementation.

Will add A8 fast path specializations in a follow-up.

Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1
BUG=skia:6005

Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1
Reviewed-on: https://skia-review.googlesource.com/14183
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoOptimizations for analytic shadows.
Jim Van Verth [Fri, 28 Apr 2017 21:30:30 +0000 (17:30 -0400)]
Optimizations for analytic shadows.

Lots of changes here:
* Batch circle shadows with rrect shadows
* Avoid checking matrix and path conditions twice
* Remove lots of checks for 1/2 pixel radii
  (needed before to force the rrect through the
   regular GPU path)
* Fix scaling effect on ambient blur width
* Remove unused flags

Bug: skia:6119
Change-Id: If0eb78ec4d19d9f978b19bdbc3a7e558a4db2ed9
Reviewed-on: https://skia-review.googlesource.com/14654
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

7 years agoUpdate SKP version
UpdateSKPs [Sun, 30 Apr 2017 07:04:22 +0000 (07:04 +0000)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=update-skps@skia.org
NO_MERGE_BUILDS

Change-Id: Ic3ced4cb5f518abc5d1d0611f68fce4b976f5082
Reviewed-on: https://skia-review.googlesource.com/14679
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>

7 years agoRemove temporary_internal_describeTopLayer
Florin Malita [Wed, 19 Apr 2017 12:39:48 +0000 (08:39 -0400)]
Remove temporary_internal_describeTopLayer

Change-Id: I035b7db84b524be13fb675b75bc402bc9b733cb5
Reviewed-on: https://skia-review.googlesource.com/13803
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoadd drawString helper to canvas
Cary Clark [Fri, 28 Apr 2017 19:35:12 +0000 (15:35 -0400)]
add drawString helper to canvas

Many tests and examples use drawText with
a guess of how long the text is in bytes,
or a call to strlen(). Add a helper to
SkCanvas to simplify these examples.

Add another helper for SkString.

R=reed@google.com

Change-Id: I0204a31e938f065606f08ee7cd9a6b36db791ee2
Reviewed-on: https://skia-review.googlesource.com/13642
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Cary Clark <caryclark@skia.org>
7 years agoFix bitmap copy gms
Matt Sarett [Fri, 28 Apr 2017 20:06:34 +0000 (16:06 -0400)]
Fix bitmap copy gms

Mark pixels as opaque so copying to 565 continues to work.

Bug: skia:
Change-Id: Id2b0a8c462fe35f7d1cc2ccc32ca10eda18981c8
Reviewed-on: https://skia-review.googlesource.com/14653
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoOnly store width and height on SkPixelRef (part 1)
Matt Sarett [Fri, 28 Apr 2017 19:43:35 +0000 (15:43 -0400)]
Only store width and height on SkPixelRef (part 1)

Relanding https://skia-review.googlesource.com/c/14105/
in pieces to try to diagnose problems with the Chrome
roll.

Bug: skia:6535
Change-Id: Ic321c437ecd3cb7940a48fd73fc22b192804c67a
Reviewed-on: https://skia-review.googlesource.com/14650
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Reed <reed@google.com>
7 years agoCombine GPU flush with semaphore API
Brian Osman [Fri, 28 Apr 2017 17:57:38 +0000 (13:57 -0400)]
Combine GPU flush with semaphore API

Bug: skia:
Change-Id: I5f388760d43b19755b2767d95d32065f6d0f926e
Reviewed-on: https://skia-review.googlesource.com/14646
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

7 years agoremove unused yuv methods
Mike Reed [Fri, 28 Apr 2017 17:53:21 +0000 (13:53 -0400)]
remove unused yuv methods

Bug: skia:
Change-Id: Ie1e6c905d8989b49c2cf5c9e5fd1f383268f6480
Reviewed-on: https://skia-review.googlesource.com/14645
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>

7 years agochange drawAtlas to behave like drawVertices
Mike Reed [Fri, 28 Apr 2017 16:31:05 +0000 (12:31 -0400)]
change drawAtlas to behave like drawVertices

Bug: skia:6571
Change-Id: If60c30755ec0548df0e9bdeca2f3af0bc87764ca
Reviewed-on: https://skia-review.googlesource.com/14642
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>

7 years agoRevert "Only store width and height on SkPixelRef"
Ben Wagner [Fri, 28 Apr 2017 17:06:02 +0000 (13:06 -0400)]
Revert "Only store width and height on SkPixelRef"

This reverts commit 2cbb6662e329981840f90ef4edd62f70f69e6030.

Reason for revert: Likely cause of Chromium DEPS roll failure; speculative revert.

Original change's description:
> Only store width and height on SkPixelRef
>
> Bug: skia:6535
> Change-Id: Id91e8d1e82f593be7d4b23ca5abde752f2666a77
> Reviewed-on: https://skia-review.googlesource.com/14105
> Commit-Queue: Matt Sarett <msarett@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
>

TBR=djsollen@google.com,msarett@google.com,reed@google.com,stani@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I12a024a71833f33432d5ea8cffdfc642b8b4240a
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/14644
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoRevert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag""
Matt Sarett [Fri, 28 Apr 2017 15:15:22 +0000 (11:15 -0400)]
Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag""

This reverts commit 0122af08f6af0dee490e1a4f35b552377d0d4753.

Reason for revert: Fixed Android callsite

Original change's description:
> Revert "Delete copyTo(Allocator), hide copyTo() behind flag"
>
> This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971.
>
> Reason for revert: Looks like I missed something I was supposed to delete in Android.
>
> Original change's description:
> > Delete copyTo(Allocator), hide copyTo() behind flag
> >
> > Replace uses of copyTo() in Skia.
> >
> > Bug: skia:6464
> > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548
> > Reviewed-on: https://skia-review.googlesource.com/14502
> > Commit-Queue: Matt Sarett <msarett@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
> >
>
> TBR=msarett@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e
> Reviewed-on: https://skia-review.googlesource.com/14602
> Reviewed-by: Matt Sarett <msarett@google.com>
> Commit-Queue: Matt Sarett <msarett@google.com>
>

TBR=msarett@google.com,reviews@skia.org,reed@google.com

Change-Id: I81659a820f79f1958fda23cb62513065b57db99d
Reviewed-on: https://skia-review.googlesource.com/14640
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
7 years agoadd helper makeShader for the common Clamp case
Mike Reed [Fri, 28 Apr 2017 15:12:19 +0000 (11:12 -0400)]
add helper makeShader for the common Clamp case

Bug: skia:
Change-Id: I22cac56f35fed16daede0cf1b3e34dfa6f5ae3ea
Reviewed-on: https://skia-review.googlesource.com/14625
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

7 years agoFix fast blur for shadow rrects.
Jim Van Verth [Fri, 28 Apr 2017 15:00:35 +0000 (11:00 -0400)]
Fix fast blur for shadow rrects.

* Handles case where blur is greater than
  corner radius.
* Speeds up shader by avoiding a divide.
* Tweaks shadow sample to be more MD-ish.

Bug: skia:
Change-Id: I2990357b39784c22f02a8e51872391fd68e8226a
Reviewed-on: https://skia-review.googlesource.com/14141
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
7 years agoScrub DeviceCM
Florin Malita [Fri, 28 Apr 2017 14:57:24 +0000 (10:57 -0400)]
Scrub DeviceCM

* remove unused fMatrix, fMatrixStorage
* fPaint  -> std::unique_ptr<>
* fDevice -> sk_sp<>

Change-Id: I790b54bfc4d8154216e620a8c1642f3955fe7be0
Reviewed-on: https://skia-review.googlesource.com/14624
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

7 years agoTesting permissions
Ravi Mistry [Fri, 28 Apr 2017 12:22:03 +0000 (08:22 -0400)]
Testing permissions

Bug: skia:
Change-Id: I204a0956228de5afde9c5df02dc5afa12ab21bfd
Reviewed-on: https://skia-review.googlesource.com/14609
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

7 years agoAdd non-Valgrind PreAbandonGpuContext bot.
Ben Wagner [Thu, 27 Apr 2017 22:14:03 +0000 (18:14 -0400)]
Add non-Valgrind PreAbandonGpuContext bot.

This may help debug timeouts for
Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind_PreAbandonGpuContext

Also stop uploading *AbandonGpuContext results to Gold.

No-Try: true
Change-Id: Ifa10d47cf27f86424d3936f451d190ee34f5637d
Reviewed-on: https://skia-review.googlesource.com/14525
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
7 years agoRemove srgb flags from GrProcessorSet
Brian Salomon [Fri, 28 Apr 2017 12:57:12 +0000 (08:57 -0400)]
Remove srgb flags from GrProcessorSet

Bug: skia:
Change-Id: Icbb1b2f39cac70c9d74603514786d76b46d0afd9
Reviewed-on: https://skia-review.googlesource.com/14603
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

7 years agoadditional skslc vector optimizations
Ethan Nicholas [Thu, 27 Apr 2017 20:24:51 +0000 (16:24 -0400)]
additional skslc vector optimizations

Bug: skia:
Change-Id: I845d0952c281835a630882ae4026277c93ccf542
Reviewed-on: https://skia-review.googlesource.com/14406
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
7 years agoadd GM to compare atlas and vertices
Mike Reed [Fri, 28 Apr 2017 14:02:47 +0000 (10:02 -0400)]
add GM to compare atlas and vertices

Bug: skia:6571
Change-Id: Ic97101c4623c7557eb33f69796232ed51a89af7e
Reviewed-on: https://skia-review.googlesource.com/14621
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>

7 years agohandle GrVkTransferBuffer::Create failure
Forrest Reiling [Thu, 27 Apr 2017 02:26:12 +0000 (19:26 -0700)]
handle GrVkTransferBuffer::Create failure

Change-Id: I713dd7b678bfec6808bd6f57bfdf5748258e8b24
Reviewed-on: https://skia-review.googlesource.com/14420
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

7 years ago[infra/bots] Treat extra_config as a list.
Ben Wagner [Thu, 27 Apr 2017 17:08:50 +0000 (13:08 -0400)]
[infra/bots] Treat extra_config as a list.

Dependency of https://skia-review.googlesource.com/c/14525/

No-Try: true
Change-Id: I7686576aa48865116fe8a593f08d395f901a1d04
Reviewed-on: https://skia-review.googlesource.com/14524
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>

7 years agoDisable deferred proxies in Chrome
Robert Phillips [Thu, 27 Apr 2017 16:04:15 +0000 (12:04 -0400)]
Disable deferred proxies in Chrome

We will re-enable once the proxy instantiation is moved past the TextureSamplers

Bug: 715488
Change-Id: I4f0dee18fc191d7fffb6a2f4fedd825729ebb057
Reviewed-on: https://skia-review.googlesource.com/14520
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

7 years agoOnly store width and height on SkPixelRef
Matt Sarett [Thu, 27 Apr 2017 20:52:29 +0000 (16:52 -0400)]
Only store width and height on SkPixelRef

Bug: skia:6535
Change-Id: Id91e8d1e82f593be7d4b23ca5abde752f2666a77
Reviewed-on: https://skia-review.googlesource.com/14105
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Reed <reed@google.com>
7 years agoRevert "Delete copyTo(Allocator), hide copyTo() behind flag"
Matt Sarett [Thu, 27 Apr 2017 20:08:39 +0000 (20:08 +0000)]
Revert "Delete copyTo(Allocator), hide copyTo() behind flag"

This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971.

Reason for revert: Looks like I missed something I was supposed to delete in Android.

Original change's description:
> Delete copyTo(Allocator), hide copyTo() behind flag
>
> Replace uses of copyTo() in Skia.
>
> Bug: skia:6464
> Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548
> Reviewed-on: https://skia-review.googlesource.com/14502
> Commit-Queue: Matt Sarett <msarett@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
>

TBR=msarett@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e
Reviewed-on: https://skia-review.googlesource.com/14602
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

7 years agoAdd instrumentation into SkArenaAlloc.
Herb Derby [Thu, 27 Apr 2017 19:22:02 +0000 (15:22 -0400)]
Add instrumentation into SkArenaAlloc.

Add a parameter to the constructor that will have the dtor print out
stats for setting the initial parameters.

Clean up: Move some function so they are in the same order as .h

Change-Id: I19d87dcc9c3b8dcc3e1d4f2ff078b78bbc490d92
Reviewed-on: https://skia-review.googlesource.com/14600
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>

7 years agojumper, remove C(int)
Mike Klein [Thu, 27 Apr 2017 17:56:33 +0000 (13:56 -0400)]
jumper, remove C(int)

This finishes off integer constants... they should all be normal now.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win7-MSVC-Golo-CPU-AVX-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE41,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE2

Change-Id: I66ecc6533807fc59bb5ac9d3c5f7ab9e6e1f0d7f
Reviewed-on: https://skia-review.googlesource.com/14528
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

7 years agoRevert "Plumb the use of GrBackendRenderTarget throughout Skia"
Greg Daniel [Thu, 27 Apr 2017 18:48:15 +0000 (18:48 +0000)]
Revert "Plumb the use of GrBackendRenderTarget throughout Skia"

This reverts commit fdd77daedbba3b7c53be74a82fb9fae891b51696.

Reason for revert: Apparently I have a few more build files to update before this can land.

Original change's description:
> Plumb the use of GrBackendRenderTarget throughout Skia
>
> Bug: skia:
> Change-Id: Ib99a58d9552f5c7b8d77c09dcc72fa88326c26aa
> Reviewed-on: https://skia-review.googlesource.com/14148
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I984e1909870182474c4c3cce257f01b6a9d8581f
Reviewed-on: https://skia-review.googlesource.com/14531
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

7 years agoFold SkImageCacherator into SkImage_Lazy
Brian Osman [Wed, 26 Apr 2017 20:20:28 +0000 (16:20 -0400)]
Fold SkImageCacherator into SkImage_Lazy

SkImageCacherator still exists, but only as an interface implemented
(solely) by SkImage_Lazy. The only external clients are
GrImageTextureMaker and SkImage_Gpu::getDeferredTextureImageData.

This is probably an improvement, but doesn't go as far as I'd hoped.

Bug: skia:
Change-Id: I6812badfabb6924b025621b21af00cbde9c16cac
Reviewed-on: https://skia-review.googlesource.com/14371
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>