ChunEon Park [Fri, 31 Oct 2014 10:18:41 +0000 (19:18 +0900)]
evas/gl_common: remove dead code.
Cedric BAIL [Fri, 31 Oct 2014 09:45:28 +0000 (10:45 +0100)]
edje: use the right variable.
Thanks michelle_lg.
Tae-Hwan Kim [Fri, 31 Oct 2014 08:28:06 +0000 (09:28 +0100)]
eina: enhance doxygen in eina_magic.h
Summary:
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Add @see more
Add links for EINA_TRUE, EINA_FALSE, etc.
Fix indentation & Fix typeof
Use @p instead of @a for the consistency
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1620
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Fri, 31 Oct 2014 08:26:47 +0000 (09:26 +0100)]
eina: group eina_sched
Summary:
Schedule group is made for eina_sched_xxx.
It is grouped into Tools group.
Futher description is needed later.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1623
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Fri, 31 Oct 2014 08:25:50 +0000 (09:25 +0100)]
eina: enhance doxgen for Eina_Trash
Summary:
Move doxygen comments from .x file to .h file
Basic rules are below:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Add @see more
Add links for EINA_TRUE, EINA_FALSE, etc.
Fix indentation & Fix typeof
Use @p instead of @a for the consistency
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1624
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Fri, 31 Oct 2014 08:24:35 +0000 (09:24 +0100)]
eina: enhance doxygen in eina_prefix.h
Summary:
Arrange grouping
- Move Prefix group below Tools group
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Add @see more
Add links for EINA_TRUE, EINA_FALSE, etc.
Fix indentation & Fix typeof
Use @p instead of @a for the consistency
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1618
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jaehwan Kim [Fri, 31 Oct 2014 06:15:39 +0000 (15:15 +0900)]
edje_calc: add null check.
Carsten Haitzler (Rasterman) [Fri, 31 Oct 2014 02:27:07 +0000 (11:27 +0900)]
ecore vsync - add debug and files to touch to disable vsync
this makes it just that much more convenient to disable the ecore x
vsync stuff in case you have troubles
Cedric BAIL [Fri, 31 Oct 2014 01:40:08 +0000 (02:40 +0100)]
eina: clear up eina_tmpstr length information
This @fix a potential wrong return value according to documentation and
improve consistency accross this API. This should fix T1775.
Chris Michael [Thu, 30 Oct 2014 13:35:26 +0000 (09:35 -0400)]
ecore-drm: Remove dead functions
Summary: These functions were never exposed via API/Header, and never
used internally. Since drm gbm stuff is handled inside the gl_drm evas
engine now, we don't need this code here.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 30 Oct 2014 13:34:34 +0000 (09:34 -0400)]
ecore-drm: Remove commented out dead functions
Summary: These functions were never exposed in the header, and were
also already commented out. This commit just removes the dead comments.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Srivardhan Hebbar [Thu, 30 Oct 2014 13:33:55 +0000 (09:33 -0400)]
ecoreidrm: Cleaned up unwanted code.
Summary: Cleaned up all unwanted code's in ecore_drm. This just
removes a bunch of already commented out code.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1615
Jean-Philippe Andre [Thu, 30 Oct 2014 11:09:43 +0000 (20:09 +0900)]
Eina: Fix eina_condition_timedwait once again
Much confusion with this spaghetti code of #ifdefs and clocks.
So, we can't use CPU clocks for the timedwait, this doesn't make
sense (and it's explicit in the manpage, too).
But we can use CLOCK_MONOTONIC or CLOCK_MONOTONIC_RAW which are
much better than the wall clock (because of ntp updates, etc...)
The test case tests that the cond actually waited for as long as was
requested and for not too long either.
This is hopefully a final fix for T1701.
Jean-Philippe Andre [Thu, 30 Oct 2014 09:23:49 +0000 (18:23 +0900)]
Eina file: Fix calls to getenv
There seems to be an intent to check that UID==EUID
before calling getenv to get the temp directory.
But that was lost in commits
61478af3a6c4f9263 and
then in
e105abc99e717b84723ab35258375e27f17f8e82.
Stefan Schmidt [Thu, 30 Oct 2014 08:14:48 +0000 (09:14 +0100)]
build: Print configure warning when trying --with-api=eo
Our code base simply do not work with the EO API alone right now. Leave the
option for testing but hide the knob to turn it on behind the beloved "I
know what I do" option.
Fixes T1558
Tae-Hwan Kim [Thu, 30 Oct 2014 07:49:01 +0000 (08:49 +0100)]
eina: enhance doxygen in eina_file.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Add @see more
Add links for EINA_TRUE, EINA_FALSE, etc.
Fix indentation & Fix typeof
Use @p instead of @a for the consistency
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1611
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Thu, 30 Oct 2014 07:47:25 +0000 (08:47 +0100)]
eina: enhance doxygen in eina_mempool.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Add @see more
Add links for EINA_TRUE, EINA_FALSE, etc.
Fix indentation & Fix typeof
Use @p instead of @a for the consistency
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1612
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Wed, 29 Oct 2014 23:36:49 +0000 (00:36 +0100)]
edje: fix use of eina_tmpstr_del after eina_shutdown.
atexit could call eina_tmpstr_del after the shutdown of eina leading
to the access of some random/garbage memory.
@fix
Tae-Hwan Kim [Wed, 29 Oct 2014 21:40:07 +0000 (22:40 +0100)]
eina: enhance doxygen in eina_lock.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Add @see more
Add links for EINA_TRUE, EINA_FALSE, etc.
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1598
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jaehyun Cho [Wed, 29 Oct 2014 21:37:24 +0000 (22:37 +0100)]
evas: fix typo in evas_cache comment.
Summary: Fix typo in comment
Reviewers: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1599
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Wed, 29 Oct 2014 21:36:27 +0000 (22:36 +0100)]
eina: enhance doxygen in eina_clist.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1601
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
artem.popov [Wed, 29 Oct 2014 21:33:15 +0000 (22:33 +0100)]
eina_unicode: fix memory allocation
Summary:
there is wrong memory allocation, Eina_Unicode has 4 bytes, allocation
is like for char
@fix
Reviewers: Hermet, seoz, raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1609
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Wed, 29 Oct 2014 18:55:17 +0000 (14:55 -0400)]
ecore-evas-wayland: Fix wayland windows not showing up after
5954289c6ce1cd55ff212428291604b981438439
Summary: Wayland windows should follow X11 windows fairly closely,
thus only set withdrawn property if they are override windows. If not,
internal dialogs do not show up in Enlightenment (wayland-only).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 29 Oct 2014 16:12:39 +0000 (12:12 -0400)]
evas-gl-3d: Fix compiler warning about 'ld' may be used uninitialized
Summary: This commit fixes compiler warning:
modules/evas/engines/gl_common/evas_gl_3d.c:1322:48: warning: 'ld' may
be used uninitialized in this function [-Wmaybe-uninitialized]. We
declare 'ld' as NULL now, and check it is valid before using it.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 29 Oct 2014 16:11:21 +0000 (12:11 -0400)]
evas-gl-3d: Fix formatting
Summary: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 29 Oct 2014 16:07:48 +0000 (12:07 -0400)]
evas-gl-x11: Don't call gl_common_error_set if MakeContextCurrent fails
Summary: glsym_evas_gl_common_error_set used here leads to an implicit
declaration in compiler warnings. Remove the call to that function and
just print out an error message. This is a cleanup function anyway.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 29 Oct 2014 16:07:03 +0000 (12:07 -0400)]
Revert "evas-gl-x11: Fix copy/paste error from Coverity fix"
This reverts commit
fb4ad043f642e7e1ea6db637750bfe5e11891b77.
Revert this. This also leads to an implicit declaration of the
error_set function.
Chris Michael [Wed, 29 Oct 2014 16:02:26 +0000 (12:02 -0400)]
evas-gl-x11: Fix copy/paste error from Coverity fix
Summary: In fixing a Coverity issue, I copy/pasted a call to
evas_gl_common_error_set without compiling :( Bad me !! This commit
fixes the issue (data was undefined). Since evas_gl_common_error_set can
take NULL as the data parameter, lets use that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Wed, 29 Oct 2014 15:30:23 +0000 (16:30 +0100)]
evas/gl_drm: Add eeze dependency to fix build race condition
Like the evas drm engine the evas gl_drm engine now depends on eeze for
backlight. Make sure it is setup to find eeze like the drm engine already
does.
Stefan Schmidt [Wed, 29 Oct 2014 15:07:39 +0000 (16:07 +0100)]
edje_cc_out: Do not shadow another local variable.
Stefan Schmidt [Wed, 29 Oct 2014 15:05:42 +0000 (16:05 +0100)]
evas/gl_x11: Do not shadow another local variable.
Stefan Schmidt [Wed, 29 Oct 2014 15:00:28 +0000 (16:00 +0100)]
ecore_drm: Silence warnings about unused parameters.
Stefan Schmidt [Wed, 29 Oct 2014 14:51:11 +0000 (15:51 +0100)]
eina_file: Give TMPDIR presedence over XDG_RUNTIME_DIR when defined
XDG_RUNTIME_DIR gives us a nice securty benefit by only allowing the
same user to read wand write files.
In some configuration this is problematic though. If one looks at the
bug report this fixes for example you can see that there are build
scripts that use a special build user.
The way this has always worked on unix is that you can define your
own tempdir with TMPDIR. When I was making the original change towards
XDG_RUNTIME_DIR I expected some trouble with it but it worked quite
well so far.
To avoid breaking scripts out there and maybe configurations we
haven't tested yet give TMPDIR precedence over XDG_RUNTIME_DIR.
Fixes T1766
Stefan Schmidt [Mon, 27 Oct 2014 14:48:24 +0000 (15:48 +0100)]
tests/eina: Enable eina_condition_timedwait() now that it should work.
Commit again now that compile problems are solved.
Stefan Schmidt [Mon, 27 Oct 2014 14:47:51 +0000 (15:47 +0100)]
eina: Fix _timedwait to handle the given timeout on top of the absolute time
The pthread man page clearly states that pthread_cond_timedwait() takes an
absolute time parameter. So far we always passed it epoch plus timeout in
seconds. This would never trigger the timeout.
Making sure we fill out timespec struct with the current time before adding
the timeout as offset now. Also handling the t < 0 error case.
Various version worked up together with Jean-Philippe Andre <jp.andre@samsung.com>
This version does not use _eina_time_get directly as this is currently not a
public API of eina. If we decide to make _eina_time_get public we can remove the
extra code here.
Fixes T1701
Chris Michael [Wed, 29 Oct 2014 14:28:50 +0000 (10:28 -0400)]
evas-gl-x11: Check return value of glXMakeContextCurrent
Summary: Fix Coverity CID1249651 (unchecked return value)
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 29 Oct 2014 13:22:25 +0000 (09:22 -0400)]
ecore-tests: Add missing separator
Summary: Previous patch for this was causing build issues due to
missing separator.
NB: Totally my fault for not testing the patch !!
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
kabeer khan [Wed, 29 Oct 2014 13:01:59 +0000 (09:01 -0400)]
Ecore File : Added test suite for Ecore File module
Summary:
Added 2 test cases. First to test initialise, shutdown Ecore_File module and second to test all file operation functions defined in the module.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1600
Srivardhan Hebbar [Wed, 29 Oct 2014 12:39:56 +0000 (08:39 -0400)]
ecore_input: Added test suite for ecore_input.
Summary:
Added test suite for ecore_input with one test case.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1602
Srivardhan Hebbar [Wed, 29 Oct 2014 12:24:53 +0000 (08:24 -0400)]
ecore_con: Added test case to check if _ecore_con_init_count goes below zero.
Summary:
_ecore_con_init_count should not go below zero. I've added a test case to test this and also the code to fix this.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1603
vivek [Wed, 29 Oct 2014 12:14:26 +0000 (08:14 -0400)]
ecore-fb: Adding test suite for ecore_fb
Summary:
Added test suite for ecore_fb with test for ecore_fb_init
w
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1594
Jaehwan Kim [Wed, 29 Oct 2014 12:04:37 +0000 (21:04 +0900)]
edje_cc_out: update the id of set images.
Before it removes unused images, it updates ids.
For the set images, it should be done.
@fix
Carsten Haitzler (Rasterman) [Wed, 29 Oct 2014 10:33:16 +0000 (19:33 +0900)]
ecore_evas - ecore_evas's should start withdrawn then normal on show
this fixes initial state of an ee where you couldn't detect when the
window had been accepted by the wm (goes to normal state from
withdrawn).
@fix
Jean-Philippe Andre [Wed, 29 Oct 2014 06:10:03 +0000 (15:10 +0900)]
Evas filters: Fix COW usage.
Thanks cedric for the report.
We'll need a new function (after 1.12) to detect if the current
cow pointer is the default data or not. Maybe eina_cow_default_get()
or maybe something just returning a bool.
Jean-Philippe Andre [Wed, 29 Oct 2014 03:56:00 +0000 (12:56 +0900)]
Evas GL: Fix potential crash
Welp, it looks like this crash actually happened once even though
it should not. glGetString() seems to have returned NULL somehow.
Cedric BAIL [Wed, 29 Oct 2014 05:15:11 +0000 (06:15 +0100)]
evas: fix increased memory usage in Evas.
Eina_Cow does memory comparison during standby time. So in expedite as we don't
have any standby time, we end up allocating some vast amount of memory that
will never be compared. It is way simpler to compare that the data are not
going to change before hand. It should also reduce the CPU consumed during
idle time.
This patch save about 1MB of data at peak time in expedite.
Cedric BAIL [Tue, 28 Oct 2014 23:12:06 +0000 (00:12 +0100)]
autotools: fix build with NEON support.
Tae-Hwan Kim [Tue, 28 Oct 2014 20:22:06 +0000 (21:22 +0100)]
eina: fix overlapped doxygen string output
Summary:
Add top padding to prevent overlapping between "Value:" and below
strings when long macro is used.
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1582
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Tue, 28 Oct 2014 20:20:33 +0000 (21:20 +0100)]
eina: enhance doxygen in eina_error.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1588
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 28 Oct 2014 20:19:10 +0000 (21:19 +0100)]
eina: remove reference to API that never made it to a stable release.
Tae-Hwan Kim [Tue, 28 Oct 2014 20:18:28 +0000 (21:18 +0100)]
eina: enhance doxygen in eina_binshare.h
Summary:
Add @brief for brief description
Add @details for detailed description
Add @warning for important description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1586
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Tue, 28 Oct 2014 20:16:38 +0000 (21:16 +0100)]
eina: enhance doxygen in eina_inarray.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add @note for noted description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1592
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tom Hacohen [Tue, 28 Oct 2014 16:19:30 +0000 (16:19 +0000)]
Eo composite objs: Add a test for the recent comp obj fix.
This adds a fragile test for cedric's fix from commit
3550c3808085175cf322670b290bf0c4a70a2fa7.
It assumes that all the added 64 functions are in order and that each
eo_op chain is 32 in length. As long as those don't change, this should
be a decent test.
Tom Hacohen [Tue, 28 Oct 2014 15:19:41 +0000 (15:19 +0000)]
Eo comp: Remove dead code following the composite fix.
This removes dead code resulting from Cedric's fix:
3550c3808085175cf322670b290bf0c4a70a2fa7.
Srivardhan Hebbar [Tue, 28 Oct 2014 14:27:31 +0000 (10:27 -0400)]
ecore_wayland: Checking if default wayland socket exists before executing test case.
Summary:
If WAYLAND_DISPLAY is not set or if wayland-0 fd doesn't exist in the XDG_RUNTIME_DIR path, then this test case fails. That should not be the case. So made changes in the test case.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1590
Srivardhan Hebbar [Tue, 28 Oct 2014 14:26:39 +0000 (10:26 -0400)]
ecore_drm: Added test case calling ecore_drm_shutdown before calling ecore_drm_init.
Summary:
_ecore_drm_init_count should not go below zero. So added test case to verify that.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1589
Carsten Haitzler (Rasterman) [Tue, 28 Oct 2014 11:09:33 +0000 (20:09 +0900)]
evas - fix new issue with segv when switching to alpha win with gl
evas gl window was freed before new one was created getting shared ctx
to 0 refcount thus freeing everything there - BAD. fix. new issue in
git, not from release
Jaehwan Kim [Tue, 28 Oct 2014 06:50:38 +0000 (15:50 +0900)]
Edje_calc: set the image set border again after resize.
_edje_real_part_image_set can change the image of part,
if the part use the image that is set by image set.
If the image is changed, the border should be changed.
@fix
Jean-Philippe Andre [Tue, 28 Oct 2014 02:19:24 +0000 (11:19 +0900)]
Evas: Fix lock usage around async_current (gl preload)
Fixes Coverity:
- CID 1039361
Jean-Philippe Andre [Mon, 27 Oct 2014 14:09:18 +0000 (23:09 +0900)]
Evas convert: Remove dead code
Woah coverity...
Fixes CID 1039448
Jean-Philippe Andre [Mon, 27 Oct 2014 13:57:53 +0000 (22:57 +0900)]
inotify: Fix safety after read in 3 places
Fixes Coverity issues:
- CID 1039565
- CID 1039566
Jean-Philippe Andre [Mon, 27 Oct 2014 13:16:53 +0000 (22:16 +0900)]
Evas cserve2: Check message size
Fixes CID 1039570
Jean-Philippe Andre [Mon, 27 Oct 2014 13:07:36 +0000 (22:07 +0900)]
Embryo: Use strncpy instead of strcpy in a few places
There are still lots of unsafe uses of strcpy, strcat, etc...
Dunno if they are relevant though. Also, assert() may be
compiled out at build time (release mode) so don't rely on it
for safety.
Fixes CID 1039593
Jean-Philippe Andre [Mon, 27 Oct 2014 12:48:37 +0000 (21:48 +0900)]
Evas GL: Set umask before calling mkstemp
Fixes Coverity issues:
- CID 1039609
- CID 1039608
Jean-Philippe Andre [Mon, 27 Oct 2014 12:37:39 +0000 (21:37 +0900)]
Evas filters: Prevent division by 0
While it really shouldn't happen, let's just add a quick if()
and make Coverity shut up.
Fixes:
- CID 1191912
- CID 1191911
- CID 1191910
- CID 1191909
Cedric BAIL [Mon, 27 Oct 2014 22:23:45 +0000 (23:23 +0100)]
eo: fix composite to actually work.
So I don't really understand why the code was not there before, but it resulted
in my experiment of making a combobox for elementary just impossible. Now it
work at least.
Bogdan Devichev [Mon, 27 Oct 2014 13:57:22 +0000 (14:57 +0100)]
evas/3d: Fix resource leaks found by coverity
CID: 1244183 - 1244187
Reviewers: cedric, artem.popov, Oleksander
Subscribers: stefan_schmidt, cedric
Differential Revision: https://phab.enlightenment.org/D1585
Srivardhan Hebbar [Mon, 27 Oct 2014 12:09:43 +0000 (08:09 -0400)]
ecore_wayland: Added test case calling ecore_wl_shutdown before calling ecore_wl_init.
Summary:
Added a test case to calling ecore_wl_shutdown before ecore_wl_init. The return value of ecore_wl_shutdown should not go below 0.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1584
Srivardhan Hebbar [Mon, 27 Oct 2014 12:00:38 +0000 (08:00 -0400)]
ecore_drm: Adding test-suite to ecore_drm.
Summary:
Adding test-suite to ecore_drm with one test case.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1583
Stefan Schmidt [Mon, 27 Oct 2014 11:32:01 +0000 (12:32 +0100)]
release: Update NEWS and bump version for 1.12.0-beta1 release
Carsten Haitzler (Rasterman) [Mon, 27 Oct 2014 10:51:10 +0000 (19:51 +0900)]
evas - sw generic - fix osmesa to not use rgb buffers as evas doesnt know
this fixes incorrect sw osmesa rendering when no alpha cannel is used
on evas gl targets.
Vyacheslav Reutskiy [Mon, 27 Oct 2014 10:28:25 +0000 (10:28 +0000)]
edje: edje_edit - fix posible resource leak
Fixes: https://phab.enlightenment.org/T1760
@fix
Vyacheslav Reutskiy [Mon, 27 Oct 2014 09:21:45 +0000 (09:21 +0000)]
edje: edje_edit - don't unlick(NULL)
Summery: fix, posible to delete file by 'NULL' path (T1760)
@fix
Jean Guyomarc'h [Mon, 27 Oct 2014 08:11:19 +0000 (09:11 +0100)]
eina_semaphore: OSX support
Summary:
OSX only support named semaphores. Eina_Semaphore was actually broken on OSX.
Since OSX 10.10 sem_init() and sem_destroy() (were not implemented) are also marked as
"deprecated", which adds huge pollution to the output when compiling.
Reviewers: cedric, raster, stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1576
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Mon, 27 Oct 2014 08:10:16 +0000 (09:10 +0100)]
eina: enhance doxygen in eina_accessor.h
Summary:
Add @brief for brief description
Add @details for detailed description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1580
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Mon, 27 Oct 2014 08:08:42 +0000 (09:08 +0100)]
eina: documentation enhance - add @brief tag
Summary: Add @brief for brief description
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1577
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tae-Hwan Kim [Mon, 27 Oct 2014 08:06:16 +0000 (09:06 +0100)]
eina: enhance doxygen for eina_counter.h
Summary:
Arrange grouping
Add @brief for brief description
Add @details for detailed description
Add [in] & [out] for parameters
Fix indentation & Fix typeof
Reviewers: raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1579
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean-Philippe Andre [Fri, 24 Oct 2014 11:52:09 +0000 (20:52 +0900)]
Evas GL: string_query returns a const char *
Why cast to/from void* in the first place?
Jean-Philippe Andre [Fri, 24 Oct 2014 10:52:21 +0000 (19:52 +0900)]
Evas GL: Fix typo in an extension's name
This could potentially break applications relying on this
typo to check for the extension. The chances are very slim.
Daniel Zaoui [Mon, 27 Oct 2014 06:10:11 +0000 (08:10 +0200)]
dnd/x: fix type set for case there is no type list exists
Summary:
DND does not work in X11 because we cannot set type.
The
f8e036d5af3c99d74c3b0f4dcc612c4e0a949e00 causes this.
Since the xdnd type list does not exists at the beginning,
if we always return without setting new property, we cannot set dnd type.
This patch brings dnd work again by correcting the type set operation.
@fix
Test Plan: Try dnd tests in elementary_test.
Reviewers: raster, woohyun, JackDanielZ
Reviewed By: JackDanielZ
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1578
Carsten Haitzler (Rasterman) [Sat, 25 Oct 2014 11:04:52 +0000 (20:04 +0900)]
evas gl rgba visual/rendering fix try ... again
so this is a re-try at the evas gl destination alpha fix. this is what
cedric tried, but done RIGHT. it required adding an ecore_x call to
create a window with correct visual/colormap. it requires doing
visuals totally correctly all the way from ecore_evas to the evas
gl_x11 core. nvidia drivers are very picky about visuals. i also had
to vid the egl/gles code too to do the same thing. nvidia gles/egl
drivers are also picky, mesa is not. this all requires a lot of code
changes. it's far from trivial
this isn't backported for a few reasons:
1. verify this fix doesn't break for anyone.
i tested:
nvidia glx + egl/gles
intel glx + egl/gles
radeon glx
it needs wider testing. nouveau, fglrx for starters and maybe
some other gles/egl drivers.
2. have some review time
3. time to settle before blasting to stable branches
@fix
Adrien Nader [Sat, 25 Oct 2014 14:35:06 +0000 (16:35 +0200)]
ecore_exe_win32: CreateProcess was called with random flags.
CreateProcess() has a flags parameter which is being passed
"run_pri | CREATE_SUSPENDED".
The issue lies in the value of run_pri. It is best explained by the
following code somewhere else in the file:
switch (run_pri)
{
case IDLE_PRIORITY_CLASS:
return ECORE_EXE_WIN32_PRIORITY_IDLE;
The run_pri variable is supposed to store a value from the win32 API while
it was used to store one from the ecore API.
If I recall correctly, the windows one is equal to 32 and the ecore one to
9999. Meaning 9999 ended up used as flags so let's have a look at what that
actually enabled; the reference is "Process Creation Flags" from MSDN
http://msdn.microsoft.com/en-us/library/ms684863%28v=vs.85%29.aspx .
9999 gives 0x0000270F and this matches
DEBUG_PROCESS | DETACHED_PROCESS | DEBUG_ONLY_THIS_PROCESS
| CREATE_SUSPENDED | CREATE_NEW_PROCESS_GROUP | CREATE_SEPARATE_WOW_VDM
| CREATE_UNICODE_ENVIRONMENT | <0x00002000 matches nothing>
Matches nothing? Weird. Well, maybe. Except that I stumbled upon this define
in the mingw-w64 headers:
#define CREATE_FORCEDOS 0x2000
Mingw-w64 only has a #define, Wine has nothing (they don't do DOS anyway),
but ReactOS has some code about it:
https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/kernel32/client/proc.c;hb=
f60941f8dc775427af04eb0a3c3e4d38160c7641#l3007
Overall the actual set of flags probably made very little sense and wasn't
working very well. :)
I also noticed the following in the mingw-w64 headers:
#define INHERIT_CALLER_PRIORITY 0x20000
This should be a better match for what seemed to be the original intent of
inheriting the priority. I haven't tested it and it's only documented on
MSDN for Windows CE and similar so I'm really not sure about what it does.
MSDN however mentions that the child processes will have at most the
"normal" priority by default (same as its parent if the parent has less
than the default one) but I'm under the impression a process can raise its
own priority level... Anyway, "NORMAL_PRIORITY_CLASS" will do for now.
With this change and a couple others, elementary's theme builds properly
on Windows (_on_ Windows). I'll assess the usefulness of the other changes
in my tree over the next few days.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Stefan Schmidt [Fri, 24 Oct 2014 12:29:35 +0000 (14:29 +0200)]
ecore_evas: Add since tag to new ecore_evas_gl_drm_new() function
Stefan Schmidt [Fri, 24 Oct 2014 12:28:02 +0000 (14:28 +0200)]
ecore-wayland: Add since tag to new ecore_wl_window_xdg_surface_get() function
Chris Michael [Fri, 24 Oct 2014 12:37:51 +0000 (08:37 -0400)]
evas-gl-drm: Fix initialization from incompatible pointer type
Summary: The function prototype for eng_context_create has recently
changed in gl_common, however nobody thought it wise to update all
engines using it, so this commit fixes the function for the gl_drm
engine.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Fri, 24 Oct 2014 11:02:07 +0000 (13:02 +0200)]
eina_cxx: Include newly added header to unbreak make distcheck
Felipe Magno de Almeida [Thu, 23 Oct 2014 20:06:13 +0000 (18:06 -0200)]
[eina-cxx] Fixed EFL_CXX_THROW not defined
Fixed errors of EFL_CXX_THROW not defined when #include'ing specific
eina C++ headers.
Felipe Magno de Almeida [Thu, 23 Oct 2014 19:38:15 +0000 (17:38 -0200)]
[cxx] Fixed eina::value get for string
The get function for string in eina::value wronfully was freeing the
string returned from eina_value_get. Which crashed applications that
used it.
Srivardhan Hebbar [Thu, 23 Oct 2014 14:40:39 +0000 (10:40 -0400)]
ecore_wayland: Making _ecore_wl_shutdown return int instead of EINA_BOOL.
Summary:
_ecore_wl_shutdown should return int instead of EINA_BOOL. So changing the function prototype.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1574
Chris Michael [Thu, 23 Oct 2014 14:33:40 +0000 (10:33 -0400)]
ecore-wayland: Add error message for calling shutdown without calling
init
Summary: If someone calls ecore_wayland_shutdown without first calling
ecore_wl_init, then the init count is wrong. Warn the caller.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 23 Oct 2014 14:32:59 +0000 (10:32 -0400)]
ecore-drm: Add error message for calling shutdown without calling init
first.
Summary: If someone calls ecore_drm_shutdown without first calling
ecore_drm_init, then the init count is wrong. Warn the caller.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Thu, 23 Oct 2014 13:13:20 +0000 (15:13 +0200)]
Revert "tests/eina: Enable eina_condition_timedwait() now that it should work."
This has to work until we really fixed up eina_condition_timedwait()
This reverts commit
5c9024424f7102abd6c7d858628b52da6065cf9a.
Stefan Schmidt [Thu, 23 Oct 2014 13:10:39 +0000 (15:10 +0200)]
Revert "eina: Fix _timedwait to handle the given timeout on top of the absolute time"
Not ready yet as it uses _eina_time_get which is internal only right now. Compiling
works fine for efl alone as the private header is in teh include search part but it
blows up when compiling elementary.
Need to think a bit more about this. Maybe exposing _eina_time_get as API but that
should wait until after the release.
This reverts commit
f0a02a92beff49879eba84b4d4eee265fe156511.
Srivardhan Hebbar [Thu, 23 Oct 2014 13:04:29 +0000 (09:04 -0400)]
ecore_drm: Making _ecore_drm_init_count not to go below zero in _ecore_drm_shutdown.
Summary:
If _ecore_drm_init_count goes below zero, then when next time ecore_drm_init is called, it won't do the initializations which it is supposed to do. So preventing this scenario by not making it go
below zero in _ecore_wl_shutdown function.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1573
Srivardhan Hebbar [Thu, 23 Oct 2014 13:02:11 +0000 (09:02 -0400)]
ecore_wayland: Making _ecore_wl_init_count not to go below zero in shutdown.
Summary:
If _ecore_wl_init_count goes below zero, then there would be problem if someone calls ecore_wl_shutdown 1st and then ecore_wl_init later. So fixing this issue in ecore_wl_shutdown.
@fix
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1571
vivek [Thu, 23 Oct 2014 12:52:02 +0000 (08:52 -0400)]
ecore-drm: Added documentation for various APIs in ecore_drm_output module
Summary:
Added documentation for ecore_drm_outputs_create, ecore_drm_output_free,
ecore_drm_output_cursor_size_set, ecore_drm_output_size_get functions
@fix
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1572
Stefan Schmidt [Thu, 23 Oct 2014 11:53:40 +0000 (13:53 +0200)]
evas/cserve2_slave: Fix build race with linking to eo but not depending on it.
I have not been able to reproduce this myself but I have seen a build log where
the binary tries to link to libeo and fails due to the missing file.
A similar problem was "fixed" in
0e4b847deb79c957dbc042ea0c6a98282aead6e0, but
this really makes me wonder where the linking against eo comes from for cserve2
which is not using eo as far as I can see.
kabeer khan [Thu, 23 Oct 2014 12:34:14 +0000 (08:34 -0400)]
Eina Test : Added test case for convert float in eina_test_value
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric, devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1567
vivek [Thu, 23 Oct 2014 12:31:20 +0000 (08:31 -0400)]
ecore-drm: Added documentation for various APIs in ecore_drm_device module
Summary:
Added documentation for ecore_drm_device_fd_get, ecore_drm_device_window_set
and ecore_drm_device_name_get APIs in ecore_drm_device module.
@fix
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1568
Chris Michael [Thu, 23 Oct 2014 12:28:33 +0000 (08:28 -0400)]
ecore-drm: Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>