Fix compile warnings in SimpleClientServer for Linux

SimpleClientServer application for Linux was trying to check the address of array
'clientResponse->rcvdVendorSpecificHeaderOptions' which will always evaluate to 'true'.
Corrected by removing such checks in the code.

Change-Id: Id7306af0792646887740ab3c7952d5fffe8c760b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1454
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updates to OICSensorboard example

* Updated OICSensorBoard client to work with the latest API
* Modified the server code for temperature conversion to reflect a minor circuit change
* Deleted OICSensorBoardREADME.pdf
* Added README and point to wiki page

Change-Id: Iab74e08f934e2a2c7c50c015b43e8fde8651bc85
Signed-off-by: Juliet Cai <juliet.z.cai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1221
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix issue the previous CreateResourceWithHost change

resolve issue registerResource mangles the name properly

Change-Id: I1926a03aef98c79ca00e2605730e856ab1a07915
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

things-manager: sampleapp: fix typo in ConClientApp

This should be ConClientApp and not ConClientApp

Change-Id: Ib39ad167674e31e8a1088f4f23e62d213fa4948b
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1444
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix NULL pointer deferencing in SimpleClientServer

Update PrintReceivedMsgInfo to print UNKNOWN when ehRequest is NULL.

Change-Id: Iaed6e2287efbcca2e41cc497545f21dcc6dc618a
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1356
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

CA linux/android sample modification for the secure message

In spite of selecting a secure, CA sample send the normal message.
I modified the CA sample to send secure message

Change-Id: I7725a0033b91dbc5159f9f27ee8147f4a3bfb174
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1425
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added one more unit test for OCCreateResource

* Unit test to exercise code path to check OCCreateResource() when the
  resource policy is non-discoverable & non-observable.

Change-Id: Ifd95cd6f48a498fbc81c5c62fd7c8df91855f40b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1438
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

CA Error handling for LE adapter

This adds error handling from LE adapter to the interface controller
Interface controller to RI Error Handling was submitted in
https://gerrit.iotivity.org/gerrit/#/c/1046/

Change-Id: If7cceb4db3a0c47c1fee6cd6814fd1257fc856e8
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1069
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Minimized hardcoding of CA transport adapter source file lists.

For each of the CA transport adapters, the single SConscript file that
handled construction of the source file list relied heavily and
needlessly on explicit target OS checks.  Minimize such logic by
delegating construction of such lists to newly created target
OS-specific SConscript files.  Each of those SConscript files will also
handle OS-specific CA transport adapter build configuration.

Change-Id: Iae493631491f6ce98521e36f1e4e790cee4d8186
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/820
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[CA] Fixed sample app code for Tizen and Arduino

Fixed build errors and run time errors w.r.to IPv6 and endpoint api changes

Change-Id: Ia2fc13cf2b0e60ee06e451725b1b283db99daa14
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

remove unnecessary code in caipserver

- remove unnecessary error check logic
- add the global variable initialization to fix the build warning

Change-Id: I1e02103b024a4b2a61d71f6e8403117069fe4b32
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1426
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[IOT-555]Add event logs to CA sample app

Fix spacing related issue and other missing Log added.

Change-Id: I07ccb79c38073c04bda5055fc07440445b8c124a
Signed-off-by: arafat.hsn <arafat.hsn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1277
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

CA Error handling for BT(EDR) Adapter

This adds error handling from BT adapter to the interface controller
Interface controller to RI Error Handling was submitted in
https://gerrit.iotivity.org/gerrit/#/c/1046/

Change-Id: I6ad67d5a4da4b65bba82c45bddbee3178fb06ef3
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1087
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[IOT-583] fixed Option Parameter is not support

HeaderOption in RequestInfo and responseInfo parameter
was not supporting since there are no logic related to it
after IPv6 merged.

trus. i'll be support through SendRequest and SendResponse

Change-Id: Ic200ebe29e130baac95991570183beb8f9fb7148
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1422
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[IOT-580] fixed RESET is not working

RESET on CoAP spec is not working in EDR
because OICStrcpyPartial(..) is supported only string format.
it have to be copied bytes to buffer

(https://gerrit.iotivity.org/gerrit/#/c/1208/8/
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrserver.c)

Change-Id: I01f4cabccdada80cccdc7efe6fb55fe203a09c99
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1416
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Corrected error return value when parsing fragmentation header.

CAParseHeader() on error returned CA_STATUS_INVALID_PARAM, a
CAResult_t value, instead of a value that matches uint32_t return
type.  Return zero on error instead.

Updated documentation accordingly.

Change-Id: I3dee0e2b562a272c5d41963e0049618d7bacd69e
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1419
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removed memory leaks in CA Unit Tests.

These memory leaks are reported by Valgrind on the build server. With
these removed, the threshold value for memory leaks can be lowered and
further commits will be more resilient.

Change-Id: I606ec487c0a4f0207b85556ed0c48b4f34873907
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1407
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added documentation build script for Doxygen and JavaDoc

This change set adds a script (./build_docs.sh) to generate
the documenation for iotivity which is placed into the ./docs
directory. Currently, the script builds java and C/C++ API
documentation and includes checks for warnings and errors.
When all of the existing warnings and errors are addressed,
this should be added to the build script to fail validation
if/when a contributor breaks the API documentation.

Please consider cherry-picking to the 0.9.1 release branch.

Change-Id: I490fbfc83cf61c76c7f59ba2c00404a073b039e7
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1418
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated android ResourceProperty to follow the same order as specified in octypes.h.
This fixes IOT-579.
Made a small correction in android build instructions

Change-Id: I5b2df5986ac8d0a75d9a987d8667f942a24ec2cf
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1420
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed unicast failure bug due to faulty strcpy

Recent modifications in ParseRequestUri introduced a bug where
IP address was not copied properly in OCDevAddr data structure.

Change-Id: I40a322530a11ab3cdae89d015cd774f507ccfdab
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1408
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix compile warnings in connectivity unittests

Unit test was emitting a warning due to unused variables in x86 Linux.
Corrected it by removing all unused varaibles.

Change-Id: I7f29487414e894149a8acc0620be4b7643f0f531
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1415
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Remove unnecessary code in Android CA Sample

As some CA API(FindResource/AdvertiseResource) had removed
by IPv6 change.
the code in Android Sample related to the API is removed
in this patch

Change-Id: I9a69620656c62aef5a89117cb562a441d08a349a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1413
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Added unit tests for StackResource

Unit test exercise code paths to check OCCreateResource() for
OC_LIENT mode and also to check if resource type name is invalid
i.e., null terminated or not.
This also includes the bug fix related to checking if resource type
name is invalid i.e., null terminated or not.

Change-Id: I7f8767a4e8b9586de9cb0926dd8a4afcd03b792c
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1391
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added missing DTLS #ifdef guard.

One of the functions only used for DTLS was missing #ifdef guards
resulting in compile warnings.

Change-Id: Ieb0082e1dba2547e8d73d0526cf0aab3bf3af589
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1333
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

removed duplicated code in Sample app

- Target Platform : Android, Linux

Change-Id: I7035a138cb9b83a6e653c213aaa4fc349b57545d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1395
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Remove unused scons file in examples/OICMiddle/ for x86 linux build

Actual file used is examples/OICMiddle/SConscript, So removed the unused
scons file examples/OICMiddle/SConstruct from git.

Change-Id: I9c0d3c37d0f228ed3125763f05efa7b447e4e41b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1399
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

remove unnecessary code in messagehandler

- remove the duplicated log message for the debugging
- add the null check logic for token

Change-Id: Icfd74fcc350b6e1c9038acdac290cfcaf9d344e7
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1402
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Remove unused make file in resource/csdk/connectivity/ for x86 linux build

Now scons are used in place of makefiles. So need to remove this left out
common.mk file from git.

Change-Id: Ice0abdc0a02ff78a9fddb0e407613d242acdffbe
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1403
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Realigned usage of IP Adapter modules' APIs on Arduino.

This fixes an issue where an Arduino using an Ethernet shield did not
respond to incoming requests nor notified the application of incoming
requests.

Change-Id: I035120e7bbe4a5950d2ed36a357f06c85c1ef8db
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1388
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[CA] Assigned unicast port number 0 instead of fixed number

Fix for jira issue IOT 379

Change-Id: Iaefe63189473fb106c5a43eb8648fc903ed3954e
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1338
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in Notification Manager

Fix memory leak in requestIsAlive when resource is not found.

Change-Id: Ia54883ac2d4f207402c4ac99a0e5304e96a39257
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1354
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix compile warnings in resource src

This patch fixes compiler warnings related to implicit declaration
of function 'strncasecmp' in resource security module

Change-Id: I4a785dde406fcaffe1acbb2b4f2c76524143c2d0
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1291
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Fix install external libraries comment on openssl in 'Readme.scons.txt'
file
Add comment libssl-dev

Change-Id: I160837cf3316eaecf6e872337ec4bc79a82ac9b8
Signed-off-by: Jiwon Kim <kjo6152@naver.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1095
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Remove unused includes.

Change-Id: Ifb5ec2dbe549d03add076d8a10844b3409484534
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1238
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Close fd after use in RestInput

A socket descriptor being created in loop and not closed after use.

Change-Id: Iadf195c4bb4591bcfd124e89a08964660bc64103
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1339
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update example applications fridgeclient & fridgeserver.

Update example application to pass OCRepresentation object by reference
instead of by value.

Change-Id: I8c38f656223181e8d4a95bee328fa4c622be92fb
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix NULL pointer deferencing in sample program.

Fix NULL pointer deferencing in send_response.

Change-Id: Ie38dd5d4d0c95fe4a8ccc26a23612584816ef442
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1342
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Make git ignore libraries and tinydtls binaries.

Change-Id: I19b3a32792cbe05d48b7e944cd26ca6bcb230386
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1385
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Enable generating credId sequentially

Added code to generate credId sequentially and disregard
the credId in POST credentail request.

Change-Id: I6da7343eb29817ead3a195c6b262738499d08472
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1284
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Addressed warnings that occurred when security was enabled.

Use memcpy() instead of OICStrcpyPartial() to copy remote endpoint
identity related binary data.  This addresses a pointer signedness
warning caused by a unsigned char* vs char* type mismatch.

Change-Id: I224d51439d57a0b86ae6ccb44aff5ece427459f8
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1384
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Updated some value of CAResponseResult_t

- VALID, CHANGED, CONTENT value is added.
- sample app also updated.

Change-Id: I41a59a3659bf27eb1de368ca3404e5bd101c2ed1
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1282
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added event logs to Android/Tizen for Primitive Service Assigned Jira issue IOT-555

Change-Id: I96dc633ac1b3117cbd2e00e14fd9797e81297160
Signed-off-by: arafat.hsn <arafat.hsn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1276
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix possible memory leak condition in PPM for Tizen Platform.

API app_get_id allocates memory internally, which was not freed
resulting in possible memory leak.

Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Change-Id: Ibc2cc77ebe803f174ab5e7ec5cff18e54178f2a8
Reviewed-on: https://gerrit.iotivity.org/gerrit/1239
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Fix NULL pointer dereferencing in ocstack

NULL check guard updated to call presenceResource.handle pointer only
when it is not NULL pointer.

Change-Id: I70f3f17b4a7b5c1f956efb7136458df0cc06f728
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1371
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added Valgrind generated "*.memcheck" files to the .gitignore list.

Change-Id: I6483c27e7867eacd4d05205d7ab140613b23f5af
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1370
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix NULL pointer deferencing in policyengine.

Update ProcessAccessRequest to call IsAccessGranted only when context is
not NULL.

Change-Id: I63abb58f254a5080ba46b30203f1e43fa6b2e781
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1359
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Modify android sample app

Modify the address to be automatically entered for testing

Change-Id: Ieaecd7e26571d1e767ef70318ec027d1c827c904
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[IOT-575] fixed Android Sample App in CA

there are some wrong and missed codes
after IPv6 changed

Change-Id: I965dcec243fb9ae59353595ee5a89d8ea881fe34
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1358
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[IOT-570] fixed multicast issue

there are some wrong codes in IPv6 changed.
CreateEndPoint(..) API need address parameter
even through Multicast

Change-Id: Ie9829c5ee56fb81446184737904a699efd941b9d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1323
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in Thing-Manager SampleAPP for Tizen Platform

In "onObserve" function locally malloc char* buf is not freed, which
creates a possible memory leak.

Change-Id: Ie8a6e6b31f580ffd4bc66c13f8f1dc3c3429a8c3
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1283
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix possible memory leak condition in PPM for Tizen Platform.

API app_get_id allocates memory internally, which was not freed
resulting in possible memory leak.

Change-Id: I513bda2dbb407eedd9e855703188eab180974122
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1281
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove logging lines running in a tight loop that flood logs.

These lines flood the logs with messages that are not useful most times
in debug mode.

Change-Id: I99aadb13379242ad529f0e075df09605a4b4d692
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix compile warnings in srmutility unittest

Unit test was emitting a warning due to type mismatch of the constant.
Corrected it by explicitly using the proper type.

Change-Id: I58a5aa4bacf551aeebf011069a38f47ed3888814
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1336
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Rename camsgparser to cafragmentation in adapter_util directory

file naming convention should be consistent throughout the entire code.
camsgparser seems to mean the control layer functionality.

Change-Id: Idb5d31fb4b480e879cb50b70588cc6ef24c6a8a6
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1134
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in sample app for linux

memory free applied in leakage areas

Change-Id: I34e356ff3ff5abb0072a15c526b2b37827d5b676
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1341
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed android build error

Changed to OICStrcpyPartial

Change-Id: I8fde944a0f2b85bfdbee6adc276db209574bf422
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1337
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Correct code that combined assignment with condition test.

Combining assignment with an if() condition test is prone to
errors in maintenance, triggers compile warnings and complicates
debugging.

Also fixed missing EOL at EOF.

Change-Id: I6691fdc4de915c5c95d0fa58997398e6028beaa6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1290
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-569] fixed Transport type issue in EDR

there is previous Transport type in IPv6 changed.

Change-Id: Id91b83d673baa83bf562c68f8521f5563f931c37
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1324
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[IOT-568] fixed linux sample app in CA

there are some wrong and missed codes in IPv6 changed.

Change-Id: I408a5c079a8ef1228194ce51b55a26dcd6f8c380
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1322
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix segfault on GET for device and platform info.

The mandatory fields for device and platform are not enforced by the
stack on init. They are enforced only when the info is explicitly added.
Servers that did not register this device and platform info segfaulted
when getting discovery requests from clients.
Added a null check before dereferencing a pointer to fix the problem.

Change-Id: I8b77d149014329e60f8aa8e9c1efb761394487da
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1285
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed Provisioning API handling for empty and malformed payload

please refer for details https://jira.iotivity.org/browse/IOT-564

Change-Id: I04a8ca6946b6d1c371e5235303f4733c5214674e
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1279
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Fix compile warning in oic_string unit test.

Unit test was emitting a warning due to type mismatch of the constant.
Corrected it by explicitly using the proper type.

Change-Id: Ibabdf289a46df025007b091b8a5e05f5a6ce7821
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1289
Reviewed-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

libcoap: fix big endian problems

When this is build for a big endian Linux system WORDS_BIGENDIAN was
not be set. This patch sets it correctly so it will not generate broken
code on big endian systems.
This was tested on MIPS BE 32 Bit.

Change-Id: I59dd07d8020c553318e2aa43894a2185fe9b9286
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix segfault in ocserver on invalid PUT json

If a client does a PUT with json that has the old "oc"
instead of "oic" it will cause a crash.

Change-Id: I05764cf7fe5613486d55d3a81cc757f45204dad3
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1286
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

IP address plumbing changes to support IPv6

IPv6 selection logic and IPv6 modifiers are now available throughout
the stack.
Builds with all samples and tests.
Works with IPv4.
Merged with security update.
Supports JIRA IOT-476,477,488,489,493,509,548

Change-Id: I539879aeeb5aeddf2b136d81fdf1247c2af12b5f
Signed-off-by: John Light <john.j.light@intel.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1081
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Replace/examine usages of mem* and strcat/strcpy

The codebase has a large number of mis-uses of memset, memcpy,
strcat, and strcpy.  This patch replaces them with OICStrdup,
OICStrcpy, and OICStrcat where possible, and fixes a number of
issues with memcpy/memset usages throughout the code.

Change-Id: Ifa03ed611778488c28f261266eb9a8821fa4db5c
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1208
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>

Fixed double free corruption in occlientbasicops handler

The scenario described in IOT-554 caused memory corruption in occlientbasicops
where OICFree is called twice in order to clean up ResourceNode List.
Removing explicit free calls in freeResourceList fixes the problem described
in IOT-554.

Change-Id: If5be1104cfb8804846f8fd684d59b018fb0401ba
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1244
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added REST query parser

Implemented rest query parser and added unit test for the parser's API.
Also added code to handle query in Doxm resource.

Change-Id: Id3dc6c171d9faa25a44849b316eaa54171a997a6
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1216
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Provisioning Manager to send CON request

Replace non-confirmable request to confirmable for the Provisioning
Manager.

Change-Id: I2cae1564d1c96c1cb35ced97813983467a6d96f2
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1260
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Updated README files to refer to usage of scons

Changed README files in resource/csdk/connectivity/samples/linux/
and resource/csdk/stack/ directories to refer to usage of scons
instead of make commands.
Removed trailing whitspaces as well, as recommended from Erich
and also removed the references to sample.sh as per
https://gerrit.iotivity.org/gerrit/#/c/1253/

Change-Id: I9f61ea80c12b48f0a86ea4ff24e0758d288ddc8e
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1254
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Remove sample.sh file

sample.sh file in resource/csdk/connectivity/samples/linux/
directory is not used after scons adaption. We can remove this file

Change-Id: Ica2bc6188696fd44a567b053dce899431252f0e1
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1253
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated resource discovery parsing logic for new 'policy' node

Recently resource discovery payload was updated to add a new
policy node. This changeset updated the payload parsing logic
for secure client application.

Change-Id: I3b256a0f3f496fe058890eec92587eb5b2fab241
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1246
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed memory leak in OICStrdup test

OICStrdup test didn't release its result memory, this fix
ensures that it is properly released.

Change-Id: Ieb271c5fbace45a730905de4dd02f2208bbf42e5
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1259
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Update NDK build with common source location change

oic_malloc and oic_string are moved to resource/c_common directory
in the patch https://gerrit.iotivity.org/gerrit/#/c/1163/
Updating android make file with the changes to fix the build

Change-Id: I297b6a25ee6a7fd744174194f9e37a877ba7cd57
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1191
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added unit tests for StackStop

Unit test modified to exercise code paths
* for checking OCStop() without any OCInit()
* to check for repeated OCStop()s after one OCInit()

Change-Id: I78a817befdce335d3dba40e5aee62275784f4ef2
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1252
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix cross compile link error

If call ld directly some flags (e.g. -m32) can't be recoglized.

Change-Id: I7f0c62c9f9e7530baf61ed9c658aa1cb15008009
Signed-off-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1248
Reviewed-by: Nirav Shah <nirav.j2.shah@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changing ocstack to retrieve double instead of int using cJson

Previously, we retrieved the sequence no. from presence payload
using object->valueint. Since the sequence no. is 32-bit unsigned
int, this caused the valueint to overflow. Hence, changing it to
object->valuedouble. This should fix IOT-549.

Change-Id: Idd30408c617e2ff84faa7c7c7f2a3f028577d337
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

fix master because cherry-picked change broke build

Change-Id: Idded4c0bedd28ce6d2064737f1ec1b7ddc630599
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1243
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Add EntityHandler callback parameter to C SDK.

Allows C api users to have a context callback parameter
with the use of EntityHandler callbacks for OCCreateResource.

Change-Id: I1358b6dbd5c2a9a1940f6146a87aacf84c16bb3c
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1042
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Fix for the Jira issue IOT-538

CpluffAdapter::findPlugins and PluginManagerImpl::findPlugins methods include the
plugins which does not have the attribute of parameter "key" and when the parameter
"value" is empty string. Modified the code to handle the case where getValueByAttribute
method returns empty string value.

Change-Id: Ia2564bff28b273a3552686d16374198e223f0bb2
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1206
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Android Plugin code file

For changed base code

Change-Id: If3a40333cb09a6c3bb2d6a01d275114a7ec45b14
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1225
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fixed possible memory leak condition.

Provisioning API returns list of unprovisioned devices. If parameter for
list is not null it can cause memory leak, changed code from just warning
from API to error and corrected test case according to it

Change-Id: I7ffe7efe116add643c1b062f2396d3486d677273
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1203
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Update pstat property name

Update the pstate commit hash property name based on the
security specification.

Change-Id: Id965150e9a1b17920e9c6339a7bc967e63f6f318
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1217
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Added unit tests for StackStart

Unit test exercise code path to check for zero length
Manufacturer Name in OCSetPlatformInfo()

Change-Id: Ic0003ba1041d14a0de1e55a09f5ff6181bc19a7f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1226
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[ARDUINO] Modified sample to let user select response

Modified sample to let user select response to a request

Change-Id: I3ce60015ce2dff382429bb546618950b6080dabd
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1204
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[TIZEN] Fix broken build caused by c_common merge

Tizen build was broken after merging of oic_malloc / oic_string.

Change-Id: I81ed8e5e5d5d13fd741ec66ac108f58430c8dcb9
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1233
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

cdsk: fix big endian problem

Without this patch the client will endianes swap the port number when
sending the detailed request after it got the answer for his multicast
get. Use the same method for storing the port number in the address
array in ever part of the code and do not use memcpy and manual
bytewise coping mixed over the code. memcpy was used once and byte wise
copy was used twice so I choose the majority.
This was tested on MIPS BE 32 Bit.

Change-Id: Ib486171987004d10209d2bbf6b1d9ada75235651
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1220
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Increase delay in presence notifications to avoid stability issues.

The C sample server, ocserver.cpp had a delay of 5 seconds before
sending out presence notifications. Failing to start the client would
cause missed notifications.
Increased delay to avoid false stability issues when testing.
This addresses IOT-546.

Change-Id: I2c9a7810d71886ff3abe7024c1f583bcd4ab65c5
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1215
Reviewed-by: Mark Tung <mark.y.tung@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

fixed android LE multicast

when send is failed in multicast in a device,
multicast routine just return without next step.
next device can be tried send through this fix.

Change-Id: I870c40384ddd5fbe092fdaae0db1ba03b7ccd583
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1210
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Bug fixing related to stringtests failures on x86

Fixed Crash issues related to Strcat in the following cases
* StrcatPartialShorterSourceLen
* StrcatPartialEqualSourceLen
* StrcatPartialLongerSourceLen
* StrcatPartialZeroSourceLen

The failures were due to buffer overflow during memset.

Change-Id: Ie588c7288377bea59366e8e1ebf9fed78f4fe5b1
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1213
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[ARDUINO] [BLE / IP] Fixed broken BLE build and IP crash

> Fixed broken Arduino BLE build
> Fixed IP crash

Change-Id: I1d367fd9b27a9a39b10d4fba267ca070daacd6e0
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1192
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add proguard-project.txt to the .gitignore file

The generated file proguard-project.txt was previously checked
in accidentally.  This patch adds it to the .gitignore so that
errors like this won't happen in the future.

Change-Id: Ic26b0d48bbb4bf50445e7314ecac6d9979b51e9d
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1196
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: Erich Keane <erich.keane@intel.com>

Fix for the Jira issue IOT- 531 and review comment fixes

Change-Id: I598491a857e95af37b03f44eac200d775728e6c9
Signed-off-by: arya.kumar <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for JIRA Issue IOT-535 and IOT-536

Change-Id: I5d581e8e2d98fa55f2718fecfa8143d0d59d6d17
Signed-off-by: Krishna Kumar KB <krishna.kb@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added Policy property to web type linking format

This change set is based on OIC core framework standard specification draft A,
Page#30,section 7.2.1.3 (Policy Property Definition).Added necessary changes
to display policy property (Discoverable,Observable, Active, Slow etc) in
JSON format. Modified core framework unit tests and samples to validate.

Change-Id: I406889d21488e3c4d49b9e3fac5d223770d9420e
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1110
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Clean Arduino build intermediate files

1) Remove .d files
2) Remove .map file

Change-Id: Ia196d072be56a8f31a492804e4d2d9a94ea43fec
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1199
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Merging security-M3 to master

Added support for resource access control, anonymous ECDH,
and Just Works Provisioning.

Patch 1 : Squashed all security-M3 patches and rebased to
          common ancestor of security-M3 and master.
Patch 2 : Rebased to master. (Arduino build fails).
Patch 3-4 : Fix the unit test failures.
Patch 5 : Fix the previsioning server send request issue
          by adding token length.
Patch 6 : Fixed Arduino compilation.
Patch 7 : Fixed DTLS handshake issue.
Patch 8 : Fix the build issue.
Patch 9 : Replaced strncmp with memcmp, As token handling is
          from null terminated string to byte buffer.
Patch 10: Rebased with master.
Patch 11-12: OSX Build Failure Fixes.
Patch 13: Updated README related to secure-Iotivity stack.
Patch 14: Fixed issues identified in Patch 5.
Patch 15: Rebased with master to avoid merge conflicts.
Patch 16: Updated commit message

Change-Id: Icae698c3bf377862b561d6ebba1d784058d28adb
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1071

NDK build Fix to support DTLS in Android sample

As the DTLS flag was not defined for in sample application
Android.mk, secure message sending fails, as credentials
cannot be set.This patch fixes the issue

Change-Id: I3f44cb1b299c967855112f9f1c3981b8499815e2
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add script license headers.

Change-Id: I94b31f4e7971d9840d760e8a5deb5478e17f7b7f
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1186
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

remove the unnecessary file.

proguard-project.txt is the unnecessary file.
so this file should be removed for open source.

Change-Id: Ib6c78cf7c1e104bc19ace44e1a965a0c6d368e6f
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1190
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>