Aaron Kennedy [Tue, 18 Oct 2011 04:10:36 +0000 (14:10 +1000)]
Allow one incubator to start in the statusChanged() of another
Change-Id: I91cb7e2a8ecc67f34cdcadc0b71f819c2881e2da
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Tue, 18 Oct 2011 03:34:20 +0000 (13:34 +1000)]
Behave correctly when AsynchronousIfNested is nested
When AIN is nested within a synchronous AIN, it should behave
synchronously.
Change-Id: Ib3f8281667118d7787967f25e27797f67e581006
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Martin Jones [Thu, 20 Oct 2011 08:20:10 +0000 (18:20 +1000)]
Mark qsgcanvasitem test as insignificant.
See QTBUG-22242.
Change-Id: I736455cff04bb4c88f0fd03ecb5fffe028687c12
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Martin Jones [Thu, 20 Oct 2011 05:49:54 +0000 (15:49 +1000)]
Skip failing tests.
Possibly due to V8 update.
Task-number: QTBUG-22238
Change-Id: Ide61c6693726e7b21766cac1166716a3af97e9d5
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Friedemann Kleint [Tue, 18 Oct 2011 09:00:02 +0000 (11:00 +0200)]
Declarative: Fix MSVC and g++ warnings
Potentially severe:
- Fix int/bool mismatches
- Use of uninitialized variable
- Do connectionMask shift operations in 64bit
- Enum type mismatch for QLineControl::EchoMode
Various:
- class/struct mismatches
- UnhandledEnumeration values
- Unused variables
- Constructor initialization order
Change-Id: Ieb52f8990445fe95f94070175a0f9beb66863240
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Jason McDonald [Mon, 17 Oct 2011 09:05:25 +0000 (19:05 +1000)]
Remove copy of tests/shared/util.h.
This module has a copy of qtbase's tests/shared/util.h, the contents of
which have been moved into qtestlib and are now accessible from the
QtTest/QtTest header.
Change-Id: I0be9e21dc9f30629dad283a740b9d80347e01140
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Toby Tomkins [Wed, 19 Oct 2011 03:34:24 +0000 (13:34 +1000)]
Skip test that crashes entire test suite.
Task-number: QTBUG-21995
Change-Id: Ic6b6d052f20e4d8c710e00f7b13bacdc146288d6
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Toby Tomkins [Mon, 17 Oct 2011 05:52:18 +0000 (15:52 +1000)]
Correct behavior for passing test, ifdef out failing test.
Task-number: QTBUG-21005, QTBUG-21688
Change-Id: I2b6ada399e7d26045c7f0a767082892332a6a378
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
Kai Koehne [Sat, 15 Oct 2011 14:05:13 +0000 (16:05 +0200)]
Debugger: Delete service if inspector plugin fails
Change-Id: Id782ddf17b04abd8efe1f504de7e55f4cc4262bb
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Tue, 18 Oct 2011 11:21:27 +0000 (13:21 +0200)]
Debugger: Let inspector plugin compile again
Change-Id: Ic1db404c0a62da7f8f9e31c7b400fba654e92979
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Kai Koehne [Tue, 18 Oct 2011 11:13:29 +0000 (13:13 +0200)]
Debugger: Remove visual toolbox from inspector
Change-Id: I8847d52a718a20a04cb23d8f0f5affdb7e038c57
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Martin Smith [Tue, 18 Oct 2011 08:04:30 +0000 (10:04 +0200)]
qdoc3: Remove several "QML:" qualifiers which should no longer be required
Task-number: QTBUG-22123
Change-Id: I78f755f978547685e77f4864bc47d1a2b2602343
Reviewed-by: Martin Smith <martin.smith@nokia.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Laszlo Agocs [Mon, 17 Oct 2011 05:20:58 +0000 (08:20 +0300)]
Deliver touch event timestamps in QSGCanvas.
The timestamp in input events is new in Qt5. When making copies of a
touch event this field must be copied too otherwise the event received
by the items will contain a default timestamp of 0.
Change-Id: I87dd337c964f34a6da6db808d83b7311df64fcd5
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Friedemann Kleint [Mon, 17 Oct 2011 14:02:01 +0000 (16:02 +0200)]
Declarative: Give qmlscene top level window flags.
Add menu and close buttons on Windows as well.
Change-Id: Ie458f8f21b14583c1a02d48819ec797e6db7390e
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Alan Alpert [Mon, 17 Oct 2011 05:15:31 +0000 (15:15 +1000)]
Mark particles tests as significant
Believed to be stable enough for CI now. Except qsgage.
Change-Id: I49d52c3913bb4140de89b769777f9b6d67abbaaa
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
Aaron Kennedy [Tue, 18 Oct 2011 03:19:57 +0000 (13:19 +1000)]
Fix assert
Change-Id: I6db293c278f10be7e998ed15fe93b9d328474e6a
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Bea Lam [Tue, 18 Oct 2011 01:09:25 +0000 (11:09 +1000)]
Fix reference to test data file
Change-Id: I04e220635487d76d2908572ceb0f0696f6876e9e
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Aaron Kennedy [Tue, 11 Oct 2011 04:21:42 +0000 (14:21 +1000)]
Simplify expression guard logic
Change-Id: I7d191bc8786452c5a1f14d024ff62d223adebd8b
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Andrew den Exter [Wed, 12 Oct 2011 03:02:39 +0000 (13:02 +1000)]
Fix TextInput echoMode test failure.
The default input method hints for a QSGItem is Qt::ImhMultiline and
TextInput is a single line input so clear that default flag in init.
Task-number: QTBUG-21686
Change-Id: I3b57227ee4182bf89f6789f775b56efb156df85b
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Wed, 12 Oct 2011 01:21:29 +0000 (11:21 +1000)]
Remove the InputContext module.
The input context module provided a bridge between QML and a
QInputContext which allowed an application to implement it's own input
method in-process. However since QInputContext has been replaced and
now only exists as a QWidget compatibility API this module no longer
works with the QtQuick 2 items and porting it to the new
QPlatformInputContext API does not seem to be an option as there is
no way to override the instance provided by the platform integration.
Change-Id: Ica602377436fcea42b9ffd05e1b347e2ee52acc8
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Tue, 11 Oct 2011 03:09:42 +0000 (13:09 +1000)]
Don't keep a cache of created QSGDragAttached objects.
It's unnecessary and can potentially return stale objects.
Change-Id: Ia04b9a58757ef06d3178e6a64e168f68abc1c9d8
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Kai Koehne [Sat, 15 Oct 2011 15:15:45 +0000 (17:15 +0200)]
Debugger: Fix compilation warning
Change-Id: I22fc756ce29bba2834bbdcaa40a9769a5391e337
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Sat, 15 Oct 2011 14:56:40 +0000 (16:56 +0200)]
Fix QDeclarativeInspector when starting with ,block
Change-Id: I3797567f22f61abf59ec5332ebc74b3fa37ede93
(cherrypicked from commit
6cb43a9b72c67b71409a59fdeb419f390441f0c7)
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Sat, 15 Oct 2011 13:56:06 +0000 (15:56 +0200)]
Debugger: Create InspectorService only when debugging is enabled
Change-Id: Ie9704233012b0bd0e473c5ee6011e6382c61900f
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Mon, 17 Oct 2011 12:13:01 +0000 (14:13 +0200)]
Debugger: Make QDeclarativeDebugJS autotest more robust & faster
Also compile it by default (again).
Change-Id: I04537e29d48cd1918160fe57220eecf1a72a8e66
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Kent Hansen [Mon, 17 Oct 2011 11:03:58 +0000 (13:03 +0200)]
Fix coding style issues
Avoid Qt Sanity Bot noise when these files are moved.
Change-Id: I714e949837909883fe7e387ae336d2ffc4a1912b
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Kent Hansen [Fri, 14 Oct 2011 06:13:44 +0000 (08:13 +0200)]
Tidy up some more declarative includes
Remove file dependencies that aren't needed.
Change-Id: I0496ef9435141528f680bbd326da55c3a31e5978
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Kent Hansen [Wed, 12 Oct 2011 06:26:22 +0000 (08:26 +0200)]
Clean up declarative includes
(This commit is in preparation of moving several files
to a separate library (QtQuick2).)
Don't add all subfolders to the includepath (from the
.pri files). There's no good reason to do that.
For headers (both public and private) that are in the
same folder as the file that includes them, prefer to use
#include "foo.h"
#include "bar_p.h"
For public headers that are outside the current folder
but have "unambiguous" names (e.g. qdeclarative prefix), use
#include <foo.h>
For private headers that are outside the current folder, use
#include <private/baz_p.h>
Also change
#include <QtDeclarative/private/foo_p.h>
to
#include <private/foo_p.h>
The header filenames already have a qdeclarative or qsg
prefix; there's no need to prefix by module name to
disambiguate.
Finally,
#include "private/foo_p.h"
should be avoided. private/ is used for auto-generated
(forwarding) headers, which never reside in the current
(source) directory. Use angle brackets instead.
Change-Id: I04f8477fdba043546064ee276475c09dc373f8f2
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Kai Koehne [Sat, 15 Oct 2011 15:52:17 +0000 (17:52 +0200)]
Debugger: Remove outdated test stub
This stub is testing the QScriptEngineAgent interface, which is deprecated.
Change-Id: I192a7b9aed0fa49f413bd6048e874414dab8256b
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Kai Koehne [Sat, 15 Oct 2011 15:43:55 +0000 (17:43 +0200)]
Debugger: Move debugging autotests into own folder
This mirrors the source tree structure and
makes it easier to run them all in one go.
Change-Id: Ia191790eaec2c409857c41aff479d2ebd144aaf8
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Bea Lam [Mon, 17 Oct 2011 05:50:07 +0000 (15:50 +1000)]
Fix GridView to repaint when geometry changes
Task-number: QTBUG-22078
Change-Id: Ic0ad67832dad9a7b3a7e5501893befe2d30b6c94
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Toby Tomkins [Mon, 17 Oct 2011 04:46:07 +0000 (14:46 +1000)]
Remove insignificant flag from tests, some failing test cleanup.
Task-number: QTBUG-21054 QTBUG-21004
Change-Id: I9d1a3ca99363949eee952e1bd09aabef82fc1831
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Alan Alpert [Mon, 17 Oct 2011 04:17:41 +0000 (14:17 +1000)]
Add Affector Benchmark
Just for generic affector.
Change-Id: I62acf524eb2c6491bc88fd687a0065866d7ceaaa
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Mon, 17 Oct 2011 02:02:22 +0000 (12:02 +1000)]
Stabilize Particles Tests
A couple of targeted fixes, plus enabling
QUnifiedTimer::consistentTiming.
Task-number: QTBUG-21867
Change-Id: I62acf524eb2c6491bc88fd687a0065866d7ce8aa
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Fri, 14 Oct 2011 03:06:41 +0000 (13:06 +1000)]
Initial particle system benchmark
Exposed another function on ParticleSystem in order to work.
Change-Id: I62acf524eb2c6491bc88fd687a0065866d7ce852
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Mon, 17 Oct 2011 02:39:22 +0000 (12:39 +1000)]
Fix tests
Fix referenced test data file and don't wait so long for move
to process
Change-Id: I55571e99015f2799a231365532aa1778e148f9e5
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Martin Jones [Thu, 13 Oct 2011 07:41:51 +0000 (17:41 +1000)]
Cannot flick to the end of a horizontal ListView with LayoutMirroring
Forward port of fix for QTBUG-21756.
minXExtent calculated the offset due to highlight range incorrectly
(reversed) when mirroring enabled. Also us same algorithm for fixup()
in GridView and ListView uses.
For QtQuick 2, this change also reverses the beginning and end highlight
range, as it should be, i.e. the preferredHighlightBegin is from the
right side in RightToLeft mode. Also added snapping tests.
Task-number: QTBUG-21756
Change-Id: Ica0ba4ab5db0ce9c77f2da75e9f8293550bd37d1
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Tue, 11 Oct 2011 01:09:17 +0000 (11:09 +1000)]
Merge PropertyCache::Data and ValueTypeData
Change-Id: I22cbb159d009151dd77ecbcdad16f27ecb9d6dba
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Alan Alpert [Tue, 11 Oct 2011 04:16:33 +0000 (14:16 +1000)]
Allow sizing of TrailEmitter emit area based on particle size
Change-Id: I7ce2ba29459b9a66e62933f9bfb9e066baedaaef
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Rohan McGovern [Fri, 14 Oct 2011 00:34:04 +0000 (10:34 +1000)]
Eliminated usage of qttest_p4.prf.
Missed from
47e1b91b47dcf59dbeff2740add94ceda188c6bc.
Change-Id: I64d6174eb98eb45e1ba7c28ae5a122f58e2522a6
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
Alan Alpert [Fri, 14 Oct 2011 07:06:39 +0000 (17:06 +1000)]
Add Move affector
Slated to replace the 'Gravity' affector which only did one specialized
gravity usecase anyways. This one is more generic.
Change-Id: I3cbb975bad24e8f6fca7e07b671aa8ba5a3a916c
Reviewed-on: http://codereview.qt-project.org/6657
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Bea Lam [Wed, 12 Oct 2011 04:30:18 +0000 (14:30 +1000)]
Fix insertions above the visible index
The first visible item was repositioned incorrectly after an insertion
above the visible index since any insertions above the position + cache
buffer were ignored and not considered for repositioning the first item.
GridView insertion code has changed to be similar to the ListView
implementation to fix various issues when inserting above the visible
index and to remove code that crossed indexes from visibleItems with
model indexes and visible indexes.
Also adds extra insertion tests for ListView and GridView.
Change-Id: I5e129c605fdad733b61bd29850465b3b752fb63f
Reviewed-on: http://codereview.qt-project.org/6485
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Friedemann Kleint [Wed, 12 Oct 2011 15:22:41 +0000 (17:22 +0200)]
Remove QMetaObjectBuilder from declarative.
Link on Windows.
Change-Id: Idca11c1a21ad5aebf79d6487692d912b4dea249f
Reviewed-on: http://codereview.qt-project.org/6553
Reviewed-by: Lorn Potter <lorn.potter@nokia.com>
juhvu [Wed, 12 Oct 2011 04:05:38 +0000 (14:05 +1000)]
(private-) export QSGShaderEffectTexture
QtLocation maps need to be able to render standard QML elements
as Map items (for example a convenience store logo and text).
Prior to Qt5 this was achieved with Qt graphics view framework.
This export is needed in order to be able to ask QML engine
to generate/update/render textures as needed.
Only private symbol really used is the updateTextures().
This commit complements the related earlier commit
1780033cb259bbb166fe9b4b14c92829a8e1800e
Change-Id: I98b2083b6a4d25fdd113ac4d95a9b9a2bb13a1f1
Reviewed-on: http://codereview.qt-project.org/6475
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Michael Brasser [Wed, 12 Oct 2011 06:16:09 +0000 (16:16 +1000)]
Add missing autotests to declarative.pro.
Change-Id: Icf43fc3aa69ac80fc077318d903becf3b78cc55b
Reviewed-on: http://codereview.qt-project.org/6492
Reviewed-by: Damian Jansen <damian.jansen@nokia.com>
Michael Brasser [Fri, 14 Oct 2011 02:02:43 +0000 (12:02 +1000)]
More use of TESTDATA macro.
Change-Id: I65ff7aa44e18a60e431d30efec2717d2ce5f95e4
Reviewed-on: http://codereview.qt-project.org/6641
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Charles Yin [Fri, 14 Oct 2011 03:07:37 +0000 (13:07 +1000)]
only use one QSGView instance for all qml test cases
Change-Id: I9296e30d216b57d8cf2a11e94030781f03594aa6
Reviewed-on: http://codereview.qt-project.org/6646
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Damian Jansen [Fri, 14 Oct 2011 01:37:25 +0000 (11:37 +1000)]
Tst_qsgitem2 test update inline with refactor
Change widget to window based code
Make compile and pass
Add license header
Change-Id: Id0826bf644836654de7eff559a8ff40a55d02616
Reviewed-on: http://codereview.qt-project.org/6635
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Aaron Kennedy [Fri, 14 Oct 2011 01:45:09 +0000 (11:45 +1000)]
QDeclarativeIncubator wasn't calling statusChanged() for nested cases
Change-Id: I1811951bdcdd69d4ad1643ed54a8ea097fa718b5
Reviewed-on: http://codereview.qt-project.org/6638
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Bea Lam [Fri, 14 Oct 2011 00:20:08 +0000 (10:20 +1000)]
Fix creation context for delegates
As per
cdf868033bbd7bf5a996c67fa56f8ac15e755115 for ListView and
GridView.
Change-Id: I6928a1fd4df51265124925530e81704dbdc5af46
Reviewed-on: http://codereview.qt-project.org/6629
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Kent Hansen [Wed, 12 Oct 2011 05:31:48 +0000 (07:31 +0200)]
Remove unneeded include
Change-Id: I8db00cee46dfb7f2a3bc4e73d093be3d766a8f7c
Reviewed-on: http://codereview.qt-project.org/6486
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Michael Brasser [Wed, 12 Oct 2011 03:46:02 +0000 (13:46 +1000)]
Use TESTDATA macro in declarative tests.
Includes a few other minor cleanups as well.
Task-number: QTBUG-21721
Change-Id: I5b1c2c116e63748c6b4199183212de8a00037af1
Reviewed-on: http://codereview.qt-project.org/6473
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Jason McDonald [Wed, 12 Oct 2011 05:44:20 +0000 (15:44 +1000)]
Don't build empty tests.
These tests need the xmlpatterns module. If that module is not in the
Qt build, then avoid building the test rather than building an empty
test.
Change-Id: Id0f72cfc9f818096361ecbc439196d2d5c64322e
Reviewed-on: http://codereview.qt-project.org/6487
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Kai Koehne [Tue, 11 Oct 2011 15:08:26 +0000 (17:08 +0200)]
QDeclarativeDebugTrace: Speed up appending elements to trace
Using a QVector with a Q_MOVABLE_TYPE with QVector should speed up
appending stuff by a magnitude.
Change-Id: Icf5cee87a0f35d81bf85f833f5656a9b296c80fd
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Mikko Harju [Wed, 12 Oct 2011 06:41:10 +0000 (09:41 +0300)]
Fix V8 heap snapshot in profiler service
Fixes the message parsing (use the option also for heap snapshot
commands).
Do not directly serialize the snapshot to the QByteArray under
QDataStream.
Change-Id: I3ad15a2debd6c2f912854610b6434744e0acd788
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Simon Hausmann [Wed, 12 Oct 2011 08:50:50 +0000 (10:50 +0200)]
Fix compilation on Harmattan
Fix issues with QString::QString(const char*)' being private
Change-Id: Ie3152d5fe952976dbda0ecb9dc28f9b6b5a1fab4
Reviewed-on: http://codereview.qt-project.org/6508
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Rohan McGovern [Wed, 12 Oct 2011 05:08:14 +0000 (15:08 +1000)]
Removed references to unused PULSE_TESTS variable
This has not been used for a very long time (since before QtDeclarative
was merged into Qt4).
Change-Id: Ie5b4578582d7b04784f11db3d8ce92ba258b782d
Reviewed-on: http://codereview.qt-project.org/6484
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Toby Tomkins [Wed, 12 Oct 2011 01:37:14 +0000 (11:37 +1000)]
Modify existing behavior to explicitly test functionality.
Task-number: QTBUG-21001
Change-Id: I63d0d56cc05328350804ad03cbc9a943a84d03c3
Reviewed-on: http://codereview.qt-project.org/6377
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Fri, 30 Sep 2011 07:17:49 +0000 (17:17 +1000)]
Provide a context when constructing a TextInput cursor delegate.
Without a context the delegate won't be able to refer to any external
properties.
Task-number: QTBUG-21780
Change-Id: I7171787e677ce67466b311796693ed88bcacb718
Reviewed-on: http://codereview.qt-project.org/5837
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 10 Oct 2011 06:38:07 +0000 (16:38 +1000)]
Rename QDeclarativeV4 -> QV4
Change-Id: Ic35e0ad1663cafe4aa535594dc3999a2d317ce0e
Reviewed-on: http://codereview.qt-project.org/6301
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Sanity-Review: Aaron Kennedy <aaron.kennedy@nokia.com>
Toby Tomkins [Tue, 11 Oct 2011 07:53:10 +0000 (17:53 +1000)]
Remove insignificant test status and explicitly mark failing test.
Task-number: QTBUG-21946
Change-Id: If1837a23041b52dc1f148821f483281975626d79
Reviewed-on: http://codereview.qt-project.org/6374
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Toby Tomkins [Tue, 11 Oct 2011 23:49:53 +0000 (09:49 +1000)]
Remove insignificant flag for passing tests.
Change-Id: Ic8c5e7871b240572b882825c91e0a544856da687
Reviewed-on: http://codereview.qt-project.org/6384
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Charles Yin [Tue, 11 Oct 2011 01:37:49 +0000 (11:37 +1000)]
fix crash bug when unloading canvas
Task-number:QTBUG-21935
Change-Id: If4a2a92b2f53cf81a48d023df8a1e6d11e522e0d
Reviewed-on: http://codereview.qt-project.org/6370
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Tue, 11 Oct 2011 06:23:50 +0000 (16:23 +1000)]
fix several canvasitem bugs
Change-Id: I6a6d97253fe66184736f8ac089e97aa114f0e83a
Reviewed-on: http://codereview.qt-project.org/6405
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Andrew den Exter [Wed, 28 Sep 2011 23:58:42 +0000 (09:58 +1000)]
Allow view items to be preserved.
Do not destroy items that are members of the VisualDataModel
persistedItems group when they are released by the view.
The create function on VisualDataGroup will return a reference to
an instantiated item within that group, any item returned by this
function is automatically added to the persistedItems group and can
be released by removing it from the group. Uninstantiated items added
to the persistedItems group by any other means are not instantiated
until requested by a view or create.
Task-number: QTBUG-21518
Task-number: QTBUG-20854
Change-Id: I59554711208504c8f20a3ebe783bddab9b21a558
Reviewed-on: http://codereview.qt-project.org/5831
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Tue, 11 Oct 2011 00:51:06 +0000 (10:51 +1000)]
Remove aggregated heap snapshots
Newer versions of v8 only support full snapshots.
Change-Id: I2c6778579bdb2ec1cc38868bf4fa76ce3fbc1633
Reviewed-on: http://codereview.qt-project.org/6406
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Sanity-Review: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 10 Oct 2011 03:52:34 +0000 (13:52 +1000)]
Optimize signal handling
Bindings connect to lots of signals that are never emitted. By managing
signal connection lists ourselves, we can do a much better job than Qt's
generic signal/slot connection logic.
Also, by connecting to QDeclarativeNotifierEndpoint's rather than QObject
slots, we can eliminate the need to instantiate a QObject for the V4 and
V8 binding managers.
Change-Id: I598667deaefdbd2860227bd74378a1b196761686
Reviewed-on: http://codereview.qt-project.org/6278
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Sanity-Review: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Fri, 7 Oct 2011 03:16:47 +0000 (13:16 +1000)]
Component.incubateObject() autotest
Change-Id: I37f76d5b273ae4f032c4de5ac8fcbff4204b78fe
Reviewed-on: http://codereview.qt-project.org/6200
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Sanity-Review: Aaron Kennedy <aaron.kennedy@nokia.com>
Yann Bodson [Thu, 22 Sep 2011 01:34:58 +0000 (11:34 +1000)]
Improvements to text layouting in QML
Allow more control over the text layouting process in QML.
Give access to every text line through a hook, this gives the
opportunity to position and resize a line as it is being laid out.
It is then possible to lay out the text in columns or around other
objects.
Task-number: QTBUG-21367
Change-Id: I56dc0c1c4b575dc06360c135098024d0324d3656
Reviewed-on: http://codereview.qt-project.org/5351
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Sanity-Review: Yann Bodson <yann.bodson@nokia.com>
Christiaan Janssen [Fri, 7 Oct 2011 15:35:53 +0000 (17:35 +0200)]
QmlProfiler: send end of trace event
Change-Id: I2e857028bde15145d5d01c6f5325a4ceabb37e27
Reviewed-on: http://codereview.qt-project.org/6434
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Jiang Jiang [Tue, 11 Oct 2011 09:10:41 +0000 (11:10 +0200)]
More accurate timing for rendering thread
To get a better overview of how much time we consumed rendering
each frame, setting QElapsedTimer around each loop in the rendering
thread. It can be turned on with QML_CANVAS_TIMING=1 environment
variable.
Change-Id: I81a231983e5f7d898589d5fe18782dd5c7e8e0dc
Reviewed-on: http://codereview.qt-project.org/6420
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
Christiaan Janssen [Fri, 7 Oct 2011 12:51:07 +0000 (14:51 +0200)]
QmlProfiler: tracking animations
Change-Id: I78fa5ed5385dfe1715c9d05a5e63eb7185870e61
Reviewed-on: http://codereview.qt-project.org/6254
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Sami Kananoja [Wed, 28 Sep 2011 08:16:51 +0000 (11:16 +0300)]
QInputPanel exposed as a property from QDeclarativeApplication
Task-number: QTBUG-21449
Change-Id: I437f80f4d1f0dbb3cb410940213eae50a4cef2cd
Reviewed-on: http://codereview.qt-project.org/5852
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Rohan McGovern [Tue, 11 Oct 2011 05:14:05 +0000 (15:14 +1000)]
tests: eliminated usage of qttest_p4.prf
qttest_p4.prf was added as a convenience for Qt's own autotests in Qt4.
It enables various crufty undocumented magic, of dubious value.
Stop using it, and explicitly enable the things from it which we want.
Since QT+= had to be touched already, this change also removes a lot of
useless duplication on those lines.
Change-Id: I9f2f20eaf4a0e676beddf474c7db8680e4712f78
Reviewed-on: http://codereview.qt-project.org/6302
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Toby Tomkins [Tue, 11 Oct 2011 03:12:23 +0000 (13:12 +1000)]
Remove insignificant test status and explicitly mark failing test.
Task-number: QTBUG-21946
Change-Id: Idf54ad4811562634b792f973c9f1a518a09e5a4d
Reviewed-on: http://codereview.qt-project.org/6375
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Mon, 10 Oct 2011 00:37:31 +0000 (10:37 +1000)]
Fix layout issues with recently removed items.
Items removed from the source model aren't removed from the cache
group until they've also been released by the view. Skip over
these removed items when translating future changes to the source
model so no invalid translated changes are created.
Change-Id: I9bf3801135e78b5a6493b4ef50ce44ee5c912bfc
Reviewed-on: http://codereview.qt-project.org/6298
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Charles Yin [Tue, 11 Oct 2011 04:28:28 +0000 (14:28 +1000)]
fix canvas bug
do painting only after component loaded and paint after geometry size initialized
Task-number:QTBUG-21920
Task-number:QTBUG-21918
Change-Id: Ibbc12d416dc694eff35f16c03cbc3c16e333645b
Reviewed-on: http://codereview.qt-project.org/6387
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Alan Alpert [Mon, 10 Oct 2011 09:05:51 +0000 (19:05 +1000)]
Expand QSGImageParticle test
Now tests all performance levels.
Also fixes an emitter timing edge-case which might be destabilizing the
tests.
Change-Id: I5e2f133dc4b96dd05d49e7e983ae630e379fa66b
Reviewed-on: http://codereview.qt-project.org/6313
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Mon, 10 Oct 2011 09:22:24 +0000 (19:22 +1000)]
Documentation Augmentation
The performance implications of adding an affector should be mentioned.
Change-Id: I0d508b0dfd16a7e9a56bf5f3c7797d1f4dd6a609
Reviewed-on: http://codereview.qt-project.org/6314
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Mon, 10 Oct 2011 08:02:17 +0000 (18:02 +1000)]
Stabilize Particles tests
One potential problem is that in certain circumstances the recycling
data list is so efficient that it doesn't need to use all particle data
in the list. In those cases, the uninitialized members were causing test
failures but these slight differences are acceptable for the simulation.
The ParticleSystem test is extended to check that it's only small edge
cases.
Change-Id: I5e2f133dc4b96dd05d49e7e983ae630e379fa66a
Reviewed-on: http://codereview.qt-project.org/6312
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Mon, 10 Oct 2011 08:30:41 +0000 (18:30 +1000)]
Initialize new particle data members
Change-Id: I1ba5aac70e662d64f9007a18465f520c8912ecf6
Reviewed-on: http://codereview.qt-project.org/6309
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Fri, 7 Oct 2011 05:23:08 +0000 (15:23 +1000)]
We no longer depend on qtsvg
Change-Id: I5980634dd4f234d9b7d0bed56c4f4cab9459fb37
Reviewed-on: http://codereview.qt-project.org/6209
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Michael Brasser [Fri, 7 Oct 2011 03:19:13 +0000 (13:19 +1000)]
Generic solution for finding QtDeclarative test data.
Also implemented changes for qsgrepeater test to verify.
Task-number: QTBUG-21721
Change-Id: Ia5a839d1a23ba0f6ee144450ec026b74ee72134b
Reviewed-on: http://codereview.qt-project.org/6203
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Bradley T. Hughes [Mon, 10 Oct 2011 14:27:10 +0000 (16:27 +0200)]
Use QBasicAtomicInt load() and store() instead of implicit casting
The implicit casts will be unavailable in the near future.
This is a follow up to commit
7f8472af8c03296be9e9ce50d8e9b3089eedf2f1,
which didn't catch all usages of the implicit cast and assignment
operator.
Change-Id: If05c343e2851b41e4a351c56328c4406c688fa0d
Reviewed-on: http://codereview.qt-project.org/6351
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Alan Alpert [Mon, 10 Oct 2011 07:12:06 +0000 (17:12 +1000)]
Update SpriteImage to modern standards
Includes updating shaders to contain the recent size flexibilities
added to QSGImageParticle, adding documentation, moving shaders
into the source file, and optional interpolation.
Small doc fixes, moving shaders into the source file, and moving the
resources (because there are no longer any shaders there) were applied
to ImageParticle and Turbulence (last user of particles resources).
Change-Id: I5e2f133dc4b96dd05d49e7e983ae630e379fa66f
Reviewed-on: http://codereview.qt-project.org/6303
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bradley T. Hughes [Mon, 3 Oct 2011 08:50:45 +0000 (10:50 +0200)]
Use QBasicAtomicInt load() and store() instead of implicit casting
The implicit casts will be unavailable in the near future
Change-Id: Ieab3603e500d3621e65f96d970c9935be7f3aa52
Reviewed-on: http://codereview.qt-project.org/6229
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Martin Jones [Fri, 7 Oct 2011 06:20:39 +0000 (16:20 +1000)]
Add "asynchronous" property to Loader.
Use an incubator to perform non-blocking instantiation of components.
Change-Id: I589bfc8ba7bf3368dc44fab3a82afb7e0d66032c
Fixes: QTBUG-21791
Reviewed-on: http://codereview.qt-project.org/6216
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Mon, 10 Oct 2011 05:34:05 +0000 (15:34 +1000)]
Compile
Change-Id: I80763db7108990b121de085b8c33cb90382b6cd1
Reviewed-on: http://codereview.qt-project.org/6292
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Sanity-Review: Aaron Kennedy <aaron.kennedy@nokia.com>
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Andrew den Exter [Mon, 10 Oct 2011 06:05:21 +0000 (16:05 +1000)]
Don't skip over the majority of the GridView tests.
Change-Id: Ie8768120c39451facbdb380668302fc645a06682
Reviewed-on: http://codereview.qt-project.org/6299
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Andrew den Exter [Mon, 12 Sep 2011 04:17:08 +0000 (14:17 +1000)]
Add DropArea item and Drag attached property.
Refactors drag API to improve compatibility with traditional drag and
drop by reusing events and adding drop actions.
Event sending is removed from MouseArea, instead the Drag object can
be attached to the item that is dragged and it will send drag events
when the position of that item is changed or when its active
property changes.
The DragTarget item is renamed to DropArea and can now communicate
supported and suggested actions.
Task-number: QTBUG-19747
Change-Id: I46cb77e68cf1ff32bbcbf0945facb593c9c2243c
Reviewed-on: http://codereview.qt-project.org/4638
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Fri, 7 Oct 2011 01:27:15 +0000 (11:27 +1000)]
Documentation Augmentation
The property name changed, the docs should change too
Change-Id: Idcdb9eaf570a7189da1ea00c9482fd1f72371906
Reviewed-on: http://codereview.qt-project.org/6189
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Charles Yin [Mon, 10 Oct 2011 01:30:15 +0000 (11:30 +1000)]
make it possible to run single qml test case file by passing a tst_*.qml file to -input option
Change-Id: I8376ca0ae23d4366d69e0e7f3c95593ba54fc71d
Reviewed-on: http://codereview.qt-project.org/6273
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Chris Adams [Fri, 7 Oct 2011 00:01:40 +0000 (10:01 +1000)]
Fix crashes caused by handle management in worker threads
Previously, the QV8Engine destructor and the QV8Engine's QV8GCCallback
Referencer destructor would crash if run after the v8 isolate had been
exited and disposed. This commit Q_ASSERTs if the worker thread
attempts to do so, and adds a cleanup function which worker threads
should call just prior to exiting the isolate.
Task-number: QTBUG-21866
Change-Id: I379b02e24ad9378e4bfc270fb9208715b6f7b60a
Reviewed-on: http://codereview.qt-project.org/6202
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Charles Yin [Mon, 10 Oct 2011 03:43:51 +0000 (13:43 +1000)]
fix doc errors
Change-Id: Ic092f2b2fba5d13eabbca8c599316e5f51193175
Reviewed-on: http://codereview.qt-project.org/6277
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Mon, 10 Oct 2011 01:11:04 +0000 (11:11 +1000)]
enable multisampling when paint on FBO with smooth = true
Task-number:QTBUG-21916
Change-Id: I7ff9810fbae30a7b765e1624293531204fc319fb
Reviewed-on: http://codereview.qt-project.org/6271
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Kai Koehne [Thu, 6 Oct 2011 14:33:47 +0000 (16:33 +0200)]
Debugger: Fix lock when profiling
Parts of the loading of data is now in a separate thread, which was already
trying to log trace data while the QDeclarativeDebugTrace constructor
was still blocking. Avoid this by calling QDeclarativeDebugTrace constructor
before the actual execution begins (addEngine()). Also make sure that the
logging methods are reentrant with a mutex.
Change-Id: I5c2c1d14763fd9c7cb6fc93c6dff22d00d8737f1
Reviewed-on: http://codereview.qt-project.org/6169
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Kai Koehne [Thu, 6 Oct 2011 14:37:48 +0000 (16:37 +0200)]
Debugger: Warn if we receive corrupted packets
Change-Id: Ie99e6806203d5c36dc8d3eb7778a04562c4d6871
Reviewed-on: http://codereview.qt-project.org/6170
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Kent Hansen [Wed, 5 Oct 2011 10:43:32 +0000 (12:43 +0200)]
Remove redundant checks in qdeclarativestategroup
Checking once should be enough for everyone.
Task-number: QTBUG-20482
Change-Id: I6cc1c608d9c1da0f4f745e436b9611937a8db160
Reviewed-on: http://codereview.qt-project.org/6054
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Kent Hansen [Thu, 6 Oct 2011 09:21:39 +0000 (11:21 +0200)]
Make qmlmin use QmlDevTools library for QML parsing
Needed to make it link in non-developer builds.
Change-Id: I45f413df5e4c01760aa245463c809c5b502a96c2
Reviewed-on: http://codereview.qt-project.org/6130
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Kent Hansen [Fri, 23 Sep 2011 08:08:30 +0000 (10:08 +0200)]
Say hello to QtQmlDevTools library
QtQmlDevTools is a private helper library. It provides QML/JS
file parsing for tools that live outside of the qtdeclarative
repository, such as lupdate.
This allows us to remove qttools's dependency on the
qtdeclarative sources.
To use the library:
QT += qmldevtools-private
#include <private/qdeclarativejsparser_p.h>
Change-Id: Ia43751b9be3d9fe05da03e65c6aca1cd9e3fdbbc
Reviewed-on: http://codereview.qt-project.org/6116
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
projects / profile / ivi / qtdeclarative.git / log