Chris Michael [Wed, 14 Oct 2015 13:28:47 +0000 (09:28 -0400)]
evas: Fix clang warning for missing field 'async' in default_state
Evas_Object_Filter_Data has a bool for 'async' at the end of the
struct. This field was missing from the initialization of
'default_state'
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Jean-Philippe Andre [Wed, 14 Oct 2015 10:42:49 +0000 (19:42 +0900)]
Evas GL: Fix support for the SW engines (OSMesa)
Since @raster changed the behaviour of the dirty flag on images,
damages must be added to redraw the GL surface. Evas_Image checks
if it is an Evas GL surface by looking at its native surface.
But in case of SW engine, there was no native surface information
for Evas GL surfaces. Also, the OPENGL surface type was awfully
abused for OSMesa support. Luckily EVASGL surface type lets us
pass arbitrary pointers :)
Jean-Philippe Andre [Wed, 14 Oct 2015 08:43:36 +0000 (17:43 +0900)]
Evas GL: Improve ERR log (direct rendering failed)
Jean-Philippe Andre [Wed, 14 Oct 2015 08:30:25 +0000 (17:30 +0900)]
Evas GL: Add a test case for Evas GL (make check)
For now this only covers SOME of Evas GL's functions.
It will try to run with opengl_x11 and buffer (OSMesa). It'll also
try to fail silently if the engine initialization failed, or if
OSMesa could not be found. If the engines work, then Evas GL must
work properly.
Jean-Philippe Andre [Wed, 14 Oct 2015 08:27:53 +0000 (17:27 +0900)]
Evas GL: Implement glGetString wrapper for OSMesa
This is only one step into making the software engine actually
work the same as a proper GL engine from Evas GL APIs point of view.
This is necessary for the test suite (coming next).
Jean-Philippe Andre [Wed, 14 Oct 2015 08:27:23 +0000 (17:27 +0900)]
Evas GL: Minor changes inside glGetString
Jean-Philippe Andre [Wed, 14 Oct 2015 07:58:05 +0000 (16:58 +0900)]
Evas GL: Avoid make_current(0,0) during destroy
Show an error message and call make_current(NULL, NULL) only if
the object (context, surface) being destroyed is current.
Otherwise, avoid changing the current context & surface.
Marcel Hollerbach [Wed, 14 Oct 2015 09:08:29 +0000 (11:08 +0200)]
gl_x11: val can be everything expected 0 to mean true
For me on a intel driver val is -1 and it needs to be inverted.
So we need to checkout that val is not 0 and not equals to 1.
Thx to raster for helping debugging this thing :).
Vincent Torri [Wed, 14 Oct 2015 08:17:00 +0000 (10:17 +0200)]
Eina: fix memory leak in eina_file_open()
@fix
Vincent Torri [Wed, 14 Oct 2015 07:58:19 +0000 (09:58 +0200)]
Eina: fix eina_file_current_directory_get()
the length was not correctly computed and eina_file_path_sanitize() was
was writing beyond the limit of the string
@fix
Vincent Torri [Wed, 14 Oct 2015 07:12:32 +0000 (09:12 +0200)]
Eina: fix spelling in eina_tmpstr documentation
Vincent Torri [Tue, 13 Oct 2015 18:45:33 +0000 (20:45 +0200)]
Evil: set EAPI correctly in pwd.h
Carsten Haitzler (Rasterman) [Wed, 14 Oct 2015 06:17:06 +0000 (15:17 +0900)]
evas gl engine - typo remove from previous commit
some typo crept in that... compiled. a stya / on a line. how it
compiled, i don't know.
Carsten Haitzler (Rasterman) [Wed, 14 Oct 2015 05:47:38 +0000 (14:47 +0900)]
evas - obj destructrion - handle when obj layer is partly destroyed
this should fix T2715 and anything similar as during destruction
object internals are a bit weird.
Carsten Haitzler (Rasterman) [Tue, 13 Oct 2015 11:34:31 +0000 (20:34 +0900)]
evas - fix evlog to push and pop properly
Amitesh Singh [Wed, 14 Oct 2015 03:48:01 +0000 (09:18 +0530)]
eina: util - set tmp to NULL to fix compilation warning
lib/eina/eina_util.c: In function 'eina_environment_tmp_get':
lib/eina/eina_util.c:96:7: warning: 'tmp' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (!tmp) tmp = "/tmp";
^
Jean-Philippe Andre [Wed, 14 Oct 2015 02:19:48 +0000 (11:19 +0900)]
Evas: Some coverity fixes
This are false alarms. But the explicit null check doesn't hurt.
Also, Coverity doesn't like eo_do_ret. Neither do I. :)
- CID 1327246
- CID 1327245
Jean-Philippe Andre [Tue, 13 Oct 2015 13:13:48 +0000 (22:13 +0900)]
Evas render: Fix proxy source_clip with source images
In case the source is an Evas_Image, we skip proxy_subrender,
and so the clip was not set against the source clip.
Jean-Philippe Andre [Tue, 13 Oct 2015 11:33:57 +0000 (20:33 +0900)]
Evas render: Fix proxy source_clip logic inversion
As spotted by @FurryMyad I inverted the logic for source_clip.
This should restore the proper behaviour while keeping my previous
fixes working. See D2940.
Nicolas Aguirre [Tue, 6 Oct 2015 16:49:53 +0000 (18:49 +0200)]
ecore_cocoa: fix a bug where event timestamp was not retrieved correctly.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Nicolas Aguirre [Thu, 24 Sep 2015 14:21:30 +0000 (16:21 +0200)]
evas: fix build of gl_cocoa engine.
__context_restore and __need_context_restore are undefined when
building gl_cocoa engine.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Nicolas Aguirre [Thu, 6 Aug 2015 21:33:24 +0000 (23:33 +0200)]
ecore_cocoa: use a timer instead of a poller to be more responsive when dealing with cocoa Event.
As all Mouse and Keyboard events comme from Cocoa, the poll period must
be reduced. Backwards of this method is that when no signal are
received for a long period, the timer fired anyway and consumes CPU
for nothig but it seems there is no easy method to integrate NSApplication
mainloop into an existing one.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Nicolas Aguirre [Thu, 6 Aug 2015 17:05:14 +0000 (19:05 +0200)]
ecore_evas_cocoa: use the same render function as ecore_evas_x
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Nicolas Aguirre [Thu, 6 Aug 2015 16:52:37 +0000 (18:52 +0200)]
ecore_cocoa: fix warnings, add Debug outputs where needed and remove printfs
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Tue, 13 Oct 2015 19:17:51 +0000 (15:17 -0400)]
eina: Include <unistd.h> for getuid and geteuid functions
Summary: If we do not include unistd.h, we end up with implicit
declaration warnings when compiling
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 13 Oct 2015 19:14:12 +0000 (15:14 -0400)]
ecore-wl: Add missing EINA_UNUSED for unused function paramaters
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Cedric BAIL [Tue, 13 Oct 2015 19:10:34 +0000 (12:10 -0700)]
evas: fix performance regression by reducing the unecessary memcpy we are doing.
Actually copying max is pretty useless and super slow. We usually have something
like 1024 slot in a context, but a very small amount of them are acutally active.
It would be better to actually do some kind of copy on write technique here, but
as Eina_Cow doesn't handle array and we are close to a release, let's be
conservative.
Cedric BAIL [Tue, 13 Oct 2015 18:45:52 +0000 (11:45 -0700)]
evas: follow API documentation more closely.
Tom Hacohen [Tue, 13 Oct 2015 13:31:29 +0000 (14:31 +0100)]
Ecore exe win32: Fix double-free errors.
As reported by vtorri, sometimes ecore_exe on win32 will encounter double
free issues. This was because the variable was freed, but not set to NULL
as expected by the cleanup function.
Fixes T2675
@fix
Carsten Haitzler (Rasterman) [Tue, 13 Oct 2015 10:43:18 +0000 (19:43 +0900)]
Revert "Revert "Revert "evas: fix borked rotation support in GL engine."""
This reverts commit
f51168f4ec7a1bd3072428c7a271ad7c6715fde5.
if this is right or not... this RESULTS in enlightenment becoming
totally unusable. put this back WHEN other issues are fixed you think
that exist. last i knew we query yinvert start with glx per native
surface and use that info - so as best i know it is and has been right
for a long time.
:)
Amitesh Singh [Tue, 13 Oct 2015 03:31:26 +0000 (09:01 +0530)]
evas: fix compilation error
This is introduced in
5c02935a866a5c14
Cedric BAIL [Tue, 13 Oct 2015 00:22:27 +0000 (17:22 -0700)]
Revert "Revert "evas: fix borked rotation support in GL engine.""
This reverts commit
5bb1c52e3a075d3a69b5baee2f2ad8d2788655b0.
This patch is actually correct, but it highlight a bug in how we
retrieve GLX_Y_INVERTED_EXT value.
Cedric BAIL [Tue, 13 Oct 2015 00:47:19 +0000 (17:47 -0700)]
evas: correctly get GLX_Y_INVERTED_EXT.
Vincent Torri [Thu, 8 Oct 2015 20:32:57 +0000 (22:32 +0200)]
ecore: mimic UNIX code even more
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Wed, 7 Oct 2015 03:54:41 +0000 (05:54 +0200)]
ecore_exe: avoid thread doing nothing by adding a small sleep
This fixes the CPU to be usedat 100% for each thread in ecore_exe. This
is obviously not an ideal fix and will be improved in the future.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Thu, 1 Oct 2015 06:45:51 +0000 (08:45 +0200)]
efreet: use ecore_file function instead of stat() in the icon cache code
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Thu, 1 Oct 2015 05:32:33 +0000 (07:32 +0200)]
ecore_file: remove whitespaces
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Thu, 1 Oct 2015 05:29:11 +0000 (07:29 +0200)]
ecore_file: fix ecore_file management function on Windows
On windows, stat() returns -1 if a path is finished with a \ or /,
so replace all stat() calls with a function which removes the trailing
slash or backslash on Windows
At this stage the code duplicate many code path for avoiding potential
borkage on Unix system. During 1.17 release cycle, it would be nice to
refactor this piece.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Tue, 29 Sep 2015 21:47:10 +0000 (23:47 +0200)]
ecore_exe: close handles only if they are valid
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Tue, 29 Sep 2015 21:35:40 +0000 (23:35 +0200)]
efreet: eina_file_mkstemp() needs a template with an extension
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Tue, 29 Sep 2015 21:34:23 +0000 (23:34 +0200)]
efreet: use eina_file_mkstemp() instead of mkstemp() for portability
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Tue, 29 Sep 2015 04:46:11 +0000 (06:46 +0200)]
edje: use eina_environment_tmp_get() instead of the TMPDIR env variable
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 11:27:15 +0000 (13:27 +0200)]
ecore_exe: fix command line when a shell is used, and increase buffer to 32768 bytes
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 10:15:04 +0000 (12:15 +0200)]
ecore_exe: remove infinite loop when killin process
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 09:24:42 +0000 (11:24 +0200)]
ecore_exe: use macro to free resources
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 08:18:54 +0000 (10:18 +0200)]
ecore_exe: better error message when child process can not be run
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 08:08:26 +0000 (10:08 +0200)]
ecore_exe: make sure that ReadFile() will not hang
When child process exits, ReadFile() will hang if those pipes are maintained
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 07:31:44 +0000 (09:31 +0200)]
ecore_exe: read remaining data when the child application has closed
Output and error threads could not read all the data sent by the child.
Based on a patch by Guillaume Friloux
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Fri, 25 Sep 2015 05:33:56 +0000 (07:33 +0200)]
ecore: lower log error level. Too much noise otherwise
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Fri, 25 Sep 2015 05:32:32 +0000 (07:32 +0200)]
ecore: mimic Win32 handlers deletion with Fd ones
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Fri, 25 Sep 2015 05:31:07 +0000 (07:31 +0200)]
ecore_con: remove debug
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Thu, 8 Oct 2015 20:33:30 +0000 (22:33 +0200)]
Ecore_Con: make sure to create named pipe with a unique name
Named pipes created with CreateNamedPipe() must have a unique name,
so append the process Id to the name
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Mon, 12 Oct 2015 23:11:00 +0000 (16:11 -0700)]
eina: fix potential security issue.
This also follow the behavior of eina_file_mkstemp.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Carsten Haitzler (Rasterman) [Mon, 12 Oct 2015 23:48:38 +0000 (08:48 +0900)]
Revert "evas: fix borked rotation support in GL engine."
This reverts commit
6153471ac3e209d86c21205ceedb97fdb8ce903b.
YES. YOU BROKE SOMETHING.... EVERY SINGLE COMPOSITED WINDOW IS NOW
UPSIDE-DOWN!
Carsten Haitzler (Rasterman) [Mon, 12 Oct 2015 12:42:18 +0000 (21:42 +0900)]
eina evlog - use CORRECT clock (monotonic) not gettimeofday if possible
Cedric BAIL [Mon, 12 Oct 2015 22:46:57 +0000 (15:46 -0700)]
evas: fix borked rotation support in GL engine.
This bug was introduced by
b0d2643f933bca2d959b873701c85c6f237328e9. I am
not sure I am not breaking that one instead now. Hopefully not.
Cedric BAIL [Mon, 12 Oct 2015 21:00:01 +0000 (14:00 -0700)]
ecore_con: be more defensive while using environment variable provided by the system.
This fix a crash during make check for system where one of those string where not defined.
Srivardhan Hebbar [Mon, 12 Oct 2015 20:24:44 +0000 (13:24 -0700)]
ecore_x: removing useless assignment pointer.
Summary:
The assignment to size has no effect on the caller and compiler
complain about it. Do shutdown compiler complain in a more reliable
way.
Signed-off-by:
Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3156
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Mon, 12 Oct 2015 19:11:53 +0000 (12:11 -0700)]
eina_tiler: add test cases for eina tiler area set/get functions
Summary:
Added test cases for eina_tiler_area_size_set and get functions
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3164
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Mon, 12 Oct 2015 19:09:04 +0000 (12:09 -0700)]
eina_queue: add test cases in eina thread queue module
Summary:
Added test cases for eina_thread_queue_parent_get and eina_thread_queue_fd_get
functions
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3165
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Mon, 12 Oct 2015 19:04:38 +0000 (12:04 -0700)]
edje_cc: fix segfault when a program attempts to play a non-registered sound
Summary:
When an edje program attempted to play a sound that was not registered
(e.g. in a sounds{} block), edje_cc would segfault instead of throwing
an error.
@fix
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3171
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Mon, 12 Oct 2015 18:06:48 +0000 (14:06 -0400)]
ecore-evas-wayland: Trap for subsequent resize events
Summary: If we have already resized this ecore_evas to be what we
want, then there is no point in running the below resize code as we
should already be at the requested size. Add a test at the beginning
to see if we have already set these values
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mrunal Sovani [Mon, 12 Oct 2015 16:05:49 +0000 (12:05 -0400)]
ecore_x: Optimize _ecore_x_modifiers_get()
Summary:
_ecore_x_modifiers_get() causes multiple XGetModifierMapping requests to the
server through _ecore_x_key_mask_get() function. _ecore_x_key_mask_get()
requests XModifierKeymap pointer every time it gets executed.
This can be optimized by a single XGetModifierMapping request in the
_ecore_x_modifiers_get() function itself and then passing the XModifierKeymap
pointer thus retrieved to the _ecore_x_key_mask_get() function.
Reviewers: raster, Hermet, tasn, zmike
Subscribers: yashu21985, alok25, sachin.dev, singh.amitesh, cedric
Differential Revision: https://phab.enlightenment.org/D3166
Boram Park [Mon, 12 Oct 2015 15:10:20 +0000 (11:10 -0400)]
evas-drm: remove useless condition
Summary: 'ob->priv.last > ob->priv.last' is always false
@fix
Reviewers: devilhorns, stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3159
Chris Michael [Mon, 12 Oct 2015 14:59:33 +0000 (10:59 -0400)]
ecore-evas-wayland: Fix common window configure callback to not adjust
for framespace
Summary: As we have already adjusted for framespace in various code
leading up to a configure callback, don't adjust for it here. This
fixes an issue where xdg surface window geometry would get incorrect
values which were including framespace. The values of the
xdg_surface_set_window_geometry should be Just the geometry of the
visible window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 12 Oct 2015 14:58:00 +0000 (10:58 -0400)]
ecore-evas-wayland: Don't resize ecore_wl window to include frame size
Summary: ecore_wl_window_resize adjusts the internal representation of
the window size so this should not include the "framespace" also. This
fixes an issue where xdg surface would be getting an incorrect window
geometry which included framespace.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 12 Oct 2015 14:55:50 +0000 (10:55 -0400)]
ecore-wl: Don't update window size during ecore_wl_window_resize
function
Summary: As we call ecore_wl_window_update_size from various places
when needed, don't call it inside the resize function. This addresses
an issue where sizes for the Ecore_Wl_Window may be out of sync
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Mon, 12 Oct 2015 10:45:38 +0000 (11:45 +0100)]
eolian generator: cleaner file write
Daniel Kolesa [Mon, 12 Oct 2015 10:35:59 +0000 (11:35 +0100)]
eolian generator: merge legacy and eo header gen entry points
Stefan Schmidt [Mon, 12 Oct 2015 09:46:06 +0000 (11:46 +0200)]
release: Update NEWS and bump version for 1.16.0-beta1 release
Jean-Philippe Andre [Mon, 12 Oct 2015 03:03:52 +0000 (12:03 +0900)]
Evas filters: Fix some build warnings
Thanks Tom for spotting one of those
Jean-Philippe Andre [Thu, 8 Oct 2015 06:01:21 +0000 (15:01 +0900)]
Evas filters: Fix some crash and reduce insanity
In a rare situation the filter would access an invalid buffer.
Solution: Stop messing with buffer references by properly
referencing and releasing them when not needed, rather
than stealing references and hoping for the best. (There were
flags tracking stolen references, but that was still madness)
Jean-Philippe Andre [Thu, 8 Oct 2015 05:00:39 +0000 (14:00 +0900)]
Evas: Add engine function image_ref
This is to simplify and fix filters. This is an internal function.
Jean-Philippe Andre [Thu, 8 Oct 2015 02:19:50 +0000 (11:19 +0900)]
Evas filter: Fix proxies of filtered images
@fix
Jean-Philippe Andre [Thu, 8 Oct 2015 01:57:54 +0000 (10:57 +0900)]
Evas render: Don't render deleted / invisible snapshots
Don't render them. They are not visible
Jean-Philippe Andre [Thu, 8 Oct 2015 01:56:35 +0000 (10:56 +0900)]
Evas render: Minor debug code improvements
Jean-Philippe Andre [Wed, 7 Oct 2015 11:03:37 +0000 (20:03 +0900)]
Evas snapshot: Fix proxies of snapshot objects
This was broken because the wrong image size was used
in the proxy's fast path (proxy of another image).
Why did snapshot use a specific surface_w,h instead of
reusing the usual cur->image.w,h? (@cedric)
Simplify code.
Carsten Haitzler (Rasterman) [Sat, 10 Oct 2015 01:50:44 +0000 (10:50 +0900)]
eeze - fix if formatting to be consistent within file
some if's were single line:
if (x) blah();
others were
if (x)
blah();
make formatting consistent at any rate.
same for EINA_LIST_FREE() blah();
Carsten Haitzler (Rasterman) [Sat, 10 Oct 2015 01:45:30 +0000 (10:45 +0900)]
fix tom's fix by nmot making e segfault EVERY EXIT
when fixing something like a leak .. it might be good to fix it to not
CRASH 100% of the time. a leak (minor) is better than a crash by far.
the strings in the list are stringshared.
fixes
896c18045aafb9c677d8d41b4876c47db2b4d5ce
Mrunal Sovani [Fri, 9 Oct 2015 17:17:45 +0000 (13:17 -0400)]
Ecore_xcb_keymap: Fix memory leak in _ecore_xcb_keymap_finilize
Summary:
xcb_get_modifier_mapping_reply_t *reply is obtained from
xcb_get_modifier_mapping_reply and should be freed after use.
Reviewers: raster, Hermet, tasn, zmike
Subscribers: singh.amitesh, yashu21985, alok25, sachin.dev, cedric
Differential Revision: https://phab.enlightenment.org/D3167
@fix
Felipe Magno de Almeida [Fri, 9 Oct 2015 16:54:32 +0000 (13:54 -0300)]
eolian-cxx: Fixed possible exception escaping main
Added try/catch around main to show the reason for the generation failure.
@fix CID 1265600
Felipe Magno de Almeida [Fri, 9 Oct 2015 16:48:17 +0000 (13:48 -0300)]
eolian-cxx: Fixed assert which was a tautology
Fixed the assert to the correct check
@fix CID 1316018
Tom Hacohen [Fri, 9 Oct 2015 13:22:36 +0000 (14:22 +0100)]
Evas engine wayland_shm: pass the correct enum value.
Following this patch, the correct enum type is now passed to this
function. It's also passing the same value (0), but now from the correct
enum. This doesn't change behaviour, and looks like what was intended.
This fixes the clang warning.
Chris Michael [Fri, 9 Oct 2015 12:55:26 +0000 (08:55 -0400)]
ecore-wayland: Comment out unused functions
Summary: As we do not listen for surface enter/leave events, we do not
need these functions so comment them out.
Thanks to Tom for the report :)
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 9 Oct 2015 12:54:41 +0000 (08:54 -0400)]
ecore-wayland: Comment out unused functions for session listener
Summary: As session listener is currently disabled in Ecore_Wayland,
we don't need these functions defined so comment them out.
Thanks to Tom for the report :)
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Tom Hacohen [Fri, 9 Oct 2015 11:41:29 +0000 (12:41 +0100)]
Evas engine software generic: Fix clang warning.
Double parenthesis comparison is reserved for evaluation for assignment, not just comparison.
So for example you should do ((x = 2)) and (x == 2), but not ((x == 2)) or (x = 2).
Tom Hacohen [Fri, 9 Oct 2015 11:37:28 +0000 (12:37 +0100)]
Ector renderer: fix return value to be of the right type.
This function expects a pointer as a return value, not a bool.
@fix.
Tom Hacohen [Fri, 9 Oct 2015 11:35:55 +0000 (12:35 +0100)]
Ethumb client: Fix shadow issues (warnings).
Tom Hacohen [Fri, 9 Oct 2015 11:32:37 +0000 (12:32 +0100)]
Eeze sensor udev: Fix memory leak and possible crash.
Due to a misplaced semicolon, EINA_LIST_FREE was doing nothing and only
the last part was freed if there was one, and probably a crash if there
wasn't.
This shows again that having statements without {} is dangerous. We need
to force {} and add a lint rule, or at the very least, add a rule to put
the ; in a new line (like clang warns about by default anyway).
(Same as issue found in previous commit)
@fix
Tom Hacohen [Fri, 9 Oct 2015 11:29:41 +0000 (12:29 +0100)]
Edje cc handlers: Fix memory leak and possible crash.
Due to a misplaced semicolon, EINA_LIST_FREE was doing nothing and only
the last part was freed if there was one, and probably a crash if there
wasn't.
This shows again that having statements without {} is dangerous. We need
to force {} and add a lint rule, or at the very least, add a rule to put
the ; in a new line (like clang warns about by default anyway).
@fix
Tom Hacohen [Fri, 9 Oct 2015 11:27:30 +0000 (12:27 +0100)]
Ector renderer: fix return value to be of the right type.
This function expects a pointer as a return value, not a bool.
@fix.
Tom Hacohen [Fri, 9 Oct 2015 11:23:41 +0000 (12:23 +0100)]
Eio model test: initialise pointer (clang warning).
This is probably not an issue because the function should always
return a value, but initialising this variable silence clang's
warning and is not harmful anyway.
Tom Hacohen [Fri, 9 Oct 2015 11:06:09 +0000 (12:06 +0100)]
Eo: Fix Eo on Windows.
We use function names instead of function pointers of Windows, because
of dll import/export issues (more in a comment in eo.c). Before this
commit we were comparing the pointers to the strings instead of the
content in some of the places, which caused op desc lookup not to work.
This fixes that.
Thanks to vtorri for his assistance.
@fix
Oleksandr Shcherbina [Thu, 8 Oct 2015 10:38:10 +0000 (12:38 +0200)]
evas_canvas3d: fix mesh being added twice added to scene data
Summary: @fix
Reviewers: cedric, Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3143
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 8 Oct 2015 10:26:55 +0000 (12:26 +0200)]
ecore_con: preventing possible NULL pointer dereference.
Summary:
Checking if client is NULL before freeing is not of much use. If it is NULL, it would have crashed before when it was dereferenced in printf. So checking NULL before dereferencing.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3151
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 8 Oct 2015 10:26:04 +0000 (12:26 +0200)]
ecore_exe: correcting spelling mistake in comment.
Summary:
Corrected the spelling mistake of mechanism.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3152
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 8 Oct 2015 10:23:32 +0000 (12:23 +0200)]
ecor_xcb: removing useless assignment.
Summary:
The assignment of NULL will have no effect on the caller. So removed that statment.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3153
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 8 Oct 2015 10:21:53 +0000 (12:21 +0200)]
ecore_xcb: initializing the uninitialized variable.
Summary:
realwin is uninitialized and is being checked against 0 at 384. It is set at 377 only if win2 == win, else it remains uninitialized. So initializing it to NULL.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3154
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 8 Oct 2015 10:20:46 +0000 (12:20 +0200)]
ecore_xcb: handle realloc failure.
Summary:
If realloc fails, then lst would be NULL, so assigning lst[i] only if realloc is successful, else assigning lst to previous memory location.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3155
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Thu, 8 Oct 2015 10:17:29 +0000 (12:17 +0200)]
eio_monitor: fix memory leak in eio monitor module
Summary:
Free the allocated memory in eio monitor win32 module.
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3160
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>