platform/upstream/libSkiaSharp.git
11 years agoNexus 7 performance trigger rebaselines
robertphillips@google.com [Tue, 7 May 2013 17:43:22 +0000 (17:43 +0000)]
Nexus 7 performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9040 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd block comment describing sync nature of SkStream
reed@google.com [Tue, 7 May 2013 15:59:16 +0000 (15:59 +0000)]
add block comment describing sync nature of SkStream

git-svn-id: http://skia.googlecode.com/svn/trunk@9039 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: now that we use MD5 instead of CityHash, the JSON should say so
epoger@google.com [Tue, 7 May 2013 15:51:54 +0000 (15:51 +0000)]
GM: now that we use MD5 instead of CityHash, the JSON should say so
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )

R=bungeman@google.com

Review URL: https://codereview.chromium.org/14758003

git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoXPS ttc handling.
commit-bot@chromium.org [Tue, 7 May 2013 15:28:15 +0000 (15:28 +0000)]
XPS ttc handling.

R=reed@google.com

Author: bungeman@google.com

Review URL: https://chromiumcodereview.appspot.com/14873006

git-svn-id: http://skia.googlecode.com/svn/trunk@9037 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Allow supporting 1 older PICTURE_VERSION."
scroggo@google.com [Tue, 7 May 2013 14:45:40 +0000 (14:45 +0000)]
Revert "Allow supporting 1 older PICTURE_VERSION."

This reverts commit deb9d6990ef2d153230340d960d86b0966f261e1.

That change was just to allow us to bump the PICTURE_VERSION
without changing the SKPs to the new one. Since it is not
entirely reliable, I am removing it.

R=rmistry@google.com

Review URL: https://codereview.chromium.org/14741007

git-svn-id: http://skia.googlecode.com/svn/trunk@9035 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCheck whether font creation is failed to avoid segment fault.
commit-bot@chromium.org [Tue, 7 May 2013 14:32:58 +0000 (14:32 +0000)]
Check whether font creation is failed to avoid segment fault.
In some rare cases, SkFontHost::CreateTypeface in src/ports/SkFontHost_fontconfig.cpp will return NULL, this will lead to segment fault because the previous code would access to 0x0 by (SkTypeface *)NULL->unref().

BUG=
R=reed@google.com, bungeman@google.com

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/14907005

git-svn-id: http://skia.googlecode.com/svn/trunk@9034 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreverting 9031
junov@chromium.org [Tue, 7 May 2013 14:11:40 +0000 (14:11 +0000)]
reverting 9031

git-svn-id: http://skia.googlecode.com/svn/trunk@9033 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SkPicture path bound optimization to handle inverse filled paths.
junov@chromium.org [Tue, 7 May 2013 13:26:18 +0000 (13:26 +0000)]
Fix SkPicture path bound optimization to handle inverse filled paths.

BUG=crbug.com/229011
TEST=Picture unit test

Review URL: https://codereview.chromium.org/14819008

git-svn-id: http://skia.googlecode.com/svn/trunk@9031 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 performance trigger rebaseline
robertphillips@google.com [Tue, 7 May 2013 13:08:41 +0000 (13:08 +0000)]
Nexus 7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9030 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd stroked oval benches.
jvanverth@google.com [Tue, 7 May 2013 13:03:21 +0000 (13:03 +0000)]
Add stroked oval benches.

Reviewed by: bsalomon
Review URL: https://codereview.chromium.org/14849011/

git-svn-id: http://skia.googlecode.com/svn/trunk@9029 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRun bench_pictures with "--config msaa4" on Razr I, Nexus 10, and GNex
borenet@google.com [Tue, 7 May 2013 12:09:54 +0000 (12:09 +0000)]
Run bench_pictures with "--config msaa4" on Razr I, Nexus 10, and GNex

Addresses: https://code.google.com/p/skia/issues/detail?id=1276

Review URL: https://codereview.chromium.org/15012002

git-svn-id: http://skia.googlecode.com/svn/trunk@9027 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 7 May 2013 07:01:03 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9023 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMask orientation and layout correctly.
commit-bot@chromium.org [Mon, 6 May 2013 22:23:08 +0000 (22:23 +0000)]
Mask orientation and layout correctly.

R=reed@google.com, clefru@google.com

Author: bungeman@google.com

Review URL: https://chromiumcodereview.appspot.com/14884010

git-svn-id: http://skia.googlecode.com/svn/trunk@9022 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r9016 due to Nexus7 GM regressions
jvanverth@google.com [Mon, 6 May 2013 19:29:23 +0000 (19:29 +0000)]
Reverting r9016 due to Nexus7 GM regressions

git-svn-id: http://skia.googlecode.com/svn/trunk@9020 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agolockPixels before calling getColorTable.
scroggo@google.com [Mon, 6 May 2013 18:08:05 +0000 (18:08 +0000)]
lockPixels before calling getColorTable.

Fixes a bug where we try to dereference a NULL pointer.

Update the comment for SkBitmap::getColorTable, telling
the client that pixels must be locked for it to return
non-NULL.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/15002002

git-svn-id: http://skia.googlecode.com/svn/trunk@9018 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBetter method for rendering AA ellipses.
commit-bot@chromium.org [Mon, 6 May 2013 16:44:03 +0000 (16:44 +0000)]
Better method for rendering AA ellipses.

This uses the standard ellipse equation as a signed distance
test, and adjusts the result by the length of the gradient
at that point to get a better approximation of the distance
to the ellipse. It replaces the standard ellipse and
roundrect shader renderers.

Also adds a check to see if the curvature extrema of the
stroke are less than the curvature extrema of the ellipse (i.e.
the radius of curvature is larger). In this case, it's no
longer an ellipse and we can't use this renderer.

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14938004

git-svn-id: http://skia.googlecode.com/svn/trunk@9016 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoby hook or by crook, force gcc to return the value of SkPoint::length() to actually...
reed@google.com [Mon, 6 May 2013 15:59:51 +0000 (15:59 +0000)]
by hook or by crook, force gcc to return the value of SkPoint::length() to actually be a float
instead of a double. Otherwise we can't properly test for overflow with large values.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14884011

git-svn-id: http://skia.googlecode.com/svn/trunk@9015 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 performance trigger rebaselines
robertphillips@google.com [Mon, 6 May 2013 15:39:11 +0000 (15:39 +0000)]
Nexus 7 performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9014 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't use writeData to write the document in GM.
bungeman@google.com [Mon, 6 May 2013 14:28:43 +0000 (14:28 +0000)]
Don't use writeData to write the document in GM.
https://codereview.chromium.org/14824003/

git-svn-id: http://skia.googlecode.com/svn/trunk@9013 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdated performance trigger baseline
robertphillips@google.com [Mon, 6 May 2013 14:08:08 +0000 (14:08 +0000)]
Updated performance trigger baseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9012 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unused complex script support from android builds
commit-bot@chromium.org [Mon, 6 May 2013 14:03:53 +0000 (14:03 +0000)]
Remove unused complex script support from android builds

R=reed@google.com

Author: djsollen@google.com

Review URL: https://chromiumcodereview.appspot.com/14942003

git-svn-id: http://skia.googlecode.com/svn/trunk@9011 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse exportVar function in nacl_make
borenet@google.com [Mon, 6 May 2013 13:49:41 +0000 (13:49 +0000)]
Use exportVar function in nacl_make

Dumps out the variables as they are defined for debugging
(SkipBuildbotRuns)

R=djsollen@google.com

Review URL: https://codereview.chromium.org/14655006

git-svn-id: http://skia.googlecode.com/svn/trunk@9010 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCopy NaCl directory into trunk/platform_tools, adjust paths
borenet@google.com [Mon, 6 May 2013 12:50:00 +0000 (12:50 +0000)]
Copy NaCl directory into trunk/platform_tools, adjust paths

(SkipBuildbotRuns)

R=djsollen@google.com

Review URL: https://codereview.chromium.org/14771017

git-svn-id: http://skia.googlecode.com/svn/trunk@9008 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreimplement generateFontMetrics to keep all calculations in SkScalar, avoiding the
reed@google.com [Mon, 6 May 2013 12:21:16 +0000 (12:21 +0000)]
reimplement generateFontMetrics to keep all calculations in SkScalar, avoiding the
risk of over/under-flow w/ the current fixed-point intermediates.

Review URL: https://codereview.chromium.org/14736005

git-svn-id: http://skia.googlecode.com/svn/trunk@9005 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefreshed SKP files. Whitespace change to trigger rebuilds.
rmistry@google.com [Sat, 4 May 2013 11:51:20 +0000 (11:51 +0000)]
Refreshed SKP files. Whitespace change to trigger rebuilds.
(AddDashboardAnnotation)

Review URL: https://codereview.chromium.org/14947003

git-svn-id: http://skia.googlecode.com/svn/trunk@9003 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 4 May 2013 07:01:15 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9002 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a new mode to render_pictures.
scroggo@google.com [Fri, 3 May 2013 20:43:37 +0000 (20:43 +0000)]
Add a new mode to render_pictures.

In the new mode, if an SKP file has encoded bitmap data, draw
the data to a file with the appropriate name.

R=borenet@google.com

Review URL: https://codereview.chromium.org/14637011

git-svn-id: http://skia.googlecode.com/svn/trunk@9001 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix more warnings.
scroggo@google.com [Fri, 3 May 2013 20:39:22 +0000 (20:39 +0000)]
Fix more warnings.

BUG=

Review URL: https://codereview.chromium.org/14624008

git-svn-id: http://skia.googlecode.com/svn/trunk@9000 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake rebaseline.py pull GN Debug images.
bsalomon@google.com [Fri, 3 May 2013 20:24:54 +0000 (20:24 +0000)]
Make rebaseline.py pull GN Debug images.

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/14743004

git-svn-id: http://skia.googlecode.com/svn/trunk@8999 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build (warning).
scroggo@google.com [Fri, 3 May 2013 20:21:17 +0000 (20:21 +0000)]
Fix build (warning).

BUG=

Review URL: https://codereview.chromium.org/14789014

git-svn-id: http://skia.googlecode.com/svn/trunk@8998 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTest region decoding in skimage, plus fixes.
scroggo@google.com [Fri, 3 May 2013 20:14:28 +0000 (20:14 +0000)]
Test region decoding in skimage, plus fixes.

Add tests in skimage to perform region decoding. Write out a
PNG of the region as well as a bitmap obtained with extractSubset
for comparison.

Rename decodeRegion to decodeSubset, so it will not be confused
with SkRegion. (Leave a function called decodeRegion which calls
decodeSubset.)

Clean up some comments.

Use png_set_interlaced_pass instead of modifying pass directly.

Make some changes to region decoding to fix problems I discovered
during testing:

Only call getAddr within a valid range.
Check for a NULL fInputStream.
Return a boolean for whether cropBitmap succeeded.
In cropBitmap, do not attempt to draw to a bitmap to an Index8
bitmap, which crashes. Use extractSubset instead.
Remove an assert.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/14567011

git-svn-id: http://skia.googlecode.com/svn/trunk@8996 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd (temporary) diagnostic code for normalize test
reed@google.com [Fri, 3 May 2013 18:11:00 +0000 (18:11 +0000)]
add (temporary) diagnostic code for normalize test

git-svn-id: http://skia.googlecode.com/svn/trunk@8994 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd endian tests (reviewed by bungeman)
reed@google.com [Fri, 3 May 2013 18:06:31 +0000 (18:06 +0000)]
add endian tests (reviewed by bungeman)

git-svn-id: http://skia.googlecode.com/svn/trunk@8993 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkBitmapHasher: use 64-bit-truncated MD5 instead of 64-bit CityHash
epoger@google.com [Fri, 3 May 2013 17:35:39 +0000 (17:35 +0000)]
SkBitmapHasher: use 64-bit-truncated MD5 instead of 64-bit CityHash
BUG=https://code.google.com/p/skia/issues/detail?id=1257

(if we change our mind within the next few days, we can toggle the
BITMAPHASHER_USES_TRUNCATED_MD5 #ifdef ; at some point, we'll remove that
option so we can delete our CityHash implementation entirely)

R=bungeman@google.com

Review URL: https://codereview.chromium.org/14054012

git-svn-id: http://skia.googlecode.com/svn/trunk@8992 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotrick the compiler into not knowning that I will generate an overflow
reed@google.com [Fri, 3 May 2013 16:30:44 +0000 (16:30 +0000)]
trick the compiler into not knowning that I will generate an overflow
(which is the point of the test). This avoids a warning, which breaks
our bots.

git-svn-id: http://skia.googlecode.com/svn/trunk@8991 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd benches for all xfermodes.
bsalomon@google.com [Fri, 3 May 2013 16:28:33 +0000 (16:28 +0000)]
Add benches for all xfermodes.

R=reed@google.com

Review URL: https://codereview.chromium.org/14818005

git-svn-id: http://skia.googlecode.com/svn/trunk@8990 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange setLength and Normalize to handle when mag2 overflows a float, but the
reed@google.com [Fri, 3 May 2013 15:59:39 +0000 (15:59 +0000)]
change setLength and Normalize to handle when mag2 overflows a float, but the
actual lenght does not.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/14838006

git-svn-id: http://skia.googlecode.com/svn/trunk@8988 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix copy-paste error in setup script
djsollen@google.com [Fri, 3 May 2013 14:21:35 +0000 (14:21 +0000)]
fix copy-paste error in setup script

BUG=

Review URL: https://codereview.chromium.org/14646027

git-svn-id: http://skia.googlecode.com/svn/trunk@8985 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCheck for third_party deps before compiling on android
djsollen@google.com [Fri, 3 May 2013 14:12:03 +0000 (14:12 +0000)]
Check for third_party deps before compiling on android

R=borenet@google.com

Review URL: https://codereview.chromium.org/14803004

git-svn-id: http://skia.googlecode.com/svn/trunk@8984 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExclude angle dependency on non-angle builds
djsollen@google.com [Fri, 3 May 2013 14:00:34 +0000 (14:00 +0000)]
Exclude angle dependency on non-angle builds

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/14200018

git-svn-id: http://skia.googlecode.com/svn/trunk@8983 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis may potentially fix a chromium issue and shouldn't hurt, so if anyone agrees...
sugoi@google.com [Fri, 3 May 2013 13:52:32 +0000 (13:52 +0000)]
This may potentially fix a chromium issue and shouldn't hurt, so if anyone agrees that this fix should be harmless, we can try merging it in to see if it's enough to fix "Invalid pointer write in GrRenderTarget::onRelease".

R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/14607003

git-svn-id: http://skia.googlecode.com/svn/trunk@8982 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for GL_*_shader__framebuffer_fetch
bsalomon@google.com [Fri, 3 May 2013 13:35:14 +0000 (13:35 +0000)]
Add support for GL_*_shader__framebuffer_fetch

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14875002

git-svn-id: http://skia.googlecode.com/svn/trunk@8980 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWin7 gpu performance trigger rebaseline (tabl_mlb)
robertphillips@google.com [Fri, 3 May 2013 13:12:48 +0000 (13:12 +0000)]
Win7 gpu performance trigger rebaseline (tabl_mlb)

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8978 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for SkPoint::normalize()
reed@google.com [Fri, 3 May 2013 12:56:39 +0000 (12:56 +0000)]
add bench for SkPoint::normalize()

git-svn-id: http://skia.googlecode.com/svn/trunk@8977 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 3 May 2013 07:01:00 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@8976 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd HACK_COLORGLYPHS (disabled) to test colorglyphs
reed@google.com [Thu, 2 May 2013 20:39:44 +0000 (20:39 +0000)]
add HACK_COLORGLYPHS (disabled) to test colorglyphs

git-svn-id: http://skia.googlecode.com/svn/trunk@8972 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCast our LOGFONTs in our enumerator callbacks to ENUMLOGFONTEX, so we
reed@google.com [Thu, 2 May 2013 19:47:24 +0000 (19:47 +0000)]
Cast our LOGFONTs in our enumerator callbacks to ENUMLOGFONTEX, so we
can get at the style-names.

git-svn-id: http://skia.googlecode.com/svn/trunk@8971 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix GL extension printing on core profiles.
bsalomon@google.com [Thu, 2 May 2013 19:42:54 +0000 (19:42 +0000)]
Fix GL extension printing on core profiles.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14864002

git-svn-id: http://skia.googlecode.com/svn/trunk@8970 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDetect color masks, and divert to draw-sprite instead of maskblitters.
reed@google.com [Thu, 2 May 2013 18:55:44 +0000 (18:55 +0000)]
Detect color masks, and divert to draw-sprite instead of maskblitters.

Review URL: https://codereview.chromium.org/14637007

git-svn-id: http://skia.googlecode.com/svn/trunk@8967 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate recommended gclient config for android
djsollen@google.com [Thu, 2 May 2013 18:42:10 +0000 (18:42 +0000)]
update recommended gclient config for android

Review URL: https://codereview.chromium.org/14857007

git-svn-id: http://skia.googlecode.com/svn/trunk@8964 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: fix --mismatchPath option
epoger@google.com [Thu, 2 May 2013 18:24:03 +0000 (18:24 +0000)]
GM: fix --mismatchPath option
(currently, it doesn't actually write any files!)

TBR=rmistry

Review URL: https://codereview.chromium.org/14855005

git-svn-id: http://skia.googlecode.com/svn/trunk@8963 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd geometry-based rotated AA rect drawing path
robertphillips@google.com [Thu, 2 May 2013 17:13:13 +0000 (17:13 +0000)]
Add geometry-based rotated AA rect drawing path

https://codereview.chromium.org/14854005/

git-svn-id: http://skia.googlecode.com/svn/trunk@8961 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAxis aligned shader-based rect drawing
robertphillips@google.com [Thu, 2 May 2013 15:37:20 +0000 (15:37 +0000)]
Axis aligned shader-based rect drawing

https://codereview.chromium.org/14314004/

git-svn-id: http://skia.googlecode.com/svn/trunk@8960 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix error that ran no tests if no options were passed
caryclark@google.com [Thu, 2 May 2013 14:23:07 +0000 (14:23 +0000)]
fix error that ran no tests if no options were passed

git-svn-id: http://skia.googlecode.com/svn/trunk@8959 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTTC support for DirectWrite.
bungeman@google.com [Thu, 2 May 2013 14:01:36 +0000 (14:01 +0000)]
TTC support for DirectWrite.
https://codereview.chromium.org/14600009/

git-svn-id: http://skia.googlecode.com/svn/trunk@8958 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new bench for rotated rects (aarects_rotated)
robertphillips@google.com [Thu, 2 May 2013 13:57:52 +0000 (13:57 +0000)]
Add new bench for rotated rects (aarects_rotated)

https://codereview.chromium.org/14688007/

git-svn-id: http://skia.googlecode.com/svn/trunk@8957 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSupport for libpng > 1.2.
commit-bot@chromium.org [Thu, 2 May 2013 13:41:34 +0000 (13:41 +0000)]
Support for libpng > 1.2.

  * Add conditional defines for deprecated NULL type casts.
  * Use wrapper functions for accessing png_structp & png_infop fields
    (direct access is deprecated).

Tested on Fedora 17 (libpng 1.5) and Ubuntu 12.04 (libpng 1.2).

Note: there is one png_structp direct field acces left in
SkPNGImageDecoder::onDecodeRegion() for which libpng does not provide a
wrapper method (png_ptr->pass = 0). That should be OK for now as the code
is only enabled when SK_BUILD_FOR_ANDROID is set, and the Android libpng
version is striclty controlled. But it may become an issue in the future
when/if Android decides to update libpng, so we should investigate a
solution.

R=scroggo@google.com, reed@google.com, djsollen@google.com

Author: fmalita@google.com

Review URL: https://chromiumcodereview.appspot.com/14645018

git-svn-id: http://skia.googlecode.com/svn/trunk@8956 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow unit tests to include or exclude test sets.
caryclark@google.com [Thu, 2 May 2013 13:14:40 +0000 (13:14 +0000)]
Allow unit tests to include or exclude test sets.

This modifies the command line to take test
matches of the form:

   --match [or -m] [~][^]match[$] [~][^]match[$] ...

   ~ causes a matching test to always be skipped

   ^ requires the start of the test to match

   $ requires the end of the test to match

   ^ and $ requires an exact match

If a test does not match any list entry,
it is skipped unless some list entry starts with ~
Review URL: https://codereview.chromium.org/14650009

git-svn-id: http://skia.googlecode.com/svn/trunk@8955 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisable AA for ovals and roundrects if MSAA is enabled.
commit-bot@chromium.org [Thu, 2 May 2013 13:11:22 +0000 (13:11 +0000)]
Disable AA for ovals and roundrects if MSAA is enabled.

Also remove GrPaint from a number of methods -- we only
use it to get the AA state.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/14109033

git-svn-id: http://skia.googlecode.com/svn/trunk@8954 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd msaa configs to bench_pictures.
jvanverth@google.com [Thu, 2 May 2013 12:39:37 +0000 (12:39 +0000)]
Add msaa configs to bench_pictures.

Enables msaa4 and msaa16 configs in bench_pictures and render_pictures (and
anything else that may use PictureRenderer).

Review URL: https://codereview.chromium.org/14544007/

git-svn-id: http://skia.googlecode.com/svn/trunk@8952 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate DEPS and GYP to use the copy of Android in platform_tools.
djsollen@google.com [Thu, 2 May 2013 12:27:21 +0000 (12:27 +0000)]
Update DEPS and GYP to use the copy of Android in platform_tools.

R=borenet@google.com

Review URL: https://codereview.chromium.org/13898019

git-svn-id: http://skia.googlecode.com/svn/trunk@8951 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix submit_try for new builder names
borenet@google.com [Thu, 2 May 2013 12:14:35 +0000 (12:14 +0000)]
Fix submit_try for new builder names

(SkipBuildbotRuns)
Unreviewed.

Review URL: https://codereview.chromium.org/14611009

git-svn-id: http://skia.googlecode.com/svn/trunk@8950 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 2 May 2013 07:01:25 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@8948 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHamfistedly removed core dependence on images
robertphillips@google.com [Thu, 2 May 2013 00:12:03 +0000 (00:12 +0000)]
Hamfistedly removed core dependence on images

https://codereview.chromium.org/14805002/

git-svn-id: http://skia.googlecode.com/svn/trunk@8947 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix for SurfaceTest on non-gpu platforms
junov@chromium.org [Wed, 1 May 2013 22:49:59 +0000 (22:49 +0000)]
Build fix for SurfaceTest on non-gpu platforms

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@8946 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding public API method on SkImage for extracting the GPU texture handle.
junov@chromium.org [Wed, 1 May 2013 22:38:16 +0000 (22:38 +0000)]
Adding public API method on SkImage for extracting the GPU texture handle.

TEST=Surface unit test

Review URL: https://codereview.chromium.org/14646007

git-svn-id: http://skia.googlecode.com/svn/trunk@8945 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test commit queue. (SkipBuildbotRuns)
commit-bot@chromium.org [Wed, 1 May 2013 21:50:53 +0000 (21:50 +0000)]
Whitespace change to test commit queue. (SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14772006

git-svn-id: http://skia.googlecode.com/svn/trunk@8944 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix attempt number 2.
scroggo@google.com [Wed, 1 May 2013 21:40:58 +0000 (21:40 +0000)]
Build fix attempt number 2.

Review URL: https://codereview.chromium.org/14646025

git-svn-id: http://skia.googlecode.com/svn/trunk@8943 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix the build.
scroggo@google.com [Wed, 1 May 2013 21:27:16 +0000 (21:27 +0000)]
Fix the build.

Remove an unused function warning.

Review URL: https://codereview.chromium.org/14785008

git-svn-id: http://skia.googlecode.com/svn/trunk@8942 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoForce linking with image decoders for images project.
scroggo@google.com [Wed, 1 May 2013 21:17:27 +0000 (21:17 +0000)]
Force linking with image decoders for images project.

Previously, each tool that wanted to use image decoders
but did not specifically reference them had to create a
dummy function that references them in order to ensure
they are not stripped by the linker.

Instead of making each tool reference each image decoder,
do it once in SkImageDecoder.cpp. Now each tool will have
image decoders linked in, assuming it includes the images
project.

This fixes a bug where SKPs with encoded data could not
be read by bench_ or render_pictures.

R=djsollen@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/14678003

git-svn-id: http://skia.googlecode.com/svn/trunk@8941 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkOpSegment.cpp gcc 4.7 build failure.
fmalita@google.com [Wed, 1 May 2013 20:35:51 +0000 (20:35 +0000)]
SkOpSegment.cpp gcc 4.7 build failure.

SkOpSegment.cpp:2240:5: error: ordered comparison of pointer with integer zero

Caught by gcc 4.7 -Werror=extra.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/14770005

git-svn-id: http://skia.googlecode.com/svn/trunk@8940 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for GL_EXT_multisampled_render_to_texture.
bsalomon@google.com [Wed, 1 May 2013 20:10:01 +0000 (20:10 +0000)]
Add support for GL_EXT_multisampled_render_to_texture.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/14091008

git-svn-id: http://skia.googlecode.com/svn/trunk@8939 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHousekeeper should not fail when skia-autogen is reset.
rmistry@google.com [Wed, 1 May 2013 14:47:03 +0000 (14:47 +0000)]
Housekeeper should not fail when skia-autogen is reset.

Created to fix https://code.google.com/p/skia/issues/detail?id=1269 : UpdateDoxygen and UploadDoxygen steps fail when skia-autogen repository is reset.

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/14772003

git-svn-id: http://skia.googlecode.com/svn/trunk@8935 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd FontMgr to DirectWrite.
bungeman@google.com [Wed, 1 May 2013 14:21:20 +0000 (14:21 +0000)]
Add FontMgr to DirectWrite.
https://codereview.chromium.org/14314008/

git-svn-id: http://skia.googlecode.com/svn/trunk@8934 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
borenet@google.com [Tue, 30 Apr 2013 19:45:48 +0000 (19:45 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@8931 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoResubmit r8929 with the duplicated change in trunk/platform_tools/android
borenet@google.com [Tue, 30 Apr 2013 16:37:30 +0000 (16:37 +0000)]
Resubmit r8929 with the duplicated change in trunk/platform_tools/android

Unreviewed.
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/14652007

git-svn-id: http://skia.googlecode.com/svn/trunk@8930 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds after builder name change
borenet@google.com [Tue, 30 Apr 2013 12:43:07 +0000 (12:43 +0000)]
Whitespace change to trigger rebuilds after builder name change

git-svn-id: http://skia.googlecode.com/svn/trunk@8925 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds after builder name change
borenet@google.com [Tue, 30 Apr 2013 12:10:45 +0000 (12:10 +0000)]
Whitespace change to trigger rebuilds after builder name change

git-svn-id: http://skia.googlecode.com/svn/trunk@8922 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix builder name references
borenet@google.com [Tue, 30 Apr 2013 12:02:32 +0000 (12:02 +0000)]
Fix builder name references

... as a result of https://codereview.chromium.org/14517004/
(SkipBuildbotRuns)

R=bensong@google.com, rmistry@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/14544003

git-svn-id: http://skia.googlecode.com/svn/trunk@8921 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 30 Apr 2013 07:01:03 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8919 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow supporting 1 older PICTURE_VERSION.
scroggo@google.com [Tue, 30 Apr 2013 02:37:56 +0000 (02:37 +0000)]
Allow supporting 1 older PICTURE_VERSION.

Allows https://codereview.chromium.org/14230022/ to be submitted
without breaking bench_pictures and render_pictures.

After DEPS roll and SKP capture, this will be reverted.

Review URL: https://codereview.chromium.org/14158015

git-svn-id: http://skia.googlecode.com/svn/trunk@8918 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes for piping bitmaps with encoded data.
scroggo@google.com [Tue, 30 Apr 2013 02:32:41 +0000 (02:32 +0000)]
Fixes for piping bitmaps with encoded data.

Similar goals as https://codereview.chromium.org/14437012.

Builds on patch set 1 from that issue
(https://codereview.chromium.org/14437012/#ps1).

Instead of the changes in patch set 2 from that issue, this
changes SkOrderedWriteBuffer::writeBitmap to store whether an
SkBitmapHeap was used when to store the index of the SkBitmap.
SkOrderedReadBuffer::readBitmap now uses that information to
distinguish between using the heap and unflattening.

In addition, writeBitmap now records the width/height first in
all cases. If now SkBitmapHeapReader is attached, but an
SkBitmapHeap was used to record the bitmap, reading will fail
and provide the same red SkBitmap as in the case where the
SkBitmap was encoded but could not be decoded.

Updates the PICTURE_VERSION as well.

The key differences in this CL to look at are in:
SkOrderedWriteBuffer,
SkOrderedReadBuffer,
and SkPicture.

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/14230022

git-svn-id: http://skia.googlecode.com/svn/trunk@8917 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd routines to compute error between conic and quad
mike@reedtribe.org [Tue, 30 Apr 2013 02:14:58 +0000 (02:14 +0000)]
add routines to compute error between conic and quad

git-svn-id: http://skia.googlecode.com/svn/trunk@8916 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor optimization
robertphillips@google.com [Mon, 29 Apr 2013 18:07:35 +0000 (18:07 +0000)]
Minor optimization

https://codereview.chromium.org/14495006/

git-svn-id: http://skia.googlecode.com/svn/trunk@8912 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd 90 degree test case to rects GM
robertphillips@google.com [Mon, 29 Apr 2013 17:44:45 +0000 (17:44 +0000)]
add 90 degree test case to rects GM

https://codereview.chromium.org/13844017/

git-svn-id: http://skia.googlecode.com/svn/trunk@8911 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoStop using mix() to implement hard-light in shader.
commit-bot@chromium.org [Mon, 29 Apr 2013 17:40:33 +0000 (17:40 +0000)]
Stop using mix() to implement hard-light in shader.

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14541004

git-svn-id: http://skia.googlecode.com/svn/trunk@8910 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove inout params from saturation helper func in XferEffect.
commit-bot@chromium.org [Mon, 29 Apr 2013 17:36:14 +0000 (17:36 +0000)]
Remove inout params from saturation helper func in XferEffect.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14535004

git-svn-id: http://skia.googlecode.com/svn/trunk@8909 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove guard against checking for copytexsubimage2d ptr in GrGLInterface::validate()
commit-bot@chromium.org [Mon, 29 Apr 2013 16:58:53 +0000 (16:58 +0000)]
Remove guard against checking for copytexsubimage2d ptr in GrGLInterface::validate()

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/13863021

git-svn-id: http://skia.googlecode.com/svn/trunk@8907 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPlumbed in discard_framebuffer extension
robertphillips@google.com [Mon, 29 Apr 2013 16:50:17 +0000 (16:50 +0000)]
Plumbed in discard_framebuffer extension

https://codereview.chromium.org/14461006/

git-svn-id: http://skia.googlecode.com/svn/trunk@8906 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreenable __builtin_clz for GNUC (and clang), recognizing that it is undefined for...
reed@google.com [Mon, 29 Apr 2013 15:34:35 +0000 (15:34 +0000)]
reenable __builtin_clz for GNUC (and clang), recognizing that it is undefined for a zero argument,
so we check for that explicitly.

git-svn-id: http://skia.googlecode.com/svn/trunk@8905 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd wacky random shift so I can generate some zeros (without the optimizer knowing)
reed@google.com [Mon, 29 Apr 2013 15:27:42 +0000 (15:27 +0000)]
add wacky random shift so I can generate some zeros (without the optimizer knowing)
so I can test passing a 0 to SkCLZ()

git-svn-id: http://skia.googlecode.com/svn/trunk@8904 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove redundant setting of alpha in hard-light GPU shader.
commit-bot@chromium.org [Mon, 29 Apr 2013 15:25:03 +0000 (15:25 +0000)]
Remove redundant setting of alpha in hard-light GPU shader.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/14418005

git-svn-id: http://skia.googlecode.com/svn/trunk@8903 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotemp work-around for mysterious failure of shadertext2 when using __builtin_clz
reed@google.com [Mon, 29 Apr 2013 15:10:44 +0000 (15:10 +0000)]
temp work-around for mysterious failure of shadertext2 when using __builtin_clz

git-svn-id: http://skia.googlecode.com/svn/trunk@8900 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreland 8897 (was not a build-breaker) and fix MathTest (was a build-breaker)
reed@google.com [Mon, 29 Apr 2013 14:43:50 +0000 (14:43 +0000)]
reland 8897 (was not a build-breaker) and fix MathTest (was a build-breaker)

git-svn-id: http://skia.googlecode.com/svn/trunk@8899 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 8897 -- broke clang build
reed@google.com [Mon, 29 Apr 2013 14:31:29 +0000 (14:31 +0000)]
revert 8897 -- broke clang build

git-svn-id: http://skia.googlecode.com/svn/trunk@8898 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse intrinsics on more platforms for SkCLZ
reed@google.com [Mon, 29 Apr 2013 14:18:44 +0000 (14:18 +0000)]
use intrinsics on more platforms for SkCLZ

Review URL: https://codereview.chromium.org/14418004

git-svn-id: http://skia.googlecode.com/svn/trunk@8897 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd unittest for SkCLZ
reed@google.com [Mon, 29 Apr 2013 14:18:23 +0000 (14:18 +0000)]
add unittest for SkCLZ

git-svn-id: http://skia.googlecode.com/svn/trunk@8896 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoup the inner-loop for clz bench, to get more stable results
reed@google.com [Mon, 29 Apr 2013 14:11:23 +0000 (14:11 +0000)]
up the inner-loop for clz bench, to get more stable results

git-svn-id: http://skia.googlecode.com/svn/trunk@8895 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for SkCLZ
reed@google.com [Mon, 29 Apr 2013 13:55:11 +0000 (13:55 +0000)]
add bench for SkCLZ

git-svn-id: http://skia.googlecode.com/svn/trunk@8894 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH macro
reed@google.com [Mon, 29 Apr 2013 13:48:34 +0000 (13:48 +0000)]
use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@8893 2bbb7eff-a529-9590-31e7-b0007b416f81