Mathieu Duponchelle [Tue, 6 Aug 2019 13:28:58 +0000 (15:28 +0200)]
funnel: fix documentation
funnel no longer sends its own segment since:
bbb26f875692a6cd84050c545ba85a7d2129cf5d
Update the documentation to reflect that
Tim-Philipp Müller [Mon, 5 Aug 2019 23:05:22 +0000 (00:05 +0100)]
message: fix up enum value for GST_MESSAGE_DEVICE_CHANGED
This was added in 1.16 and accidentally duplicated the value of
the existing GST_MESSAGE_REDIRECT.
As the only known user of this message is GStreamer core itself,
and it is quite an obscure message, it seems best to just fix up
the enum value even if that technically breaks API.
Fixes #418
Keri Henare [Tue, 6 Aug 2019 03:16:35 +0000 (03:16 +0000)]
Removes unnecessary "Sissy" pejorative from configure.ac warning message.
Doug Nazar [Wed, 31 Jul 2019 01:40:47 +0000 (21:40 -0400)]
info: Fix deadlock in gst_ring_buffer_logger_log
gst_ring_buffer_logger_log calls several functions while formatting
the message which may in turn log a message while we already hold
the mutex. Do all formatting first before acquiring the mutex to
avoid this and reduce the time we hold the mutex.
Guillaume Desmottes [Fri, 2 Aug 2019 07:37:58 +0000 (13:07 +0530)]
tracers: set MAY_BE_LEAKED on tracer records
The records are static and so appear as false positives when using those
tracers with the leaks tracer as well.
The leaks tracer was already setting this flag on its record so let's
set it on the other ones as well.
Alicia Boya García [Mon, 22 Jul 2019 15:06:20 +0000 (15:06 +0000)]
downloadbuffer: Check for flush after seek
In gst_download_buffer_wait_for_data(), when a seek is made with
perform_seek_to_offset() the `qlock` is released temporarily. Therefore,
the flushing condition can be set during this period and should be
checked.
This was not being checked before, causing occasional deadlocks when
GST_DOWNLOAD_BUFFER_WAIT_ADD_CHECK() was called.
GST_DOWNLOAD_BUFFER_WAIT_ADD_CHECK() assumes that the caller has already
checked that we're not flushing before, since this is done when
acquiring the lock; so if we release it temporarily somewhere, we need
to check for flush again.
Without that check, the function would keep waiting for the condition
variable to be notified before checking for flushing condition again,
and that may very well never happen. This was reproduced when during pad
deactivation when running WebKit in gdb.
Nicolas Dufresne [Sat, 20 Jul 2019 01:57:09 +0000 (21:57 -0400)]
identity: Non-live upstream have no max latency
sync=TRUE implementation changes the latency query of a non-live
upstream into live, though it wrongly set the upstream max latency to 0.
As non-live sources won't loose data if we wait longer, this should have
been reported as have no max latency limite (-1).
Mathieu Duponchelle [Fri, 19 Jul 2019 15:28:25 +0000 (17:28 +0200)]
aggregator: drop duplicated SEEK events
This is similar to what demuxers do, and necessary when multiple
sinks get seeked downstream of the aggregator: if we forward
duplicated seeks upstream, elements such as demuxers may drop
the flushing seeks, but return TRUE, aggregator then waits forever
for the flushing events.
Fixes #276
Tim-Philipp Müller [Fri, 19 Jul 2019 10:09:22 +0000 (11:09 +0100)]
basesrc: fix g-i warnings
Sebastian Dröge [Sun, 14 Jul 2019 19:41:56 +0000 (22:41 +0300)]
info: Free some more memory on gst_deinit()
Sebastian Dröge [Sun, 14 Jul 2019 18:36:00 +0000 (21:36 +0300)]
info: Deprecate gst_debug_category_free()
And change it to do nothing at all.
As debug categories don't use reference counting and they can be
retrieved from anywhere at any time by name, it is fundamentally unsafe
to free them at any point in time except for right before the end of the
process.
No code apart from a unit test seems to be currently using the function,
so deprecate it and also change it to do nothing at all.
Philippe Normand [Thu, 11 Jul 2019 16:53:53 +0000 (17:53 +0100)]
identity: Fix the ts-offset property getter
Previous code was a copy/paste from the property setter function.
Sebastian Dröge [Mon, 8 Jul 2019 16:09:03 +0000 (19:09 +0300)]
aggregator: Make parsing of explicit sink pad names more robust
When passing "sink_%d" twice to aggregator before it would create two
pads called "sink_0", because it failed to parse "%d" as integer and
used 0 instead then.
Instead validate that parsing was actually successful and also don't
even try to parse if the requested pad name contains a '%'.
Guillaume Desmottes [Mon, 8 Jul 2019 11:16:08 +0000 (13:16 +0200)]
gst-stats: fix leaks
String returned from g_match_info_fetch() needs to be freed.
Guillaume Desmottes [Mon, 8 Jul 2019 09:20:26 +0000 (11:20 +0200)]
gst-stats: sort latency by first activity before displaying
We use to display the latency of each element in random order which is
not very convenient when comparing latency between different runs.
Sort them by "first activity" (the first latency reported for each
element) so it's consistent betwen runs.
This is the same logic when sorting and displaying element stats.
Jan Schmidt [Sun, 7 Jul 2019 10:42:56 +0000 (20:42 +1000)]
gsttracerutils: Fix build with disabled tracer hooks.
Add a stub gst_tracing_get_active_tracers() call when building
with tracer hooks disabled.
Thibault Saunier [Tue, 2 Jul 2019 21:14:50 +0000 (17:14 -0400)]
multiqueue: Fix possible NULL pointer dereferencing
In the hotdoc inspector for example, pads are instantiated with
g_object_new, other code paths to get/set properties already make
that check.
And update doc cache
Nirbheek Chauhan [Mon, 1 Jul 2019 18:24:19 +0000 (23:54 +0530)]
gstinfo: Fix typo in debug log message
Tim-Philipp Müller [Mon, 1 Jul 2019 14:50:13 +0000 (20:20 +0530)]
leakstracer: Improve notes in the the get-live-objects API docs
It may not be obvious to the user how this action signal is meant to
be called, so document it.
Nirbheek Chauhan [Mon, 1 Jul 2019 09:35:58 +0000 (15:05 +0530)]
tests: Add test for new activity-tracking leaktracer API
Nirbheek Chauhan [Fri, 21 Jun 2019 12:47:13 +0000 (18:17 +0530)]
leakstracer: Add API for tracking and checkpointing objects
This feature was previously available only through the SIGUSR2 signal,
which meant it wasn't available on platforms that don't have UNIX
signals, such as Windows and with applications that already use
SIGUSR1 for something else.
Now we have action-signals for doing the same. These action signals
can also be used for fetching the checkpoint information
programmatically instead of printing to the debug log.
Nirbheek Chauhan [Mon, 1 Jul 2019 09:35:08 +0000 (15:05 +0530)]
tests: Add test for new live-objects leaktracer API
Needs a valgrind suppression for:
==11119== Warning: invalid file descriptor -1 in syscall close()
==11119== Warning: invalid file descriptor -1 in syscall close()
==11119== Syscall param write(buf) points to uninitialised byte(s)
==11119== at 0x4C4AFAD: syscall (in /usr/lib64/libc-2.29.so)
==11119== by 0x4E70DF9: write_validate (Ginit.c:112)
==11119== by 0x4E70DF9: UnknownInlinedFun (Ginit.c:148)
==11119== by 0x4E70DF9: mincore_validate (Ginit.c:131)
==11119== by 0x4E70CC3: UnknownInlinedFun (Ginit.c:208)
==11119== by 0x4E70CC3: access_mem (Ginit.c:242)
==11119== by 0x4E75536: UnknownInlinedFun (libunwind_i.h:168)
==11119== by 0x4E75536: apply_reg_state (Gparser.c:863)
==11119== by 0x4E75A71: _ULx86_64_dwarf_step (Gparser.c:952)
==11119== by 0x4E71BD3: _ULx86_64_step (Gstep.c:71)
==11119== by 0x48BAF47: generate_unwind_trace (gstinfo.c:2726)
==11119== by 0x48BC92E: gst_debug_get_stack_trace (gstinfo.c:2908)
==11119== by 0x49B2BB2: handle_object_created.part.0 (gstleaks.c:384)
==11119== by 0x488134E: gst_object_constructed (gstobject.c:141)
==11119== by 0x49EC61B: g_object_new_internal (gobject.c:1845)
==11119== by 0x49EE347: g_object_new_valist (gobject.c:2128)
==11119== by 0x49EE69C: g_object_new (gobject.c:1648)
==11119== by 0x48CA59D: gst_pad_new_from_template (gstpad.c:867)
==11119== by 0x68C209E: gst_base_src_init (gstbasesrc.c:454)
==11119== by 0x4A0A0C3: g_type_create_instance (gtype.c:1858)
==11119== by 0x49EC42C: g_object_new_internal (gobject.c:1805)
==11119== by 0x49EDB14: g_object_new_with_properties (gobject.c:1973)
==11119== by 0x49EE6C0: g_object_new (gobject.c:1645)
==11119== by 0x48AF91A: gst_element_factory_create (gstelementfactory.c:372)
==11119== Address 0x1ffeffe000 is on thread 1's stack
==11119== in frame #6, created by generate_unwind_trace (gstinfo.c:2695)
Fixed in libunwind commit:
https://github.com/libunwind/libunwind/commit/
b256722d49a63719c69c0416eba9163a4d069584
Needs a separate suppression for Debian because the callstack is
different there.
Nirbheek Chauhan [Fri, 28 Jun 2019 12:49:31 +0000 (18:19 +0530)]
leakstracer: Add API for logging leaks in the debug log
This is the equivalent of sending SIGUSR1 to the application, and is
useful on platforms where UNIX signals are not available, such as
Windows.
Nirbheek Chauhan [Fri, 28 Jun 2019 12:49:31 +0000 (18:19 +0530)]
leakstracer: Add API for fetching leaked objects
This allows programs to inspect the leaked objects directly, log them,
and so on. Unlike the existing mechanism to use SIGUSR1, this also
works on platforms that do not support UNIX signals, such as Windows
and with applications that already use SIGUSR1 for something else.
Nirbheek Chauhan [Tue, 18 Jun 2019 22:52:42 +0000 (04:22 +0530)]
gsttracer: Add new API to fetch the list of active tracers
This will be useful in the next commit where we add action-signals on
the leaks tracer to get information about leaks and to manipulate
checkpoints as a replacement for the SIGUSR1 and SIGUSR2 signals for
doing the same.
Nirbheek Chauhan [Tue, 18 Jun 2019 22:17:18 +0000 (03:47 +0530)]
tracers: Allow setting a name for all tracer objects
This will be useful in combination with the next commit when we add
API to get a list of active tracers so that consumers of the API can
easily distinguish tracer objects.
Nicolas Dufresne [Sat, 29 Jun 2019 13:22:05 +0000 (09:22 -0400)]
bufferpool: Fix the buffer size reset code
The offset in gst_buffer_resize() is additive. So to move back the
offset to zero, we need to pass the opposite of the current offset. This
was raised through the related unit test failingon 32bit as on 64bit
the alignment padding was enough to hide the issue. The test was
modified to also fail on 64bit. This patch will remove spurious
assertions like:
assertion 'bufmax >= bufoffs + offset + size' failed
Fixes #316
Nirbheek Chauhan [Mon, 24 Jun 2019 15:44:51 +0000 (21:14 +0530)]
leakstracer: Get rid of GSlice usage
It's not faster than malloc, and is slower in most cases. Glib is also
getting rid of it entirely: https://gitlab.gnome.org/GNOME/glib/merge_requests/940
Nirbheek Chauhan [Fri, 21 Jun 2019 05:56:38 +0000 (11:26 +0530)]
leakstracer: Remove unused and redundant record fields
All leak records are obviously scoped to the process, and nothing in
the GstTracerRecord code uses these fields anyway.
Nirbheek Chauhan [Fri, 21 Jun 2019 05:13:18 +0000 (10:43 +0530)]
tracerrecord: Be stricter while parsing record templates
It's not really possible for us to recover when someone uses the
gst_tracer_record_new() API incorrectly. Also, document a piece of
somewhat-obscure code.
Nirbheek Chauhan [Tue, 18 Jun 2019 22:12:46 +0000 (03:42 +0530)]
leakstracer: Improve documentation for the element
Also print a useful g_warning() message when leaks are detected.
Nirbheek Chauhan [Mon, 1 Jul 2019 09:25:20 +0000 (14:55 +0530)]
gstcheck: Document strcmp used in string cmp macros
strcmp() does not allow the arguments to be NULL, but g_strcmp0()
does, so document that we use g_strcmp0() so that people don't need to
worry about that.
Nirbheek Chauhan [Fri, 21 Jun 2019 05:11:18 +0000 (10:41 +0530)]
gstsystemclock: Mark the clock as MAY_BE_LEAKED
It is freed in gst_deinit(), but otherwise it is leaked.
Nirbheek Chauhan [Tue, 18 Jun 2019 22:09:59 +0000 (03:39 +0530)]
gstinfo: Rework stack trace detection a bit
Ensure that the code paths for HAVE_UNWIND and HAVE_DBGHELP are never
taken at the same time, even if the build file code changes.
Prefer DbgHelp over libunwind on Windows in case both are somehow
available because DbgHelp is only available when building with the
MSVC toolchain, and libunwind won't give us debug symbols from objects
built with the MSVC toolchain.
Also, print slightly more useful messages for the level of stack trace
support enabled, and document what each if conditional does.
Nirbheek Chauhan [Tue, 18 Jun 2019 21:49:16 +0000 (03:19 +0530)]
gstinfo: Add an explicit enum for GST_STACK_TRACE_SHOW_NONE
The code implicitly uses this value when the stack trace is not FULL.
Mostly useful for documenting the behaviour when each flag is passed
and for translating to/from strings.
Carlos Rafael Giani [Mon, 24 Jun 2019 12:35:16 +0000 (14:35 +0200)]
basesrc: Add public gst_base_src_negotiate () function
This is useful for when format changes occur mid-stream.
Thibault Saunier [Thu, 27 Jun 2019 19:51:47 +0000 (15:51 -0400)]
multiqueue: Hold weak references to pads/multiqueue in SingleQueue
Without holding a ref we have no guarantees that the SingleQueue
doesn't have dangling pointers on those objects during its destruction.
Nirbheek Chauhan [Mon, 6 May 2019 13:49:47 +0000 (19:19 +0530)]
gstplugin: Don't stat plugins when building for UWP
When using GStreamer with Universal Windows Platform apps, dynamic
plugins can only be loaded by filename (without a path) using
gst_plugin_load_file() which will call into g_module_open().
On Windows, GModule calls LoadLibrary() on the filename, but with
UWP we need to use LoadPackagedLibrary() which is basically the same
as LoadLibrary(), except it looks only for DLLs (by name) that have
been packaged as assets with the app.
These assets are not files and cannot be accessed using normal file
APIs such as open() or stat().
The upstream glib merge request for adding LoadPackagedLibrary support
is: https://gitlab.gnome.org/GNOME/glib/merge_requests/951
NOTE: Whitespcae removal is to make gst-indent happy
Nirbheek Chauhan [Wed, 15 May 2019 23:27:16 +0000 (04:57 +0530)]
gstconfig.h.in: Windows ARM64 does not allow unaligned access
Nicolas Dufresne [Wed, 19 Jun 2019 21:39:58 +0000 (17:39 -0400)]
testclock: Allow calling crank with a past entry
At the moment, we can only use crank if the pending entry is in the
future. This patch leaves the clock time to the same point if the
pending entry was in the past. This still execute a single entry. This
will be needed for the jitterbuffer, since as soon as we stop waking up
the jitterbuffer when the timer is reschedule later, we may endup with
such case in the unit tests.
Related to #608
Thibault Saunier [Sun, 23 Jun 2019 03:46:35 +0000 (23:46 -0400)]
multiqueue: Stop using the gst_pad_element_private API
There was a race where we could still get the pad event function
called when its private member were already unset, leading to
a segfault in the event handler:
```
0 gst_multi_queue_src_event (pad=<optimized out>, parent=<optimized out>, event=0x7f3ff0007600) at ../subprojects/gstreamer/plugins/elements/gstmultiqueue.c:2534
2534 ret = gst_pad_push_event (sq->sinkpad, event);
[Current thread is 1 (Thread 0x7f406c0258c0 (LWP 21925))]
(gdb) bt
0 0x00007f4062ec1399 in gst_multi_queue_src_event (pad=<optimized out>, parent=<optimized out>, event=0x7f3ff0007600 [GstEvent]) at ../subprojects/gstreamer/plugins/elements/gstmultiqueue.c:2534
1 0x00007f406b40f46d in gst_validate_pad_monitor_src_event_check (handler=0x7f4062ec1360 <gst_multi_queue_src_event>, event=0x7f3ff0007600 [GstEvent], parent=0x7f3fcc01f090 [GstMultiQueue|multiqueue167], pad_monitor=0x7f3fe809e7c0 [GstValidatePadMonitor|validatepadmonitor2213]) at ../subprojects/gst-devtools/validate/gst/validate/gst-validate-pad-monitor.c:2101
2 0x00007f406b40f46d in gst_validate_pad_monitor_src_event_func (pad=<optimized out>, parent=0x7f3fcc01f090 [GstMultiQueue|multiqueue167], event=0x7f3ff0007600 [GstEvent]) at ../subprojects/gst-devtools/validate/gst/validate/gst-validate-pad-monitor.c:2374
3 0x00007f406b904387 in gst_pad_send_event_unchecked (pad=pad@entry=0x7f3fdc027650 [GstPad|src_0], event=event@entry=0x7f3ff0007600 [GstEvent], type=<optimized out>, type@entry=GST_PAD_PROBE_TYPE_EVENT_UPSTREAM) at ../subprojects/gstreamer/gst/gstpad.c:5772
4 0x00007f406b90481b in gst_pad_push_event_unchecked (pad=pad@entry=0x7f4058182fc0 [GstPad|sink], event=event@entry=0x7f3ff0007600 [GstEvent], type=type@entry=GST_PAD_PROBE_TYPE_EVENT_UPSTREAM) at ../subprojects/gstreamer/gst/gstpad.c:5417
5 0x00007f406b90f016 in gst_pad_push_event (pad=0x7f4058182fc0 [GstPad|sink], event=event@entry=0x7f3ff0007600 [GstEvent]) at ../subprojects/gstreamer/gst/gstpad.c:5554
6 0x00007f406a1c99ba in gst_video_decoder_src_event_default (decoder=0x7f3fe81c6060 [GstTheoraDec|theoradec46], event=<optimized out>) at ../subprojects/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.c:1532
7 0x00007f406b40f46d in gst_validate_pad_monitor_src_event_check (handler=0x7f406a1ca270 <gst_video_decoder_src_event>, event=0x7f3ff0007600 [GstEvent], parent=0x7f3fe81c6060 [GstTheoraDec|theoradec46], pad_monitor=0x7f4028163aa0 [GstValidatePadMonitor|validatepadmonitor2216]) at ../subprojects/gst-devtools/validate/gst/validate/gst-validate-pad-monitor.c:2101
8 0x00007f406b40f46d in gst_validate_pad_monitor_src_event_func (pad=<optimized out>, parent=0x7f3fe81c6060 [GstTheoraDec|theoradec46], event=0x7f3ff0007600 [GstEvent]) at ../subprojects/gst-devtools/validate/gst/validate/gst-validate-pad-monitor.c:2374
```
This make the GstSingleQueue a MiniObject, mainly so it is properly
refcounted.
This also make use of the GstMultiQueuePad class for srcpads which
is totally valid as srcpads and sinkpads share the same SingleQueue
object.
Mathieu Duponchelle [Fri, 21 Jun 2019 13:38:15 +0000 (15:38 +0200)]
devicemonitor: add debug category
Michael Bunk [Thu, 20 Jun 2019 12:04:55 +0000 (14:04 +0200)]
Fixing various typos
Guillaume Desmottes [Thu, 20 Jun 2019 11:12:01 +0000 (16:42 +0530)]
latency: display event pointer in logs
This is quite useful for debugging when tracer is reporting the wrong
latency because of an element breaking the events/buffers ordering.
Guillaume Desmottes [Thu, 20 Jun 2019 08:19:14 +0000 (13:49 +0530)]
gstelements_private: sync gst_buffer_get_flags_string() with new flags
Thibault Saunier [Thu, 20 Jun 2019 03:29:24 +0000 (23:29 -0400)]
multiqueue: never unref queries we do not own
The `query` argument of gst_pad_query is "transfer none".
Query objects are "borrowed" by the pad query handlers and those
should never unref them.
This was leading to double freed queries in a very racy way with nested
GESTimelines.
Havard Graff [Mon, 17 Jun 2019 07:50:32 +0000 (09:50 +0200)]
gstmeta: Optimize get_tags() by using private quark table
Havard Graff [Thu, 13 Jun 2019 08:32:32 +0000 (10:32 +0200)]
pad: increase debug-level to warning for fatal outcomes
Håvard Graff [Thu, 13 Jun 2019 15:21:03 +0000 (15:21 +0000)]
queue: don't report 0 max-latency for leaky queue if max was already 0.
Havard Graff [Wed, 22 May 2019 08:09:47 +0000 (10:09 +0200)]
harness: move creating of buffer and event queues to harness itself
By only having it on sinkpad-creation, it is racy to write a test
with a sometimes-pad (like a demuxer) that you want to pull from, having
the pull wait until the pad arrives and the buffer can be produced.
Stian Selnes [Wed, 3 Oct 2018 11:56:22 +0000 (13:56 +0200)]
harness: Fix race when forwarding event while tearing down harness
Stian Selnes [Mon, 28 May 2018 08:57:13 +0000 (10:57 +0200)]
harness: Make sure pad functions are not called after teardown
For the query function there's a risk that the function may be called
after the harness has been teared down. Since the function accesses a
pointer to the harness via the pad's data, the harness must protect
itself against this.
Event and chain function is also handled for constistency, although
they don't have the same problem since the gstpad.c checks whether the
pad is flushing before calling these.
Mathieu Duponchelle [Tue, 11 Jun 2019 20:09:33 +0000 (22:09 +0200)]
aggregator: don't try to take STREAM_LOCK on sink pad flush
This was a misguided effort to try and guarantee the buffers of
the sink pads would not change during aggregate, when an upstream
branch is seeked independently, however this is simply incorrect
as downstream has not necessarily been flushed, or the aggregate
function might be waiting to receive buffers on other pads.
Mathieu Duponchelle [Tue, 11 Jun 2019 13:20:18 +0000 (15:20 +0200)]
aggregator: send flush_stop ourselves if needed
In !159 , we switched to sending flush_start ourselves from the
do_seek implementation. If no flushing seek successfully made its
way upstream, we need to send flush_stop ourselves as well.
Mathieu Duponchelle [Mon, 10 Jun 2019 15:23:29 +0000 (17:23 +0200)]
aggregator: don't hold stream lock when flushing
Releasing a GRecMutex from a different thread is undefined
behaviour.
There should be no reason to hold the stream lock from the
moment aggregator receives a flush_start until it receives
the last flush_stop: the source pad task is stopped, and can
only be restarted once the last flush_stop has arrived.
I can only speculate as to the reason why this was done,
as it was that way since the original commit. My best
guess is that aggregator originally didn't marshall events
and queries to the aggregate thread, and this somehow
helped work around this.
Mathieu Duponchelle [Wed, 22 May 2019 19:37:43 +0000 (21:37 +0200)]
aggregator: refactor flushing logic
Instead of tracking "pending_flush_*" on the pads and the
aggregator, we now simply track the last seqnum for flush start
and flush stop events on the pads, and use it to determine whether
we should enter or exit our flushing state.
See https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/977
Mathieu Duponchelle [Wed, 5 Jun 2019 16:40:12 +0000 (18:40 +0200)]
valgrind: revert generic suppression of ld-related errors
the replacement suppression casts way too large a net, ignoring
all leaks in the main thread
Mathieu Duponchelle [Wed, 5 Jun 2019 18:58:45 +0000 (20:58 +0200)]
valgrind: ignore dlopen leaks when parsing launch lines
Mathieu Duponchelle [Wed, 5 Jun 2019 18:58:45 +0000 (20:58 +0200)]
valgrind: suppress intentional debug list item leak
Sebastian Dröge [Tue, 4 Jun 2019 14:56:30 +0000 (17:56 +0300)]
concat: Improve debug output a bit
Sebastian Dröge [Tue, 4 Jun 2019 14:55:30 +0000 (17:55 +0300)]
concat: Reset last_stop on FLUSH_STOP too
Otherwise when seeking backwards we would keep the last_stop at the last
position we saw until playback passed the seek position again, and if
switching to the next pad happens in the meantime we would set the wrong
offset in the outgoing segment.
Niels De Graef [Tue, 4 Jun 2019 06:50:59 +0000 (08:50 +0200)]
Use G_DEFINE_AUTOPTR_CLEANUP_FUNC unconditionally
Since we started depending on GLib 2.44, we can be sure this macro is
defined (it will be a no-op on compilers that don't support it). For
plugins we should just start using `G_DECLARE_FINAL_TYPE` which means
we no longer need the macro there, but for most types in core we don't
want to break ABI, which means it's better to just keep it like it is
(and use the `#ifdef` instead).
Niels De Graef [Fri, 31 May 2019 20:56:09 +0000 (22:56 +0200)]
meson: Bump minimal GLib version to 2.44
This means we can use some newer features and get rid of some
boilerplate code using the `G_DECLARE_*` macros.
As discussed on IRC, 2.44 is old enough by now to start depending on it.
Mathieu Duponchelle [Sat, 1 Jun 2019 00:37:26 +0000 (02:37 +0200)]
docs: unprefix subproject paths
Thibault Saunier [Fri, 31 May 2019 03:23:35 +0000 (23:23 -0400)]
docs: Add tracers support
Mathieu Duponchelle [Thu, 30 May 2019 23:56:08 +0000 (01:56 +0200)]
gstelement: fix links to the gsterror page
Mathieu Duponchelle [Thu, 30 May 2019 23:45:41 +0000 (01:45 +0200)]
gsttaglist: do not link to symbols from gst-plugins-base in doc
Mathieu Duponchelle [Wed, 29 May 2019 19:33:42 +0000 (21:33 +0200)]
doc: remove xml from comments
Thibault Saunier [Wed, 22 May 2019 22:56:34 +0000 (18:56 -0400)]
docs: Document pad types
And update the plugins doc cache
Thibault Saunier [Wed, 22 May 2019 13:47:41 +0000 (09:47 -0400)]
aggregator: Minor documentation fix
Tim-Philipp Müller [Wed, 29 Jul 2015 10:48:33 +0000 (11:48 +0100)]
aggregator: fix flow-return boolean return type mismatch
Not that it matters, since we don't check the return value
anyway. Unclear why the aggregator pad flush function should
have a return value at all really, and perhaps it should be
called reset anyway. Spotted by dv on irc.
Michael Olbrich [Sun, 12 May 2019 05:45:31 +0000 (07:45 +0200)]
gdb: add gst_element_pad() function
Another helper to navigate a pipeline. It makes it possible to easily
access the pads of an element:
(gdb) print $gst_element_pad(basesink, "sink")
$1 = 0x7fffe80770f0 [GstPad|sink]
Michael Olbrich [Sat, 11 May 2019 19:08:50 +0000 (21:08 +0200)]
gdb: print more data for segment events
This add the different timestamps for segment events:
(gdb) gst-print pad
SrcPad(src, push) {
events:
[...]
segment: time
rate: 1.1
start: 0:03:08.
449753330
time: 0:03:08.
449753330
position: 0:03:08.
449753330
duration: 0:12:14.
166687500
[...]
}
Michael Olbrich [Sat, 11 May 2019 19:02:37 +0000 (21:02 +0200)]
gdb: add 'gst-pipeline-tree' command
It shows a simple tree of all elements in pipeline.
As with gst-dot, the toplevel bin is found from any element of the
pipeline:
(gdb) gst-pipeline-tree bsink
playbin
inputselector1
inputselector0
uridecodebin0
queue2-0
decodebin0
avdec_aac0
aacparse0
vaapidecodebin0
vaapipostproc0
capsfilter1
vaapi-queue
vaapidecode0
capsfilter0
h264parse0
multiqueue0
matroskademux0
typefind
typefindelement0
source
playsink
abin
aconv
resample
conv
identity
aqueue
pulsesink0
vbin
vconv
scale
conv
identity
vqueue
vaapisink0
vdbin
deinterlace
vdconv
audiotee
streamsynchronizer0
Michael Olbrich [Sat, 11 May 2019 18:59:04 +0000 (20:59 +0200)]
gdb: add gst_pipeline() and gst_bin_get() functions
This simplifies navigating in a GStreamer pipeline, e.g.
(gdb) print $gst_bin_get($gst_pipeline(pad), "matroskademux0")
$1 = 0x7fffe81b4050 [GstMatroskaDemux|matroskademux0]
Michael Olbrich [Sat, 11 May 2019 18:55:36 +0000 (20:55 +0200)]
gdb: handle ghost and proxy pads while looking for the top-level element
The parent object for pads is not always a GstElement. Handle GstProxyPad
parents as well.
Michael Olbrich [Sat, 11 May 2019 18:53:54 +0000 (20:53 +0200)]
gdb: refactor finding top-level pipeline
No functional changes. Just refactoring to make it possible to reuse this
later.
Michael Olbrich [Sat, 11 May 2019 18:53:05 +0000 (20:53 +0200)]
gdb: gst-print add more pad and element information
For elements, this adds all child elements, the state and base/start time:
(gdb) gst-print pipeline
0x5555556ebd20 "pipeline0"
GstPipeline(pipeline0) {
children:
fakesink0
queue0
videotestsrc0
state: PLAYING
base_time: +2:54:36.
892581150
start_time: 0:00:00.
000000000
}
For pads, this adds the peer pads and the current task state and the
offset (if not zero):
(gdb) gst-print pad
SrcGhostPad(src, push) {
events:
[...]
peer: vaapisink0:sink
inner peer: scale:src
}
(gdb) gst-print pad
SrcPad(src, push) {
events:
[...]
peer: queue0:sink
task: STARTED
offset:
30000000 [+0:00:00.
030000000]
}
Michael Olbrich [Sat, 11 May 2019 18:39:00 +0000 (20:39 +0200)]
gdb: refactor time formating
Make it reuseable independent of the GstClockTimePrinter.
Sebastian Dröge [Wed, 22 May 2019 07:44:50 +0000 (10:44 +0300)]
dataurisrc: Add test that checks various URIs against their expected output
Benjamin Otte [Tue, 21 May 2019 15:22:04 +0000 (17:22 +0200)]
dataurisrc: Fix crash when semicolon is aprt of data
This URI is valid:
data:,;base64
(It encodes the literal string ";base64")
But would lead to a crash because the code assumed the semicolon would
be placed before the colon.
Benjamin Otte [Tue, 21 May 2019 15:15:52 +0000 (17:15 +0200)]
dataurisrc: Allow case-insensitive scheme
Quoting RFC 2396:
For resiliency, programs interpreting URI should treat upper case
letters as equivalent to lower case in scheme names (e.g., allow
"HTTP" as well as "http").
Matthew Waters [Thu, 16 May 2019 06:17:35 +0000 (16:17 +1000)]
docs: add coretracers to the list of plugins
Thibault Saunier [Thu, 16 May 2019 13:11:00 +0000 (09:11 -0400)]
docs: Stop building the doc cache by default
Fixes https://gitlab.freedesktop.org/gstreamer/gst-docs/issues/36
Thibault Saunier [Thu, 16 May 2019 02:46:45 +0000 (22:46 -0400)]
docs: Update diplayed plugins filename something stable
Thibault Saunier [Thu, 16 May 2019 01:15:35 +0000 (21:15 -0400)]
hotdoc: Let the the registry inspect in forks
So that the whole process doesn't segfault if something bad happens while inspecting
Thibault Saunier [Wed, 15 May 2019 13:23:06 +0000 (09:23 -0400)]
docs: Use the MESON_BUILD_ROOT env variable in the plugins cache generator
Thibault Saunier [Tue, 14 May 2019 19:27:05 +0000 (15:27 -0400)]
docs: Do not pass the json through stdout
Unicode encoding breaks on windows when doing so
Thibault Saunier [Tue, 14 May 2019 17:44:43 +0000 (13:44 -0400)]
registry: Avoid discovering plugins in hotdoc private directories
Thibault Saunier [Tue, 14 May 2019 17:44:24 +0000 (13:44 -0400)]
docs: Do not inspect internal files
Seungha Yang [Tue, 14 May 2019 11:27:47 +0000 (20:27 +0900)]
docs: Always follow Unix style newline
The 'open()' follows default behavior of OS (CRLF in case of Windows).
So it results in a bunch of git diff on Windows.
Sebastian Dröge [Thu, 16 May 2019 12:15:27 +0000 (15:15 +0300)]
basesink: Remove leading space from Since maker of gst_base_sink_get_stats()
gobject-introspection does not like this.
Sebastian Dröge [Thu, 16 May 2019 12:13:23 +0000 (15:13 +0300)]
basesink: Fix syntax for gtk-doc comment of the new stats property
Edward Hervey [Mon, 13 May 2019 14:42:04 +0000 (16:42 +0200)]
gstpad: Probes that return HANDLED can reset the data info field
Before GST_PAD_PROBE_HANDLED was introduced, we had to handle the case
where some probes would reset the probe info data field to NULL. This would
be considered an invalid use-case.
But with GST_PAD_PROBE_HANDLED it is totally fine to reset that, since
the probe has "handled" it.
Sebastian Dröge [Mon, 6 May 2019 19:17:50 +0000 (22:17 +0300)]
filesink: Implement workaround for some (network) filesystems that spuriously return EACCES on write
This seems to happen when another client is accessing the file at the
same time, and retrying after a short amount of time solves it.
Sometimes partial data is written at that point already but we have no
idea how much it is, or if what was written is correct (it sometimes
isn't) so we always first seek back to the current position and repeat
the whole failed write.
It happens at least on Linux and macOS on SMB/CIFS and NFS file systems.
Between write attempts that failed with EACCES we wait 10ms, and after
enough consecutive tries that failed with EACCES we simply time out.
In theory a valid EACCES for files to which we simply have no access
should've happened already during the call to open(), except for NFS
(see open(2)).
This can be enabled with the new max-transient-error-timeout property, and
a new o-sync boolean property was added to open the file in O_SYNC mode
as without that it's not guaranteed that we get EACCES for the actual
writev() call that failed but might only get it at a later time.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/305
Aaron Boxer [Tue, 14 May 2019 19:44:07 +0000 (15:44 -0400)]
gstreamer.pc.in: exec_prefix must be defined before libexecdir
Thibault Saunier [Tue, 14 May 2019 02:47:38 +0000 (22:47 -0400)]
docs: Update plugins cache
Thibault Saunier [Tue, 14 May 2019 02:47:05 +0000 (22:47 -0400)]
docs: Fix cache invalidation status
The dictionnary is updated in place so we were checking the same twice
Thibault Saunier [Sun, 11 Nov 2018 23:11:47 +0000 (20:11 -0300)]
docs: Use the new GstPluginsPath.json to have the right plugin path
When inspecting plugins to generate the json cache file. Otherwise
when we are not in the uninstalled env and using `gst-build` plugins
with dependency might fail/throw warning, etc..
Thibault Saunier [Sun, 28 Oct 2018 12:05:41 +0000 (12:05 +0000)]
pkgconfig: Add information about libexecdir
https://bugzilla.gnome.org/show_bug.cgi?id=797349