Sungtaek Hong [Thu, 8 Dec 2016 04:26:55 +0000 (13:26 +0900)]
efreet_desktop: fix potential error in efreet_desktop_cache_create
Summary:
- old_file_ids is freed but not set as NULL.
If it goes to error code, old_file_ids will be freed again.
Reviewers: jpeg, cedric, Hermet
Reviewed By: Hermet
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4467
Carsten Haitzler (Rasterman) [Thu, 8 Dec 2016 01:19:23 +0000 (10:19 +0900)]
evas fb engine - fix build break cedric added...
Cedric BAIL [Wed, 7 Dec 2016 23:44:43 +0000 (15:44 -0800)]
evas: do not rely on Evas canvas no longer passed during setup.
Cedric BAIL [Fri, 2 Dec 2016 23:30:02 +0000 (15:30 -0800)]
evas: refactor setup stage and reduce complexity for engine.
Derek Foreman [Wed, 7 Dec 2016 22:41:34 +0000 (16:41 -0600)]
gl_drm: Only use dmabuf if the extension is present
Need to check for the extension string instead of just the presence of the
function pointers.
Derek Foreman [Wed, 7 Dec 2016 22:39:17 +0000 (16:39 -0600)]
gl_drm: Query eglGetProcAddress with dlsym
eglGetProcAddress should be queried with dlsym unconditionally. What we
had could query it with other extended forms of eglGetProcAddress, which
is probably not what anyone wants.
Also, throwing away the weird extended forms because there's a good chance
our other gl bits don't run on any stacks that don't support normal
eglGetProcAddress.
Derek Foreman [Wed, 7 Dec 2016 21:53:08 +0000 (15:53 -0600)]
gl_drm: simplify outbuf_reconfigure
Calling render_engine_software_generic_update from eng_setup lets us
remove a bunch of stuff from evas_outbuf_reconfigure.
Cedric BAIL [Wed, 7 Dec 2016 19:17:01 +0000 (11:17 -0800)]
evas: wait on one specific task to be done.
This prevent dead lock.
Derek Foreman [Wed, 7 Dec 2016 17:29:39 +0000 (11:29 -0600)]
gl_drm: Don't destroy the outbuf in reconfigure
Cedric tells me this is bad, and I never argue with Cedric.
We now re-use the same outbuf and just reconfigure the gbm/gl stuff.
Derek Foreman [Wed, 7 Dec 2016 17:28:33 +0000 (11:28 -0600)]
ecore_drm2: Make ecore_drm2_fb_release return status
We need to use this to free up gbm buffers on a surface release, so it
has to report when it successfully frees a buffer.
Stefan Schmidt [Wed, 7 Dec 2016 16:49:10 +0000 (17:49 +0100)]
build: coverage: work around lcov 1.12 bug by using absolute paths for info files
In case a warning gets printed from lcov some internal function changes the dir
to / and thus fails to create files in the given file later on. Using an
absolute path here is a workaround to avoid this problem. The fix is in lcoc
already but not yet in any release so we better keep this around here.
Lcov fix reference:
https://github.com/linux-test-project/lcov/commit/
632c25a0d1f5e4d2f4fd5b28ce7c8b86d388c91f
Stefan Schmidt [Wed, 7 Dec 2016 16:35:57 +0000 (17:35 +0100)]
build: coverage: disable branch coverage generation to avoid hangs in gcov
I have seen hangs with gcov on Jenkins and locally where the processing just
keeps spinning in an infinite loop. From what I have found out this boils down
to using gcov --all-blocks which is what lcov does with branch coverage enabled.
It is supposed to be fixed in gcc 4.8+ but I see this here with 5.3.1. So its
either a regression or not completely fixed. In any case we will ignore branch
coverage for now. I hoped it would work well but it did only for a while and
having line and function coverage is better than having nothing.
Derek Foreman [Wed, 7 Dec 2016 16:10:42 +0000 (10:10 -0600)]
evas - software generic - fix crash
Commit
fcef8d8392b8c8d1d7b96baacaf5e7e89fcf6b45
breaks any evas engine that frees/NULLs its own outbuf before
calling evas_render_engine_software_generic_update()
We should unconditionally set the outbuf, we only need to
do the free conditionally.
Tom Hacohen [Wed, 7 Dec 2016 13:55:13 +0000 (13:55 +0000)]
Eo: Fix efl_isa() sometimes returning wrong results with extensions
This fixes an issue where efl_isa() wouldn't work for extensions or
ancestors of extensions of a class.
Example:
Class A implements interface F2
F2 inherits from interface F1
obj is of class A
Before this patch efl_isa(obj, F1) would return false, now it returns
true as expected.
This is just one example, there is a whole array of variations to this
issue that are now fixed.
Thanks to Gustavo for reminding me of this.
@fix
Tom Hacohen [Wed, 7 Dec 2016 13:18:41 +0000 (13:18 +0000)]
Eo tests: Adjust according to latest commit.
Daniel Kolesa [Wed, 7 Dec 2016 12:19:48 +0000 (13:19 +0100)]
eolian: use the generic class name instead of C name in source
This changes the string in Efl_Class_Description to use the real
class name (with namespaces) instead of the C class name. The
reason for this is that this string is generic, not C-related.
Daniel Kolesa [Wed, 7 Dec 2016 13:06:02 +0000 (14:06 +0100)]
eolian: forgotten free() (leaks memory otherwise)
Daniel Kolesa [Wed, 7 Dec 2016 12:55:56 +0000 (13:55 +0100)]
eolian: switch reference validation to new tokenizer
Tom Hacohen [Wed, 7 Dec 2016 12:50:52 +0000 (12:50 +0000)]
Eo gdb: Be more strict with types and convert Eo * to uintptr_t.
This should make the results cleaner and also solve potential conversion
issues in some version combinations of gdb and python.
Tom Hacohen [Wed, 7 Dec 2016 12:33:59 +0000 (12:33 +0000)]
Eo gdb: Implement eo_data_get to get eo data.
Like
79d76fb25ece4ffbf5785b4be2b030f062ef9f2c, this is useful when
debugging a core dump.
It accepts a valid pointer to an object, for example as returned from
$eo_resolve, and a name of a class or mixin, and returns a pointer to
the private data. Essentially the same as efl_data_scope_get(), but also
works on core dumps, and accepts a class name instead of a class
pointer.
Usage:
Print the pointer:
(gdb) print $eo_data_get($eo_resolve(obj), "Efl_Canvas_Object")
$1 = (void *) 0x555555eb9290
Use it directly (e.g. to print a value):
(gdb) print ((Evas_Object_Protected_Data *) $eo_data_get($eo_resolve(obj),
"Efl_Canvas_Object"))->last_event_type
$2 = EVAS_CALLBACK_MOUSE_UP
@feature
Carsten Haitzler (Rasterman) [Wed, 7 Dec 2016 10:24:44 +0000 (19:24 +0900)]
evas - software generic - fix crash when buffer is freed when its the same
evas_render_engine_software_generic_update(0 definitely is wrong where
it wants to always free the outbuf even if the buffer passed in is the
same one and thus it ends up being freed and now invalid. fix it
@fix
Artem Popov [Wed, 7 Dec 2016 05:21:12 +0000 (14:21 +0900)]
Evas: include efl_vg_container.eo.legacy.h to avoid implicit declaration for evas_vg_container_child* @fix
Summary: Due to implicit declaration, evas_vg_container_child_get casts to int and on 64-bit can return wrong pointer
Reviewers: cedric, NikaWhite, myoungwoon, jpeg, an.kroitor, Hermet
Reviewed By: Hermet
Subscribers: t.naumenko
Differential Revision: https://phab.enlightenment.org/D4464
Hermet Park [Wed, 7 Dec 2016 05:17:33 +0000 (14:17 +0900)]
elementary genlist: code refactoring.
removed duplicated logic and add a descriptive comment.
jinwoo.shin [Wed, 7 Dec 2016 04:57:56 +0000 (13:57 +0900)]
genlist : fix cannot scroll to item after call elm_genlist_item_update
Summary: Fix cannot scroll to item after call elm_genlist_item_update
Test Plan: https://phab.enlightenment.org/T4974
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee, minkyu, cedric, jpeg
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D4460
Sungtaek Hong [Wed, 7 Dec 2016 04:42:46 +0000 (13:42 +0900)]
emile_image: fix possible segmentation fault in AGRY88
Summary:
- ptrag is set NULL and is allocated only when prop is rotated.
but *ptrag = 0xFF00 | ptr[0]; without checking rotation.
Reviewers: jpeg, cedric, Hermet
Reviewed By: Hermet
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4463
Cedric BAIL [Wed, 7 Dec 2016 00:24:59 +0000 (16:24 -0800)]
evas: as an example make PMAPS decoding interruptible.
Cedric BAIL [Wed, 7 Dec 2016 00:23:59 +0000 (16:23 -0800)]
evas: use emile and evas new infrastructure to interrupt decoding of JPEG early.
Cedric BAIL [Wed, 7 Dec 2016 00:22:56 +0000 (16:22 -0800)]
emile: add infrastructure for callback to request what to do with image.
First use of this infrastructure is to make JPEG decoding interruptible.
Cedric BAIL [Wed, 7 Dec 2016 00:22:11 +0000 (16:22 -0800)]
efl: extend possible error while decoding an image to be cancelled.
Cedric BAIL [Tue, 6 Dec 2016 19:44:05 +0000 (11:44 -0800)]
evas: add possibility for image loader to know if what they are working is still useful.
Cedric BAIL [Tue, 6 Dec 2016 19:34:56 +0000 (11:34 -0800)]
evas: add infrastructure for Evas_Loader to know if what they are working on is still useful.
Cedric BAIL [Tue, 6 Dec 2016 01:08:50 +0000 (17:08 -0800)]
evas: add capability to know if a thread has been cancelled.
Cedric BAIL [Tue, 6 Dec 2016 00:57:46 +0000 (16:57 -0800)]
evas: switch to use Ecore_Thread instead of half done Evas thread infrastructure.
Derek Foreman [Tue, 6 Dec 2016 22:20:46 +0000 (16:20 -0600)]
wayland_shm: track mappings more effectively
Unmap any active mappings from buffer_destroy. This also means we need
to clear the mapping after unmapping in fallback.
Derek Foreman [Tue, 6 Dec 2016 22:16:10 +0000 (16:16 -0600)]
wayland_shm: Refcount the dmabuf buffer manager
Because we async render into buffers before the compositor has told us
we can use them, we can end up kicking over to fallback while still
rendering into a buffer.
Refcount the manager to let us clean up properly without crashing when
this happens.
Derek Foreman [Tue, 6 Dec 2016 22:21:49 +0000 (16:21 -0600)]
wayland_shm: clear busy bit for buffers during dmabuf fallback
If we pre-rendered then we have a busy buffer - we need to clear that
busy bit after reading from the buffer or buffer_destroy won't clean it
up.
Derek Foreman [Tue, 6 Dec 2016 22:17:57 +0000 (16:17 -0600)]
wayland_shm: Clear busy status when replacing an unassigned buffer
If we render fast enough we can use more than one buffer before the
compositor assigns us buffer ids. We need to be careful to clear the
busy bit on all but the most recent one.
Derek Foreman [Tue, 6 Dec 2016 16:43:18 +0000 (10:43 -0600)]
gl_drm: Allow testing of dmabuf objects
Enlightenment needs to know if a specific dmabuf format is supported
before it lets clients use it. This lets E test commit a wayland
dmabuf object without assigning it a buffer.
Chris Michael [Tue, 6 Dec 2016 19:13:00 +0000 (14:13 -0500)]
evas-wayland-shm: Keep tile buffers in sync with size changes
Previous patch to not destroy Outbuf on resize should not have removed
this line else software generic tilebuffers will not be in sync with
the updated size.
ref
5ebba4463
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Bruno Dilly [Tue, 6 Dec 2016 19:06:05 +0000 (17:06 -0200)]
examples/evas: use new API for key modifiers per seat
Chris Michael [Tue, 6 Dec 2016 19:05:19 +0000 (14:05 -0500)]
evas-drm: Keep tile buffers in sync with size changes
This line should not have been removed from the previous patch. Thanks
to Cedric for catching this.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 6 Dec 2016 18:17:16 +0000 (13:17 -0500)]
evas-drm: Don't destroy Outbuf on resize
On an engine resize, we previously would destroy the Outbuf structure.
This patch modifies the code so that on a resize we no longer have to
destroy the old Outbuf and reallocate a new one. Instead, we will just
reconfigure the existing one and update it's properties.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Tue, 6 Dec 2016 18:08:42 +0000 (19:08 +0100)]
eolian: add a reference resolver
New API function eolian_doc_token_ref_get will resolve the kind of
reference in the given token and extract the necessary data you
might need for further use, for example class and function for
methods, or struct and field for struct field. It also supports
event references that will be added into Eolian later.
EFL will be switched to the new resolver (by changing the validator
code) during the next step.
Chris Michael [Tue, 6 Dec 2016 18:01:35 +0000 (13:01 -0500)]
evas-wayland-shm: Don't destroy Outbuf on resize
On an engine resize, rather than destroy & recreate the Outbuf
structure (and the associated surface) we can just call the
eng_output_resize function (which in turn will call
outbuf_reconfigure) to update Outbuf with new properties. This saves
us from having to create a whole new Outbuf every time we resize.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Gustavo Sverzut Barbieri [Tue, 6 Dec 2016 16:38:34 +0000 (14:38 -0200)]
eo: guard lifecycle obj log inside spinlock.
since the array can be pushed or looked up from multiple threads we
must have a lock in place.
Gustavo Sverzut Barbieri [Tue, 6 Dec 2016 16:24:59 +0000 (14:24 -0200)]
eo: guard all efl_super() checks under EO_DEBUG.
Tom is worried about performance hit (god, checking a bit in a pointer
we'll fetch to memory anyway, since we return it masked), so guard
under EO_DEBUG.
Stefan Schmidt [Tue, 6 Dec 2016 13:33:24 +0000 (14:33 +0100)]
all: use void if we really want to make sure we do not accept parameters
In C we need this to make clear that we really do not accept parameters.
Found by the smatch source code matcher. I had run and fixed this before
but it seems to creep in again over time.
Stefan Schmidt [Tue, 6 Dec 2016 16:03:59 +0000 (17:03 +0100)]
eina: fix same wrong indenting
Brought up by running smatch. We have way to many of such things in tree though
to fix them all without annoying a lot of people. I will just stop here.
Gustavo Sverzut Barbieri [Tue, 6 Dec 2016 16:06:54 +0000 (14:06 -0200)]
eo_debug: add lifecycle debug options, allow run-in-tree and use eina_btlog.
As usual with our code, EFL_RUN_IN_TREE=1 will lead to usage of
binaries from the current build dir instead of system.
To make user life easier, add -l/--lifecycle-debug and
-L/--lifecycle-no-debug options, as well as -h/--help. The
lifecycle-debug option will export the correct environment variables,
such as EO_LIFECYCLE_DEBUG, EO_LIFECYCLE_NO_DEBUG and
EINA_LOG_LEVELS=eo_lifecycle:4 if no such level was set for that
domain.
Last but not least, pass all command's stderr thru eina_btlog so
backtraces are automatically translated to function names, files and
lines. This one was a bit trickier to respect colors and stdout/stderr
contents, see comments in the script.
Gustavo Sverzut Barbieri [Tue, 6 Dec 2016 16:00:55 +0000 (14:00 -0200)]
eina_btlog: allows continuous running on input, flush when possible.
eina_btlog will make a table of the backtrace and then must compute
columns length.
However, if not running in such mode (ie: show_compact/-c), we don't
need to queue lines or compute column lengths.
Also, now that we accept non-backtrace lines, like other output
interleaved, then flush the table once such line is found, this will
restart the table columns for the next output, but at least allows
eina_btlog to run on a live output, such as:
myapp 2>&1 | eina_btlog
Gustavo Sverzut Barbieri [Tue, 6 Dec 2016 15:50:18 +0000 (13:50 -0200)]
eina_btlog: cleanup backtrace list.
Gustavo Sverzut Barbieri [Tue, 6 Dec 2016 14:40:33 +0000 (12:40 -0200)]
eo: efl_super() can receive a class as first parameter.
This fixes the src/tests/eo/test_function_overrides
Tom Hacohen [Tue, 6 Dec 2016 12:45:40 +0000 (12:45 +0000)]
Static deps unibreak: Update to latest version.
This version supports Unicode 9.0 and includes many fixes.
Reference git hash:
fe1ce2e78c19fa2b4b7a92b1864a12b432da6ec6
This version is not yet released, but now is a better time to sync it,
and there are no code changes expected, only "admin" work.
Main changes:
Unicode 9.0 support
Many fixes in the lineberaking algorithm to now pass the Unicode
reference test data.
@feature
Hermet Park [Tue, 6 Dec 2016 10:18:09 +0000 (19:18 +0900)]
static_libs triangulator: prevent null pointer(ptr) access.
Stefan Schmidt [Tue, 6 Dec 2016 09:49:10 +0000 (10:49 +0100)]
evas: native_dmabuf: make sure we check for NULL before not after we dereference
Same change as just done in evas_native_tbm in commit
38dbe932db5c12f66ff2e045ac74107e149c14da.
Stefan Schmidt [Tue, 6 Dec 2016 09:42:42 +0000 (10:42 +0100)]
evas: native_tbm: make sure we check for NULL before not after we dereference
Using *im and dereferencing it before doing the actual NULL check does not make
much sense. I kept the checks as they have been there before so the intent was
probably that they could be NULL and should be checked.
CID: 1270030, 1270029, 1270028
Stefan Schmidt [Tue, 6 Dec 2016 09:31:57 +0000 (10:31 +0100)]
evas: input_pointer: remove unreachable case statement
Directly in the beginning of the function we check if key is
<= EFL_INPUT_VALUE_NONE and return if this is true. No chance key could be
EFL_INPUT_VALUE_NONE below here.
CID: 1361997
Stefan Schmidt [Tue, 6 Dec 2016 09:21:50 +0000 (10:21 +0100)]
evas: events: fix NULL check on returned value
Continuing the loop if the returned pdata is non-NULL does not make sense.
What Coverity actually found was that if we have cobj_pdata NULL here we
would happily deref it the line afterwards and crash.
Guilherme, Bruno if something else was intended here feel free to change it
again.
CID: 1366822
Jaehyun Cho [Tue, 6 Dec 2016 09:51:14 +0000 (18:51 +0900)]
eolian: Fix to unregister eina log domain if it was registered.
Hermet Park [Tue, 6 Dec 2016 09:56:07 +0000 (18:56 +0900)]
evas render: code refactoring.
There were some obj->map->surface validation check
but final map drawing was in the out of the surface valid scope.
Actually, this change does nothing but logically this change makes sense.
Jean-Philippe Andre [Tue, 6 Dec 2016 06:52:10 +0000 (15:52 +0900)]
win: Simplify sizing recalc
This amends the previous patch. Some moer testing showed that the
deferred resize flag was in fact harmful (on X with CSD).
Carsten Haitzler (Rasterman) [Tue, 6 Dec 2016 07:14:01 +0000 (16:14 +0900)]
efl_net check openssl x509 check o runtime dlsym checks
this fixes T4814
Jean-Philippe Andre [Tue, 6 Dec 2016 06:19:03 +0000 (15:19 +0900)]
win: Fix sizing issues with new windows
This fixes sizing issues in EDI when opening a new window (not
the splash screen). This patch is quite brute force in the way
it pushes recalc.
Sungtaek Hong [Tue, 6 Dec 2016 05:17:31 +0000 (14:17 +0900)]
elm_map: add copyright_cb for osm tile source.
Summary:
- According to Copyright and license in Openstreetmap
(https://www.openstreetmap.org/copyright/en)
credit has to be in the corner of map.
- Add copyright_cb which returns an object to show copyright.
Test Plan:
1. Excecute elementary_test->map
2. Right click->source->set any tile source
3. Observe copyright is added.
Reviewers: cedric, Hermet, jpeg
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4449
Jaehyun Cho [Tue, 6 Dec 2016 05:42:37 +0000 (14:42 +0900)]
cpphash: Fix not to access freed pointer.
Jee-Yong Um [Tue, 6 Dec 2016 03:10:01 +0000 (12:10 +0900)]
Elm.Button: fix color class descriptions
Reviewers: cedric, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D4457
Hermet Park [Tue, 6 Dec 2016 04:39:23 +0000 (13:39 +0900)]
updated AUTHORS
soohye [Tue, 6 Dec 2016 04:30:43 +0000 (13:30 +0900)]
scrollable_interface: fixed last_page_get() API
Summary: ceiling the vaule of content size divided by page size
Reviewers: cedric, jpeg, Hermet
Reviewed By: Hermet
Subscribers: minkyu, sju27, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4447
Jean-Philippe Andre [Tue, 6 Dec 2016 02:27:37 +0000 (11:27 +0900)]
eldbus: change to idle_enterer from idler
Summary:
This patch set changes eldbus to use idle_enterer from idler.
If an application does not give idle time, then the eldbus cannot have chance to work.
Reviewers: raster, cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4443
Hosang Kim [Tue, 6 Dec 2016 02:31:06 +0000 (11:31 +0900)]
elm_panel: change panel freeze API when swiping panel.
Summary:
The panel is freezed by elm_interface_scrollable_movement_block_set(),
but elm_interface_scrollable_freeze_set() is used to unfreeze panel.
Test Plan: elementar_test -> panel scrollable
Reviewers: woohyun, seoz, Hermet, cedric, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4458
Carsten Haitzler (Rasterman) [Tue, 6 Dec 2016 02:19:05 +0000 (11:19 +0900)]
evas - protect against outbuf alloc fail possibility
this should fix T4967
Hermet Park [Tue, 6 Dec 2016 02:07:49 +0000 (11:07 +0900)]
elementary calendar: it'd rather return false here.
Jean-Philippe Andre [Tue, 6 Dec 2016 01:40:11 +0000 (10:40 +0900)]
evas: Ensure single init of common per canvas
After @cedric's commit
6427c77707fb6116a98b we end up with E
not working in Xephyr, because evas_common_shutdown() is called
too many times (init_count == -1). So I'm being paranoid and
tracking whether Evas has initialized or not evas_common. That
way we end up with exactly the right number of inits. We even
reach 0 after E shuts down :)
Cedric BAIL [Mon, 5 Dec 2016 19:35:19 +0000 (11:35 -0800)]
evas: remove all Engine Info headers installation except for the buffer engine.
We do not have any upstream application using those headers and if any do,
they should have proper auto detection of them being available or not. Today,
most application should use Ecore_Evas directly. If the need reappear, we will
reintroduce those headers one by one.
Cedric BAIL [Fri, 2 Dec 2016 23:27:48 +0000 (15:27 -0800)]
evas: refactor initialisation and shutdown of evas_common.
Stefan Schmidt [Mon, 5 Dec 2016 16:00:56 +0000 (17:00 +0100)]
elm: config: check return value of eina_value_get instead of returning always TRUE
There is always a chance that eina_value_get will not return EINA_TRUE here so
better check it and use it as return value directly.
CID: 1357138
Stefan Schmidt [Mon, 5 Dec 2016 15:53:42 +0000 (16:53 +0100)]
elm: multibuttomentry: check if value is valid before we access it
The ELM_MULTIBUTTONENTRY_DATA_GET_OR_RETURN will access 'it' here before we
check it is NULL. Reverse the order of these checks.
CID: 1365324, 1365323
Stefan Schmidt [Mon, 5 Dec 2016 15:30:22 +0000 (16:30 +0100)]
edje: svg_loader: make sure we check the return from all _parser_number calls
Instead of nesting this make a bit more sense (at least to me). Also return in
case one of these is not a number.
CID: 1356610
Stefan Schmidt [Mon, 5 Dec 2016 15:05:12 +0000 (16:05 +0100)]
efreetd: handle invalid fd in all cases
Very unlikely that we will get a -1 when opening /dev/null but you never know
what kind of system you are running on.
CID: 1361759
Chris Michael [Mon, 5 Dec 2016 14:27:11 +0000 (09:27 -0500)]
ecore-wl2: No need to call hide inside the free function
When we are freeing an Ecore_Wl2_Window, there is no need to call
ecore_wl2_window_hide anymore because inside the free function we are
destroying subsurfaces, surfaces, etc, etc so no need to even unmap
them.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 5 Dec 2016 14:22:26 +0000 (09:22 -0500)]
ecore-wl2: When we hide a window, attach a NULL buffer to the surface
This patch essentially makes sure that the surface gets a NULL buffer
attached to it when we are hiding.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 5 Dec 2016 14:21:20 +0000 (09:21 -0500)]
evas-wayland-shm: Don't recreate Outbuf if we are hidden
If the hidden flag is set, then we don't need to recreate the Outbuf
for a given canvas as the window is hidden and we are not going to
render there until it's shown again.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Tom Hacohen [Mon, 5 Dec 2016 12:35:40 +0000 (12:35 +0000)]
Emacs config: Also remove from extra_dist.
Tom Hacohen [Mon, 5 Dec 2016 12:34:43 +0000 (12:34 +0000)]
Emacs configs: Move to designated repo.
Tom Hacohen [Mon, 5 Dec 2016 12:06:20 +0000 (12:06 +0000)]
Eo gdb: Remove redundant variable setting.
These were hardcoded values I used for debugging, they are not used anymore,
they are instead calculated at runtime.
Marcel Hollerbach [Mon, 5 Dec 2016 10:13:02 +0000 (11:13 +0100)]
emile: do not rely on the struct size
Summary:
in newer versions of openssl, most of the public structures are made
opaque. So we should use the openssl api to allocate this structure.
Since ctx is now a pointer we dont need opened anymore, so those vars
are replaced with ctx checks. ctx is always NULL'ed after a free
fix T4923
Reviewers: cedric, jpeg, stefan_schmidt
Reviewed By: jpeg, stefan_schmidt
Subscribers: stefan_schmidt, ManMower, jpeg
Maniphest Tasks: T4923
Differential Revision: https://phab.enlightenment.org/D4456
Jean-Philippe Andre [Mon, 5 Dec 2016 09:15:08 +0000 (18:15 +0900)]
eo: Fix test case
The exact error message has changed.
Another test case is still broken.
Jean-Philippe Andre [Mon, 5 Dec 2016 01:43:38 +0000 (10:43 +0900)]
eo: Fix potential inifinite loop
I saw a little oopsie in patch
fc48161910fc013674f4af9e19. This
amends it to avoid a potential infinite loop.
Hermet Park [Mon, 5 Dec 2016 09:03:01 +0000 (18:03 +0900)]
evas textblock: fix a rendering issue.
It's a rare case but a possible scenario that textblock is not updated
properly in case of textblock rendering via proxy/map.
If the textblock state turned out with an invisible state,
its relayouting won't be up to date. But actually, it could be rendered
by map/proxy. In that case textblock text layouting would be incorrect.
Additionally, removed evas event freeze state there because map/proxy won't
be drawn under the event freeze state always.
@fix
Jean-Philippe Andre [Mon, 5 Dec 2016 00:46:55 +0000 (09:46 +0900)]
eo: Make error message less nebulous
When writing this ERR log I thought about "thread" (it's really
the keyword here) but eventually reworded to "context". Let's be
clearer about the possible issue here.
Andy Williams [Sat, 3 Dec 2016 15:59:40 +0000 (15:59 +0000)]
elm_code: refactoring of the elm_code_line_indent to work with lines
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 14:57:24 +0000 (12:57 -0200)]
eina_btlog: compact output and keep non-bt information.
Now we keep all non-bt prefixes as well, in conjunction with compact
mode it looks like we resolved the address to lines in the output.
Example:
```
$ cat bt-new.txt
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e401ca: libeo_dbg.so+0x91ca (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e3fb42: _efl_add_internal_start+0x1c2 (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x0000000010a85f: lt-efl_net_dialer_simple_example+0x285f (in /home/gustavo/Development/git/efl/src/examples/ecore/.libs/lt-efl_net_dialer_simple_example 0x108000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000005c7c291: __libc_start_main+0xf1 (in /usr/lib/libc.so.6 0x5c5c000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x0000000010a38a: _start+0x2a (in /home/gustavo/Development/git/efl/src/examples/ecore/.libs/lt-efl_net_dialer_simple_example 0x108000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() obj_id=0x400000007feb55b9 deleted obj=0x97870b0, class=0x9785850 (Efl_Net_Dialer_Simple) [0.9045s, 0.0198 ago]:
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e409aa: libeo_dbg.so+0x99aa (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e407f1: libeo_dbg.so+0x97f1 (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e3eee8: libeo_dbg.so+0x7ee8 (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e3f09e: _efl_object_call_end+0x4e (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000004e48a65: efl_del+0x105 (in src/lib/eo/.libs/libeo_dbg.so 0x4e37000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x0000000010ac2c: lt-efl_net_dialer_simple_example+0x2c2c (in /home/gustavo/Development/git/efl/src/examples/ecore/.libs/lt-efl_net_dialer_simple_example 0x108000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x00000005c7c291: __libc_start_main+0xf1 (in /usr/lib/libc.so.6 0x5c5c000)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() 0x0000000010a38a: _start+0x2a (in /home/gustavo/Development/git/efl/src/examples/ecore/.libs/lt-efl_net_dialer_simple_example 0x108000)
ERR<24641>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() obj_id=0x400000007c9a1109 was already deleted 0.0287 seconds ago!
```
Results in:
```
$ cat /tmp/bt-new.txt | eina_btlog -c
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _eo_log_obj_new (in eo.c:2691)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _efl_add_internal_start (in eo.c:844)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() main (in efl_net_dialer_simple_example.c:375)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() __libc_start_main (in ??:375)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _start (in ??:375)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() obj_id=0x400000007feb55b9 deleted obj=0x97870b0, class=0x9785850 (Efl_Net_Dialer_Simple) [0.9045s, 0.0198 ago]:
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _eo_log_obj_free (in eo.c:2714)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _eo_free (in eo.c:974)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _efl_unref_internal (in eo_private.h:342)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _efl_object_call_end (in eo.c:620)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() efl_del (in efl_object.eo.c:78)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() main (in efl_net_dialer_simple_example.c:447)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() __libc_start_main (in ??:447)
ERR<23314>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() _start (in ??:447)
ERR<24641>:eo_lifecycle ../src/lib/eo/efl_object.eo.c:78 efl_del() obj_id=0x400000007c9a1109 was already deleted 0.0287 seconds ago!
```
which is similar to valgrind's log and is MUCH nicer to read :-)
This commit also simplifies alignment and color display by using a single printf().
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 14:15:06 +0000 (12:15 -0200)]
eina_btlog: show comments (non-bt lines)
If the user paste the backtrace he may include some non-backtrace
line, such as Eo logs that includes the message saying what's the
backtrace is about.
These lines will be printed as is, unless "-C" is used to discard
them.
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 13:59:48 +0000 (11:59 -0200)]
eina_btlog: understand new backtrace format used by eo.
The output of eo backtrace is much more readable than eina's default,
but still misses addr2line translation done by eina_btlog, so make
eina_btlog understand the new format.
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 13:06:05 +0000 (11:06 -0200)]
eina_btlog: improve help.
Andy Williams [Sat, 3 Dec 2016 06:08:10 +0000 (06:08 +0000)]
elm_code: ooops, fix test from previous refactor
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 12:35:27 +0000 (10:35 -0200)]
eo: do not use eina_trash when running on valgrind.
This allows valgrind to show when the object was created and deleted.
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 11:44:44 +0000 (09:44 -0200)]
eo: fix compilation without HAVE_BACKTRACE.
time_get() function was used even in that case to log when objects
were created or deleted.
thanks @vtorri.
Gustavo Sverzut Barbieri [Sat, 3 Dec 2016 11:41:09 +0000 (09:41 -0200)]
eo: fix missing Evil.h include
Jean Guyomarc'h [Sat, 3 Dec 2016 11:10:04 +0000 (12:10 +0100)]
eo: fix build on macOS
Commit
227463bd introduces macOS-specific code, but without including the
header that provides the used declarations.