Chris 'BinGOs' Williams [Sun, 27 Jan 2013 21:23:35 +0000 (21:23 +0000)]
Document module and utility deprecations in perldelta
Chris 'BinGOs' Williams [Sun, 27 Jan 2013 15:24:43 +0000 (15:24 +0000)]
Add module deprecations for v5.18.0 to Module::CoreList
Aaron Crane [Sun, 27 Jan 2013 10:56:14 +0000 (10:56 +0000)]
New TODO test: B::Deparse doesn't handle lexical subs
See RT #116553.
Dagfinn Ilmari Mannsåker [Sat, 26 Jan 2013 17:01:25 +0000 (17:01 +0000)]
Fix installman ignoring --silent
Chris 'BinGOs' Williams [Sun, 27 Jan 2013 01:04:28 +0000 (01:04 +0000)]
Update Archive-Extract to CPAN version 0.64
[DELTA]
Changes for 0.64 Sat Jan 26 21:07:03 2013
============================================
* Add deprecation usage to warn if the
module is loaded from corelib.
Archive::Extract is leaving core with
v5.20.0, but will remain available from
CPAN.
Tony Cook [Sat, 26 Jan 2013 03:06:37 +0000 (03:06 +0000)]
un-TODO a test that passes on recent FreeBSD
It may pass on earlier FreeBSD, but I don't have it available to
check.
Tony Cook [Fri, 25 Jan 2013 11:09:25 +0000 (11:09 +0000)]
EINVAL is expected when f?pathconf() isn't implemented for a path
This can happen when a particular file system doesn't implement a
particular variable.
RT# 116463
Tony Cook [Sun, 27 Jan 2013 04:17:24 +0000 (15:17 +1100)]
avoid PERL_UNICODE interfering with the new PerlIO-scalar tests
Smylers [Sat, 26 Jan 2013 23:19:06 +0000 (16:19 -0700)]
PATCH [perl 116252]: Correct nested pod bullets in perl5177delta.pod
Karl Williamson [Sat, 26 Jan 2013 19:06:49 +0000 (12:06 -0700)]
Porting/todo.pod: Add tasks
This requests people to volunteer to
1) classify type unknown bug tickets
2) investigate new tickets, classify them, and get TODO tests from the
originator
3) add TODO tests to old tickets
Chris 'BinGOs' Williams [Sat, 26 Jan 2013 16:51:18 +0000 (16:51 +0000)]
Update B-Lint to CPAN version 1.17
[DELTA]
1.17 2013-0126
make the use of "deprecate" conditional
Tobias Leich [Thu, 24 Jan 2013 09:05:46 +0000 (10:05 +0100)]
replace tabs with spaces
Use spaces like the rest of the pod does.
Tobias Leich [Thu, 24 Jan 2013 09:04:24 +0000 (10:04 +0100)]
wrap examples in single quotes
Examples that use $ as metacharacter should be in single quotes,
or the dollar must be escaped.
Chris 'BinGOs' Williams [Sat, 26 Jan 2013 14:50:15 +0000 (14:50 +0000)]
Update lib/.gitignore to include Config-Perl-V generated file
Ricardo Signes [Sat, 26 Jan 2013 13:28:50 +0000 (08:28 -0500)]
Import Config-Perl-V 0.16
Ricardo Signes [Fri, 25 Jan 2013 03:44:22 +0000 (22:44 -0500)]
prevent failures deep in value dumping from aborting
Sometimes, dumpvar's dumpvalue routine gets a value it can't dump. The
simplest example to contrive is the one in this test: a tied hash that
can't tell you its keys. Until now, this would cause the whole dump to
abort as soon as it failed to dump one part.
With this commit, each stringify or unwind is inside an eval. Failed
stringifications or unwindings are replaced with a placeholder showing
the error.
unwind uses return to stop early, and rather than go through contortions
to wrap the eval in something that can then return 1 to test that eval
worked, I've just asserted that this code requires 5.14.0, which made $@
a much more reliable indicator of failure after eval.
Tony Cook [Sat, 26 Jan 2013 04:24:38 +0000 (15:24 +1100)]
perldelta for
f0af002c73 (-DPERL_GLOBAL_STRUCT)
Peter Martini [Fri, 25 Jan 2013 17:06:47 +0000 (12:06 -0500)]
Fix format string warnings in toke.c Changed literals to "%s", literal
Chris 'BinGOs' Williams [Fri, 25 Jan 2013 16:37:59 +0000 (16:37 +0000)]
Update CPANPLUS-Dist-Build to CPAN version 0.70
[DELTA]
0.70 Fri Jan 25 15:58:27 GMT 2013
- Add deprecation usage to warn if modules are loaded
from corelib. CPANPLUS::Dist::Build will be leaving
core with v5.20.0 and will still be available on
CPAN.
Andy Dougherty [Fri, 25 Jan 2013 15:12:35 +0000 (10:12 -0500)]
Correct variable names in embed.fnc for hv_free_ent and hv_free_ent_ret.
Make the second variable name in embed.fnc match those used in the
actual function declaration. This will matter if we add in 'entry'
to PERL_ARGS_ASSERT_HV_FREE_ENT_RET. Also regen headers (only proto.h
is affected) to match.
Chris 'BinGOs' Williams [Fri, 25 Jan 2013 08:13:12 +0000 (08:13 +0000)]
Update B-Lint to CPAN version 1.16
[DELTA]
1.16 2013-01-23
install to sitelib, not corelib on 5.12.0 and later
1.15 2013-01-23
Merge changes from perl core:
- Stop the indexer from processing private modules
Add warning that B::Lint will be removed from core, if used from core
Tony Cook [Fri, 25 Jan 2013 02:54:47 +0000 (13:54 +1100)]
fix -DPERL_GLOBAL_STRUCT_PRIVATE builds
Tony Cook [Tue, 22 Jan 2013 11:38:10 +0000 (22:38 +1100)]
PL_Vars and PL_VarsPtr aren't exported under PERL_GLOBAL_STRUCT_PRIVATE
Tony Cook [Tue, 22 Jan 2013 11:37:34 +0000 (22:37 +1100)]
release the global struct *after* we've finished using it
Karl Williamson [Thu, 24 Jan 2013 21:41:02 +0000 (14:41 -0700)]
Fix various minor pod issues
These were all uncovered by the new Pod::Checker, not yet in core.
Fixing these will speed up debugging the new Checker.
Tony Cook [Fri, 25 Jan 2013 00:28:11 +0000 (11:28 +1100)]
perldelta for
a951350815 (PerlIO-scalar)
Tony Cook [Thu, 24 Jan 2013 23:42:37 +0000 (10:42 +1100)]
[perl #109828] disallow scalar I/O on non-byte strings
Tony Cook [Thu, 24 Jan 2013 10:37:25 +0000 (21:37 +1100)]
warn and fail on writes to SVf_UTF8 SVs
Tony Cook [Thu, 24 Jan 2013 22:56:14 +0000 (09:56 +1100)]
TODO tests for writing to a SVf_UTF8 scalar
Tony Cook [Thu, 24 Jan 2013 22:56:01 +0000 (09:56 +1100)]
handle reading from a SVf_UTF8 scalar
if the scalar can be downgradable, it is downgraded and the read succeeds.
Otherwise the read fails, producing a warning if enabled and setting
errno/$! to EINVAL.
Tony Cook [Mon, 31 Dec 2012 02:33:02 +0000 (13:33 +1100)]
TODO tests for reads from a scalar changed to upgraded after open
Tony Cook [Mon, 31 Dec 2012 00:48:24 +0000 (11:48 +1100)]
bump PerlIO::scalar's version
Tony Cook [Thu, 24 Jan 2013 03:38:21 +0000 (14:38 +1100)]
document the new warning
Tony Cook [Thu, 24 Jan 2013 10:29:32 +0000 (21:29 +1100)]
fail to open scalars containing characters that don't fit in a byte
Tony Cook [Thu, 24 Jan 2013 03:35:25 +0000 (14:35 +1100)]
TODO tests for opening upgraded scalars
Karl Williamson [Thu, 24 Jan 2013 16:59:47 +0000 (09:59 -0700)]
Porting/todo.pod: Add task to clean up pods
Chris 'BinGOs' Williams [Thu, 24 Jan 2013 12:28:56 +0000 (12:28 +0000)]
Update Digest-SHA to CPAN version 5.82
[DELTA]
5.82 Thu Jan 24 04:54:12 MST 2013
- introduced workaround to SvPVbyte bug in Perl 5.6
-- module behavior now consistent under all Perls 5.6+
-- ref: new test script t/unicode.t
-- SHA routines now always croak on wide chars (5.6+)
- removed "static" message schedules from C code
-- default "auto" is now just as fast
-- thread-safe option (-t) no longer necessary
-- still allowed, but ignored
-- simplifies source and header files
-- eliminates SHA_STO_CLASS and SHA_THREAD_SAFE
-- ref. Bug #82784
-- thanks to Steve Hay for initial patch
- provided documentation to describe Unicode handling
-- ref: Bug #82378
- updated documentation of NIST statement on SHA-1
Chris 'BinGOs' Williams [Thu, 24 Jan 2013 07:48:35 +0000 (07:48 +0000)]
Update Module-Pluggable to CPAN version 4.6
[DELTA]
2013-01-23 - 4.6
Add warning about future removal from core
Chris 'BinGOs' Williams [Thu, 24 Jan 2013 07:24:23 +0000 (07:24 +0000)]
Make sure that Test-Harness customisations are declared and checked.
Craig A. Berry [Fri, 31 Dec 2010 01:45:13 +0000 (19:45 -0600)]
VMS nits in cpan/Test-Harness/t/source.t
[Reapplying
ada6eeb82df as it's still awaiting application
upstream two years later and the things it fixes get broken
again every time a new version of Test::Harness is brought
into blead.]
1.) Can't get the basename of a directory in native format.
2.) Symlinks still a bit dodgy -- skip tests for now.
Submitted upstream at:
https://rt.cpan.org/Ticket/Display.html?id=64353
Karl Williamson [Tue, 22 Jan 2013 21:02:27 +0000 (14:02 -0700)]
Typo in perl5178delta
Spotted by Hugo van der Sanden
Karl Williamson [Tue, 22 Jan 2013 20:34:54 +0000 (13:34 -0700)]
Add deprecation warning for literal PATWS under /x
This is explained in the perldelta changes in this commit. We plan to
migrate to Unicode's definition of white-space to ignore under /x. That
means we should raise a deprecation warning in the meantime if anyone
currently uses these characters in such a way as to have the meaning
changed when the migration is completed.
Karl Williamson [Tue, 22 Jan 2013 20:35:15 +0000 (13:35 -0700)]
regcomp.c: Add macro for generating deprecated warnings
This will be used in a future commit
Karl Williamson [Tue, 22 Jan 2013 20:32:01 +0000 (13:32 -0700)]
regcomp.c: Add comments; no code changes
Karl Williamson [Tue, 22 Jan 2013 20:30:01 +0000 (13:30 -0700)]
regcharclass.h: Add macro for non-ASCII PATWS
This will be used to deprecate uses of non-ASCII Pattern White Space
Karl Williamson [Tue, 22 Jan 2013 20:29:10 +0000 (13:29 -0700)]
/regen/regcharclass.pl: white-space only; no code changes
Karl Williamson [Tue, 22 Jan 2013 20:27:44 +0000 (13:27 -0700)]
regen/regcharclass.pl: Add capability
This allows one to generate macros that exclude just the ASCII range
Karl Williamson [Tue, 22 Jan 2013 20:23:06 +0000 (13:23 -0700)]
reg_mesg.t: Remove repetitious boiler plate
All the messages have boiler plate that can be removed and inserted by
the subroutine that does insertion anyway.
Karl Williamson [Tue, 22 Jan 2013 18:40:54 +0000 (11:40 -0700)]
Move t/lib/warnings/regcomp to t/re/reg_mesg.t
reg_mesg.t has better infrastructure to more easily add and maintain
these warnings.
Karl Williamson [Tue, 22 Jan 2013 18:16:59 +0000 (11:16 -0700)]
regcomp.c: Change warning category to just deprecated
The warnings for \b{ and \B{ were added in the 5.17 series; they are a
deprecation warning which should be turned off by that category. One
should not have to turn off regular regexp warnings as well to get rid
of these.
Karl Williamson [Tue, 22 Jan 2013 18:08:27 +0000 (11:08 -0700)]
reg_mesg.t: Add cpabilities; improve output
This adds the capability to have tests that each generate multiple
warnings, and it improves the flow so that if a test fails that make
moot subsequent tests, those tests are skipped.
Karl Williamson [Tue, 22 Jan 2013 02:32:09 +0000 (19:32 -0700)]
re/reg_mesg.t: White-space only; no code changes
Karl Williamson [Tue, 22 Jan 2013 02:25:01 +0000 (19:25 -0700)]
re/reg_mesg.t: Add tests for suppressing warnings
This automatically adds a test for each warning to verify that turning
off the warning category works.
Karl Williamson [Wed, 23 Jan 2013 18:36:01 +0000 (11:36 -0700)]
perlapi: Fix SvIOK_UV, SvUOK descriptions
Commit
b630937b8bf49e835d8976fc1036e68c79585b04 changed the text
of these two macros to how they currently work, but we don't
want to be tied to this behavior in the future.
New wording suggested by Darin McBride
Chris 'BinGOs' Williams [Wed, 23 Jan 2013 14:59:03 +0000 (14:59 +0000)]
Update Object-Accessor to CPAN version 0.46
[DELTA]
Changes for 0.46 Wed Jan 23 14:09:11 GMT 2013
=================================================
* Add deprecate usage to warn if module is loaded
from corelib. Object::Accessor is leading core
with v5.20.0, but will remain available from
CPAN.
Chris 'BinGOs' Williams [Wed, 23 Jan 2013 13:29:20 +0000 (13:29 +0000)]
Update Log-Message to CPAN version 0.06
[DELTA]
Changes for 0.06 Wed Jan 23 12:21:48 GMT 2013
=================================================
* Add deprecate usage to warn if module is loaded
from corelib. Log::Message is leaving core with
v5.20.0, but will still be available from CPAN.
Chris 'BinGOs' Williams [Wed, 23 Jan 2013 11:25:01 +0000 (11:25 +0000)]
Update Log-Message-Simple to CPAN version 0.10
[DELTA]
Changes for 0.10 Wed Jan 23 08:10:42 GMT 2013
================================================
* Add deprecate usage to warn if module is loaded
from corelib. Log::Message::Simple is leaving
core with v5.20.0, but will still be available
on CPAN.
Brad Gilbert [Wed, 26 Dec 2012 21:00:06 +0000 (15:00 -0600)]
Clean up indenting on t/win32/fs.t
Previous commit removed the need for indents.
Brad Gilbert [Wed, 26 Dec 2012 20:46:49 +0000 (14:46 -0600)]
Remove dead code from t/win32/fs.t
tempfile() from t/test.pl already handles checking for existing files
and removing them at the end of the test.
This test also doesn't need Config loaded
James E Keenan [Wed, 23 Jan 2013 03:25:04 +0000 (22:25 -0500)]
Convert to use of t/test.pl
Patch supplied by Marcel Gruenauer.
For: RT #116511
James E Keenan [Wed, 23 Jan 2013 00:32:33 +0000 (19:32 -0500)]
Note why switchF1.t and switchp.t do not use test.pl.
Patches submitted by Marcel Gruenauer.
For RT #116507 and 116517.
Chris 'BinGOs' Williams [Tue, 22 Jan 2013 12:45:07 +0000 (12:45 +0000)]
Update Term-UI to CPAN version 0.34
[DELTA]
Changes for 0.34 Tue Jan 22 12:19:40 GMT 2013
=====================================================
* deprecate usage added if the library is found in
corelib location. Term::UI is leaving core with
v5.20.0
Tony Cook [Tue, 22 Jan 2013 12:27:13 +0000 (23:27 +1100)]
syntax check a directory: set the test process locale too
Ricardo Signes [Mon, 21 Jan 2013 22:16:03 +0000 (17:16 -0500)]
move B-Lint and File-CheckTree to ./cpan
Ricardo Signes [Mon, 21 Jan 2013 16:34:42 +0000 (11:34 -0500)]
add deprecate.pm usage to CPANPLUS
Chris 'BinGOs' Williams [Mon, 21 Jan 2013 20:43:45 +0000 (20:43 +0000)]
Update CPANPLUS to CPAN version 0.9134
[DELTA]
Changes for 0.9134 Mon Jan 21 20:00:03 2013
================================================
* $VERSION all library files
Chris 'BinGOs' Williams [Mon, 21 Jan 2013 12:09:18 +0000 (12:09 +0000)]
The MAPping for Test-Harness is not required since 3.26
Aaron Crane [Mon, 21 Jan 2013 11:20:54 +0000 (11:20 +0000)]
Mark 5.17.8 as done in release_schedule.pod
Chris 'BinGOs' Williams [Sun, 20 Jan 2013 23:17:31 +0000 (23:17 +0000)]
Module-CoreList-2.80 has been released to CPAN
Chris 'BinGOs' Williams [Sun, 20 Jan 2013 22:30:11 +0000 (22:30 +0000)]
Actually update Test-Harness to CPAN version 3.26
[DELTA]
Finishes off what was started with
83044e8d6
Aaron Crane [Sun, 20 Jan 2013 19:28:58 +0000 (19:28 +0000)]
Bump the Perl version in various places for 5.17.9
Aaron Crane [Sun, 20 Jan 2013 19:14:59 +0000 (19:14 +0000)]
Make a new perldelta for 5.17.9-to-be
Aaron Crane [Sun, 20 Jan 2013 19:11:26 +0000 (19:11 +0000)]
Add the 5.17.8 epigraph to epigraphs.pod
Aaron Crane [Sun, 20 Jan 2013 15:49:49 +0000 (15:49 +0000)]
Add 5.17.8 to perlhist
Aaron Crane [Sun, 20 Jan 2013 15:46:34 +0000 (15:46 +0000)]
Update Module::CoreList for 5.17.8
Aaron Crane [Sun, 20 Jan 2013 18:22:21 +0000 (18:22 +0000)]
Last-minute "known issue" in perldelta
Aaron Crane [Sat, 19 Jan 2013 20:32:57 +0000 (20:32 +0000)]
Update perldelta for 5.17.8
Including the generated Acknowledgements section.
Thanks to Smylers++ for reviewing an earlier draft.
Karl Williamson [Thu, 27 Dec 2012 22:21:47 +0000 (15:21 -0700)]
Add av_top() synonym for av_len()
av_len() is misleadingly named.
Karl Williamson [Sun, 20 Jan 2013 04:37:36 +0000 (21:37 -0700)]
Replace XXX by correct bug number
Commit
4d68ffa0f7f345bc1ae6751744518ba4bc3859bd failed to get the
correct bug number in a comment
Karl Williamson [Sun, 20 Jan 2013 03:37:37 +0000 (20:37 -0700)]
perlre: Fix typo
"<" isn't a metacharacter, therefore "\<" doesn't change its meaning.
"[" is a metacharacter, therefore "\[" does change its meaning.
Karl Williamson [Sun, 20 Jan 2013 03:29:42 +0000 (20:29 -0700)]
Deprecate certain rare uses of backslashes within regexes
There are three pairs of characters that Perl recognizes as
metacharacters in regular expression patterns: {}, [], and (). These
can be used as well to delimit patterns, as in:
m{foo}
s(foo)(bar)
Since they are metacharacters, they have special meaning to regular
expression patterns, and it turns out that you can't turn off that
special meaning by the normal means of preceding them with a backslash,
if you use them, paired, within a pattern delimitted by them. For
example, in
m{foo\{1,3\}}
the backslashes do not change the behavior, and this matches "f", "o"
followed by one to three more occurrences of "o".
Usages like this, where they are interpreted as metacharacters, are
exceedingly rare; we think there are none, for example, in all of CPAN.
Hence, this deprecation should affect very little code. It does give
notice, however, that any such code needs to change, which will in turn
allow us to change the behavior in future Perl versions so that the
backslashes do have an effect, and without fear that we are silently
breaking any existing code.
=head1 Performance Enhancements
Karl Williamson [Wed, 16 Jan 2013 20:02:53 +0000 (13:02 -0700)]
toke.c: White-space alignment only
Karl Williamson [Mon, 14 Jan 2013 17:56:06 +0000 (10:56 -0700)]
Revert "Deprecate literal unescaped "{" in regexes."
This reverts commit
2a53d3314d380af5ab5283758219417c6dfa36e9.
Not the entire commit was reverted, but the deprecation message is
gone. This caused too many problems. See thread
http://www.nntp.perl.org/group/perl.perl5.porters/2012/11/msg195425.html
(which lists previous threads).
Karl Williamson [Sat, 19 Jan 2013 04:58:10 +0000 (21:58 -0700)]
Extend strictness for qr/(?[ \N{} ])/
This recently added regex syntax imposes stricter rules on parsing than
normal. However, this did not include parsing \N{} constructs that
occur within it. This commit does that, making fatal the warnings that
come from \N{}
I will add to perldiag the newly added messages along with the others
for (?[ ]) before 5.18 ships
Chris 'BinGOs' Williams [Sat, 19 Jan 2013 11:35:27 +0000 (11:35 +0000)]
constant-1.25 has been released to CPAN
James E Keenan [Sat, 19 Jan 2013 02:15:04 +0000 (21:15 -0500)]
Remove checks for Perl 5.6; adjust tests; bump version number.
Patch contributed by Sébastien Aperghis-Tramoni
For: RT #114770.
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch blead
# Your branch is ahead of 'origin/blead' by 1 commit.
#
# Changes to be committed:
# (use "git reset HEAD^1 <file>..." to unstage)
#
# modified: dist/constant/lib/constant.pm
# modified: dist/constant/t/constant.t
#
James E Keenan [Tue, 8 Jan 2013 01:55:24 +0000 (20:55 -0500)]
Skip t/io/eintr.t on older Darwins.
Identify the OS version by capturing the first two parts of the M.m.p version
number.
For RT #116262
Chris 'BinGOs' Williams [Fri, 18 Jan 2013 16:54:50 +0000 (16:54 +0000)]
Update Socket to CPAN version 2.009
[DELTA]
2013/01/18
2.009 CHANGES:
* Fix building in core by skipping check_for() as it doesn't work
there (RT82760)
2012/12/27
2.008 CHANGES:
* Fix uninitialised memory read (RT82119)
2012/12/16
2.007 CHANGES:
* Test %Config keys for definedness, not mere existence (RT79854)
* Fix missing argument in sprintf in Socket.xs (from perl.git
5d6dfea82e1c4b6, RT82007)
Aaron Crane [Fri, 18 Jan 2013 15:13:34 +0000 (15:13 +0000)]
Update Pod-LaTeX to CPAN version 0.61
Upstream changes:
- Update site vs perl install for perl v5.12 and above
- Issue a deprecation warning if the module is being used in perl 5.17.0 and above.
This module will be removed from perl Core for perl 5.20. (Ricardo Signes)
It will still be available on CPAN.
Daniel Dragan [Thu, 17 Jan 2013 23:38:07 +0000 (18:38 -0500)]
rearrange initializations in S_intuit_more for better code gen
MS VC 2003 in my experiance does not reorder var initializations with
constants to reduce their liveness. This commit attempts to defer
initialization until right before the var is first used. I can't explain
exactly why less instructions or shorter addressing happened since I didnt
record what the asm looked like before. On VC 2003 -O1 -GL, S_intuit_more
was previously 0x4B5 bytes of 32 bit machine code long, after it this
change it is 0x4A3 bytes long. These changes should have no user visible
effect.
The scope of the vars was not reduced to avoid large indentation changes
which would be required under C89 and Perl code formatting policy.
Aaron Crane [Fri, 18 Jan 2013 14:24:13 +0000 (14:24 +0000)]
todo: revisit the super-linear cache
Suggested by Yves.
Ricardo Signes [Wed, 16 Jan 2013 23:40:44 +0000 (18:40 -0500)]
further refinement to EISDIR tests from `perl dir`
1. actually use the EISDIR string, rather than getting it and
not using it; this was a refactoring screw-up
2. don't hardcode the Win32 EACCES error, either, use the same
"$!" mechanism
Ricardo Signes [Wed, 16 Jan 2013 21:17:13 +0000 (16:17 -0500)]
use non-dev version for Safe
Ricardo Signes [Wed, 16 Jan 2013 21:16:39 +0000 (16:16 -0500)]
use non-dev version for IO
Ricardo Signes [Wed, 16 Jan 2013 21:14:51 +0000 (16:14 -0500)]
use non-dev version for I18N::LangTags::List
...and sync with I18N::LangTags
Ricardo Signes [Wed, 16 Jan 2013 21:10:55 +0000 (16:10 -0500)]
bump I18N::Langinfo to a non-dev version
Ricardo Signes [Fri, 18 Jan 2013 03:21:12 +0000 (22:21 -0500)]
tweak the way we mention if.pm
It should be clear even to readers of the documentation in text
format that "if" is a module and not the "if" flow control.
Andy Dougherty [Thu, 17 Jan 2013 15:34:33 +0000 (10:34 -0500)]
Added asserts() to check the arguments to S_copy_little_tm_to_big_TM.
The original version just zeroed dest if src == NULL, but that code path
was never used. (gcc -Os inlined the function and optimized the test
away anyway.)
Daniel Dragan [Thu, 17 Jan 2013 07:52:45 +0000 (02:52 -0500)]
remove an useless null check in S_copy_little_tm_to_big_TM
All callers of S_copy_little_tm_to_big_TM pass a true variable src.
Checking for null is pointless. On Win32 32 bit VC 2003 -O1 -GL,
perl517.dll's .text section went from 0xCO13F to 0xC012F bytes long. It can
be argued that the compiler should have figured this out on its own, but VC
for whatever reason didn't. Also pretty the indenting and align the
assignments. The null check blames to commit
806a119aef .
Karl Williamson [Wed, 16 Jan 2013 22:05:04 +0000 (15:05 -0700)]
utf8.c: Reword a warning message
This follows the suggestion by Aristotle Pagaltzis.