review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

msarett [Tue, 30 Aug 2016 20:51:10 +0000 (13:51 -0700)]

Whitespace change

TBR=djsollen@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2297833003

Review-Url: https://codereview.chromium.org/2297833003

commit | commitdiff | tree

bsalomon [Tue, 30 Aug 2016 19:52:49 +0000 (12:52 -0700)]

Remove SkBitmap::getTexture()
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289313002

Review-Url: https://codereview.chromium.org/2289313002

commit | commitdiff | tree

cblume [Tue, 30 Aug 2016 19:09:23 +0000 (12:09 -0700)]

Store mipmap levels in deferred texture image

This is a follow-up to https://codereview.chromium.org/2115023002/ and
https://codereview.chromium.org/2034933003/ which were reverted due to
an access violation and a memory leak, respectively.

When creating the deferred texture image, detect if using medium / high
quality. If so, generate and store mipmaps in the deferred texture
image.

When creating a texture from that be sure to read it back out.

BUG=578304
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242883004

Review-Url: https://codereview.chromium.org/2242883004

commit | commitdiff | tree

vjiaoblack [Tue, 30 Aug 2016 19:03:37 +0000 (12:03 -0700)]

made raster shadows variance shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2297693002

Review-Url: https://codereview.chromium.org/2297693002

commit | commitdiff | tree

halcanary [Tue, 30 Aug 2016 18:58:52 +0000 (11:58 -0700)]

Revert of SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName. (patchset #3 id:40001 of https://codereview.chromium.org/2258233002/ )

Reason for revert:
forgot to roll sfntly in android!

Original issue's description:
> SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName.
>
> Also, minor code refactoring.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002
>
> Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f

TBR=bungeman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2296683004

commit | commitdiff | tree

halcanary [Tue, 30 Aug 2016 18:58:33 +0000 (11:58 -0700)]

SkTextBlob: Begin implementing Extended TextBlob API

BUG=skia:5434
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084533004

Review-Url: https://codereview.chromium.org/2084533004

commit | commitdiff | tree

rmistry [Tue, 30 Aug 2016 18:50:23 +0000 (11:50 -0700)]

Increase run_benchmarks timeout because the two Chromium page sets can take a while

BUG=skia:5700
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298453002
# Trybots do not exercise this code.
NOTRY=true
TBR=borenet

Review-Url: https://codereview.chromium.org/2298453002

commit | commitdiff | tree

mtklein [Tue, 30 Aug 2016 18:49:24 +0000 (11:49 -0700)]

clean up use of register storage class

This fixes this warning-as-error, so we don't have to stifle it any more:
error: 'register' storage class specifier is deprecated and incompatible with C++1z [-Werror,-Wdeprecated-register]

Tested by building for mipsel via GN.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289293002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2289293002

commit | commitdiff | tree

halcanary [Tue, 30 Aug 2016 18:07:01 +0000 (11:07 -0700)]

SkPDF: SK_SFNTLY_SUBSETTER is gone

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2296823002

Review-Url: https://codereview.chromium.org/2296823002

commit | commitdiff | tree

mtklein [Tue, 30 Aug 2016 17:45:17 +0000 (10:45 -0700)]

Detect TSAN instead of relying on #ifdef THREAD_SANITIZER.

And reindent.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293063002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot

Review-Url: https://codereview.chromium.org/2293063002

commit | commitdiff | tree

halcanary [Tue, 30 Aug 2016 17:43:48 +0000 (10:43 -0700)]

SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName.

Also, minor code refactoring.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002

Review-Url: https://codereview.chromium.org/2258233002

commit | commitdiff | tree

mtklein [Tue, 30 Aug 2016 17:37:19 +0000 (10:37 -0700)]

GN: add sksl

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2296803002

Review-Url: https://codereview.chromium.org/2296803002

commit | commitdiff | tree

bsalomon [Tue, 30 Aug 2016 17:27:20 +0000 (10:27 -0700)]

Remove unneeded variables from ResourceCache test
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2295883002

Review-Url: https://codereview.chromium.org/2295883002

commit | commitdiff | tree

bsalomon [Tue, 30 Aug 2016 16:42:29 +0000 (09:42 -0700)]

Remove custom data from GrGpuResource

Chrome is no longer relying on this feature to track mailboxes for textures.

BUG=skia:4134

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2291203002

Review-Url: https://codereview.chromium.org/2291203002

commit | commitdiff | tree

ethannicholas [Tue, 30 Aug 2016 14:26:58 +0000 (07:26 -0700)]

changed kCurveConnectionThreshold in GrAAConvexTessellator
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2297563003
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2297563003

commit | commitdiff | tree

vjiaoblack [Tue, 30 Aug 2016 14:13:04 +0000 (07:13 -0700)]

raster shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248493002

Review-Url: https://codereview.chromium.org/2248493002

commit | commitdiff | tree

brianosman [Tue, 30 Aug 2016 14:08:07 +0000 (07:08 -0700)]

Improve the gamma GM significantly

- Switch to portable typeface, to avoid per-platform diffs in the labels
- Stretch out the image slightly, to avoid overlap with larger font
- Fix several tests that were no longer matching ground-truth. We treat
  SkColor as sRGB, so 0x7F is incorrect, for example. Several of the
  XferMode tests had similar math errors now. Computed new values, and
  verified that they work as expected.
- Removed a couple tests that were mixing color and alpha in funny ways

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288053003

Review-Url: https://codereview.chromium.org/2288053003

commit | commitdiff | tree

brianosman [Tue, 30 Aug 2016 14:07:59 +0000 (07:07 -0700)]

Some tests around surface creation and snapshotting with color space

Verify the rules that we're converging on for surfaces:
- For 8888, we only support sRGB-like gamma, or no color space at all.
- For F16, we require a color space, with linear gamma.
- For all other formats, we do not support color spaces.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2270823002

Review-Url: https://codereview.chromium.org/2270823002

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 23:01:10 +0000 (16:01 -0700)]

Disable sktexttopdf when building for mipsel.

The Clang in the latest NDK crashes when we try to build it for MIPS.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286303004

Review-Url: https://codereview.chromium.org/2286303004

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 22:22:10 +0000 (15:22 -0700)]

GN: fontmgr_android

Should be enough to run parser tests on Linux.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2291863002

Review-Url: https://codereview.chromium.org/2291863002

commit | commitdiff | tree

msarett [Mon, 29 Aug 2016 21:52:24 +0000 (14:52 -0700)]

Skip spinlock overhead on Android

Using the spinlock is only necessary when we multiple threads
might use a GrContext. Android uses the GrContext from a
single thread, so these locks are not needed.

This is a temporary fix until we can refactor to avoid
creating GrContexts in a global memory pool.

BUG=skia:5696
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293633003

Review-Url: https://codereview.chromium.org/2293633003

commit | commitdiff | tree

msarett [Mon, 29 Aug 2016 21:47:49 +0000 (14:47 -0700)]

Add Gray support to SkPNGImageEncoder

BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290843002

Review-Url: https://codereview.chromium.org/2290843002

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 21:27:15 +0000 (14:27 -0700)]

remove dead code

TBR=

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286253003

Review-Url: https://codereview.chromium.org/2286253003

commit | commitdiff | tree

jvanverth [Mon, 29 Aug 2016 20:50:07 +0000 (13:50 -0700)]

Fix stroked rrects with batching.

Was using stroked shader for fills and vice versa.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288923002
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2288923002

commit | commitdiff | tree

egdaniel [Mon, 29 Aug 2016 20:42:55 +0000 (13:42 -0700)]

Remove unneeded pipeline barrier in vulkan

We don't need to syncronize the mapped memory writes to the buffer since
all CPU writes are already syncronized when we submit a command buffer. And we are using coherent memory for buffers so we don't need to call vkFlushMappedMemory

BUG=skia:

Review-Url: https://codereview.chromium.org/2289973002

commit | commitdiff | tree

jcgregorio [Mon, 29 Aug 2016 20:33:04 +0000 (13:33 -0700)]

benchmarks: Avoid brackets and commas in test names.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2295483002

Review-Url: https://codereview.chromium.org/2295483002

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 20:26:14 +0000 (13:26 -0700)]

GN: ft and fc as optionals

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292613002

Review-Url: https://codereview.chromium.org/2292613002

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 20:14:55 +0000 (13:14 -0700)]

add gn_android_flavor

This ought to support compiles for now.

Am I picking up my CIPD ndk packages right?

The main thing to note is that I'm passing the target_arch directly through
as target_cpu.  This means these bots will have a slightly different naming
convention than we've been using, but it'll agree with what you must type
yourself when using GN to build for Android:

  - Arm7 -> arm
  - Arm64 -> arm64
  - Mips -> mipsel
  - Mips64 -> mips64el
  - x86 -> x86 (unchanged)
  - x86_64 -> x64

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292663002

Review-Url: https://codereview.chromium.org/2292663002

commit | commitdiff | tree

bsalomon [Mon, 29 Aug 2016 19:43:27 +0000 (12:43 -0700)]

Skip batch iteration in GrDrawTarget::forwardCombine when the max look ahead is 0

TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288373002

Review-Url: https://codereview.chromium.org/2288373002

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 17:27:16 +0000 (10:27 -0700)]

Add docs for GN/Android

While I'm at it, add a few more examples of other types of builds you can do.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289883002
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2289883002

Review-Url: https://codereview.chromium.org/2289883002

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 17:23:15 +0000 (10:23 -0700)]

GN: release -> -O3, to match GYP

-O3 does trigger some important compiler optimizations that -Os does not,
like autovectorization.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288813002

Review-Url: https://codereview.chromium.org/2288813002

commit | commitdiff | tree

vjiaoblack [Mon, 29 Aug 2016 17:22:09 +0000 (10:22 -0700)]

Moved ambient lights out of SkLight's light array

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002

Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686
Review-Url: https://codereview.chromium.org/2287553002

commit | commitdiff | tree

jvanverth [Mon, 29 Aug 2016 17:16:40 +0000 (10:16 -0700)]

Batch all circular rrects together

When possible, this change will place all circular rrect
types in the same batch. If the batch is all fills, we
use the fill shader, otherwise we use the stroke shader.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283973002

Review-Url: https://codereview.chromium.org/2283973002

commit | commitdiff | tree

halcanary [Mon, 29 Aug 2016 16:47:48 +0000 (09:47 -0700)]

SkPDF: Remove some unused glyphs from fallback fonts

This makes the /Widths and the /Differences arrays smaller.

Example diff in output PDF (lines are wrapped for easy viewing):

<</Type /Font
/Subtype /Type3
/FontMatrix [.00100000005 0 0 -.00100000005 0 0]
/FirstChar 0
-/LastChar 255
+/LastChar 118
/FontBBox [23 228 669 -694]
/CIDToGIDMap /Identity
/ToUnicode 8 0 R
-/Widths [280 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
-525 0 0 0 525 0 0 0 0 525 525 525 525 0 0 0 0 0 0 525 0 0 0 0 0 0 0 0
-0 0 0 0 0 525 0 525 0 0 0 525 0 0 0 0 0 0 0 0 0 0 0 525 0 0 0 0 0 0
-525 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 525 0 0 0 0 0 0 0 525
-0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
-0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
-0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
-0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
+/Widths [280 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
+525 0 0 0 525 0 0 0 0 525 525 525 525 0 0 0 0 0 0 525 0 0 0 0 0 0 0 0
+0 0 0 0 0 525 0 525 0 0 0 525 0 0 0 0 0 0 0 0 0 0 0 525 0 0 0 0 0 0
+525 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 525 0 0 0 0 0 0 0
+525]
/Encoding <</Type /Encoding
-/Differences [0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g1D
-/g0 /g0 /g0 /g21 /g0 /g0 /g0 /g0 /g26 /g27 /g28 /g29 /g0 /g0 /g0 /g0
-/g0 /g0 /g30 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g3E
-/g0 /g40 /g0 /g0 /g0 /g44 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g50 /g0 /g0 /g0 /g0 /g0 /g0 /g57 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g6E /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g76 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
-/g0 /g0 /g0 /g0 /g0 /g0]>>
+/Differences [0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
+/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g1D
+/g0 /g0 /g0 /g21 /g0 /g0 /g0 /g0 /g26 /g27 /g28 /g29 /g0 /g0 /g0 /g0
+/g0 /g0 /g30 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g3E
+/g0 /g40 /g0 /g0 /g0 /g44 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
+/g50 /g0 /g0 /g0 /g0 /g0 /g0 /g57 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0
+/g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g0 /g6E /g0 /g0 /g0
+/g0 /g0 /g0 /g0 /g76]>>
/CharProcs <</g0 9 0 R
/g1D 10 0 R
/g21 11 0 R
.......

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287393002

Review-Url: https://codereview.chromium.org/2287393002

commit | commitdiff | tree

bsalomon [Mon, 29 Aug 2016 16:18:39 +0000 (09:18 -0700)]

Add support for glDrawRangeElements
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287003002

Review-Url: https://codereview.chromium.org/2287003002

commit | commitdiff | tree

msarett [Mon, 29 Aug 2016 16:15:33 +0000 (09:15 -0700)]

Add width, height, unique ID, alpha to debugger DrawImageCommand

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290683002

Review-Url: https://codereview.chromium.org/2290683002

commit | commitdiff | tree

vjiaoblack [Mon, 29 Aug 2016 15:38:04 +0000 (08:38 -0700)]

Revert of Moved ambient lights out of SkLight's light array (patchset #7 id:120001 of https://codereview.chromium.org/2287553002/ )

Reason for revert:
Made Deigo's GM miss their ambient lights

Original issue's description:
> Moved ambient lights out of SkLight's light array
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002
>
> Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686

TBR=robertphillips@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2291663002

commit | commitdiff | tree

rmistry [Mon, 29 Aug 2016 15:13:29 +0000 (08:13 -0700)]

Add Gerrit API support to Skia's PRESUBMIT.py

Also skip post upload hooks for Gerrit.

BUG=skia:5674
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281123002

Review-Url: https://codereview.chromium.org/2281123002

commit | commitdiff | tree

reed [Mon, 29 Aug 2016 14:52:13 +0000 (07:52 -0700)]

dedup images/blobs/pictures by ID in old serialization format

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289783002

Review-Url: https://codereview.chromium.org/2289783002

commit | commitdiff | tree

Ravi Mistry [Mon, 29 Aug 2016 13:33:03 +0000 (09:33 -0400)]

Whitespace change to test Gerrit Submit

BUG=skia:5680

Change-Id: I4778f44d150ed4ba937a89b4e639c8ca33a24fea
Reviewed-on: https://skia-review.googlesource.com/2142
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

commit | commitdiff | tree

jvanverth [Mon, 29 Aug 2016 14:17:47 +0000 (07:17 -0700)]

Use stroked rrects for Android shadow sample

Changes the Android shadow sample to use stroked roundrects when
we can (mainly if stroked geometry area < fill geometry area).

Also changes the setup for the overstroke geometry so that it computes
the correct distance to the outer edge.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283003003

Review-Url: https://codereview.chromium.org/2283003003

commit | commitdiff | tree

mtklein [Mon, 29 Aug 2016 14:14:28 +0000 (07:14 -0700)]

Roll GN

This picks up https://chromium.googlesource.com/chromium/src/tools/gn/+/efc976e5029419fde92111ce52f913c61fb9553c, which means we don't need to create a link_pool any more. The default behavior is unlimited linking, what we were asking for explicitly.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288253002

Review-Url: https://codereview.chromium.org/2288253002

commit | commitdiff | tree

vjiaoblack [Mon, 29 Aug 2016 14:08:52 +0000 (07:08 -0700)]

Moved ambient lights out of SkLight's light array

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002

Review-Url: https://codereview.chromium.org/2287553002

commit | commitdiff | tree

reed [Mon, 29 Aug 2016 13:57:28 +0000 (06:57 -0700)]

change readTypeface to return sk_sp

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290653002

TBR=mtklein

Review-Url: https://codereview.chromium.org/2290653002

commit | commitdiff | tree

brianosman [Mon, 29 Aug 2016 13:46:07 +0000 (06:46 -0700)]

Remove FP16 support from ANGLE. Previous workaround was incomplete.

ANGLE is using the wrong external type (GL_HALF_FLOAT) when querying for
ReadPixels format, but it validates parameters to TexImage2D against the
correct type (GL_HALF_FLOAT_OES). Rather than introduce a lot of
complexity to work around the inconsistency, I'm just going to remove
support for now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288233002

Review-Url: https://codereview.chromium.org/2288233002

commit | commitdiff | tree

fmalita [Mon, 29 Aug 2016 12:54:42 +0000 (05:54 -0700)]

[SVGDom] Don't truncate opacity scalars

Round instead, for more accurate values.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2284123003

Review-Url: https://codereview.chromium.org/2284123003

commit | commitdiff | tree

update-skps [Sun, 28 Aug 2016 08:53:34 +0000 (01:53 -0700)]

Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286143002

Review-Url: https://codereview.chromium.org/2286143002

commit | commitdiff | tree

mtklein [Sat, 27 Aug 2016 13:50:11 +0000 (06:50 -0700)]

cleanup dead nanomsg and build_overrides

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287013003
TBR=

Review-Url: https://codereview.chromium.org/2287013003

commit | commitdiff | tree

caryclark [Fri, 26 Aug 2016 21:24:24 +0000 (14:24 -0700)]

if the winding of the top can't be computed, give up

TBR=reed@google.com
BUG=641478
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2283993002

Review-Url: https://codereview.chromium.org/2283993002

commit | commitdiff | tree

mtklein [Fri, 26 Aug 2016 20:43:19 +0000 (13:43 -0700)]

GN: support compiler_prefix, use it for ccache on bots.

This makes it considerably easier to use ccache with the Android NDK.
You can now just set
compiler_prefix = "ccache"
ndk = "/path/to/ndk"
and we'll use the NDK clang, wrapped with ccache.

The name compiler_prefix is stolen from / compatible with Chrome.

If you have ccache, you can just always leave compiler_prefix="ccache" enabled.
This should make it an unusual thing for humans to have to change cc or cxx.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281163002

Review-Url: https://codereview.chromium.org/2281163002

commit | commitdiff | tree

halcanary [Fri, 26 Aug 2016 20:17:44 +0000 (13:17 -0700)]

SkPDF: Glyph validation change

Instead of mapping invaid glyphIDs to zero or maxGlyphID,
don't draw them at all.

Validate glyphs when glyph is written, not ahead of time.

Don't allocate array to copy user-provided glyphs.

Easy early exit from SkPDFDevice::internalDrawText()
    GlyphPositioner::flush() called ~GlyphPositioner()
    SkScopeExit class now exists.

Assume SkTypeface* pointers are now never null in more
places.

precalculate alignmentFactor to clean up code.

SkPDFDevice::updateFont must be called with validated
glyphID.  Skip bad glyphs to make this true.

SkPDFDevice::updateFont always succeeds.

SkPDFFont::GetFontResource always succeeds (preconditions are
asserted).  If GetMetrics fails, don't call GetFontResource.

SkPDFFont::glyphsToPDFFontEncodingCount() becomes
SkPDFFont::countStretch() and is inlined.

SkPDFFont::glyphsToPDFFontEncoding now works one Glyph at a
time and is inlined.

SkPDFFont::noteGlyphUsage() operates one glyph at a time.

Add SkScopeExit.h; also a unit test for it.

SkPostConfig: Fix SK_UNUSED for Win32.

No public API changes.
TBR=reed@google.com

BUG=625995

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278703002

Review-Url: https://codereview.chromium.org/2278703002

commit | commitdiff | tree

fmalita [Fri, 26 Aug 2016 20:04:14 +0000 (13:04 -0700)]

drawBitmapRect() should not touch the CTM when mask filters are present

Blur sigma calculations are CTM dependent, so we cannot take the
drawBitmap() fast path in the presence of mask filters.

BUG=skia:5682
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286873002

Review-Url: https://codereview.chromium.org/2286873002

commit | commitdiff | tree

msarett [Fri, 26 Aug 2016 19:49:27 +0000 (12:49 -0700)]

Reduce CPU overhead on drawRegion()

Only batch when the view matrices are the same.

This allows us to skip applying the matrix and uploading
local coords.

drawregion Bench on Nexus 6P:
Before 4.69ms
After 2.83ms

This puts SkiaGL nearly on par with OpenGL.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282983003

Review-Url: https://codereview.chromium.org/2282983003

commit | commitdiff | tree

brianosman [Fri, 26 Aug 2016 19:33:58 +0000 (12:33 -0700)]

Fix angle build on Ubuntu

Review-Url: https://codereview.chromium.org/2284753003

commit | commitdiff | tree

bungeman [Fri, 26 Aug 2016 19:15:54 +0000 (12:15 -0700)]

Expat target exports includes instead of FreeType.

Currently when building for Android framework the freetype target
exports the expat include directory, but the freetype target neither
uses nor logically provides this information. Instead, the expat target
itself should do this.

Review-Url: https://codereview.chromium.org/2283903003

commit | commitdiff | tree

mtklein [Fri, 26 Aug 2016 18:22:54 +0000 (11:22 -0700)]

Add Mac NDK asset, and fetch NDK on Android compile bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2284813002

Review-Url: https://codereview.chromium.org/2284813002

commit | commitdiff | tree

egdaniel [Fri, 26 Aug 2016 18:05:13 +0000 (11:05 -0700)]

Don't add the resolve attachment to vulkan render passes.

Also includes some other msaa bug fixes

BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843002

Review-Url: https://codereview.chromium.org/2256843002

commit | commitdiff | tree

ethannicholas [Fri, 26 Aug 2016 18:03:32 +0000 (11:03 -0700)]

fixed 'corners' of paths in GrAAConvexTessellator

BUG=skia:5671
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2280943003

Review-Url: https://codereview.chromium.org/2280943003

commit | commitdiff | tree

mtklein [Fri, 26 Aug 2016 17:52:19 +0000 (10:52 -0700)]

add an asset for the Linux Android NDK.

I have run create_and_upload.py... cipd is uploading now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275093003

Review-Url: https://codereview.chromium.org/2275093003

commit | commitdiff | tree

bsalomon [Fri, 26 Aug 2016 17:48:19 +0000 (10:48 -0700)]

Converts a drawPaint through a rrect clip to a drawRRect in GrDrawContext.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271053004

Review-Url: https://codereview.chromium.org/2271053004

commit | commitdiff | tree

brianosman [Fri, 26 Aug 2016 17:37:57 +0000 (10:37 -0700)]

Update ANGLE to latest as of August 25, 2016

With this version, it's now exposing GL_EXT_color_buffer_half_float, but
it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES.
In addition, release builds were crashing in EGLImageTest due to an
apparent disagreement about calling convention on function-pointer to
exported symbol. There is a proper typedef for that in one of their
headers, but I can't seem to include it without creating more problems,
so I just fixed the decoration on our local typedef.

With those changes, all tests pass, and (on my Windows machine), all
GMs and SKPs produce identical results vs. master in angle and angle-gl.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003

Review-Url: https://codereview.chromium.org/2282733003

commit | commitdiff | tree

fmalita [Fri, 26 Aug 2016 17:23:43 +0000 (10:23 -0700)]

Remove SVG serialization suppressions

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282883002

Review-Url: https://codereview.chromium.org/2282883002

commit | commitdiff | tree

fmalita [Fri, 26 Aug 2016 17:13:39 +0000 (10:13 -0700)]

Add imagemasksubset GM

(GM for non-N32 SkImage subsetting)

BUG=skia:5687
R=bsalomon@google.com,robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286733002

Review-Url: https://codereview.chromium.org/2286733002

commit | commitdiff | tree

drott [Fri, 26 Aug 2016 17:08:45 +0000 (10:08 -0700)]

Restrict supported font formats in Chrome context

Chrome's complex text path uses HarfBuzz OpenType glyph lookup
functions. These do not support glyph lookup in Type 1 / Postscript
fonts and we do not wish to support those in Chrome any longer.

In order to avoid matching fonts against Type 1 fonts possible present
on Linux installations and exposed through fontconfig, this CL filters
those out in Skia's font matching code.

This change might not be desirable for all context in which Skia is
used, hence making it conditional on a Chrome context define.

BUG=skia:5685
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2280053002

Review-Url: https://codereview.chromium.org/2280053002

commit | commitdiff | tree

robertphillips [Fri, 26 Aug 2016 17:04:26 +0000 (10:04 -0700)]

Move work from ctor to onOnceBeforeDraw in ShowMipLevel GMs

These were making debugging stroking more difficult than necessary

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2285813002

Review-Url: https://codereview.chromium.org/2285813002

commit | commitdiff | tree

caryclark [Fri, 26 Aug 2016 16:54:25 +0000 (09:54 -0700)]

avoid generating degenerate conic from arc

R=bsalomon@google.com
BUG=skia:5672
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281953002

Review-Url: https://codereview.chromium.org/2281953002

commit | commitdiff | tree

vjiaoblack [Fri, 26 Aug 2016 15:49:46 +0000 (08:49 -0700)]

Added distance attenuation and diffuse shading to PointLights

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246463004

Review-Url: https://codereview.chromium.org/2246463004

commit | commitdiff | tree

jvanverth [Fri, 26 Aug 2016 15:15:33 +0000 (08:15 -0700)]

Fix for fat stroked roundrects.

The original method did not correctly compute the distance value along
the inner edge, so the antialiasing was not quite correct. This fixes
that by adding additional vertices and setting a different outerRadius.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275423002

Review-Url: https://codereview.chromium.org/2275423002

commit | commitdiff | tree

mtklein [Fri, 26 Aug 2016 15:13:04 +0000 (08:13 -0700)]

GN: mac host and armv7 target

Just when I thought it wouldn't be useful to override ar...

Tested by building 32- and 64-bit DM on my MBP and running it on my N5x.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2279703003

Review-Url: https://codereview.chromium.org/2279703003

commit | commitdiff | tree

bungeman [Fri, 26 Aug 2016 14:15:50 +0000 (07:15 -0700)]

SkOSFile instead of dirent in android font parser.

This makes the parser more portable while making essentially the same
file system calls on Android.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2279033004

Review-Url: https://codereview.chromium.org/2279033004

commit | commitdiff | tree

bsalomon [Fri, 26 Aug 2016 13:45:06 +0000 (06:45 -0700)]

Fix bounds check in grshape test
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274113004

Review-Url: https://codereview.chromium.org/2274113004

commit | commitdiff | tree

msarett [Fri, 26 Aug 2016 13:37:45 +0000 (06:37 -0700)]

drawRegion() cleanups

(1) Move implementation to the cpp.
(2) Check for the isRect() case.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2286693002

Review-Url: https://codereview.chromium.org/2286693002

commit | commitdiff | tree

robertphillips [Fri, 26 Aug 2016 12:30:19 +0000 (05:30 -0700)]

Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and fill path remaining convex. There seems to be an issue with round joins where the outer generated shell is usually not convex. Without this CL the resulting stroke & filled paths are always concave.

Perf-wise (on Windows):

convex-lineonly-paths-stroke-and-fill bench

(in ms)   w/o   w/CL    %decrease

8888      2.88  2.01      30.2

gpu       4.4   1.38      68.6

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003

Review-Url: https://codereview.chromium.org/2275243003

commit | commitdiff | tree

msarett [Fri, 26 Aug 2016 01:07:18 +0000 (18:07 -0700)]

GPU implementation of drawRegion()

Nexus 6P drawregion Bench Performance
Before 48.0ms
After 3.57ms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267273006

Review-Url: https://codereview.chromium.org/2267273006

commit | commitdiff | tree

mtklein [Thu, 25 Aug 2016 21:50:44 +0000 (14:50 -0700)]

GN: Android

Once you have downloaded an android NDK, you can set the ndk GN arg to use it.
E.g. my gn.args looks like:
  is_debug = false
  ndk = "/opt/android-ndk"

This should be enough to get you going for an arm64 build.  You ought to be able to tweak that to other architectures by changing target_cpu to "arm", "x86", "x86-64", etc.  That won't quite work until I follow this up a bit, but the skeleton is there.

This is enough to get me compiled, linked, and running to completion on my N5x.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275983004

Review-Url: https://codereview.chromium.org/2275983004

commit | commitdiff | tree

msarett [Thu, 25 Aug 2016 20:54:30 +0000 (13:54 -0700)]

Add drawRegion() API to SkCanvas

This will allow us to optimize for the RectGrid macrobench.
Currently, SkiaGL is much slower than OpenGL.
SkiaGL 12 items/s
OpenGL 160 items/s

This contains everything except for the fast implementation on GPU.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277053002

Review-Url: https://codereview.chromium.org/2277053002

commit | commitdiff | tree

egdaniel [Thu, 25 Aug 2016 20:52:00 +0000 (13:52 -0700)]

Add support for getting vulkan descriptor sets without a GrVkUniformHandler.

This change allows us to use the current descriptor set system for doing
copies as draws. This is a step towards being able to track resources for draws
that don't go through out normal pipeline.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275633002

Review-Url: https://codereview.chromium.org/2275633002

commit | commitdiff | tree

liyuqian [Thu, 25 Aug 2016 20:14:54 +0000 (13:14 -0700)]

Do not spam the debugging information

Currently, whenever there's a frame being rendered, we log such an
invalidation event. This is very spammy for animations or frame rates
test.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276303003

Review-Url: https://codereview.chromium.org/2276303003

commit | commitdiff | tree

bsalomon [Thu, 25 Aug 2016 19:29:23 +0000 (12:29 -0700)]

Respecify SkCanvas::drawArc, consolidate conversion to SkPath, add GM for oddball drawArcs

Allows the arc to wind more than 360 degrees when useCenter is true, specs that nothing draws
if the oval is empty or the sweep angle is 0.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281653002

Review-Url: https://codereview.chromium.org/2281653002

commit | commitdiff | tree

caryclark [Thu, 25 Aug 2016 18:27:17 +0000 (11:27 -0700)]

path ops stream-lining

The addT() function is a workhorse of pathops.
Make it simpler, removing branches and parameters.

Separate addOpp() into const and modify parts.

Add more debugging that asserts if the function
fails and the data is not extreme (e.g., fuzzer
generated).

TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273293004

Review-Url: https://codereview.chromium.org/2273293004

commit | commitdiff | tree

halcanary [Thu, 25 Aug 2016 18:10:41 +0000 (11:10 -0700)]

SkDrawCommand: hinting

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274373003

Review-Url: https://codereview.chromium.org/2274373003

commit | commitdiff | tree

jcgregorio [Thu, 25 Aug 2016 16:25:11 +0000 (09:25 -0700)]

BUILD.gn: Fix fiddle raster.

BUG=skia:

Review-Url: https://codereview.chromium.org/2269143007

commit | commitdiff | tree

halcanary [Thu, 25 Aug 2016 16:07:02 +0000 (09:07 -0700)]

SkPDF: Stop `#include PREPROCESSOR_DEFINE` pattern

No more:
#include SK_SFNTLY_SUBSETTER
#include ZLIB_INCLUDE

Also, rename SK_SFNTLY_SUBSETTER to SK_PDF_USE_SFNTLY
to follow my pattern of prefixing SkPDF-specific defines
with 'SK_PDF_'.

The ZLIB_INCLUDE define is no longer is used by anyone.

TODO: rename Sfntly to something pronounceable.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273343002

Review-Url: https://codereview.chromium.org/2273343002

commit | commitdiff | tree

brianosman [Thu, 25 Aug 2016 15:55:24 +0000 (08:55 -0700)]

Remove pixel config fallback - failing is a better option.

This produces surprising results in some cases. For example: Attempt to
make an F16 SkSurface on ANGLE. We can't render to F16, but this succeeds
and gives you back an N32 surface instead. Ran all tests and GMs in DM on
ANGLE (where this is most likely to be an issue). No problems.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272423004

Review-Url: https://codereview.chromium.org/2272423004

commit | commitdiff | tree

mtklein [Thu, 25 Aug 2016 15:44:49 +0000 (08:44 -0700)]

update Android auto-detection.

Clang defines __ANDROID__

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278483004

No public API changes.
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2278483004

commit | commitdiff | tree

fmalita [Thu, 25 Aug 2016 15:44:35 +0000 (08:44 -0700)]

Reland: Experimental parsing expression grammar (PEG) template library

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002

Committed: https://skia.googlesource.com/skia/+/9d08cbc8c6131ff61a1e71cc5c8cf27841d62b42
Review-Url: https://codereview.chromium.org/2271743002

commit | commitdiff | tree

jvanverth [Thu, 25 Aug 2016 15:12:35 +0000 (08:12 -0700)]

Add Ganesh support for circular roundrects with strokes > 2*radii.

Overstroked rrects are supported by adding additional geometry to the
center of the nine patch, and setting constant offset vectors to fake
out the distance calculation.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272703004

Review-Url: https://codereview.chromium.org/2272703004

commit | commitdiff | tree

bsalomon [Thu, 25 Aug 2016 13:45:29 +0000 (06:45 -0700)]

Make bleed GM produce consistent bitmaps on all platforms
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264133003

Review-Url: https://codereview.chromium.org/2264133003

commit | commitdiff | tree

vjiaoblack [Thu, 25 Aug 2016 13:30:23 +0000 (06:30 -0700)]

Made shadows blurry (thru implementing variance mapping)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224163005

Review-Url: https://codereview.chromium.org/2224163005

commit | commitdiff | tree

hcm [Thu, 25 Aug 2016 13:19:30 +0000 (06:19 -0700)]

Update Skia milestone to 55

TBR=reed@google.com

No API changes, just moving version fwd.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281533002

Review-Url: https://codereview.chromium.org/2281533002

commit | commitdiff | tree

jvanverth [Thu, 25 Aug 2016 12:53:00 +0000 (05:53 -0700)]

Add fat stroke test case to roundrects GM.

Prep for supporting fat stroked roundrects in Ganesh.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272703009

Review-Url: https://codereview.chromium.org/2272703009

commit | commitdiff | tree

fmalita [Thu, 25 Aug 2016 12:50:26 +0000 (05:50 -0700)]

Revert of Experimental parsing expression grammar (PEG) template library (patchset #8 id:140001 of https://codereview.chromium.org/2271743002/ )

Reason for revert:
G3 roll & Msan woes.

Original issue's description:
> Experimental parsing expression grammar (PEG) template library
>
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002
>
> Committed: https://skia.googlesource.com/skia/+/9d08cbc8c6131ff61a1e71cc5c8cf27841d62b42

TBR=mtklein@google.com,bungeman@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2275943004

commit | commitdiff | tree

caryclark [Thu, 25 Aug 2016 12:21:14 +0000 (05:21 -0700)]

add pathops debugging

Pathops has many points of failure, most of which
are triggered by extreme data generated by fuzzers.
It's difficult to figure out which failure point
was triggered when the operation gives up.

Add instrumentation so that the failure can
be debugged when the data is well-behaved.

Also, add a check that looks for a sequence of
coincident points on multiple edges that are out
of order when compared to each other.

TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274803003

Review-Url: https://codereview.chromium.org/2274803003

commit | commitdiff | tree

anmittal [Thu, 25 Aug 2016 11:55:19 +0000 (04:55 -0700)]

Add neon and crc32 sources for aarch64

This fixes the build for aarch64 arch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272243003

Review-Url: https://codereview.chromium.org/2272243003

commit | commitdiff | tree

fmalita [Thu, 25 Aug 2016 01:23:24 +0000 (18:23 -0700)]

Experimental parsing expression grammar (PEG) template library

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002

Review-Url: https://codereview.chromium.org/2271743002

commit | commitdiff | tree

bsalomon [Thu, 25 Aug 2016 00:47:40 +0000 (17:47 -0700)]

Update GrShape test to allow more flexible shape creation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002

Review-Url: https://codereview.chromium.org/2277483002

commit | commitdiff | tree

mtklein [Thu, 25 Aug 2016 00:32:30 +0000 (17:32 -0700)]

GN: misc

  - Use options' template pattern for opts too.
  - Simplify opt's and options' configs... they should all be the same.
  - When building a static-library component in our GN environment (i.e. libskia.a),
    make it a complete static lib, fully containing its transitive deps.
  - It has not proved useful to override ar.

TBR=jcgregorio@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278673002

Review-Url: https://codereview.chromium.org/2278673002

commit | commitdiff | tree

mtklein [Wed, 24 Aug 2016 21:46:35 +0000 (14:46 -0700)]

We can't infer the right type for voidp for old png_jmpbuf()

In libpng 1.2 it's just a macro that's ->jmpbuf,
so there's nothing forcing the conversion to png_structp.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268953005

Review-Url: https://codereview.chromium.org/2268953005

commit | commitdiff | tree

halcanary [Wed, 24 Aug 2016 21:42:08 +0000 (14:42 -0700)]

SkPDF: set SK_SFNTLY_SUBSETTER uniformly

When Skia is built into the Android framework,
SK_SFNTLY_SUBSETTER="sample/chromium/font_subsetter.h".
This #includes the same value for GOOGLE3.

Once Chrome is also using this value, we can do away with
the `#ifdef GOOGLE3` line.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2272103002

Review-Url: https://codereview.chromium.org/2272103002

commit | commitdiff | tree

caryclark [Wed, 24 Aug 2016 20:00:42 +0000 (13:00 -0700)]

mark fuzz test flaky since it may fail on some platforms

NOTRY=true
TBR=bungeman@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277893004

Review-Url: https://codereview.chromium.org/2277893004

Domain: Dotnet / API;

RSS Atom