GDB Administrator [Sun, 2 Dec 2018 00:02:20 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 1 Dec 2018 00:02:00 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 30 Nov 2018 00:01:59 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 29 Nov 2018 00:01:44 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 28 Nov 2018 00:01:49 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 27 Nov 2018 00:01:30 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 26 Nov 2018 00:01:38 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 25 Nov 2018 00:02:18 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 24 Nov 2018 00:01:17 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 23 Nov 2018 00:01:47 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 22 Nov 2018 00:01:48 +0000 (00:01 +0000)]
Automatic date update in version.in
Benno Fünfstück [Wed, 21 Nov 2018 17:16:25 +0000 (17:16 +0000)]
Make command-repeat work after gdb.execute
Since commit
56bcdbea2bed ("Let gdb.execute handle multi-line commands")
command repetition after using the `gdb.execute` Python function
fails (the previous command is not repeated anymore). This happens
because read_command_lines_1 sets dont_repeat, but the call to
prevent_dont_repeat in execute_gdb_command is later.
The fix is to move the call to prevent_dont_repeat to the beginning of
the function.
Tested on my laptop (ArchLinux-x86_64).
gdb/ChangeLog:
PR python/23714
* gdb/python/python.c (execute_gdb_command): Call
prevent_dont_repeat earlier to avoid affecting dont_repeat.
gdb/testuite/ChangeLog:
PR python/23714
* gdb.python/python.exp: Test command repetition after
gdb.execute.
GDB Administrator [Wed, 21 Nov 2018 00:01:50 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 20 Nov 2018 00:01:53 +0000 (00:01 +0000)]
Automatic date update in version.in
Pedro Alves [Mon, 19 Nov 2018 15:08:46 +0000 (15:08 +0000)]
gdb.base/warning.exp tweaks
#1- Check that the warning is emitted.
#2- Avoid overriding INTERNAL_GDBFLAGS, as per documentated in
gdb/testsuite/README:
~~~
The testsuite does not override a value provided by the user.
~~~
We don't actually need to tweak INTERNAL_GDBFLAGS, we just need to
append out -data-directory to GDBFLAGS, because each passed
-data-directory option leads to a call to the warning:
$ ./gdb -data-directory=foo -data-directory=bar
Warning: foo: No such file or directory.
Warning: bar: No such file or directory.
[...]
2018-11-19 Pedro Alves <palves@redhat.com>
* gdb.base/warning.exp: Don't override INTERNAL_FLAGS. Use
gdb_spawn_with_cmdline_opts instead of gdb_start. Check that we
see the expected warning.
Tom Tromey [Fri, 5 Oct 2018 20:54:35 +0000 (14:54 -0600)]
Avoid crash when calling warning too early
I noticed that if you pass the name of an existing file (not a
directory) as the argument to --data-directory, gdb will crash:
$ ./gdb -nx --data-directory ./gdb
../../binutils-gdb/gdb/target.c:590:56: runtime error: member call on null pointer of type 'struct target_ops'
This was later reported as PR gdb/23838.
This happens because warning ends up calling
target_supports_terminal_ours, which calls current_top_target, which
returns nullptr this early.
This fixes the problem by handling this case specially in
target_supports_terminal_ours. I also changed
target_supports_terminal_ours to return bool.
2018-11-08 Tom Tromey <tom@tromey.com>
PR gdb/23555:
PR gdb/23838:
* target.h (target_supports_terminal_ours): Return bool.
* target.c (target_supports_terminal_ours): Handle case where
current_top_target returns nullptr. Return bool.
gdb/testsuite/ChangeLog
2018-11-08 Tom Tromey <tom@tromey.com>
PR gdb/23555:
PR gdb/23838:
* gdb.base/warning.exp: New file.
GDB Administrator [Mon, 19 Nov 2018 00:01:34 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 18 Nov 2018 00:02:27 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 17 Nov 2018 00:02:01 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 16 Nov 2018 00:01:48 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 15 Nov 2018 00:01:37 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 14 Nov 2018 00:02:01 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 13 Nov 2018 00:01:43 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 12 Nov 2018 00:01:25 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 11 Nov 2018 00:02:13 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 10 Nov 2018 00:01:55 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 9 Nov 2018 00:01:27 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 8 Nov 2018 00:01:25 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 7 Nov 2018 00:01:40 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 6 Nov 2018 00:02:09 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 5 Nov 2018 00:01:48 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 4 Nov 2018 00:02:20 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 3 Nov 2018 00:02:35 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 2 Nov 2018 00:02:00 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 1 Nov 2018 00:01:36 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 31 Oct 2018 00:01:30 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 30 Oct 2018 00:01:45 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 29 Oct 2018 00:01:26 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 28 Oct 2018 00:02:48 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 27 Oct 2018 00:02:03 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 26 Oct 2018 00:01:46 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 25 Oct 2018 00:02:14 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 24 Oct 2018 00:02:06 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 23 Oct 2018 00:02:11 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 22 Oct 2018 00:01:58 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 21 Oct 2018 00:02:09 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 20 Oct 2018 00:01:41 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 19 Oct 2018 00:01:51 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 18 Oct 2018 00:02:16 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 17 Oct 2018 00:02:07 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 16 Oct 2018 00:01:36 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 15 Oct 2018 00:01:33 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 14 Oct 2018 00:02:19 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 13 Oct 2018 00:01:51 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 12 Oct 2018 00:01:26 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 11 Oct 2018 00:01:45 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 10 Oct 2018 00:01:31 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 9 Oct 2018 00:02:09 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 8 Oct 2018 00:01:19 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 7 Oct 2018 00:02:41 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 6 Oct 2018 00:01:08 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 5 Oct 2018 00:01:54 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 4 Oct 2018 00:01:28 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 3 Oct 2018 00:01:25 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 2 Oct 2018 00:01:48 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 1 Oct 2018 00:01:49 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 30 Sep 2018 00:02:14 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 29 Sep 2018 00:01:52 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 28 Sep 2018 00:01:33 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 27 Sep 2018 00:01:22 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 26 Sep 2018 00:01:55 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 25 Sep 2018 00:01:45 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Mon, 24 Sep 2018 00:01:19 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 23 Sep 2018 00:02:02 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 22 Sep 2018 00:01:07 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 21 Sep 2018 00:01:51 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 20 Sep 2018 00:02:12 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 19 Sep 2018 00:01:26 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 18 Sep 2018 00:01:12 +0000 (00:01 +0000)]
Automatic date update in version.in
Simon Marchi [Mon, 17 Sep 2018 12:26:24 +0000 (08:26 -0400)]
python: Make gdb.execute("show commands") work (PR 23669)
Since commit
56bcdbea2bed ("Let gdb.execute handle multi-line commands")
trying to use a command like gdb.execute("show commands") in Python
fails. GDB ends up trying to run the "commands" command.
The reason is that GDB gets confused with the special "commands"
command. In process_next_line, the lookup_cmd_1 function returns the
cmd_list_element representing the "commands" sub-command of "show".
Lower, we check the cmd_list_element to see if it matches various
control commands by name, including the "commands" command. This is
where we wrongfully conclude that the executed command must be
"commands", when in reality it was "show commands".
The fix proposed in this patch removes the comparisons by name, instead
comparing the cmd_list_element object by pointer with the objects
created at initialization time.
Tested on the buildbot, though on a single builder (Fedora-x86_64-m64).
gdb/ChangeLog:
PR python/23669
* breakpoint.c (commands_cmd_element): New.
(_initialize_breakpoint): Assign commands_cmd_element.
* breakpoint.h (commands_cmd_element): New.
* cli/cli-script.c (while_cmd_element, if_command,
define_cmd_element): New.
(command_name_equals): Remove.
(process_next_line): Compare commands by pointer, not by name.
(_initialize_cli_script): Assign the various cmd_list_element
variables.
* compile/compile.c (compile_cmd_element): New.
(_initialize_compile): Assign compile_cmd_element.
* compile/compile.h (compile_cmd_element): New.
* guile/guile.c (guile_cmd_element): New.
(install_gdb_commands): Assign guile_cmd_element.
* guile/guile.h (guile_cmd_element): New.
* python/python.c (python_cmd_element): New.
(_initialize_python): Assign python_cmd_element.
* python/python.h (python_cmd_element): New.
* tracepoint.c (while_stepping_cmd_element): New.
(_initialize_tracepoint): Assign while_stepping_cmd_element.
* tracepoint.h (while_stepping_cmd_element): New.
gdb/testsuite/ChangeLog:
PR python/23669
* gdb.python/python.exp: Test gdb.execute("show commands").
GDB Administrator [Mon, 17 Sep 2018 00:01:42 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 16 Sep 2018 00:02:07 +0000 (00:02 +0000)]
Automatic date update in version.in
Sergio Durigan Junior [Sat, 15 Sep 2018 20:40:13 +0000 (16:40 -0400)]
Move 'is_regular_file' from common-utils.c to filestuff.c
There is no reason for 'is_regular_file' to be in common-utils.c; it
belongs to 'filestuff.c'. This commit moves the function definition
and its prototype to the appropriate files.
The motivation behind this move is a failure that happens on certain
cross-compilation environments when compiling the IPA library, due to
the way gnulib probes the need for a 'stat' call replacement. Because
configure checks when cross-compiling are more limited, gnulib decides
that it needs to substitute the 'stat' calls its own 'rpl_stat';
however, the IPA library doesn't link with gnulib, which leads to an
error when compiling 'common-utils.c':
...
/opt/x86-core2--musl--bleeding-edge-2018.09-1/bin/i686-buildroot-linux-musl-g++ -shared -fPIC -Wl,--soname=libinproctrace.so -Wl,--no-undefined -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -I. -I. -I./../common -I./../regformats -I./.. -I./../../include -I./../gnulib/import -Ibuild-gnulib-gdbserver/import -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -DGDBSERVER \
-Wl,--dynamic-list=./proc-service.list -o libinproctrace.so ax-ipa.o common-utils-ipa.o errors-ipa.o format-ipa.o print-utils-ipa.o regcache-ipa.o remote-utils-ipa.o rsp-low-ipa.o tdesc-ipa.o tracepoint-ipa.o utils-ipa.o vec-ipa.o linux-i386-ipa.o linux-x86-tdesc-ipa.o arch/i386-ipa.o -ldl -pthread
/opt/x86-core2--musl--bleeding-edge-2018.09-1/lib/gcc/i686-buildroot-linux-musl/8.2.0/../../../../i686-buildroot-linux-musl/bin/ld: common-utils-ipa.o: in function `is_regular_file(char const*, int*)':
common-utils.c:(.text+0x695): undefined reference to `rpl_stat'
collect2: error: ld returned 1 exit status
Makefile:413: recipe for target 'libinproctrace.so' failed
make[1]: *** [libinproctrace.so] Error 1
...
More details can also be found at:
https://sourceware.org/ml/gdb-patches/2018-09/msg00304.html
The most simple fix for this problem is to move 'is_regular_file' to
'filestuff.c', which is not used by IPA. This ends up making the
files more logically organized as well, since 'is_regular_file' is a
file operation.
No regressions found.
gdb/ChangeLog:
2018-09-15 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/23663
* common/common-utils.c: Don't include '<sys/stat.h>'.
(is_regular_file): Move to...
* common/filestuff.c (is_regular_file): ... here.
* common/common-utils.h (is_regular_file): Move to...
* common/filestuff.h (is_regular_file): ... here.
GDB Administrator [Sat, 15 Sep 2018 00:02:16 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 14 Sep 2018 00:01:00 +0000 (00:01 +0000)]
Automatic date update in version.in
Tom Tromey [Thu, 13 Sep 2018 16:56:34 +0000 (10:56 -0600)]
Make Rust error message mention the field name
I noticed a spot in rust-lang.c where the placeholder "foo" was used
instead of the actual field name. This patch fixes the bug.
2018-09-13 Tom Tromey <tom@tromey.com>
PR rust/23650:
* rust-lang.c (rust_evaluate_subexp): Use field name, not "foo".
gdb/testsuite/ChangeLog
2018-09-13 Tom Tromey <tom@tromey.com>
PR rust/23650:
* gdb.rust/simple.exp: Add test for enum field access error.
Tom Tromey [Tue, 11 Sep 2018 21:28:04 +0000 (15:28 -0600)]
Fix crash with empty Rust enum
While testing my Rust compiler patch to fix the DWARF representation
of Rust enums (https://github.com/rust-lang/rust/pull/54004), I found
a gdb crash coming from one of the Rust test cases.
The bug here is that the new variant support in gdb does not handle
the case where there are no variants in the enum.
This patch fixes the problem in a straightforward way. Note that the
new tests are somewhat lax because I did not want to try to fully fix
this corner case for older compilers. If you think that's
unacceptable, let meknow.
Tested on x86-64 Fedora 28 using several versions of the Rust
compiler. I intend to push this to the 8.2 branch as well.
2018-09-13 Tom Tromey <tom@tromey.com>
PR rust/23626:
* rust-lang.c (rust_enum_variant): Now static.
(rust_empty_enum_p): New function.
(rust_print_enum, rust_evaluate_subexp, rust_print_struct_def):
Handle empty enum.
gdb/testsuite/ChangeLog
2018-09-13 Tom Tromey <tom@tromey.com>
PR rust/23626:
* gdb.rust/simple.rs (EmptyEnum): New type.
(main): Use it.
* gdb.rust/simple.exp (test_one_slice): Add empty enum test.
GDB Administrator [Thu, 13 Sep 2018 00:01:30 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Wed, 12 Sep 2018 00:02:07 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Tue, 11 Sep 2018 00:01:51 +0000 (00:01 +0000)]
Automatic date update in version.in
Eli Zaretskii [Mon, 10 Sep 2018 07:14:04 +0000 (10:14 +0300)]
Fix "make install-strip" failure to install gdb-add-index.sh
gdb/ChangeLog:
2018-09-10 Eli Zaretskii <eliz@gnu.org>
* Makefile.in (transformed_name): Use INSTALL_SCRIPT instead of
INSTALL_PROGRAM to install gdb-add-index.sh. Don't append
$(EXEEXT) to the script, as it is not a program.
GDB Administrator [Mon, 10 Sep 2018 00:01:40 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Sun, 9 Sep 2018 00:02:18 +0000 (00:02 +0000)]
Automatic date update in version.in
GDB Administrator [Sat, 8 Sep 2018 00:01:37 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Fri, 7 Sep 2018 00:01:58 +0000 (00:01 +0000)]
Automatic date update in version.in
GDB Administrator [Thu, 6 Sep 2018 00:01:33 +0000 (00:01 +0000)]
Automatic date update in version.in
Joel Brobecker [Wed, 5 Sep 2018 08:13:08 +0000 (10:13 +0200)]
Bump GDB version number to 8.2.0.DATE-git.
gdb/ChangeLog:
* version.in: Set GDB version number to 8.2.0.DATE-git.
* PROBLEMS: Likewise.
Joel Brobecker [Wed, 5 Sep 2018 08:01:55 +0000 (10:01 +0200)]
Document the GDB 8.2 release in gdb/ChangeLog
gdb/ChangeLog:
GDB 8.2 released.
Joel Brobecker [Wed, 5 Sep 2018 07:44:29 +0000 (09:44 +0200)]
Set GDB version number to 8.2.
gdb/ChangeLog:
* version.in: Set GDB version number to 8.2.
* PROBLEMS: Likewise.
GDB Administrator [Wed, 5 Sep 2018 00:01:17 +0000 (00:01 +0000)]
Automatic date update in version.in