fix issue related to wrong messageId

Change-Id: I6008dfe8fc3dc648841f0527e993bd698275f7e4
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13385
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit a8e1605955b5f7fdf9ed1b59cfb3eb54c4e6d8ac)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13411
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>

Fix for Memory leak results from static analyzer for NS C++ Wrapper.

Change-Id: I97ca331ce6fcd7352350fd36426366433a5521a2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 1b4cea1ba6bb1b57214e0c3bbb6e84f214dda971)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13403
Tested-by: Uze Choi <uzchoi@samsung.com>

setting received  ttl value  by consumer.

Change-Id: I1de504edf851d39d761dfa2a189a77116fca8a85
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13387
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit f25946d028fa420573093f03fcbb2aa94eecfcf8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13409
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>

Fix Build issue for soname for NS Libraries

Change-Id: I07416d904e5ac63bbb389081e99f6849acfff842
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13415
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

tizen: Ignore tmp folder as used for local building

This temporary folder is used to build out of sources.

Change-Id: I88dedd1f019cb67196d1980a6171f513c82b19cb
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12715

tizen: Use sqlite from system not scon puller

Change-Id: Id4382d37d34e5ac7d023e38bebd60228c6e6860e
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12913
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

tizen: Ship only BSD licence from libcoap

libcoap-4.1.1 is also licenced LICENSE.GPL,
to avoid ambiguity, tizen use the more permissive one, BSD.

This patch can be reverted,
 if Tizen wants to ship all upstream licences

Change-Id: Idc77605c48322f36887cc502dc0be570e2562486
Origin: https://gerrit.iotivity.org/gerrit/#/c/12969/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12805
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 2bf870bae3451743f0dee3d35735994785e1b15c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12969
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>

tizen: Ship renamed libuuid into RPM for SDK

This way produced RPM can be installed on target or imported in SDK.

libuuid.so.1 is pulled by pkgconfig from com-oic-ri.spec
 then it will be installed correctly if using "rpm -i *.rpm",

Overiding system libs in packaging, is not encouraged:
Observed issue on Tizen:2.4:Mobile (TM1) :

  sdb shell su -c "rpm -i /opt/usr/media/Others/GBS-ROOT-RI-OIC/*.rpm"
  file /usr/lib/libuuid.so.1 from install of com-oic-ri-1.2.0-0.armv7l \
  conflicts with file from package libuuid-2.20.2-4.139.slp.armv7l

But if we want to unpack RPM contents to be used along Tizen-sdk,
 as app, then uuid is also needed
 (because SDK is missing it from its sysroot).
 So application need to be linked with -luuid1 (same just renamed),
 to avoid collision.

For more details about building IoTivity for Tizen along SDK,
 please check:

https://wiki.iotivity.org/tizen

Change-Id: Iabed0221618d0d602f440e3527e1824177395ee1
Bug: https://jira.iotivity.org/browse/IOT-1343
Origin: https://gerrit.iotivity.org/gerrit/#/c/12471
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

JavaDoc script update

correct primitive service package and path

Change-Id: I59ed31c14c2286a7565b7a01f26ed213ef39bd55
Reviewed-on: https://gerrit.iotivity.org/gerrit/13361
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Unit tests for SSL adapter update

Change-Id: Ib108dd1ce76632f1393383e6402e73c7ba2e60d7
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix crash in Android provisioning client App.

Catch exception in provision Android client for setDeviceId API.

Change-Id: I19918e47eac9f040d490e3805964c6cc7d5d3fba
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Remove unnecessary files for MOT

Change-Id: I9dbfab89b3c6cac1f82514dbb42c82c23808fc7e
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13343
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[Hotfix] Remove the segmentation fault while MOT.

Segmentation fault was occured by https://gerrit.iotivity.org/gerrit/#/c/13299/

In this patch,
MOT device discovery will use the pCandidateList
to handle discovered device according to patch 13229.

Change-Id: I57d9a603602d49bb3f8e287ae1599f450a044731
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13341
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

added error code (4.03 / 5.00) in ocstack result

Change-Id: I311c0b76a2faa7704be8f4a8b89088a0ae471c6a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13339
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Modify /oic/res response

1. Modify /oic/res response from cloud side.
   Return 4.04 Not found if no resources found.

Change-Id: I5a8bf56ff5a3c07c2dc489dc2721b76716d9f6fd
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13335
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Glen Youngjin Kim <glen.kim@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Update a logic to check an availability of cloud server resource

Rather than URI, resource type of the cloud server resource is more
confirmable to check the availability.

Change-Id: I61f3b63412b39fc56e993a3041ac007d0886368b
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13333
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add null checking for observe request in easy setup

Checking if entityHandlerRequest is NULL is added.

Change-Id: I79bf75c9f53f28b9c0c679a5dd7371552764b5cd
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13327
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

tizen: Simplify missing license macro for Tizen:2.3

Change-Id: I6c2ceec4f37589db6c110a0f04df501c689a3fde
Origin: https://gerrit.iotivity.org/gerrit/#/c/12897/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12897
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Revert wrong removal of proxy client sample build

A DTLS related change has wrongly removed build for
proxy client sample.

Change-Id: I1f65c1cadf6a84a69691ad02bc1227793ca2fce7
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for all discovered devices to include a secure port

This patch prevent to add the device that does not have a secure port to discovered device list

Change-Id: Ia7283b37b7820e045f4a51ad03395205b4240dd3
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13299
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Multiple Ownership Transfer support.

  - Patch #1 : Initial upload
  - Patch #2 : Apply the conditional compilation for Multiple Owner features.
               e.g.) scons SECURED=1 MULTIPLE_OWNER=1
  - Patch #3 : Remove compile error for arduino
  - Patch #4-5 : Rebased for latest 1.2-rel branch
  - Patch #6 : Updated according to comment.
  - Patch #7 : Updated according to comments.
  - Patch #8 : Fixed unittest error.
  - Patch #9-10 : Fix svace issues
  - Patch #11 : Rebased with latest 1.2-rel
  - Patch #12 : Updated according to Kevin's comments.
  - Patch #13 : Rebased with latest 1.2-rel
  - Patch #14-15 : Fix svace issues
  - Patch #16 : Rebased with latest 1.2-rel
  - Patch #17 : Apply the optional compile for CA layer.

[Overview]
This patch is to support the multiple ownership transfer(MOT).
We assume the MOT authenticated client is the SubOwner.
SubOwner can access the ALL resources with full permsion except the DOXM, ACL and CRED.

This patch includes following changes :
1. Update the doxm resource to include MOT related properties.
   - New Properties
     . x.org.iotivity.mom : Mode of MOT
     . x.org.iotivity.subowneruuid : List of SubOwner
   - SubOwner has READ permission for DOXM.
   - The resource server will be update subowner list of doxm
     when MOT authentication successfully done.

2. Update the cred, acl resource to include MOT related property.
   - New Properties
     . x.org.iotivity.eowneruuid : entry owner uuid for each entry.
   - SubOwner should set the eowner as subowner's UUID
     when provision the ACL and CRED.
   - SubOwner can access only those resources that registered as eowner.

3. Update the PolicyEngine for SubOwner's access control as following :
   - DOXM : READ ONLY
   - CRED/ACL : SubOwner can access only those resources that registerd as eowner.
     . SubOwner can not provision ACL which is include the DOXM, CRED, ACL, PSTAT.
   - PSTAT : FULL permission
   - Application Resources : FULL permission

4. Add Preconfigured-PIN OxM

5. Update the sample codes
   - Test Preconfigured PIN based MOT
     1. Run the sampleserver_justworks
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Perform the MOT enabled device discovery [Menu:13]
        - Check the discovered device list.
     8. POST the preconfigured-PIN credential [Menu:71]
         - sample's preconfigured-PIN is '12341234'
     9. Change the server's 'oxmsel' [Menu:72]
         - '3' is preconfigured-PIN OxM
     10. Run the subownerclient
     [On the subownerclient]
     11. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     12. Perform the MOT [Menu:20]
     13. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     14. Perform the ACL provisioning TEST [Menu:40]

   - Test Random PIN based MOT
     1. Run the sampleserver_randompin
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Run the subownerclient
     [On the subownerclient]
     8. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     9. Perform the MOT [Menu:20]
         In case of random PIN based MOT, PIN input required.
     [On the sampleserver_randompin]
     10. Press 'G' or 'g' on the sampleserver_randompin.
         server will generate and display the random PIN.
     11. Input the server's PIN number on the subownerclient side.
     12. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     13. Perform the ACL provisioning TEST [Menu:40]
     14. Press 'E' or 'e' on the sampleserver_randompin to exit server.

Change-Id: I5449834e766d256495537d9fb469eb4d597f4c7a
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12063
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Update the ACL delete mechanism as determined by OSWG.

After this patch,
If 'subject' not exist in the query string of DELETE request,
All ACE data will be removed.

Change-Id: Ife12c457b2029991168bf048bbfb90278ea4b3a2
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Add license comment

Change-Id: I1374b2ee45e120bae756e1e2f975eba23fee24f4
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13293
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[IOT-1440] findResource() to return list of discovered resources.

OCPlatform::findResource() does not return all the discovered resources in single callback
even though it gets the whole discovery payload from RI C layer.

This change implements OCPlatform::findResourceList() API which does return all the parsed
resources in discovery payload in single callback.

Change-Id: Ic95541f7303a15eb676029e6f2ea4952e5e3ca3e
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13111
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Bug fix about result of static anlayzer.

this patch include,
bug fix about memory leak and coding idiom.

Change-Id: I6fba4a8b182ce88cda44571ebb490c7573812c01
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13269
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Modified connectivityType on calling getDeviceInfo API at CPP Sample

Modified connectivityType on calling getDeviceInfo API at CPP Sample
Invalid connectivityType is used after merging below patch.
https://gerrit.iotivity.org/gerrit/#/c/13143

Change-Id: Ia881159af02f1eae984d4cda770e23cf6205741a
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1442] Apply the new ACL policy for device owner and resource owner.

According to new ACL policy,
Device owner's ACL should be provisioned while OTM.
For this reason, Ownership transfer manager should updates the owner's ACL while OTM.

- Patch #1 : Initial upload
- Patch #2 : Updated according to comments.
- Patch #3 : Rebase
- Patch #4 : Fixed a bug that occured during rebase.

Change-Id: I92a78e6145afdb3341582555739a64184bee65db
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Added NULL check for GetDoxmResourceData

Change-Id: Iea981a40ebaccef368ae4cbd834c30cb124fd76c
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Keep ACL rowneruuid when POST payload does not have rowneruuid

Maintains the ACL rowneruuid when the payload of POST request
does not have rowneruuid

Change-Id: I52177b84ba9ced8b1078b3edea12256e23d6dfd8
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix for IOT-1394.

In callbacks for GET, PUT, POST, and OBSERVE requests in
InProcClientWrapper.cpp (CPP layer of RI), the representation was parsed
only for success cases.

But when we are dealing with cloud responses,
they include a payload with error message and code even for error cases.

To catch those responses, we should ignore the status(OCStackResult)
of client response and let the error representation reach till application.

Change-Id: I103957bb79e948693807fc05e8bed461e6b2d8dd
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12831
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 664340cc8b5c22d3441f11c34df2b5f3d1b8eff3)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13211
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1444] Enabling handling observe requests for collection resource.

Change-Id: If72f5a85858240787dea2b307710f1167c14c68a
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13149
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit aa9cdad0a3937ae0e8538cbc8f6c48a1a52cde9a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13161

[IOT-1438] Solve Build issue on Tizen secured build through gbsbuild script

- add secured check logic into gbsbuild.sh file
- using this logic, check mbedtls file & apply the patch

Change-Id: I6d458ea599562216444582b78724a1b61023d6de
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[IOT-1451] Keep client callback when receiving error result

when Client receive error code from some server after request
oic/res. clientCB is removed by return value "OC_STACK_DELETE_
TRANSACTION"

Change-Id: Ibf42740078f0ed6a97ee3b18d22559b0d2fbdf43
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13237
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: MyeongGi Jeong <myeong.jeong@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

bug fix about memory leak.

this patch include,
bug fix for dynamic analyzer.

Change-Id: I4fc7ff7436ac6019abe3aaaf8467392068e0ad7d
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13255
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

fixed bug in ResourceFind of CI

Change-Id: I816b8e0ed8fe62d0a6f385aa634c8e464669977c
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13249
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Urgent Fix (in ocstack.c)

Fix error in ocstack.c which prevents us to Sign Up to cloud
It was appeared in next patchset
[IOT-1413,IOT-1415] Fixed request handling bugs for /oic/ping resource

Change-Id: Icf193a19107ce2cb044537f6a0a5058944c39afd
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13241
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

IOT-1398 Remove CheckFunc() on Win32 API

CheckFunc() is dangerous on Win32 APIs because SCons is not capable
of compensating for __stdcall name mangling on x86 systems using the
Visual Studio compiler.

Change-Id: Iaec49e4d246c02ecfebc5bf70ee0c0620cdde51d
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
(cherry picked from commit 823d478bbf5109a4a73c304794179410f984714e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12955
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Update observe-request processing logic.

Change-Id: Icb5ae1a3f8c8e985570b30b0420cc6e7fe98ffdc
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13251
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

bug fix for response of topic and modify unittest.

this patch include,
1. bug fix for response of topic post case.
2. modify unittest about included interface type.

Change-Id: I5bba7ef93260c2c67f25d9d79455e383d6ea8c0c
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit f58cd738051414f36223ea6a6eb6def34a927ba9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13221

Bug fix about memory leak.

this patch include,
bug fix for dynamic analyzer.

Change-Id: I9a36d496b76c9d712d80af45492f0e38a7aff4ea
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added SVACE Fixes for C++ wrapper Unit TCs

Change-Id: I09224a2bcd6e38c0d8cbb80caf5a0009161113d2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 82f4898421586624bb7e0576ad48948e05032fff)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13239

Change settings on deviceInfo and platformInfo in samples as per specs.

Bug: https://jira.iotivity.org/browse/IOT-1435
Change-Id: I9de03c0c6c09d4632503f9ad8f2943c9f1468527
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13051
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 18459f405216414506c405c118633405a27b0585)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13175

[IOT-1391] fix BLE scan logic which create thread.

scan thread was made by unicast/multicast request in BLE client.
it causes a big problem which memory overflow issue related Thread.
so, scan thread will be working as one thread.

Change-Id: Icbabfcdbc7e4c260e36b22f31e98779248b4b7ed
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12923
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

annotate OIC_LOG_BUFFER when looking for client callback and observer

Printing all token info while looking for client callback or observer
is burden and makes it hard to see entire log message
even though it is needless.

Change-Id: I25e0c3f1922f207a9d6652017495270db34e6bbc
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12375
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ce6822710a2ee2272b2740e6747f219c8c51dfca)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13209
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>

Fix bugs for result of static analizer.

1. Initializatioin of local variable is added.
2. Invalid memory double free is removed on error handling.

Change-Id: I2d4c8460dd1e81ef88f6119f79deeae09c7f01c8
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13201
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated Easysetup Security logic.

 - EnrolleeSecure resource not to re-created during previous request is processed
   for every security provisioning request to get callback from security-logic

Change-Id: I905b1cf708db68583a95bd9cad299212fa00ec84
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13077
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 6bc9e3388d3cafb0af33e785b3650af9f94ff7d1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13203
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[IOT-1413,IOT-1415] Fixed request handling bugs for /oic/ping resource

- /oic/ping resource is responding with 5.00(internal server error)
when it receives a GET/POST/PUT request with baseline query
- /oic/ping resource is successfully registering and deregistering
observe requests, even though it is shown as non observable resource
in discovery response.

Change-Id: I86db52f17b0b42750906fdfa8b377c78a85ef822
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13089
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1445] Add ins value when publishing a resource to rd

The ins value has to be included when publishing a resource
to resource-directory. Otherwise resource-directory will
return error code.
Currently, The ins is not included because the return value
of OCGetResourceIns() was not checked properly.

Change-Id: I11b1f405e000f36bb76ca7d24c8dbbbd6e7586fe
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13159
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1449] mbedTLS: Use wcslen instead of lstrlenW on Windows

lstrlenW is not allowed in Windows Store applications. Use wcslen
instead.

Also fix a nearby narrowing size_t to int conversion to make sure
it's safe.

Change-Id: I14d37b6a0d6c82444f4733f5d54bd8173ca62b71
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13183
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix a faulty logic in PMSingleDeviceDiscovery

A device discovery transaction should be removed AFTER port discovery
is done or discovery time is expired.

Change-Id: I55062a3a8ef5187bf249d0afee2276e40c0f52d9
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Added changes to remove build warning while building NS Jni Common files

Change-Id: I0631be24a2cdfeedaae61a02fb351f047f834ae7
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 2ca715130d210337381369b8d3c65283a9ab6ae4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13187

[IOT-1420] Solve that if, rt properties ommited

- add rt, if attributes to SceneListResource

Change-Id: I07017fbfb99755d182676e5a946fde505e121e66
Signed-off-by: ChaJiWon <jw_wonny.cha@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13105
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 3b06e2bd1f6db4bae9189dc974632df4caa77239)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13189

Fixed bug for result of static analysis.

Change-Id: I6301a61d0e8fd8bfd21585a59455da50b2aabd14
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit a510bc85e4e7afea9f2c2f59aced6e284f12cd52)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13191

Set ACL Rowner to PT's Device ID in SRPProvisionACL

If Rowner of ACL to be provisioned in SRPProvisionACL is empty,
Set it to PT's Device ID

Patch #1: Initial upload
Patch #2: Jongsung's recommendation applied
Patch #3: Fix typo
Patch #4-5: GetDoxmDeviceID failure taken care of

Change-Id: I38886d32fd35f39370d4e5e46e39b66edfc0f003
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13037
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Add logic about checking the NULL and modify warning code.

This patch include, check the NULL and modify warning code.

Change-Id: Ie28548563357e0c9565ecdcd776cce60d3d42f33
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13195
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove unused old API.

 - delete registerSecurityCallbackHandler api.

Change-Id: I0d4c31af7ac9d5d25c260cf07f5ebf38381609ea
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13081
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 071b2cf0e75cae68b8441552dbbc660d158489d9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13197

Remove unnecessary define and files for SSL

1) Removed X.509 build option because it is enabled by default
2) Deleted DTLS and TLS adapter files because thay are included in SSL

Change-Id: I078c5b0c912801f17fa858d6fdd2abe39feed9f8
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13115
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1446] Fix discovery failure issue

Change logic in the Policy Engine in order to resolve
discovery failure issue

Patch #1: Initial upload
Patch #2: Error message changed

Change-Id: I08ab1dec15cb0f49374d42d97b65a23fe885db39
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13173
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Update a response representation according to requested interface in easy setup

Referred jira ticket:
[IOT-1408] -
  [ES] Common properties are not exist
[IOT-1410] -
  [ES] /ProvisioningResURI does not support properly for Retrieve
       with interface query

Change-Id: Icb2c8bb5e3c9d796e7f09a7bdd23e895c1f2352d
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13073
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix bugs for result of dynamic analizer.

1. definitely losted memory was deallocated.
2. pthread creating type was modified for parameter deallocation.
3. invalid c-string copy was fixed.

Change-Id: Iab32535f164029ccd8a82d49968ce0a44e8b8bd1
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13163
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

change asynccall Function to synccall function.

this patch include,
1. change sync call about NSProviderSetConsumerTopic Function.
2. change sync call about NSProviderUnsetConsumerTopic Function.

second patch include,
modify invalid return value.

Change-Id: Ia73d6544489dd36f4612c97108ca488f76e038e3
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13001
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1389]Release netlink socket event in Android ip adapter

Netlink socket event is never released in Android ip adapter.
The reason is the function "CAFindInterfaceChange" should listen event
from netlink socket for release socket event, but it didn`t.
So, we should listen and release netlink event from netlink socket.

Change-Id: I221682d4f0dde5a902670ce54eba797c30c09911
https://jira.iotivity.org/browse/IOT-1389
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12749
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 8a1f7a74aee41dd9a80da855e59fcbe2abef4b7b)
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12779
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Add curl license file

CURL license file is attached so that an example is used the licensed code.

Change-Id: I65e5e136e042329fa6350a7660a24bc5cd3b22ba
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13039
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

build: ignore debian generated files

Change-Id: I963a02a548344f5c6e9955a4286de595801e9f93
Origin: https://gerrit.iotivity.org/gerrit/#/c/11811/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Scan for licences to be shipped in package

It's important to have this generated at buildtime,
 especially if tree is patched with missing dependencies,
 like those mentionned at:

 https://wiki.iotivity.org/build

Change-Id: Ie8d9dc0685ddc2df37545e92da4a662ee496bd07
Credit-to: Jaehong Jo <jaehong.jo@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/12891/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12891
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Use installed sqlite3

Change-Id: I2cc6cb804bd9c28473cf1dfc2b4c85c4da6cb982
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12911
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

[IOT-1400] Remove multicast presence node list in client side.

MCPresenceNode(multicast presence list) never remove.
it causes a big memory leak.
and since checking sequence number not required.
it is better to remove for simple stack logic.

Change-Id: I000772b12c88b30bd771fc759ac2ffaacedd0cc0
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13139
Reviewed-by: daeken kwon <daeken.kwon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Add device and platform information in sample codes.

Bug: https://jira.iotivity.org/browse/IOT-1384
Change-Id: I8f8e69716534dddb77d6069394267e730a02c14f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12909
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
(cherry picked from commit 727e1ba3cbd4d8fd9fbfa30d1f25529f7c24ee31)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13143

Update C API doxygen

C API description is updated for some fields such as subControllability.

Change-Id: Ie44c213657a9ffdd55ec386e8bc953bad709432d
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13091
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update and fix of  UnitTest for cpp-wrapper

1)Updated new unittest for consumer and provider
2)Fix for removing segmentation fault

Change-Id: If06e9606c405a3fa2dace726a5c9320399b06e66
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13127
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1430] bug fix for seg fault on start consumer.

With this patch, segmentation fault is resolved on the starting consumer service.

Change-Id: I929ec45d34a401ea7e6e503d6c686471656f39cf
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13007
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update Cpp Api doxygen

Change-Id: I4ed23e32956980d816c3a7e6bb0605272df2782f
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13147
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add doxygen comment for java api's of ProviderServicer and ConsumerService.

Change-Id: I149a714258db8495473064c98f270b9b01fd2497
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13131
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for invalid remove a context at request.

When receive responce of getting topic information,
consumer serivce remove context manually.
But, it is the invalid way.
With this patch, consumer service does not remove manually.
Context will be removed automatically by RI layer.

Change-Id: I1278dc13bf297b95e513d364f243064b525a7083
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13025
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify gradle version for building notification service.

Change-Id: I93557aac43c2d1c808495dff1120cff737ccea44
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13121
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Bug fix about invalid parsing and modify sconscript.

this patch include,
1. Bug fix about invalid parsing in jni side
   and send notification was changed to once call.
2. Modify sconscript for android 6.0 devices

Change-Id: I9ae6d68ebf24d944e896db54949f86de62fc0f6e
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13069
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add invitation accept/deny method in invite resource.

Server can not know the intention of user when a user deletes received
invitations.Therefore, i add a new field "accept" in query. if "accept"
is "1"(accept=1), then it means accept, otherwise(accept=0) deny.

Change-Id: I2030099ed084c3238cc0f5cc4ff7e5f38eba5235
Signed-off-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

[IOT-1441] Update DevOwner access policy to remove implicit access in RFPROV.

With this patch, the DevOwner now will only be able to access SVRs during
RFOTM or RESET states, unless of course there is an ACE installed allowing
explicit access to the DevOwner.

This behavior change is required by the Security Test Matrix v7, published
by the Security WG.

Patch 2: updated with JIRA ticket #

Patch 3: fixed logic bug found by Kevin

Patch 4: corrected commitmsg

Change-Id: I267c9eb78682bc810b7b2399f6606b8379d6e718
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13117
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Account server static analysis issue solved

1. Account server static analysis issue solved in AclResource.java

Change-Id: Ieeadf6f0d018efddcac1b69a56341ce4464bbb79
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13055
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jung seungho <shonest.jung@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

[IOT-1436] fix scons build issue related sqlite3 with unsecured mode

sqlite3 is triggering to download by default.
it causes a storage memory waste in user side.
scons build script should check any option for download that lib

Change-Id: I701752bb450dc79d3604304fc7130375586e5356
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13071
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1380] Use BCryptGenRandom on Windows

Patch mbedTLS to use BCryptGenRandom on Windows.
Add the mbedtls subtree to .gitignore.

Change-Id: I23367aac194de2531299badc466a0d39e46eda4d
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 881029a89e9e1f5a828fc2d2df705a6d62a93189)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13123

[IOT-1434] fix subscribe presence for multicast.

it causes a big memory issue to add in serverRequestList.
because this request never remove

and subscribe presence for multicast should be not sent
on network.
since it is just for register clientCB in stack.

Change-Id: I14c9701009350ad52dfdf4e72db64522fc591705
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1417] Fix Sign Up/In/Out Workflow

Change-Id: Icfadd8e40fcb8cbf8d962464d8bc1372b302d5c6
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13093
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Disable security version discovery

Change-Id: I22183fc82ef953f2fe49966406488d491de18ada
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13087
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Unit tests for SSL adapter (ca_adapter_net_ssl.c)

Change-Id: Ia9bb81012159df0f1b5f87d80e821610aeaa44c1
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Update easysetup's security-provisioning logic.

 - This patch indicates the method to reduce security-provisioning time
   by improving the secured-resource search process.

Change-Id: I7cb1a9be272dc92451cf5099afb55c15adeb27ec
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12995
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add logic for checking the null

Add logic about malloc failed.

Change-Id: I8ac6169f65b00200f9d64fa1572217e53c05435f
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit f114f92cbc6c025fbd92ec99599f79974a43957d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12981

Correct observe callback function in occlient.

1. For observe register request, Sequence number received
in client response falls in range 0 - MAX_SEQUENCE_NUMBER.
2. For observe deregister request and or any failed requests,
the client sequence number value is MAX_SEQUENCE_NUMBER + 1.

Change-Id: Idcc0775179e17ce6df85fb93f127336fede9a42a
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11695
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 7ed91f143c91ce4d7522faad5f772e55a41ac0da)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12789

fix android build failure issue with WITH_CLOUD=1 and secure mode

Change-Id: I1f1cca166866fda08e2d644032eca7e721bf8db8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12861
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1400] fix memory leak related presence in ocstack

Change-Id: Ib838532de9ab732fd1833d9423b2759c8aec0cf7
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1434] Fix memory leak related server request List.

when there is no response data for virtual reqeust in server.
it should be removed, since it never remove and
causes a big memory leak.

Change-Id: Ic65692ae8b2c1c27f554f466d00bd0cc1674118f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12947
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix for Jira [IOT-1424]

Modified unit test to pass mutable string to CHPGetOCContentType().

Change-Id: Ic0ea5704ddff20dc67086296e54775ef8d677d69
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13013
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix mq sample client crash

1. Fix mq_publisher crash (IOT-1432)
1. Fix mq_subscriber crash (IOT-1433)

Change-Id: I499f2e1ef95cfde69e29618c8580271009b0a61e
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12989
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>

Fixed [IOT-1414]

Propagate INVALID_CALLBACK  instead of INVALID_PARAM when Listener is null

Change-Id: Id41c9be5dc33e9220c4809351b8269738eb95f56
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Add logic for sending responses according to the interface of requests.

This patch include,
Generate response for each of interface
and Add handling about exception cases.

Second patch include,
1. change NS_DEFAULT_INTERFACE to NS_INTERFACE_BASELINE
2. Add first patch logic into Topic case.

Change-Id: I7aa5868fc9a4b4537964c8bdf92b1f15d058d892
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12787
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit c7a5965ec9778c92fa3a36431155d0697424e76f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12983

add logic for invalid char

this patch include,
add logic for invalid char in notificationprovider example only.
sometimes, input variable has an incorrect value.

Change-Id: Id8fa6152a7a7f15ef5d54425daf896680d6c9447
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12985
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1396] Changed values of OicSecDpom_t to align with oic.sec.pomtype from Security Spec v1.1.12

The bitmask values for the pstat.om and pstat.sm properties were incorrectly
defined.  A few other files (including provisioning tool files) appeared to use
the values incorrectly, and are also fixed as part of this patch.

Patch #2: .json and .dat files changed accordingly
Patch #3: unittest svd db changed accordingly

Change-Id: Ie1d4b13a271eafea38b41313bba6e087b69a2f62
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12855
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

tizen: Disable Bluetooth transport for Tizen:2.3

Tizen:2.3:Wearable (Samsung GearS) builds at least.
Because it's not building using outdated capi BT packages.

Change-Id: Id1b37df55bbdebd7ada1413935f5306ccd1e0002
Bug: https://jira.iotivity.org/browse/IOT-1320
Origin: https://gerrit.iotivity.org/gerrit/#/c/12475/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1388] fixed duplicate start server in EDR adapter.

when both mode(server and client) in App is set.
startDiscoveryServer and startListenningServer is calling.
and then both accept thread
and receive thread is running redundantly

Change-Id: I70395ace6115d52d28d2c034ea24c70aafeb671e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12799
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add DeviceID Parameter on SingleDeviceDiscovery function
this Parameter for discover a specified deviceID
If specify the deviceID, It can discover a specified device
when there is one or more device on the network

Change-Id: I99bff0620ee339a42e22e434099772e4175d73d9
Signed-off-by: Sijae Kim <sijae.kim@samsung.com>
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12957
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>