Lennart Poettering [Mon, 16 Apr 2018 19:24:13 +0000 (21:24 +0200)]
conf-files: beef up conf-files.[ch] a bit
This adds fozr new flags:
- If CONF_FILES_DIRECTORY is specified conf_file_list() and friends
will look for directories only.
- Similar CONF_FILES_REGULAR means we'll look only for regular files.
- If CONF_FILES_BASENAME is specified the resulting list will contain
only the basenames of all discovered files or directories, not the
full paths.
- If CONF_FILES_FILTER_MASKED is specified the resulting list will have
masked entries removed (i.e. those symlinked to /dev/null and
suchlike)
These four flags are useful for discovering portable service profile
information.
While we are at it, also improve a couple of other things:
- More debug logging
- use path_hash_ops instead of string_hash_ops when putting together the
path lists
Lennart Poettering [Tue, 17 Apr 2018 09:07:56 +0000 (11:07 +0200)]
fileio: make sure read_full_stream() works on memory-backed streams
Lennart Poettering [Mon, 16 Apr 2018 10:36:07 +0000 (12:36 +0200)]
path-lookup: add flag to optionally force checking split-usr unit dirs
When we look into a portable service image it might contain the unit
files in split-usr directories rather than merged-usr directories as on
the host. Hence, let#s add a flag that checking all dirs can be forced.
Lennart Poettering [Wed, 28 Mar 2018 14:45:44 +0000 (16:45 +0200)]
install: export unit_file_lookup_state()
Lennart Poettering [Mon, 26 Mar 2018 14:32:40 +0000 (16:32 +0200)]
os-util: add helpers for finding /etc/os-release
Place this new helpers in a new source file os-util.[ch], and move the
existing and related call path_is_os_tree() to it as well.
Lennart Poettering [Mon, 26 Mar 2018 17:20:47 +0000 (19:20 +0200)]
fileio: add parse_env_filev() that is like parse_env_file() but takes a va_list
Lennart Poettering [Fri, 23 Mar 2018 20:31:14 +0000 (21:31 +0100)]
fileio: accept FILE* in addition to path in parse_env_file()
Most our other parsing functions do this, let's do this here too,
internally we accept that anyway. Also, the closely related
load_env_file() and load_env_file_pairs() also do this, so let's be
systematic.
Lennart Poettering [Fri, 23 Mar 2018 19:52:46 +0000 (20:52 +0100)]
process-util: add a new FORK_MOUNTNS_SLAVE flag for safe_fork()
We already have a flag for creating a new mount namespace for the child.
Let's add an extension to that: a new FORK_MOUNTNFS_SLAVE flag. When
used in combination will mark all mounts in the child namespace as
MS_SLAVE so that the child can freely mount or unmount stuff but it
won't leak into the parent.
Lennart Poettering [Fri, 23 Mar 2018 19:39:32 +0000 (20:39 +0100)]
dissect: optionally, validate that the image we dissect is a valid OS image
We already do this kind of validation in nspawn when we operate on a
plain directory, let's also do this on raw images under the same
condition: that we are about too boot the image. Also, do this when we
are about to read OS metadata from it.
Lennart Poettering [Fri, 9 Mar 2018 21:45:08 +0000 (22:45 +0100)]
fd-util: add new helper call fd_duplicate_data_fd()
This call creates an fd from another fd containing the same data.
Specifically, repeated read() on the returned fd should return the same
data as the original fd. This call is useful when we want to copy data
out of disk images and suchlike, and want to be pass fds with the data
around without having to keep the disk image continously mounted.
The implementation tries to be somewhat smart and tries to prefer
memfds/pipes over files in /tmp or /var/tmp based on the size of the
data, but has appropropriate fallbacks in place.
Lennart Poettering [Thu, 24 May 2018 14:49:13 +0000 (16:49 +0200)]
Merge pull request #8817 from yuwata/cleanup-nsflags
core: allow to specify RestrictNamespaces= multiple times
Susant Sahani [Mon, 21 May 2018 11:33:36 +0000 (17:03 +0530)]
networkd: Support the ability to set MTU in [Route] sections
Add support to set the route MTU.
Closes #9047
Zbigniew Jędrzejewski-Szmek [Thu, 24 May 2018 14:30:46 +0000 (16:30 +0200)]
Merge pull request #9020 from poettering/physical-memory-cgroupsv2
make sure physical_memory() groks cgroupsv2
Zbigniew Jędrzejewski-Szmek [Thu, 24 May 2018 14:27:27 +0000 (16:27 +0200)]
Merge pull request #9024 from poettering/nspawn-attrs-more
make even more nspawn concepts configurable
Zbigniew Jędrzejewski-Szmek [Thu, 24 May 2018 14:25:22 +0000 (16:25 +0200)]
Merge pull request #9068 from poettering/nspawn-pty-deadlock
nspawn logging deadlock fix
Lennart Poettering [Thu, 17 May 2018 02:33:13 +0000 (22:33 -0400)]
logind: let's change the type of the runtime directory size to uint64_t
Externally it's an uint64_t anyway, and internally we most just
initialize it to physical_memory() which returns uint64_t, hence there's
exactly zero value in using it as size_t internally. Hence, let's fix
that, and use uint64_t everywhere.
Lennart Poettering [Thu, 17 May 2018 02:32:15 +0000 (22:32 -0400)]
util: add debug logging to system_tasks_max()
We should always do debug logging when we eat up error conditions. Let's
do so here too.
Lennart Poettering [Thu, 17 May 2018 02:27:58 +0000 (22:27 -0400)]
util: fix physical_memory() to work correctly on cgroupsv2
Let's look into the right cgroupsv2 attribute.
Also, while we are at it, add debug logging for all error conditions we
eat up silently otherwise.
Yu Watanabe [Thu, 24 May 2018 04:18:28 +0000 (13:18 +0900)]
doc: mention in NEWS that AF_INET{,6} are dropped from logind
Closes #9072.
Lennart Poettering [Wed, 23 May 2018 19:10:39 +0000 (21:10 +0200)]
Merge pull request #9040 from yuwata/resolved-networkd-use-dynamic-user
Set DynamicUser= to resolved and networkd
Franck Bui [Tue, 22 May 2018 12:22:53 +0000 (14:22 +0200)]
install: "user" and "global" scopes are equivalent for user presets
Otherwise querying the preset status of a unit to the user instance gives
incorrect results since in this case the scope used by the manager is
UNIT_FILE_USER.
Lennart Poettering [Wed, 23 May 2018 19:07:22 +0000 (21:07 +0200)]
Merge pull request #9039 from yuwata/fix-device-allow
core: support unit specifiers in IODeviceWeight= and friends
Zbigniew Jędrzejewski-Szmek [Wed, 23 May 2018 12:35:39 +0000 (14:35 +0200)]
Merge pull request #9067 from thedrow/patch-1
Enable ccache and mount it into the build/test container
Will Thompson [Tue, 22 May 2018 14:56:53 +0000 (15:56 +0100)]
tmpfiles: fix documented constant for exit code 73
sysexits.h has:
#define EX_CANTCREAT 73 /* can't create (user) output file */
EX_DATAERR is a copy-paste error from the previous sentence, which is
correct.
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 15:14:48 +0000 (17:14 +0200)]
Merge pull request #9065 from poettering/fixup-tab-double-newline
tree-wide: fix some TABs and double newlines
Lennart Poettering [Tue, 22 May 2018 14:52:50 +0000 (16:52 +0200)]
nspawn: make sure our container PID 1 keeps logging to the original stderr as long as possible
If we log to the pty that is configured as stdin/stdout/stderr of the
container too early we risk filling it up in full before we start
processing the pty from the parent process, resulting in deadlocks.
Let's hence keep a copy of the original tty we were started on before
setting up stdin/stdout/stderr, so that we can log to it, and keep using
it as long as we can.
Since the kernel's pty internal buffer is pretty small this actually
triggered deadlocks when we debug logged at lot from nspawn's child
processes, see: https://github.com/systemd/systemd/pull/9024#issuecomment-
390403674
With this change we won't use the pty at all, only the actual payload we
start will, and hence we won't deadlock on it, ever.
Lennart Poettering [Tue, 22 May 2018 14:51:28 +0000 (16:51 +0200)]
nspawn: make use of log_set_open_when_needed() in nspawn too
Let's make use of log_set_open_when_needed() in nspawn too, i.e. at the
point where we close logging because we are about to rearrange fds,
let's automatically reopen the logging fds when we need them, the same
way as we do that in the service manager. This makes things simpler and
more robust.
Omer Katz [Tue, 22 May 2018 14:48:14 +0000 (17:48 +0300)]
Install ccache in container.
Omer Katz [Tue, 22 May 2018 14:45:19 +0000 (17:45 +0300)]
Enable ccache and mount it into the build/test container.
Lennart Poettering [Mon, 7 May 2018 15:50:31 +0000 (17:50 +0200)]
update TODO
Lennart Poettering [Tue, 22 May 2018 12:39:50 +0000 (14:39 +0200)]
nspawn: let's rename _FORCE_ENUM_WIDTH → _SETTING_FORCE_ENUM_WIDTH
Just some preparation in case we need a similar hack in another enum one
day.
Lennart Poettering [Thu, 17 May 2018 03:43:03 +0000 (23:43 -0400)]
nspawn: similar to the previous patches, also make /etc/localtime handling more configurable
Fixes: #9009
Lennart Poettering [Sat, 12 May 2018 20:17:38 +0000 (13:17 -0700)]
nspawn: complain if people still use --share-system
Lennart Poettering [Sat, 12 May 2018 20:17:16 +0000 (13:17 -0700)]
nspawn: make --link-journal= configurable through .nspawn files, too
Lennart Poettering [Sat, 12 May 2018 19:51:20 +0000 (12:51 -0700)]
nspawn: add a bit of debug logging to resolved_listening()
Lennart Poettering [Sat, 12 May 2018 19:50:57 +0000 (12:50 -0700)]
nspawn: add greater control over how /etc/resolv.conf is handled
Fixes: #8014 #1781
Lennart Poettering [Tue, 22 May 2018 14:14:49 +0000 (16:14 +0200)]
Merge pull request #9062 from poettering/parse-conf-macro
add new CONFIG_PARSER_PROTOTYPE() macro
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 12:48:33 +0000 (14:48 +0200)]
pid1: fix ShowStatus property
It is not const, because a) systemd can bump it on its own if
errors occur, and b) the user can change it using signals.
Also it's not boolean.
$ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager ShowStatus
b true
$ sudo kill -SIGRTMIN+21 1
$ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager ShowStatus
b false
Fixes #4503.
Lennart Poettering [Tue, 22 May 2018 14:08:26 +0000 (16:08 +0200)]
tree-wide: remove some double newlines in headers, too
Lennart Poettering [Tue, 22 May 2018 14:07:18 +0000 (16:07 +0200)]
find-double-newline: look in headers too
Lennart Poettering [Tue, 22 May 2018 14:01:21 +0000 (16:01 +0200)]
tree-wide: fix a couple of TABs
Lennart Poettering [Tue, 22 May 2018 14:00:30 +0000 (16:00 +0200)]
tools: add a script for fixing up TABs
This is similar to "find-double-newline.sh" but looks for TABs that
should not be there.
Yu Watanabe [Tue, 22 May 2018 13:37:34 +0000 (22:37 +0900)]
network: set DynamicUser= to systemd-networkd.service
Yu Watanabe [Sat, 19 May 2018 16:18:21 +0000 (01:18 +0900)]
resolve: enable DynamicUser= for systemd-resolved.service
Yu Watanabe [Tue, 22 May 2018 13:26:22 +0000 (22:26 +0900)]
core: chown RuntimeDirectory= if DynamicUser= is set
When DynamicUser= is set, then RuntimeDirectory= should be always
chowned, as the service unit may enable RuntimeDirectoryPreserve=,
and the uid or gid may changed from the last run.
This also makes easier to migrate the service to use DynamicUser=.
Yu Watanabe [Sat, 19 May 2018 16:55:39 +0000 (01:55 +0900)]
timesync,shared: move logic requesting bus name to shared
Preparation for setting DynamicUser= to other services which
request bus names.
Yu Watanabe [Sat, 19 May 2018 16:09:57 +0000 (01:09 +0900)]
unit: drop After=systemd-sysusers.service from timesyncd
After=systemd-sysusers.service is not necessary, as timesyncd
already enables DynamicUser=.
Arnaud Rebillout [Mon, 21 May 2018 04:10:21 +0000 (11:10 +0700)]
nspawn: support pivot-root option during directory validation
Signed-off-by: Arnaud Rebillout <arnaud.rebillout@collabora.com>
Lennart Poettering [Tue, 22 May 2018 12:30:03 +0000 (14:30 +0200)]
Merge pull request #9059 from keszybz/rm-rf-generators
Allow removing generators dirs on real fs
Lennart Poettering [Tue, 22 May 2018 12:28:38 +0000 (14:28 +0200)]
Merge pull request #9061 from poettering/dump-string-table
add new DUMP_STRING_TABLE() macro and make use of it everywhere
Lennart Poettering [Tue, 22 May 2018 11:23:56 +0000 (13:23 +0200)]
Merge pull request #9058 from keszybz/fun-with-uint64_c
Fun with UINT64_C
Lennart Poettering [Tue, 22 May 2018 11:12:48 +0000 (13:12 +0200)]
conf-parser: make use of free_and_replace() at one more place
Lennart Poettering [Tue, 22 May 2018 11:10:17 +0000 (13:10 +0200)]
tree-wide: port over all code to the new CONFIG_PARSER_PROTOTYPE() macro
This makes most header files easier to look at. Also Emacs gets really
slow when browsing through large sections of overly long prototypes,
which is much improved by this macro.
We should probably not do something similar with too many other cases,
as macros like this might help readability for some, but make it worse
for others. But I think given the complexity of this specific prototype
and how often we use it, it's worth doing.
Lennart Poettering [Tue, 22 May 2018 11:03:19 +0000 (13:03 +0200)]
config-parser: introduce new CONFIG_PARSER_PROTOTYPE() macro
This builds on the previous GENERIC_PARSER_ARGS macro work. I think in
general it is a better idea to declare macros that generate full C
statements instead of just parts of them, hence, let's introduce
CONFIG_PARSER_PROTOTYPE() which defines a full C function prototype,
instead of the pre-existing way of defining the C function prototype
manually, but then using GENERIC_PARSER_ARGS to define its arguments.
This doesn't drop GENERIC_PARSER_ARGS though, but renames it to
CONFIG_PARSER_ARGUMENTS, and changes the ConfigParserCallback function
type to use it. The new name follows more closely how the other symbols
in the header are named.
Lennart Poettering [Tue, 22 May 2018 10:12:44 +0000 (12:12 +0200)]
detect-virt: add new --list command for showing all currently known VM/container envs
Lennart Poettering [Tue, 22 May 2018 10:10:56 +0000 (12:10 +0200)]
tree-wide: port various bits of the tree over to the new DUMP_STRING_TABLE() macro
Lennart Poettering [Tue, 22 May 2018 10:09:59 +0000 (12:09 +0200)]
volatile-mode: use the usual string table macros for implementing volatile_mode_from_string()
Let's shorten our code a bit, and also add the matching _to_string()
call.
Lennart Poettering [Tue, 22 May 2018 10:08:30 +0000 (12:08 +0200)]
coredumpctl: always output proper english sentence
Let's uppercase the first character, and finish them in a full stop.
Lennart Poettering [Tue, 22 May 2018 10:06:54 +0000 (12:06 +0200)]
string-table: add new DUMP_STRING_TABLE() macro
The macro is inspired by the other string table macros, and takes the
same arguments in the same order and dumps a string table to stdout.
Since it's typesafe it's nice to implement this as macro rather than
regular function.
This new macro is useful for implementing commands such as "systemctl -t
help" and similar, i.e. wherever we want to dump all values of an enum
to stdout.
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 09:56:31 +0000 (11:56 +0200)]
Generator dirs might be on a real filesystem
Most of the time, tmpfs is used for /tmp, but this is not required.
Applied to both pid1 and systemd-analyze verify.
Fixes #8592.
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 09:33:01 +0000 (11:33 +0200)]
basic/rm-rf: include the path in error messages
Attempted to remove disk file system under "/tmp/systemd-temporary-aWPkbQ", and we can't allow that.
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 07:13:31 +0000 (09:13 +0200)]
systemd-nspawn: make SettingsMask 64 bit wide
The use of UINT64_C() in the SettingsMask enum definition is misleading:
it does not mean that individual fields have this width. E.g., with
enum {
FOO = UINT64_C(1)
}
sizeof(FOO) gives 4. It only means that the shift is done properly. So
1 << 35 is undefined, but UINT64_C(1) << 35 is the expected 64 bit
constant. Thus, the use UINT64_C() is useful, because we know that the shifts
are done properly, no matter what the value of _RLIMIT_MAX is, but when those
fields are used in expressions, we don't know what size they will be
(probably 4). Let's add a define which "hides" the enum definition behind a
define which gives the same value but is actually 64 bit. I think this is a
nicer solution than requiring all users to cast SETTING_RLIMIT_FIRST before
use.
Fixes #9035.
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 07:36:08 +0000 (09:36 +0200)]
sd-resolve: remove misleading casts
As shown in previous commit, UINT64_C() has no effect here, the field can still
be smaller. Remove it.
Zbigniew Jędrzejewski-Szmek [Tue, 22 May 2018 07:07:35 +0000 (09:07 +0200)]
test-sizeof: show that a small 64 field is not enough to force the enum to be 64 bits
On both 32 and 64 bits, the result is:
enum Enum → 32 bits, unsigned
enum BigEnum → 32 bits, unsigned
enum BigEnum2 → 64 bits, unsigned
big_enum2_pos → 4
big_enum2_neg → 8
The last two lines show that even if the enum is 64 bit, and the field of an
enum is defined with UINT64_C(), the field can still be smaller.
Zbigniew Jędrzejewski-Szmek [Sun, 20 May 2018 20:42:23 +0000 (22:42 +0200)]
man: fix typo in man page citation
Fixes #9045.
Zbigniew Jędrzejewski-Szmek [Sat, 19 May 2018 09:39:57 +0000 (11:39 +0200)]
Yu Watanabe [Sun, 20 May 2018 14:20:24 +0000 (23:20 +0900)]
Merge pull request #9036 from keszybz/rpm-macro-cleanup
rpm macro cleanup
Yu Watanabe [Sat, 19 May 2018 14:59:02 +0000 (23:59 +0900)]
core: support unit specifiers in IODeviceWeight= and friends
Yu Watanabe [Sun, 20 May 2018 14:08:29 +0000 (23:08 +0900)]
core/load-fragment: update log messages
Zbigniew Jędrzejewski-Szmek [Sat, 19 May 2018 15:02:37 +0000 (17:02 +0200)]
rpm: add macros for common configuration dirs
%_environmnentdir /usr/lib/environment.d
%_modulesloaddir /usr/lib/modules-load.d
%_modprobedir /usr/lib/modprobe.d
This makes installing files there more convenient because people don't need to
construct the path from %_prefix/lib/… .
See https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/GBF5WJLTQVSXMHGYGBF3723ZYCWFBR7C/.
Lennart Poettering [Fri, 18 May 2018 18:14:54 +0000 (20:14 +0200)]
fs-util: don't alter errno in unlink_tempfilep()
Functions whose only purpose is to be used with _cleanup_() should not
touch errno, so that failing removals do not alter errno at unexpected
places.
This is already done in unlink_and_freep(), rmdir_and_freep(),
rm_rf_physical_and_freep(), hence do so for unlink_tempfilep(), too.
Follow-up for #9013
Evegeny Vereshchagin [Fri, 18 May 2018 10:52:17 +0000 (10:52 +0000)]
meson: use run_target for generating tags with ctags
In https://github.com/systemd/systemd/pull/6561, `run_target`
was changed to `custom_target`, which inadvertently caused
relative paths to be passed to ctags due to
https://github.com/mesonbuild/meson/issues/3589.
The switch to `run_target` causes absolute paths to be
passed again and makes it easier to jump from file to
file, hopefully delaying the need to exit Vim :-)
Lennart Poettering [Fri, 18 May 2018 18:35:01 +0000 (20:35 +0200)]
sd-resolve: tweak error assignment code a bit, use abs() and regular functions
Let's tweak the assignment of errors a bit, and automatically abs()
errnos, similar to how log_error_errno() and friends does it.
Macros are fine to use, but regular functions usually preferable if
there's no reason to use macros, because they avoid multiple evaluation
and suchlike. Hence, let's just use a regular funciton for assigning
errors, instead of macros.
Follow-up for #8993
Zbigniew Jędrzejewski-Szmek [Sat, 19 May 2018 11:04:21 +0000 (13:04 +0200)]
rpm: simplify redirects to /dev/null
Zbigniew Jędrzejewski-Szmek [Sat, 19 May 2018 11:01:55 +0000 (13:01 +0200)]
rpm: remove confusing --user before --global
Fixes #9027.
David Tardon [Tue, 24 Apr 2018 13:19:38 +0000 (15:19 +0200)]
fix race between daemon-reload and other commands
When "systemctl daemon-reload" is run at the same time as "systemctl
start foo", the latter might hang. That's because commands like start
wait for JobRemoved signal to know when the job is finished. But if the
job is finished during reloading, the signal is never sent.
The hang can be easily reproduced by running
# for ((N=1; N>0; N++)) ; do echo $N ; systemctl daemon-reload ; done
# for ((N=1; N>0; N++)) ; do echo $N ; systemctl start systemd-coredump.socket ; done
in two different terminals. The start command will hang after 1-2
iterations.
This keeps track of jobs that were started before reload and finished
during it and sends JobRemoved after the reload has finished.
Lucas Werkmeister [Fri, 18 May 2018 20:04:35 +0000 (22:04 +0200)]
man: fix typo
Lennart Poettering [Fri, 18 May 2018 19:38:30 +0000 (21:38 +0200)]
Merge pull request #8981 from keszybz/ratelimit-and-dbus
Ratelimit renaming and dbus error message fix
Franck Bui [Fri, 18 May 2018 16:37:56 +0000 (18:37 +0200)]
core: keep the kernel coredump defaults when systemd-coredump is disabled
If systemd-coredump is disabled (at build time), PID1 should keep the
(old) kernel defaults as they are.
David Tardon [Fri, 18 May 2018 14:52:01 +0000 (16:52 +0200)]
localectl: drop duplicate property entry
Lennart Poettering [Fri, 18 May 2018 18:30:12 +0000 (20:30 +0200)]
Merge pull request #8993 from keszybz/sd-resolve-coverity-and-related-fixes
sd-resolve coverity and related fixes
Lennart Poettering [Fri, 18 May 2018 18:25:52 +0000 (20:25 +0200)]
Merge pull request #8985 from yuwata/bus-macro-3
tree-wide: use BUS_DEFINE_PROPERTY_GET* macros
Zbigniew Jędrzejewski-Szmek [Wed, 16 May 2018 09:35:41 +0000 (11:35 +0200)]
fs-util,test: add helper to remove tempfiles
This simplifies the use of tempfiles in tests and fixes "leaked"
temporary files in test-fileio, test-catalog, test-conf-parser.
Not the whole tree is converted.
Lennart Poettering [Fri, 18 May 2018 18:02:43 +0000 (20:02 +0200)]
Merge pull request #9026 from yuwata/followup-9021
core: refuse StateDirectory=private
Yu Watanabe [Fri, 18 May 2018 08:35:23 +0000 (17:35 +0900)]
core: use free_and_replace()
Yu Watanabe [Fri, 18 May 2018 08:34:59 +0000 (17:34 +0900)]
core: fix coding style
Zbigniew Jędrzejewski-Szmek [Fri, 18 May 2018 08:33:10 +0000 (10:33 +0200)]
Merge pull request #8940 from poettering/nspawn-attrs
nspawn: make a couple of additional container parameters configurable
Lennart Poettering [Thu, 17 May 2018 02:15:46 +0000 (22:15 -0400)]
tmpfiles: fix up and complain paths referring to /var/run (instead of /run) automatically
tmpfiles.d relies on merging lines for the same file paths, as well as
detecting conflicts between lines for the same file paths. /var/run is a
prominent case that is an alias for /run, any many tmpfiles snippets
refer to paths in /var/run rather than /run currently, which breaks the
conflict detection and merging.
We can't really fix this comprehensively, as doing so would require us
to resolve symlinks early on, but that's precisely not what we want to
do, as tmpfiles is usually run very early on where the paths might not
be fully available yet (in particular as we might likely create them
ourselves).
Hence, let's at least detect and fix this case for the most prominent
case of this ambiguity, and also log explicitly about this, asking users
to fix the snippets in question so that the merging and conflict
detection works properly again.
David Tardon [Thu, 17 May 2018 13:45:37 +0000 (15:45 +0200)]
inhibit: use pager for systemd-inhibit --list
Yu Watanabe [Fri, 18 May 2018 04:29:26 +0000 (13:29 +0900)]
core: refuse StateDirectory=private
Follow-up for
e8865688735ba3bd34297fa89cca6bde7ba33997 (#9021).
Lennart Poettering [Thu, 17 May 2018 17:52:37 +0000 (19:52 +0200)]
tmpfiles: create /var/{lib,log,cache}/private during early boot
This directory is used by the DynamicUer= stuff when used in combination
with StateDirectory=/LogDirectory=/CacheDirectory=. Let's make sure the
dir exists early on with the right perms. This is not strictly necessary
as we'll also create the dir on demand if it is missing, but in the
interest of grabbing the name early on, and making things more explicit
let's also list this in a tmpfiles.d/ snippet.
Lennart Poettering [Thu, 17 May 2018 02:25:12 +0000 (22:25 -0400)]
core: refuse StateDirectory=private, as our internal DynamicUser=1 symlink is called that way
Let's better be safe than sorry.
Lennart Poettering [Tue, 8 May 2018 15:03:58 +0000 (08:03 -0700)]
nspawn: voidify more things
Lennart Poettering [Wed, 25 Apr 2018 09:23:01 +0000 (11:23 +0200)]
path-util: one more empty_or_root() change
Lennart Poettering [Mon, 7 May 2018 19:57:00 +0000 (21:57 +0200)]
nspawn: split out merging of settings object
Let's separate the loading of the settings object and the merging into
our arg_xyz fields into two.
This will become particularly useful when we eventually are able to load
settings from OCI runtime files in addition to .nspawn files.
Lennart Poettering [Mon, 7 May 2018 19:47:15 +0000 (21:47 +0200)]
nspawn: add a new --cpu-affinity= switch
Similar as the other options added before, this is primarily useful to
provide comprehensive OCI runtime compatbility, but might be useful
otherwise, too.
Lennart Poettering [Mon, 7 May 2018 19:18:25 +0000 (21:18 +0200)]
nspawn: show --help text in a pager
The text is long enough now, and we do auto-paging for systemctl
already, hence let's do it here too.
Lennart Poettering [Mon, 7 May 2018 19:17:09 +0000 (21:17 +0200)]
nspawn: add a new --oom-score-adjust= command line switch
This is primarily useful in order to provide comprehensive OCI runtime
compatibility with nspawn, but might have uses outside of it.
Lennart Poettering [Mon, 7 May 2018 18:45:39 +0000 (20:45 +0200)]
nspawn: properly handle and log about hostname setting errors
Lennart Poettering [Mon, 7 May 2018 18:44:41 +0000 (20:44 +0200)]
process-util: add new helper call for adjusting the OOM score
And let's make use of it in execute.c