platform/core/csapi/xsf.git
4 years agoIn Android : Reverse layout only when default layout direction is the… (#7809)
Elashi [Tue, 22 Oct 2019 16:50:36 +0000 (19:50 +0300)]
In Android : Reverse layout only when default layout direction is the… (#7809)

* In Android : Reverse layout only when default layout direction is the opposite of the user settings (#7393)

* - remove ReverseLayout and just rely on LayoutDirection

* - fix formatting

4 years agoFix random test failures (#8083)
Rui Marinho [Tue, 22 Oct 2019 09:54:50 +0000 (10:54 +0100)]
Fix random test failures (#8083)

* [UITEsts] Ignore vertical test

* [UITests] Ignore 5766 uitest

* [UITests] Ignore UITest 1342

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 21 Oct 2019 08:40:15 +0000 (10:40 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years agoAlways use current dispatcher to invoke wpf timer (#7958) fixes #6957
Konrad Müller [Fri, 18 Oct 2019 14:07:40 +0000 (16:07 +0200)]
Always use current dispatcher to invoke wpf timer (#7958) fixes #6957

4 years ago[MacOS] FIx agains NRE on disposing Entry renderer (#8019)
Rui Marinho [Fri, 18 Oct 2019 12:03:53 +0000 (13:03 +0100)]
[MacOS] FIx agains NRE on disposing Entry renderer (#8019)

4 years ago[MacOS] Fixed NRE with modal navigation (#7900)
Gerald Versluis [Fri, 18 Oct 2019 12:03:43 +0000 (14:03 +0200)]
[MacOS] Fixed NRE with modal navigation (#7900)

* Added repro and fix

* Added UITest

4 years agoFixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElemen...
Jon Robinson Levy [Fri, 18 Oct 2019 10:25:56 +0000 (12:25 +0200)]
Fixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElement, to check if the supplied NavigationPage Eelement has a CurrentPage. If not, an InvalidOperationException is thrown. (Otherwise a NullReferenceException would be thrown at a later point.) (#8034)

4 years agoMake the Refresh View Respect Command CanExecute and add Refreshing event (#7866)
Shane Neuville [Thu, 17 Oct 2019 06:44:25 +0000 (00:44 -0600)]
Make the Refresh View Respect Command CanExecute and add Refreshing event (#7866)

* Make Refresh View respect Command CanExecute

* - force isrefreshing false when isenabled fasle
- Add IsRefreshing Event

* - shift command execution up to xplat code

* - fix ui test

* - cleanup

* - add additional check

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7803.xaml.cs

* - fix flag

4 years ago[iOS] Prevent crash when adding item to source of CollectionView in tab (#7940)
E.Z. Hart [Wed, 16 Oct 2019 20:54:16 +0000 (14:54 -0600)]
[iOS] Prevent crash when adding item to source of CollectionView in tab (#7940)

* Prevent crash when adding item to source of CollectionView that's never been displayed;
fixes #7700

* Fix renaming error in UI test

* Add test and fix for adding groups offscreen

* Fix rebase error

* Remove flags

* Add instructions

* Better instructions

4 years agoCleanup material controls character spacing interactions (#7880)
Shane Neuville [Wed, 16 Oct 2019 16:11:51 +0000 (10:11 -0600)]
Cleanup material controls character spacing interactions (#7880)

* Cleanup material controls and spacing

* - remove left over code

* - remove virtual

* - pr comments

4 years agoRemove requirement for CollectionView Experimental flag (#7907)
E.Z. Hart [Wed, 16 Oct 2019 15:44:47 +0000 (09:44 -0600)]
Remove requirement for CollectionView Experimental flag (#7907)

* CollectionView_Experimental is dead; long live CarouselView_Experimental!

* Change CollectionView enabling button labels to CarouselView for CarouselView tests

* Fix UI tests for Carousel

* Honor the CollectionView_Experimental flag for CarouselView

* Update Issue6963.cs

* Update Issue7817.xaml.cs

* Remove collection view flag settings

4 years ago[Android] Fix recyclerview offsets (#8018) fixes #7993
adrianknight89 [Wed, 16 Oct 2019 10:29:33 +0000 (05:29 -0500)]
[Android] Fix recyclerview offsets (#8018) fixes #7993

4 years agoremove duplicate statement (#8014)
adrianknight89 [Wed, 16 Oct 2019 10:16:00 +0000 (05:16 -0500)]
remove duplicate statement (#8014)

4 years agoFix Material Editor so TextChange delegate isn't removed (#8011)
Shane Neuville [Tue, 15 Oct 2019 22:10:36 +0000 (16:10 -0600)]
Fix Material Editor so TextChange delegate isn't removed (#8011)

* Fix Material Editor so delegate isn't removed

* - fix ui test

4 years agoFix bug 5868 "VisualElement.Unfocus does not work on WPF" (#7883)
Konrad Müller [Tue, 15 Oct 2019 19:24:34 +0000 (21:24 +0200)]
Fix bug 5868 "VisualElement.Unfocus does not work on WPF" (#7883)

* Add repro

* fix bug

4 years agoFix shell to correctly pick visible item (#8009)
Shane Neuville [Tue, 15 Oct 2019 18:44:22 +0000 (12:44 -0600)]
Fix shell to correctly pick visible item (#8009)

- when items are removed

4 years agoFix iOS crash when group type is not an IList (#7955)
E.Z. Hart [Tue, 15 Oct 2019 18:19:36 +0000 (12:19 -0600)]
Fix iOS crash when group type is not an IList (#7955)

4 years agoFixed issue setting Position in CarouselView (#7901) fixes #7865
Javier Suárez Ruiz [Tue, 15 Oct 2019 14:37:41 +0000 (16:37 +0200)]
Fixed issue setting Position in CarouselView (#7901) fixes #7865

* Added sample file

* Updated sample

* Fixed the issue on Android and iOS

* Updated IsScrolling property from UWP CarouselView renderer

* Added repro sample instructions

* Update Issue7865.xaml.cs

* [iOS] Update IsScrolling from renderer

4 years agoFixed build error (merge) (#8024)
Javier Suárez Ruiz [Tue, 15 Oct 2019 13:18:03 +0000 (15:18 +0200)]
Fixed build error (merge) (#8024)

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Tue, 15 Oct 2019 12:12:49 +0000 (14:12 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years agoLabel size doesn't change when text changed (#7942)
bill2004158 [Tue, 15 Oct 2019 10:53:31 +0000 (18:53 +0800)]
Label size doesn't change when text changed (#7942)

- fixes #7888

4 years agoAdded sample (#7650)
Javier Suárez Ruiz [Tue, 15 Oct 2019 08:37:57 +0000 (10:37 +0200)]
Added sample (#7650)

4 years ago[iOS] Various fixes with ItemsViewController (#7618)
adrianknight89 [Tue, 15 Oct 2019 08:32:26 +0000 (03:32 -0500)]
[iOS] Various fixes with ItemsViewController (#7618)

* various fixes

* remove comment

* move delegator setting to ViewDidLoad

* fix delegator

* fix accessibility issue

4 years ago[Android] speed up development builds (#7834)
Shane Neuville [Tue, 15 Oct 2019 05:10:00 +0000 (23:10 -0600)]
[Android] speed up development builds (#7834)

* speed up development builds android

* - remove extra property group

* - add cake descriptions

* - fix

* - remove shared runtime

* - add check for TF_Build

4 years agoFixed ItemSpacing, NumberOfSideItems, PeekAreaInsets and Snap in UWP CarouselView...
Javier Suárez Ruiz [Tue, 15 Oct 2019 00:07:11 +0000 (02:07 +0200)]
Fixed ItemSpacing, NumberOfSideItems, PeekAreaInsets and Snap in UWP CarouselView. (#7930)

4 years ago[Android] Fixed a crash on CollectionView changing ItemsSource (#7945)
Javier Suárez Ruiz [Mon, 14 Oct 2019 21:24:53 +0000 (23:24 +0200)]
[Android] Fixed a crash on CollectionView changing ItemsSource (#7945)

* Added repro sample

* Fixed the crash

4 years agoValidate on Date part only (#7766) fixes #5784
Glenn Versweyveld [Mon, 14 Oct 2019 15:56:57 +0000 (17:56 +0200)]
Validate on Date part only (#7766) fixes #5784

* Validate on Date part only

Fixes #5784

* Add unittest

* Both sides should be Date only validated

4 years ago[Android] Fixed CarouselView string EmptyView not displayed (#7822) fixes #7792
Javier Suárez Ruiz [Mon, 14 Oct 2019 15:48:33 +0000 (17:48 +0200)]
[Android] Fixed CarouselView string EmptyView not displayed (#7822) fixes #7792

* Added sample

* Updated sample

* Fixed CarouselView issue not displaying string EmptyView

* Fixed wrong controls shared projitems paths

4 years agoFix [macOS] navigation page doesn't hide previous page (#7921)
melimion [Mon, 14 Oct 2019 11:57:44 +0000 (14:57 +0300)]
Fix [macOS] navigation page doesn't hide previous page (#7921)

* fix

* test added

* more transparency added to test

* test simplified

* test title fix

4 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 14 Oct 2019 07:03:32 +0000 (09:03 +0200)]
Merge branch '4.1.0' into 4.2.0

4 years agoMove CollectionView UWP implementation to generics (#7911)
E.Z. Hart [Fri, 11 Oct 2019 23:11:42 +0000 (17:11 -0600)]
Move CollectionView UWP implementation to generics (#7911)

* Clean up implementation with generics and get rid of awkward casts

* Save some unnecessary casts and switching on CarouselView

4 years agoFixed crash on UWP Switch (UpdateThumbColor) (#7932)
Javier Suárez Ruiz [Fri, 11 Oct 2019 11:43:08 +0000 (13:43 +0200)]
Fixed crash on UWP Switch (UpdateThumbColor) (#7932)

4 years ago[Tizen] Fix RenderWith attributes for Forwarders (#7854)
Kangho Hur [Fri, 11 Oct 2019 00:46:57 +0000 (09:46 +0900)]
[Tizen] Fix RenderWith attributes for Forwarders (#7854)

4 years agoGenerics for CollectionView iOS implementation (#7918)
E.Z. Hart [Thu, 10 Oct 2019 23:21:22 +0000 (17:21 -0600)]
Generics for CollectionView iOS implementation (#7918)

* Make the ItemsView type generic

* Make controller type generic

* Generic all the things, and split up the delegators

Fix rebase error

4 years agoRevert "Fixed crash on UWP Switch (UpdateThumbColor)"
Javier Suárez Ruiz [Thu, 10 Oct 2019 16:09:50 +0000 (18:09 +0200)]
Revert "Fixed crash on UWP Switch (UpdateThumbColor)"

This reverts commit 10a0f4e0b3ded2480b49faae0b301980fbf4dc65.

4 years agoFixed crash on UWP Switch (UpdateThumbColor)
Javier Suárez Ruiz [Thu, 10 Oct 2019 16:08:43 +0000 (18:08 +0200)]
Fixed crash on UWP Switch (UpdateThumbColor)

4 years ago[Android/iOS] Fixed ItemsUpdatingScrollMode on CarouselView (#7872)
Javier Suárez Ruiz [Thu, 10 Oct 2019 15:31:05 +0000 (17:31 +0200)]
[Android/iOS] Fixed ItemsUpdatingScrollMode on CarouselView (#7872)

* Added repro sample

* Updated sample

* Fixed issue on Android

* Fixed issue on iOS

* Updated sample

* Updated instructions

* Fixed property changed propagation from CarouselViewRenderer to ItemsViewRenderer

4 years ago[UWP] [iOS] Verify selected items exist when updating native selections (#7902)
E.Z. Hart [Thu, 10 Oct 2019 15:16:38 +0000 (09:16 -0600)]
[UWP] [iOS] Verify selected items exist when updating native selections (#7902)

* Add selection synchronization tests

* Resync native selection after ItemsSource is updated

* Update native selection on iOS when changing ItemsSource; prevent crash when
selection contains items not in source; fixes #6963

* Automated test

4 years ago[X] binding find the right indexer (#7896)
Stephane Delcroix [Thu, 10 Oct 2019 08:19:04 +0000 (10:19 +0200)]
[X] binding find the right indexer (#7896)

supports having multiple indexers on a bound source, try to invoke the right one

- fixes #7837

4 years agoFixed SnapPointsType discrepancy between CarouselView and LinearItemsLayout (#7893)
Javier Suárez Ruiz [Wed, 9 Oct 2019 18:14:38 +0000 (20:14 +0200)]
Fixed SnapPointsType discrepancy between CarouselView and LinearItemsLayout (#7893)

4 years agoImplement grouping for UWP CollectionView (#7697)
E.Z. Hart [Wed, 9 Oct 2019 17:56:18 +0000 (11:56 -0600)]
Implement grouping for UWP CollectionView (#7697)

* Implement grouping for UWP CollectionView

* Clean up CollectionViewSource on teardown

4 years ago[iOS] Fixed crash displaying strings in CarouselView (#7858)
Javier Suárez Ruiz [Wed, 9 Oct 2019 07:52:27 +0000 (09:52 +0200)]
[iOS] Fixed crash displaying strings in CarouselView (#7858)

* Added repro sample

* Fixed the crash on DequeueReusableCell registering the correct cell types

* Added instructions to the test

* Fixed wrong paths on Controls Issues projitems

4 years agoShell android dispose (#7768)
Shane Neuville [Tue, 8 Oct 2019 18:16:03 +0000 (12:16 -0600)]
Shell android dispose (#7768)

* Better dispose of Android shell renderers

* - fixup a few dispose paths

* - set page to null

* - header container

4 years ago[iOS] Fix issue changing the ItemTemplate on CollectionView dynamically (#7743)
Javier Suárez Ruiz [Tue, 8 Oct 2019 18:06:07 +0000 (20:06 +0200)]
[iOS] Fix issue changing the ItemTemplate on CollectionView dynamically (#7743)

* Fixed Issue 7742: Change CollectionView ItemTemplate programmatically

* Fixed typo

* Removed invalid test

4 years ago[iOS] Alternative proposal for PR 7794 (#7811)
adrianknight89 [Tue, 8 Oct 2019 15:44:49 +0000 (10:44 -0500)]
[iOS] Alternative proposal for PR 7794 (#7811)

* emptyview fix

* fix

* added collectionview flag

* added using for List

* fix formatting

* fix formatting 2

* fix formatting 3

* fixes

* fix test

4 years agoIgnore empty cache and don't cache invalid stream (#7764)
Shane Neuville [Mon, 7 Oct 2019 15:41:24 +0000 (09:41 -0600)]
Ignore empty cache and don't cache invalid stream (#7764)

* Ignore empty cache and don't cache invalid stream

* - msbuild locator

4 years ago[X] pass the RootAssembly to DT Context (#7853)
Stephane Delcroix [Mon, 7 Oct 2019 14:09:51 +0000 (16:09 +0200)]
[X] pass the RootAssembly to DT Context (#7853)

regression introduced by #7531

- fixes #7830

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 7 Oct 2019 09:54:46 +0000 (11:54 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years ago[macOS] Fix Image Rotation issue (#7815) fixes #5395
melimion [Fri, 4 Oct 2019 14:08:45 +0000 (17:08 +0300)]
[macOS] Fix Image Rotation issue (#7815) fixes #5395

* AnchorPoint fix

* rotation and translationY direction fix

* clipping fix

* test added

* anchor point and position translation fixed

* test update

4 years ago[iOS] Fix hard crash when horizontal GridViewLayout is refreshed (#7612) fixes #7593
adrianknight89 [Fri, 4 Oct 2019 00:36:53 +0000 (19:36 -0500)]
[iOS] Fix hard crash when horizontal GridViewLayout is refreshed (#7612) fixes #7593

* fix refreshview issue

* fix path

* remove extra line after rebase

4 years ago[Android] Fix crash changing the Application MainPage (#7776) fixes #7283
Javier Suárez Ruiz [Fri, 4 Oct 2019 00:32:03 +0000 (02:32 +0200)]
[Android] Fix crash changing the Application MainPage (#7776) fixes #7283

* Fixed Issue 7283 - Fix crash changing the Application MainPage

* Update Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs

* Fix build

4 years agoRemove Material Frame Renderer from Frame element on dispose of renderer (#7752)...
Shane Neuville [Thu, 3 Oct 2019 23:20:07 +0000 (17:20 -0600)]
Remove Material Frame Renderer from Frame element on dispose of renderer (#7752) fixes #7339

* [iOS] remove renderer from Frame on dispose

* - add uitests

4 years agoFixed PeekAreaInsets not working on iOS (#7802)
Javier Suárez Ruiz [Thu, 3 Oct 2019 22:47:16 +0000 (00:47 +0200)]
Fixed PeekAreaInsets not working on iOS (#7802)

4 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Thu, 3 Oct 2019 12:35:23 +0000 (13:35 +0100)]
Merge branch '4.2.0' into 4.3.0

4 years agoMerge branch '4.1.0' into 4.2.0
Rui Marinho [Thu, 3 Oct 2019 12:34:25 +0000 (13:34 +0100)]
Merge branch '4.1.0' into 4.2.0

4 years agoRevert "ios: raise touch event on touchbegin. (#6989) fixes #3320" (#7787)
Rui Marinho [Thu, 3 Oct 2019 08:50:00 +0000 (09:50 +0100)]
Revert "ios: raise touch event on touchbegin. (#6989) fixes #3320" (#7787)

This reverts commit dca82ed828e3fc1b3fede8d376ea8c4abf56d4ca.

4 years agoUpdate Build.Locator (#7783)
Rui Marinho [Wed, 2 Oct 2019 19:33:03 +0000 (20:33 +0100)]
Update Build.Locator (#7783)

4 years agoRemove duplicate items
Rui Marinho [Wed, 2 Oct 2019 14:20:44 +0000 (15:20 +0100)]
Remove duplicate items

4 years agoFix merge
Rui Marinho [Wed, 2 Oct 2019 13:42:26 +0000 (14:42 +0100)]
Fix merge

4 years ago[X] send VisualTreeChanged for root (#7747)
Stephane Delcroix [Wed, 2 Oct 2019 13:13:24 +0000 (15:13 +0200)]
[X] send VisualTreeChanged for root (#7747)

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Wed, 2 Oct 2019 13:08:09 +0000 (15:08 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Wed, 2 Oct 2019 13:06:24 +0000 (15:06 +0200)]
Merge branch '4.1.0' into 4.2.0

4 years ago[HR] allow the HR test harness to clear cache (#7774)
Stephane Delcroix [Wed, 2 Oct 2019 12:40:36 +0000 (14:40 +0200)]
[HR] allow the HR test harness to clear cache (#7774)

4 years agoFixed clipping when using FontImageSource (#7607) fixes #6491 fixes #7469 fixes ...
Gerald Versluis [Wed, 2 Oct 2019 07:57:22 +0000 (09:57 +0200)]
Fixed clipping when using FontImageSource (#7607) fixes #6491 fixes #7469 fixes #7414

* Fixed issue

* Fixes #7469

4 years agoFixed crash setting the MainPage on teh OnStart method on UWP (#7749) fixes #7537
Javier Suárez Ruiz [Wed, 2 Oct 2019 07:56:00 +0000 (09:56 +0200)]
Fixed crash setting the MainPage on teh OnStart method on UWP (#7749) fixes #7537

4 years agoNRE fix reported in 7399 (#7704) fixes #7399
kingces95 [Wed, 2 Oct 2019 07:54:12 +0000 (00:54 -0700)]
NRE fix reported in 7399 (#7704) fixes #7399

4 years ago[UWP] Fix crash on Switch Renderer when a custom renderer provides Color objects...
Javier Suárez Ruiz [Wed, 2 Oct 2019 07:53:15 +0000 (09:53 +0200)]
[UWP] Fix crash on Switch Renderer when a custom renderer provides Color objects instead of Brush (#7760) fixes #7253

* Fixed 7253 -  UWP Switch custom Renderer using custom colors throws exception

* Fixed merge error in the code

4 years ago[ControlGallery] Add more CarouselView samples (#7677)
Javier Suárez Ruiz [Wed, 2 Oct 2019 00:20:56 +0000 (02:20 +0200)]
[ControlGallery] Add more CarouselView samples (#7677)

* Added new CarouselView Core Gallery sample

* Fixed typo

4 years agoFix use of ToolbarItem.Order on Android Shell (#7718)
Gerald Versluis [Tue, 1 Oct 2019 17:52:52 +0000 (19:52 +0200)]
Fix use of ToolbarItem.Order on Android Shell (#7718)

fixes #6127

4 years ago[UWP] Make EmptyView work in UWP CarouselView (#7724)
E.Z. Hart [Tue, 1 Oct 2019 16:12:09 +0000 (10:12 -0600)]
[UWP] Make EmptyView work in UWP CarouselView (#7724)

* Make EmptyView work in UWP CarouselView

* Update Xamarin.Forms.Core/Items/CarouselView.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
4 years agoios: raise touch event on touchbegin. (#6989) fixes #3320
v-haroha [Tue, 1 Oct 2019 15:59:59 +0000 (11:59 -0400)]
ios: raise touch event on touchbegin. (#6989) fixes #3320

* ios: raise touch event on touchbegin.

* bugfix - listview highlight on tap, select on tap release
updated touch gester to highlight on Touchbegin and select on touchend. Also remove highlight when tab view is scrolling.

* - fix CI

* - fix CI

4 years ago[Android/iOS] Expose CollectionView scroll listener (#7737)
adrianknight89 [Tue, 1 Oct 2019 15:43:03 +0000 (10:43 -0500)]
[Android/iOS] Expose CollectionView scroll listener (#7737)

* expose scroll listener

* expose ios delegator creation

4 years agoUpdate iOS MDP Tablet Renderer to use current APIS for Master Behavior (#7705) fixes...
Shane Neuville [Tue, 1 Oct 2019 15:35:56 +0000 (09:35 -0600)]
Update iOS MDP Tablet Renderer to use current APIS for Master Behavior (#7705) fixes #7556

* Update iOS MDP Tablet Renderer to current APIS for Master Behavior

* - fix build

4 years agoInvalidate layout on ViewCell if Measurements change (#7755)
Shane Neuville [Tue, 1 Oct 2019 15:21:08 +0000 (09:21 -0600)]
Invalidate layout on ViewCell if Measurements change (#7755)

4 years ago[Android] CarouselView problems updating ObservableCollection (#7693) fixes #7678
Javier Suárez Ruiz [Mon, 30 Sep 2019 18:07:21 +0000 (20:07 +0200)]
[Android] CarouselView problems updating ObservableCollection (#7693) fixes #7678

* Fixed 7678: [Android] CarouselView binded to a new ObservableCollection filled with Items does not render content

* Added test instructions

* Fixed build error

* Updated sample model name

4 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Mon, 30 Sep 2019 01:29:36 +0000 (02:29 +0100)]
Merge branch '4.2.0' into 4.3.0

4 years ago[Android] Fix FlowDirection for Labels (#7614) fixes #7512
adrianknight89 [Mon, 30 Sep 2019 00:56:22 +0000 (19:56 -0500)]
[Android] Fix FlowDirection for Labels (#7614) fixes #7512

* fix textview flow direction

* removed Details from model

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7512.xaml.cs

Co-Authored-By: Rui Marinho <me@ruimarinho.net>
4 years ago[Android] Remove ripple effect on CollectionView item when SelectionMode is None...
adrianknight89 [Sun, 29 Sep 2019 21:41:35 +0000 (16:41 -0500)]
[Android] Remove ripple effect on CollectionView item when SelectionMode is None (#7615)

* fix ripple effect

* revert changes in core

4 years agoHandle case where GetRenderer retuns null (#7566) Fixes #7563
Stuart Lang [Sun, 29 Sep 2019 21:01:37 +0000 (22:01 +0100)]
Handle case where GetRenderer retuns null (#7566)  Fixes #7563

4 years ago[Android/iOS] Handle dynamically switching between item layouts in CollectionView...
adrianknight89 [Sat, 28 Sep 2019 23:50:22 +0000 (18:50 -0500)]
[Android/iOS] Handle dynamically switching between item layouts in CollectionView (#7613) fixes #5354

* switch between item layouts

* drop private

* added ui test

4 years agoUWP fixes for lower target sdk on VS 2017 (#7722)
Shane Neuville [Sat, 28 Sep 2019 23:42:14 +0000 (17:42 -0600)]
UWP fixes for lower target sdk on VS 2017 (#7722)

* Set UWP to lower target framework

* - mono version

* - dotnet core

* - dotnet core

* - dotnet core

* - mono

* - remove sdks

* - new sdk for mac targets

* - mono path

* - fix mono version

* - update unit test

4 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Sat, 28 Sep 2019 01:27:54 +0000 (02:27 +0100)]
Merge branch '4.2.0' into 4.3.0

4 years agoSetup public and provisionator based provisioning of SDKS (#7458)
Shane Neuville [Sat, 28 Sep 2019 01:01:00 +0000 (19:01 -0600)]
Setup public and provisionator based provisioning of SDKS (#7458)

* general provisioning

* - remove android

* - add android in

* - split up provisioning

* Update build.cake

* - increment versions

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* - fix android

* - version

* - fix varialbes

* - NUGET_VERSION

* - set on parameters

* - fix parameters

* - nuget build step

* - fix powershell

* - merge UI Test fixes in

* - squash

* - cleanup provisionator

* - fix missing names

* - simplify

* - simplify

* - provisionator

* - provisionator

* JavaSDK build path hack

* - turn off default provisioning

* - windows image

* - remove sdk installs from cake

* - sdk manager installs

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* - conditional core

* - conditional core

* - change to conditions

* - make the same

* - add better naming

* - sdks

* - user better links

4 years ago[Android] Fixed issue changing the ItemTemplate on CarouselView (#7628) fixes #7395
Javier Suárez Ruiz [Fri, 27 Sep 2019 22:06:53 +0000 (00:06 +0200)]
[Android] Fixed issue changing the ItemTemplate on CarouselView (#7628) fixes #7395

* Fixed Issue 7395 - Changing ItemTemplate does not work as expected (Android)

* Added instructions to Issue7395

* Updated Core Gallery sample (instructions)

4 years agoFix NRE for 7301 (#7706)
kingces95 [Fri, 27 Sep 2019 20:28:46 +0000 (10:28 -1000)]
Fix NRE for 7301 (#7706)

4 years ago[UWP] Reduce allocations and fix memory leak in CollectionView (#7608)
E.Z. Hart [Fri, 27 Sep 2019 17:41:04 +0000 (11:41 -0600)]
[UWP] Reduce allocations and fix memory leak in CollectionView (#7608)

* Checkpoint

* Fix leak caused by CollectionViewSource

* Simplify ItemTemplateEnumerator

* Reduce allocations in simple IList source scenarios on UWP

* Revert debugging changes

4 years agoFix binding on test page to remove IsDragging errors
E.Z. Hart [Fri, 27 Sep 2019 15:56:42 +0000 (09:56 -0600)]
Fix binding on test page to remove IsDragging errors

4 years agoWait for test to load before scrolling images (#7702)
Shane Neuville [Fri, 27 Sep 2019 15:23:13 +0000 (09:23 -0600)]
Wait for test to load before scrolling images (#7702)

4 years ago[X] Pass the current assembly to parsing context (#7550)
Stephane Delcroix [Fri, 27 Sep 2019 05:59:52 +0000 (07:59 +0200)]
[X] Pass the current assembly to parsing context (#7550)

In case of Xaml-only RD, the rootAssembly is different from the assembly
of the rootType

- fixes #7531

4 years ago[RefreshView] Fire RefreshCommand setting IsRefreshing (#7398)
Javier Suárez Ruiz [Fri, 27 Sep 2019 05:19:12 +0000 (07:19 +0200)]
[RefreshView] Fire RefreshCommand setting IsRefreshing (#7398)

* refresh view ui tests

* Fixed issue notifying changes in IsRefreshing property

* Fire RefreshCommand setting IsRefreshing to true

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Update Xamarin.Forms.Core.UITests.Shared/UITestCategories.cs

* Added RefreshView UITests

* - ui test with swipe

* - change to drag

* - fix ui test

* - remove extra property changed event

4 years ago[Android] 28+ Make non-visible pickers work again (#7289)
Gerald Versluis [Fri, 27 Sep 2019 05:18:17 +0000 (22:18 -0700)]
[Android] 28+ Make non-visible pickers work again (#7289)

* Repro + fix

* Final fix

* Update Issue5159.cs

* Fixes #7311

* Test tweaks

* Update TimePickerRenderer.cs

* Revert "Update TimePickerRenderer.cs"

This reverts commit 06c1172d2501ec533cdf5b1eabafa1d402687980.

* Update TimePickerRenderer.cs

* Update TimePickerRenderer.cs

* - added instructions

4 years agoMerge branch '4.2.0' into 4.3.0
Samantha Houts [Fri, 27 Sep 2019 00:23:42 +0000 (17:23 -0700)]
Merge branch '4.2.0' into 4.3.0

4 years agoJavaSDK build path hack (#7707)
Shane Neuville [Fri, 27 Sep 2019 00:16:10 +0000 (18:16 -0600)]
JavaSDK build path hack (#7707)

4 years ago[iOS] Fix MeasureFirstItem for CollectionView (#7622)
adrianknight89 [Fri, 27 Sep 2019 00:16:03 +0000 (19:16 -0500)]
[iOS] Fix MeasureFirstItem for CollectionView (#7622)

* fix MeasureFirstItem

* added test

* changed file name

* fix path

* added text

* remove 5455

* drop private
fixes #7621

4 years ago[BUG/iOS] Fixed CollectionView Insets ItemSpacing (#7158)
Gerald Versluis [Thu, 26 Sep 2019 17:23:41 +0000 (10:23 -0700)]
[BUG/iOS] Fixed CollectionView Insets ItemSpacing (#7158)

* Fix 7035

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Update ItemsViewLayout.cs

* Update test case to show span issue

* Update AppDelegate.cs

Remove test setting

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Update Issue7035.xaml

4 years agofix android foreground tinting (#7682) fixes #7577
Shane Neuville [Thu, 26 Sep 2019 09:29:32 +0000 (03:29 -0600)]
fix android foreground tinting (#7682) fixes #7577

4 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Thu, 26 Sep 2019 09:12:54 +0000 (10:12 +0100)]
Merge branch '4.2.0' into 4.3.0

4 years agofix android apk path for ui tests (#7657)
Shane Neuville [Wed, 25 Sep 2019 16:49:26 +0000 (10:49 -0600)]
fix android apk path for ui tests (#7657)

4 years agoonly set elevation on Lollipop and up (#7662)
Shane Neuville [Wed, 25 Sep 2019 14:43:20 +0000 (08:43 -0600)]
only set elevation on Lollipop and up (#7662)

4 years agoTry catch Update Bitmap and equate null to empty for FontFamily Check (#7611) fixes...
Shane Neuville [Wed, 25 Sep 2019 00:35:33 +0000 (18:35 -0600)]
Try catch Update Bitmap and equate null to empty for FontFamily Check (#7611) fixes #7598 fixes #7597