Steve Holme [Sat, 16 Nov 2013 12:00:30 +0000 (12:00 +0000)]
tests: Added SMTP VRFY command tests
Steve Holme [Sat, 16 Nov 2013 11:11:45 +0000 (11:11 +0000)]
ftpserver.pl: Added support for new SMTP commands
Steve Holme [Fri, 15 Nov 2013 22:20:56 +0000 (22:20 +0000)]
smtp: Fixed broken RCPT TO from commit
0ea4a80bb23666
Daniel Stenberg [Fri, 15 Nov 2013 21:43:34 +0000 (22:43 +0100)]
smtp_state_mail_resp: removed unused variable 'smtp'
Steve Holme [Fri, 15 Nov 2013 21:15:38 +0000 (21:15 +0000)]
DOCS: Updated curl_easy_setopt.3 following recent SMTP changes
* Added information about the verify and expand commands to
CURLOPT_MAIL_RCPT.
* Reworked CURLOPT_CUSTOMREQUEST section, adding information about IMAP
and SMTP custom commands.
Steve Holme [Fri, 15 Nov 2013 20:55:55 +0000 (20:55 +0000)]
DOCS: Updated manpage following recent SMTP modifications
* Added SMTP section to --request
* Expanded --mail-rcpt to describe the usage when using the verify and
expand commands.
Steve Holme [Fri, 15 Nov 2013 18:30:04 +0000 (18:30 +0000)]
smtp: Simplified the next RCPT TO logic
Steve Holme [Fri, 15 Nov 2013 20:35:43 +0000 (20:35 +0000)]
lib1507.c: Added missing set of CURLOPT_UPLOAD option
Although this option should have already been set, the SMTP module can
now download information from and send instructional commands to, an
SMTP server, requiring the option to be set in order to perform a mail
transfer.
Steve Holme [Fri, 15 Nov 2013 20:22:01 +0000 (20:22 +0000)]
smtp.c: Fixed trailing whitespace
Steve Holme [Fri, 15 Nov 2013 18:20:12 +0000 (18:20 +0000)]
smtp: Added support for VRFY and EXPN commands
Steve Holme [Fri, 15 Nov 2013 16:10:05 +0000 (16:10 +0000)]
smtp: Added support for NOOP and RSET commands
Steve Holme [Fri, 15 Nov 2013 12:50:37 +0000 (12:50 +0000)]
smtp: Fixed handling of multiline server greeting responses
Incorrectly processed multiline server greeting responses as "wanted"
continue responses in smtp_endofresp(), from commit
f16c0de4e9bbe3,
which in turn broke the SMTP server detection in the test suite,
because the EHLO command would not be sent.
Steve Holme [Fri, 15 Nov 2013 12:14:09 +0000 (12:14 +0000)]
smtp.c: Fixed compilation error from commit
f16c0de4e9bbe3
warning: unused variable 'smtpc'
Steve Holme [Fri, 15 Nov 2013 10:54:47 +0000 (10:54 +0000)]
smtp: Fixed processing of more than one response when sent in same packet
Added a loop to smtp_statemach_act() in which Curl_pp_readresp() is
called until the cache is drained. Without this multiple responses
received in a single packet could result in a hang or delay.
Steve Holme [Fri, 15 Nov 2013 10:46:29 +0000 (10:46 +0000)]
smtp: Moved EHLO response handling to smtp_state_ehlo_resp()
Similar to the processing of untagged CAPABILITY responses in IMAP moved
the processing of multiline EHLO responses to smtp_state_ehlo_resp() and
introduced an internal response code of one to differentiate a multiline
continuation from the end of command. This also allows for the separate
processing of multiline responses from commands such as VRFY and EXPN.
Steve Holme [Thu, 14 Nov 2013 20:43:15 +0000 (20:43 +0000)]
connect: Forgot to correct line endings before push in commit
ed1662c374361a
Björn Stenberg [Tue, 12 Nov 2013 20:09:03 +0000 (21:09 +0100)]
connect: Return the socket descriptor even on fail
singleipconnect() did not return the open socket descriptor on some
errors, thereby sometimes causing a socket leak. This patch ensures
the socket is always returned.
Daniel Stenberg [Thu, 14 Nov 2013 02:58:25 +0000 (18:58 -0800)]
configure: Fix test with -Werror=implicit-function-declaration
The ipv6 auto-detect test in configure returns a false negative when
CFLAGS contains -Werror=implicit-function-declaration. (I have been
using this flag to detect code issues that would result in SEGVs on
x86_64-cygwin.)
Patch-by: Yaakov Selkowitz
Bug: http://curl.haxx.se/bug/view.cgi?id=1304
Steve Holme [Wed, 13 Nov 2013 17:31:42 +0000 (17:31 +0000)]
test825: Corrected typo from commit
b29217d0d682d4
Steve Holme [Wed, 13 Nov 2013 10:12:01 +0000 (10:12 +0000)]
RELEASE-NOTES: Synced with
bde901ad89a6f1
Steve Holme [Wed, 13 Nov 2013 09:17:15 +0000 (09:17 +0000)]
test922: Corrected title to match other OAuth 2.0 tests
Steve Holme [Wed, 13 Nov 2013 09:12:15 +0000 (09:12 +0000)]
tests: Added IMAP OAuth 2.0 authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 09:02:20 +0000 (09:02 +0000)]
tests: Added IMAP NTLM authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 08:52:25 +0000 (08:52 +0000)]
tests: Added IMAP login authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 08:42:30 +0000 (08:42 +0000)]
tests: Added IMAP plain authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 08:35:13 +0000 (08:35 +0000)]
test873: Use proper padding in NTLM responses
Nick Zitzmann [Wed, 13 Nov 2013 02:26:20 +0000 (20:26 -0600)]
darwinssl: check for SSLSetSessionOption() presence when toggling BEAST
Even though this is only a formality (since not many people build on
Mavericks while targeting Leopard), since we still support Leopard
at the earliest, we might as well be pedantic.
Nick Zitzmann [Wed, 13 Nov 2013 02:18:04 +0000 (20:18 -0600)]
darwinssl: PKCS#12 import feature now requires Lion or later
It turns out that some of the constants necessary to make this feature
work are missing from Snow Leopard's Security framework even though
they are defined in the headers.
Bug: http://curl.haxx.se/mail/lib-2013-11/0076.html
Reported by: myriachan
Steve Holme [Wed, 13 Nov 2013 00:33:00 +0000 (00:33 +0000)]
tests: Added POP3 OAuth 2.0 authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 00:23:03 +0000 (00:23 +0000)]
tests: Added POP3 NTLM authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 00:13:06 +0000 (00:13 +0000)]
tests: Added POP3 login authentication with initial response test
Steve Holme [Wed, 13 Nov 2013 00:03:09 +0000 (00:03 +0000)]
tests: Added POP3 plain authentication with initial response test
Steve Holme [Tue, 12 Nov 2013 20:29:58 +0000 (20:29 +0000)]
TODO: Added auth= in URLs to the wish list for HTTP
Steve Holme [Tue, 12 Nov 2013 19:01:04 +0000 (19:01 +0000)]
curl_easy_setopt: Added the ability to set the login options separately
Rather than set the authentication options as part of the login details
specified in the URL, or via the older CURLOPT_USERPWD option, added a
new libcurl option to allow the login options to be set separately.
Daniel Stenberg [Tue, 12 Nov 2013 17:28:07 +0000 (09:28 -0800)]
curl.1: mention that -O does no URL decoding
Tomas Hoger [Mon, 11 Nov 2013 15:20:14 +0000 (16:20 +0100)]
curl_easy_setopt.3: clarify CURLOPT_SSL_VERIFYHOST documentation
- better describe what happens when 1 is specified as parameter
- clarify what "is ignored" means for NSS builds
Steve Holme [Tue, 12 Nov 2013 12:34:56 +0000 (12:34 +0000)]
runtests.pl: Added SSPI detection
Steve Holme [Tue, 12 Nov 2013 09:59:22 +0000 (09:59 +0000)]
multi: Small code tidy up to avoid hard return
Steve Holme [Tue, 12 Nov 2013 09:42:59 +0000 (09:42 +0000)]
tests: Updated CRAM-MD5 tests to use test user details
Björn Stenberg [Mon, 11 Nov 2013 22:43:48 +0000 (23:43 +0100)]
multi: Set read socket when returning READSOCK(0)
This patch fixes and issue introduced in commit
7d7df831981fee, if the
tunnel state was TUNNEL_CONNECT, waitconnect_getsock() would return a
bitmask indicating a readable socket but never stored the socket in the
return array.
Daniel Stenberg [Mon, 11 Nov 2013 07:46:27 +0000 (08:46 +0100)]
bump: next release will be 7.34.0
Due to all the news and changes.
Björn Stenberg [Thu, 7 Nov 2013 23:09:20 +0000 (00:09 +0100)]
connect: Close temporary sockets in conn_free()
The temporary sockets used for Happy Eyeballs were not closed properly,
if curl exited prematurely, which this patch fixes.
Steve Holme [Sun, 10 Nov 2013 20:22:44 +0000 (20:22 +0000)]
tests: Corrected titles of POP3 and SMTP OAuth 2.0 tests
Steve Holme [Sun, 10 Nov 2013 20:20:20 +0000 (20:20 +0000)]
test823: Fixed expected authentication text from commit
e10a26a9d6d6de
Fixed authentication text due to incorrect digest-uri property.
Steve Holme [Sun, 10 Nov 2013 20:15:00 +0000 (20:15 +0000)]
test821: Fixed expected authentication text from commit
2d5455feac9984
Steve Holme [Sun, 10 Nov 2013 18:16:21 +0000 (18:16 +0000)]
RELEASE-NOTES: Synced with
0f81fbe5da6643
Kim Vandry [Sun, 10 Nov 2013 17:08:57 +0000 (12:08 -0500)]
ares: Fixed compilation under Visual Studio 2012
Steve Holme [Sun, 10 Nov 2013 17:00:00 +0000 (17:00 +0000)]
tests: Added IMAP OAuth 2.0 authentication test
Steve Holme [Sun, 10 Nov 2013 16:51:45 +0000 (16:51 +0000)]
tests: Added IMAP DIGEST-MD5 authentication test
Steve Holme [Sun, 10 Nov 2013 16:42:30 +0000 (16:42 +0000)]
tests: Added IMAP NTLM authentication test
Steve Holme [Sun, 10 Nov 2013 16:33:25 +0000 (16:33 +0000)]
tests: Added IMAP CRAM-MD5 authentication test
Steve Holme [Sun, 10 Nov 2013 16:08:12 +0000 (16:08 +0000)]
test819: Fixed expected authentication text from commit
76f924131c9fd3
Steve Holme [Thu, 7 Nov 2013 20:12:51 +0000 (20:12 +0000)]
ftpserver.pl: Reworked custom reply handling code
1) To fix issues with IMAP custom replies
2) So initial space is not required in IMAP display text
3) To be more readable and understandable
Steve Holme [Sun, 10 Nov 2013 10:20:50 +0000 (10:20 +0000)]
ftpserver.pl: Reworked unrecognised command responses
As the IMAP regex could fail and $1 would not contain the command id
updated the unrecognised command response to be more generic and
realistic (like those used in the command handlers).
Additionally updated the POP3, SMTP and FTP responses.
Steve Holme [Sun, 10 Nov 2013 10:08:32 +0000 (10:08 +0000)]
ftpserver.pl: Fixed processing of IMAP authentication strings
Daniel Stenberg [Fri, 8 Nov 2013 23:07:32 +0000 (00:07 +0100)]
cmake: fix Windows build with IPv6 support
Patch-by: "Z98"
Steve Holme [Wed, 6 Nov 2013 12:31:46 +0000 (12:31 +0000)]
Revert "ftpserver.pl: Corrected logic from commit
27b7b1062f9d97"
This reverts commit
558034ab7002d1 as it appears to break the auto
builds. More thought is required for this!
Steve Holme [Wed, 6 Nov 2013 08:07:59 +0000 (08:07 +0000)]
ftpserver.pl: Corrected logic from commit
27b7b1062f9d97
Steve Holme [Wed, 6 Nov 2013 07:19:01 +0000 (07:19 +0000)]
ftpserver.pl: Fixed IMAP cmdid being sent on custom responses
Steve Holme [Wed, 6 Nov 2013 00:09:15 +0000 (00:09 +0000)]
tests: Added IMAP login authentication test
Steve Holme [Wed, 6 Nov 2013 00:00:00 +0000 (00:00 +0000)]
tests: Added IMAP plain authentication test
Steve Holme [Tue, 5 Nov 2013 23:30:12 +0000 (23:30 +0000)]
url.c: Very small amount of policing
Björn Stenberg [Tue, 5 Nov 2013 22:57:22 +0000 (23:57 +0100)]
url.c: Remove superfluous for loop
The reason for this loop's existence was removed in commit
02fbc26d59c591.
Daniel Stenberg [Tue, 5 Nov 2013 09:21:30 +0000 (10:21 +0100)]
KNOWN_BUGS: STARTTRANSFER for POST requests
added 85. Wrong STARTTRANSFER timer accounting for POST requests
Daniel Stenberg [Tue, 5 Nov 2013 08:56:18 +0000 (09:56 +0100)]
Curl_ssl_push_certinfo_len: don't %.*s non-zero-terminated string
Our own printf() replacement clearly can't properly handle %.*s with a
string that isn't zero terminated. Instead of fixing the printf code or
even figuring out what the proper posix behavior is, I reverted this
piece of the code back to the previous version where it does malloc +
memcpy instead.
Regression added in
e839446c2a5, released in curl 7.32.0.
Reported-by: Felix Yan
Bug: http://curl.haxx.se/bug/view.cgi?id=1295
Steve Holme [Tue, 5 Nov 2013 07:17:24 +0000 (07:17 +0000)]
RELEASE-NOTES: Synced with
7fc3b2ce382ed6
Steve Holme [Tue, 5 Nov 2013 07:11:40 +0000 (07:11 +0000)]
connect.h: Updated copyright year for last edit
Björn Stenberg [Tue, 29 Oct 2013 10:51:25 +0000 (11:51 +0100)]
connect: Add connection delay to Happy Eyeballs.
This patch adds a 200ms delay between the first and second address
family socket connection attempts.
It also iterates over IP addresses in the order returned by the
system, meaning most dual-stack systems will try IPv6 first.
Additionally, it refactors the connect code, removing most code that
handled synchronous connects. Since all sockets are now non-blocking,
the logic can be made simpler.
Steve Holme [Mon, 4 Nov 2013 20:12:22 +0000 (20:12 +0000)]
winbind: Fixed ntlm_auth expecting eol following commit
e17c1b25bc33eb
Steve Holme [Mon, 4 Nov 2013 12:59:34 +0000 (12:59 +0000)]
nss.c: Fixed compilation warnings (Take Two)
nss.c:702: warning: pointer targets in passing argument 3 of
'Curl_extract_certinfo' differ in signedness
nss.c:702: warning: pointer targets in passing argument 4 of
'Curl_extract_certinfo' differ in signedness
Made sure the cast was correctly "unsigned char *" to "char *" and not
"unsigned char *" to "unsigned char *".
Steve Holme [Mon, 4 Nov 2013 00:38:58 +0000 (00:38 +0000)]
nss.c: Fixed compilation warnings
nss.c:700: warning: pointer targets in passing argument 3 of
'Curl_extract_certinfo' differ in signedness
nss.c:700: warning: pointer targets in passing argument 4 of
'Curl_extract_certinfo' differ in signedness
Steve Holme [Sun, 3 Nov 2013 21:34:38 +0000 (21:34 +0000)]
tests: Added test for IMAP NOOP command
Steve Holme [Sun, 3 Nov 2013 21:24:20 +0000 (21:24 +0000)]
tests: Added test for IMAP COPY command
Steve Holme [Sun, 3 Nov 2013 20:41:28 +0000 (20:41 +0000)]
tests: Disable IMAP CLOSE and EXPUNGE command tests
This is temporary until curl supports either multiple custom commands
or post-quote commands in IMAP.
Steve Holme [Sun, 3 Nov 2013 20:34:35 +0000 (20:34 +0000)]
tests: Added tests for IMAP CLOSE and EXPUNGE commands
Steve Holme [Sun, 3 Nov 2013 19:53:58 +0000 (19:53 +0000)]
connect.c: Code policing on commit
5094bb53f4a027
No need for a rhs condition on a bitwise compare.
Steve Holme [Sun, 3 Nov 2013 16:36:51 +0000 (16:36 +0000)]
nss.c: Fixed compilation warnings
warning: implicit declaration of function 'Curl_extract_certinfo'
Steve Holme [Sun, 3 Nov 2013 16:24:17 +0000 (16:24 +0000)]
x509asn1.c: Fixed compilation warnings
warning: declaration of 'chsize' shadows a global declaration
Steve Holme [Sun, 3 Nov 2013 14:39:10 +0000 (14:39 +0000)]
DOCS: Expanded --request description to include POP3 and IMAP details
Steve Holme [Sun, 3 Nov 2013 13:55:22 +0000 (13:55 +0000)]
tool_help: Updated --list-only description to include POP3
Steve Holme [Sun, 3 Nov 2013 13:54:49 +0000 (13:54 +0000)]
DOCS: Updated --list-only description to include POP3
Additionally corrected typos in --oauth2-bearer protocol list.
Steve Holme [Sun, 3 Nov 2013 12:25:07 +0000 (12:25 +0000)]
base64: Fixed compilation warnings when using Curl_base64_decode()
curl_sasl.c:294: warning: dereferencing type-punned pointer will break
strict-aliasing rules
getpart.c:201: warning: dereferencing type-punned pointer will break
strict-aliasing rules
Steve Holme [Sun, 3 Nov 2013 11:27:12 +0000 (11:27 +0000)]
connect: Fixed "Whut?" no server connection failures
Introduced in commit
7d7df831981fee curl would loop displaying "Whut?"
if it was trying to connect to an address and port that didn't have
anything listening on it.
Steve Holme [Sun, 3 Nov 2013 10:17:26 +0000 (10:17 +0000)]
http: Post base64 decoding tidy up
Renamed copy_header_value() to Curl_copy_header_value() as this
function is now non static.
Simplified proxy flag in Curl_http_input_auth() when calling
sub-functions.
Removed unnecessary white space removal when using negotiate as it had
been missed in commit
cdccb422671aeb.
Daniel Stenberg [Sun, 3 Nov 2013 09:08:10 +0000 (10:08 +0100)]
glob_range: pass the closing bracket for a-z ranges
Regression since commit
5ca96cb844102 (release in 7.33.0)
Reported-by: Marcin Gryszkalis
Steve Holme [Sat, 2 Nov 2013 17:00:00 +0000 (17:00 +0000)]
getpart: Fixed base64 encoded parts following commit
e17c1b25bc33eb
Steve Holme [Sat, 2 Nov 2013 11:18:39 +0000 (11:18 +0000)]
http: Added proxy tunnel authentication message header value extraction
...following recent changes to Curl_base64_decode() rather than trying
to parse a header line for the authentication mechanisms which is CRLF
terminated and inline zero terminate it.
Steve Holme [Wed, 30 Oct 2013 21:33:28 +0000 (21:33 +0000)]
http: Added authentication message header value extraction
...following recent changes to Curl_base64_decode() rather than trying
to parse a header line for the authentication mechanisms which is CRLF
terminated and inline zero terminate it.
Daniel Stenberg [Wed, 30 Oct 2013 22:48:08 +0000 (23:48 +0100)]
curl_multi_wait: accept 0 from multi_timeout() as valid timeout
The code rejected 0 as a valid timeout while in fact the function could
indeed legitimately return that and it should be respected.
Reported-by: Bjorn Stenberg
Steve Holme [Wed, 30 Oct 2013 21:25:15 +0000 (21:25 +0000)]
email: Corrected a couple of typos from commit
aa0eaef4838ccd
Steve Holme [Wed, 30 Oct 2013 20:59:11 +0000 (20:59 +0000)]
TODO: Removed the 'Graceful base64 decoding failure' sections
Updated following the recent changes to support graceful failures
during the authentication phrase.
Steve Holme [Wed, 30 Oct 2013 20:56:38 +0000 (20:56 +0000)]
email: Post graceful SASL authentication cancellation tidy up
Kamil Dudka [Wed, 30 Oct 2013 16:52:19 +0000 (17:52 +0100)]
tests: use proper padding in NTLM responses
Patrick Monnerat [Wed, 30 Oct 2013 10:12:06 +0000 (11:12 +0100)]
NSS: support for CERTINFO feature
Daniel Stenberg [Wed, 30 Oct 2013 08:11:10 +0000 (09:11 +0100)]
base64: removed trailing white space
and updated copyright year
Steve Holme [Wed, 30 Oct 2013 07:31:22 +0000 (07:31 +0000)]
base64: Added basic validation to base64 input string when decoding
A base64 string should be a multiple of 4 characters in length, not
contain any more than 2 padding characters and only contain padding
characters at the end of string. For example: Y3VybA==
Strings such as the following are considered invalid:
Y= - Invalid length
Y== - Invalid length
Y=== - More than two padding characters
Y=x= - Padding character contained within string
Daniel Stenberg [Tue, 29 Oct 2013 22:06:04 +0000 (23:06 +0100)]
RELEASE-NOTES: synced with
255826c40f9316
Björn Stenberg [Tue, 29 Oct 2013 13:43:01 +0000 (14:43 +0100)]
bugfix: Don't block waiting for socket1 connect.
This patch fixes a bug in Happy Eyeballs where curl would wait for a
connect response from socket1 before checking socket2.
Also, it updates error messages for failed connections, showing the ip
addresses that failed rather than just the host name repeatedly.
Bug: http://curl.haxx.se/mail/lib-2013-10/0236.html
Reported-by: Paul Marks
Steve Holme [Sun, 27 Oct 2013 22:53:07 +0000 (22:53 +0000)]
sasl: Updated create_digest_md5_message() to use a dynamic buffer
Daniel Stenberg [Mon, 28 Oct 2013 22:19:55 +0000 (23:19 +0100)]
SECURITY: "curl security for developers"
Describes our security process from a project and curl developer's
perspective.