Jaeyun Jung [Tue, 8 Aug 2023 04:34:49 +0000 (13:34 +0900)]
[C-Api] check index in tensors-info handle
Code clean, check index in tensors-info handle and update log message.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 8 Aug 2023 06:17:46 +0000 (15:17 +0900)]
[Service] update ml-agent interface
Code refactoring, update the name of ml-agent interface.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 4 Aug 2023 03:10:09 +0000 (12:10 +0900)]
[Svace] fix svace issue
Check null case when getting nth info of ml and gst tensor-info.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 3 Aug 2023 12:42:34 +0000 (21:42 +0900)]
[CodeClean] delete unnecessary log
Code clean, fix svace issue. Remove unnecessary log - data type.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Wed, 2 Aug 2023 05:16:43 +0000 (14:16 +0900)]
[Pipeline] element name for tizen media src
Code clean, get the element name from tizen media config and replace it.
TODO: handle properties for each element.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 3 Aug 2023 09:20:01 +0000 (18:20 +0900)]
[CodeClean/Service] util to get app-info
Code clean, add util to get app-info string and reduce duplicated code.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 1 Aug 2023 09:21:18 +0000 (18:21 +0900)]
[Service] util to parse app-info
Use common function to parse app-info and update ml-information handle.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 1 Aug 2023 06:55:48 +0000 (15:55 +0900)]
[Service/Test] valid ml-information handle
Set valid handle name in testcase - ml-information handle for model and resource API.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 1 Aug 2023 07:09:17 +0000 (16:09 +0900)]
[CodeClean] missed tag
Code clean, condition to release mem-block and add missed tag.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 28 Jul 2023 09:36:34 +0000 (18:36 +0900)]
[Service] handle app-info for ml-resource
Add new field app_info for tizen RPK install case, to manage app-information like model API.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 31 Jul 2023 07:11:58 +0000 (16:11 +0900)]
[Service/Test] add test about ml-resource
Update testcase to use ml-resource API.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 31 Jul 2023 05:16:49 +0000 (14:16 +0900)]
[Service] util to get app info
Define internal common function to get app info.
TODO:
New field for app info for ml-resource and the funtion adding ml-resource will be udpated.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 28 Jul 2023 13:05:32 +0000 (22:05 +0900)]
[Common] util to create info-list handle
Add internal util function to create ml-information-list handle.
TODO:
I will update another PR to cleanup info-list handle in ml-agent.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 28 Jul 2023 04:33:06 +0000 (13:33 +0900)]
[Service] data from ml-service
1. Get resource info with insertion order.
2. We do not neet to export key from service-db.
Add common json info to get the data from db and hide key from json info.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 31 Jul 2023 04:52:41 +0000 (13:52 +0900)]
[Service] return val to parse app info
Code clean, return val if failed to parse app-info from json string.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Thu, 13 Jul 2023 09:19:25 +0000 (18:19 +0900)]
[test] Use ml_information for ml_service_model APIs
- Since the signature of the API is changed, fix related test code.
- Add a negative TC for ml_information_list_h
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Thu, 13 Jul 2023 09:16:34 +0000 (18:16 +0900)]
[Service/model] Replace ml_option with ml_information in service/model APIs
- Change service/model APIs to use newly added handle ml_information_h
and ml_information_list_h
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Thu, 13 Jul 2023 08:07:57 +0000 (17:07 +0900)]
[common] Add ml_information, which is not ml_option
- Define ml_information_h and ml_information_list_h.
- Add related APIs
ml_information_
- destroy
- get
ml_information_list_
- destroy
- length
- get
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Wed, 5 Jul 2023 12:16:07 +0000 (21:16 +0900)]
[C-Api/Service] define API for ml-resource
Define new API set for ml-resource control.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 28 Jul 2023 04:50:52 +0000 (13:50 +0900)]
[Test] predefined dbus name
Code clean, use predefined dbus name in dbus-interface.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 24 Jul 2023 07:36:45 +0000 (16:36 +0900)]
[Service] ml-agent interface for resource
Implement ml-agent interface for ml-resource.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 24 Jul 2023 06:03:35 +0000 (15:03 +0900)]
[Service] add resource table
Add new table for ml-resource, and add functions for ml-agent.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 18 Jul 2023 11:36:31 +0000 (20:36 +0900)]
[Service/CodeClean] reduce duplicated code
Code clean,
1. Add methods in service-db to reduce duplicated code.
2. Add key prefix for each table.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:34:19 +0000 (17:34 +0900)]
[test] Add TCs for Pipeline API with 32 in/out model
- Test NNStreamer pipeline for tflite model with 32 input / 32 output tensors
- one using videotestsrc / and the other using appsrc
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:32:27 +0000 (17:32 +0900)]
[test] Add TC for singleshot with 32 input/output tflite model
- Test Single for tflite model with 32 input / 32 output tensors.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 10 Jul 2023 06:38:01 +0000 (15:38 +0900)]
[test] Add test for common util
- Add TCs for tensors_info handling ML_TENSOR_SIZE_LIMIT infos.
- Add negative TCs for newly added internal utils.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:31:16 +0000 (17:31 +0900)]
[test] Change datatype_consistency test
- Remove tests with value `NNS_TENSOR_SIZE_LIMIT`
- Revert later when the value is changed.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:29:28 +0000 (17:29 +0900)]
[Pipeline] Let pipeline handle increased number of tensors
- Let sink and src element deal with tensors not memory using util function from nnstreamer
- Remove size check in `cb_sink_event` that is no longer valid.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:22:48 +0000 (17:22 +0900)]
[common] Add utils for extra tensor_info
- Add util functions for extra `ml_tensor_info_s`.
- Replace index based access of tensor_info with newly added util
`gst_tensors_info_get_nth_info` and `ml_tensors_info_get_nth_info`
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:18:11 +0000 (17:18 +0900)]
[common] Increase ML_TENSOR_SIZE_LIMIT 16 -> 256
- Increase `ML_TENSOR_SIZE_LIMIT` to 256
- Define `ML_TENSOR_SIZE_LIMIT_STATIC` and
`ML_TENSOR_SIZE_EXTRA_LIMIT` to handle extra tensors
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Mon, 17 Jul 2023 08:26:13 +0000 (17:26 +0900)]
[Service] util to init gdbus module
Fix log message, and add common function to initialize gdbus module.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Thu, 13 Jul 2023 07:26:12 +0000 (16:26 +0900)]
[common] Refactor ml_option APIs to use internal ml_info
- Declare ml_info and related enum and structures. Add internal
functions for create, destroy, set, get.
- Replace ml_option_s with the new internal structure in ml_option API.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Thu, 13 Jul 2023 05:32:15 +0000 (14:32 +0900)]
[opton] Use ml_option_get to get value from ml_option_h
- Use the API rather than accessing internal structure.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Mon, 17 Jul 2023 08:21:27 +0000 (17:21 +0900)]
[Service] set dbus-complete function
Set exact complete function in dbus callback.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 11 Jul 2023 11:24:21 +0000 (20:24 +0900)]
[C-Api] util to check file path
Code clean, add internal function to check the path of model or resource.
This will be used resource-add function later.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Fri, 7 Jul 2023 09:09:05 +0000 (18:09 +0900)]
[API] function to get version
Add util function to get version of ML-API.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 10 Jul 2023 06:54:41 +0000 (15:54 +0900)]
[C-Api] log string
Trivial, update log string before adding new API set.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
gichan2-jang [Tue, 4 Jul 2023 09:13:49 +0000 (18:13 +0900)]
[Service] Remove deprecated header file
Since ml-api-service-internal.h is deprecated, remove the file.
Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
Wook Song [Tue, 27 Jun 2023 07:00:28 +0000 (16:00 +0900)]
Daemon/Model: Add missing gst initialization
This patch adds GStreamer initialization procedure into
init_model_module. Without the initialization, D-Bus interfaces for
the models inproperly work.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 19 Jun 2023 07:59:30 +0000 (16:59 +0900)]
Dist/Tizen: Include ml-agentd.pc in the ml-agnet-devel package
This patch updates the Tizen RPM spec file to add the ml-agentd.pc file
to the libmachine-learning-agent-devel package.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 19 Jun 2023 07:52:17 +0000 (16:52 +0900)]
Daemon/Meson: Add a pkg-config file for ml-agentd
This patch adds a pkg-config file that provides details for using the
Machine Machine Learning Agent service interfaces.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Wed, 21 Jun 2023 08:15:26 +0000 (17:15 +0900)]
[single] Fix macro value for rank
- Change size_limit to rank_limit in rank related methods
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Harsh Jain [Thu, 15 Jun 2023 09:07:10 +0000 (14:37 +0530)]
Update Android-nnstreamer.mk
Updated Android-nnstreamer.mk for tensor_decoder::tensor_region sub-plugin in regard to https://github.com/nnstreamer/nnstreamer/pull/4115#discussion_r1230632289
Signed-off-by: HarshJ20 <hjain24in@gmail.com>
Yongjoo Ahn [Thu, 15 Jun 2023 04:11:04 +0000 (13:11 +0900)]
[fix] Fix mem leak in Single API
- Destroy ml_tensors_info_h in ml_single_close
- Call gst_tensors_info_free
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Tue, 13 Jun 2023 12:35:46 +0000 (21:35 +0900)]
[fix] Fix memi leak in pipeline API
- Free GstTensorsConfig using gst_tensors_config_free
- Initialize ml_tensors_info_s before set a new one
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
SuYeon [Wed, 14 Jun 2023 02:22:18 +0000 (11:22 +0900)]
fix svace issue.
error param should be paased to 'json_parser_load_from_data' since error_report acess to error message.
Signed-off-by: SuYeon <suyeon5.kim@samsung.com>
gichan2-jang [Tue, 13 Jun 2023 02:41:24 +0000 (11:41 +0900)]
[Tizen] Update coverage auto measurement script
- Exclude 'ml-api-common-tizen-feature-check.c' and
'ml-api-inference-tizen-privilege-check.c' from the coverage report.
- Change test directory before running the tests.
Error:
[DEBUG]:[ RUN ] [mMLAgentTest.call_method
Error : GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.tizen.machinelearning.service was not provided by any .service files
[DEBUG]:../tests/daemon/unittest_ml_agent.cc:87: Failure
Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
Wook Song [Tue, 13 Jun 2023 01:21:48 +0000 (10:21 +0900)]
API/Client: Revise JSON cstring conversion code
This patch revises the mechanism that creates ml_option_h typed data
from a JSON cstring.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Sangjung Woo [Mon, 12 Jun 2023 08:31:41 +0000 (17:31 +0900)]
[ml-service] Add 'app_common_internal.h' to support Tizen v7.0
In case of Tizen 7.0, app_get_res_control_global_resource_path() is
defined in app_common_internal.h. So this patch includes
app_common_internal.h to support both of Tizen 7.0 and latest Tizen.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Jaeyun Jung [Thu, 1 Jun 2023 05:53:49 +0000 (14:53 +0900)]
[Test] feature for tf-lite
Enable testcase if tensorflow-lite ver2.x is available.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 1 Jun 2023 05:58:35 +0000 (14:58 +0900)]
[Service] common log-util
Code clean, use common log-util in ml-agent code.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Mon, 22 May 2023 08:06:17 +0000 (17:06 +0900)]
API/Client: Use nested scope for JSON handling
This is a trivial patch for code cleaning. Toward better readability,
nested scope and g_auto* are used for JSON handling.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Wed, 24 May 2023 10:15:09 +0000 (19:15 +0900)]
Daemon/DBus: Replace NULL with "" for the DBus out parameters
When the out parameter type is set to "s" (which means a string type
value), it should not be a NULL value. This patch fixes such a case
in the DBus callback implementation for the pipeline.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 22 May 2023 07:32:52 +0000 (16:32 +0900)]
API/Client: Replace g_new0 with g_try_new0
g_new0 would not work as the author intended. This patch replaces g_new0
macros with g_try_new0 macros so that memory allocation failure is
checked at runtime.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 22 May 2023 06:50:32 +0000 (15:50 +0900)]
API/Client: Revise null-checks for output parameters
This patch revises null-checks for the output parameters, which
require memory allocation at the callee side, to return an error when
the argument is NULL and to warn the leak possibility when the
dereference is not NULL.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Mon, 22 May 2023 02:46:30 +0000 (11:46 +0900)]
Daemon: Change the directory including header file to 'include'
To keep consistency with the C-Level API's header file directory, this
patch changes the directory including ML Agent Service's header files to
'include' from 'includes'.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Jaeyun Jung [Wed, 3 May 2023 11:49:06 +0000 (20:49 +0900)]
[Service] deleting activated model
Add util functions in service-db,
1. prevent deleting activated model,
2. add util function to check model registration.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Sangjung Woo [Thu, 18 May 2023 04:56:46 +0000 (13:56 +0900)]
[Service] Fix the wrong requires section of pkgconfig file
This patch fixes the wrong requires section of ML Service package config file.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Wook Song [Thu, 18 May 2023 04:32:23 +0000 (13:32 +0900)]
Tests: Revise the unittests package
This patch revised the meson build script and Tizen's rpm spec file to
include files which are required by the test daemon,
machine-learning-agent-test.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Mon, 15 May 2023 05:00:30 +0000 (14:00 +0900)]
[Release] Change the name tizen 7.5 into tizen 8.0
- Tizen X.5 is not going to be used. Change tizen 7.5 to tizen 8.0
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
gichan2-jang [Thu, 11 May 2023 10:11:14 +0000 (19:11 +0900)]
[Tizen] Fix script for converage auto measurement
Fix script for coverage auto measuremnt
- Set MLAPI PATH
Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
Jaeyun Jung [Thu, 4 May 2023 07:06:12 +0000 (16:06 +0900)]
[Service] functions for transaction
Code clean, add internal util function for DB transaction.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 4 May 2023 04:40:09 +0000 (13:40 +0900)]
[Service] logutil in service-db
Code clean, use common logutil in service-db.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Thu, 4 May 2023 05:16:33 +0000 (14:16 +0900)]
[Build/Service] fix indent
Fix build error, clang-format of service-db.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Wed, 3 May 2023 06:24:28 +0000 (15:24 +0900)]
[Service/Log] printing internal value
The ID from pipeline hashtable in daemon is internal value.
This PR hides this internal ID value.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 07:28:53 +0000 (16:28 +0900)]
[C-Api/CodeClean] remove unnecessary code
Code clean,
1. fix indent and remove unnecessary lines.
2. replace function to compare pkg type (case-insensitive).
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Wed, 3 May 2023 07:29:16 +0000 (16:29 +0900)]
[clang-format] line-comment length
clang-format, ignore line-comment length.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 04:32:56 +0000 (13:32 +0900)]
[Service] handle invalid version
Raise exception when given version number is 0.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Tue, 2 May 2023 05:43:29 +0000 (14:43 +0900)]
Formatting/CC: Apply .clang-format to the C++ source files
This patch applies .clang-format to all of the .cc files, which are
source files written in C++.
find . -name "*.cc" -exec clang-format-15 --style=file:.clang-format {} \;
Signed-off-by: Wook Song <wook16.song@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 07:13:26 +0000 (16:13 +0900)]
[C-Api] Tizen API guide
Update API description, fix design guide.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Wook Song [Tue, 2 May 2023 05:54:42 +0000 (14:54 +0900)]
API/C: Add the missing header to the pipeline-internal header file
This patch adds a missing internal header, 'nnstreamer.h', which defines
data structures and types required by the
'ml-api-inference-pipeline-internal.h' file.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Tue, 2 May 2023 04:17:32 +0000 (13:17 +0900)]
Tests: Add test cases for gdbus-util
This patch adds unit test cases for the helper functions in the
gdbus-util.c file.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Tue, 2 May 2023 04:06:00 +0000 (13:06 +0900)]
[test] Add a negative testcase for ml_service_launch_pipeline
- Add an erroneous pipeline launch case with invalid tensor_filter
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 03:33:45 +0000 (12:33 +0900)]
[Service] invalid table schema
Fix invalid table schema and cleanup service-db test.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 2 May 2023 03:27:16 +0000 (12:27 +0900)]
[C-Api/CodeClean] remove duplicated code
Code clean, remove duplicated code.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Yongjoo Ahn [Fri, 28 Apr 2023 02:26:39 +0000 (11:26 +0900)]
[CodeClean] Change variable name
- Change variable name not to hide the parameter of cb
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Fri, 28 Apr 2023 02:25:47 +0000 (11:25 +0900)]
[CodeClean] Fix memleak of pkg_info
- Free pkg_info handle when the callback is returned
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
gichan [Thu, 27 Apr 2023 05:51:43 +0000 (14:51 +0900)]
[TEST] Set `is-updatable` prop of single test
Set `is-updatable` prop of single test
*line coverage: 80.1%
Signed-off-by: gichan <gichan2.jang@samsung.com>
Yongjoo Ahn [Thu, 27 Apr 2023 04:42:10 +0000 (13:42 +0900)]
[build] Add missing errno.h in ml-agent-dbus-interface.c
- Add missing header <errno.h> to the source file.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Tue, 25 Apr 2023 12:25:08 +0000 (21:25 +0900)]
Meson/LCOV: Apply a workaround to increase lcov of 'service-db.cc'
This patch applies a simple workaround to increase the line coverage of
the 'service-db.cc' file.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Fri, 14 Apr 2023 06:57:08 +0000 (15:57 +0900)]
MLAgent: Introduce libml-agentd
This patch defines APIs of the ML Agent Daemon whose backend is GDBus
and exports them to the outer space of the daemon so that the tightly
coupled dependency between the libcapi-ml-service and daemon is
eliminated.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Jaeyun Jung [Tue, 25 Apr 2023 03:48:45 +0000 (12:48 +0900)]
[Test] remove unnecessary test
Code clean, remove empty testcase.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Tue, 25 Apr 2023 03:41:00 +0000 (12:41 +0900)]
[Test/Meson] common dependency
Use predefined dependencies in meson script.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 24 Apr 2023 10:54:19 +0000 (19:54 +0900)]
[Meson] dependency to tizen pkgs
Code clean, define dependencies to tizen packages.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Jaeyun Jung [Mon, 24 Apr 2023 08:35:49 +0000 (17:35 +0900)]
[Build] error ml-svc on ubuntu
Fix error when building ml-svc on ubuntu.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
gichan [Mon, 24 Apr 2023 05:51:25 +0000 (14:51 +0900)]
Tizen] Exclude test files for SAM
Exclude test files for SAM
Signed-off-by: gichan <gichan2.jang@samsung.com>
Yelin Jeong [Fri, 21 Apr 2023 02:00:17 +0000 (11:00 +0900)]
[C-API] revert fill dimension 1
This patch reverts fill dimension to default value 1.
In C# API, interop function ml_tensors_info_get_tensor_dimension
is used with length 4 dimension array instead of 16.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Wook Song [Thu, 20 Apr 2023 05:43:24 +0000 (14:43 +0900)]
Daemon/PkgMrg: Eliminate duplicate code blocks
This is a trivial patch for the elimination of the duplicate code
blocks.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Wook Song [Thu, 20 Apr 2023 04:56:17 +0000 (13:56 +0900)]
Tests/PkgMgr: Add functions for emulation of Tizen's Pkg Manager APIs
This patch adds helper functions for the emulation of Tizen's Package
Manager APIs and utilities for unit test cases of ML Agent Service APIs.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Fri, 21 Apr 2023 01:32:52 +0000 (10:32 +0900)]
[CodeClean] Fix memleak in pkgmgr
- Use g_autofree gchar to prevent memleak;
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Thu, 20 Apr 2023 03:11:03 +0000 (12:11 +0900)]
[build] Add empty build dep for tizen appfw for local build/test
- Add an empty build dep for tizen appfw, used by servce API
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:39:28 +0000 (15:39 +0900)]
[pkgmgr] Parse rpk's "model_description.json" to fill app_info and register
- When rpk is installed, parse the provided model_description.json file
and register models described in the json.
TODO: Handle when the rpk package is removed or updated.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:13:23 +0000 (15:13 +0900)]
[service] Check and parse app_info of tizen application (the caller)
In a Tizen application context,
`ml_service_model_register` fill app_info column. RPK cannot call this
API, so the value of key `is_rpk` is always false.
`ml_service_model_get*` APIs should parse the app_info and update the
path in case of models from 'RPK'.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Wed, 19 Apr 2023 02:47:55 +0000 (11:47 +0900)]
Tests/Dbus: Move DBus-related files to the tests/dbus directory
This patch relocates the dbus interface for the unit tests to the tests
directory. According to the changes, the meson build files are alse
updated as well.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:05:17 +0000 (15:05 +0900)]
[service] Add "app_info" column to the model DB
- Add a new column "app_info" to the service DB's tblModel table.
- This app_info is a json string consists of tizen application
information which owns model.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Wook Song [Wed, 19 Apr 2023 04:16:09 +0000 (13:16 +0900)]
Tests/Meson: Revise meson build scripts in tests
This patch revises the meson build scripts related to the test
sub-directory.
Signed-off-by: Wook Song <wook16.song@samsung.com>
Yelin Jeong [Tue, 11 Apr 2023 10:46:43 +0000 (19:46 +0900)]
[C-API] Fix set tensor dimension order
This patch fixes the order of ml_tensors_info_set_tensor_dimension.
If tensors_info is not extended, user may regard dimension array's length to 4.
Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Yongjoo Ahn [Mon, 17 Apr 2023 06:46:19 +0000 (15:46 +0900)]
[agent] Change tizen log functions of ml-agent
- Let ml-agent logs be more verbose in Tizen.
Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Sangjung Woo [Thu, 13 Apr 2023 00:15:22 +0000 (09:15 +0900)]
[C-Api] Revert fill dim (default 1) commit
Because of native TC failure, this patch reverts the fill dim (default
1) commit.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Jaeyun Jung [Fri, 7 Apr 2023 07:50:33 +0000 (16:50 +0900)]
[C-Api] fill dim (default 1)
When calling get-dimension(), fill remained dim - default dim is 1.
Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>