platform/upstream/gstreamer.git
10 years agoivfparse: port to baseparse.
Gwenole Beauchesne [Tue, 4 Mar 2014 14:46:58 +0000 (15:46 +0100)]
ivfparse: port to baseparse.

https://bugzilla.gnome.org/show_bug.cgi?id=710855

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
10 years agotests: add standalone program for VP8 parser.
Zhao, Halley [Fri, 24 Jan 2014 00:37:16 +0000 (08:37 +0800)]
tests: add standalone program for VP8 parser.

Add standalone test application that demonstrates how to use the new
VP8 bitstream parsing library, while also allowing simple debugging/
tracing of IVF files.

[clean-ups, updated to new parser API]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
10 years agotests: add test for VP8 bitstream parsing library.
Zhao, Halley [Tue, 7 Jan 2014 18:49:00 +0000 (02:49 +0800)]
tests: add test for VP8 bitstream parsing library.

[updated to new parser API]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
10 years agocodecparsers: vp8: rename dboolhuff symbols.
Sebastian Dröge [Wed, 9 Apr 2014 07:22:02 +0000 (09:22 +0200)]
codecparsers: vp8: rename dboolhuff symbols.

Rename VP8 dboolhuff symbols so that to avoid clashes with libvpx when
static linking.

10 years agocodecparsers: vp8: add GStreamer native utilities.
Gwenole Beauchesne [Tue, 8 Apr 2014 08:30:09 +0000 (10:30 +0200)]
codecparsers: vp8: add GStreamer native utilities.

Import libvpx 1.3.0 range decoder files (dboolhuff.[ch]) to implement
the VP8 utilities native interface. Likewise, copy and use the default
libvpx generated entropy probabilities tables.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
10 years agocodecparsers: add VP8 bitstream parser.
Zhao, Halley [Tue, 7 Jan 2014 18:49:00 +0000 (02:49 +0800)]
codecparsers: add VP8 bitstream parser.

https://bugzilla.gnome.org/show_bug.cgi?id=722760

[refactored, among other fixes]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
10 years agompegtspacketizer: Improve ts_to_offset code
Edward Hervey [Fri, 18 Apr 2014 14:23:43 +0000 (16:23 +0200)]
mpegtspacketizer: Improve ts_to_offset code

* Search in current pending values first. For CBR streams we can very
  easily end up having just one initial observations and then nothing
  else (since the bitrate doesn't change).
* Use one group whether we are in that group *OR* if there is only
  one group.
* If the group to use isn't closed (points are being accumulated in the
  PCROffsetCurrent), use the latest data available for calculation
* If in the unlikelyness that all of this *still* didn't produce more
  than one data point, just return the initial offset

10 years agotsdemux: Fix scaling macros
Edward Hervey [Fri, 18 Apr 2014 14:20:31 +0000 (16:20 +0200)]
tsdemux: Fix scaling macros

While the calculation done in these macros will work with 64bit
integers, they will fail if working with 32bit integers.

Force the scaling up to solve that.

This amazingly didn't introduce major issues up to now, but resulted
in bogus values in debug logs.

10 years agompegtsbase: Don't hard-flush the packetizer on discont buffers
Edward Hervey [Fri, 18 Apr 2014 14:18:01 +0000 (16:18 +0200)]
mpegtsbase: Don't hard-flush the packetizer on discont buffers

Doing a hard flush on the packetizer will drop all observations, which
will eventually break push-based seeking (with BYTES segment) since
we won't know where to seek to anymore (new data would always be
considered as the beginning of the stream).

10 years agomxfdemux: Fix copy/paste error
Edward Hervey [Wed, 16 Apr 2014 14:25:29 +0000 (16:25 +0200)]
mxfdemux: Fix copy/paste error

We want to check whether the rate is different. We check changes in
numerator *and* denominator.

CID #1139631
CID #1139642

10 years agomxf: Handle fraction parsing failure
Edward Hervey [Wed, 16 Apr 2014 14:19:47 +0000 (16:19 +0200)]
mxf: Handle fraction parsing failure

And properly cleanup/reset the segment before returning on errors

CID #206012

10 years agomxf: Remove useless check
Edward Hervey [Wed, 16 Apr 2014 14:12:02 +0000 (16:12 +0200)]
mxf: Remove useless check

a guint will always smaller or equal to the maximum value it can
contain

CID #206049

10 years agomxf: avoid dereferencing NULL mapping data pointer
Vincent Penquerc'h [Wed, 9 Apr 2014 11:27:16 +0000 (12:27 +0100)]
mxf: avoid dereferencing NULL mapping data pointer

Also unref buffers on error, as it seems to be done in one, but
not all, error paths.

The NULL pointer part is Coverity 206112

https://bugzilla.gnome.org/show_bug.cgi?id=727889

10 years agodvb: Fix if() check
Edward Hervey [Wed, 16 Apr 2014 14:07:17 +0000 (16:07 +0200)]
dvb: Fix if() check

introduced by my previous commit :(

10 years agoconfigure: Detect EGL header presence
Edward Hervey [Wed, 16 Apr 2014 13:43:06 +0000 (15:43 +0200)]
configure: Detect EGL header presence

Fixes the build for Android, and I suspect for other systems too...

10 years agodvb/camsession: Don't do operations on unexisting sessions
Edward Hervey [Wed, 16 Apr 2014 13:37:57 +0000 (15:37 +0200)]
dvb/camsession: Don't do operations on unexisting sessions

CID #206114

10 years agodvb: Handle socket() failure
Edward Hervey [Wed, 16 Apr 2014 13:32:32 +0000 (15:32 +0200)]
dvb: Handle socket() failure

CID #206178

10 years agodvbsrc: Handle failure to get statistics from the device
Edward Hervey [Wed, 16 Apr 2014 13:23:57 +0000 (15:23 +0200)]
dvbsrc: Handle failure to get statistics from the device

Check the ioctl return value and don't output bogus values.

CID #206016

10 years agodvbsrc: Don't close a fd that wasn't open
Edward Hervey [Wed, 16 Apr 2014 13:18:44 +0000 (15:18 +0200)]
dvbsrc: Don't close a fd that wasn't open

We are handling the failure cases in this block where the open failed

CID #206179

10 years agodvbsrc: Don't try to access NULL string
Edward Hervey [Wed, 16 Apr 2014 13:17:03 +0000 (15:17 +0200)]
dvbsrc: Don't try to access NULL string

And refactor the pid setting code to be in its own function for clarity

CID #206374

10 years agompegts: add dvb ca identifier descriptor
Stefan Ringel [Thu, 10 Apr 2014 14:04:21 +0000 (16:04 +0200)]
mpegts: add dvb ca identifier descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727560

10 years agompegts: add scrambling descriptor
Stefan Ringel [Thu, 10 Apr 2014 14:03:07 +0000 (16:03 +0200)]
mpegts: add scrambling descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727560

10 years agompegts: add frequency list descriptor
Stefan Ringel [Thu, 10 Apr 2014 14:02:09 +0000 (16:02 +0200)]
mpegts: add frequency list descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727560

10 years agompegts: add data broadcast id descriptor
Stefan Ringel [Thu, 10 Apr 2014 14:00:50 +0000 (16:00 +0200)]
mpegts: add data broadcast id descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727403

10 years agompegts: add private data specifier descriptor
Stefan Ringel [Thu, 10 Apr 2014 13:59:50 +0000 (15:59 +0200)]
mpegts: add private data specifier descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727403

10 years agodvb: Minor code style fix
Sebastian Dröge [Wed, 16 Apr 2014 07:20:37 +0000 (09:20 +0200)]
dvb: Minor code style fix

10 years agompegts: add parential rating descriptor
Stefan Ringel [Thu, 10 Apr 2014 13:58:55 +0000 (15:58 +0200)]
mpegts: add parential rating descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727403

10 years agompegts: add linkage descriptor
Stefan Ringel [Thu, 10 Apr 2014 13:58:04 +0000 (15:58 +0200)]
mpegts: add linkage descriptor

https://bugzilla.gnome.org/show_bug.cgi?id=727403

10 years agompegts: for loop initial declarations are only allowed in C99 mode
Tim-Philipp Müller [Tue, 15 Apr 2014 23:25:51 +0000 (00:25 +0100)]
mpegts: for loop initial declarations are only allowed in C99 mode

Fixes compiler warnings.

10 years agoegl: Add libgstegl and eglgles plugin to the CRUFT directories
Sebastian Dröge [Tue, 15 Apr 2014 18:47:55 +0000 (20:47 +0200)]
egl: Add libgstegl and eglgles plugin to the CRUFT directories

10 years agoegl/eglglessink: remove since EGLImage and iOS support have been added in glimagesink
Julien Isorce [Tue, 15 Apr 2014 16:58:34 +0000 (17:58 +0100)]
egl/eglglessink: remove since EGLImage and iOS support have been added in glimagesink

https://bugzilla.gnome.org/show_bug.cgi?id=703343

10 years agogl: allow to include GLES/gl.h
Julien Isorce [Mon, 24 Mar 2014 12:08:43 +0000 (12:08 +0000)]
gl: allow to include GLES/gl.h

https://bugzilla.gnome.org/show_bug.cgi?id=703343

10 years agowayland: Remove dead assignment
Edward Hervey [Mon, 14 Apr 2014 05:56:16 +0000 (07:56 +0200)]
wayland: Remove dead assignment

We set it just after variable declaration

CID #1197709

10 years agogl/eagl: Fix compilation
Sebastian Dröge [Sun, 13 Apr 2014 17:20:32 +0000 (19:20 +0200)]
gl/eagl: Fix compilation

10 years agogl/eagl: Notify the window's resize callback about surface dimension changes
Sebastian Dröge [Sun, 13 Apr 2014 14:53:58 +0000 (16:53 +0200)]
gl/eagl: Notify the window's resize callback about surface dimension changes

https://bugzilla.gnome.org/show_bug.cgi?id=728107

10 years agogl/eagl: Remove spurious private struct pointer
Sebastian Dröge [Sun, 13 Apr 2014 14:46:11 +0000 (16:46 +0200)]
gl/eagl: Remove spurious private struct pointer

10 years agogl/android: Notify the window's resize callback about surface dimension changes
Sebastian Dröge [Sun, 13 Apr 2014 14:40:58 +0000 (16:40 +0200)]
gl/android: Notify the window's resize callback about surface dimension changes

https://bugzilla.gnome.org/show_bug.cgi?id=728107

10 years agoglimagesink: remove unused texture
Matthew Waters [Sun, 13 Apr 2014 12:16:45 +0000 (22:16 +1000)]
glimagesink: remove unused texture

10 years agoglimagesink: move upload into _prepare()
Matthew Waters [Sun, 13 Apr 2014 12:14:52 +0000 (22:14 +1000)]
glimagesink: move upload into _prepare()

10 years agogl/context: output available extensions
Matthew Waters [Sun, 13 Apr 2014 03:49:22 +0000 (13:49 +1000)]
gl/context: output available extensions

10 years agogl/context: provide get_gl_version
Matthew Waters [Sun, 13 Apr 2014 03:39:14 +0000 (13:39 +1000)]
gl/context: provide get_gl_version

10 years agogl/color: restore viewport dimensions when fbo done
Julien Isorce [Sat, 12 Apr 2014 23:21:00 +0000 (00:21 +0100)]
gl/color: restore viewport dimensions when fbo done

Regression introduced by 95abfda1399bcddbee345d4542e857d743965477.
It caused to display the wrong frame size when resizing the window.

10 years agogl: Import QuartzCore/QuartzCore.h for CAEAGLLayer on older iOS versions
Sebastian Dröge [Sat, 12 Apr 2014 20:45:30 +0000 (22:45 +0200)]
gl: Import QuartzCore/QuartzCore.h for CAEAGLLayer on older iOS versions

10 years agogl: Set glimagesink rank to SECONDARY
Sebastian Dröge [Sat, 12 Apr 2014 20:15:35 +0000 (22:15 +0200)]
gl: Set glimagesink rank to SECONDARY

This is a full-featured video sink now and especially should be
used instead of osxvideosink on OSX if available.

10 years agogl: Add support for iOS EAGL platform
Sebastian Dröge [Sat, 12 Apr 2014 19:43:50 +0000 (21:43 +0200)]
gl: Add support for iOS EAGL platform

https://bugzilla.gnome.org/show_bug.cgi?id=703341

10 years agogl/cocoa: make gst_gl_window_cocoa_send_message_async re-entrant
Julien Isorce [Sat, 12 Apr 2014 16:33:44 +0000 (17:33 +0100)]
gl/cocoa: make gst_gl_window_cocoa_send_message_async re-entrant

Backends that use g_main_context_invoke are re-entrant.

Il allows to call two nested gst_gl_context_thread_add.
ex: init_upload / init_colorconvert

10 years agoglimagesink: First handle GL window setup, then create the context and its thread
Sebastian Dröge [Sat, 12 Apr 2014 15:01:09 +0000 (17:01 +0200)]
glimagesink: First handle GL window setup, then create the context and its thread

10 years agogl/cocoa: fix NSAutoreleasePool initialization
Julien Isorce [Sat, 12 Apr 2014 14:51:47 +0000 (15:51 +0100)]
gl/cocoa: fix NSAutoreleasePool initialization

10 years agogl/cocoa: ensure to call NSApplication:sharedApplication in the main thread
Julien Isorce [Sat, 12 Apr 2014 11:42:40 +0000 (12:42 +0100)]
gl/cocoa: ensure to call NSApplication:sharedApplication in the main thread

"(NSApplication *)sharedApplication This method also makes a connection
to the window server and completes other initialization"
The implicit thing which is not mentioned is that it required
to be called in the main thread.

Fix a regression introduces by 82b7c915bb02a9790d256d599452e5a54afda633
When using with gst-launch, it was not possible to click on the close
cross of the window anymore which is a bit anoying and also because
it's was possible before.

Prior to this commit the GstGLContextCocoaClass was initialized
in the main thread because gst_gl_context_new was called in the
state change function from going from ready to paused.

From this commit this call is done from the streaming thread.
So that the call to [NSApplication sharedApplication];
was not done in the main thread anymore.

We now ensure that by assuming there is a GMainLoop running.
It's for debugging purpose so that's ok to do that. Also
note we already do this assumtion to run app itereations.

The regression had no consequence on the cocoa/videooverlay example
(that should be moved from gst-plugins-gl to -bad) because the
application is responsible for that necessary call.

10 years agogl/color: fix warning type qualifiers ignored
Julien Isorce [Sat, 12 Apr 2014 13:40:40 +0000 (14:40 +0100)]
gl/color: fix warning type qualifiers ignored

i686-apple-darwin11-llvm-gcc-4.2
"warning: type qualifiers ignored on function return type"

10 years agogl/color: remove if statement with no effect
Matthew Waters [Sat, 12 Apr 2014 08:24:43 +0000 (18:24 +1000)]
gl/color: remove if statement with no effect

Coverity 1199698

10 years agogl/color: pass large value by reference
Matthew Waters [Sat, 12 Apr 2014 08:16:29 +0000 (18:16 +1000)]
gl/color: pass large value by reference

Coverity 1199700

10 years agosrtpdec: fix assertion checking ssrc from rtcp packets
Aleix Conchillo Flaqué [Wed, 2 Apr 2014 19:59:58 +0000 (12:59 -0700)]
srtpdec: fix assertion checking ssrc from rtcp packets

rtcp_buffer_get_ssrc is called even with RTP buffers. this means we
might end up with an exception and not find any valid RTCP packet type
and thus hit GST_RTCP_TYPE_INVALID. we now take care of this.

https://bugzilla.gnome.org/show_bug.cgi?id=727512

10 years agojp2kdecimator: fix maybe-uninitialized compiler error
Andoni Morales Alastruey [Fri, 11 Apr 2014 10:29:17 +0000 (12:29 +0200)]
jp2kdecimator: fix maybe-uninitialized compiler error

10 years agompegtsmux: Remove unneeded unref
Edward Hervey [Fri, 11 Apr 2014 09:34:26 +0000 (11:34 +0200)]
mpegtsmux: Remove unneeded unref

packet_buffer has already been cleared in all code paths leading
to this point.

CID #1199696

10 years agodvbsrc: Handle symbols added in minor version 7 and 8
Edward Hervey [Fri, 11 Apr 2014 06:39:29 +0000 (08:39 +0200)]
dvbsrc: Handle symbols added in minor version 7 and 8

Some symbols were re-defined in minor v8 (GO TEAM BACKWARDS COMPATIBLE!)

Some symbols were added in minor v7

https://bugzilla.gnome.org/show_bug.cgi?id=727977

10 years agogl/mem: cache the stride/unpack length for upload
Matthew Waters [Fri, 11 Apr 2014 07:24:39 +0000 (17:24 +1000)]
gl/mem: cache the stride/unpack length for upload

10 years agogl/color: explicitly map the buffers we are copying into
Matthew Waters [Fri, 11 Apr 2014 07:23:32 +0000 (17:23 +1000)]
gl/color: explicitly map the buffers we are copying into

Otherwise it may not be downloaded at all.

10 years agodvbsrc: Add comment with all DVB API v5 minor changes
Edward Hervey [Fri, 11 Apr 2014 06:16:01 +0000 (08:16 +0200)]
dvbsrc: Add comment with all DVB API v5 minor changes

There wasn't a definite list anyway, so I just dove in the kernel
and extract all that information.

10 years agogl/color: cache the temporary textures
Matthew Waters [Fri, 11 Apr 2014 06:09:09 +0000 (16:09 +1000)]
gl/color: cache the temporary textures

10 years agogl/mem: provide defines for tokens not defined in GLES2/ancient platforms
Matthew Waters [Fri, 11 Apr 2014 01:04:43 +0000 (11:04 +1000)]
gl/mem: provide defines for tokens not defined in GLES2/ancient platforms

10 years agogl: fixup incorrect number of arguments
Matthew Waters [Fri, 11 Apr 2014 01:03:19 +0000 (11:03 +1000)]
gl: fixup incorrect number of arguments

10 years agogl: fix incorrect usage of g_return_if_fail
Matthew Waters [Fri, 11 Apr 2014 00:55:21 +0000 (10:55 +1000)]
gl: fix incorrect usage of g_return_if_fail

10 years agogl/mem: allocate the memory per plane
Matthew Waters [Wed, 2 Apr 2014 06:43:52 +0000 (17:43 +1100)]
gl/mem: allocate the memory per plane

This patch provides the basic infrastructure required for this.
Upload and Download has been ported to this.

Has the nice effect of allowing GstGLMemory to be our
refcounted texture object for any texture type (not just RGBA).

Should not lose any features/video formats.

10 years agogl/eglimage: #if 0 unused code
Matthew Waters [Tue, 1 Apr 2014 04:10:05 +0000 (15:10 +1100)]
gl/eglimage: #if 0 unused code

10 years agogl: add colorconvert object that converts between color spaces/formats
Matthew Waters [Tue, 1 Apr 2014 02:30:51 +0000 (13:30 +1100)]
gl: add colorconvert object that converts between color spaces/formats

Currently used by both upload and download objects separately.

10 years agofaac: fix faac API error checking
Vincent Penquerc'h [Thu, 10 Apr 2014 16:55:21 +0000 (17:55 +0100)]
faac: fix faac API error checking

Coverity 1139790

10 years agodashdemux: do not ignore failure to register typefinder
Vincent Penquerc'h [Thu, 10 Apr 2014 16:52:02 +0000 (17:52 +0100)]
dashdemux: do not ignore failure to register typefinder

Coverity 1139629

10 years agodashdemux: fix time leak
Vincent Penquerc'h [Thu, 10 Apr 2014 16:48:03 +0000 (17:48 +0100)]
dashdemux: fix time leak

Coverity 1147016

10 years agodashdemux: remove dead code and variable
Vincent Penquerc'h [Thu, 10 Apr 2014 16:44:14 +0000 (17:44 +0100)]
dashdemux: remove dead code and variable

A recent commit made stream not able to be NULL, ending up with
a flag being always set to FALSE when it matters.

Coverity 1146968, 1147012

10 years agocurl: remove unneeded NULL check
Vincent Penquerc'h [Thu, 10 Apr 2014 16:37:22 +0000 (17:37 +0100)]
curl: remove unneeded NULL check

We just checked for NULL and allocated if it was. And glib aborts
if it can't allocate, I'm told.

Coverity 1139841

10 years agocurl: remove duplicate assignment
Vincent Penquerc'h [Thu, 10 Apr 2014 16:33:55 +0000 (17:33 +0100)]
curl: remove duplicate assignment

Coverity 1197708

10 years agohlsdemux: Also update the sequence position when updating non-live playlists
Sebastian Dröge [Thu, 10 Apr 2014 14:53:42 +0000 (16:53 +0200)]
hlsdemux: Also update the sequence position when updating non-live playlists

10 years agohlsdemux: Try reloading the playlist first if downloading a fragment fails
Sebastian Dröge [Thu, 10 Apr 2014 12:59:57 +0000 (14:59 +0200)]
hlsdemux: Try reloading the playlist first if downloading a fragment fails

But only add this for non-live playlists. For live playlists we already
have another thread that is periodically updating playlists.

Reason for this is that sometimes downloading a fragment can fail because
the URIs have changed or expired since last time.

10 years agohlsdemux: When updating a non-live playlist make sure to find the current sequence...
Sebastian Dröge [Thu, 10 Apr 2014 12:46:01 +0000 (14:46 +0200)]
hlsdemux: When updating a non-live playlist make sure to find the current sequence by time

Sequence numbers in different playlists are not guaranteed to be the same for the
same position, e.g. fragments could have different durations in different playlists.

In theory we should do exactly the same for live playlists, but unfortunately we can't
because doing this kind of seeking requires the complete playlist since we started
playback. For live playlists the server is however dropping fragments in the beginning
over time and we have no absolute time references.

10 years agosmoothstreaming: avoid using an uninitialized manifest
Vincent Penquerc'h [Wed, 9 Apr 2014 16:28:49 +0000 (17:28 +0100)]
smoothstreaming: avoid using an uninitialized manifest

If we did not set the manifest yet, early out in the seeking query.

Coverity 1139737

10 years agoh264parse: Set framerate even for interlaced videos
Thibault Saunier [Mon, 17 Mar 2014 15:39:42 +0000 (16:39 +0100)]
h264parse: Set framerate even for interlaced videos

Co-Authored by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>

https://bugzilla.gnome.org/show_bug.cgi?id=726752

10 years agompegts: add atsc terrestrial virtual channel table
Stefan Ringel [Wed, 9 Apr 2014 08:04:46 +0000 (10:04 +0200)]
mpegts: add atsc terrestrial virtual channel table

https://bugzilla.gnome.org/show_bug.cgi?id=727460

10 years agoliveadder: fix memory leak querying sink caps
Santiago Carot-Nemesio [Wed, 9 Apr 2014 13:07:19 +0000 (15:07 +0200)]
liveadder: fix memory leak querying sink caps

https://bugzilla.gnome.org/show_bug.cgi?id=727894

10 years agohlssink: catch failure to write playlist file
Vincent Penquerc'h [Wed, 9 Apr 2014 17:44:38 +0000 (18:44 +0100)]
hlssink: catch failure to write playlist file

Coverity 1139613

10 years agokate: fix implicit promotion to signed int breaking on largeish inputs
Vincent Penquerc'h [Wed, 9 Apr 2014 17:31:31 +0000 (18:31 +0100)]
kate: fix implicit promotion to signed int breaking on largeish inputs

Coverity 1139858, 1139857

10 years agoladspa: remove duplicate assignment
Vincent Penquerc'h [Wed, 9 Apr 2014 17:16:52 +0000 (18:16 +0100)]
ladspa: remove duplicate assignment

Coverity 1139706

10 years agomimdec: fix open error checking
Vincent Penquerc'h [Wed, 9 Apr 2014 17:12:58 +0000 (18:12 +0100)]
mimdec: fix open error checking

Coverity 206364

10 years agoschrodec: remove unnecessary check
Vincent Penquerc'h [Wed, 9 Apr 2014 16:37:41 +0000 (17:37 +0100)]
schrodec: remove unnecessary check

The tag was dereferenced earier. From the libschroedinger code,
it's not obvious to see whether tag and frame would be NULL at
the same time. I think is likely that both will be non NULL
here, but that's not certain. Additional tests may be needed
to avoid dereferencing tag and/or frame, but what to do if
only one is NULL isn't obvious, as the _get_tag function does
transfer ownership so isn't undoable.

Coverity 1139850

10 years agosmoothstreaming: remove unnecessary check
Vincent Penquerc'h [Wed, 9 Apr 2014 16:10:06 +0000 (17:10 +0100)]
smoothstreaming: remove unnecessary check

The function is static, the only call site passes a non NULL
pointer, and the pointer is dereferenced before anyway.

Coverity 1139839

10 years agosrtp: remove dead assignment
Vincent Penquerc'h [Wed, 9 Apr 2014 15:55:30 +0000 (16:55 +0100)]
srtp: remove dead assignment

Coverity 1197707

10 years agompegts: fix sdt length check
Vincent Penquerc'h [Wed, 9 Apr 2014 14:54:18 +0000 (15:54 +0100)]
mpegts: fix sdt length check

It was originally test for 9 bytes (as the comment says) and was
rewritten buggily. So rewrite it a third way, which is now
hopefully consistent with the original and the comment, while
being more sense-making to humans.

Coverity 1139654

10 years agoRevert "tsmux: catch alloc failure"
Vincent Penquerc'h [Wed, 9 Apr 2014 15:00:24 +0000 (16:00 +0100)]
Revert "tsmux: catch alloc failure"

Turns out glib aborts on allocation failure, so this is pointless.
We'll just ignore Coverity warnings on such constructs.

This reverts commit d347809a82e24057302f948269392e76aaacea10.

10 years agompegts: turns out glib aborts on allocation failure
Vincent Penquerc'h [Wed, 9 Apr 2014 14:58:37 +0000 (15:58 +0100)]
mpegts: turns out glib aborts on allocation failure

So this is actually pointless. We'll just have to ignore
Coverity moaning on those.

Revert "mpegts: test for allocation failure"

This reverts commit 224cb81b8fcbf03df5e07f045ecb9ecf64189400.

10 years agompegts: test for allocation failure
Vincent Penquerc'h [Wed, 9 Apr 2014 14:44:10 +0000 (15:44 +0100)]
mpegts: test for allocation failure

While it's unlikely to get there, it silences the coverity warning
on the error code path that we test for NULL before freeing, when
all branches there are from locations where pmt cannot be NULL,
and removing the NULL check makes the code more vulnerable to a
hypothetical future branch from somewhere where it can be.

Coverity 1139852

10 years agoasfmux: remove unnecessary test
Vincent Penquerc'h [Wed, 9 Apr 2014 14:41:11 +0000 (15:41 +0100)]
asfmux: remove unnecessary test

We've been dereferencing that object like there's no tomorrow
in the code just before that.

Coverity 206369

10 years agoasfmux: remove stray gst_buffer_unmap on error path
Vincent Penquerc'h [Wed, 9 Apr 2014 14:37:55 +0000 (15:37 +0100)]
asfmux: remove stray gst_buffer_unmap on error path

A previous commit removed the map, and the unmap on the main
code path, but not the one on the error path.

Coverity 1139930

10 years agoautoconvert: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 14:28:05 +0000 (15:28 +0100)]
autoconvert: remove dead code

Those events were previously taken from a cached events list,
which was removed during the port to 0.11, but this bit stayed.

Coverity 1139684

10 years agocamerabin2: remove unneeded check
Vincent Penquerc'h [Wed, 9 Apr 2014 14:24:13 +0000 (15:24 +0100)]
camerabin2: remove unneeded check

A message may not be NULL in the message handling function
(and nothing there sets it to NULL).

Coverity 1139848

10 years agocompare: special case empty regions with 1 SSIM to avoid dividing by 0
Vincent Penquerc'h [Wed, 9 Apr 2014 14:18:22 +0000 (15:18 +0100)]
compare: special case empty regions with 1 SSIM to avoid dividing by 0

Coverity 1139689, 1139688

10 years agointer: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 14:09:25 +0000 (15:09 +0100)]
inter: remove dead code

Coverity 1139666

10 years agoliveadder: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 14:03:45 +0000 (15:03 +0100)]
liveadder: remove dead code

From the 0.11 port

Coverity 1139676

10 years agoresindvd: avoid crashing in pathological case
Vincent Penquerc'h [Wed, 9 Apr 2014 13:37:48 +0000 (14:37 +0100)]
resindvd: avoid crashing in pathological case

When we'd see an unknown stream type, then a SDDS stream.
Then we'd get to the end of the switch with a NULL temp stream
pointer, and dereference it.

Coverity 1139708

10 years agompegtsdemux: catch prev-not-found when inserting in the group list
Vincent Penquerc'h [Wed, 9 Apr 2014 13:13:46 +0000 (14:13 +0100)]
mpegtsdemux: catch prev-not-found when inserting in the group list

While this probably should never happen if callers are well behaved,
this avoids a crash if it does. With a warning about it. Unsure if
it'd be better to not add at all, but it should not happen...

Coverity 1139713

10 years agompegtsmux: guard against _dispose being called mutiple times
Vincent Penquerc'h [Wed, 9 Apr 2014 12:51:41 +0000 (13:51 +0100)]
mpegtsmux: guard against _dispose being called mutiple times

_dispose calls _reset, so we need to make sure _reset handles
already NULLed fields.

Coverity 1139843