Hermet Park [Fri, 12 Feb 2016 16:43:56 +0000 (01:43 +0900)]
widget: don't access a widget focus if the object is not a widget.
Youngbok Shin [Fri, 12 Feb 2016 11:18:05 +0000 (20:18 +0900)]
entry: add elm_entry_select_region_get() API
Summary:
Already, there is a way to set a selection region:
elm_entry_select_region_set()
The get() API also useful and there is needs for this
inside of elm_entry.c. Add the API and replace codes
in atspi_text_selection_get with the API.
@feature
Test Plan:
1. Run "elementary_test -to entry3"
2. Make a selection on text.
3. Press "Sel" button.
Reviewers: tasn, herdsman, cedric, woohyun, Jaehyun, Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3639
Jee-Yong Um [Fri, 12 Feb 2016 10:50:55 +0000 (19:50 +0900)]
els_box: fix item sizing error
Summary:
Although items' size hint align are not set to fill,
Elm.Box expands its items.
This patch fixes item sizing error.
Test Plan: attached sample
Reviewers: cedric, jpeg, Hermet, Jaehyun, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3667
Prince Kumar Dubey [Fri, 12 Feb 2016 10:42:25 +0000 (19:42 +0900)]
[gengrid] possible crash issue fixed.
Summary: reset show_it, bring_in_it and corresponding flags on item deletion
Test Plan: delete item with animation and rotate the handset display.
Reviewers: raster, cedric
Subscribers: shilpasingh, godlytalias, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D3672
Youngbok Shin [Fri, 12 Feb 2016 10:39:53 +0000 (19:39 +0900)]
label: add elm.swallow.background part to all of groups
Summary:
elm.swallow.background part will be a default part for
widget's background image.
Test Plan: N/A
Reviewers: woohyun, cedric, kimcinoo
Differential Revision: https://phab.enlightenment.org/D3675
Daniel Kolesa [Wed, 10 Feb 2016 16:07:06 +0000 (16:07 +0000)]
eolian helper: add --silent-types to mirror EFL
Vitor Sousa [Fri, 5 Feb 2016 16:48:35 +0000 (14:48 -0200)]
elementary: Use new object name "Elm.Widget_Item" instead of old name
Replace the old name "Elm.Object.Item" by the new name of the class
"Elm.Widget_Item" in all .eo files.
Larry [Thu, 4 Feb 2016 20:08:14 +0000 (18:08 -0200)]
Elm_Image: moved undefined types to eolian file
Vitor Sousa [Thu, 4 Feb 2016 18:33:46 +0000 (16:33 -0200)]
elm win: replace Evas_Modifier_Mask by Evas.Modifier.Mask in elm_win.eo
Vitor Sousa [Tue, 2 Feb 2016 20:37:06 +0000 (18:37 -0200)]
elm genlist: use Eolian conventions for Elm.List.Mode in elm_genlist.eo
Use Eolian names for types and values of the enumeration Elm.List.Mode,
instead of legacy names, in elm_genlist.eo.
Larry [Mon, 1 Feb 2016 20:53:07 +0000 (18:53 -0200)]
Elm.Map: move emun Zoom Mode, Source Type and Route Type to Eolian
Larry [Fri, 29 Jan 2016 20:12:17 +0000 (18:12 -0200)]
move enum e structs defines of elm_atspi_text to eolian
Vitor Sousa [Mon, 1 Feb 2016 14:14:17 +0000 (12:14 -0200)]
elementary: move types to elm_interface_atspi_accessible.eo
Move structs, enums and typedefs definitions from
elm_interface_atspi_accessible.h to elm_interface_atspi_accessible.eo.
Give them namespace names to conform with Eolian policies.
Replace all occurrences in elm_interface_atspi_accessible.eo with the
Eolian names.
Adjust include order in elm_interface_atspi_accessible.h to avoid
errors.
Larry [Wed, 27 Jan 2016 20:45:43 +0000 (18:45 -0200)]
elm_glview: move enums to eolian files
Larry [Thu, 21 Jan 2016 22:35:36 +0000 (20:35 -0200)]
elm_gesture_layer: move enums to .eo
Vitor Sousa [Mon, 25 Jan 2016 23:13:51 +0000 (21:13 -0200)]
elm gengrid: replace Ecore_Pos_Map with Ecore.Pos_Map in elm_gengrid.eo
Replace Ecore_Pos_Map with Ecore.Pos_Map in elm_gengrid.eo to correctly
use the Eolian name of the type.
Vitor Sousa [Fri, 22 Jan 2016 21:42:58 +0000 (19:42 -0200)]
elementary: move definition of Elm_Glob_Match_Flags to elm_general.eot
Move definition of Elm_Glob_Match_Flags from elm_gen.h to
elm_general.eot.
Use the Eolian name Elm.Glob.Match_Flags and replace the older name
by it in all .eo files.
Keep the legacy prefix "ELM_GLOB_MATCH".
Vitor Sousa [Thu, 21 Jan 2016 21:37:05 +0000 (19:37 -0200)]
elementary: use the Eolian name for Elm.Genlist.Item.Type in .eo files
Replace Elm_Genlist_Item_Type with Elm.Genlist.Item.Type in .eo files
to use the proper Eolian name of this enumeration.
Vitor Sousa [Thu, 21 Jan 2016 21:16:22 +0000 (19:16 -0200)]
elementary: move definition of Elm_Gen_Item_Class to elm_general.eot
Move the definition of Elm_Gen_Item_Class from elm_gen.h to
elm_general.eot.
Also move the definition of its aliases Elm_Gengrid_Item_Class and
Elm_Genlist_Item_Class from elm_gengrid_common.h and
elm_genlist_common.h to elm_general.eot.
Rename these types to Elm.Gen.Item.Class, Elm.Gengrid.Item.Class and
Elm.Genlist.Item.Class to follow Eolian standards. And rename all
occurrences in .eo files accordingly.
Put elm_gen.h include above elm_general.h to allow the callback fields
to be defined in elm_general.eot.
Vitor Sousa [Tue, 19 Jan 2016 20:45:45 +0000 (18:45 -0200)]
elm_calendar,elm_datetime: move struct tm typedefs to .eo files
Move elm_calendar and elm_datetime struct tm typedefs to theirs
respective .eo files.
Use Ecore.Time, an alias to struct tm, to refer to this type in the
.eo files.
Use namespaced names for these typedefs, in order to follow Eolian
standards.
Vitor Sousa [Mon, 18 Jan 2016 18:20:59 +0000 (16:20 -0200)]
elementary: move definition of Elm_App_View_State to elm_general.eot
Move the definition of the enumeration Elm_App_View_State from
elm_app_common.h to elm_general.eot, and give it the the Eolian name:
Elm.App.View_State.
Replace Elm_App_View_State with Elm.App.View_State in
elm_app_client_view.eo and elm_app_server_view.eo.
Vitor Sousa [Mon, 18 Jan 2016 17:03:50 +0000 (15:03 -0200)]
elm gengrid: fix Elm.Gengrid.Item.Scrollto_Type usage in .eo file
Use the proper Eolian name "Elm.Gengrid.Item.Scrollto_Type" instead of
Elm_Gengrid_Item_Scrollto_Type in functions in elm_gengrid_item.eo.
Vitor Sousa [Thu, 14 Jan 2016 20:17:10 +0000 (18:17 -0200)]
elm entry: Move the declaration of Elm_Cnp_Mode to elm_entry.eo
Move the enumeration Elm_Cnp_Mode to elm_entry.eo to make it more
accessible for binding generation.
Also rename it to Elm.Cnp_Mode.
Vitor Sousa [Thu, 14 Jan 2016 20:11:20 +0000 (18:11 -0200)]
elementary: Rename Elm_Icon_Type to Elm.Icon.Type in .eo files
Correct the usage of the type Elm_Icon_Type by replacing it with its
Eolian name (Elm.Icon.Type) in .eo files.
Vitor Sousa [Mon, 11 Jan 2016 10:38:57 +0000 (08:38 -0200)]
elementary: rename classes in Eo files to use Elm as a namespace, not a prefix
Rename classes in Eo files that still uses "Elm" as a prefix to use it as a
namespace.
Stefan Schmidt [Fri, 5 Feb 2016 12:21:08 +0000 (13:21 +0100)]
theme: fix typo for adding background in ctxpopup
Introduced in
6cf09175874cca9e5859d580a5bad706012b8880. Thanks a lot to Davide
Andreoli for spotting this!
SungTaek Hong [Fri, 5 Feb 2016 07:21:54 +0000 (08:21 +0100)]
button: add elm.swallow.background part
Summary:
- This swallow part is for custom bg image.
- previous bg has to be hid.
Reviewers: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3657
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
SungTaek Hong [Fri, 5 Feb 2016 07:21:13 +0000 (08:21 +0100)]
button: remove unnecessary action in program
Summary: @fix
Reviewers: kimcinoo, Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3658
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
taehyub [Fri, 5 Feb 2016 07:18:31 +0000 (08:18 +0100)]
popup: add elm.swallow.background for background customize
Summary: add elm.swallow.background part in elm/popup/base/default
Reviewers: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3645
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
taehyub [Fri, 5 Feb 2016 07:17:55 +0000 (08:17 +0100)]
ctxpopup: add elm.swallow.backgournd for backgournd customize
Summary: add elm.swallow.background part in elm/ctxpopup/base/default
Reviewers: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3646
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Fri, 5 Feb 2016 07:16:58 +0000 (08:16 +0100)]
genlist: remove dead code.
Youngbok Shin [Fri, 5 Feb 2016 07:15:29 +0000 (08:15 +0100)]
win: fix a possible crash in elm_win_add
Summary:
The enginelist[0] can be NULL in some very rare cases.
Then enginelist[0] will be used for strcmp and it make a crash.
@fix
Test Plan: N/A
Reviewers: raster, cedric, woohyun, jypark, jaehwan
Differential Revision: https://phab.enlightenment.org/D3649
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jee-Yong Um [Fri, 5 Feb 2016 07:13:11 +0000 (08:13 +0100)]
elm: add Elm.Layout as edje externals' contents instead of Edje.Object
Summary:
When edje external parts add its content, edje object is added,
but it breaks elementary widget hierarchy.
In Elementary, edje external can use Elm.Layout to add its content.
Reviewers: cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3655
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Godly T Alias [Fri, 5 Feb 2016 07:11:41 +0000 (08:11 +0100)]
genlist: fix for a bug in tree expansion, T3132
Summary:
@fix T3132
If nobody sees issue with this change, this should be backported.
Signed-off-by: Godly T Alias <godly.talias@samsung.com>
Test Plan: elementary_test Genlist Tree, enable Tree effect
Reviewers: prince.dubey, SanghyeonLee, shilpasingh
Subscribers: govi, rajeshps
Maniphest Tasks: T3132
Differential Revision: https://phab.enlightenment.org/D3656
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Godly T Alias [Fri, 5 Feb 2016 07:08:16 +0000 (08:08 +0100)]
transit: add possibility to revert an ongoing transition during play
Summary:
Currently the feature available in transit to reverse play a transition is
auto-reverse which will play a transition in reverse mode once a transition
is complete. This feature helps the user to revert a transition at any point
of time when transition is going on.
New API added.
@feature T3019
Use Case:
While doing pinch zoom, we will be doing zoom transit effect from one step to other, during that transit if user do the pinch in reverse direction this API can be called so that transition will be reverted easily.
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test Transit Resizing / Transit Zoom / Transit Bezier / Transit Custom / Transit Fade / Transit Flip
Reviewers: raster, prince.dubey, shilpasingh, Hermet, seoz, cedric
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3567
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jee-Yong Um [Fri, 5 Feb 2016 06:47:31 +0000 (07:47 +0100)]
hoversel: improve key_action_move to handle disabled items
Summary:
Existing key_action_move logic used elm_widget_focus_cycle on hover,
but only handled the first and last item to move focus circularly.
So if the first or last item is disabled, focus movement is blocked.
This patch makes hoversel handle focus movement by itself to handle
disabled item better.
Test Plan: elementary_test -to hoversel
Reviewers: Hermet, cedric, Jaehyun
Differential Revision: https://phab.enlightenment.org/D3640
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
divyesh purohit [Fri, 5 Feb 2016 06:18:04 +0000 (07:18 +0100)]
combobox: prevent empty swallow to be shown on hover_dismiss animation
Summary:
Hover dismiss animation takes 0.5 sec to complete. if the genlist item_count
becomes zero, empty swallow is shown in dismiss animation.
@fix T3124
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
please run combobox example from elementary_test.
Open hover by pressing on left side button of combobox or pressing "enter/space" key in entry
contained in combobox.
Type a char which is not in any genlist item , for example "a' is not presented in any genlist
item.
empty swallow shouldn't seen in dismiss animation.
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3124
Differential Revision: https://phab.enlightenment.org/D3630
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
divyesh purohit [Fri, 5 Feb 2016 06:16:13 +0000 (07:16 +0100)]
multibuttonentry: fix Segfault on pressing Delete Key
Summary:
Pressing "Delete" Key in MBE layout causes Segfault as MBE item is not deleted properly and also focus is not transferred back to MBE.
@fix
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: Run MultibuttonEntry example from elementart_test . Add some MBE items, now press the delete key, it should delete items without causing segfaults and transfer focus to previous MBE item.
Reviewers: raster, cedric, CHAN, shilpasingh
Reviewed By: shilpasingh
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3635
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Thiep Ha [Fri, 5 Feb 2016 06:43:06 +0000 (15:43 +0900)]
entry: remove unnecessary variables
remove unnecessary dw, dh variables
Shilpa Singh [Fri, 5 Feb 2016 06:05:57 +0000 (15:05 +0900)]
Elm_Entry: Magnifier Not working properly on corner areas issue fix.
Summary:
When magnifier is moved across corners and outside entry, working of magnifier
is not proper.
Magnifier is Restricted with in the window and to entry area and its position depends
on cursor.
Signed-off-by: Thiep Ha <thiepha@gmail.com>
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan:
1. Enable Magnifier export ELM_MAGNIFIER_ENABLE=1
2. Launch elementary test and launch entry3 demo
3. Move magnifier on corners and outside of second entry
The contents of magnifiers are undefined when moved outside entry
and clipper moves in a different direction as magnifier.
Reviewers: cedric, raster, thiepha
Reviewed By: thiepha
Subscribers: buds, govi, rajeshps, subodh6129
Differential Revision: https://phab.enlightenment.org/D3586
Amitesh Singh [Thu, 4 Feb 2016 18:14:19 +0000 (23:44 +0530)]
genlist: update all realized items in a single job
Summary:
Its really weird to call same job for each item and deletes that job in
next iteration. Since item_update() deletes the old update_job ecore job
again so basically we call update job only for the last realized item in the list.
@fix
Reviewers: raster, jpeg, cedric, SanghyeonLee, tasn
Reviewed By: SanghyeonLee
Subscribers: seoz
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3644
Felipe Magno de Almeida [Wed, 3 Feb 2016 23:19:51 +0000 (21:19 -0200)]
js: Added layout example
divyesh purohit [Sat, 30 Jan 2016 20:29:35 +0000 (18:29 -0200)]
js: Added combobox class to JavaScript binding
Vitalii Vorobiov [Wed, 3 Feb 2016 12:13:49 +0000 (12:13 +0000)]
calendar.edc: fix typo in text style
@fix
Chris Michael [Tue, 2 Feb 2016 20:02:20 +0000 (15:02 -0500)]
elementary: update mailmap addresses
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Cedric BAIL [Tue, 2 Feb 2016 19:39:10 +0000 (11:39 -0800)]
panel: no need for destructor anymore as the event handler will disappear in the destructor.
Cedric BAIL [Tue, 2 Feb 2016 00:02:56 +0000 (16:02 -0800)]
genlist: make automatic bounce test configurable.
Cedric BAIL [Fri, 29 Jan 2016 23:47:38 +0000 (00:47 +0100)]
naviframe: switch to use animator,tick.
Cedric BAIL [Fri, 29 Jan 2016 01:07:34 +0000 (17:07 -0800)]
genlist: switch to efl.core.animator tick.
Cedric BAIL [Fri, 29 Jan 2016 01:05:08 +0000 (17:05 -0800)]
tests: switch anim test to Efl.Core.Animator tick.
Cedric BAIL [Thu, 28 Jan 2016 00:46:16 +0000 (16:46 -0800)]
map: use Efl.Core.Animator tick.
Cedric BAIL [Wed, 27 Jan 2016 00:13:23 +0000 (16:13 -0800)]
photocam: switch to use efl.core.animator.
Cedric BAIL [Tue, 26 Jan 2016 23:51:49 +0000 (15:51 -0800)]
interface_scrollable: drop use of ecore_animator in favor of efl.core.animator tick
Cedric BAIL [Tue, 26 Jan 2016 23:51:19 +0000 (15:51 -0800)]
scroller: prevent the use of uninitialized data in some case.
Cedric BAIL [Tue, 26 Jan 2016 22:26:31 +0000 (14:26 -0800)]
panel: switch to use per window animator.
Tick provided by to efl.core.animator.
Cedric BAIL [Tue, 26 Jan 2016 22:07:29 +0000 (14:07 -0800)]
win: remove animator,tick.
woochan lee [Tue, 2 Feb 2016 11:35:17 +0000 (20:35 +0900)]
multibuttonentry: Add item unfocused callback.
Summary:
Even MBE item lose focus, item state did not changed before.
So i send a signal to make item state as default when item lose own focus.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan:
Run MBE sample.
Click any item.
Click out of MBE area.
See the item still got a highlight.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2994
Conflicts:
data/themes/edc/elm/multibuttonentry.edc
Jee-Yong Um [Tue, 2 Feb 2016 10:57:20 +0000 (19:57 +0900)]
elm_hoversel: add "escape" key action to dismiss
Summary:
To allow to dismiss hoversel expansion without selecting item
by key, "escape" key action is added.
Test Plan: elementary_test -to hoversel
Reviewers: Jaehyun_Cho, cedric, divyesh
Reviewed By: divyesh
Differential Revision: https://phab.enlightenment.org/D3627
Jinyong Park [Tue, 2 Feb 2016 10:47:28 +0000 (19:47 +0900)]
fix calendar today bug
Summary: After today mark appear once on calendar, it never disappear when user change calendar's year or month
Test Plan: elementary_test calendar2
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D3612
Vitor Sousa [Tue, 26 Jan 2016 13:02:52 +0000 (13:02 +0000)]
elm calendar: add mark_del method and move Elm_Calendar_Mark to .eo file
Summary:
Add mark_del as a method in the Elm.Calendar class.
Move the elm_calendar_mark_del() function (which do not receive an Eo object)
to elm_calendar_legacy.h.
Move the declaration of Elm_Calendar_Mark to elm_calendar.eo as an opaque
struct.
Rename it to Elm.Calendar.Mark to follow eolian standards.
Update documentation to refer to mark_del method instead of the
elm_calendar_mark_del() function.
Reviewers: felipealmeida, vinipsmaker, larryolj, cedric, tasn
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D3582
Subodh Kumar [Thu, 14 Jan 2016 16:05:08 +0000 (16:05 +0000)]
Elm entry: Fix selection using handlers.
Summary:
Fix item selection using selection handler
In case of selection using handler, there is a problem in case the entry
has the item, mouse down over handler consider the current down
coordinate to start selection and it becomes very difficult to select in the
situation shown in the test plan. So I consider the next/previous line
geometry to fix it.
@fix
Test Plan:
1.Enable selection handler
2. Have a look at the setup in the attached image
{F27396}
3. Start selecting from last item and extent to cover the last text.
4.Observe that its impossible to select the last text until you move mouse out of the window
So, in mobile device its almost impossible to select using handlers in this situation.
Please use the attached application to test it.
{F27402}
Reviewers: thiepha, herdsman, tasn
Reviewed By: tasn
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3479
Subodh Kumar [Tue, 12 Jan 2016 13:25:12 +0000 (13:25 +0000)]
Elm entry: Use edje api and simplify empty check logic
Summary: Use edje api and simplify empty check logic
Test Plan: NA
Reviewers: herdsman, tasn
Reviewed By: tasn
Subscribers: shilpasingh, cedric
Differential Revision: https://phab.enlightenment.org/D3505
Stefan Schmidt [Tue, 2 Feb 2016 10:19:42 +0000 (11:19 +0100)]
configure: Switch to dev mode again. Merge window for 1.18 is now open.
Stefan Schmidt [Tue, 2 Feb 2016 09:48:10 +0000 (10:48 +0100)]
release: Update NEWS and bump version for 1.17.0 release
Stefan Schmidt [Mon, 1 Feb 2016 21:48:33 +0000 (22:48 +0100)]
theme: make sure vertical_separated_bar_disabled.png lands in the dist tarball
A ix for commit
186aeb42eb7e97c07a58a30aafbca5d05c4e2302 which introduced the
image but did not made sure it gets shipped.
Hermet Park [Mon, 1 Feb 2016 13:35:23 +0000 (22:35 +0900)]
layout: test code refactoring.
remove a comment.
pass immediate parents.
remove unnecessary show call.
Jean-Philippe Andre [Mon, 1 Feb 2016 11:48:21 +0000 (20:48 +0900)]
genlist test: fix invalid free on window close
Jean-Philippe Andre [Mon, 1 Feb 2016 02:27:56 +0000 (11:27 +0900)]
genlist/gengrid: Fix focus hilight error
The error was due to an invalid cast between real data and Eo ptr.
Thanks @DaveMDS for reporting.
Fixes T3122
@fix
Jean-Philippe Andre [Mon, 1 Feb 2016 04:25:01 +0000 (13:25 +0900)]
test: reflow check boxes in genlist and gengrid focus tests
Without this, the items never get unrealized, except on
window close. This allows better testing of those widgets.
Andy Williams [Sat, 30 Jan 2016 13:54:24 +0000 (13:54 +0000)]
[toolbar] Adjust icon size along with text etc.
As discussed on the mailing list elm should scale the whole UI
based on the scale value. Make toolbar icons match this.
@fix
Andy Williams [Fri, 29 Jan 2016 15:33:27 +0000 (15:33 +0000)]
[toolbar] don't leak icons into the UI
This cleans up orphan icons being left in the UI if you call icon_set
after the toolbar has been displayed.
This was most noticable if the toolbar or buttons move first
@fix
Jee-Yong Um [Thu, 28 Jan 2016 09:57:10 +0000 (18:57 +0900)]
elm_focus: refine focus.edc
Summary: remove whitespaces and add programs block
Reviewers: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3616
Conflicts:
data/themes/edc/elm/focus.edc
Jee-Yong Um [Thu, 28 Jan 2016 09:12:30 +0000 (18:12 +0900)]
elm_focus: fix mislocation error during continuous focus movement
Summary:
When focus is moved fast and continuously, newly created animator
conflicts with the animator for previous movement, so focus bounces
among locations.
This patch removes previous animator and move focus to the final
location before creating new animator.
Test Plan:
elementary_test -to focus
elementary_test -to genlist
Reviewers: raster, jpeg, cedric, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3611
Jee-Yong Um [Wed, 27 Jan 2016 05:56:50 +0000 (14:56 +0900)]
remove incorrect references of insert_before/after in EDC
Summary:
This patch removes unavailable references to nonexistent parts
from default theme.
Reviewers: raster, jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D3609
Divyesh Purohit [Tue, 26 Jan 2016 21:01:55 +0000 (13:01 -0800)]
combobox: avoid calling item_selected and dismissed signal on show
Summary:
After this patch https://phab.enlightenment.org/rELM0f6e1a46a402fd9cf848ffb1bd47c6b406eb7ffa
calling item,selected and dismissed signals should be avoided on combobox show.
Signed-off-by: Divyesh Purohit <purohit.div@gmail.com>
Test Plan: please run combobox example from elementary_test
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3603
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Divyesh Purohit [Tue, 26 Jan 2016 21:01:03 +0000 (13:01 -0800)]
combobox: fix continuous clicks on hover
Summary:
Continouous clicks on hover would need to ensure that variable
on_dismiss of combobox_vertical style in hover.edc should 0 when slot is being shown, otherwise events
would be disabled on hover even though swallow content is shown.
@fix
Signed-off-by: Divyesh Purohit <purohit.div@gmail.com>
Test Plan:
Click continouosly on combobox and events on hover would be
disabled.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3601
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
divyesh purohit [Tue, 26 Jan 2016 21:00:22 +0000 (13:00 -0800)]
combobox: fix disabled state
Summary:
Apply gray-scale to vertical_separated_bar_glow image and increase the opacity
of the button, so that the text on the entry is visible.
@fix T3075
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example from elementary_test
Reviewers: shilpasingh, cedric, raster
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3605
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hermet Park [Tue, 26 Jan 2016 10:34:46 +0000 (19:34 +0900)]
Fix toogle icon sizing issue.
Strangely, toggle couldn't afford it's icon space
at elementary_test -> check toggle.
Following to default style which is normal to avoid this wierd look.
Dave Andreoli [Mon, 25 Jan 2016 21:17:09 +0000 (22:17 +0100)]
Elm Image: fix usage of animated gif on the same image object more than one time
This patch @fix this usage example:
0. image obj create
1. file_set(an animated gif)
2. animated_set(TRUE) + animated_play_set(TRUE) to make the gif play
3. file_set(a normal image)
... at this point elm_image is confused because it still think that the image is animated
4. file_set(an animated gif)
5. animated_set(TRUE) + animated_play_set(TRUE) to make the gif play
...this now do not work because elm think that the image is already animated
Stefan Schmidt [Mon, 25 Jan 2016 17:00:33 +0000 (18:00 +0100)]
release: Update NEWS and bump version for 1.17.0-beta3 release
Mike Blumenkrantz [Mon, 25 Jan 2016 17:32:34 +0000 (12:32 -0500)]
shelf: add "noshadow" data item to indicate no shadow should be used
Chris Michael [Mon, 25 Jan 2016 12:43:03 +0000 (07:43 -0500)]
elementary: Add missing EINA_UNUSED in combobox function
_elm_combobox_elm_genlist_filter_set function does not use the Eo *obj
parameter so mark it as EINA_UNUSED to remove compiler warning
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Jaehyun Cho [Mon, 25 Jan 2016 09:13:25 +0000 (18:13 +0900)]
naviframe: Update documentation of item_pop_cb_set and item_pop_to.
Jean-Philippe Andre [Fri, 22 Jan 2016 08:13:35 +0000 (17:13 +0900)]
elm_test: Show popup error when Plug can't connect
Dave Andreoli [Sun, 24 Jan 2016 15:44:57 +0000 (16:44 +0100)]
Genlist: do not select the item two times in case of a double click.
In the case of a genlist set as ELM_OBJECT_SELECT_MODE_ALWAYS the "selected" cb was called 2 times. This @fix that by skipping the selection code in case the click is not the first one (EVAS_BUTTON_NONE).
Also merge the conditions of two consecutive "if" in a single statement.
Dave Andreoli [Sun, 24 Jan 2016 15:11:13 +0000 (16:11 +0100)]
Genlist/grid: do not set again the focus on double/triple click
Focus is already setted on first mouse-up, no need to set again in double and triple click up events
@Fix the issue reported in previous commits
Dave Andreoli [Sun, 24 Jan 2016 14:44:48 +0000 (15:44 +0100)]
Reveal the same focus bug of previous commit also in genlist.
See previous commit for instructions on how to reproduce in "Genlist Focus" test.
Dave Andreoli [Sun, 24 Jan 2016 13:35:49 +0000 (14:35 +0100)]
Add a test to reveal a focus bug in Genlist/Gengrid
To reproduce:
* elm_test -to "GenGrid Focus"
* turn on the "Focus Highlight" checkbox
* double-click an item to show a popup that should have the focus
As you can see the mouse-up event on the gengrid item steal the focus from the popup.
When, instead, the item is activated with the keyboard the popup correctly keep the focus.
I have this problem in both genlist and gengrid, so probably the error is not in the gengrid code, but somewhere else that I cannot find.
...any help appreciated
divyesh purohit [Fri, 22 Jan 2016 19:07:01 +0000 (11:07 -0800)]
combobox: apply proper style
Summary:
Initially combobox used hover's default style, this patch would make combobox use hoversel_vertical style.
@Fix T3075 for 2nd point.
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example from elementary_test
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3596
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
divyesh purohit [Fri, 22 Jan 2016 19:00:20 +0000 (11:00 -0800)]
combobox: "return" key handled correctly and removed unreachable code.
Summary:
_key_action_activate was triggered when "return" was pressed, _key_action_move
contained the "return" key handling, which is unreachable code.
@fix T3075 (1st point).
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example in elementary_test
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3599
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Fri, 22 Jan 2016 18:44:03 +0000 (10:44 -0800)]
combobox: move responsibility to define filter and content to the user of a combobox
Before this patch, the filter was set inside the combobox. This is confusing for the
user of the object as it can't define a custom filter except on strings. It is also
impossible to bind as binding require to know what was put in and they can't differentiate
between a genlist filter being set from the binding to one being set internally by
the combobox.
@fix
SangHyeon Lee [Fri, 22 Jan 2016 07:55:37 +0000 (16:55 +0900)]
genlist : fix tree item floating issue when homoegeneous mode is enabled
genlist item is flaoting upon the expanded item when homoegeneous mode
is enabled.
when item block is recalculated by tree expanding, new item didn't
update their properties and values becuase of size hash, but edc
actaully need to be recaculated after swallowing tree size padding.
solve the issue by adding expand depth check in size hash.
you can check the previous issue in T2708
elementary_test->genlist tree->homoegeneous check
@fix
Dave Andreoli [Thu, 21 Jan 2016 21:21:30 +0000 (22:21 +0100)]
Adjust "context_menu_disabled" configuration.
This @fix three (yes 3!) errors from commit
cafda5928f9bf8116564219dc03d12c3a6e131b3
1. the initial value in the standard config is wrong, causing ctx menu to be disabled for everyone!
2. the argument of the api should be named "disabled" (like all the other disable API in this context)
3. (minor) fixed doc for elm_config_context_menu_disabled_set
NOTE: there are no configuration gui for this option, if you cleared your elm config recently you probably now have the ctx menu disabled everywhere, only solution is to wipe your config (to let elm create a new correct one)
Big SPANK to the author, the commiter and all the reviewers of D2463!!!
Jean-Philippe Andre [Thu, 21 Jan 2016 05:45:05 +0000 (14:45 +0900)]
elm: Replace EO_EV_ by EO_BASE_EVENT_
EO_EV_ stuff is deprecated
Jee-Yong Um [Wed, 20 Jan 2016 12:29:12 +0000 (21:29 +0900)]
elm_hoversel: fix calculation to make items fit to dropdown box
Summary:
While applying scroller on hoversel, several lines for item size
calculation were added, but they failed to have item get proper size.
Now redundant codes are removed and some are fixed, and hoversel will
be shown more well-ordered.
Test Plan: elementary_test hoversel
Reviewers: jpeg, raster, cedric
Differential Revision: https://phab.enlightenment.org/D3589
Minkyu Kang [Wed, 20 Jan 2016 08:15:45 +0000 (17:15 +0900)]
elm_widget: use internal function for clearing the focus
Summary:
This patch will remove duplicate logic
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: seoz, Hermet, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3573
Hermet Park [Wed, 20 Jan 2016 08:10:16 +0000 (17:10 +0900)]
update author
Minkyu Kang [Wed, 20 Jan 2016 08:06:22 +0000 (17:06 +0900)]
elm_widget: cleanup _elm_widget_on_focus function
Summary:
This patch will reduce duplicate codes and code depth for readability
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: seoz, Hermet, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3574
Dave Andreoli [Tue, 19 Jan 2016 19:33:47 +0000 (20:33 +0100)]
Combobox: rename the "selected" event to "item,selected" as it should be.
Also updated the test to reflect this change
Chris Michael [Tue, 19 Jan 2016 15:43:28 +0000 (10:43 -0500)]
elementary: Fix elm_win_window_id_get function
When using this function with wayland windows, we should be returning
the matching Ecore_Wl2_Window id, not the surface_id
ref T3058
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>