platform/upstream/efl.git
4 years agotests/spin_button: include Elementary.h since this uses legacy api
Mike Blumenkrantz [Fri, 27 Sep 2019 15:06:21 +0000 (11:06 -0400)]
tests/spin_button: include Elementary.h since this uses legacy api

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10233

4 years agotests/spec: use eo types here since this isn't supposed to use legacy
Mike Blumenkrantz [Fri, 27 Sep 2019 15:06:05 +0000 (11:06 -0400)]
tests/spec: use eo types here since this isn't supposed to use legacy

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10232

4 years agoefl_ui: explicitly include eo headers for a couple types
Mike Blumenkrantz [Fri, 27 Sep 2019 15:05:24 +0000 (11:05 -0400)]
efl_ui: explicitly include eo headers for a couple types

the general headers here pull in legacy headers, which is bad

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10231

4 years agoelm_test/radio: use eo type here
Mike Blumenkrantz [Fri, 27 Sep 2019 15:04:38 +0000 (11:04 -0400)]
elm_test/radio: use eo type here

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10230

4 years agoedje: add Efl_Layout.h for eo-based layout headers
Mike Blumenkrantz [Fri, 27 Sep 2019 14:27:05 +0000 (10:27 -0400)]
edje: add Efl_Layout.h for eo-based layout headers

this includes all related headers

ref T8274

Additional Authors: Lauro Moura <lauromoura@expertisesolutions.com.br>

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10228

4 years agoedje: rename edje_types.eot to efl_canvas_types.eot and move include
Mike Blumenkrantz [Fri, 27 Sep 2019 14:26:27 +0000 (10:26 -0400)]
edje: rename edje_types.eot to efl_canvas_types.eot and move include

this has no relation to legacy and should not be included in legacy headers

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10227

4 years agoefl/canvas: add Efl_Canvas.h
Mike Blumenkrantz [Fri, 27 Sep 2019 14:06:30 +0000 (10:06 -0400)]
efl/canvas: add Efl_Canvas.h

this includes all the efl.canvas headers and adds some compilation tests
for the header to the unit test suite

ref T8274

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10226

4 years agoevas map: diable high quality texture mapping feature.
Hermet Park [Mon, 30 Sep 2019 07:53:29 +0000 (16:53 +0900)]
evas map: diable high quality texture mapping feature.

This is a little bit buggy, need to make it stablize further.

Temporarily diable this for 1.23 release.

4 years agotheme: port to efl.ui.clickable and use macro for anchor style
Jaehyun Cho [Mon, 30 Sep 2019 07:19:31 +0000 (07:19 +0000)]
theme: port to efl.ui.clickable and use macro for anchor style

This patch applies the following commits to anchor style.
bb1388798b1afaced65484cedf385a93f6b1bb6a
122ca2fa2f9290729e10715253e45f0ad343e09a

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10247

4 years agoeolian_mono: support beta for enum if mono-beta is enabled
Jaehyun Cho [Mon, 30 Sep 2019 06:51:31 +0000 (15:51 +0900)]
eolian_mono: support beta for enum if mono-beta is enabled

Summary: this generates beta enum with `-Dmono-beta=true`.

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10246

4 years agoeolian_mono: Respect beta for enum
Yeongjong Lee [Mon, 30 Sep 2019 04:52:45 +0000 (13:52 +0900)]
eolian_mono: Respect beta for enum

Summary: this prevent generating beta enum with `-Dmono-beta=false`.

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=false

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10245

4 years agoevas_event: fix proxy event is not passed through 58/214958/1
Hosang Kim [Mon, 8 Jul 2019 11:53:28 +0000 (20:53 +0900)]
evas_event: fix proxy event is not passed through

Change-Id: I1e56af96688a9f9f05b703f21d8f8353174cfbce
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
4 years agobuild: resolve build error during migration accepted/tizen/unified/20191001.062520 submit/tizen/20190929.220413 submit/tizen/20190930.064714
Jongmin Lee [Sun, 29 Sep 2019 21:49:05 +0000 (06:49 +0900)]
build: resolve build error during migration

Change-Id: I9b5d04334b51653fa691ee6f8733484d79c46b66

4 years agoPyolian: implemented eolian Error object
Dave Andreoli [Sun, 29 Sep 2019 09:29:38 +0000 (11:29 +0200)]
Pyolian: implemented eolian Error object

4 years agoPyolian: reformat code to make pycharm happy
Dave Andreoli [Sun, 29 Sep 2019 08:19:11 +0000 (10:19 +0200)]
Pyolian: reformat code to make pycharm happy

and fix some typos in the code

4 years agoelm_*: make scrolling correct again
Marcel Hollerbach [Sat, 28 Sep 2019 16:02:56 +0000 (18:02 +0200)]
elm_*: make scrolling correct again

in revision D9859 the scroll events have been renamed. However this also
renamed the legacy widgets, which also renamed the evas smart events,
which is a bug. With this commit we are back to plain old
evas_smart_callback_call calls, as these just take the string, and do
not need the bypassing through the eo events.

This fixes:
- elm_test gengrid,toolbar,panel (the events are now shown correctly
again)
- scrolling in elm_code_widget
- elm_map in a touchscreen

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10240

4 years agoelm_test: undef logging macros before redefining them in header
Mike Blumenkrantz [Fri, 27 Sep 2019 18:34:32 +0000 (14:34 -0400)]
elm_test: undef logging macros before redefining them in header

Summary: Depends on D10228

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10229

4 years agoefl_ui_suite: Some pointers were being delete.
Bruno da Silva Belo [Fri, 27 Sep 2019 15:07:37 +0000 (15:07 +0000)]
efl_ui_suite: Some pointers were being delete.

`efl_ui_smart_transition_lifetime` test causes segfault
when compile with `clang`.
Fixes half of T8277

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10221

4 years agothemes: Rename "dragable" to "draggable"
Xavi Artigas [Fri, 27 Sep 2019 12:42:27 +0000 (08:42 -0400)]
themes: Rename "dragable" to "draggable"

Summary:
"Dragable" is a misspelling:
https://en.wiktionary.org/wiki/dragable

We have it EVERYWHERE in EFL, even with jokes:
./src/lib/efl/interfaces/efl_ui_drag.eo:1

This patch only fixes the theme API so it does not get carved in stone for this release.

Depends on D10217

Test Plan: No functional changes.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10218

4 years agotheme: replace hbar and vbar to horizontal_bar and vertical_bar
Jaehyun Cho [Fri, 27 Sep 2019 12:40:35 +0000 (08:40 -0400)]
theme: replace hbar and vbar to horizontal_bar and vertical_bar

Summary:
To make clear the meaning, hbar and vbar are replaced to horizontal_bar
and vertical_bar.

Reviewers: zmike, woohyun, segfaultxavi

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10217

4 years agoevas filter: Implement grayscale filter in pure GL
Shinwoo Kim [Fri, 27 Sep 2019 06:30:36 +0000 (15:30 +0900)]
evas filter: Implement grayscale filter in pure GL

Summary:
Initial version implementing grayscale filter in pure GL.
This patch needs a logt of love as 5bce712 did.

Grasyscale formula:
https://www.tutorialspoint.com/dip/grayscale_to_rgb_conversion.htm

Test Plan:
1. Create filter_example with following .
efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");

2. Run.
ELM_ACCEL=gl ./filter_example

Reviewers: Hermet, jsuya

Subscribers: ali.alzyod, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9858

4 years agoevas: fix memory leak with Efl.Canvas.Vg
Cedric Bail [Fri, 27 Sep 2019 05:19:38 +0000 (14:19 +0900)]
evas: fix memory leak with Efl.Canvas.Vg

Summary:
It is not correct to change the parent and hope that refcount will work
for you. The parent chain is a decision made by the user, not something
a widget can touch. Only ref count are to be used when given an outside
object. As things where not triggering destruction, there was also no
point where the image buffer would be getting to zero and be freed. This
commit also fix this.

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10169

4 years agotheme: remove efl.track.slider and efl.track2.slider from efl_ui_slider
Jaehyun Cho [Fri, 27 Sep 2019 03:21:48 +0000 (23:21 -0400)]
theme: remove efl.track.slider and efl.track2.slider from efl_ui_slider

Summary:
efl_ui_slider does not support popup which shows the current value.
Therefore, efl.track.slider and efl.track2.slider swallows which set the
popup size and position are not required in efl_ui_slider.

Reviewers: zmike, woohyun

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10216

4 years agoevas/object; fix null deref
Mike Blumenkrantz [Thu, 26 Sep 2019 22:00:05 +0000 (18:00 -0400)]
evas/object; fix null deref

Summary:
_efl_canvas_object_clipper_prev_reset() derefs obj->cur

CID 1396985
Depends on D10211

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10212

4 years agoeio/dir: fix null deref
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:59 +0000 (17:59 -0400)]
eio/dir: fix null deref

Summary:
above cases may fail, causing target to be null

CID 1399103
Depends on D10210

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10211

4 years agoefl_ui/image fix null derefs
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:54 +0000 (17:59 -0400)]
efl_ui/image fix null derefs

Summary:
CID 1405781, 1405780
Depends on D10209

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10210

4 years agoefl_ui/scroll_manager: fix null derefs
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:49 +0000 (17:59 -0400)]
efl_ui/scroll_manager: fix null derefs

Summary:
CID 1405811, 1405804
Depends on D10208

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10209

4 years agoefl_ui/table: handle case where table has no items
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:43 +0000 (17:59 -0400)]
efl_ui/table: handle case where table has no items

Summary:
CID 1399086
Depends on D10207

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10208

4 years agoecore_evas/convert: fix div by zero
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:38 +0000 (17:59 -0400)]
ecore_evas/convert: fix div by zero

Summary:
if one is 0, the printf line will divide by it

CID 1403900
Depends on D10206

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10207

4 years agotests/eina: outdent code
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:34 +0000 (17:59 -0400)]
tests/eina: outdent code

Summary:
this is a very important coverity issue.

CID 1400838
Depends on D10205

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10206

4 years agoeina/list: move dead code inside corresponding #ifdef
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:29 +0000 (17:59 -0400)]
eina/list: move dead code inside corresponding #ifdef

Summary:
this is debug code

CID 1404753, 1404745
Depends on D10204

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10205

4 years agotests/strbuf: call va_end for varargs
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:24 +0000 (17:59 -0400)]
tests/strbuf: call va_end for varargs

Summary: CID 1400792

Reviewers: brunobelo

Reviewed By: brunobelo

Subscribers: brunobelo, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10204

4 years agoepp: remove extra variable passed in format specifier
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:19 +0000 (17:59 -0400)]
epp: remove extra variable passed in format specifier

Summary: CID 1402674

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10203

4 years agoeolian_cxx: Possible infinite loop, if called.
Bruno da Silva Belo [Thu, 26 Sep 2019 21:48:20 +0000 (18:48 -0300)]
eolian_cxx: Possible infinite loop, if called.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10200

4 years agoefl_ui/item_clickable: mark beta again
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again

Summary:
this isn't strictly necessary at the moment

Depends on D10197

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10199

4 years agotheme: add spec documentation for all stabilized theme groups in 1.23
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23

Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing

ref T8231
Depends on D10196

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10197

Change-Id: I79bb8f1ad664172b1dd136cfc071f20a66a7467e

4 years agotheme: remove efl_ui_slider "disabled" styles
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles

Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10196

Change-Id: Icf3a44ea37afef6804108971c4a117cd08324cba

4 years agotests/check: add port of check widget mouse testing for efl_ui_check
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check

Summary:
coverage++
Depends on D10194

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10195

Change-Id: Iac8dddaa348cc08a6cee94090be35b4bc98d91f3

4 years agoefl_ui/layout: improve error message when theme version parsing fails
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails

Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10194

Change-Id: I21f9bb740ff0316866fd5e0060ef8ed287fa2c97

4 years agoefl_ui/layout: fix shadow warning
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning

Summary:
a variable with the same name is declared above
Depends on D10192

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10193

Change-Id: I8d39246bf4276ce4a6880f214b36bae422f7d7f7

4 years agoefl_ui/layout: use better check for determining whether to defer signals
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals

Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10192

Change-Id: Ida519eed1ac99c8ecc7f07e1ba0ce7583d6110d9

4 years agoeolian: better error message for const on strings
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings

4 years agoecore-x: protect against accidentally "un-managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window

Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10014

Change-Id: Ic69aa45cdbf6a9cd125edc32f98b28616af8e709

4 years agoecore-x: add internal function for selecting just properties of root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window

Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10013

Change-Id: I8d88315a36d8b74e6839d9648f6581a3c3a65875

4 years agoecore-x: track whether ecore-x is internally "managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window

Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing

Depends on D9899

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10012

Change-Id: Iedae76203dc28ad3e496eeaf300513ae423552d6

4 years agoecore-evas/x: detect and track wm existence, apply visibility correctly
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly

Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed

fix T7838

Depends on D10014

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7838

Differential Revision: https://phab.enlightenment.org/D9900

Change-Id: Ife7e3217461e06ef5f711d5ee57cf8587c56c137

4 years agoecore-x: fix null derefs in window prop code
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code

Summary:
handle cases where null params could be passed and cause crashes

@fix

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9899

Change-Id: I784f393ee7f93fb5b1c914dfb5d79f23a6999847

4 years agoefl_mono: remove spurious const
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const

Change-Id: I9a0442d0d9c8c3e0c801b8f8e2baa38052b528e9

4 years agoefl_core : stabilized Efl.Generic_Model
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model

Summary:
stabilzed Efl.Generic_Model

depends on D10188

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10189

Change-Id: I34e7eece539fea71057d1d6e77fffeadddb3cb03

4 years agoefl_ui : stablized Efl.Ui.View
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View

Summary:
Efl.Ui.View is base infrastructure interface of MVVM.

fixes T7578

Reviewers: zmike, cedric, segfaultxavi, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7578

Differential Revision: https://phab.enlightenment.org/D10188

Change-Id: Iccf2d4faf276d0e454eaf6e95b8335c5f4a3ed5c

4 years agoeolian: rename param direction enum and fields for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency

Change-Id: I7f3e09d39d32b8dcb3c35ba1085756acb6b90b54

4 years agoeolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)

4 years agoeolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency

4 years agoeolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section

Change-Id: I71ea138db0959c178c5d496fcdb4a93bbeaceba8

4 years agoefl_ui/item_clickable: fix event info for press events
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events

this is just a button and not the full clickable struct

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198

4 years agoeolian: stricter checks for const() validity
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity

4 years agoefl_ui_image: fix a wrong return value of legacy API
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API

Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10186

Change-Id: I036c10c301d223b4cd1cec0c5ae415f5ad2f9ed3

4 years agoedje_legacy: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value

Summary:
When invalid object comes, the return value should be
EINA_FALSE.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10185

Change-Id: Ib2f71f30594bbf02434c6ee4accceb091a65c90d

4 years agoefl_ui_win: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value

Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10187

Change-Id: Ia7e1f46f9f089afc237557ca64ab857317a20253

4 years agoefl: mark selectable stable
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable

Summary:
fixes T7871
fixes T7852

This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.

Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: SanghyeonLee, cedric

Tags: #efl

Maniphest Tasks: T7871, T7852

Differential Revision: https://phab.enlightenment.org/D10184

Change-Id: I734b272411e3fc9ebb79d907f171528849219c10

4 years agoatspi: add stop reading command 40/213540/3
Radoslaw Cybulski [Fri, 6 Sep 2019 09:54:20 +0000 (11:54 +0200)]
atspi: add stop reading command

Adds stop reading command over dbus, which cancels all quened readings
(including one in progress if any). Additional passed argument, boolean
flag, when set to false limits cancelling only to discardable readings.

Change-Id: I1ff8571edbaf0513da9d710c9eea16846aba62d4

4 years agoevas_events: fix usage of last mouse 05/214705/2
Hosang Kim [Wed, 25 Sep 2019 09:33:00 +0000 (18:33 +0900)]
evas_events: fix usage of last mouse

Change-Id: Ifa21646cf43f969c347ca7fe4127309f2920ddf4

4 years agobuild: resolve migration build errors submit/tizen/20190926.223052
Jongmin Lee [Thu, 26 Sep 2019 21:57:18 +0000 (06:57 +0900)]
build: resolve migration build errors

Change-Id: I588c4a50424c77b980136c89b31a25d28c452c68

4 years agoefl_ui/item_clickable: mark beta again
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again

Summary:
this isn't strictly necessary at the moment

Depends on D10197

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10199

4 years agotheme: add spec documentation for all stabilized theme groups in 1.23
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23

Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing

ref T8231
Depends on D10196

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10197

4 years agotheme: remove efl_ui_slider "disabled" styles
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles

Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10196

4 years agotests/check: add port of check widget mouse testing for efl_ui_check
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check

Summary:
coverage++
Depends on D10194

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10195

4 years agoefl_ui/layout: improve error message when theme version parsing fails
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails

Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10194

4 years agoefl_ui/layout: fix shadow warning
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning

Summary:
a variable with the same name is declared above
Depends on D10192

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10193

4 years agoefl_ui/layout: use better check for determining whether to defer signals
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals

Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10192

4 years agoeolian: better error message for const on strings
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings

4 years agoecore-x: protect against accidentally "un-managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window

Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10014

4 years agoecore-x: add internal function for selecting just properties of root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window

Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10013

4 years agoecore-x: track whether ecore-x is internally "managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window

Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing

Depends on D9899

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10012

4 years agoecore-evas/x: detect and track wm existence, apply visibility correctly
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly

Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed

fix T7838

Depends on D10014

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7838

Differential Revision: https://phab.enlightenment.org/D9900

4 years agoecore-x: fix null derefs in window prop code
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code

Summary:
handle cases where null params could be passed and cause crashes

@fix

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9899

4 years agoefl_mono: remove spurious const
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const

4 years agoefl_core : stabilized Efl.Generic_Model
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model

Summary:
stabilzed Efl.Generic_Model

depends on D10188

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10189

4 years agoefl_ui : stablized Efl.Ui.View
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View

Summary:
Efl.Ui.View is base infrastructure interface of MVVM.

fixes T7578

Reviewers: zmike, cedric, segfaultxavi, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7578

Differential Revision: https://phab.enlightenment.org/D10188

4 years agoeolian: rename param direction enum and fields for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency

4 years agoeolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)

4 years agoeolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency

4 years agoeolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section

4 years agoefl_ui/item_clickable: fix event info for press events
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events

this is just a button and not the full clickable struct

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198

4 years agoeolian: stricter checks for const() validity
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity

4 years agoefl_ui_image: fix a wrong return value of legacy API
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API

Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10186

Change-Id: If8039795398b3681c7329d8103d196d02393612b

4 years agoedje_legacy: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value

Summary:
When invalid object comes, the return value should be
EINA_FALSE.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10185

Change-Id: I3b2434528d68e8570308b25049442d07f4174a86

4 years agoefl_ui_win: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value

Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10187

Change-Id: I27ae9dcc4030b26ffc124f11a66c4fc7bf1436e9

4 years agoefl: mark selectable stable
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable

Summary:
fixes T7871
fixes T7852

This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.

Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: SanghyeonLee, cedric

Tags: #efl

Maniphest Tasks: T7871, T7852

Differential Revision: https://phab.enlightenment.org/D10184

4 years agoefl_ui_*selectable: unify these APIs with the same c_prefix
Marcel Hollerbach [Thu, 26 Sep 2019 09:16:24 +0000 (18:16 +0900)]
efl_ui_*selectable: unify these APIs with the same c_prefix

Summary:
with this commit that api for single and multi selectable shares the
same prefix, which makes sense in c as we do not really differ between
those two types there anyway.

ref T7871

Reviewers: SanghyeonLee, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7871

Differential Revision: https://phab.enlightenment.org/D10183

4 years agoefl_ui : add document comment on efl_ui_item_clickable event data
SangHyeon Jade Lee [Thu, 26 Sep 2019 08:38:37 +0000 (10:38 +0200)]
efl_ui : add document comment on efl_ui_item_clickable event data

Summary: Add document comment on Efl_Ui_Item_Clickable.Clickable_Clicked.

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10181

4 years agoelementary: stabilize Efl.Ui.Item_Clickable.
Cedric Bail [Thu, 26 Sep 2019 01:59:29 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Item_Clickable.

Summary: Depends on D10177

Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10173

4 years agoelementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Cedric Bail [Thu, 26 Sep 2019 01:59:25 +0000 (21:59 -0400)]
elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.

Summary: Depends on D10176

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10177

4 years agoelementary: temporary workaround include issue that prevent acces to Evas_Eo.h
Cedric Bail [Thu, 26 Sep 2019 01:59:20 +0000 (21:59 -0400)]
elementary: temporary workaround include issue that prevent acces to Evas_Eo.h

Summary: Depends on D10175

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10176

4 years agoelementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Cedric Bail [Thu, 26 Sep 2019 01:59:14 +0000 (21:59 -0400)]
elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable

Summary: Depends on D10171

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10175

4 years agoelementary: stabilize Efl.Ui.Collection_View.
Cedric Bail [Thu, 26 Sep 2019 01:59:09 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Collection_View.

Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8261

Differential Revision: https://phab.enlightenment.org/D10171

4 years agoapi: mark Efl.Ui.Image_Zoomable stable
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:38 +0000 (17:56 -0400)]
api: mark Efl.Ui.Image_Zoomable stable

Summary:
ref T7875
Depends on D10125

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D10126

4 years agoapi: mark Efl.Gfx.Image_Load_Controller stable
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:33 +0000 (17:56 -0400)]
api: mark Efl.Gfx.Image_Load_Controller stable

Summary:
fix T7876
Depends on D10124

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7876

Differential Revision: https://phab.enlightenment.org/D10125

4 years agoapi: mark efl.gfx.image and related types stable
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:29 +0000 (17:56 -0400)]
api: mark efl.gfx.image and related types stable

Summary:
fix T7875
fix T7926
fix T7927
fix T7926
fix T7929

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7929, T7927, T7926, T7875

Differential Revision: https://phab.enlightenment.org/D10124

4 years agotheme: migrate all efl,anim,activate (and similar) signals to efl,state,animation...
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:17 +0000 (17:56 -0400)]
theme: migrate all efl,anim,activate (and similar) signals to efl,state,animation,activated

Summary:
ref T8231
Depends on D10166

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10167