Denis Kenzior [Thu, 2 Jun 2011 20:55:26 +0000 (15:55 -0500)]
sim: Make sure only PINs can be sent to EnterPin
Denis Kenzior [Thu, 2 Jun 2011 07:35:39 +0000 (02:35 -0500)]
gprs: Unify logic inside registration_status_cb
And delay reseting the ATTACHING flag until we had a chance to query the
CGREG status.
Marcel Holtmann [Fri, 3 Jun 2011 06:49:03 +0000 (08:49 +0200)]
tools: Use mobile-broadband-provider-info database location if present
Marcel Holtmann [Fri, 3 Jun 2011 06:48:49 +0000 (08:48 +0200)]
build: Check for mobile-broadband-provider-info database
Denis Kenzior [Thu, 2 Jun 2011 02:50:02 +0000 (21:50 -0500)]
emulator: Don't try to release in case of error
Frédéric Danis [Wed, 1 Jun 2011 11:24:22 +0000 (13:24 +0200)]
voicecall: save last dialed number
Frédéric Danis [Wed, 1 Jun 2011 11:24:20 +0000 (13:24 +0200)]
voicecall: create generic dial function
split manager_dial between generic and dbus parts
Denis Kenzior [Wed, 1 Jun 2011 04:31:41 +0000 (23:31 -0500)]
stk: Cancel pending DTMF tones if session is ended
The Send DTMF command is special in its use of DisplayAction method of
STK agent. This allows the user to send a 'User Terminated Session'
response to the SIM. If the user performs this action, then any pending
DTMFs should also be canceled as soon as possible.
Philippe Nunes [Fri, 20 May 2011 16:26:14 +0000 (18:26 +0200)]
stk: simplify respond_on_exit flag handling
respond_on_exit flag is set by commands which are dispatched to the
agent, so that if the agent exits prematurely, a 'User Terminated
Session' response is sent to the SIM.
There were a couple of corner cases not quite handled correctly:
- During Set Up Call, if the user confirmation phase succeeded and the
call was dispatched to voicecall atom successfully, and the agent
exited at this point, then no terminal response would be sent until
the call succeeded / failed. Now the agent termination results in an
'User Terminated Session' response being sent immediately, but the
call setup proceeding.
Nicolas Bertrand [Tue, 31 May 2011 16:21:25 +0000 (18:21 +0200)]
TODO: set owner of call forwarding state handling
Denis Kenzior [Tue, 31 May 2011 16:41:42 +0000 (11:41 -0500)]
bluetooth: Initialize GError properly
Denis Kenzior [Tue, 31 May 2011 16:32:56 +0000 (11:32 -0500)]
netreg: Remove unused variable
Marcel Holtmann [Sun, 29 May 2011 18:55:48 +0000 (11:55 -0700)]
smsutil: Mark variable properly as unused
Marcel Holtmann [Sun, 29 May 2011 00:44:22 +0000 (17:44 -0700)]
Release 0.49
Denis Kenzior [Wed, 25 May 2011 15:01:16 +0000 (10:01 -0500)]
emulator: Fix make distcheck
Marcel Holtmann [Fri, 27 May 2011 17:21:16 +0000 (10:21 -0700)]
btio: Add workaround for not defined BT_FLUSHABLE
Johan Hedberg [Sat, 14 May 2011 22:55:16 +0000 (01:55 +0300)]
btio: Fix unused variable warning
Anderson Briglia [Thu, 5 May 2011 18:55:24 +0000 (14:55 -0400)]
btio: Fix compilation warning
This patch fixes a compilation warning regarding btio/btio.c. Actually
this warning seems a false positive by Ubuntu Natty GCC version. A new
bug on Ubuntu bug system was opened but if you do not want to wait until
it is analyzed, just apply this minor fix.
btio/btio.c: In function 'bt_io_get':
btio/btio.c:803:11: warning: 'flushable' may be used uninitialized in
this function
Johan Hedberg [Thu, 21 Apr 2011 07:15:04 +0000 (10:15 +0300)]
btio: Add BT_FLUSHABLE support to BtIO
This patch adds support for the BT_FLUSHABLE L2CAP socket option through
BtIO. This can be used to mark data from specific L2CAP sockets to have
the flushable flag set in their corresponding ACL packets.
Luiz Augusto von Dentz [Thu, 24 Mar 2011 12:09:52 +0000 (14:09 +0200)]
btio: Fix error message when getting SCO connection handle
Error message should indicate the transport correctly which is SCO
not RFCOMM.
Marcel Holtmann [Fri, 27 May 2011 17:10:04 +0000 (10:10 -0700)]
bluetooth: Remove usage of unused variable
Marcel Holtmann [Fri, 27 May 2011 17:08:59 +0000 (10:08 -0700)]
sierra: Remove usage of unused gprs variable
Marcel Holtmann [Fri, 27 May 2011 17:08:16 +0000 (10:08 -0700)]
huawei: Remove usage of unused netreg variable
Marcel Holtmann [Fri, 27 May 2011 17:06:10 +0000 (10:06 -0700)]
gisi: Remove unused code for PN netlink address handling
Marcel Holtmann [Fri, 27 May 2011 17:01:30 +0000 (10:01 -0700)]
tools: Fix missing handling of signalfd read results
Marcel Holtmann [Fri, 27 May 2011 17:00:08 +0000 (10:00 -0700)]
tools: Fix unused variable for Huawei audio settings
Szymon Janc [Tue, 10 May 2011 13:58:04 +0000 (15:58 +0200)]
gdbus: Remove unused result variable from g_dbus_pending_success
Marcel Holtmann [Fri, 27 May 2011 16:52:31 +0000 (09:52 -0700)]
gatchat: Fix unused variable cases
Marcel Holtmann [Fri, 27 May 2011 16:48:45 +0000 (09:48 -0700)]
smsutil: Fix missing error handling for strtol function
Denis Kenzior [Wed, 25 May 2011 10:32:05 +0000 (05:32 -0500)]
gsmdial: Send escape sequence followed by ATH/ATO
This functionality can be triggered by sending SIGUSR1 / SIGUSR2 to
gsmdial. e.g. kill -10 <pid> and kill -12 <pid>
Denis Kenzior [Wed, 25 May 2011 10:30:38 +0000 (05:30 -0500)]
ppp_net: Keep valgrind happy
Denis Kenzior [Wed, 25 May 2011 10:30:17 +0000 (05:30 -0500)]
gathdlc: Fix memory leak
Denis Kenzior [Wed, 25 May 2011 10:22:58 +0000 (05:22 -0500)]
gatppp: Set the suspend function in open / listen
In case it was set before calling these functions
Denis Kenzior [Wed, 25 May 2011 09:54:41 +0000 (04:54 -0500)]
emulator: Reflow ato implementation logic
Guillaume Zajac [Fri, 20 May 2011 09:38:15 +0000 (11:38 +0200)]
emulator: add ATO implementation
Denis Kenzior [Tue, 24 May 2011 18:45:36 +0000 (13:45 -0500)]
emulator: Make sure to cleanup on forceful exit
Denis Kenzior [Tue, 24 May 2011 18:45:26 +0000 (13:45 -0500)]
emulator: simplify ath callback
Denis Kenzior [Tue, 24 May 2011 18:20:31 +0000 (13:20 -0500)]
examples: Add a simple private-network driver
Denis Kenzior [Tue, 24 May 2011 18:20:04 +0000 (13:20 -0500)]
include: Declare typedef as a function pointer
Denis Kenzior [Sun, 22 May 2011 13:10:09 +0000 (08:10 -0500)]
emulator: Update to the new GAtPPP API
Denis Kenzior [Tue, 24 May 2011 16:13:05 +0000 (11:13 -0500)]
test-server: Update to the new GAtPPP API
Denis Kenzior [Tue, 24 May 2011 16:12:38 +0000 (11:12 -0500)]
cdmamodem: Update to the new GAtPPP API
Denis Kenzior [Tue, 24 May 2011 16:12:13 +0000 (11:12 -0500)]
atmodem: Update to new GAtPPP api
Denis Kenzior [Tue, 24 May 2011 16:11:59 +0000 (11:11 -0500)]
gsmdial: Update to new API
Denis Kenzior [Tue, 24 May 2011 13:08:34 +0000 (08:08 -0500)]
gatppp: Refactor PPP API
Remove the series of constructors which take a GIOChannel directly.
These weren't used.
This change also allows the construction of the PPP object and filling
in various pertinent information without starting the HDLC processing.
The client must now use g_at_ppp_open() for the client side or
g_at_ppp_listen() for the server side to start the true PPP session.
The previous owner of the GAtIO object must be suspended beforehand.
Denis Kenzior [Sun, 22 May 2011 13:34:21 +0000 (08:34 -0500)]
gatppp: Make sure to clean up guard_timeout_source
Denis Kenzior [Sun, 22 May 2011 13:34:08 +0000 (08:34 -0500)]
gatppp: Rename guard_timeout_src to _source
Guillaume Zajac [Fri, 20 May 2011 09:38:14 +0000 (11:38 +0200)]
gatppp: Do not call disconnect func if suspended
Guillaume Zajac [Fri, 20 May 2011 09:38:14 +0000 (11:38 +0200)]
gatppp: Add GAtPPP suspend API
Guillaume Zajac [Fri, 20 May 2011 09:38:14 +0000 (11:38 +0200)]
gatppp: Add GAtPPP resume functionality
Guillaume Zajac [Fri, 20 May 2011 09:38:13 +0000 (11:38 +0200)]
ppp_net: add ppp_net_resume_interface() API
Denis Kenzior [Sun, 22 May 2011 13:17:20 +0000 (08:17 -0500)]
gathdlc: Squash unneeded function
Guillaume Zajac [Fri, 20 May 2011 09:38:12 +0000 (11:38 +0200)]
gathdlc: add g_at_hdlc_resume() API
Denis Kenzior [Sun, 22 May 2011 13:01:44 +0000 (08:01 -0500)]
emulator: Send a NO CARRIER where appropriate
Denis Kenzior [Tue, 24 May 2011 13:16:12 +0000 (08:16 -0500)]
emulator: Get rid of return at the end of func
Denis Kenzior [Sun, 22 May 2011 12:47:56 +0000 (07:47 -0500)]
emulator: optimize request_private_network_cb flow
Guillaume Zajac [Thu, 19 May 2011 09:58:31 +0000 (11:58 +0200)]
emulator: add request/release private network calls
Guillaume Zajac [Thu, 19 May 2011 09:58:30 +0000 (11:58 +0200)]
private-network: add initial implementation
Guillaume Zajac [Thu, 19 May 2011 09:58:29 +0000 (11:58 +0200)]
private-network: add header into include and Makefile.am
Denis Kenzior [Sun, 22 May 2011 11:43:03 +0000 (06:43 -0500)]
gatppp: Make ppp->fd handling a bit easier to grok
Denis Kenzior [Sun, 22 May 2011 11:35:01 +0000 (06:35 -0500)]
ppp_net: streamline ppp_net_new logic
Denis Kenzior [Tue, 24 May 2011 04:00:06 +0000 (23:00 -0500)]
gatppp: Ensure created GAtPPP object is not null
Guillaume Zajac [Thu, 19 May 2011 09:58:28 +0000 (11:58 +0200)]
gatppp: Add new contructor to use external fd
Denis Kenzior [Tue, 24 May 2011 17:00:51 +0000 (12:00 -0500)]
gitignore: Add unit/test-cdmasms
Lei Yu [Tue, 18 Jan 2011 22:54:22 +0000 (14:54 -0800)]
test: Add CDMA SMS Support
Lei Yu [Tue, 18 Jan 2011 22:54:20 +0000 (14:54 -0800)]
cdma-sms: Add CDMA SMS Support
Lei Yu [Tue, 18 Jan 2011 22:54:19 +0000 (14:54 -0800)]
cdma-sms: Add CDMA SMS Support
Frédéric Dalleau [Tue, 24 May 2011 07:56:05 +0000 (09:56 +0200)]
TODO: Lower priority and remove owner of CE4A task
Frédéric Dalleau [Tue, 24 May 2011 07:56:04 +0000 (09:56 +0200)]
TODO: Remove owner of HSP task
Frédéric Dalleau [Tue, 24 May 2011 07:56:57 +0000 (09:56 +0200)]
voicecall: remove unnecessary local var
Denis Kenzior [Tue, 24 May 2011 12:58:30 +0000 (07:58 -0500)]
gatppp: Don't go over 80 characters / line
Denis Kenzior [Tue, 24 May 2011 12:49:41 +0000 (07:49 -0500)]
test-server: Remove legacy code
The previous thinking was to use the PPP stack to send Conf-Naks with
some delay to client requests until the IP configuration was setup
correctly. However, we now hide this by using the delay during the
processing of the ATD. This code is no longer relevant.
Denis Kenzior [Tue, 24 May 2011 16:38:33 +0000 (11:38 -0500)]
gitignore: Add lookup-apn
Caiwen Zhang [Thu, 26 May 2011 01:53:23 +0000 (09:53 +0800)]
udev: add rule for Option GTM661W modem
Frédéric Dalleau [Fri, 20 May 2011 09:33:25 +0000 (11:33 +0200)]
voicecall: add +VTS support for HFP emulator
Frédéric Danis [Fri, 20 May 2011 09:47:18 +0000 (11:47 +0200)]
doc: add hfp-overview.txt
Gustavo F. Padovan [Fri, 20 May 2011 19:03:43 +0000 (16:03 -0300)]
gobi: remove set but not used var
Gustavo F. Padovan [Fri, 20 May 2011 19:03:42 +0000 (16:03 -0300)]
udev: remove set but not used var
Gustavo F. Padovan [Fri, 20 May 2011 19:03:41 +0000 (16:03 -0300)]
simutil: remove set but not used var
Gustavo F. Padovan [Fri, 20 May 2011 19:03:40 +0000 (16:03 -0300)]
gprs: remove set but not used var
Gustavo F. Padovan [Fri, 20 May 2011 19:03:39 +0000 (16:03 -0300)]
sms: remove set but not used var
Marcel Holtmann [Fri, 20 May 2011 00:20:15 +0000 (17:20 -0700)]
tools: Add utility for looking up APN from database
Frédéric Dalleau [Tue, 17 May 2011 14:32:39 +0000 (16:32 +0200)]
voicecall: fix CHLD support reply
Caiwen Zhang [Wed, 11 May 2011 09:19:27 +0000 (17:19 +0800)]
gatppp: add name field when using chap auth
Some systems require name field, otherwise chap authentication will
fail.
Denis Kenzior [Wed, 11 May 2011 18:24:04 +0000 (13:24 -0500)]
gprs: Make sure to clean up interfaces
When going down, it is sometimes possible for us not to ifconfig down
the interface or reset the MMS context IPv4 address propertly
Bertrand Aygon [Wed, 11 May 2011 15:27:43 +0000 (17:27 +0200)]
nokia-gpio: Fix memory leak
All dir opened with opendir must be closed with closedir
Bertrand Aygon [Wed, 11 May 2011 15:27:43 +0000 (17:27 +0200)]
nokia-gpio: Fix minor style issue
Denis Kenzior [Wed, 11 May 2011 17:30:36 +0000 (12:30 -0500)]
AUTHORS: Mention Caiwen's contributions
Caiwen Zhang [Wed, 11 May 2011 08:15:19 +0000 (16:15 +0800)]
gatppp: fix ppp protocol-reject constructing error
In PPP Protocol-Reject package the 'rejected data field' should be a copy
of the rejected package, the copy starts from the data field. besides,
Protocol-Reject package include a 'rejected protocol field', it is the
same as the protocol field of the rejected package.
Protocol-Reject package structure is:
| PPP_header | rejected protocol | rejected data
The rejected package structure is:
| Addr | Control | protocol | data
So the Protocol-Reject package data field is copied from the 3rd byte of
the rejected package.
Denis Kenzior [Wed, 11 May 2011 17:29:12 +0000 (12:29 -0500)]
simfs: Fix error reported by valgrind
==20365== Invalid read of size 8
==20365== at 0x4B3501: sim_fs_free (simfs.c:114)
==20365== by 0x493CEC: sim_remove (sim.c:2485)
==20365== by 0x4703D7: modem_change_state (modem.c:410)
==20365== by 0x470664: set_powered (modem.c:848)
==20365== by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20365== by 0x46F2C5: signal_cb (main.c:76)
==20365== by 0x52F555E: g_io_unix_dispatch (giounix.c:166)
==20365== by 0x52A0AAB: g_main_dispatch (gmain.c:2440)
==20365== by 0x52A203B: g_main_context_dispatch (gmain.c:3013)
==20365== by 0x52A2501: g_main_context_iterate (gmain.c:3091)
==20365== by 0x52A2C98: g_main_loop_run (gmain.c:3299)
==20365== by 0x46F0D3: main (main.c:243)
==20365== Address 0x63ff998 is 8 bytes inside a block of size 16 free'd
==20365== at 0x4C2612D: free (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20365== by 0x52AA4A1: g_free (gmem.c:263)
==20365== by 0x52C433D: g_slice_free1 (gslice.c:907)
==20365== by 0x52C58D0: g_slist_free_1 (gslist.c:192)
==20365== by 0x52C5C5F: g_slist_remove (gslist.c:465)
==20365== by 0x4B342A: sim_fs_context_free (simfs.c:192)
==20365== by 0x4B3500: sim_fs_free (simfs.c:117)
==20365== by 0x493CEC: sim_remove (sim.c:2485)
==20365== by 0x4703D7: modem_change_state (modem.c:410)
==20365== by 0x470664: set_powered (modem.c:848)
==20365== by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20365== by 0x46F2C5: signal_cb (main.c:76)
Denis Kenzior [Wed, 11 May 2011 17:20:59 +0000 (12:20 -0500)]
simfs: Fix issue reported by valgrind
==20287== Invalid read of size 4
==20287== at 0x52B5C6B: g_queue_peek_nth_link (gqueue.c:704)
==20287== by 0x52B5F57: g_queue_peek_nth (gqueue.c:848)
==20287== by 0x4B33ED: sim_fs_context_free (simfs.c:170)
==20287== by 0x4B34F8: sim_fs_free (simfs.c:116)
==20287== by 0x493CEC: sim_remove (sim.c:2485)
==20287== by 0x4703D7: modem_change_state (modem.c:410)
==20287== by 0x470664: set_powered (modem.c:848)
==20287== by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20287== by 0x46F2C5: signal_cb (main.c:76)
==20287== by 0x52F555E: g_io_unix_dispatch (giounix.c:166)
==20287== by 0x52A0AAB: g_main_dispatch (gmain.c:2440)
==20287== by 0x52A203B: g_main_context_dispatch (gmain.c:3013)
==20287== Address 0x63fae70 is 16 bytes inside a block of size 24
free'd
==20287== at 0x4C2612D: free (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20287== by 0x52AA4A1: g_free (gmem.c:263)
==20287== by 0x52C433D: g_slice_free1 (gslice.c:907)
==20287== by 0x52B4E96: g_queue_free (gqueue.c:60)
==20287== by 0x4B34E0: sim_fs_free (simfs.c:107)
==20287== by 0x493CEC: sim_remove (sim.c:2485)
==20287== by 0x4703D7: modem_change_state (modem.c:410)
==20287== by 0x470664: set_powered (modem.c:848)
==20287== by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20287== by 0x46F2C5: signal_cb (main.c:76)
==20287== by 0x52F555E: g_io_unix_dispatch (giounix.c:166)
==20287== by 0x52A0AAB: g_main_dispatch (gmain.c:2440)
Denis Kenzior [Wed, 11 May 2011 17:09:56 +0000 (12:09 -0500)]
gprs: Mark context inactive on removal
Denis Kenzior [Wed, 11 May 2011 17:07:41 +0000 (12:07 -0500)]
gprs: Fix valgrind error
This fixes an invalid access condition for the case where the
gprs atom is destroyed before context atoms are.
Denis Kenzior [Wed, 11 May 2011 02:45:28 +0000 (21:45 -0500)]
gprs: emit Active changed for contexts being removed
Denis Kenzior [Wed, 11 May 2011 02:36:37 +0000 (21:36 -0500)]
gprs: Add additional debug statements
Denis Kenzior [Wed, 11 May 2011 02:35:20 +0000 (21:35 -0500)]
phonesim: Create atoms in a different order
This uncovers a valgrind condition:
==17231== Invalid read of size 8
==17231== at 0x4A2461: gprs_context_unregister (gprs.c:2143)
==17231== by 0x46FEB0: __ofono_atom_unregister (modem.c:260)
==17231== by 0x4703C9: modem_change_state (modem.c:407)
==17231== by 0x470664: set_powered (modem.c:848)
==17231== by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
Philippe Nunes [Wed, 4 May 2011 17:07:41 +0000 (19:07 +0200)]
stkutil: Send at least the data currently available
Denis Kenzior [Mon, 9 May 2011 04:27:17 +0000 (23:27 -0500)]
sim: Fix potential use of uninitialized variable
In certain circumstances, when the image has been cached but EFimg has
not been read yet, we might end up accessing an unitialized variable.
Fix this by always failing if EFimg has not been read yet.
Frédéric Danis [Mon, 9 May 2011 15:13:06 +0000 (17:13 +0200)]
emulator: add AT+CMEE support for HFP
Guillaume Zajac [Wed, 4 May 2011 15:39:05 +0000 (17:39 +0200)]
emulator: add dun_ath_cb() and register it