Kevin Jones [Thu, 24 Mar 2022 13:07:08 +0000 (09:07 -0400)]
Update the latest node (#67060)
Eirik Tsarpalis [Thu, 24 Mar 2022 13:06:32 +0000 (13:06 +0000)]
Fix #66727. (#67041)
Trayan Zapryanov [Thu, 24 Mar 2022 12:46:37 +0000 (14:46 +0200)]
Use stackalloc in NumberFormatterBase (#67003)
Co-authored-by: Trayan Zapryanov <Traian.Zaprianov@docuware.com>
Elinor Fung [Thu, 24 Mar 2022 12:14:34 +0000 (05:14 -0700)]
Fix entry point for EnumPrinters (#67081)
Radek Zikmund [Thu, 24 Mar 2022 12:03:10 +0000 (13:03 +0100)]
Add timestamp-based expiration to cached SafeFreeCredentials (#66334)
* Add Expiry timestamp on SafeFreeCredentials handle
* Recalculate expiration timestamp based on CertificateContext
* Fix case when user provides CertificateContext
Johan Lorensson [Thu, 24 Mar 2022 07:54:35 +0000 (08:54 +0100)]
CoreCLR runtime tests on Mono Windows x64. (#64281)
Fixed and enabled CoreCLR runtime tests running on Mono Windows x64.
dotnet-maestro[bot] [Thu, 24 Mar 2022 06:45:05 +0000 (23:45 -0700)]
[main] Update dependencies from 8 repositories (#66826)
* Update dependencies from https://github.com/dotnet/arcade build
20220317.4
Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
From Version 2.5.1-beta.22166.1 -> To Version 2.5.1-beta.22167.4
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220317.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22166.1 -> To Version 7.0.0-preview1.22167.1
* Update dependencies from https://github.com/dotnet/arcade build
20220318.2
Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
From Version 2.5.1-beta.22166.1 -> To Version 2.5.1-beta.22168.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220318.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22166.1 -> To Version 7.0.0-preview1.22168.1
* Update dependencies from https://github.com/dotnet/runtime build
20220321.1
runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.ILAsm , Microsoft.NETCore.DotNetHostPolicy , System.Text.Json , Microsoft.NET.Sdk.IL
From Version 7.0.0-preview.3.22163.2 -> To Version 7.0.0-preview.3.22171.1
* Update dependencies from https://github.com/dotnet/arcade build
20220321.2
Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
From Version 2.5.1-beta.22166.1 -> To Version 2.5.1-beta.22171.2
* Update dependencies from https://github.com/dotnet/icu build
20220321.4
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-preview.3.22157.1 -> To Version 7.0.0-preview.4.22171.4
* Update dependencies from https://github.com/dotnet/runtime-assets build
20220321.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.22166.2 -> To Version 7.0.0-beta.22171.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220321.3
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-preview.3.22167.1 -> To Version 7.0.0-preview.4.22171.3
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20220321.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.0.2-alpha.0.22164.2 -> To Version 1.0.2-alpha.0.22171.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20220321.2
runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.22164.2 -> To Version 11.1.0-alpha.1.22171.2
* Update dependencies from https://github.com/dotnet/emsdk build
20220322.1
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-preview.3.22121.1 -> To Version 7.0.0-preview.4.22172.1
* Update dependencies from https://github.com/dotnet/icu build
20220322.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-preview.3.22121.1 -> To Version 7.0.0-preview.4.22172.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220322.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22166.1 -> To Version 7.0.0-preview1.22172.1
* Revert changes from Roslyn-Analyzers
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
Jesper Meyer [Thu, 24 Mar 2022 02:02:01 +0000 (03:02 +0100)]
Improve vectorization of String.Split (#64899)
Eric Erhardt [Thu, 24 Mar 2022 00:54:51 +0000 (19:54 -0500)]
Update coding-style to include target-typed new() guideline (#67061)
* Update coding-style to include target-typed new guideline
Similar to `var` usage, `new()` usage is only allowed when the Type can be understood from the same line.
Fix #53369
* Fix coding style violations
Zoltan Varga [Thu, 24 Mar 2022 00:45:31 +0000 (20:45 -0400)]
Add a --aot-lazy-assembly-load command line option to load assemblies… (#67024)
* Add a --aot-lazy-assembly-load command line option to load assemblies referenced by AOT images lazily.
Note that this requires the assemblies used at AOT time to exactly match
the assemblies loaded at runtime, otherwise the runtime will abort
when it loads the mismatching reference.
* Handle the options added by options.h in mono_jit_parse_options ().
Stephen Toub [Wed, 23 Mar 2022 22:40:09 +0000 (18:40 -0400)]
Eat cancellation exceptions from WaitAsync in Parallel.ForEachAsync (#66712)
We can safely ignore cancellation exceptions due to WaitAsync being canceled. They do not represent work that was started and interrupted, and we know exactly the source of the exception (as compared to if the exception emerged from either MoveNextAsync or the loop body).
Zoltan Varga [Wed, 23 Mar 2022 22:18:48 +0000 (18:18 -0400)]
[mono] Optimize generic sharing for generic methods. (#64129)
* [mono] Optimize generic sharing for generic methods.
Previously, rgctx entries where stored either in the class rgctx
or the method rgctx in linked structures, and accessed using
rgctx trampolines (for non-llvmonly configuration), or
inline code and fallback C code (for llvmonly configuration).
However, if a method has an mrgctx parameter, all the rgctx entries
can be stored as an array in the mrgctx and accessed using a simple
load.
One complication is that the mrgctx might need to be allocated before
the method is compiled/loaded, so the rgctx entries need to be stored
in a separate array, and the array needs to be initialized on
demand.
* Add an 'entries' field to MonoMethodRuntimeGenericContext which stores
the rgctx entries.
* Add a MonoGSharedMethodInfo structure which stores the information
needed to initialize a MonoMethodRuntimeGenericContext, i.e. the
number of rgctx entries and their contents.
* Add a MONO_PATCH_INFO_GSHARED_METHOD_INFO patch type to refer
to the previous structure.
* Add a mini_init_method_rgctx () JIT icall, which initializes
an mrgctx if needed and generate code in the prolog of gshared methods
to call it.
* [mono] Pass an mrgctx to static/valuetype gshared methods.
Previously, these methods were passed a vtable. Passing the mrgctx
instead simplifies some runtime code and allows smaller/faster access to
rgctx entries.
* Add rgctx trampolines in get_ftnptr_for_method ().
* [mono][wasm] Avoid AOTing Microsoft.CodeAnalysis.dll as well.
Maksym Koshovyi [Wed, 23 Mar 2022 22:07:07 +0000 (00:07 +0200)]
Update EventSourceLogger.cs (#67065)
Stephen Toub [Wed, 23 Mar 2022 22:02:11 +0000 (18:02 -0400)]
Remove unnecessary XmlQualifiedName allocations from XsdBuilder.ProcessElement/Attribute (#67045)
Stephen Toub [Wed, 23 Mar 2022 22:01:33 +0000 (18:01 -0400)]
Avoid bool[] allocation in MemberInfoCache.PopulateProperties (#66912)
Maksym Koshovyi [Wed, 23 Mar 2022 21:02:09 +0000 (23:02 +0200)]
[Group 4] Enable nullable annotations for `Microsoft.Extensions.Logging.EventSource` (#66802)
* Annotate src
* Annotate ref
* Make internal parameters non-nullable if they never receive null
Aaron Robinson [Wed, 23 Mar 2022 20:51:27 +0000 (16:51 -0400)]
Remove libunwind disabled warnings. (#67042)
keymoon [Wed, 23 Mar 2022 20:36:27 +0000 (05:36 +0900)]
[resubmit] BigInteger parsing optimization for large decimal string (#55121)
* implement divide-and-conquer method for parsing digits
* fix argument order in Assert when x equals to 0
* Apply format fix
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* add test for non-naive algorithm
* add description for naiveThreshold
* fix trivial part
* add check for boundary condition
* add assertions and descriptions
* change variable name
* remove inappropreate use of var
* to use ArrayPool<int>.Shared.Rent for newBuffer allocation
* move both algorithms to separate methods
* add and fix comments
* trivial fix
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Tanner Gooding [Wed, 23 Mar 2022 20:35:33 +0000 (13:35 -0700)]
Ensure that fgMorphFieldToSimdGetElement doesn't call gtNewSimdGetElementNode if the ISA is unsupported (#66853)
* Ensure that fgMorphFieldToSimdGetElement doesn't call gtNewSimdGetElementNode if the ISA is unsupported
* Ensure fgMorphFieldToSimdGetElement is correctly checking for AdvSimd support on Arm64
* Ensure impExpandHalfConstEqualsSIMD checks for baseline simd support
Maksym Koshovyi [Wed, 23 Mar 2022 18:35:24 +0000 (20:35 +0200)]
Improve nullable annotations for `ILogger.BeginScope` (#66960)
* BeginScope can return a null IDisposable. And TState is not nullable.
Jakob Botsch Nielsen [Wed, 23 Mar 2022 17:13:00 +0000 (18:13 +0100)]
Give end-marker symbols their own addresses to work around a linker bug (#66999)
It seems there is a linker bug related to control-flow guard that is
causing #66969. In eb8460f a thunktemplates.asm file was added that has
a LEAF_END_MARKED at the end of the file. This creates two symbols for
the same upcoming address. Normally that should be fine, but in this
case it causes the linker to place the same address twice in a CFG table
in the PE file. This causes the kernel to fail while loading the image.
A simple workaround would be to add a nop at the end of
thunktemplates.asm, but @janvorli suggested giving these symbols their
own address in all cases for goodness when debugging. We already do so
for Windows x64 it looks like.
Fix #66969
David Edey [Wed, 23 Mar 2022 16:38:15 +0000 (16:38 +0000)]
Improves handling of env prefixes containing __ (#65757)
Both the un-altered and colon-normalized prefixes now match
environment variables in either the __ or colon formats.
The change includes minor refactors to
the EnvironmentVariablesConfigurationProvider
to make the code easier to follow and reduce the likelihood
of future regressions.
Test naming has been made clearer, and a comprehensive test
has been added.
Fix #65756
Omair Majid [Wed, 23 Mar 2022 16:33:41 +0000 (12:33 -0400)]
Add Fedora 37 RID (#67021)
Fedora 37 has now started development, and the distribution now
identifies itself as Fedora 37 instead of Fedora 36:
https://fedorapeople.org/groups/schedule/f-37/f-37-key-tasks.html
This is a forward-port of https://github.com/dotnet/runtime/pull/65392
Jeremy Koritzinsky [Wed, 23 Mar 2022 16:06:32 +0000 (09:06 -0700)]
Add the CustomTypeMarshallerAttribute type to make it easier to identify marshaller types (#65591)
Jeremy Koritzinsky [Wed, 23 Mar 2022 16:05:54 +0000 (09:05 -0700)]
Change CoreCLR diagnostic resource production to remove cross-component build dependency (#67018)
Eric StJohn [Wed, 23 Mar 2022 15:13:36 +0000 (08:13 -0700)]
Workaround NuGet error in Content_Types (#66744)
Viktor Hofer [Wed, 23 Mar 2022 15:12:34 +0000 (16:12 +0100)]
Delete System.Runtime.Experimental leftovers (#66819)
* Delete System.Runtime.Experimental leftovers
e34e8dd85e7ffaaad8c884de0967cb8d845af5c6 merged the API surface of System.Runtime.Experimental inbox and deleted the project and the package. Hence we should delete leftovers that reference it.
* Update System.Runtime.csproj
Stephen Toub [Wed, 23 Mar 2022 15:03:21 +0000 (11:03 -0400)]
Remove delegate/closure allocations from DynamicAssemblies.IsTypeDynamic (#66797)
Vlad Brezae [Wed, 23 Mar 2022 14:46:56 +0000 (16:46 +0200)]
[mono][interp] Enable some tests (#66947)
* [mono][interp] Enable all IL_Conformance tests
* [mono][interp] Enable tests
* [mono][interp] Enable test
* [tests] Fix ckfinite test
According to spec, ckfinite can throw ArithmeticException. CoreCLR throws OverflowException while mono throws ArithmeticException. Change test to catch all ArithmeticExceptions.
Michal Strehovský [Wed, 23 Mar 2022 13:28:59 +0000 (22:28 +0900)]
Reject mismatched symbol files (#67027)
`UnmanagedPdbSymbolReader` will already perform a GUID check that rejects mismatched symbol files. Do the same for the portable symbol reader.
Egor Bogatov [Wed, 23 Mar 2022 11:54:20 +0000 (14:54 +0300)]
Better approach (#66902)
Mikel Blanchard [Wed, 23 Mar 2022 05:05:46 +0000 (22:05 -0700)]
Avoid an extra copy of T inside System.Diagnostics.Enumerator<T>. (#67012)
Omair Majid [Wed, 23 Mar 2022 03:49:50 +0000 (23:49 -0400)]
Support using the system version of brotli (#66462)
This is mainly motivated by the March 2022 release of .NET 5. .NET 5 was
found to be vulnerable to CVE-2020-8927, which was caused by the older
version of brotli built into .NET. .NET was vulernable even in
environments where a system-wide version of brotli was present and had
already received fixes for this CVE. We could have avoided a Remote Code
Execution vulnerability in such environments by using the system's
version of brotli.
This is similar to the existing support for disabling distro-agnostic
OpenSSL (except no OpenSSL is embedded) and using the system libunwind
(a copy of libunwind is embedded this repo).
One small twist is the presence of entrypoint verification. In a
system-brotli build, the verification fails, because the built library,
libSystem.IO.Compression.Native.so, doesn't include the symbols for
Brotli. Those symbols are instead used from the system brotli libraries.
Andy Gocke [Wed, 23 Mar 2022 03:44:24 +0000 (20:44 -0700)]
Delete create-codespaces-prebuild.yml (#67015)
* Delete create-codespaces-prebuild.yml
* Remove reference to the prebuild action and link to the codespaces doc instead.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Carlos Sanchez [Tue, 22 Mar 2022 23:55:12 +0000 (16:55 -0700)]
Bump PreReleaseVersionIteration to 4 (#66962)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Jeremy Barton [Tue, 22 Mar 2022 22:30:17 +0000 (15:30 -0700)]
Fix revocation processing on expired chains.
When adding tracing to the Linux X509Chain build, the "when do we process revocation" check got cleaned up to avoid doing wasteful work. But it got cleaned a bit too aggressively.
With this change, fully-valid and valid-except-for-validity chains will both move into active revocation checks.
Zoltan Varga [Tue, 22 Mar 2022 21:10:50 +0000 (17:10 -0400)]
[mono] Remove the llvmonly exception handling code, its not used any more. (#66875)
Eirik Tsarpalis [Tue, 22 Mar 2022 21:07:37 +0000 (21:07 +0000)]
Consolidate sync/async JsonSerializer test abstractions (#66729)
* Consolidate sync/async JsonSerializer test abstractions
* Rename wrapper properties
Stephen Toub [Tue, 22 Mar 2022 21:05:50 +0000 (17:05 -0400)]
Remove OfType/ToArray usage from ReflectTypeDescriptionProvider (#66949)
Aaron Robinson [Tue, 22 Mar 2022 19:00:35 +0000 (15:00 -0400)]
Release `CordbUnmanagedThread` instance from `CordbProcess` member (#66910)
* Release CordbUnmanagedThread from CordbProcess member
The m_lastDispatchedIBEvent was not being cleared during shutdown, which was causing a memory leak assert to fire.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Aaron Robinson [Tue, 22 Mar 2022 19:00:14 +0000 (15:00 -0400)]
Release `CordbUnmanagedThread` instance from `CordbProcess` member (#66910)
* Release CordbUnmanagedThread from CordbProcess member
The m_lastDispatchedIBEvent was not being cleared during shutdown, which was causing a memory leak assert to fire.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Radek Doulik [Tue, 22 Mar 2022 17:25:01 +0000 (18:25 +0100)]
[wasm] Emscripten 3.1.1 bump (#63894)
* Initial changes for emscripten 2.0.34
* Use emcc-link.rsp in build targets
* Use updated docker images
* Fix compiler warnings
Co-authored-by: Zoltan Varga <vargaz@gmail.com>
* Put `--profiling-funcs` to `_EmccLinkFlags`
* Fix build
src/mono/mono/mini/mini-runtime.c:3407:25: error: ‘invoke’ undeclared (first use in this function); did you mean ‘revoke’?
3407 | invoke = mono_marshal_get_runtime_invoke_dynamic ();
* Add shell to the environment
Environment setting https://github.com/emscripten-core/emscripten/blob/2.0.34/src/settings.js#L616-L641
From emscripten 2.0.25 release notes
- Support for the 'shell' environment is now disabled by default. Running under
`d8`, `js`, or `jsc` is not something that most emscripten users ever want to
do, so including the support code is, more often than not, unnecessary. Users
who want shell support can enable it by including 'shell' in `-s ENVIRONMENT`
(#14535).
Example of the the size increase for bench sample:
-a--- 12/10/2021 3:35 PM 382113 dotnet.js
-a--- 12/13/2021 10:37 AM 383589 dotnet.js
* Add emcc-link.rsp to PlatformManifestFileEntry
* Feedback
https://github.com/emscripten-core/emscripten/blob/
2fda25eea756c78c8cb024aa5b6c2b188bf7990f/src/settings.js#L1173-L1176
-s EXPORT_ES6 is link option
* Bump emscripten version
* Bump llvm package version and use its libclang
* Use newer docker images with emscripten 3.1.1
* Remove unused variable
* Add note about icu repo
* Add comment to improve code readability
* Bump the ICU and emsdk versions
* disable non-wasm builds
* disable wasm jobs in runtime, and runtime-staging, as we'll be running runtime-wasm manually
* [wasm] Re-enable tests that were disabled due to the earlier emsdk bump
System.Linq.Tests.csproj: https://github.com/dotnet/runtime/issues/64774
System.Text.Json.Tests.csproj: https://github.com/dotnet/runtime/issues/64775
System.Text.RegularExpressions.Tests.csproj: https://github.com/dotnet/runtime/issues/64769
System.Threading.Channels.Tests.csproj: https://github.com/dotnet/runtime/issues/65012
System.Collections.Immutable.Tests.csproj: https://github.com/dotnet/runtime/issues/65335
* [wasm] Disable nodejs tests
They are still unstable, and fail with:
```
[01:27:29] fail: /datadisks/disk1/work/
A3DA08F7/w/
B1B30976/e/test-main.js:97
[01:27:29] fail: if (typeof globalThis.crypto === 'undefined') {
[01:27:29] fail: ^
[01:27:29] fail:
[01:27:29] fail: ReferenceError: globalThis is not defined
[01:27:29] fail: at Object.<anonymous> (/datadisks/disk1/work/
A3DA08F7/w/
B1B30976/e/test-main.js:97:1)
[01:27:29] fail: at Module._compile (internal/modules/cjs/loader.js:778:30)
[01:27:29] fail: at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
[01:27:29] fail: at Module.load (internal/modules/cjs/loader.js:653:32)
[01:27:29] fail: at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
[01:27:29] fail: at Function.Module._load (internal/modules/cjs/loader.js:585:3)
[01:27:29] fail: at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
[01:27:29] fail: at startup (internal/bootstrap/node.js:283:19)
[01:27:29] fail: at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
```
Issue: https://github.com/dotnet/runtime/issues/65485
* fix wbt build
* Update path to node in helix commands.
* disable non-wasm builds
* [wasm] Make emscripten version mismatch an error on CI
* Bump emscripten packages used to preview3, which has emsdk 3.1.1
* Update emscripten package version in Versions.props tooo
* Re-enable wasm jobs
* enable non-wasm jobs
* Add more missing exports
* __dl_seterr shouldn't be needed
* Fix MicrosoftNETCoreRuntimeICUTransportVersion
* Put back the 3.1.1 docker images after merge
* Revert "fix wbt build"
This reverts commit
f7c77d995e36130118dd9d98c2c66809aaf42fe2.
* Revert "[wasm] Disable nodejs tests"
This reverts commit
7b90965638b7e90bf4d35c69696f2f361a04ef20.
* Use newer ICU package, last that still had 3.1.1
* Try different helix queue parameter
* Revert "Try different helix queue parameter"
This reverts commit
a34230f7fe04760df30c5e63e14826575f1a7545.
* Fix helix queue with docker tag
* Try to set PYTHONPATH for emscripten
* [wasm] Do not set _WasmDevel=true for blazor projects
* Increase timeout
The AOT tests are canceled after timeout
* Fix WBT tests
Co-authored-by: Ankit Jain <radical@gmail.com>
* [wasm] Export more functions
`htons,ntohs,_get_daylight,_get_timezone,_get_tzname`
.. to fix:
```
EXEC : warning : undefined symbol: htons (referenced by $inetPton6__deps: ['htons','$jstoi_q'], referenced by $writeSockaddr__deps: ['$Sockets','$inetPton4','$inetPton6','$zeroMemory'], referenced by __syscall_accept4__deps: ['$getSocketFromFD','$writeSockaddr','$DNS','$SYSCALLS'], referenced by top-level compiled C/C++ code) [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
EXEC : warning : undefined symbol: ntohs (referenced by $inetNtop6__deps: ['$inetNtop4','ntohs'], referenced by $readSockaddr__deps: ['$Sockets','$inetNtop4','$inetNtop6','ntohs'], referenced by $getSocketAddress__deps: ['$readSockaddr','$FS','$DNS'], referenced by __syscall_bind__deps: ['$getSocketFromFD','$getSocketAddress','$SYSCALLS'], referenced by top-level compiled C/C++ code) [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
EXEC : warning : undefined symbol: _get_daylight (referenced by tzset_impl__deps: ['_get_daylight','_get_timezone','_get_tzname'], referenced by tzset__deps: ['tzset_impl'], referenced by localtime_r__deps: ['tzset'], referenced by top-level compiled C/C++ code) [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
EXEC : warning : undefined symbol: _get_timezone (referenced by tzset_impl__deps: ['_get_daylight','_get_timezone','_get_tzname'], referenced by tzset__deps: ['tzset_impl'], referenced by localtime_r__deps: ['tzset'], referenced by top-level compiled C/C++ code) [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
EXEC : warning : undefined symbol: _get_tzname (referenced by tzset_impl__deps: ['_get_daylight','_get_timezone','_get_tzname'], referenced by tzset__deps: ['tzset_impl'], referenced by localtime_r__deps: ['tzset'], referenced by top-level compiled C/C++ code) [C:\helix\work\workitem\e\publish\ProxyProjectForAOTOnHelix.proj]
```
```
Starting: Microsoft.Extensions.Logging.Tests.dll
Message1
:
testKey3:testValue, testKey2:, testKey1:
missing function: ntohs
Error
at Object.onAbort (test-main.js:176:60)
at abort (./dotnet.js:1316:24)
at _ntohs (./dotnet.js:4990:35)
at readSockaddr (./dotnet.js:5091:18)
...
```
* fix exported function names
Co-authored-by: Radek Doulik <radekdoulik@google.com>
Co-authored-by: Zoltan Varga <vargaz@gmail.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Marek Fišera <mara@neptuo.com>
Andrew Au [Tue, 22 Mar 2022 17:06:49 +0000 (10:06 -0700)]
Fix heap walking with global allocation context (#66844)
Luca Leonardo Scorcia [Tue, 22 Mar 2022 16:41:33 +0000 (17:41 +0100)]
Fix #41618 Correct marshalling of SortKey objects on Linux (#65548)
Michal Strehovský [Tue, 22 Mar 2022 14:38:09 +0000 (23:38 +0900)]
Include method instantiation MethodTables in compilation (#66984)
* Include method instantiation MethodTables in compilation
We'll need to load the `MethodTable` so that we can search for it in GVM tables.
* Regression test
Adam Sitnik [Tue, 22 Mar 2022 14:07:40 +0000 (15:07 +0100)]
disable CooperativeBlockingCanCreateThreadsFaster on OSX (#66988)
Stijn Herreman [Tue, 22 Mar 2022 14:04:37 +0000 (15:04 +0100)]
Fix summary doc, the client name is an argument. (#66703)
Jan Vorlicek [Tue, 22 Mar 2022 12:26:23 +0000 (13:26 +0100)]
Cleanup macos 32 bit (#66849)
* Cleanup obsolete 32 bit related macOS code
* Cleanup obsolete mac OS 32 bit stuff
I've noticed that we had some stuff in our PAL that was there from
the era of the 32 bit mac OS, so I have removed it.
stefan-sf-ibm [Tue, 22 Mar 2022 10:44:59 +0000 (11:44 +0100)]
[mono] Initialize offset_entries (#66933)
Adeel Mujahid [Tue, 22 Mar 2022 09:37:17 +0000 (11:37 +0200)]
Fix a few #ifdef vs. #if issues (#66898)
Also upstreamed a fix for libunwind https://github.com/libunwind/libunwind/pull/342 (but we are not using ptrace so it can wait until the next libunwind update).
Ankit Jain [Tue, 22 Mar 2022 07:59:23 +0000 (03:59 -0400)]
[wasm] Do not set _WasmDevel=true for blazor projects (#66793)
* [wasm] Do not set _WasmDevel=true for blazor projects
to workaround wasm-ld getting oomkilled.
Fixes https://github.com/dotnet/runtime/issues/66725, and https://github.com/dotnet/runtime/issues/66591
* Fix test
Michal Strehovský [Tue, 22 Mar 2022 07:11:34 +0000 (16:11 +0900)]
Use UTF-8 for file path in ObjWriter (#66974)
LLVM already assumes the `char*` it receives is UTF-8. Fixes #66913.
Michal Strehovský [Tue, 22 Mar 2022 05:45:59 +0000 (14:45 +0900)]
Block targeting .NET 5 with NativeAOT (#66972)
The trimming settings for .NET 5 are not compatible and lead to rooting everything. Who knows what else is not compatible. We don't test this.
Jeremy Koritzinsky [Tue, 22 Mar 2022 05:30:27 +0000 (22:30 -0700)]
Fix some alloc-dealloc mismatches found by ASAN (#66964)
* Fix some alloc-dealloc mismatches found by ASAN
* Define new static
Tomas Weinfurt [Tue, 22 Mar 2022 02:14:22 +0000 (19:14 -0700)]
remove unused code (#66959)
* remove unused code
* fix osx build
* android
Badre BSAILA [Tue, 22 Mar 2022 01:01:28 +0000 (02:01 +0100)]
prevent BaseType from returning default (#66955)
Jeremy Koritzinsky [Tue, 22 Mar 2022 00:12:23 +0000 (17:12 -0700)]
Add validation target to avoid losing test coverage with merged test wrappers (#66951)
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
Jan Kotas [Mon, 21 Mar 2022 22:36:51 +0000 (15:36 -0700)]
Update to latest System.CommandLine package (#66929)
dotnet-maestro[bot] [Mon, 21 Mar 2022 22:25:51 +0000 (15:25 -0700)]
[main] Update dependencies from dotnet/linker (#66538)
* Update dependencies from https://github.com/dotnet/linker build
20220311.3
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22161.3
* Update dependencies from https://github.com/dotnet/linker build
20220314.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22164.1
* Fix warnings introduced by new version of trim analyzer
In the case of Type.Helpers.cs better data flow analysis in the analyzer uncovers a warning. The method is used to implement reflection functionality and the warnings are not a problem and should be suppressed.
In the case of the System.Private.Xml Types.cs, the analyzer shows a real issue where the annotation is not enough for what the method does. This changed the annotation to All - which is already in place in all the callers anyway.
* Update dependencies from https://github.com/dotnet/linker build
20220318.5
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22168.5
* Update dependencies from https://github.com/dotnet/linker build
20220318.6
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22160.1 -> To Version 7.0.100-1.22168.6
* Fix suppression for MakeGenericType of Nullable
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Carlos Sanchez [Mon, 21 Mar 2022 22:18:41 +0000 (15:18 -0700)]
Bump IntelliSense package to .NET 7.0 Preview1 (#66753)
Jeremy Koritzinsky [Mon, 21 Mar 2022 21:22:17 +0000 (14:22 -0700)]
Fix memory load ordering bug (#66952)
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Alexander Köplinger [Mon, 21 Mar 2022 19:23:21 +0000 (20:23 +0100)]
[mono] Remove w32error code (#66846)
The remaining usages can be removed.
dotnet bot [Mon, 21 Mar 2022 19:16:28 +0000 (12:16 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1674429 (#66883)
Sychev Vadim [Mon, 21 Mar 2022 19:13:05 +0000 (22:13 +0300)]
Add optimization "X & 1 == 1" to "X & 1" (#61412) (#62818)
* Add optimization "X & 1 == 1" to "X & 1" (#61412)
* Moved the optimization to the morph phase (#61412)
* Done in post-order (#61412)
* Moved the optimization into fgOptimizeEqualityComparisonWithConst (#61412)
* Some corrections due the comments (#61412)
* Fix of the picture (#61412)
* Add optNarrowTree use (#61412)
* Change narrowing to the type check (#61412)
* Fix regressions (#61412)
* Moved the optimization to the lowering phase (#61412)
* Reverted Morph changes (#61412)
* Moved the optimization into OptimizeConstCompare method (#61412)
* Add GT_EQ check(#61412)
Adeel Mujahid [Mon, 21 Mar 2022 19:12:43 +0000 (21:12 +0200)]
Clear gcServer envvar before running the scenario (#66907)
Anton Firszov [Mon, 21 Mar 2022 18:43:37 +0000 (19:43 +0100)]
Fix DNS cancellation deadlock (#63904)
Avoid taking a lock, and address the use-after-free race condition by guarding GetAddrInfoExContext with a SafeHandle.
Aaron Robinson [Mon, 21 Mar 2022 18:00:26 +0000 (14:00 -0400)]
Update error string for non-glibc scenarios (#66950)
* Update error string for non-glibc scenarios
Adeel Mujahid [Mon, 21 Mar 2022 17:51:09 +0000 (19:51 +0200)]
Move libunwind directories to src/native/external (#64043)
* Move libunwind directories to src/native/external
* Move extra additions to single directory
* Extract coreclr configs in libunwind.cmake
* Reapply upstream patches
* Fixups
Jakob Botsch Nielsen [Mon, 21 Mar 2022 17:19:15 +0000 (18:19 +0100)]
Revert "[crossgen2] Promote single byref aot. (#65682)" (#66946)
This reverts commit
c6ca9dc012bfd1a1fca7b6a2139d20368a258deb.
Jeremy Koritzinsky [Mon, 21 Mar 2022 17:08:25 +0000 (10:08 -0700)]
Implement NativeLibrary.GetEntryPointModuleHandle (#57610)
Bruce Forstall [Mon, 21 Mar 2022 16:36:11 +0000 (09:36 -0700)]
Cloning improvements (#66257)
* Loop cloning improvements
Fix various comments
* Remove loop cloning var initialization condition
Assume that any pre-existing initialization is ok. Check it against
zero if necessary. Const inits remain as before.
Lots of diffs due to more cloning for cases of `for (i = expression...`
where `expression` is not just a constant or local var.
* Feedback
Parker Bibus [Mon, 21 Mar 2022 16:02:33 +0000 (11:02 -0500)]
[PERF][MAUI] Update Podcast app repo (#66843)
* Update the repo and branch we get dotnet-podcasts from.
Alexander Köplinger [Mon, 21 Mar 2022 15:48:06 +0000 (16:48 +0100)]
[mono] Fix typo in detecting sys/auxv.h (#66894)
We were checking `sts/auxv.h` instead of `sys/auxv.h` so we were never defining `HAVE_SYS_AUXV_H`.
Instead of fixing the typo let's switch to checking for `HAVE_GETAUXVAL` which is what coreclr/libs.native are using.
Michal Strehovský [Mon, 21 Mar 2022 15:04:45 +0000 (00:04 +0900)]
Fix up DiagnosticName of RuntimeDetermined types (#66937)
Name/Namespace of these already includes the details type name. Bring this over to DiagnosticName too.
This is so that we can distinguish between `List<__Canon>` and List<T___Canon>`.
Vlad Brezae [Mon, 21 Mar 2022 14:18:33 +0000 (16:18 +0200)]
[mono][interp] Fix a few local store warnings (#66766)
* [mono][interp] Fix warning when storing function pointers
* [mono][interp] Fix storing of R4 or R8 into local of different size
The IL execution stack operates on generic floating type F, which can be stored in local of both float32 or float64. We however operate on the real types and need to add implicit conversions if necessary.
* [mono][interp] Fix ckfinite
It was previously handling only R8 correctly.
* [mono][interp] Add implicit conversion between nint and int32
* [mono][interp] Change warning to error
Michal Strehovský [Mon, 21 Mar 2022 13:28:14 +0000 (22:28 +0900)]
Make it possible to log scanner progress (#66935)
We were using a null logger.
Gleb Balykov [Mon, 21 Mar 2022 13:14:45 +0000 (16:14 +0300)]
Add executable bit to tizen sh files (#66931)
Hyungju Lee [Mon, 21 Mar 2022 04:58:35 +0000 (13:58 +0900)]
Fix ReplaceModuleMapping for 32bit binary on 64bit kernel (#66640)
Stephen Toub [Mon, 21 Mar 2022 03:41:21 +0000 (23:41 -0400)]
Use ValueStringBuilder in CodeIdentifier.MakeValid (#66915)
Stephen Toub [Mon, 21 Mar 2022 03:20:48 +0000 (23:20 -0400)]
Replace XmlSchema ContentValidator Hashtables that are boxing lots of ints (#66908)
Jan Kotas [Sun, 20 Mar 2022 21:41:47 +0000 (14:41 -0700)]
Delete IL verifier support in the VM (#66616)
Contributes to #32648
Wraith [Sun, 20 Mar 2022 10:41:02 +0000 (10:41 +0000)]
Add flags checks to BMI1 intrinsic lowering (#66736)
* add flags checks to BMI1 intrinsic lowering to prevent decomposed longs in x84 from being altered
* update bmji1intrinsics tests
Bruce Forstall [Sun, 20 Mar 2022 00:44:50 +0000 (17:44 -0700)]
Update coredistools from 1.0.1-prerelease-00006 to 1.1.0 (#66861)
Updates include:
- Use LLVM 13.0.1
- Use Visual Studio 2022 for building on Windows
- Use Ubuntu 18.04 containers for building on Linux
Binaries built from: https://github.com/dotnet/jitutils/pull/351
Jakob Botsch Nielsen [Sat, 19 Mar 2022 20:55:47 +0000 (21:55 +0100)]
Fix too narrow loads while unspilling (#66675)
Unspilling could produce too narrow loads for normalize-on-load
variables when encountering a narrowly typed LCL_VAR node. This could
result in subsequent uses of the same local using a truncated value.
Fix #66624
Tomáš Rylek [Sat, 19 Mar 2022 20:20:36 +0000 (21:20 +0100)]
Merged wrapper support for test exclusion lists (#66680)
According to our design discussions we have decided to keep
the 'issues.targets' file for disabling tests before the
test refactoring has been completed as otherwise we would
have a subset of issue exclusions in 'issues.targets' and
the rest in 'ActiveIssue' test annotations making it very
hard to understand for developers and test monitors.
Moreover today implementation of ActiveIssue is not rich enough
to express all conditional test disabling clauses in issues.targets
so the bug migration will require a bit of additional design work
and we don't want to block the migration on that. This simple change
uses the existing infrastructure to emit a "test exclusion list"
under CORE_ROOT for the particular targeting OS, architecture and
build mode that gets subsequently consumed by the merged test
wrapper in Helix and used to skip the blocked tests.
Thanks
Tomas
Andy Ayers [Sat, 19 Mar 2022 15:25:00 +0000 (08:25 -0700)]
JIT: handle large OSR funclet frame initial SP delta for arm64 type 5… (#66124)
Because OSR funclet frames must pad with Tier0 frame size, initial SP delta
may exceed 240 bytes.
Fixes #65996.
Adeel Mujahid [Sat, 19 Mar 2022 13:14:13 +0000 (15:14 +0200)]
Include sys/auxv.h in getexepath (#66874)
J. Ritchie Carroll [Sat, 19 Mar 2022 12:22:06 +0000 (07:22 -0500)]
Fixed TlsHandshakeType enum label (#66786)
Fixes #66781
Stefan [Sat, 19 Mar 2022 12:21:23 +0000 (13:21 +0100)]
Fix Character Spelling (#66857)
Stephen Toub [Sat, 19 Mar 2022 12:20:21 +0000 (08:20 -0400)]
Add tests for RegexGenerator on interface and virtual members (#66850)
Stephen Toub [Sat, 19 Mar 2022 12:19:58 +0000 (08:19 -0400)]
Avoid boxing array enumerator in StackTrace.TryResolveStateMachineMethod (#66836)
Stephen Toub [Sat, 19 Mar 2022 12:19:11 +0000 (08:19 -0400)]
Avoid IntPtr[] allocation in Associates.AssignAssociates (#66825)
* Avoid IntPtr[] allocation in Associates.AssignAssociates
* Address PR feedback (and as a result use stack space in a few more related places)
Zoltan Varga [Sat, 19 Mar 2022 07:14:11 +0000 (03:14 -0400)]
[mono] Make the --llvmonly mode the same as --llvmonly-interp. (#66811)
The --llvmonly mode is not used in production, it also doesn't
have correct EH semantics.
Ilona Tomkowicz [Sat, 19 Mar 2022 06:58:21 +0000 (07:58 +0100)]
Disabled System.Security.Cryptography.Tests for Android x64 and x86 (#66833)
* Disabled System.Security.Cryptography.Tests.
* Applied @mdh1418 suggestion.
* Removed empty line.
Vladimir Sadov [Sat, 19 Mar 2022 06:44:02 +0000 (23:44 -0700)]
Do not include redist files in runtime packs (#66805)
* do not copy redist files to artefacts
* do not copy redist files to tests
* Do not include Redist files in runtime packs
Brennan [Sat, 19 Mar 2022 02:38:40 +0000 (19:38 -0700)]
Fix cancel in PipeReader.ReadAtLeastAsync (#66752)
Jeremy Koritzinsky [Fri, 18 Mar 2022 22:41:43 +0000 (15:41 -0700)]
Replace AsArgument/AsParameter with less P/Invoke-centric concepts (#66784)
Alexander Köplinger [Fri, 18 Mar 2022 19:00:29 +0000 (20:00 +0100)]
[mono] Remove a few set but unused variables (#66839)
These triggered a warning in the new clang included with Xcode 13.3
Stephen Toub [Fri, 18 Mar 2022 17:56:28 +0000 (13:56 -0400)]
Dedup patterm/options/timeout in Regex source generator (#66747)
* Dedup patterm/options/timeout in Regex source generator
If we end up with multiple identical pattern/options/timeout tuples in the same assembly, we don't need to emit unique code for each. We can still emit the partial implementation for each, but emit a single implementation of the Regex they all share.
* Make the cached Regex members be static readonly fields
No reason we need a property here wrapping a compiler-generated backing field.
Stephen Toub [Fri, 18 Mar 2022 17:25:31 +0000 (13:25 -0400)]
Reduce string allocations in XmlWriterTraceListener (#66762)
Rather than ToString'ing everything, most of the header data can be formatted into a span and then written out to the writer.