akallabeth [Mon, 18 May 2020 15:10:18 +0000 (17:10 +0200)]
Prepared version for 2.1.1
akallabeth [Mon, 18 May 2020 15:10:08 +0000 (17:10 +0200)]
Updated changelog for 2.1.1
akallabeth [Tue, 19 May 2020 11:11:32 +0000 (13:11 +0200)]
Clear dynamic channel lists on disconnect.
(cherry picked from commit
a1eb3e66b31579d3d878dee67913962140f75255)
Kobi Mizrachi [Tue, 19 May 2020 12:06:22 +0000 (15:06 +0300)]
codec: fix typo in progressive codec log
(cherry picked from commit
8d72051ab157d89af3f919a441170ca57bf67e84)
akallabeth [Tue, 19 May 2020 12:07:15 +0000 (14:07 +0200)]
Fixed some more resource cleanup leaks in nla
(cherry picked from commit
354bb7d6ae98df282775d154b609a39c1068a09b)
akallabeth [Wed, 20 May 2020 13:24:34 +0000 (15:24 +0200)]
Reformatted to satisfy clang-format
(cherry picked from commit
a4e95f8e65dfbfd2625034ad6740645366a6c0c0)
akallabeth [Wed, 20 May 2020 11:45:57 +0000 (13:45 +0200)]
Abort on first possible certificate validation error
Only retry certificate validation if the purpose was wrong.
(cherry picked from commit
de619e9964684eced5fb3108de81440b979aace0)
akallabeth [Wed, 20 May 2020 06:59:44 +0000 (08:59 +0200)]
Fixed #6197: NULL check in urbdrc
(cherry picked from commit
fb3a0e6b5ae3b4e6523509a0ec0c522425968989)
Armin Novak [Tue, 19 May 2020 17:46:01 +0000 (19:46 +0200)]
Fixed #6195: Wrong length read/write in rdpei
(cherry picked from commit
a18a732d4b87c85bcd364626b9ab2b8f95f9e955)
Armin Novak [Tue, 19 May 2020 17:32:42 +0000 (19:32 +0200)]
Fixed #6200: Arraysize check
(cherry picked from commit
06c48df0dfd228646fed00c554a20ae9bcaa5e5e)
Armin Novak [Tue, 19 May 2020 17:29:32 +0000 (19:29 +0200)]
Fixed #6199: Reading version information in tsg
(cherry picked from commit
e501c56e5ca0c76c4019e7048cba3ee63331d830)
Armin Novak [Tue, 19 May 2020 17:25:18 +0000 (19:25 +0200)]
Fixed #6201: event handler count check
(cherry picked from commit
018eaa44f52b3e9e33bfa80493faf9be57713a3d)
akallabeth [Tue, 19 May 2020 13:18:55 +0000 (15:18 +0200)]
Reset pointer to NULL after free.
(cherry picked from commit
33c7f808154c6682d3b84526a46d79f3e8d5c1ac)
akallabeth [Tue, 19 May 2020 09:32:59 +0000 (11:32 +0200)]
Renamed variable to avoid MSVC define collission
(cherry picked from commit
f9e1f21b0ce47d8eeea40314ce6b8b666964dc7d)
akallabeth [Tue, 19 May 2020 07:05:05 +0000 (09:05 +0200)]
Fixed missing label
akallabeth [Tue, 19 May 2020 06:16:55 +0000 (08:16 +0200)]
Ensure buffers are NULL before reuse in NLA
(cherry picked from commit
5f53b2b7c7109016b7127d595e13bd333ac77613)
akallabeth [Tue, 19 May 2020 06:04:02 +0000 (08:04 +0200)]
Removed unused variable warnings
(cherry picked from commit
8052708f3354a686de98b62d641e9d0eb61a74db)
akallabeth [Tue, 19 May 2020 06:01:48 +0000 (08:01 +0200)]
Fixed invalid argument to strtok_s
(cherry picked from commit
dc4ac3ba17b6a340b96aa3f6363c6fac866696b7)
akallabeth [Tue, 19 May 2020 05:48:07 +0000 (07:48 +0200)]
Fixed GHSL-2020-101 missing NULL check
(cherry picked from commit
b207dbba35c505bbc3ad5aadc10b34980c6b7e8e)
akallabeth [Tue, 19 May 2020 05:41:14 +0000 (07:41 +0200)]
Fixed GHSL-2020-102 heap overflow
(cherry picked from commit
197b16cc15a12813c2e4fa2d6ae9cd9c4a57e581)
akallabeth [Mon, 18 May 2020 15:40:28 +0000 (17:40 +0200)]
Fixed multiple sanitizer errors in codecs
(cherry picked from commit
2278d92a5d902692a7d1088629b2345c9b4e229c)
akallabeth [Mon, 18 May 2020 07:36:16 +0000 (09:36 +0200)]
Fixed issues with clang sanitizers and alignemt offsets.
(cherry picked from commit
4c1011fec37459ecc11f6c4453bcd693ed614e5d)
akallabeth [Mon, 18 May 2020 07:30:59 +0000 (09:30 +0200)]
Fixed history buffer reset.
(cherry picked from commit
ccc9cbef2d5d0d9f5cf5ec7621f71bed33f41aba)
akallabeth [Mon, 18 May 2020 07:24:01 +0000 (09:24 +0200)]
Fixed extended info packet alignment.
(cherry picked from commit
03ebaf2dc1547c75f8693dd5087ce2e8dc17765a)
akallabeth [Mon, 18 May 2020 07:07:49 +0000 (09:07 +0200)]
Fixed rdp_read_info_packet unaligned access and size checks
(cherry picked from commit
c75d08d70e878d35cd12ffac2aefcda405576092)
akallabeth [Mon, 18 May 2020 06:10:42 +0000 (08:10 +0200)]
Fixed memory leak in test
(cherry picked from commit
2d630cccf7b1e566f99b74a224805fc25f85d6c1)
akallabeth [Mon, 18 May 2020 06:10:29 +0000 (08:10 +0200)]
Fixed unaligned access
(cherry picked from commit
cb2ed7f09ad68242bfdfad8967024b063f785d97)
akallabeth [Mon, 18 May 2020 05:54:48 +0000 (07:54 +0200)]
Fixed rails debug string warnings.
(cherry picked from commit
e58ea30305e8754ada82018c4f2042ec1b72337c)
akallabeth [Fri, 15 May 2020 15:49:55 +0000 (17:49 +0200)]
utf8 behaviour fixes
(cherry picked from commit
bb78eb4fa6f8618a70995eaf17aba94cc47a1e74)
akallabeth [Fri, 15 May 2020 15:28:13 +0000 (17:28 +0200)]
Rewritten rdp_recv_logon_info_v2 to remove unaligned access
(cherry picked from commit
66d182a84bed7bf19b6a99d71a4e4c7c6856f583)
akallabeth [Fri, 15 May 2020 15:18:57 +0000 (17:18 +0200)]
Rewritten check to satisfy BehaviouralSanitizer
(cherry picked from commit
14829de866b43e7f2740b46f0c736b9adf5067eb)
akallabeth [Fri, 15 May 2020 14:55:58 +0000 (16:55 +0200)]
Fixed BehaviourSanitizer warning in rdp parser
(cherry picked from commit
771332c04e2dbad964d0cb11a86ff561e792bc35)
akallabeth [Fri, 15 May 2020 14:38:42 +0000 (16:38 +0200)]
Fixed memory leak in NTLM test
(cherry picked from commit
135458cf27160d50e6294f87ef80f27f1f65d319)
akallabeth [Fri, 15 May 2020 14:30:02 +0000 (16:30 +0200)]
Fixed undefined behaviour
(cherry picked from commit
c15929d821ce99aa8c1069f790f4addbe9439593)
akallabeth [Fri, 15 May 2020 14:04:28 +0000 (16:04 +0200)]
Fixed undefined behaviour in primitives shift
(cherry picked from commit
436bd3dbb103c7c49e51ffb1cafad6f25ab05d66)
akallabeth [Fri, 15 May 2020 13:43:33 +0000 (15:43 +0200)]
Fixed undefined behaviour in ncrush
(cherry picked from commit
83137d2a1bb732fbea2f20778924a50a79f63fef)
akallabeth [Fri, 15 May 2020 13:40:12 +0000 (15:40 +0200)]
Fixed undefined behaviour in rfx decoder
(cherry picked from commit
ef611d34d61c6590429c17db5c97f0a9a33147e8)
akallabeth [Fri, 15 May 2020 13:34:42 +0000 (15:34 +0200)]
Fixed UndefinedBehaviour in planar left shift
(cherry picked from commit
328691c46597c194f01a77a9d33d58b2faa88c9d)
akallabeth [Fri, 15 May 2020 13:04:05 +0000 (15:04 +0200)]
Fixed BehaviourSanitizer warnings in streams.
(cherry picked from commit
66ea3d0579841b468684e05936fabf654727e720)
akallabeth [Fri, 15 May 2020 12:49:52 +0000 (14:49 +0200)]
Fixed memory leak in ini parser and test functions.
(cherry picked from commit
7f9997595918e8b6a2acec2ff40f5779fa183038)
akallabeth [Fri, 15 May 2020 10:22:37 +0000 (12:22 +0200)]
Refactored settings clone/free, extended tests
(cherry picked from commit
773ad6e9791844ca3ccdc40d378a37fc0238ef0a)
akallabeth [Fri, 15 May 2020 09:20:24 +0000 (11:20 +0200)]
Fixed BehaviorSanitizer warnings.
(cherry picked from commit
b5dfc15183b752a5d9c6da01225ed281b20001cf)
akallabeth [Fri, 15 May 2020 09:16:50 +0000 (11:16 +0200)]
Fixed BehaviorSanitizer warnings
(cherry picked from commit
0d28390319025c86e7e9d7cc776d88ef24f9db0e)
akallabeth [Fri, 15 May 2020 09:16:18 +0000 (11:16 +0200)]
Always require aligned memory for interleaved codec.
(cherry picked from commit
20c11fb7178462a8ba36b4fdbfb3e2a03197356f)
akallabeth [Fri, 15 May 2020 09:15:21 +0000 (11:15 +0200)]
Fixed BehaviorSanitizer warnings
(cherry picked from commit
afdd81dab5c484ab95b977a0d71f3809c8fa89a3)
akallabeth [Fri, 15 May 2020 09:14:44 +0000 (11:14 +0200)]
Fixed BehaviorSantizer warnings.
(cherry picked from commit
7a509fe27749e006a9a58854c4abb4522fc58c81)
akallabeth [Fri, 15 May 2020 08:17:31 +0000 (10:17 +0200)]
Fixed GHSL-2020-100: oob read in ntlm_read_ChallengeMessage
* Added length checks for data read from stream
* Unified function resource cleanup
(cherry picked from commit
8357dedbbf7213b7d0d18f1026145b9a5b92235a)
Kentaro Hayashi [Sun, 10 May 2020 07:35:20 +0000 (16:35 +0900)]
Fixed typos (Otherweise)
Otherweise ->
Otherw ise
^
(cherry picked from commit
148f3c675d02da2c7f19b3099ba8792f5594416b)
Vladyslav Hordiienko [Wed, 6 May 2020 09:36:44 +0000 (12:36 +0300)]
improve RFX DWT algorithm
merge multiple loops into the one loop for vertical DWT inverse
(cherry picked from commit
fff9eba34af8a54bd93b1a7ccdda0a6a6898f755)
Vladyslav Hordiienko [Wed, 6 May 2020 08:05:04 +0000 (11:05 +0300)]
fix typo in GFX logs
(cherry picked from commit
a79635fd1c9e12c4ea543f461f03c0dd83d5e063)
Victor K [Fri, 15 May 2020 00:50:20 +0000 (03:50 +0300)]
Windows Authentication - Then launced with username argument prefill the name in the authentication box.
(cherry picked from commit
318075676b5ea610b1ba47da600eb418812951cb)
akallabeth [Mon, 18 May 2020 10:07:59 +0000 (12:07 +0200)]
Refactored sam functions to utilize strtok_s
(cherry picked from commit
ddb388e1527de69e47d55068d8a318ef270fc4a0)
akallabeth [Mon, 18 May 2020 09:18:55 +0000 (11:18 +0200)]
Replaced strtok with strtok_s
(cherry picked from commit
7890833af8a891765a475bd7ae2a756aeddd4977)
akallabeth [Mon, 18 May 2020 12:27:13 +0000 (14:27 +0200)]
Fixed NULL access of context struct on screen draw
Added a log message to fix occurances later on.
(cherry picked from commit
cfea3fc6ed01aa33c1a935da42572577ba832feb)
akallabeth [Mon, 18 May 2020 12:20:11 +0000 (14:20 +0200)]
Extend lifetime of streampool in drdynvc
The stream pool can not be released until all streams have been
returned. This might happen as late as channel termination, so
change the lifetime scope accordingly.
(cherry picked from commit
5bd4cfcdc013cdd0c0d7c9b6eec878dd8a297575)
akallabeth [Mon, 18 May 2020 08:26:09 +0000 (10:26 +0200)]
Fixed sample client resource cleanup
(cherry picked from commit
e716f823115463fc66d94dd6c044ba7c47c43fe1)
Kobi Mizrachi [Mon, 18 May 2020 08:35:52 +0000 (11:35 +0300)]
change use of strtok to strtok_s
(cherry picked from commit
6013a96bff20affbb4c0a1780d35a751eafa4903)
akallabeth [Tue, 12 May 2020 14:34:01 +0000 (16:34 +0200)]
Fixed drdynvc_send stream release
(cherry picked from commit
a497e78d37b63f8f342be56e1732c5a891b5ba0d)
akallabeth [Tue, 12 May 2020 12:26:45 +0000 (14:26 +0200)]
Fixed DestroyListener arguments and call order
(cherry picked from commit
0e08727d4ecff2777884a23bc33961f63d52465e)
akallabeth [Tue, 12 May 2020 11:00:13 +0000 (13:00 +0200)]
Fixed #6148: multiple ceritificate purposes
OpenSSL certificate verification can only check a single purpose.
Run the checks with all allowed purposes and accept any.
(cherry picked from commit
f3063a589d908a087a295b9217bc5fa34a80fb36)
Kobi Mizrachi [Tue, 12 May 2020 10:30:20 +0000 (13:30 +0300)]
server: proxy: use peer load balance info when host is fetched from config
(cherry picked from commit
6f4682a043d20b794540827fe8604354477bb7af)
akallabeth [Tue, 12 May 2020 08:54:07 +0000 (10:54 +0200)]
Destroy channel listeners on terminate
(cherry picked from commit
2f5e5359f60c26a2de244cd6d9f7957b039cd121)
akallabeth [Tue, 12 May 2020 08:21:06 +0000 (10:21 +0200)]
drdynvc channel cleanup.
* Clean channel listeners on channel close
* Remove limit on listeners for channels
* Remove limit on channels
(cherry picked from commit
5b2a4434d8becd7b527d5b329eee9915ff8ca77a)
akallabeth [Tue, 12 May 2020 07:09:13 +0000 (09:09 +0200)]
Ensure all NLA structs are freed up
(cherry picked from commit
477ad675f31a1965833304f79406599e0ad97b82)
akallabeth [Tue, 12 May 2020 06:46:06 +0000 (08:46 +0200)]
Fixed #6157: Reset cups instance on disconnect.
(cherry picked from commit
13906f3ec629af4b2b2aeb5b92845f99b7bf7747)
akallabeth [Mon, 11 May 2020 07:56:18 +0000 (09:56 +0200)]
Fixed #6163: Force linking to objective C runtime
Sound channel requires the objective C runtime, force linking to
fix build issues on older mac os versions
(cherry picked from commit
eee1d7176b885d09385471bec943c9aabc4a1552)
akallabeth [Mon, 11 May 2020 06:50:15 +0000 (08:50 +0200)]
Fixed #6156: Enforce synchronized encrypt count
Old style RDP encryption uses a counter, synchronize this for
packets send from different threads.
(cherry picked from commit
873a9bef42017ff694659538f70909f679eb1eac)
akallabeth [Mon, 11 May 2020 06:40:13 +0000 (08:40 +0200)]
Fixed #6162: Clipboard temporary path length limit
The limit of clipboard temporary paths is 260 '\0' terminated
wide characters. Fix the checks to enforce that properly.
(cherry picked from commit
06bfcfad672522598a39522830449b444d50a9e4)
Kobi Mizrachi [Sun, 10 May 2020 05:33:25 +0000 (08:33 +0300)]
server: proxy: Register signal handler after modules finished loading.
This prevents a race where the signal handler free's structs that
modules use while initializing.
(cherry picked from commit
42d99f4c6070a984afc43ec7e85650dc4e624af8)
Kobi Mizrachi [Sun, 10 May 2020 05:33:07 +0000 (08:33 +0300)]
server: proxy: print version and buildconfig on startup
(cherry picked from commit
f0fe17d94364087136354284543573bf54da162f)
Bernhard Miklautz [Fri, 8 May 2020 09:40:17 +0000 (11:40 +0200)]
Merge pull request #6152 from akallabeth/stable-backports
Stable backports
akallabeth [Tue, 5 May 2020 05:50:40 +0000 (07:50 +0200)]
2.1.0 release version.
akallabeth [Tue, 5 May 2020 09:46:19 +0000 (11:46 +0200)]
Changelog for 2.1.0
akallabeth [Wed, 29 Apr 2020 13:47:00 +0000 (15:47 +0200)]
Fixed integer overflow in winpr_image_bitmap_read_buffer
Thanks to hac425
(cherry picked from commit
dffd893dc5874b63c99777d7df147e37c770fc92)
akallabeth [Fri, 8 May 2020 07:39:10 +0000 (09:39 +0200)]
Changed smartcard no reader log message level to info
(cherry picked from commit
728f6aff516a12ac8720aa0c9fa1730cde348dca)
akallabeth [Fri, 8 May 2020 07:37:19 +0000 (09:37 +0200)]
Fixed wrong error return from drdynvc_write_data
When the channel was closed a wrong error code was returned.
(cherry picked from commit
6446d609fc95830d7c9c1e6a91829146d567e277)
akallabeth [Thu, 7 May 2020 14:19:54 +0000 (16:19 +0200)]
Silence valgrind in rdp_read_header
If a disconnect message is received, we returned success but did
not initialize the return arguments.
(cherry picked from commit
b45336f51febb4c34b5bf33fdf8d63ce44fe9e99)
akallabeth [Thu, 7 May 2020 13:38:35 +0000 (15:38 +0200)]
Silence valgrind in unicode conversion functions
Only check destination buffer for NULL if length argument did not
already indicate the buffer needs to be allocated.
(cherry picked from commit
ebe223e7a4ba0131b55e0c8e8baa98deb3f89c4b)
akallabeth [Thu, 7 May 2020 09:13:06 +0000 (11:13 +0200)]
Increased uwac library version.
(cherry picked from commit
58b313e6d95d96f942b451c9b635fbc70fe415cf)
akallabeth [Tue, 5 May 2020 15:02:34 +0000 (17:02 +0200)]
Create data copy in case of dynamic sound channel.
(cherry picked from commit
f016f1ec09056db856fb662876f934dbc754bc0c)
akallabeth [Mon, 4 May 2020 08:57:19 +0000 (10:57 +0200)]
Fixed warning messages for RDP file options
networkautodetect and bandwidthautodetect are both boolean options
which must match each other. Added adequate warnings.
(cherry picked from commit
5f5bf10703276be3ddb0c5d184e078c0a6a857bb)
akallabeth [Tue, 5 May 2020 11:07:15 +0000 (13:07 +0200)]
Use dedicated sound decoder thread.
akallabeth [Tue, 5 May 2020 08:31:26 +0000 (10:31 +0200)]
Fixed primary monitor index for wayland fullscreen
akallabeth [Tue, 5 May 2020 08:29:25 +0000 (10:29 +0200)]
Fixed UwacDisplayGetOutput and UwacOutputGetResolution checks
return proper error conditions if arguments are invalid.
Linus Heckemann [Tue, 5 May 2020 06:35:19 +0000 (08:35 +0200)]
shadow_server: allow specifying IP addresses to listen on (#6050)
* shadow_server: allow specifying IP addresses to listen on
This allows using IPv6 as well as listening only on specific
interfaces. Additionally, it enables listening on local and TCP
sockets simultaneously.
* listener: log address with square brackets
This disambiguates IPv6 addresses.
* shadow_server: check error on each socket binding
* Refactored shadow /bind-address for 2.0 compiatibility.
* Made /ipc-socket and /bind-address incompatible arguments.
* Fixed shadow /bind-address handling and description
* Allow multiple bind addresses for shadow server.
Co-authored-by: akallabeth <akallabeth@posteo.net>
akallabeth [Sat, 25 Apr 2020 06:34:08 +0000 (08:34 +0200)]
Fixed compiler warnings for usb channel
akallabeth [Sat, 25 Apr 2020 06:33:45 +0000 (08:33 +0200)]
Fixed index out of bound access in update_glyph_offset
akallabeth [Sat, 25 Apr 2020 06:26:37 +0000 (08:26 +0200)]
Unified INLINE definition
Armin Novak [Mon, 4 May 2020 15:32:55 +0000 (17:32 +0200)]
Silence SCARD_E_TIMEOUT warnings
These occur quite often for status calls, so reduce log verbosity.
akallabeth [Wed, 29 Apr 2020 14:01:52 +0000 (16:01 +0200)]
Fixed various input buffer length checks in URBDRC
Thanks to hac425 CVE-2020-11039
akallabeth [Wed, 29 Apr 2020 13:55:51 +0000 (15:55 +0200)]
Fixed int overflow in smartcard_ndr_read
Thanks to hac425
akallabeth [Wed, 29 Apr 2020 13:49:52 +0000 (15:49 +0200)]
Fixed int overflow in msusb_mspipes_read
Thanks to hac425
akallabeth [Wed, 29 Apr 2020 13:49:09 +0000 (15:49 +0200)]
Fixed int overflow in printer_write_setting
Thanks to hac425
akallabeth [Wed, 29 Apr 2020 13:48:43 +0000 (15:48 +0200)]
Fixed int overflow in PresentationContext_new
Thanks to hac425 CVE-2020-11038
akallabeth [Thu, 23 Apr 2020 09:52:16 +0000 (11:52 +0200)]
Fixed #6112: Segfault in update_decompress_brush
The iterators need to be signed for the loop check to work.
akallabeth [Tue, 21 Apr 2020 08:46:16 +0000 (10:46 +0200)]
Fixed oob read in rfx_process_message_tileset
Check input data length
Thanks to hac425 CVE-2020-11043
akallabeth [Tue, 21 Apr 2020 08:35:17 +0000 (10:35 +0200)]
Fixed oob read in clear_decompress_subcode_rlex
Fixed length checks before stream read.
Thanks to hac425 CVE-2020-11040
akallabeth [Tue, 21 Apr 2020 08:25:47 +0000 (10:25 +0200)]
Fixed oob read in rdpsnd_recv_wave2_pdu
Check format index before using it.
Thanks to hac425 CVE-2020-11041
akallabeth [Tue, 21 Apr 2020 08:23:04 +0000 (10:23 +0200)]
Fixed oob read in update_recv
properly use update_type_to_string to print update type.
Thanks to hac425 CVE-2020-11019
akallabeth [Tue, 21 Apr 2020 08:18:22 +0000 (10:18 +0200)]
update_decompress_brush: explicit output length checks
The output length was just assumed to be >= 256 bytes, with this
commit it is explicitly checked.